Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id

2017-08-08 Thread Larry Finger
On 08/08/2017 11:05 AM, Arvind Yadav wrote: usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Acked-by:

[PATCH] mwifiex: uap: enable 11d based on userspace configruation

2017-08-08 Thread Xinming Hu
From: Xinming Hu This patch check whether userspace beacon data include country ie, if so then download command to enable 11d setup in firmeare accordingly. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo ---

Re: wireless drivers fail to report link speed?

2017-08-08 Thread Dan Williams
On Tue, 2017-08-08 at 16:25 -0600, James Feeney wrote: > Hey Dan > > > ... > > So one second the wifi might be the "best" link and then when > > somebody > > turns on a microwave oven or a baby monitor, it may be the "worst" > > until the microwave's duty cycle completes a few seconds later then

Re: wireless drivers fail to report link speed?

2017-08-08 Thread James Feeney
Hey Dan > ... > So one second the wifi might be the "best" link and then when somebody > turns on a microwave oven or a baby monitor, it may be the "worst" > until the microwave's duty cycle completes a few seconds later then > it'll become the "best" again for a couple seconds then "worst"

Re: wireless drivers fail to report link speed?

2017-08-08 Thread Dan Williams
On Tue, 2017-08-08 at 13:07 -0600, James Feeney wrote: > Hello All > > Would you please look at kernel bug report "Since 4.12 - bonding > module not > working with wireless drivers", and tell me if you know why the > kernel ethtool > does not receive a speed report from the wireless drivers? > >

Re: [PATCH v4 10/10] wil6210: make debugfs compilation optional

2017-08-08 Thread Kalle Valo
Lior David writes: > On 8/8/2017 2:03 PM, Kalle Valo wrote: >> Maya Erez writes: >> >>> From: Gidon Studinski >>> >>> Since debugfs is a kernel configuration option, enable the driver to >>> compile without

RTS threshold not being obeyed

2017-08-08 Thread Jacobo Pantoja
Hi, I'm having a hard time to figure out why RTS/CTS are happening in my network. In a nutshell, I'm using two identical OpenWRT routers to stablish a WDS link (4address mode) in 5GHz, with no other client nor AP in 5GHz. The problem is, a great amount of bandwidth is being consumed by RTS/CTSs.

Re: [PATCH v4 10/10] wil6210: make debugfs compilation optional

2017-08-08 Thread Lior David
On 8/8/2017 2:03 PM, Kalle Valo wrote: > Maya Erez writes: > >> From: Gidon Studinski >> >> Since debugfs is a kernel configuration option, enable the driver to >> compile without debugfs. >> >> Signed-off-by: Gidon Studinski

[PATCH 22/35] wireless: intersil: orinoco: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 2 +-

[PATCH 23/35] wireless: intersil: p54: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/intersil/p54/p54usb.c | 2 +- 1 file

[PATCH 24/35] wireless: marvell: libertas: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- 1

[PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-

[PATCH 25/35] wireless: marvell: libertas_tf: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +-

[PATCH 35/35] wireless: zydas: zd1211rw: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- 1

[PATCH 34/35] wireless: zydas: zd1201: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/zydas/zd1201.c | 2 +- 1 file

[PATCH 28/35] wireless: ralink: rt2500usb: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 2 +- 1

[PATCH 32/35] wireless: realtek: rtl8xxxu: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2

[PATCH 30/35] wireless: ralink: rt73usb: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/ralink/rt2x00/rt73usb.c | 2 +- 1

[PATCH 26/35] wireless: marvell: mwifiex: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/marvell/mwifiex/usb.c | 2 +- 1 file

[PATCH 27/35] wireless: mediatek: mt7601u: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/mediatek/mt7601u/usb.c | 2 +- 1 file

[PATCH 21/35] wireless: broadcom: brcm80211: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 2

[PATCH 20/35] wireless: atmel: at76c50x: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/atmel/at76c50x-usb.c | 2 +- 1 file

[PATCH 19/35] wireless: ath: carl9170: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/ath/carl9170/usb.c | 2 +- 1 file

[PATCH 18/35] wireless: ath: ath9k: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- 1 file

[PATCH 16/35] wireless: ath: ar5523: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/wireless/ath/ar5523/ar5523.c | 2 +- 1 file

Re: [PATCH 30/34] brcmfmac: Correctly handle accesses to SDIO func0

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > Rather than workaround the restrictions on func0 addressing in the > driver, set MMC_QUIRK_LENIENT_FN0 A quirk sounds like a workaround to me, but as it is provided by the mmc stack it trumps a driver solution. Acked-by: Arend van Spriel

Re: [PATCH 31/34] brcmfmac: Remove func0 from function array

2017-08-08 Thread Arend van Spriel
On 08-08-17 13:27, Ian Molton wrote: > On 08/08/17 12:19, Arend van Spriel wrote: > >>> #define brcmf_sdiod_func0_rb(sdiodev, addr, r) \ >>> - sdio_f0_readb((sdiodev)->func[0], (addr), (r)) >>> + sdio_f0_readb((sdiodev)->func[1], (addr), (r)) >> >> There is no reason to keep these any

Re: [PATCH 34/34] brcmfmac: Reduce the noise from repeatedly dereferencing common pointers

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > This introduces no functional changes, but makes the code drastically more > readable, reducing the amount of dereferencing performed inside functions > throughout the SDIO core. > > For example, reduce: > sdio_release_host(bus->sdiodev->func1); > to:

Re: [PATCH 33/34] brcmfmac: Remove array of functions

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > Replace the array of functions with a pair of pointers to the > relevant functions. Acked-by: Arend van Spriel > Signed-off-by: Ian Molton > > # Conflicts: > #

Re: [PATCH 32/34] brcmfmac: Replace function index with function pointer

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > In preparation for removing the function array, remove all code that > refers to function by index and replace with pointers to the function > itself. Reviewed-by: Arend van Spriel > Signed-off-by: Ian Molton

Re: [v3] rt2x00: Fix MMIC Countermeasures

2017-08-08 Thread Kalle Valo
Michael Skeffington wrote: > Set RX_FLAG_DECRYPTED in case of MMIC failure so that > ieee80211_rx_h_decrypt() doesnt drop the frame before getting to > ieee80211_rx_h_michael_mic_verify(). > > Signed-off-by: Michael Skeffington > Acked-by: Stanislaw Gruszka

Re: [v2] rtlwifi: constify rate_control_ops structure

2017-08-08 Thread Kalle Valo
Bhumika Goyal wrote: > rate_control_ops structure is only passed as an argument to the > function ieee80211_rate_control_{register/unregister}. This argument > is of type const, so declare the structure as const. > > Signed-off-by: Bhumika Goyal Patch

Re: [1/2] wlcore: add const to bin_attribute structure

2017-08-08 Thread Kalle Valo
Bhumika Goyal wrote: > Add const to bin_attribute structure as it is only passed to the > functions sysfs_{remove/create}_bin_file. The corresponding arguments > are of type const, so declare the structure to be const. > > Signed-off-by: Bhumika Goyal

Re: brcmfmac: add setting carrier state ON for successful roaming

2017-08-08 Thread Kalle Valo
Wright Feng wrote: > From: Chung-Hsien Hsu > > After association, ping is not working when sweeping the channel at the > AP side. It is caused by having incorrect carrier state (OFF) for the STA > in successful roaming. This patch sets the

Re: [v2, 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode

2017-08-08 Thread Kalle Valo
Wright Feng wrote: > When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, > firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and > probe response. The security type in softAP beacons confuse the > supplicant in client side, and the

Re: [v2] mwifiex: p2p: use separate device address

2017-08-08 Thread Kalle Valo
Xinming Hu wrote: > From: Xinming Hu > > Per below statement about p2p device address in WFA P2P > spec $2.4.3: > > The P2P Device Address of a P2P Device shall be its globally > administered MAC address, or its globally administered MAC > address

Re: [1/2] mwifiex: Do not change bss_num in change_virtual_intf

2017-08-08 Thread Kalle Valo
Xinming Hu wrote: > From: Xinming Hu > > Commit 4d7ab36f0c47 ("mwifiex: Do not change bss_type in > change_virtual_intf") kept original bss_type unchanged. bss_num should > keep the same style, in this way. Unique tuple (bss_type, bss_num) will > be

Re: mwifiex: replace netif_carrier_on/off by netif_device_attach/dettach

2017-08-08 Thread Kalle Valo
Ganapathi Bhat wrote: > Driver is doing netif_carrier_off during suspend, which will set > the IFF_LOWER_UP flag to 0. As a result certain applications > will think this as a real carrier down and behave accordingly. > This will cause issues like loss of IP address, for

Re: [v2,1/8] rsi: add support for rf-kill functionality

2017-08-08 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Pavani Muthyala > > This patch implements rfkill_poll handler. Also, necessary changes > are done in interface up and down handler to support rfkill > functionality. > > Signed-off-by: Pavani Muthyala

Re: bcma: make BCMA a menuconfig to ease disabling it all

2017-08-08 Thread Kalle Valo
Vincent Legoll wrote: > No need to get into the submenu to disable all BCMA-related config entries. > > Signed-off-by: Vincent Legoll Patch applied to wireless-drivers-next.git, thanks. 9ca766b3641f bcma: make BCMA a menuconfig to ease

Re: [PATCH 31/34] brcmfmac: Remove func0 from function array

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > Linux doesnt pass you func0 as a function when probing - instead > providing specific access functions to read/write it. > > This prepares for a patch to remove the actual array entry itself. Reviewed-by: Arend van Spriel >

Re: ath9k: make ath_ps_ops structures as const

2017-08-08 Thread Kalle Valo
Bhumika Goyal wrote: > ath_ps_ops structures are only stored as a reference in the ps_ops > field of a ath_common structure. This field is of type const, so make > the structures as const. > > Signed-off-by: Bhumika Goyal > Signed-off-by: Kalle Valo

Re: [v1] ath10k: Switch to use new generic UUID API

2017-08-08 Thread Kalle Valo
Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. > > Signed-off-by: Andy Shevchenko

Re: [v2] ath10k: fix memory leak in rx ring buffer allocation

2017-08-08 Thread Kalle Valo
Rakesh Pillai wrote: > The rx ring buffers are added to a hash table if > firmware support full rx reorder. If the full rx > reorder support flag is not set before allocating > the rx ring buffers, none of the buffers are added > to the hash table. > > There is a race

Re: [v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()

2017-08-08 Thread Kalle Valo
Gabriel C wrote: > Each time we get disconnected from AP we get flooded with messages like: > > ... > ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! > > ath10k_warn: 155 callbacks suppressed > ... > > Use ath10k_dbg() here too. > > Signed-off-by:

Re: [PATCH v4 10/10] wil6210: make debugfs compilation optional

2017-08-08 Thread Kalle Valo
Maya Erez writes: > From: Gidon Studinski > > Since debugfs is a kernel configuration option, enable the driver to > compile without debugfs. > > Signed-off-by: Gidon Studinski > Signed-off-by: Maya Erez

Re: [PATCH v4 02/10] wil6210: allow configuring scan timers

2017-08-08 Thread Kalle Valo
Maya Erez writes: > From: Hamad Kadmany > > Allow setting scan timeout and scan dwell time > through module parameters. > > Signed-off-by: Hamad Kadmany > Signed-off-by: Maya Erez

ath: Incorrect regDomainPairs/allCountries settings

2017-08-08 Thread Sven Eckelmann
Hi, I just had two inquiries from Vietnam and Singapore regarding the used CTL limits by Atheros based chips. I've checked through the code and noticed that regd_common.h assigns SG to APL6_WORLD and VN to NULL1_WORLD. * SG: APL6_WORLD - 2.4GHz: CTL_ETSI - 5GHz: CTL_ETSI * VN:

Re: Problem with the wifi

2017-08-08 Thread Arend van Spriel
+ linux-wireless + Larry Jesus christ..grow some ears! On 08-08-17 11:21, Paolo Bettini wrote: > Arend van Spriel ha scritto: >> + linux-wireless >> + Larry >> >> please keep linux-wireless in this thread. >> >> On 08-08-17 08:21, Paolo Bettini wrote: >>> Arend van Spriel ha scritto: +

Re: Problem with the wifi

2017-08-08 Thread Arend van Spriel
+ linux-wireless + Larry please keep linux-wireless in this thread. On 08-08-17 08:21, Paolo Bettini wrote: > Arend van Spriel ha scritto: >> + linux-wireless On 07-08-17 21:38, Paolo Bettini wrote: >>> Hi , i am Paolo and i installed Debian stretch on my ezbook2 . One >>> problem is the wifi ,

Re: [PATCH v3] iwlwifi: Demote messages about fw flags size to info

2017-08-08 Thread Coelho, Luciano
On Thu, 2017-08-03 at 07:47 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags than the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the

RE: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-08 Thread Reizer, Eyal
> Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8 > > * Reizer, Eyal [170807 00:47]: > > Hi Tony, > > > > > > * Reizer, Eyal [170807 00:32]: > > > > The following commits: > > > > c815fde wlcore: spi: Populate config firmware data > > > > d776fc8

Re: [PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset

2017-08-08 Thread Chi-Hsien Lin
On 08/07/2017 8:27, Arend van Spriel wrote: On 8/3/2017 11:37 AM, Wright Feng wrote: From: Chi-Hsien Lin Add support for CYW4373 SDIO/USB chipset. CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support. It's a WiFi/BT combo device. Reviewed-by:

Re: [PATCH v3] rt2x00: Fix MMIC Countermeasures

2017-08-08 Thread Stanislaw Gruszka
On Mon, Aug 07, 2017 at 12:47:36PM -0400, Michael Skeffingfon wrote: > Set RX_FLAG_DECRYPTED in case of MMIC failure so that > ieee80211_rx_h_decrypt() doesnt drop the frame before getting to > ieee80211_rx_h_michael_mic_verify(). > > Signed-off-by: Michael Skeffington Acked-by: