[PATCH 4/9] brcmfmac: initialize variable in brcmf_sdiod_regrl()

In case of an error the variable returned is uninitialized. The caller will probably check the error code before using it, but better assure it is set to zero. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts

[PATCH 6/9] brcmfmac: remove unnecessary null pointer check

From: Hante Meuleman in the function brcmf_bus_start() in the exception handling a check is made to dermine whether ifp is null, though this is not possible. Removing the unnessary check. Reviewed-by: Arend Van Spriel Reviewed-by:

[PATCH 0/9] brcmfmac: coverity fixes

This series consist of: * fixes for several issues found by Coverity. * ignore 802.11d configuration if not supported in firmware. * remove worker from netdev callback. This is intended for 4.9 and applies to the master branch of the wireless-drivers-next repository. Arend van Spriel (4):

[PATCH 1/9] brcmfmac: ignore 11d configuration errors

From: Hante Meuleman 802.11d is not always supported by firmware anymore. Currently the AP configuration of 11d will cause an abort if the ioctl set is failing. This behavior is not correct and the error should be ignored. Reviewed-by: Arend Van Spriel

[PATCH 5/9] brcmfmac: remove worker from .ndo_set_mac_address() callback

As it turns out there is no need to use a worker for the callback because it is not called from atomic context. Reported-by: Dan Williams Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts

[PATCH 8/9] brcmfmac: fix out of bound access on clearing wowl wake indicator

From: Hante Meuleman Clearing the wowl wakeindicator happens with a rather odd construction where the string "clear" is used to set the iovar wowl_wakeind. This was implemented incorrectly as it caused an out of bound access. Use an intermediate variable of correct

[PATCH 7/9] brcmfmac: fix clearing entry IPv6 address

From: Hante Meuleman When IPv6 address is to be cleared there is a possible out of bound access. But also the clearing of the last entry and the adjustment of total number of stored IPv6 addresses is not updated. This patch fixes that bug. Bug was found using

[PATCH 2/9] brcmfmac: rework pointer trickery in brcmf_proto_bcdc_query_dcmd()

The variable info is assigned to point to bcdc->msg[1], which is the same as pointing to bcdc->buf. As that is what we want to access make it clear by fixing the assignment. This also avoid out-of-bounds errors from static analyzers are bcdc->msg[1] is not in the structure definition.

[PATCH 9/9] brcmfmac: simplify mapping of auth type

From: Hante Meuleman The 802.11 standard only has four valid auth type configurations of which our firmware only supports two, ie. Open System and Shared Key. Simplify the mapping falling back to automatic for other types specified by user-space. Reviewed-by: Arend

[PATCH 3/9] brcmfmac: fix memory leak in brcmf_flowring_add_tdls_peer()

In the error paths in brcmf_flowring_add_tdls_peer() the allocated resource should be freed. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel ---

Re: ath10k inoperatable after suspend

On 19 September 2016 at 00:52, Steffen Arntz wrote: > Hi at all, > > I have an QCA988X based card in my laptop and have some "issues" with > it, that I was not experiencing with my previous ath9k based card. > > The main issue is, that after suspend to RAM the card seems to

Re: [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 18:58 +0800, Herbert Xu wrote: > v3 fixes a bug in the remove path that causes the element count > to decrease when it shouldn't, leading to a gigantic hash table > when it underflows. > Ok, with the BUG_ON() thrown in, this works in the test that was failing before. I'll

Re: ath10k mesh mode issue

On 16 September 2016 at 12:56, Matteo Grandi wrote: > Hello all, [...] > [8.589474] ath10k_pci :07:00.0: qca988x hw2.0 (0x4100016c, > 0x043222ff sub :) fw 10.2.4.70.54 fwapi 5 bdapi 1 htt-ver 2.1 > wmi-op 5 htt-op 2 cal otp max-sta 128 raw 0 hwcrypto 1

[PATCH] rsi: fix memory leak in debugfs entry and supported bands

From: Prameela Rani Garnepudi Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [athk9] beacon.c:642 ath9k_calculate_summary_state dump

On Sat, Sep 17, 2016 at 3:29 PM, Kalle Valo wrote: > Vidar Haarr writes: >> sep. 17 11:38:36 edbpc kernel: WARNING: CPU: 0 PID: 1684 at >> /home/kernel/COD/linux/drivers/net/wireless/ath/ath9k/beacon.c:642 >>

Re: [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 13:03 +0200, Johannes Berg wrote: > On Mon, 2016-09-19 at 18:58 +0800, Herbert Xu wrote: > > > > v3 fixes a bug in the remove path that causes the element count > > to decrease when it shouldn't, leading to a gigantic hash table > > when it underflows. > > > Ok, with the

staging: wilc1000: kernel Oops while opening the device

Hi all, While using the wilc1000 driver with latest 4.8-rc7, I have difficulties to open the device and actually use it as I have this kernel Oops right after the loading of the firmware (wilc1003_firmware.bin). If I revert back the driver to its b9811891a9f60ca9c314dcab3244c65930c4cf37 state,

pull-request: iwlwifi-next 2016-09-19

Hi Kalle, Here we go again, now I'm almost catching up with the pending stuff in our internal tree, just in time for 4.9.  This pull contains a bunch of fixes to DQA and new HW support code, a few new features and some cleanups.  More details in the tag description. Let me know if everything's

[PATCH 15/25] iwlwifi: mvm: document passing unexpected Block Ack Request frames

From: Johannes Berg When we get an unexpected Block Ack Request frame, the BAID from the hardware will be invalid, and we'll pass it to mac80211 for further handling (sending a delBA action frame.) Add a comment explaining that, in case anyone looks in the future.

[PATCH 13/25] iwlwifi: mvm: make iwl_mvm_update_sta() an inline

From: Johannes Berg There's no point in making this an out-of-line function since it just calls a single other function with a few changed parameters. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 14/25] iwlwifi: move to wide ID for all commands

From: Sara Sharon Due to firmware design considerations, move to wide ID for all commands. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-notif-wait.c | 8 ++--

[PATCH 18/25] iwlwifi: migrate to devm_* API

From: Sharon Dvir Change PCIE and trans resource allocations to managed resources. Signed-off-by: Sharon Dvir Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 8 +--

[PATCH 17/25] iwlwifi: mvm: disable P2P queue on mac context release

From: Sara Sharon AP queue is properly released, but P2P queue isn't. Fixes: commit 4c965139a3cd ("iwlwifi: mvm: support p2p device frames tx on dqa queue #2") Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH 22/25] iwlwifi: mvm: Add mem debugfs entry

From: Ido Yariv In order to access cached/paged memory, there are a couple of firmware commands (one for UMAC and one for LMAC) that let the host access memory and registers indirectly. Since this is done by the firmware on behalf of the host, even if memory is paged out or

[PATCH 06/25] iwlwifi: check for valid ethernet address provided by OEM

From: Haim Dreyfuss In 9000 family products we added an option to let the OEM fuse the mac address via registers. If these registers are zeroed we use the OTP address instead. Make sure that the address provided by the OEM is valid and, if not, fall back to the OTP

[PATCH 09/25] iwlwifi: mvm: Add support for RRM by scan

From: Avrahams Stern Implement support for RRM by adding an option to configure the scan dwell time and reporting scan start time and BSS detection time, and Advertise support for these features. Signed-off-by: David Spinadel Signed-off-by:

[PATCH 24/25] iwlwifi: mvm: use LIST_HEAD() macro

From: Johannes Berg There's no need to declare a list and then init it manually, just use the LIST_HEAD() macro. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 20/25] iwlwifi: add new 8265 series PCI ID

From: Oren Givon Add a new PCI ID for the 8265 series. Signed-off-by: Oren Givon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 12/25] iwlwifi: pcie: log full command sequence

From: Sara Sharon Log group as well. Remove 0x prefix to match TX logging. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 5 +++-- 1 file changed, 3

[PATCH 05/25] iwlwifi: mvm: add support for MU-MIMO air sniffer

From: Aviya Erenfeld enable MU-MIMO air sniffer if it's supported by the NIC Signed-off-by: Aviya Erenfeld Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 8 1 file

[PATCH 08/25] iwlwifi: mvm: support BAR in reorder buffer

From: Sara Sharon On default queue we will not receive frame release notification, but the BAR itself. Upon receiving the BAR driver should look at the NSSN and adjust window accordingly. Fixes: b915c10174fb ("iwlwifi: mvm: add reorder buffer per queue") Signed-off-by:

[PATCH 07/25] iwlwifi: mvm: fix DQA AP mode station assumption

From: Sara Sharon There was recently a Full AP mode feature added where hostap adds the station at auth stage, and not assoc. However, when running with legacy hostapd, we get the auth response before station was added, and tx_skb_non_sta fails to allocate a queue,

[PATCH 16/25] iwlwifi: don't export trace points that are used in iwlwifi only

From: Emmanuel Grumbach This can save a few bytes Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH 19/25] iwlwifi: mvm: Add debugfs function for clocks diff

From: Roee Zamir New function, reveals the diff between gp2 and host time. Signed-off-by: Roee Zamir Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/mvm/debugfs-vif.c | 26 ++ 1 file

[PATCH 10/25] iwlwifi: mvm: support packet injection

From: Sara Sharon For automatic testing packet injection can be useful. Support injection through debugfs. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 55

[PATCH 04/25] iwlwifi: mvm: compare full command ID

From: Johannes Berg When comparing command IDs, the group should be taken into account so the same command/notification from a different group doesn't trigger anything unexpected. Fix this by comparing to the wide ID. Fixes: commit 1738d60b31d7 ("iwlwifi: mvm: handle RX

RE: [PATCH v2 1/9] cfg80211: add start / stop NAN commands

> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 21:54 > To: Otcheretianski, Andrei ; Luca Coelho > ; johan...@sipsolutions.net > Cc: linux-wireless@vger.kernel.org;

[PATCH 21/25] iwlwifi: mvm: move AP-specific code to right function

From: Johannes Berg There's no need for the common MAC context function to have an if on AP mode, the values can be overridden in the AP-specific function later. Clean that up by adding the full command as a new parameter to the AP-specific function, and doing it there.

[PATCH 11/25] iwlwifi: move BIOS MCC retrieval to common code

From: Arik Nemtsov This will be used by more than MVM, so move it to iwlwifi While at it, rename WRD_METHOD to the more appropriate WRDD_METHOD and add some documentation. Signed-off-by: Arik Nemtsov Signed-off-by: Johannes Berg

[PATCH 23/25] iwlwifi: mvm: set HCMD_NAME for PHY_DB as well

From: Sara Sharon Currently it is logged as UNKNOWN. Also, 0x6c seems to be the permanent ID for this command, remove incorrect comment and uncomment the command from the commands list. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho

[PATCH 25/25] iwlwifi: pcie: use LIST_HEAD() macro

From: Johannes Berg There's no need to declare a list and then init it manually, just use the LIST_HEAD() macro. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH] cfg80211: add checks for beacon rate, extend to mesh

From: Johannes Berg The previous commit added support for specifying the beacon rate for AP mode. Add features checks to this, and extend it to also support the rate configuration for mesh networks. For IBSS it's not as simple due to joining etc., so that's not yet

Re: ath10k mesh + ap + encryption?

On Tuesday, September 13, 2016 5:54:38 PM CEST Pedersen, Thomas wrote: > On Tue, 2016-09-13 at 14:30 +0200, Simon Wunderlich wrote: > > > [...] > > > > Thanks for the clarification. We will then stick to the 70's branch > > then. > > > > Does anyone have pointers for the other questions? :) I

[PATCH 01/25] iwlwifi: mvm: remove variable shadowing

From: Liad Kaufman Variable "ac" defined twice. Fix that. Fixes: commit 93f436e2c7fe ("iwlwifi: mvm: set sta_id in SCD_QUEUE_CONFIG cmd") Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho ---

[PATCH 03/25] iwlwifi: mvm: cleanup skb queue functions use

From: Sara Sharon Use skb_queue_empty() and not skb_peek_tail() to check for empty list. Avoid a redundant check as well - loop will take care of it. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, Sep 19, 2016 at 12:10:27PM +0200, Johannes Berg wrote: > Btw, for debug I put > > BUG_ON(atomic_read(>nelems) < 0); > > after the atomic_dec() in __rhashtable_remove_fast_one(). That makes > the kernel crash instantly on the buggy code, and I just have to run a > single test

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 18:48 +0800, Herbert Xu wrote: > On Mon, Sep 19, 2016 at 12:10:27PM +0200, Johannes Berg wrote: > > > > Btw, for debug I put > > > > BUG_ON(atomic_read(>nelems) < 0); > > > > after the atomic_dec() in __rhashtable_remove_fast_one(). That > > makes > > the kernel crash

[v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects

v3 fixes a bug in the remove path that causes the element count to decrease when it shouldn't, leading to a gigantic hash table when it underflows. v2 contains a reworked insertion slowpath to ensure that the spinlock for the table we're inserting into is taken. This series contains two patches.

[v3 PATCH 1/2] rhashtable: Add rhlist interface

The insecure_elasticity setting is an ugly wart brought out by users who need to insert duplicate objects (that is, distinct objects with identical keys) into the same table. In fact, those users have a much bigger problem. Once those duplicate objects are inserted, they don't have an interface

[v3 PATCH 2/2] mac80211: Use rhltable instead of rhashtable

mac80211 currently uses rhashtable with insecure_elasticity set to true. The latter is because of duplicate objects. What's more, mac80211 walks the rhashtable chains by hand which is broken as rhashtable may contain multiple tables due to resizing or rehashing. This patch fixes it by

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

On 09/19/2016 02:00 AM, Johannes Berg wrote: Actually, can you apply the v2 (cfg80211: add bitrate for 20MHz MCS 9) of this? Systems guys confirmed they use MCS 9 @ 20MHz when LDPC is enabled. Also confirmed bitrate should be ok. I don't really understand that. How can the bitrate be "OK"

Re: Problem with 40Mhz on 2.5GHz with Intel 8260

Hi, On Mon, Sep 19, 2016 at 5:00 PM, Volker Mische wrote: > Hi, > > I'm having connectivity issues with an Intel 8260 on a 2.5GHz network > when using 40Mhz. I'm getting errors like > > Queue 2 stuck for 1 ms. > > I've upgrade my system to the firmware version 21

Re: [v3 PATCH 1/2] rhashtable: Add rhlist interface

On Mon, Sep 19, 2016 at 11:16:21PM +0200, Thomas Graf wrote: > > Nice, I like how this simplifies users! Is this suitable for > ILA as well? Does it have duplicate objects and use inelastic_security? If so then yes it should switch over to rhlist. Cheers, -- Email: Herbert Xu

[PATCH] ath10k: fix debug cal data file

It got broken by 0b8e3c4ca29fe2c0efd3d41a76e34a657b9f17a4 Signed-off-by: Nikolay Martynov --- drivers/net/wireless/ath/ath10k/debug.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c

Re: brcmfmac MAC address change delay and 500ms down delay

On Fri, 2016-09-16 at 11:58 +0200, Arend Van Spriel wrote: > On 15-9-2016 16:42, Dan Williams wrote: > > > > Hi, > > > > While refining NetworkManager's MAC address randomization behavior > > we > > came across two issues with brcmfmac: > > > > 1) when changing the MAC address, the driver

Problem with 40Mhz on 2.5GHz with Intel 8260

Hi, I'm having connectivity issues with an Intel 8260 on a 2.5GHz network when using 40Mhz. I'm getting errors like Queue 2 stuck for 1 ms. I've upgrade my system to the firmware version 21 (21.373438.0) and Kernel 4.8.0-rc6 in hope that it fixes the issue and to be able to debug the

Re: [PATCH] rsi: fix memory leak in debugfs entry and supported bands

On 09/19/2016 12:51 PM, Prameela Rani Garnepudi wrote: > From: Prameela Rani Garnepudi > > Signed-off-by: Prameela Rani Garnepudi > --- > drivers/net/wireless/rsi/rsi_91x_mac80211.c | 10 ++ > 1 file changed,

[PATCH V2] rtl8xxxu: Stop log spam from each successful interrupt

As soon as debugging is turned on, the logs are filled with messages reporting the interrupt status. As this quantity is usually zero, this output is not needed. In fact, there will be a report if the status is not zero, thus the debug line in question could probably be deleted. Rather than taking

nl80211 fine timing measurement support

Hi Johannes, We are working on adding indoor location support to the wil6210 11ad driver. This includes fine timing measurement (FTM) as well as something we call angle of arrival (AOA) which measures azimuth and elevation. Initially we implemented it internally using vendor commands but we

Re: [PATCH 0/9] brcmfmac: coverity fixes

On 09/19/2016 04:09 AM, Arend van Spriel wrote: > This series consist of: > * fixes for several issues found by Coverity. > * ignore 802.11d configuration if not supported in firmware. > * remove worker from netdev callback. Thanks for doing this, can you also provide the coverity id when

Re: nl80211 fine timing measurement support

On 19-9-2016 19:31, Lior David wrote: > Hi Johannes, > > We are working on adding indoor location support to the wil6210 11ad driver. > This includes fine timing measurement (FTM) as well as something we call > angle of arrival (AOA) which measures azimuth and elevation. > Initially we

Re: brcmfmac MAC address change delay and 500ms down delay

On 19-9-2016 16:48, Dan Williams wrote: > On Fri, 2016-09-16 at 11:58 +0200, Arend Van Spriel wrote: >> On 15-9-2016 16:42, Dan Williams wrote: >>> >>> Hi, >>> >>> While refining NetworkManager's MAC address randomization behavior >>> we >>> came across two issues with brcmfmac: >>> >>> 1) when

RTL8192EU on rtl8xxxu driver breaks every few minutes

Hi, I happen to own a RTL8192EU WiFi dongle which is marked as untested by the rtl8xxxu driver. I'm on a linux from scratch system using kernel 4.7.3 and wpa_supplicant 2.5. The dongle appears to connect and work fine, but after around 10 minutes it deauthenticates and enters and endless loop of

Re: nl80211 fine timing measurement support

> > However I did not see any comments or response on this > > patch. Can you please update if you plan on eventually submitting > > this patch? > > You can find several FTM related patches in backport-iwlwifi repo on > kernel.org. See link to git log of nl80211.h there [1]. > You can find

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Sunday, September 18, 2016 6:44:08 PM CEST Greg KH wrote: > On Sun, Sep 18, 2016 at 02:49:33PM +0200, Christian Lamparter wrote: > > On Sunday, September 18, 2016 12:14:55 PM CEST Greg KH wrote: > > > On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote: > > > > Greg KH

RE: [PATCH v2 4/9] cfg80211: allow the user space to change current NAN configuration

> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 22:43 > To: Luca Coelho ; johan...@sipsolutions.net > Cc: linux-wireless@vger.kernel.org; Beker, Ayala ; > Otcheretianski, Andrei

[v2 PATCH 2/2] mac80211: Use rhltable instead of rhashtable

mac80211 currently uses rhashtable with insecure_elasticity set to true. The latter is because of duplicate objects. What's more, mac80211 walks the rhashtable chains by hand which is broken as rhashtable may contain multiple tables due to resizing or rehashing. This patch fixes it by

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

> Actually, can you apply the v2 (cfg80211: add bitrate for 20MHz MCS > 9) of this? Systems guys confirmed they use MCS 9 @ 20MHz when LDPC > is enabled. Also confirmed bitrate should be ok. I don't really understand that. How can the bitrate be "OK" when the spec explicitly says it cannot be

Re: [PATCH 4/4] ath10k: fix spurious tx/rx during boot

On 17 September 2016 at 00:37, Hsu, Ryan wrote: [...] >> + /* WMI and HTT may use separate HIF pipes and are not guaranteed to be >> + * serialized properly implicitly. >> + * >> + * Moreover (most) WMI commands have no explicit acknowledges. It is >>

RE: [PATCH v2 3/9] cfg80211: add add_nan_func / rm_nan_func

> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 22:29 > To: Luca Coelho ; johan...@sipsolutions.net > Cc: linux-wireless@vger.kernel.org; Beker, Ayala ; > Otcheretianski, Andrei

Re: [PATCH] NFC: Delete owner assignment

Hi Markus, On Mon, Aug 15, 2016 at 09:12:29AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Aug 2016 09:00:26 +0200 > > The field "owner" is set by core. Thus delete an extra initialisation. > > Generated by:

Re: TCP data throughput for BCM43362

Hi Arend, On Wed, 2016-09-14 at 20:13 +0200, Arend Van Spriel wrote: > On 14-9-2016 15:41, Jörg Krause wrote: > > > > Hi, > > > > On Mon, 2016-08-29 at 23:15 +0200, Jörg Krause wrote: > > > > > > On Mi, 2016-08-24 at 20:35 +0200, Arend Van Spriel wrote: > > > > > > > > > > > > On 22-8-2016

[PATCH v2 19/25] iwlwifi: mvm: Add debugfs function for clocks diff

From: Roee Zamir New function, reveals the diff between gp2 and host time. Signed-off-by: Roee Zamir Signed-off-by: Luca Coelho --- Sorry, I was missing a compilation flag in my .config and missed a compilation error

Re: [PATCH] NFC: pn533: constify pn533_phy_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 06:11:02PM +0200, Julia Lawall wrote: > The pn533_phy_ops are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/pn533/i2c.c |2 +- >

Re: [PATCH] NFC: nfcmrvl: constify nfcmrvl_if_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 07:03:50PM +0200, Julia Lawall wrote: > The nfcmrvl_if_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/nfcmrvl/i2c.c |2 +-

[v2 PATCH 1/2] rhashtable: Add rhlist interface

The insecure_elasticity setting is an ugly wart brought out by users who need to insert duplicate objects (that is, distinct objects with identical keys) into the same table. In fact, those users have a much bigger problem. Once those duplicate objects are inserted, they don't have an interface

pull-request: iwlwifi-next 2016-09-19-2

Hi Kalle, Please drop my previous pull-request.  There was a compilation error that I missed to due a missing flag in my .config.  I fixed it now and this is the new pull request that includes the fix. Here we go again, now I'm almost catching up with the pending stuff in our internal tree, just

Re: [PATCH 0/2] rhashtable: rhashtable with duplicate objects

> > I take that back. I think it's leaking memory - my tests never used > > to run out of memory, but now they eventually do. > > > I'll try to figure out more. > > Interesting.  The kernel test robot found a bug in the insertion > slowpath where we end up inserting without taking the inner

RE: [PATCH v2 3/9] cfg80211: add add_nan_func / rm_nan_func

> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 22:54 > To: Luca Coelho ; johan...@sipsolutions.net > Cc: linux-wireless@vger.kernel.org; Beker, Ayala ; > Otcheretianski, Andrei

Re: [PATCH 0/2] rhashtable: rhashtable with duplicate objects

> OK, it's finally ready now. > > This series contains one two patches.  The first adds the rhlist > interface and the second converts mac80211 to use it.  If this works > out I'll then proceed to convert the other insecure_elasticity > users over to this. Thanks a lot Herbert! > I've tested

Re: [PATCH 0/2] rhashtable: rhashtable with duplicate objects

> Yes, it's passing all the wpa_supplicant tests, so > > Acked-by: Johannes Berg > I take that back. I think it's leaking memory - my tests never used to run out of memory, but now they eventually do. I'll try to figure out more. johannes

Re: [PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, Sep 19, 2016 at 10:25:18AM +0200, Johannes Berg wrote: > > > Yes, it's passing all the wpa_supplicant tests, so > > > > Acked-by: Johannes Berg > > > > I take that back. I think it's leaking memory - my tests never used to > run out of memory, but now they

[v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

v2 contains a reworked insertion slowpath to ensure that the spinlock for the table we're inserting into is taken. This series contains one two patches. The first adds the rhlist interface and the second converts mac80211 to use it. If this works out I'll then proceed to convert the other

RE: [PATCH v2 6/9] cfg80211: Provide an API to report NAN function termination

> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 23:00 > To: Luca Coelho ; johan...@sipsolutions.net > Cc: linux-wireless@vger.kernel.org; Beker, Ayala ; > Otcheretianski, Andrei

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 16:40 +0800, Herbert Xu wrote: > I've tested the rhlist code with test_rhashtable but I haven't > tested the mac80211 conversion.  So please give it a go and see > if it still works. This is still running out of memory on my test suite. Somehow I don't see kmemleak kicking

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, Sep 19, 2016 at 11:15:30AM +0200, Johannes Berg wrote: > On Mon, 2016-09-19 at 16:40 +0800, Herbert Xu wrote: > > > I've tested the rhlist code with test_rhashtable but I haven't > > tested the mac80211 conversion.  So please give it a go and see > > if it still works. > > This is still

Re: [v3 PATCH 1/2] rhashtable: Add rhlist interface

On 09/19/16 at 07:00pm, Herbert Xu wrote: > The insecure_elasticity setting is an ugly wart brought out by > users who need to insert duplicate objects (that is, distinct > objects with identical keys) into the same table. > > In fact, those users have a much bigger problem. Once those >

Re: [PATCH] mwifiex: parse device tree node for PCIe

On Fri, Sep 09, 2016 at 08:47:34PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework. > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > marvell-8xxx.txt) to accomodate PCIe changes. > >

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

> What does your test suite actually do? Is it something that I > can run without special hardware? Yes, it's pretty simple - it spins up a number of VMs with hwsim and just runs a lot of tests: https://w1.fi/cgit/hostap/tree/tests/hwsim I've attached a kernel .config you can use for it. I'm

Re: [OpenWrt-Devel] ath10k mesh + ap + encryption?

On Montag, 19. September 2016 08:43:56 CEST Simon Wunderlich wrote: [...] > > We're testing encrypted AP + Mesh quite successfully right now with > > this firmware: https://github.com/kvalo/ath10k-firmware/commit/307cb46b > > 06661ebd3186723b5002de769c7add83, of course that is for a QCA4019 chip.

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, Sep 19, 2016 at 11:27:24AM +0200, Johannes Berg wrote: > > I have a feeling there's a bug with ht->nelems, since the crash is > always in the grow worker, but I haven't quite put my finger on it yet. Can you show me a stack trace? Thanks, -- Email: Herbert Xu

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 17:34 +0800, Herbert Xu wrote: > On Mon, Sep 19, 2016 at 11:27:24AM +0200, Johannes Berg wrote: > > > > > > I have a feeling there's a bug with ht->nelems, since the crash is > > always in the grow worker, but I haven't quite put my finger on it > > yet. > > Can you show

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

> The stack trace is useless, but my other annotation showed that the > table's nelems *underflowed* to -1, so now the worker will continue > to try to grow it forever. > And this *was* actually a case of duplication, afaict, since it was multiple virtual interfaces on the same device all

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 11:54 +0200, Johannes Berg wrote: > > > > The stack trace is useless, but my other annotation showed that the > > table's nelems *underflowed* to -1, so now the worker will continue > > to try to grow it forever. > > > > And this *was* actually a case of duplication,

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

On 19-9-2016 11:00, Johannes Berg wrote: > >> Actually, can you apply the v2 (cfg80211: add bitrate for 20MHz MCS >> 9) of this? Systems guys confirmed they use MCS 9 @ 20MHz when LDPC >> is enabled. Also confirmed bitrate should be ok. > > I don't really understand that. How can the bitrate

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 11:27 +0200, Johannes Berg wrote: > >  > I have a feeling there's a bug with ht->nelems, since the crash is > always in the grow worker, but I haven't quite put my finger on it > yet. > Btw, I should not actually get into the duplicate case here. johannes

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 17:34 +0800, Herbert Xu wrote: > On Mon, Sep 19, 2016 at 11:27:24AM +0200, Johannes Berg wrote: > > > > > > I have a feeling there's a bug with ht->nelems, since the crash is > > always in the grow worker, but I haven't quite put my finger on it > > yet. > > Can you show

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

On Mon, 2016-09-19 at 12:02 +0200, Johannes Berg wrote: > On Mon, 2016-09-19 at 11:54 +0200, Johannes Berg wrote: > > > > > > > > > > > The stack trace is useless, but my other annotation showed that > > > the > > > table's nelems *underflowed* to -1, so now the worker will > > > continue > > >

Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects

Btw, for debug I put BUG_ON(atomic_read(>nelems) < 0); after the atomic_dec() in __rhashtable_remove_fast_one(). That makes the kernel crash instantly on the buggy code, and I just have to run a single test ("wpas_ctrl_interface_add_many") to get there. johannes