Re: [v5] wlcore: add missing nvs file name info for wilink8

* Reizer, Eyal [170807 00:47]: > Hi Tony, > > > > * Reizer, Eyal [170807 00:32]: > > > The following commits: > > > c815fde wlcore: spi: Populate config firmware data > > > d776fc8 wlcore: sdio: Populate config firmware data > > > > > > Populated the nvs entry for

[PATCH 1/2] wireless-regdb: Update regulatory document references for Taiwan (TW)

Taiwan's Ministry of Transportation and Communications updated its frequency allocation rules again on 2017/02/22. The amended articles are not related to this database, but the link should be kept up to date, as the old one is no longer accessible. Taiwan's regulatory body, NCC, published its

[PATCH 2/2] wireless-regdb: Add 60 GHz rule for Taiwan (TW)

The latest low power radio frequency devices technical regulations [1] released by Taiwan's regulatory body, NCC, opens up 57 GHz ~ 66 GHz to most devices, including WiGig. [1] LP0002 Low-power Radio-frequency Devices Technical Regulations 2016/8/23

[PATCH v2 0/2] prism54: move to staging

Greg, This v2 adds the TODO you requested to clarify prism54 will be removed in two kernel releases from now, and so no further cleanup is needed other than to ensure the driver compiles. This is based on linux-next tag next-20170807. Luis Luis R. Rodriguez (2): wireless: move prism54 out

[PATCH v2 2/2] MAINTAINERS: update email address for mcgrof for few straggling drivers

This will ensure I get emails on my work and personal email address. Signed-off-by: Luis R. Rodriguez --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3deaddc8c578..997b8062397a 100644 --- a/MAINTAINERS

[PATCH v2 1/2] wireless: move prism54 out to staging

prism54 is deprecated in favor of the p54pci device driver. Although only *one soul* had reported issues with it long ago Linux most Linux distributions these days just disable the device driver given the conflicts with the PCI IDs of p54pci and the *very* unlikely situation of folks really need

Re: Problem with the wifi

+ linux-wireless On 07-08-17 21:38, Paolo Bettini wrote: > Hi , i am Paolo and i installed Debian stretch on my ezbook2 . One > problem is the wifi , the card a SDIO device , seems to be 02d0:a9a6 > linux id or Broadcom AP6212 for windowsi installed deb package > firmware-brcm80211 and nvram

Re: [PATCH 13/34] brcmfmac: Tidy register definitions a little

On 26-07-17 22:25, Ian Molton wrote: > Trivial tidy of register definitions. Initially skipped this one, but it is indeed trivial. Reviewed-by: Arend van Spriel > Signed-off-by: Ian Molton comment below... > --- >

Re: pull-request: wireless-drivers-next 2017-08-07

From: Kalle Valo Date: Mon, 07 Aug 2017 17:55:40 +0300 > here's the first pull request to net-next for 4.14, more info in the > signed tag below. This time there's a simple conflict in iwlwifi but > you can fix it just like Stephen did: > >

Re: [PATCH 12/34] brcmfmac: Replace old IO functions with simpler ones.

On 07/08/17 12:26, Arend van Spriel wrote: > On 7/26/2017 10:25 PM, Ian Molton wrote: >> Primarily this patch removes: >> >> brcmf_sdiod_f0_writeb() >> brcmf_sdiod_reg_write() >> brcmf_sdiod_reg_read() > > Having [patch 30/34] "brcmfmac: Correctly handle accesses to SDIO func0" > before this

Re: [PATCH 07/34] brcmfmac: Remove brcmf_sdiod_request_data()

On 07/08/17 12:25, Arend van Spriel wrote: >> Handling of -ENOMEDIUM is altered, but as that's pretty much broken >> anyway >> we can ignore that. > > Please explain why you think it is broken. Not got the code to hand right now, but from memory, theres a trapdoor case where the state can wind

Re: [PATCH 03/34] brcmfmac: Split brcmf_sdiod_regrw_helper() up.

On 07/08/17 12:25, Arend van Spriel wrote: > On 26-07-17 22:25, Ian Molton wrote: >> This large function is concealing a LOT of obscure logic about >> how the hardware functions. Time to split it up. >> >> This first patch splits the function into two pieces - read and write, >> doing away

Re: [PATCH v2] rt2x00: Fix MMIC Countermeasures.

Sorry about that, I work on other projects that use spaces and I must have missed that when double checking the patch. I sent out a new patch with the correct line length, removal of trailing '.' and indentation fix. On Mon, Aug 7, 2017 at 2:31 AM, Stanislaw Gruszka wrote:

[PATCH v3] rt2x00: Fix MMIC Countermeasures

Set RX_FLAG_DECRYPTED in case of MMIC failure so that ieee80211_rx_h_decrypt() doesnt drop the frame before getting to ieee80211_rx_h_michael_mic_verify(). Signed-off-by: Michael Skeffington --- drivers/net/wireless/ralink/rt2x00/rt2800mmio.c | 13 +++--

pull-request: wireless-drivers-next 2017-08-07

Hi Dave, here's the first pull request to net-next for 4.14, more info in the signed tag below. This time there's a simple conflict in iwlwifi but you can fix it just like Stephen did: https://lkml.kernel.org/r/20170804120408.0d147...@canb.auug.org.au Please let me know if you have any

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

On Mon, 2017-08-07 at 16:37 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote: > > > Luca Coelho writes: > > > > > > > From: Christophe Jaillet > > > > > > > > We should free

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

Luca Coelho writes: > On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > From: Christophe Jaillet >> > >> > We should free 'wgds.pointer' here as done a few lines above in another >> > error

Re: [PATCH 04/19] iwlwifi: mvm: add debugfs to force CT-kill

Luca Coelho writes: > On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > From: Chaya Rachel Ivgi >> > >> > In order to test the enter/exit CT-kill flow. >> > >> > Signed-off-by: Chaya Rachel Ivgi

Re: [PATCH 04/19] iwlwifi: mvm: add debugfs to force CT-kill

On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Chaya Rachel Ivgi > > > > In order to test the enter/exit CT-kill flow. > > > > Signed-off-by: Chaya Rachel Ivgi > > Signed-off-by:

Re: [PATCH 12/19] iwlwifi: mvm: support new beacon template command

Luca Coelho writes: > From: Haim Dreyfuss > > Support new version of beacon template command. This rplaces v8 command typo: "rplaces" -- Kalle Valo

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Christophe Jaillet > > > > We should free 'wgds.pointer' here as done a few lines above in another > > error handling path. > > It was allocated within

Re: [PATCH 04/19] iwlwifi: mvm: add debugfs to force CT-kill

Luca Coelho writes: > From: Chaya Rachel Ivgi > > In order to test the enter/exit CT-kill flow. > > Signed-off-by: Chaya Rachel Ivgi > Signed-off-by: Luca Coelho The commit log doesn't explain

Re: [PATCH 00/10] mac80211 patches from our internal tree 2017-08-05

Luca Coelho writes: > On Mon, 2017-08-07 at 12:06 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > Here are some pending mac80211 patches from our internal tree. >> > >> > The "mac80211: add api to start ba session timer expired flow" patch >> > is

Re: [PATCH 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged

Luca Coelho writes: > From: Avraham Stern > > Under DQA, when tx is deferred because a queue needs to be allocated, > the mac queue for that TID is stopped until the new stream is added. > If at this point the station that this stream belongs to is

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

Luca Coelho writes: > From: Christophe Jaillet > > We should free 'wgds.pointer' here as done a few lines above in another > error handling path. > It was allocated within 'acpi_evaluate_object()'. > > Fixes: c52030a01ccc ("iwlwifi: mvm: add

Re: [PATCH] brcmfmac: add setting carrier state ON for successful roaming

On 8/7/2017 10:16 AM, Wright Feng wrote: From: Chung-Hsien Hsu After association, ping is not working when sweeping the channel at the AP side. It is caused by having incorrect carrier state (OFF) for the STA in successful roaming. This patch sets the carrier state ON

Re: [PATCH v2 09/12] qtnfmac: implement scan timeout

Sergey Matyukevich writes: >> > + if (timer_pending(>scan_timeout)) >> > + del_timer_sync(>scan_timeout); >> >> What if the device is removed while the timer is pending, is that >> handled? > > Good point. I took another look at this kind of

Re: [v5] wlcore: add missing nvs file name info for wilink8

"Reizer, Eyal" writes: > The following commits: > c815fde wlcore: spi: Populate config firmware data > d776fc8 wlcore: sdio: Populate config firmware data It's recommended to use 12 chars when abbreviating commit ids so the format should be this: c815fdebef44 wlcore: spi:

Re: [PATCH v2 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

On 8/3/2017 11:37 AM, Wright Feng wrote: brcmfmac: fix wrong num_different_channels when mchan feature enabled When the device/firmware supports multi-channel, it can have P2P connection and regular connection with AP simultaneous. In this case, the num_different_channels in wiphy info was not

Re: [PATCH 29/34] brcmfmac: stabilise the value of ->sbwad in use for some xfer routines.

So now I jump to this patch On 7/26/2017 10:25 PM, Ian Molton wrote: The IO functions operate within the Chipcommon IO window. Explicitly set this, rather than relying on the last initialisation IO access to leave it set to the right value by chance. Signed-off-by: Ian Molton

Re: [PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset

On 8/3/2017 11:37 AM, Wright Feng wrote: From: Chi-Hsien Lin Add support for CYW4373 SDIO/USB chipset. CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support. It's a WiFi/BT combo device. Reviewed-by: Arend van Spriel

Re: [PATCH v2 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode

On 8/3/2017 11:37 AM, Wright Feng wrote: brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and probe response. The security type in

Re: [PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

On 8/7/2017 1:11 PM, Arend van Spriel wrote: On 7/26/2017 10:25 PM, Ian Molton wrote: All functions that might require the window address changing call brcmf_sdiod_set_backplane_window() prior to access. Thus resetting the window is not required. Actually noticed a minor nit. The subject says

Re: [PATCH 14/34] brcmfmac: Remove brcmf_sdiod_addrprep()

On 7/26/2017 10:25 PM, Ian Molton wrote: This function has become trivial enough that it may as well be pushed into its callers, which has the side-benefit of clarifying what's going on. Remove it, and rename brcmf_sdiod_set_sbaddr_window() to brcmf_sdiod_set_backplane_window() as it's easier

Re: [PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

On 7/26/2017 10:25 PM, Ian Molton wrote: This function needs to be split up into separate read / write variants for clarity. Reviewed-by: Arend van Spriel Signed-off-by: Ian Molton more comments below... # Conflicts: #

Re: [PATCH 12/34] brcmfmac: Replace old IO functions with simpler ones.

On 7/26/2017 10:25 PM, Ian Molton wrote: Primarily this patch removes: brcmf_sdiod_f0_writeb() brcmf_sdiod_reg_write() brcmf_sdiod_reg_read() Having [patch 30/34] "brcmfmac: Correctly handle accesses to SDIO func0" before this patch could make this look cleaner. Since we no longer use the

Re: [PATCH 09/34] brcmfmac: Remove noisy debugging.

On 7/26/2017 10:25 PM, Ian Molton wrote: If you need debugging this low level, you're doing something wrong. Remove these noisy debug statements so the code is more readable. Needing this debugging does not necessarily means you are doing something wrong. You may be dealing with hardware that

Re: [PATCH 10/34] brcmfmac: Rename bcmerror to err

On 7/26/2017 10:25 PM, Ian Molton wrote: Trivial cleanup of nasty variable name Did not look, but here is... Acked-by: Arend van Spriel Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 14

Re: [PATCH 08/34] brcmfmac: Fix uninitialised variable

On 7/26/2017 10:25 PM, Ian Molton wrote: Unlikely to be a problem, but brcmf_sdiod_regrb() is not symmetric with brcmf_sdiod_regrl() in this regard. You are pretty keen on symmetry, but you could also remove the initialization in brcmf_sdiod_regrl(). As long as no -Wunitialized pops

Re: [PATCH 03/34] brcmfmac: Split brcmf_sdiod_regrw_helper() up.

On 26-07-17 22:25, Ian Molton wrote: This large function is concealing a LOT of obscure logic about how the hardware functions. Time to split it up. This first patch splits the function into two pieces - read and write, doing away with the rw flag in the process. I really don't this

Re: [PATCH 06/34] brcmfmac: Remove bandaid for SleepCSR

On 26-07-17 22:25, Ian Molton wrote: Register access code is not the place for band-aid fixes like this. If this is a genuine problem, it should be fixed further up in the driver stack. So lets make it a SDIO debug message for all register accesses getting rid of the error message.

Re: [PATCH 07/34] brcmfmac: Remove brcmf_sdiod_request_data()

On 26-07-17 22:25, Ian Molton wrote: This function is obfuscating how IO works on this chip. Remove it and push its logic into brcmf_sdiod_reg_{read,write}(). Handling of -ENOMEDIUM is altered, but as that's pretty much broken anyway we can ignore that. Please explain why you think it is

Re: [PATCH 01/34] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

Hi Ian, So it took me a while to get to this patch series. It is indeed way to big and not well structured making it difficult to review the patches on a per-patch basis. I decided to limit myself to looking at the patches involving bcmsdh.c doing a 'git log bcmsdh.c' on the applied

Re: [PATCH 02/34] brcmfmac: Register sizes on hardware are not dependent on compiler types

On 26-07-17 22:25, Ian Molton wrote: The 4 IO functions in this patch are incorrect as they use compiler types to determine how many bytes to send to the hardware. I see no incorrectness here. It is validating the regsz value and those compiler types are pretty well defined I would say.

Re: [PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

On 7/26/2017 10:25 PM, Ian Molton wrote: All functions that might require the window address changing call brcmf_sdiod_set_backplane_window() prior to access. Thus resetting the window is not required. Acked-by: Arend van Spriel Signed-off-by: Ian Molton

Assalamualikum.

Greetings from Mr. Abdul Karim. Assalamu`Alaikum. My Name is Mr. Abdul Karim I am a banker by profession. I'm from Ouagadougou, Burkina Faso, West Africa. My reason for contacting you is to transfer an abandoned $15.5M to your account. The owner of this fund died since 2004 with his Next Of

Re: [PATCH 00/10] mac80211 patches from our internal tree 2017-08-05

On Mon, 2017-08-07 at 12:06 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > Here are some pending mac80211 patches from our internal tree. > > > > The "mac80211: add api to start ba session timer expired flow" patch > > is needed by an iwlwifi patch that I want to send for

Re: [PATCH 00/10] mac80211 patches from our internal tree 2017-08-05

Luca Coelho writes: > Here are some pending mac80211 patches from our internal tree. > > The "mac80211: add api to start ba session timer expired flow" patch > is needed by an iwlwifi patch that I want to send for -fixes, so it > would have to be applied to -fixes as well. We

[PATCH] wireless-regdb: Update regulatory rules for Singapore (SG)

2.4GHz and the lower 5GHz band can now be use with up to 23dBm. But the DFS channels in general require TPC to be usable. Only 5150 - 5250 has an exception which allows the use of it without TPC when reducing the power to 20 dBm. Signed-off-by: Sven Eckelmann ---

[PATCH] brcmfmac: add setting carrier state ON for successful roaming

From: Chung-Hsien Hsu After association, ping is not working when sweeping the channel at the AP side. It is caused by having incorrect carrier state (OFF) for the STA in successful roaming. This patch sets the carrier state ON for the case. Signed-off-by: Chung-Hsien

RE: [v5] wlcore: add missing nvs file name info for wilink8

Hi Tony, > > * Reizer, Eyal [170807 00:32]: > > The following commits: > > c815fde wlcore: spi: Populate config firmware data > > d776fc8 wlcore: sdio: Populate config firmware data > > > > Populated the nvs entry for wilink6 and wilink7 only while it is > > still needed for

Re: [v5] wlcore: add missing nvs file name info for wilink8

* Reizer, Eyal [170807 00:32]: > The following commits: > c815fde wlcore: spi: Populate config firmware data > d776fc8 wlcore: sdio: Populate config firmware data > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for wilink8 as well. > This broke

RE: [v4] wlcore: add missing nvs file name info for wilink8

> -Original Message- > From: Julian Calaby [mailto:julian.cal...@gmail.com] > Sent: Saturday, August 5, 2017 8:51 AM > To: Reizer, Eyal > Cc: Kalle Valo; ,Tony Lindgren; linux-wireless@vger.kernel.org; linux- > ker...@vger.kernel.org; sebastian.reic...@collabora.co.uk > Subject: Re: [v4]

Re: [PATCH v2] rt2x00: Fix MMIC Countermeasures.

On Thu, Aug 03, 2017 at 11:31:21AM -0400, Michael Skeffingfon wrote: > @@ -136,10 +136,19 @@ void rt2800mmio_fill_rxdone(struct queue_entry *entry, >*/ > rxdesc->flags |= RX_FLAG_MMIC_STRIPPED; > > - if (rxdesc->cipher_status == RX_CRYPTO_SUCCESS) > +