Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

2017-02-23 Thread Ben Greear
with specific names so that I could know where to find them in debugfs. I think all of those patches made it upstream I'll post my hwsim related patch set in case someone wants to either apply it as is or clean it up, etc... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 162/306] mac80211-hwsim: add length checks before allocating skb.

2017-02-24 Thread Ben Greear
CK flag in a meaningful way. Maybe there is a way to return a specific error code so that the user-space doesn't get concerned when radio is idle. I didn't want to spam logs in user-space app... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 161/306] mac80211-hwsim: Improve logging.

2017-02-24 Thread Ben Greear
t up netlink API, and neither of those options seemed like an efficient use of CPU time. I'll work to fix the cosmetic problems and squash these logging patches and re-submit those. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-02-24 Thread Ben Greear
at's a global rate limiter. Is there a better rate-limiter w/out hand-crafting something? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

2017-02-24 Thread Ben Greear
ut_failure; and have the full channel definition Also the indentation in the documentation didn't match the convention used there. johannes -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

2017-02-27 Thread Ben Greear
because if you remove/add a virtual phy, then the index will probably change, even if name and MAC addr may stay the same (and so probably be the same logical entitity). Since phys can be renamed, you cannot assume that the phy will be called phyX where X is the device-id. Thanks, Ben -- Ben Gre

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

2017-02-27 Thread Ben Greear
REQ, center_freq)) + goto nla_put_failure; and have the full channel definition You want chandef.center_freq1, chandef.center_freq2, chandef.width? Anything else? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

2017-02-27 Thread Ben Greear
ed like the NEW_RADIO command? Thanks, Ben johannes -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

2017-02-27 Thread Ben Greear
On 02/27/2017 05:23 PM, Andrew Zaborowski wrote: Hi, On 27 February 2017 at 18:10, Ben Greear wrote: On 02/27/2017 07:26 AM, Andrew Zaborowski wrote: As it turns out it can be read from /sys, but I do need it so I can know what to put in HWSIM_ATTR_ADDR_RECEIVER based on the destination

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

2017-03-01 Thread Ben Greear
radio. And, you should be able to create virtual STA, AP, etc, with any specified MAC address, so the MAC of the radio really should not matter much? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

2017-03-02 Thread Ben Greear
On 03/02/2017 12:38 AM, Johannes Berg wrote: On Mon, 2017-02-27 at 12:48 -0800, Ben Greear wrote: On 02/23/2017 10:36 PM, Johannes Berg wrote: + msg_head = genlmsg_put(skb, 0, 0, &hwsim_genl_family, 0, + HWSIM_CMD_NOTIFY); I think you should use a

Re: rate mask resulting in no usable rates - WARN_ON

2017-03-07 Thread Ben Greear
s the rateset that you want to transmit with. That allows you to configure your station to act like a /b station (advertise 1,2,...11Mbps), but only transmit on 1Mbps, for instance. Nice thing about doing it in supplicant is that it has fairly good access to the rates the AP is advertisin

Re: rate mask resulting in no usable rates - WARN_ON

2017-03-10 Thread Ben Greear
works fine). Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Should ath10k enable RX_FLAG_ALLOW_SAME_PN

2017-03-15 Thread Ben Greear
have the same PN as the previous frame. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: netdev level filtering? perhaps pushing socket filters down?

2017-03-16 Thread Ben Greear
stations/vdevs, and ignore radiotap headers and/or add special processing for metadata like rx-info? Thanks, Ben Thanks, johannes -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change.

2017-03-29 Thread Ben Greear
e needs grew. It can still grow, however. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v3 3/4] mac80211-hwsim: add rate-limited debugging for rx-netlink

2017-03-29 Thread Ben Greear
On 03/29/2017 01:46 AM, Johannes Berg wrote: On Thu, 2017-03-23 at 16:26 -0700, gree...@candelatech.com wrote: From: Ben Greear This makes it easier to understand why wmediumd (or similar) is getting errors when sending frames to the kernel. Signed-off-by: Ben Greear --- drivers/net

Re: [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change.

2017-03-29 Thread Ben Greear
etlink's saving grace is that it is easy to add new data members and so support new API in a forward/backward compatible manner. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change.

2017-03-31 Thread Ben Greear
, then I'm happy to keep working on it. If it needs a complete re-write, then it will have to wait for someone else or some later date. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [RFC 2/3] genetlink: pass extended error report down

2017-04-07 Thread Ben Greear
logic free it when done? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [RFC 2/3] genetlink: pass extended error report down

2017-04-07 Thread Ben Greear
On 04/07/2017 12:12 PM, Johannes Berg wrote: On Fri, 2017-04-07 at 11:37 -0700, Ben Greear wrote: I guess the error string must be constant and always available in memory in this implementation? Yes. I think it would be nice to dynamically create strings (malloc, snprintf, etc) and have

How to debug DMAR errors?

2017-04-13 Thread Ben Greear
(not even sysrq-boot will do anything), so I guess I would need the DMAR logic to print out more info on that address somehow. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: How to debug DMAR errors?

2017-04-14 Thread Ben Greear
On 04/14/2017 08:45 AM, Alexander Duyck wrote: On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: Hello, I have been seeing a regular occurrence of DMAR errors, looking something like this when testing my ath10k driver/firmware under some specific loads (maximum receive of 512 byte frames

Re: How to debug DMAR errors?

2017-04-14 Thread Ben Greear
On 04/14/2017 09:24 AM, Alexander Duyck wrote: On Fri, Apr 14, 2017 at 9:19 AM, Ben Greear wrote: On 04/14/2017 08:45 AM, Alexander Duyck wrote: On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: Hello, I have been seeing a regular occurrence of DMAR errors, looking something like

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-04-18 Thread Ben Greear
ese patches offer any fundamental new vulnerability that should concern the FCC. After all, someone who really wants to do evil can find and apply the patches without undue effort, and it could easily be that those applying the patches would then make it even easier to abuse the new channels due to

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-05-10 Thread Ben Greear
requires a few small changes in the mac80211 stack to allow it to be configuredjust FYI. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-05-12 Thread Ben Greear
this into LEDE? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: ath10k: controlling TX aggregation

2017-05-12 Thread Ben Greear
ize through driver? latest wireless-drivers-next and linux-firmware git is used. -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-05-12 Thread Ben Greear
On 05/12/2017 12:21 PM, Steve deRosier wrote: Hi Ben, On Fri, May 12, 2017 at 7:12 AM, Ben Greear wrote: On 05/11/2017 04:38 AM, Kalle Valo wrote: Simon Wunderlich writes: it seems like there was some discussion here and I wouldn't expect too many more opinions ... do you think w

BUG related to NAPI and ath10k in 4.9 + hacks kernel.

2017-05-15 Thread Ben Greear
p;n->state)); smp_mb__before_atomic(); clear_bit(NAPI_STATE_SCHED, &n->state); clear_bit(NAPI_STATE_NPSVC, &n->state); } Any ideas what might be the cause of this? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: BUG related to NAPI and ath10k in 4.9 + hacks kernel.

2017-05-15 Thread Ben Greear
On 05/15/2017 11:26 AM, Ben Greear wrote: This is from a test system running my hacked 4.9 kernel, with 9888 ath10k NIC which often fails during startup. The firmware did fail to boot this time, and maybe it left things in a weird state. Then, the whole OS crashed with BUG. I think the bug

'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-16 Thread Ben Greear
x27;strace' shows that it is waiting on recvmsg. If I start a second 'iw events' then it will get wifi events as expected. Are there any known issues in this area? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed"

2018-02-26 Thread Ben Greear
which resource the firmware ran out of? It would seem to be a FW bug if it is leaking, so maybe it can be fixed as well... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] ath9k: break out of irq handler after 5 jiffies

2018-02-26 Thread Ben Greear
On 02/07/2018 07:39 AM, Ben Greear wrote: On 02/07/2018 02:55 AM, Johannes Berg wrote: On Wed, 2018-02-07 at 10:16 +0100, Felix Fietkau wrote: On 2018-02-07 00:05, gree...@candelatech.com wrote: From: Ben Greear In case where the system is sluggish, we should probably break out early

Re: [PATCH] ath9k: break out of irq handler after 5 jiffies

2018-02-26 Thread Ben Greear
On 02/26/2018 02:08 PM, Arend van Spriel wrote: On 2/26/2018 10:39 PM, Ben Greear wrote: On 02/07/2018 07:39 AM, Ben Greear wrote: On 02/07/2018 02:55 AM, Johannes Berg wrote: On Wed, 2018-02-07 at 10:16 +0100, Felix Fietkau wrote: On 2018-02-07 00:05, gree...@candelatech.com wrote: From

Re: fixed bit rate 9Mbps set as 24Mbps in g mode(legacy)

2018-02-27 Thread Ben Greear
Kavita -- To unsubscribe from this list: send the line "unsubscribe backports" in -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Deadlock debugging help.

2018-02-27 Thread Ben Greear
nternal+0x34/0x210 [ 1623.116899] #2: (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x12/0x20 [ 1623.116905] #3: (&ar->conf_mutex){+.+.+.}, at: [] ath10k_stop+0x24/0x80 [ath10k_core] [ 1623.116915] 2 locks held by bash/7559: [ 1623.116916] #0: (&tty->ldisc_sem){.+},

Re: Deadlock debugging help.

2018-02-27 Thread Ben Greear
On 02/27/2018 12:49 PM, Ben Greear wrote: I notice I can reliably lock up the kernel if I rmmod ath10k while it is under heavy tx/rx traffic. First, this causes the firmware to crash, and then right after (or possibly during?) the related kernel threads deadlock. This is with my hacked driver

Re: Deadlock debugging help.

2018-02-27 Thread Ben Greear
On 02/27/2018 01:42 PM, Ben Greear wrote: On 02/27/2018 12:49 PM, Ben Greear wrote: I notice I can reliably lock up the kernel if I rmmod ath10k while it is under heavy tx/rx traffic. First, this causes the firmware to crash, and then right after (or possibly during?) the related kernel

Re: [RFC] ath10k: Attempt to work around napi_synchronize hang.

2018-02-28 Thread Ben Greear
ture. And you'd need to update ahb.c too. I'll update ahb.c to match. Thanks, Ben Michał -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: fixed bit rate 9Mbps set as 24Mbps in g mode(legacy)

2018-02-28 Thread Ben Greear
On 02/27/2018 08:03 PM, KAVITA MATHUR wrote: On Tue, 27 Feb 2018 08:41:50 -0800, Ben Greear wrote On 02/27/2018 12:49 AM, KAVITA MATHUR wrote: Hi, I have configured AP in g mode and tested legacy rates.All basic rates and supported rates(1,2,5.5,11,6,9,12,18,24,36,48,54) are set except

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Ben Greear
On 03/20/2018 03:37 AM, Michal Kubecek wrote: On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify a 'level'. This level can be used by the driver to decrease the amount of stats

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Ben Greear
On 03/20/2018 09:11 AM, Steve deRosier wrote: On Tue, Mar 20, 2018 at 8:39 AM, Ben Greear wrote: On 03/20/2018 03:37 AM, Michal Kubecek wrote: On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Ben Greear
On 03/20/2018 11:24 AM, Michal Kubecek wrote: On Tue, Mar 20, 2018 at 08:39:33AM -0700, Ben Greear wrote: On 03/20/2018 03:37 AM, Michal Kubecek wrote: IMHO it would be more practical to set "0 means same as GSTATS" as a rule and make ethtool_get_stats() a wrapper for ethtool_get_s

Re: [ath10k throughput] low throughput in multi-user mode

2018-03-21 Thread Ben Greear
igher MCS rates. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] ath9k: Protect queue draining by rcu_read_lock()

2018-03-23 Thread Ben Greear
g the rcu_read_lock() to the caller in ath9k. Fixes: 50f08edf9809 ("ath9k: Switch to using mac80211 intermediate software queues.") Cc: sta...@vger.kernel.org Reported-by: Ben Greear Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath9k/xmit.c | 4 1 file change

Re: [PATCH] mac80211: Fix wlan freezes under load at rekey

2018-03-24 Thread Ben Greear
ior to switching to new key in mac80211. +*/ + ieee80211_key_disable_hw_accel(old); + } else { idx = new->conf.keyidx; + } if (sta) { if (pairwise) { -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] mac80211: Fix wlan freezes under load at rekey

2018-03-25 Thread Ben Greear
tly wasn't correct enough to accept upstream: https://www.spinics.net/lists/hostap/msg03677.html So I really don't know enough to properly review your patch. Just be aware that ath10k is weird about sw-crypt, maybe make sure your patch is tested on it to make sure it doesn't out-ri

Re: second wifi card enforce CN reg dom

2018-04-12 Thread Ben Greear
urers who improperly interpret said rules because it's easier for them. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/ -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: second wifi card enforce CN reg dom

2018-04-12 Thread Ben Greear
ed testing. And for the patch, it is also implied that I am able to write one. Unfortunately, my opinion is that if you are unable to write one, then you should not be mucking with the regulatory domain stuff at all. Thanks, Ben 2018-04-12 19:11 GMT+02:00 Ben Greear : On 04/12/2018 10:05 AM

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Ben Greear
them individually to different lists I figure I'd be hearing about how the netdev patch is useless because it has no driver support, etc. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread Ben Greear
On 04/18/2018 11:38 PM, Johannes Berg wrote: On Wed, 2018-04-18 at 14:51 -0700, Ben Greear wrote: It'd be pretty hard to know which flags are firmware stats? Yes, it is, but ethtool stats are difficult to understand in a generic manner anyway, so someone using them is already likely

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-23 Thread Ben Greear
On 04/22/2018 11:54 AM, David Miller wrote: From: Johannes Berg Date: Thu, 19 Apr 2018 17:26:57 +0200 On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: Maybe this could be in followup patches? It's going to touch a lot of files, and might be hell to get merged all at once, and

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-23 Thread Ben Greear
On 04/22/2018 02:15 PM, Roopa Prabhu wrote: On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: From: Johannes Berg Date: Thu, 19 Apr 2018 17:26:57 +0200 On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: Maybe this could be in followup patches? It's going to touch a lot of

Re: [PATCH v1] ath10k: fix band_center_freq handling for VHT160 in recent firmwares

2018-04-26 Thread Ben Greear
arg->band_center_freq1); + } ch->min_power = arg->min_power; ch->max_power = arg->max_power; ch->reg_power = arg->max_reg_power; -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-26 Thread Ben Greear
+ 1) + +/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/ +#define BW_NSS_FWCONF_160(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M)) +#define BW_NSS_FWCONF_80_80(x)(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) <&

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-26 Thread Ben Greear
On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On 04/26/2018 02:28 AM, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Ben Greear
On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On 04/26/2018 02:28 AM, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall current handling

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Ben Greear
On 04/27/2018 11:54 AM, Sebastian Gottschall wrote: Am 27.04.2018 um 18:07 schrieb Ben Greear: On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On 04

Re: [PATCH v4] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-28 Thread Ben Greear
ine BW_NSS_FWCONF_80_80(x)(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M)) struct wmi_10_4_peer_assoc_complete_cmd { struct wmi_10_2_peer_assoc_complete_cmd cmd; -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-28 Thread Ben Greear
On 04/27/2018 05:24 PM, Sebastian Gottschall wrote: Am 27.04.2018 um 23:57 schrieb Ben Greear: On 04/27/2018 11:54 AM, Sebastian Gottschall wrote: Am 27.04.2018 um 18:07 schrieb Ben Greear: On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On

Re: [PATCH v4] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-28 Thread Ben Greear
On 04/28/2018 08:26 AM, Sebastian Gottschall wrote: Am 28.04.2018 um 17:01 schrieb Ben Greear: On 04/27/2018 05:47 PM, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx

Re: [PATCH v7] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-30 Thread Ben Greear
_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M)) +#define BW_NSS_FWCONF_80_80(x)(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M)) struct wmi_10_4_peer_assoc_complete_cmd { struct wmi_10_2_peer_assoc_complete_cmd cmd; -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v7] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-05-01 Thread Ben Greear
_NSS_FWCONF_MAP_160MHZ_M)) +#define BW_NSS_FWCONF_80_80(x)(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M)) struct wmi_10_4_peer_assoc_complete_cmd { struct wmi_10_2_peer_assoc_complete_cmd cmd; -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Ath10k probe response error related to mac80211 commit.

2016-09-01 Thread Ben Greear
EATURE_USERSPACE_MPM | + NL80211_FEATURE_FULL_AP_CLIENT_STATE; if (!ops->hw_scan) wiphy->features |= NL80211_FEATURE_LOW_PRIORITY_SCAN | Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Ath10k probe response error related to mac80211 commit.

2016-09-01 Thread Ben Greear
only happens (as far as I know) with my modified firmware, then I will try to fix it there. Or, possibly I can change ath10k driver to flip this mac80211 flag when loading my firmware variant if firmware cannot be easily fixed. Thanks for the info, --Ben johannes -- Ben Greear Cande

Re: Ath10k probe response error related to mac80211 commit.

2016-09-01 Thread Ben Greear
On 09/01/2016 11:53 AM, Johannes Berg wrote: On Thu, 2016-09-01 at 11:23 -0700, Ben Greear wrote: Could easily be that others are corrupted too, but since probe resp is bad, the association will not proceed. makes sense. Heh, I spent 4 days tracking this down, so I wanted to be precise in

Re: Ath10k probe response error related to mac80211 commit.

2016-09-01 Thread Ben Greear
On 09/01/2016 11:53 AM, Johannes Berg wrote: On Thu, 2016-09-01 at 11:23 -0700, Ben Greear wrote: Could easily be that others are corrupted too, but since probe resp is bad, the association will not proceed. makes sense. Heh, I spent 4 days tracking this down, so I wanted to be precise in

Re: Ath10k probe response error related to mac80211 commit.

2016-09-02 Thread Ben Greear
On 09/02/2016 05:09 AM, Michal Kazior wrote: On 1 September 2016 at 22:52, Ben Greear wrote: On 09/01/2016 11:53 AM, Johannes Berg wrote: On Thu, 2016-09-01 at 11:23 -0700, Ben Greear wrote: Could easily be that others are corrupted too, but since probe resp is bad, the association will

Re: [PATCH] ath10k: ensure pdev sta kickout threshold is set.

2016-09-06 Thread Ben Greear
like my fwcfg patches, and/or disable the kickout entirely. Since mac80211 can deal with kicking out stations already, the stuff in the firmware just makes things less stable in poor RF environments and/or with stations with flaky power-save and off-channel roaming. Thanks, Ben -- Ben Greear

Re: [PATCH] ath10k: ensure pdev sta kickout threshold is set.

2016-09-06 Thread Ben Greear
On 09/06/2016 10:16 AM, Rajkumar Manoharan wrote: On 2016-09-06 18:42, Ben Greear wrote: On 09/06/2016 12:39 AM, Manoharan, Rajkumar wrote: [...] +int ath10k_mac_set_pdev_kickout(struct ath10k *ar) +{ + u32 param = ar->wmi.pdev_param->sta_kickout_th; + int rv; + +

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

2016-09-06 Thread Ben Greear
MCS 8 + * bitrate as it's closer than 0 */ + 7800, }, { 1350, 2700, -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.

2016-09-09 Thread Ben Greear
On 09/09/2016 06:36 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear I was seeing some spin-lock hangs in this area of the code, and it seems more proper to do the rcu-read-lock outside of the spin lock. I am not sure how much this matters, however. Signed-off-by

Re: [PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

2016-09-09 Thread Ben Greear
On 09/09/2016 10:25 AM, Felix Fietkau wrote: On 2016-08-19 03:26, gree...@candelatech.com wrote: From: Ben Greear I was seeing kernel crashes due to accessing freed memory while debugging a 9984 firmware that was crashing often. This patch fixes the crashes. I am not certain if there is a

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

2016-09-12 Thread Ben Greear
On 09/11/2016 11:43 PM, Johannes Berg wrote: On Wed, 2016-09-07 at 18:20 +, Pedersen, Thomas wrote: On 09/06/2016 12:07 PM, Ben Greear wrote: On 09/06/2016 12:00 PM, Thomas Pedersen wrote: Some drivers (ath10k) report MCS 9 @ 20MHz, which technically isn't allowed. To get

Re: [PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.

2016-09-12 Thread Ben Greear
CU protected section *small*, so having the spinlock inside hurts overall system performance. Ok, thanks for the review. I'll drop this patch from my tree. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

2016-09-14 Thread Ben Greear
On 09/14/2016 07:07 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error message for tx failures. Signed-off-by: Ben Greear --- drivers

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:12 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear There are not many of these messages producted by the firmware, but they are generally fairly useful, so print them at info level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:18 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This allows user-space tools to decode debug-log messages by parsing dmesg or /var/log/messages. Signed-off-by: Ben Greear Don't tracing points already provide the same information? Tr

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

2016-09-14 Thread Ben Greear
On 09/14/2016 07:19 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Helps keep messages off of (serial) console when that is desired. Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print exactly for this purpose? At least I recall using it. I just want

Re: [PATCH v2 11/21] ath10k: add fw-powerup-fail to ethtool stats.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:25 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This gives user-space a normal-ish way to detect that firmware has failed to start and that a reboot is probably required. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.h

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:30 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Add placeholder so CT firmware can more easily co-exist with upstream kernel. CT firmware should be backwards compatible with existing kernels, but it also has many new features. Subsequent

Re: [PATCH v2 19/21] ath10k: Enable adhoc mode for CT firmware.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:37 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear CT firmware can support IBSS mode, so allow users to configure this. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 5 + 1 file changed, 5 insertions(+) diff --git a

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

2016-09-14 Thread Ben Greear
On 09/14/2016 07:06 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Using debugfs. More convenient than module options in some cases. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 62 + 1 file changed

Re: Using ath5k/ath9k radio for constant-tx noise source.

2016-09-14 Thread Ben Greear
On 08/20/2015 08:11 AM, Zefir Kurtisi wrote: On 08/19/2015 09:07 PM, Ben Greear wrote: I have a commercial AP that is using a CM9 ath5k radio (evidently, I could be wrong) and it has the ability to do a constant transmit of raw noise (RF probe shows noise, but a monitor-port sniffer does not

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:15 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:30 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Add placeholder so CT firmware can more easily co-exist with upstream kernel. CT firmware should be backwards compatible with

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

2016-09-15 Thread Ben Greear
On 09/15/2016 07:12 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:19 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Helps keep messages off of (serial) console when that is desired. Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print ex

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:19 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:06 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Using debugfs. More convenient than module options in some cases. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:06 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:18 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This allows user-space tools to decode debug-log messages by parsing dmesg or /var/log/messages. Signed-off-by: Ben Greear Don&#

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:02 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:12 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear There are not many of these messages producted by the firmware, but they are generally fairly useful, so print them at info level

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

2016-09-15 Thread Ben Greear
On 09/15/2016 06:59 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:07 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error

Re: Using ath5k/ath9k radio for constant-tx noise source.

2016-09-15 Thread Ben Greear
On 09/15/2016 08:28 AM, Zefir Kurtisi wrote: Hi Ben, On 09/15/2016 02:22 AM, Ben Greear wrote: On 08/20/2015 08:11 AM, Zefir Kurtisi wrote: On 08/19/2015 09:07 PM, Ben Greear wrote: I have a commercial AP that is using a CM9 ath5k radio (evidently, I could be wrong) and it has the ability to

Re: Using ath5k/ath9k radio for constant-tx noise source.

2016-09-15 Thread Ben Greear
On 09/15/2016 06:26 AM, Bob Copeland wrote: On Wed, Sep 14, 2016 at 05:22:46PM -0700, Ben Greear wrote: On 08/20/2015 08:11 AM, Zefir Kurtisi wrote: On 08/19/2015 09:07 PM, Ben Greear wrote: I have a commercial AP that is using a CM9 ath5k radio (evidently, I could be wrong) and it has the

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote: On Thu, 2016-09-15 at 08:14 -0700, Ben Greear wrote: On 09/15/2016 07:06 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:18 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This allows user-space tools

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 10:59 AM, Ben Greear wrote: On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote: I have other patches that remember the last 100 or so firmware log messages from the kernel and provide that in a binary dump image when firmware crashes. This is indeed very useful. But, when

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

2016-09-19 Thread Ben Greear
his 'feature' as well, at least in some firmware. Probably can reproduce by sending off-channel mgt frames on 5Ghz when associated on 2.4, or something similar to this. I was using ath9k as sniffer when I found this long ago, so at least ath9k needs the change Thanks, Ben -- Ben Gre

Re: ath9k_htc kernel driver regression affecting throughput

2016-09-21 Thread Ben Greear
all<- the rom code into ram starting with the USB subsystem. Have you investigated whether you have enough RAM to do this? I haven't looked at ath9k_htc, but in general, that type of architecture is tight on RAM in my experience. Thanks, Ben -- Ben Greear Candela Technologie

Re: ath9k_htc kernel driver regression affecting throughput

2016-09-22 Thread Ben Greear
e to use a bitfield may save some BSS ram, but may easily use far more instruction ram than what you saved with the bitfield. Good luck! Thanks, Ben On 9/21/16, Ben Greear wrote: On 09/21/2016 08:34 PM, bruce m beach wrote: i.e a lable that the code jumps to and nothing else. At this po

Re: [PATCH] ath10k: fix system hang at qca99x0 probe on x86 platform (DMA32 issue)

2016-09-26 Thread Ben Greear
_DMA32 for firmware swap memory. This fixes OS crash when using QCA 9984 NIC on x86-64 system without vt-d enabled. Also tested on ea8500 with 9980, and x86-64 with 9980 and 9880. All tests were with CT firmware. Signed-off-by: Ben Greear drivers/net/wireles

Re: ath10k stuck on 6Mbps and spam syslog

2016-09-29 Thread Ben Greear
3Csv*sd*bc*sc*i* depends:ath10k_core,compat vermagic: 3.14.48-g408ccb9 SMP mod_unload modversions ARMv7 p2v8 parm: irq_mode:0: auto, 1: legacy, 2: msi (default: 0) (uint) parm: reset_mode:0: auto, 1: warm only (default: 0) (uint) I don't know if it's only a problem of iw station dump that can't show the tx rate, but the spammed syslog honestly warn me... How shall I check what's wrong and see the HT work? Thanks a lot! Matteo -- Ben Greear Candela Technologies Inc http://www.candelatech.com

  1   2   3   4   5   6   7   >