Re: [Linuxwacom-devel] [PATCH 5/6] Search for more potential key and cert locations

: > > On Tue, Apr 9, 2019 at 3:17 PM Gerecke, Jason wrote: >> >> From: Jason Gerecke >> >> Previously we would only automatically discover Ubuntu's shim MOK if one >> had been created. We now also try to use the kernel's autogenerated key >> if presen

[Linuxwacom-devel] [PATCH input-wacom] Only use AM_EXTRA_RECURSIVE_TARGETS if defined

a RHEL 6 user builds from git (not a tarball), the `make signature` step will not work unless they first change into the 2.6.32 directory. Fixes: 260ee967a0 ("Add support for kernel module signing and enforcement") Signed-off-by: Jason Gerecke --- configure.ac | 2 +- 1 file changed, 1

[Linuxwacom-devel] [PATCH input-wacom 1/3] 2.6.32: Limit input-wacom to only provide "new" devices to RHEL 6.10

nly* support devices that aren't already supported by the existing RHEL driver. This isn't ideal, but the proper fix (backporting EKR and others) is more work than we're prepared to undertake at this point in time. Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.32/Makefile.in | 14 ++

[Linuxwacom-devel] [PATCH input-wacom 3/3] Recgonize Scientific Linux as a variant of RHEL

From: Ping Cheng Update configure.ac to include them into RHEL 6.10+ and 7.4+ paths. Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5ea344c..1830b75 100644

[Linuxwacom-devel] [PATCH input-wacom 2/3] 2.6.32: MobileStudio Pro 13/16 and Cintiq Pro 13FHD/16UHD support 10 fingers

From: Ping Cheng Add missed .touch_max = 10 to their feature structure. Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.32/wacom_wac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/2.6.32/wacom_wac.c b/2.6.32/wacom_wac.c index dfb4ed3..7df47fb

Re: [Linuxwacom-devel] [PATCH] 2.6.32 RHEL: Add out of tree support for RHEL 6.10

Looks good, but I have a few requests: On Wed, Dec 12, 2018 at 5:05 PM Ping Cheng wrote: > > Make those devices not supported by RHEL 6.10 into wacom-ot.ko so > both drivers can live happily together ;). > > Signed-off-by: Ping Cheng > --- > 2.6.32/Makefile.in | 17 - >

[Linuxwacom-devel] [PATCH input-wacom] Add support for kernel module signing and enforcement

It is becoming more common for systems to only allow signed kernel modules to be loaded (e.g. because the kernel is in "lockdown mode" due to secure boot policies). Users who follow the standard configure / make / install process find that the driver does not work after rebooting and often don't

[Linuxwacom-devel] [PATCH 2/3] Prevent spurious right-clicks at the end of very short scroll and zoom gestures

a check for single-finger SCROLL and ZOOM states just before this block and have it move the mode to CANCEL which will only be reset once both fingers have gone up. Ref: https://github.com/linuxwacom/input-wacom/issues/33 Signed-off-by: Jason Gerecke --- src/wcmTouchFilter.c | 10 +- 1 file

[Linuxwacom-devel] [PATCH 1/3] Do not wait wcmTapTime to enter scroll or zoom mode

so sloppy that your fingers moved enough to be considered a scroll or zoom gesture). Ref: https://github.com/linuxwacom/input-wacom/issues/33 Ref: 3005fc0 ("reduce 2-finger scroll holdoff time") Signed-off-by: Jason Gerecke --- src/wcmTouchFilter.c | 11 +++ 1 file changed

[Linuxwacom-devel] [PATCH 3/3] Overhaul calculation of default scroll, zoom, and spread distances

-smaller gestures on tablets with higher logical resolution. Ref: https://github.com/linuxwacom/input-wacom/issues/33 Signed-off-by: Jason Gerecke --- src/wcmValidateDevice.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/wcmValidateDevice.c b/src

Re: [Linuxwacom-devel] [PATCH] xsetwacom: 'Serial' missing from deprecated parameter list

included the patch differently (e.g. as an > attachment) ? > > Thanks > > James Pearson > > Jason Gerecke wrote: > > > > Reviewed-by: Jason Gerecke > > > > I'm having some trouble actually applying this patch to my tree, but I > > suspect that a

Re: [Linuxwacom-devel] [PATCH] xsetwacom: 'Serial' missing from deprecated parameter list

Reviewed-by: Jason Gerecke I'm having some trouble actually applying this patch to my tree, but I suspect that a recent change to Gmail is probably more the problem than the patch itself. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ISDv4 50fd and 4807

Tue, Jul 24, 2018 at 11:11:45AM -0700, Jason Gerecke wrote: >> Ref: https://github.com/linuxwacom/libwacom/issues/26 >> Ref: https://github.com/linuxwacom/libwacom/issues/28 >> Signed-off-by: Jason Gerecke > > Reviewed-by: Peter Hutterer > > Cheers, >Peter >

[Linuxwacom-devel] [PATCH libwacom] data: Add ISDv4 50fd and 4807

Ref: https://github.com/linuxwacom/libwacom/issues/26 Ref: https://github.com/linuxwacom/libwacom/issues/28 Signed-off-by: Jason Gerecke --- data/isdv4-4807.tablet | 14 ++ data/isdv4-50fd.tablet | 14 ++ 2 files changed, 28 insertions(+) create mode 100644 data/isdv4

[Linuxwacom-devel] [PATCH 1/3] Remove unnecessary free() from wcmAllocate

There is no need to free the 'tool' variable, since the "error" label is only ever reached if 'tool' is already null. V575 The null pointer is passed into 'free' function. Inspect the first argument. Signed-off-by: Jason Gerecke --- src/wcmConfig.c | 1 - 1 file changed, 1 deletio

[Linuxwacom-devel] [PATCH 3/3] Simplify boolean expression

The check here is logically equivalent to (a != b) but much harder to read. Lets change that. V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. Signed-off-by: Jason Gerecke --- src/wcmUSB

[Linuxwacom-devel] [PATCH 2/3] Remove unnecessary check against 'press'

The loop that this executes in only evaluates press entries to begin with, making the check here unnecessary. V547 Expression 'press' is always true. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/wcmCommon.c b/src

[Linuxwacom-devel] [PATCH] travis: Hotfix Coverity's Travis integration patch

. Signed-off-by: Jason Gerecke --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index bc3f492..8135071 100644 --- a/.travis.yml +++ b/.travis.yml @@ -29,6 +29,7 @@ matrix: env: BUILDTYPE="coverity", COVERITY_SCAN_PR

[Linuxwacom-devel] [PATCH] data: Add elan-2537 (HP Envy x360 15m-bq1xx)

Ref: https://github.com/linuxwacom/libwacom/issues/21 Signed-off-by: Jason Gerecke <killert...@gmail.com> --- data/elan-2537.tablet | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 data/elan-2537.tablet diff --git a/data/elan-2537.tablet b/data/elan-2537.tablet ne

[Linuxwacom-devel] [PATCH libwacom] data: Add HP Elite x2 1012 G2

Ref: https://github.com/linuxwacom/libwacom/issues/20 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/isdv4-485e.tablet | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 data/isdv4-485e.tablet diff --git a/data/isdv4-485e.tablet b/data/isdv4-485e.

Re: [Linuxwacom-devel] [PATCH input-wacom] backport: restore touch functionality to SW_MUTE_DEVICE devices

, 2018 at 9:42 PM, Jason Gerecke <killert...@gmail.com> wrote: > On Tue, Apr 24, 2018 at 12:19 AM, Ping Cheng <pingli...@gmail.com> wrote: >> On Mon, Apr 23, 2018 at 4:37 PM Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >>> >>> On Mon, Apr 2

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] Include generated config.h header in all kernels

On Fri, Apr 20, 2018 at 4:31 PM, Ping Cheng <pingli...@gmail.com> wrote: > On Fri, Apr 20, 2018 at 2:33 PM, Jason Gerecke <killert...@gmail.com> wrote: >> >> The config.h header that is generated after running the configure >> script should be included by

[Linuxwacom-devel] [PATCH libwacom v2] data: Add ELAN 22E2 (HP Spectre x360)

Ref: https://github.com/linuxwacom/libwacom/issues/15 Signed-off-by: Jason Gerecke <killert...@gmail.com> --- data/elan-22e2.tablet | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 data/elan-22e2.tablet diff --git a/data/elan-22e2.tablet b/data/elan-22e2.tabl

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ELAN 22E2 (HP Spectre x360)

On Tue, Apr 17, 2018 at 9:17 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Apr 17, 2018 at 10:53:17AM -0700, Jason Gerecke wrote: >> Ref: https://github.com/linuxwacom/libwacom/issues/15 >> Signed-off-by: Jason Gerecke <killert...@gmail.com> >> -

[Linuxwacom-devel] [PATCH input-wacom 1/2] Include generated config.h header in all kernels

The config.h header that is generated after running the configure script should be included by all the kernels to ensure that we are able to access compiler defines only discovered at config time. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.32/wacom.h | 1 + 2.6.38/wacom

[Linuxwacom-devel] [PATCH libwacom] Fix memory leak in error path

Reported by PVS Studio: V773 The function was exited without releasing the 'devices' pointer. A memory leak is possible. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- libwacom/libwacom-database.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libwacom/li

[Linuxwacom-devel] [PATCH libwacom] data: Add isdv4-5146 (Lenovo ThinkPad X1 Yoga [3rd-gen])

Ref: https://github.com/linuxwacom/libwacom/issues/17 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/isdv4-5146.tablet | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 data/isdv4-5146.tablet diff --git a/data/isdv4-5146.tablet b/data/isdv4-5146.

[Linuxwacom-devel] [PATCH libwacom] data: Add ELAN 22E2 (HP Spectre x360)

Ref: https://github.com/linuxwacom/libwacom/issues/15 Signed-off-by: Jason Gerecke <killert...@gmail.com> --- data/elan-22e2.tablet | 17 + 1 file changed, 17 insertions(+) create mode 100644 data/elan-22e2.tablet diff --git a/data/elan-22e2.tablet b/data/elan-22e2.tabl

[Linuxwacom-devel] [PATCH input-wacom 3/6] 2.6.30: Align INTUOSHT3 case in wacom_wac_irq with other trees

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index 5bf69d4..bd93cf7 100644 --- a/2.6.30/wacom_wac.c +++ b/2.6.30/wacom_wac.c @@ -1929,10 +

[Linuxwacom-devel] [PATCH input-wacom 6/6] 2.6.30: Backport report ID check for wacom_intuos_general

Should have no impact other than reducing the diff between 2.6.30 and 2.6.38. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 4 1 file changed, 4 insertions(+) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index 5b75224..c5f4aa3 100644 --- a/

[Linuxwacom-devel] [PATCH input-wacom 1/6] 2.6.30: Check WACOM_QUIRK_BBTOUCH_LOWRES before modifying Bamboo coords

Only tablets with the WACOM_QUIRK_BBTOUCH_LOWRES flag set should have their coordinates expanded. This fix was never backported from upstream to the 2.6.30 kernel; only the 2.6.38+ kernels. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 7 +-- 1 file c

[Linuxwacom-devel] [PATCH input-wacom 5/6] 2.6.30: Do not report acceleromter data from Cintiq 27QHD

) but tracking prox makes things tricky: either you always keep the pad in prox like the 2.6.30 kernel was doing (which will possibly be a source of actual issues) or you just don't bother reporting this data like the 2.6.38 and 3.7 kernels. Signed-off-by: Jason Gerecke <jason.gere...@wacom.

[Linuxwacom-devel] [PATCH input-wacom 4/6] 2.6.30: Remove useless statement

Just after this statement is (possibly) executed, we update the value of stylus_in_proximity to be equal to 'prox', making this explicit setting useless. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom v2] release.sh: bugfixes

s most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel From 065bcff

[Linuxwacom-devel] [PATCH input-wacom] Use `dracut` if available to update RHEL/Fedora initramfs

the package manager installed a kernel update. Users with customizations very likely make use of the dracut configuration files rather than passing arguments to the command every time. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 3.17/Makefile.in | 4 3.7/Makefile.i

Re: [Linuxwacom-devel] [PATCH input-wacom 2/8] 3.17: backport 2cf83833fc9c HID: use kobj_to_dev()

[Apparently I forgot to send this notification out -- I'll let you look it over before I push the first 7 patches in your set] I'll apply this patch to the 3.7 tree as well since its post 3.6. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is

Re: [Linuxwacom-devel] [PATCH input-wacom 4/8] 4.5: define our own hid_is_using_ll_driver()

[Apparently I forgot to send this notification out -- I'll let you look it over before I push the first 7 patches in your set] I'd prefer keeping the "wacom" prefix for the same reason as the prior patch. I've used the pattern from the previous patch (defining 'wacom_is_using_usb_driver' as

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] Fail the Coverity build if their script cannot be downloaded

, Mar 14, 2018 at 1:52 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Mar 13, 2018 at 03:25:48PM -0700, Jason Gerecke wrote: >> If curl encounters an error trying to download the Coverity build script >> (as seems to be happening at the moment d

[Linuxwacom-devel] [PATCH libwacom] Fail the Coverity build if their script cannot be downloaded

construction which will get and then execute the script as independent steps. Also, to ensure curl returns an error code even in less-severe cases (e.g. a basic 404 "Not Found") we add the '-f' option. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- Might as well apply

[Linuxwacom-devel] [PATCH xf86-input-wacom] Fail the Coverity build if their script cannot be downloaded

construction which will get and then execute the script as independent steps. Also, to ensure curl returns an error code even in less-severe cases (e.g. a basic 404 "Not Found") we add the '-f' option. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- .travis.yml | 2 +- 1

[Linuxwacom-devel] [PATCH input-wacom 09/10] 2.6.30: Backport TABLETPCE ISDv4 devices

The pen interface of TABLETPCE devices is supposedly identical to the classic TABLETPC interface (see: dabcba4226), with just the touch interface modified to be Win8-compatible. Supporting these devices (and updating those that are marked TABLETPC) is fairly straightforward. Signed-off-by: Jason

[Linuxwacom-devel] [PATCH input-wacom 07/10] 2.6.30: Backport touch_max data

causes the ABS_MT_POSITION_{X,Y} axes to be declared but otherwise has no effect (touch_max is already set on several tablets, and the existence of unused ABS_MT_POSITION_{X,Y} axes doesn't seem to cause them any issue). Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom

[Linuxwacom-devel] [PATCH input-wacom 06/10] 2.6.30: Backport resolution data (but not implementation)

of resolutions. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 310 +++-- 2.6.30/wacom_wac.h | 2 + 2 files changed, 161 insertions(+), 151 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index b

[Linuxwacom-devel] [PATCH input-wacom 04/10] 2.6.30: Fix maximum distance for Bamboo tablets

pport for 2.6.30+ kernels") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index e1758e1..281fb80 100644 --- a/2.6.30/w

[Linuxwacom-devel] [PATCH input-wacom 10/10] 2.6.30: Backport MTSCREEN ISDv4 devices

The 2.6.38 and later trees contain a single "MTSCREEN" device that should be backported to the 2.6.30 kernel. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_sys.c | 8 ++-- 2.6.30/wacom_wac.c | 6 ++ 2.6.30/wacom_wac.h | 3 ++- 3 files change

[Linuxwacom-devel] [PATCH input-wacom 02/10] 2.6.30: Correct number of buttons for DTU-1141

The DTU-1141 only has 4 ExpressKeys. This value was incorrectly copied while backporting. Fixes: ee0d2bd259 ("backport: HID: wacom: Set button bits based on a new numbered_buttons") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 2 +- 1 file chan

[Linuxwacom-devel] [PATCH input-wacom 08/10] 2.6.30: Backport missing TABLETPC ISDv4 devices

The 2.6.30 tree is missing the three following ISDv4 devices which use the vanilla TABLETPC type: 0xEC 0xEF and 0x10E. Backporting support is trivial since only the definitions are missing. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 12

[Linuxwacom-devel] [PATCH input-wacom 00/10] 2.6.30: Synchronize wacom_features structures

kernels into the wacom_features structures and leaving it unused. While we're there, fix several bugs and backport support for a few tablets that are simple enough to add. Jason Gerecke (10): 2.6.30: Add missing oVid/oPid data to pen side of split devices 2.6.30: Correct number of buttons for DTU

[Linuxwacom-devel] [PATCH input-wacom 03/10] 2.6.30: Correct resolution of ISDv4 0x5000 tablet

When backporting support for the 0x5000 tablet to the 2.6.30 tree, the maximum pressure value was incorrectly copied. Fixes: ecff90f818 ("Input: wacom: Add support for three new ISDv4 sensors") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 2 +-

[Linuxwacom-devel] [PATCH input-wacom 05/10] 2.6.30: Clean up wacom_features structures

-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 63 -- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index 281fb80..bf40164 100644 --- a/2.6.30/wacom_wac.c +++ b/

[Linuxwacom-devel] [PATCH input-wacom 01/10] 2.6.30: Add missing oVid/oPid data to pen side of split devices

robe order is reversed and touch is detected first. By adding the oVid/oPid data to the pen side as well, the logic will link the devices regardless of probe order. Fixes: afb48f975b ("Add support for WACOM_24HDT and WACOM_27QHDT touch sensors to 2.6.30 / 2.6.36") Signed-off-by: Jason Gerecke <

Re: [Linuxwacom-devel] [PATCH input-wacom 8/8] 3.7: compile under RHEL 7.5

All the prior patches look pretty good. I've got everything staged for pushing except this last patch: On Mon, Mar 5, 2018 at 10:32 AM, Benjamin Tissoires wrote: > We take the same checks for the powersupply API than the one in the 3.17 > branch > > Signed-off-by:

[Linuxwacom-devel] [PATCH input-wacom] Fix -EINVAL error preventing probe of One by Wacom on pre-3.17 kernels

-incorrect data, bailing out of the function with -EINVAL. Ref: https://sourceforge.net/p/linuxwacom/support-requests/54/ Fixes: c6fc15ada5 ("backport: HID: wacom: Add support for One by Wacom (CTL-472 / CTL-672)") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wa

[Linuxwacom-devel] [PATCH] Check both valid and working state when finding new channels

et/p/linuxwacom/bugs/335/?limit=25=1#73fe Ref: https://sourceforge.net/p/linuxwacom/bugs/339/#f940 Ref: https://sourceforge.net/p/linuxwacom/bugs/349/ Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- src/wcmUSB.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/s

[Linuxwacom-devel] [PATCH] Fix tilt-y being overridden with tilt-x

e averaging to seperate function") Signed-off-by: Daniel Ferguson <danielfergu...@me.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- Mailinglist review of the following pull request: https://github.com/linuxwacom/xf86-input-wacom/pull/12 src/wcmFilter.c | 2 +- 1 fil

[Linuxwacom-devel] [PATCH libwacom] data: Remove FIXME from Huion H610 Pro

Evdev codes have been verified, so this FIXME is no longer necessary. Fixes: https://github.com/linuxwacom/libwacom/issues/13 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/huion-h610-pro.tablet | 1 - 1 file changed, 1 deletion(-) diff --git a/data/huion-h610-pro.tablet

[Linuxwacom-devel] [PATCH libwacom] data: Styli shipped with the One by Wacom have two buttons

219c ("data: Add 2nd-generation "One by Wacom"") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/one-by-wacom-m-p.tablet | 2 +- data/one-by-wacom-m-p2.tablet | 2 +- data/one-by-wacom-s-p.tablet | 2 +- data/one-by-wacom-s-p2.tablet | 2 +- 4 files changed, 4 in

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add 2nd-generation "One by Wacom"

h edits all four files shortly. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three,/ So you look at the sixty-fours > On 2 Feb. 2018 3:15 am, "Jason Gerecke

[Linuxwacom-devel] [PATCH libwacom] data: Add 2nd-generation "One by Wacom"

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/one-by-wacom-m-p2.tablet | 23 +++ data/one-by-wacom-s-p2.tablet | 23 +++ 2 files changed, 46 insertions(+) create mode 100644 data/one-by-wacom-m-p2.tablet create mode 100644 da

Re: [Linuxwacom-devel] [PATCH] Add support for DTK-2451 and DTH-2452

Looks good, thanks! Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three,/ So you look at the sixty-fours

Re: [Linuxwacom-devel] [input-wacom] release.sh: Synchronize with changes made to xf86-input-wacom's release.sh

Thanks for bringing over the updates. I see two differences of note that still remain between the xf86-input-wacom and input-wacom version of the script. Looks like the the former doesn't have DRY_RUN support for two error conditions. We might want to make a patch for that too. Reviewed-by: Jason

[Linuxwacom-devel] [PATCH input-wacom 1/2] Guard direct access of 'input->abs' in 2.6.30 tree where necessary

than 2.6.35 rather than 2.6.36. We'll follow that convention even though its not correct... Ref: 898e7d46f8 ("Add Intous5 touch support in 2.6.30+") Fixes: 126ec2dd60 ("Add support to ISDV4 0x100 and 0x101") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/w

[Linuxwacom-devel] [PATCH input-wacom 2/2] Implement support for multitouch value conflict resolution on 2.6.35+

API where available and fallback to direct access when not. It also means that the fixups are now applied to 2.6.35+ kernels. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --

[Linuxwacom-devel] [PATCH] Correct release.sh script documentation

: 32c065ae02 ("add Github to release.sh script") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- release.sh | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/release.sh b/release.sh index d082b38..5017a86 100755 --- a/release.sh

Re: [Linuxwacom-devel] [v2ish xf86-input-wacom 1/2] remove release script code from other projects

the last time we synced in late 2015, so it shouldn't be too hard to backport things manually, but its still something to consider. I'll leave the decision up to you. Either way, my comments in patch 2 aside, this set is Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> [1]:

Re: [Linuxwacom-devel] [v2ish xf86-input-wacom 2/2] add Github to release.sh script

On Mon, Jan 15, 2018 at 11:12 AM, Aaron Armstrong Skomra wrote: > Require at least 1 of Github/Sourceforge. > Add something like the following tag here for tracking: Ref: https://github.com/linuxwacom/xf86-input-wacom/issues/10 > Signed-off-by: Aaron Armstrong Skomra

Re: [Linuxwacom-devel] [PATCH input-wacom] backport: initialize generic device pad variables

A few nitpicks. First, this isn't a backport of an upstream patch, so the 'backport' tag should be removed from the commit subject. On Tue, Jan 9, 2018 at 10:51 AM, Aaron Armstrong Skomra wrote: > Remove complier warnings. > I'd be nice to have an example of the warning being

[Linuxwacom-devel] [PATCH libwacom] Add Coverity integration to .travis.yml

Use the same kind of setup as xf86-input-wacom to run Coverity nightly. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- .travis.yml | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8db3cd4..2a8e98f

[Linuxwacom-devel] [PATCH input-wacom] Additional outbound area fixes

kport: HID: wacom: Fix sensor outbounds and redefine as offsets from each edge") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 26 +- 2.6.36/wacom_wac.c | 26 +- 2 files changed, 26 insertions(+), 26 deletion

[Linuxwacom-devel] [PATCH libwacom 2/2] data: Change ISDv4 50b6 to use USB bus

Original data from `./Lenovo ThinkPad X1 Yoga 2nd/sysinfo.tkM70wemeh` in the wacom-hid-descriptors repository indicates that this is a USB device, not an I2C device. Fixes: d8181a95b7 ("data: Add several ISDv4 tablet definitions") Signed-off-by: Jason Gerecke <jason.gere...@wacom.c

[Linuxwacom-devel] [PATCH libwacom 1/2] data: Add ISDv4 50b8 tablet

https://github.com/linuxwacom/libwacom/issues/12 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/isdv4-50b8.tablet | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 data/isdv4-50b8.tablet diff --git a/data/isdv4-50b8.tablet b/data/isdv4-50b8.tabl

[Linuxwacom-devel] [PATCH libwacom] data: Add Bamboo Pad

https://github.com/linuxwacom/libwacom/issues/6 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/bamboo-pad-wireless.tablet | 23 data/bamboo-pad.tablet | 23 data/layouts/bamboo-pad.svg

[Linuxwacom-devel] [PATCH libwacom] data: Add missing Graphire tablets

https://github.com/linuxwacom/libwacom/issues/3 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/graphire2-4x5.tablet | 28 data/graphire2-5x7.tablet | 28 2 files changed, 56 insertions(+) create mode 10064

[Linuxwacom-devel] [PATCH libwacom v2] data: Add several ISDv4 tablet definitions

m/issues/9 https://github.com/linuxwacom/libwacom/issues/10 https://github.com/linuxwacom/libwacom/issues/11 Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/isdv4-5090.tablet | 14 ++ data/isdv4-5099.tablet | 14 ++ data/isdv4-509d.tablet | 14 ++

Re: [Linuxwacom-devel] CTH-670: Stylus and pad buttons not working with libwacom, working with xsetwacom; how to help?

Hi Alicia, I'll try to answer each question of yours in turn: On Wed, Dec 27, 2017 at 1:20 PM, Alicia Boya wrote: > Hi. > > I'm a bit sad that my Wacom tablet (CTH-670) is so poorly supported in > gnome. The Wacom control panel does not recognize the stylus ("No stylus >

[Linuxwacom-devel] [PATCH] Be more strict about linking to already-linked devices

get linked, and pen2/pad2 left unlinked!). To prevent this, we disallow linking of pad interfaces, which should not be a problem since the pad shouldn't need to use the wcmTouchDevice variable. Fixes: 8bb519ef2b ("Update wcmTouchDevice for touch interface") Signed-off-by: Jason Gerecke &

[Linuxwacom-devel] [PATCH] Allocate 4 buttons for stylus devices (Pro Pen 3D)

t;Add support for kernel's new BTN_STYLUS3 event") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- src/wcmUSB.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 9190fbe..6349d69 100644 --- a/src/wcmUSB.c +++ b/src/wc

[Linuxwacom-devel] [PATCH libwacom] Add several ISDv4 tablet definitions

Adds support for the following tablets: * Lenovo Yoga 720 15" * Lenovo Yoga 720 13" * Lenovo Yoga 260 (0x5090) --- data/isdv4-5090.tablet | 14 ++ data/isdv4-50f1.tablet | 14 ++ data/isdv4-50f8.tablet | 14 ++ 3 files changed, 42 insertions(+) create

[Linuxwacom-devel] [PATCH libwacom] Add .data files for Cintiq Pro 24 and 32

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- data/cintiq-pro-24-p.tablet | 44 +++ data/cintiq-pro-24-pt.tablet | 45 data/cintiq-pro-32.tablet

Re: [Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

On Mon, Dec 18, 2017 at 4:59 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Dec 18, 2017 at 11:46:21AM -0800, Jason Gerecke wrote: >> When enabled through `xsetwacom set button pan`, this causes the >> driver >> to appear to "drag" s

[Linuxwacom-devel] [PATCH input-wacom 6/6] Remove BTN_TOOL_RUBBER and BTN_TOOL_STYLUS2 from DTH1152 capabilities

Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng <ping.ch...@wacom.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 8 +--- 2.6.36/wacom_wac.c | 8 +---

[Linuxwacom-devel] [PATCH input-wacom 5/6] Declare correct pen events for PENPARTNER devices

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 8 +++- 2.6.36/wacom_wac.c | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index 9bc9564..6d63780 100644 --- a/2.6.30/wacom_wac.c +++ b/2.

[Linuxwacom-devel] [PATCH input-wacom 4/6] Rely on 'wacom_setup_numbered_buttons' in 2.6.30 tree

f-by: Ping Cheng <ping.ch...@wacom.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 25 - 1 file changed, 25 deletions(-) diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c index 8e2269c..9bc9564 100644 --- a/2.6.30/wa

[Linuxwacom-devel] [PATCH input-wacom 2/6] Fix size of WACOM_PKGLEN_DTH1152

The plain report format for the DTH-1152 is only 12 bytes in length, not 17. Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng <ping.ch...@wacom.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> -

[Linuxwacom-devel] [PATCH input-wacom 0/6] Misc. fixes

Just a collection of several miscellaneous fixes that Ping had acumulated while working on some other stuff. Jason Gerecke (6): Correct off-by-one error in DTH-1152 pressure range Fix size of WACOM_PKGLEN_DTH1152 Fix over-read of touch width and height values for MobileStudio Pro Rely

[Linuxwacom-devel] [PATCH input-wacom 1/6] Correct off-by-one error in DTH-1152 pressure range

Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng <ping.ch...@wacom.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 2 +- 2.6.36/wacom_wac.c | 2 +- 2.6.38/wacom_wac.c |

[Linuxwacom-devel] [PATCH input-wacom 3/6] Fix over-read of touch width and height values for MobileStudio Pro

m.com> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 8 +--- 2.6.36/wacom_wac.c | 8 +--- 2.6.38/wacom_wac.c | 14 +++--- 3.7/wacom_wac.c| 14 +++--- 4 files changed, 8 insertions(+), 36 deletions(-) diff --git a/2.6.3

[Linuxwacom-devel] [PATCH input-wacom 2/3] Backport support for most keys found on Cintiq Pro 13/16/24/32

Adding support for the KEY_CONTROLPANEL, KEY_ONSCREEN_KEYBOARD, and KEY_BUTTONCONFIG keys is fairly straightforward. Continue the backport started in 286d542658 all the way back to 2.6.30. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.

[Linuxwacom-devel] [PATCH input-wacom 1/3] Add support for Cintiq Pro 24/32

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_wac.c | 22 ++ 2.6.36/wacom_wac.c | 24 2.6.38/wacom_wac.c | 28 3.7/wacom_wac.c| 28 4 files changed, 102 inse

[Linuxwacom-devel] [PATCH input-wacom 3/3] Backport support for the touch on/off switch

8681f6e506 ("backport: HID: wacom: generic: support generic touch switch") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/wacom_sys.c | 8 2.6.30/wacom_wac.c | 37 + 2.6.30/wacom_wac.h | 4 2.6.38/wacom_sys.c |

[Linuxwacom-devel] [PATCH v2 1/3] conf: Add preprobe fdi config to workaround EV_SW issues in HAL

hich don't require it. This commit also adds logic to configure.ac so that only systems which still use HAL will install this file. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- Changes from v1: * Squashed 1st and 2nd patches together * "wacom.fdi" goes back in

[Linuxwacom-devel] [PATCH v2 2/3] Add support for Cintiq Pro 24/32

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes from v1: * Add resolution information to WacomModelDesc table as suggested by Ping. Ping also noticed the touch resolution doesn't look sane (for this,

[Linuxwacom-devel] [PATCH v2 3/3] Add support for Cintiq 27QHDT

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes from v1: * Added resolution information to WacomModelDesc table as requsted by Ping src/wcmUSB.c| 2 ++ src/wcmValidateDevice.c | 2 ++ 2 file

[Linuxwacom-devel] [PATCH 2/2] tools: Prevent use of invalid (negative) fd

tools: add isdv4-serial-debugger test program.") Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- tools/tools-shared.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/tools-shared.c b/tools/tools-shared.c index 3485ac2..c55e8ca 100644 --- a/tools/tool

[Linuxwacom-devel] [PATCH 1/2] Add Coverity integration to .travis.yml

lso be set for cron-triggered jobs. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- .travis.yml | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index eb27e4d..efebe6b 100644 --- a/.travis.yml +++ b/.travis.yml

Re: [Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

hat is to say, eight) to the two, / But you can’t take seven from three,/ So you look at the sixty-fours On Mon, Dec 18, 2017 at 11:46 AM, Jason Gerecke <killert...@gmail.com> wrote: > When enabled through `xsetwacom set button pan`, this causes the > driver > to appear t

[Linuxwacom-devel] [PATCH] Pass current WacomDeviceState through to sendAction

This commit refactors the signature of the sendAction function to take a WacomDeviceState pointer. This change makes it easier to implement the following pan/scroll patch. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- src/wcmCommon.

[Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

When enabled through `xsetwacom set button pan`, this causes the driver to appear to "drag" scrollable window contents by emitting appropriate scroll events as the pen is dragged around. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- include/Xwacom.h | 1

Re: [Linuxwacom-devel] [PATCH 1/4] Detect if HAL fdi configuration needs to be installed

On Sun, Dec 17, 2017 at 3:34 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Dec 15, 2017 at 11:48:50AM -0800, Jason Gerecke wrote: >> RHEL6/CentOS6 use HAL as an Xorg configuration database instead of the >> more modern xorg.conf.d mechanism. Our dri

[Linuxwacom-devel] [PATCH 4/4] Add support for Cintiq 27QHDT

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- src/wcmValidateDevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index d18c76b..0118acb 100644 --- a/src/wcmValidateDevice.c +++ b/src/wcmValidateDevice.c @@ -313,6

  1   2   3   4   5   6   7   8   9   10   >