[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. There a a few call sites that use FILE* which are easy to fix without disrupting anything else. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223139. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files:

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223140. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223135. hhb added a comment. Fix description.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D68442: [lldb] Remove unused variables.

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Fixes the comment in https://reviews.llvm.org/D67993 [lldb] Unifying lldb python path There are 3 places where python site-package path is calculated independently: 1.

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. I ended reverting this because of SymbolFile/Breakpad/symtab.test. It seems that in this test we add symbols after the synthetic entry point symbol is added creating confusion. I think I'll need to change the code that adds symbols in Symtab to explicitly check if we're

[Lldb-commits] [lldb] r373686 - [Python] Remove unused variable

Author: jdevlieghere Date: Thu Oct 3 18:38:57 2019 New Revision: 373686 URL: http://llvm.org/viewvc/llvm-project?rev=373686=rev Log: [Python] Remove unused variable warning: unused variable 'py_func_obj' [-Wunused-variable] PyObject *py_func_obj = m_py_obj; Modified:

[Lldb-commits] [lldb] r373685 - Properly handle instantiation-dependent array bounds.

Author: rsmith Date: Thu Oct 3 18:25:59 2019 New Revision: 373685 URL: http://llvm.org/viewvc/llvm-project?rev=373685=rev Log: Properly handle instantiation-dependent array bounds. We previously failed to treat an array with an instantiation-dependent but not value-dependent bound as being an

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

This revision was automatically updated to reflect the committed changes. Closed by commit rL373680: Explicitly set entry point arch when its thumb (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r373679 - Python3 doesn't seem to allow you to tell whether an object is a class

Author: jingham Date: Thu Oct 3 16:57:34 2019 New Revision: 373679 URL: http://llvm.org/viewvc/llvm-project?rev=373679=rev Log: Python3 doesn't seem to allow you to tell whether an object is a class PyClass_Check and everything it relied on seems gone from Python3.7. So I won't check whether

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68433: SBFile: add a bunch of tests that should eventually work.. This patch add SBFile interfaces to

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68188: allow arbitrary python streams to be converted to SBFile. It's really annoying and confusing to have to keep

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

hhb updated this revision to Diff 223117. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67988/new/ https://reviews.llvm.org/D67988 Files: lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [lldb] r373677 - Forgot to change the header guards on OptionGroupPythonClassWithDict.

Author: jingham Date: Thu Oct 3 16:32:42 2019 New Revision: 373677 URL: http://llvm.org/viewvc/llvm-project?rev=373677=rev Log: Forgot to change the header guards on OptionGroupPythonClassWithDict. I think that's what is confusing the modules build on the bots. Modified:

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk added a comment. Thank you. I've just realized that Phab's "Raw Diff" mode (https://reviews.llvm.org/F10156020) renders the diff in a much clearer way. I suspect reviewing the raw diff will be much easier than reviewing what Phab has rendered here. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rL373675: Pass an SBStructuredData to scripted ThreadPlans on use. (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r373675 - Pass an SBStructuredData to scripted ThreadPlans on use.

Author: jingham Date: Thu Oct 3 15:50:18 2019 New Revision: 373675 URL: http://llvm.org/viewvc/llvm-project?rev=373675=rev Log: Pass an SBStructuredData to scripted ThreadPlans on use. This will allow us to write reusable scripted ThreadPlans, since you can use key/value pairs with known keys

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

shafik added a comment. Thank you for doing this, this looks like an excellent start from a quick review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68422/new/ https://reviews.llvm.org/D68422 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68363: Segregate the Python class + key/value dictionary into a separate OptionGroup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373673: Break out the Python class key/value options into a separate OptionGroup. (authored by jingham, committed by ).

[Lldb-commits] [lldb] r373673 - Break out the Python class & key/value options into a separate OptionGroup.

Author: jingham Date: Thu Oct 3 15:18:51 2019 New Revision: 373673 URL: http://llvm.org/viewvc/llvm-project?rev=373673=rev Log: Break out the Python class & key/value options into a separate OptionGroup. Use this in the scripted breakpoint command. Added some tests for parsing the key/value

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

This revision was automatically updated to reflect the committed changes. Closed by commit rL373670: [process list] make the TRIPLE column wider (authored by wallace, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r373670 - [process list] make the TRIPLE column wider

Author: wallace Date: Thu Oct 3 14:57:01 2019 New Revision: 373670 URL: http://llvm.org/viewvc/llvm-project?rev=373670=rev Log: [process list] make the TRIPLE column wider Summary: Now that `process list` works better on the android platform, the arch aarch64-unknown-linux-android appears

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

This revision was automatically updated to reflect the committed changes. Closed by commit rL373668: [lldb] Calculate relative path for symbol links (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

jingham marked 4 inline comments as done. jingham added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlanPython.h:35 + ThreadPlanPython(Thread , const char *class_name, + StructuredDataImpl *args_data); ~ThreadPlanPython() override;

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

jingham updated this revision to Diff 223096. jingham added a comment. Added the missing REGISTER macros Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68366/new/ https://reviews.llvm.org/D68366 Files: lldb/include/lldb/API/SBStructuredData.h

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

aadsm updated this revision to Diff 223094. aadsm added a comment. Rename lldb-scripts to lldb-python-scripts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68370/new/ https://reviews.llvm.org/D68370 Files: lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk created this revision. vsk added reviewers: labath, shafik, teemperor. Herald added a subscriber: aprantl. Herald added a reviewer: jdoerfert. Split out the logic to parse structure-like types into a separate function, in an attempt to reduce the complexity of ParseTypeFromDWARF. Note: Phab

[Lldb-commits] [lldb] r373662 - [test] Disable TestCustomShell on Linux

Author: jdevlieghere Date: Thu Oct 3 13:49:55 2019 New Revision: 373662 URL: http://llvm.org/viewvc/llvm-project?rev=373662=rev Log: [test] Disable TestCustomShell on Linux ShellExpandArguments is unimplemented on Linux. I need to come up with another way to test this on Linux. Modified:

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

rupprecht added a comment. In D68299#1692503 , @labath wrote: > > FYI, we've root caused some internal lldb asan failures to this patch. I > > don't have a repro yet (my lldb tests seem to be failing locally for > > unrelated reasons) > > This should be

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default,

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlanPython.h:35 + ThreadPlanPython(Thread , const char *class_name, + StructuredDataImpl *args_data); ~ThreadPlanPython() override; Why do we need the

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223080. lawrence_danna added a comment. rm class PresumptivelyValidFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but for the following classes +// we want the file to be

[Lldb-commits] [PATCH] D68366: Parametrize scripted ThreadPlans using SBStructuredData

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. From a purely mechanical point of view, this lgtm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68366/new/ https://reviews.llvm.org/D68366

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223075. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. semicolons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but for the following classes +// we want the file

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223074. lawrence_danna marked 5 inline comments as done. lawrence_danna added a comment. remove unnecessary friends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but for the following classes +// we want the file to be

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1255-1264 + Status Close() override { +assert(m_py_obj); +GIL takeGIL; +if (m_borrowed) +

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223072. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. group all the PythonFile support together in the source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 6 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default,

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223071. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223069. lawrence_danna added a comment. use LLDB_LOGF and add a logging test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223061. wallace added a comment. - Encoding differently the arguments. Now it shouldn't have any corner cases - I'm also sending from the server all the args, including arg0 - In the client, when displaying the process name, I'm using arg0 as fallback if the

[Lldb-commits] [PATCH] D68316: [Host] Return the user's shell from GetDefaultShell

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373644: [Host] Return the users shell from GetDefaultShell (authored by JDevlieghere, committed by ). Herald added a

[Lldb-commits] [lldb] r373644 - [Host] Return the user's shell from GetDefaultShell

Author: jdevlieghere Date: Thu Oct 3 11:29:01 2019 New Revision: 373644 URL: http://llvm.org/viewvc/llvm-project?rev=373644=rev Log: [Host] Return the user's shell from GetDefaultShell LLDB handles shell expansion by running lldb-argdumper under a shell. Currently, this is always /bin/sh on

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223057. lawrence_danna added a comment. assert instead of raise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223056. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. anonymous namespace, and a windows fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223053. lawrence_danna added a comment. no_debug_info_test -> NO_DEBUG_INFO_TESTCASE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223049. lawrence_danna added a comment. We need to obsessively check PyErr_Occurred() before calling into the next python API, even when we'd just catch it a little later. Python APIs will generally work if you don't, but it's undefined behavior to

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL373622: [dsymutil] Tablegenify option parsing (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D68361?vs=222934=223042#toc Repository: rL LLVM CHANGES

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

JDevlieghere added a comment. In D68361#1692988 , @thegameg wrote: > I noticed a bunch of explicit `llvm::` prefixes like `llvm::Error`, > `llvm::StringRef`, etc. Did you intentionally leave that there? No, that's definitely unintentional. I'll fix the

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68326/new/ https://reviews.llvm.org/D68326 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] r373572 - Fix a use-after-free in GDBRemoteCommunicationServerLLGS

Thanks Pavel! On Thu, Oct 3, 2019 at 12:57 AM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Thu Oct 3 00:59:26 2019 > New Revision: 373572 > > URL: http://llvm.org/viewvc/llvm-project?rev=373572=rev > Log: > Fix a use-after-free in GDBRemoteCommunicationServerLLGS > > Although

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

friss accepted this revision. friss added a comment. This seems a little heavyweight, but it reads nicely and gets rid of global state. Go for it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68361/new/ https://reviews.llvm.org/D68361

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. I noticed a bunch of explicit `llvm::` prefixes like `llvm::Error`, `llvm::StringRef`, etc. Did you intentionally leave that there? Otherwise, this LGTM, thanks for the nice cleanup!

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

teemperor updated this revision to Diff 223007. teemperor marked 2 inline comments as done. teemperor added a comment. - Addressed feedback (Thanks Gabor, Adrian & Shafik!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68326/new/ https://reviews.llvm.org/D68326 Files:

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

teemperor marked 11 inline comments as done. teemperor added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:95 DeclContext *Parent, std::size_t Extra) { + if (!(!Parent || >getParentASTContext() == )) { +llvm::errs() << Parent << " | " <<

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath accepted this revision. labath added a comment. Ok, let's try this once more. I took another look at the patch, and I have some more tiny comments, but nothing too major. I'm sorry this took so long. When the topic of parsing both symbol sections came up, I was happy that it was

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

labath added a comment. I think the fact that all of our options *must* have a short version is a pretty serious deficiency in our option parsing system. It results in a lot of unintuitive options that nobody uses because they can't guess what they stand for. But anyway, `-x` seems as good as

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I don't think there's a reasonable way to test this, as these will fail only when running stuff under a different user, or on a system with a paranoid security module.

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68291/new/ https://reviews.llvm.org/D68291

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. In D67994#1691641 , @shafik wrote: > In D67994#1683934 , @labath wrote: > > > IOW, I was not saying you should use "image dump ast" to write the test you > > wanted to write. I was merely

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. Maybe this is my fault since I'm the one who introduced the first bunch of arguments here IIRC, but anyway, I have a feeling all of these dumping options are getting out of hand. Looking at the argument list, you'd expect that -dump-ast, and -dump-clang-ast do something

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. Ok, I think that the major issues are out of the way now. I've done a more careful pass over the file, and I think this is looking pretty good. I am particularly happy with how you've implemented (and tested) the interaction with python exceptions. A bunch of additional

[Lldb-commits] [PATCH] D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This paragraph from that bug is interesting too: According to the 3.11 documentation for the GENERATED source file property, it should be used to indicate "Is this source file generated as

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. BTW, I've had to add (or rather, extend) a fairly ugly hack in r373573 in order to get the new tests running on non-darwin platforms. The reason for that is that the FILE* out typemap needs to get the "mode" of the object in order to construct the python wrapper. My

[Lldb-commits] [lldb] r373573 - "Fix" TestFileHandle.py on non-darwin platforms

Author: labath Date: Thu Oct 3 01:44:33 2019 New Revision: 373573 URL: http://llvm.org/viewvc/llvm-project?rev=373573=rev Log: "Fix" TestFileHandle.py on non-darwin platforms This test exposed a very long standing issue that the python file objects returned by the FILE* typemap were unusable on

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath added a comment. > FYI, we've root caused some internal lldb asan failures to this patch. I > don't have a repro yet (my lldb tests seem to be failing locally for > unrelated reasons) This should be fixed with r373572. BTW, are you sure those reasons were unrelated? If you have had

[Lldb-commits] [PATCH] D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

teemperor created this revision. teemperor added reviewers: JDevlieghere, labath. Herald added subscribers: lldb-commits, abidh, mgorny. Herald added a project: LLDB. We mark debugserver_vers.c as a generated file in CMake. This means that when we run `ninja clean` we end up deleting that file,

[Lldb-commits] [lldb] r373572 - Fix a use-after-free in GDBRemoteCommunicationServerLLGS

Author: labath Date: Thu Oct 3 00:59:26 2019 New Revision: 373572 URL: http://llvm.org/viewvc/llvm-project?rev=373572=rev Log: Fix a use-after-free in GDBRemoteCommunicationServerLLGS Although it's called "GetString", StreamString::GetString actually returns a StringRef. Creating a json object

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222970. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

mgorny added inline comments. Comment at: lldb/scripts/CMakeLists.txt:72 # Install the LLDB python module - install(DIRECTORY ${SWIG_PYTHON_DIR}/ DESTINATION ${SWIG_INSTALL_DIR}) + add_custom_target(lldb-scripts) + add_dependencies(lldb-scripts finish_swig)