xiaobai updated this revision to Diff 93566.
xiaobai added a comment.
Added unit tests for the method and changed the logic according to clayborg's
suggestion.
https://reviews.llvm.org/D31485
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
xiaobai marked an inline comment as done.
xiaobai added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1506-1510
+ // We got an invalid address range back
+ if (!region_info.GetRange().IsValid()) {
+
xiaobai created this revision.
This aims to verify the validity of the response from the debugging
server in GDBRemoteCommunicationClient::GetMemoryRegionInfo. I was
working with ds2 (https://github.com/facebook/ds2) and encountered a bug
that caused the server's response to have a 'size' value
xiaobai marked an inline comment as done.
xiaobai added a comment.
I'll resubmit after removing the extra code in the test and get somebody to
commit for me.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+
+ result =
xiaobai updated this revision to Diff 93674.
xiaobai added a comment.
Removed extra code in unit test
https://reviews.llvm.org/D31485
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
Index:
xiaobai added a comment.
@krytarowski: Thanks for checking! I can set up a NetBSD environment sometime
in the next few days to see what's going on. While it might not be an issue on
this platform, I think it's an issue that MoveCursor() accesses
`m_input_lines[m_input_lines.size() - 1]`
xiaobai created this revision.
I have found a way to segfault lldb in 7 keystrokes! Steps to reproduce:
1. Launch lldb
2. Type `print` and hit enter. lldb will now prompt you to type a list of
expressions, followed by an empty line.
3. Hit enter, indicating the end of your input.
4. Segfault!
xiaobai updated this revision to Diff 97717.
xiaobai added a comment.
Moving test per @labath's suggestion
https://reviews.llvm.org/D32421
Files:
packages/Python/lldbsuite/test/expression_command/multiline/TestMultilineExpressions.py
source/Host/common/Editline.cpp
Index:
xiaobai added a comment.
I do not have commit access. I would appreciate it if you could commit it for
me.
https://reviews.llvm.org/D32421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai created this revision.
Herald added a subscriber: emaste.
I recently ran into a shared object that had a reasonably large number
of absolute symbols. Parsing all the symbols in the shared object took an
unusually long amount of time, so I looked into it and found that when we
created fake
xiaobai created this revision.
With this patch I want to do the following:
When searching for global data symbols, only consider non-externally visible
symbols if we are in the module where they are visible.
I was investigating bug 35043
(https://bugs.llvm.org/show_bug.cgi?id=35043)
and found
xiaobai added a comment.
In https://reviews.llvm.org/D39307#907220, @clayborg wrote:
> It is a nice idea. I would still rather fix this in clang so it doesn't ask
> us about a variable it already knows about. Though this might be a good
> solution until we can fix it for real though. Sean or
xiaobai added a comment.
In https://reviews.llvm.org/D39307#907253, @jingham wrote:
> If I have a library that uses some singleton class that's not exported, and
> I'm debugging code in a client of my library, and the state of my library is
> looking odd based on what it is returning to the
xiaobai added a comment.
In https://reviews.llvm.org/D39307#907248, @davide wrote:
> Thanks, I'll try this patch tomorrow.
> I know this may be a little off, but how hard is to write a test for this so
> that it doesn't regress?
I don't think this would be terribly difficult, and I
xiaobai added a comment.
$ nm /lib64/libm.so.6 | grep " a$"
00093bb0 r a
000c6a80 r a
00093bb0 r a
This is what I get, which seems to match what you said. These are definitely
internal to libm. It's a similar story for the symbol `b`.
xiaobai added a comment.
In https://reviews.llvm.org/D39307#907302, @jingham wrote:
> Note, BTW, we absolutely need some way to say "this symbol from this
> library". But first of all, if we're going to do this you need to be able to
> mix & match within an expression which you can't do with
xiaobai added a comment.
In https://reviews.llvm.org/D39307#907301, @jingham wrote:
> So one of the expectations of people using the debugger is that their whole
> program is available to them wherever they happen to be stopped. People get
> really upset when we break that fiction. I've
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110104, @clayborg wrote:
> That is the only guaranteed way as new headers could come along.
> LLDB.framework doesn't have headers in installed Xcode.app bundles
In that case, adding this test could double build times since we would
xiaobai created this revision.
xiaobai added reviewers: compnerd, sas, labath, beanz, zturner.
Herald added a subscriber: mgorny.
Generating LLDB.framework when building with CMake+Ninja will copy the
lldb-private headers because public_headers contains them, even though we try
to make sure they
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110155, @clayborg wrote:
> sorry, not as a test, but just as a way to figure out if we are getting all
> the needed header files when we modify this framework header file copying
> code.
Ah, yeah. I'm in the process of trying to
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110171, @clayborg wrote:
> In https://reviews.llvm.org/D47278#1110164, @xiaobai wrote:
>
> > In https://reviews.llvm.org/D47278#1110155, @clayborg wrote:
> >
> > > sorry, not as a test, but just as a way to figure out if we are getting
xiaobai added a comment.
I also think that'd be a great idea. The only way I can think to do that would
be to build LLDB.framework using both build systems and compare the two. Is
there a faster way?
https://reviews.llvm.org/D47278
___
xiaobai updated this revision to Diff 148305.
xiaobai added a comment.
Remove SystemInitializerFull.h from framework headers
https://reviews.llvm.org/D47278
Files:
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL04: Move SystemInitializerFull header to source/API
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
xiaobai updated this revision to Diff 148688.
xiaobai added a comment.
Updating to reflect changes in r04
https://reviews.llvm.org/D47278
Files:
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
===
---
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110777, @labath wrote:
> From a layering perspective, it makes sense for SystemInitializerFull to live
> in the outermost layer, as it's the thing which makes sure liblldb pulls in
> all required components. Since it is only included
xiaobai created this revision.
xiaobai added reviewers: labath, clayborg.
It seems to me that files in include/lldb/API/ are headers that should
be exposed to liblldb users. Because SystemInitializerFull.h exposes details of
lldb_private, I think having it there is not the right thing to do.
xiaobai created this revision.
xiaobai added reviewers: clayborg, labath, sas.
Herald added a subscriber: mgorny.
Currently, the liblldb target is treated as the entire framework when
building LLDB.framework with CMake, and treated only as the actual liblldb
library otherwise. In this patch I aim
xiaobai created this revision.
xiaobai added reviewers: eugene, labath, beanz.
Herald added a subscriber: mgorny.
Instead of checking if code compiles, I think it is a better to check
if the symbol exists. This is simpler and should do the same thing.
https://reviews.llvm.org/D47897
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334219: Check for process_vm_readv using CheckSymbolExists
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47897
Files:
xiaobai added a comment.
Thank you @labath for your help. I'm much happier with this!
Repository:
rL LLVM
https://reviews.llvm.org/D48060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334968: Introduce lldb-framework CMake target and centralize
its logic (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai updated this revision to Diff 151598.
xiaobai added a comment.
Labath's suggestion
https://reviews.llvm.org/D48060
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
tools/argdumper/CMakeLists.txt
xiaobai updated this revision to Diff 151840.
xiaobai added a comment.
Rebasing this commit after my framework refactor
https://reviews.llvm.org/D47792
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
resources/LLDB-Info.plist
Index: resources/LLDB-Info.plist
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335014: Fix up Info.plist when building LLDB.framework with
CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47792
xiaobai updated this revision to Diff 151067.
xiaobai added a comment.
Minor fixups pointed out by compnerd
https://reviews.llvm.org/D48060
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
tools/driver/CMakeLists.txt
Index: tools/driver/CMakeLists.txt
xiaobai added inline comments.
Comment at: CMakeLists.txt:145
+ add_dependencies(lldb-suite lldb-framework)
+elseif()
+ if (LLDB_CAN_USE_LLDB_SERVER)
compnerd wrote:
> Shouldn't this be `else()`?
Yup
Comment at: CMakeLists.txt:176
+if
xiaobai updated this revision to Diff 151049.
xiaobai added a comment.
Minor change I forgot to make
https://reviews.llvm.org/D48060
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
tools/driver/CMakeLists.txt
Index: tools/driver/CMakeLists.txt
xiaobai updated this revision to Diff 151048.
xiaobai added a comment.
Updated based on feedback. I would like to get more feedback before I'm
comfortable changing it further and/or committing this.
https://reviews.llvm.org/D48060
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:45
+
+ add_dependencies(lldb-framework liblldb lldb-argdumper lldb-server
lldb-framework-headers)
+ add_dependencies(finish_swig lldb-framework)
labath wrote:
> xiaobai wrote:
> >
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:1
+if (LLDB_BUILD_FRAMEWORK)
+ add_custom_target(lldb-framework)
labath wrote:
> Maybe use early exit here?
Sounds good
Comment at:
xiaobai added inline comments.
Comment at: CMakeLists.txt:140
+# lldb-suite is a dummy target that encompasses all the necessary tools and
+# libraries for building a fully-functioning lldb.
+add_custom_target(lldb-suite)
labath wrote:
> fully-functioning lldb
xiaobai added a comment.
xiaobai added inline comments.
Comment at: cmake/modules/AddLLDB.cmake:102-104
if(LLDB_BUILD_FRAMEWORK)
if(ARG_INCLUDE_IN_FRAMEWORK)
+ add_dependencies(lldb-framework ${name})
labath wrote:
> If you reorder this slightly,
xiaobai updated this revision to Diff 151543.
xiaobai added a comment.
Pavel's suggestions.
https://reviews.llvm.org/D48060
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
tools/driver/CMakeLists.txt
Index:
xiaobai added a comment.
I think this is in a pretty good state. I built LLDB.framework with xcodebuild
and compared it. There are still some discrepancies but this brings us a step
closer to a final working solution.
Comment at: cmake/modules/LLDBFramework.cmake:45
+
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333444: Remove lldb-private headers when building
LLDB.framework with CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai created this revision.
xiaobai added a reviewer: clayborg.
Herald added a subscriber: mgorny.
Instead of assuming that SWIG generated files (e.g. lldb.py) will live
in scripts, we should set it to $LLDB_PYTHON_TARGET_DIR. This variable is set to
scripts, except when building
xiaobai added reviewers: labath, sas.
xiaobai added a comment.
I'm not sure who else would be interested in reviewing this. If you know
somebody, please add them. :)
https://reviews.llvm.org/D47742
___
lldb-commits mailing list
xiaobai added inline comments.
Comment at: scripts/CMakeLists.txt:38
OUTPUT ${LLDB_WRAP_PYTHON}
- OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
sas wrote:
> ...and this path were not the same before your change. Was that a bug that
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333968: Change SWIG output directory when building
LLDB.framework with CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai created this revision.
xiaobai added reviewers: clayborg, labath, sas.
Herald added a subscriber: mgorny.
The LLDB.framework generated when building with CMake + Ninja/Make is
completely missing the clang headers. Although the code to copy them exists, we
don't even generate them unless
xiaobai created this revision.
xiaobai added reviewers: sas, clayborg.
Herald added a subscriber: mgorny.
We weren't using the Info.plist template in resources previously.
When using that template, some of the key's values weren't being populated
because some variables were not being defined. In
xiaobai created this revision.
xiaobai added reviewers: sas, clayborg, labath.
Herald added a subscriber: mgorny.
When you build LLDB.framework with cmake, the liblldb target is built
as a framework. When lldb tools are built with INCLUDE_IN_FRAMEWORK, then
LLDB.framework should depend on those
xiaobai added a comment.
> No existing INCLUDE_IN_FRAMEWORK tool links to liblldb, just it's individual
> components, which is fine. And this is probably a state that we should
> maintain for the future.
I think I agree with you here.
> So, how about we do this instead:
>
> - rename
xiaobai added inline comments.
Comment at: source/API/CMakeLists.txt:184
+ set(EXECUTABLE_NAME "LLDB")
+ set(CURRENT_PROJECT_VERSION "360.99.0")
set_target_properties(liblldb PROPERTIES
clayborg wrote:
> sas wrote:
> > clayborg wrote:
> > > Currently the
xiaobai added a comment.
In https://reviews.llvm.org/D47801#1123933, @labath wrote:
> In https://reviews.llvm.org/D47801#1123895, @xiaobai wrote:
>
> > > - rename INCLUDE_IN_FRAMEWORK to something more neutral (USED_BY_LIBLLDB
> > > or whatever)
> > > - make the liblldb -> tool dependency not
xiaobai abandoned this revision.
xiaobai added a comment.
Going to go with the direction we discussed here. This shouldn't be needed.
https://reviews.llvm.org/D47801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333777: Add dependency on clang-headers when building
LLDB.framework using CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai added a comment.
In https://reviews.llvm.org/D47612#1118615, @labath wrote:
> I don't understand the interactions between lldb framework and clang headers,
> but if there isn't a better person to review this, I'm happy to rubber-stamp
> it. :)
Thanks! I don't quite understand it
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Woohoo!
https://reviews.llvm.org/D48620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai added a comment.
I don't have commit rights, so I need somebody to commit for me. If you can do
that, that'd be great! :)
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai closed this revision.
xiaobai added a subscriber: compnerd.
xiaobai added a comment.
@compnerd committed this for me! r323363
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai added a comment.
Oh, FWIW I tested this on Linux (specifically CentOS) and the test result
summary showed no difference in Success/Failure rate.
https://reviews.llvm.org/D42763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py:39-40
(_COMP_DIR_SYM_LINK_PROP, pwd_symlink))
-lldbutil.run_break_set_by_file_and_line(self, self.src_path,
xiaobai abandoned this revision.
xiaobai added a comment.
It's clear this is not the way forward. The problem I am trying to solve should
be attacked differently. Thanks everyone for your input!
https://reviews.llvm.org/D39307
___
lldb-commits
xiaobai added inline comments.
Comment at: source/Breakpoint/BreakpointSiteList.cpp:191
if (lower != m_bp_site_list.begin()) {
-collection::const_iterator prev_pos = lower;
-prev_pos--;
+auto prev_pos = std::prev(lower);
const BreakpointSiteSP _bp =
xiaobai added inline comments.
Comment at: source/Breakpoint/BreakpointSiteList.cpp:191
if (lower != m_bp_site_list.begin()) {
-collection::const_iterator prev_pos = lower;
-prev_pos--;
+auto prev_pos = std::prev(lower);
const BreakpointSiteSP _bp =
xiaobai added a comment.
Using this patch, I was able to build the lldb framework and install it. I
configured with:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLDB_CODESIGN_IDENTITY=""
-DLLDB_BUILD_FRAMEWORK=1 -DLLDB_USE_SYSTEM_SIX=1 -DCMAKE_INSTALL_PREFIX=""
xiaobai created this revision.
xiaobai added reviewers: labath, sas.
Herald added a subscriber: mgorny.
Previously, I thought that install-liblldb would fail because CMake had
a bug related to installing frameworks. In actuality, I misunderstood the
semantics of `add_custom_target`: the DEPENDS
xiaobai added a comment.
Looks good
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > This
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Awesome! Thank you so much for your patience and contribution. :)
Do you need somebody to commit this for you?
https://reviews.llvm.org/D49779
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
xiaobai requested changes to this revision.
xiaobai added a comment.
This revision now requires changes to proceed.
I think this might actually not do what we want it to do. I've commented inline
with my concerns.
Comment at: cmake/modules/LLDBFramework.cmake:21
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338058: Make framework-header-fix process copied headers
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49779
Files:
xiaobai added a comment.
Tested this by invoking
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLDB_BUILD_FRAMEWORK=1 && ninja
lldb
The resulting framework appears to be the same as before.
https://reviews.llvm.org/D49888
___
lldb-commits
xiaobai created this revision.
xiaobai added a reviewer: labath.
Herald added a subscriber: mgorny.
CMake has a bug in its ninja generator that prevents you from
installing targets that are built with framework support. Therefore, I want to
not rely on CMake's framework support.
xiaobai added a comment.
In https://reviews.llvm.org/D49888#1177929, @labath wrote:
> Can't say I fully understand what's going on, but the changes seem reasonable
> to me.
Let me know if I can clear anything up.
> If there is some public cmake bug describing the issue you ran into, it would
xiaobai updated this revision to Diff 158329.
xiaobai added a comment.
Address comments
https://reviews.llvm.org/D50038
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
xiaobai added a comment.
In https://reviews.llvm.org/D50038#1181817, @labath wrote:
> I am glad filing the cmake bug has paid off. :)
Same! :)
Comment at: cmake/modules/AddLLDB.cmake:81-87
+ # install-liblldb{,-stripped} is the actual target that will install the
+ #
xiaobai added a comment.
In https://reviews.llvm.org/D50038#1184445, @clayborg wrote:
> Might be nice to put a blurb in the build page about this in the MacOS
> section?
Yep, I think that wouldn't be a bad idea. I can handle that in a separate
commit. Might be nice for one of the buildbots
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338594: Introduce install-lldb-framework target (authored by
xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50038
Files:
xiaobai updated this revision to Diff 157713.
xiaobai added a comment.
Add comment pointing to CMake bug report
https://reviews.llvm.org/D49888
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBConfig.cmake
cmake/modules/LLDBFramework.cmake
scripts/CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338154: Stop building liblldb with CMakes framework
functionality (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49888
xiaobai added a comment.
If I understand correctly, this is putting the headers directly into the
framework? That's a pretty good idea :D
In https://reviews.llvm.org/D49779#1174659, @keith wrote:
> It seems like if this was a common occurrence, it would've been fixed
> earlier, so I'm
xiaobai added a comment.
Can't speak much to the contents yet (Haven't done a thorough pass yet) but it
looks like there's a lot of dead code you might want to remove. I commented on
a few of them but there is probably more.
Comment at:
xiaobai updated this revision to Diff 159400.
xiaobai added a comment.
Reducing redundancy and changing some wording around.
https://reviews.llvm.org/D50362
Files:
www/build.html
Index: www/build.html
===
--- www/build.html
xiaobai added a comment.
Hurray for more layering improvements!
It looks like Raphael recently committed a modulemap for compiling the LLDB
headers into C++ modules (`include/lldb/module.modulemap`) that has a reference
to Predicate.h in in Host. You should probably modify that as well.
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB339155: Add instructions for building LLDB on Mac OS X
with CMake (authored by xiaobai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50362?vs=159400=159540#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340560: [cmake] Add option to skip building lldb-server
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
xiaobai accepted this revision.
xiaobai added a comment.
Regardless of compatibility, the man page for sed on OSX recommends not having
a zero length extension while editing the file in place. LGTM.
https://reviews.llvm.org/D51374
___
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337311: Invert dependency between lldb-framework and
lldb-suite (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49406
xiaobai added a comment.
In https://reviews.llvm.org/D49282#1163517, @labath wrote:
> I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
> different than SKIP_DEBUGSERVER), but while looking at this I got an idea for
> a possible improvement.
How is it subtly different?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337202: [CMake] Give lldb tools functional install targets
when building LLDB.framework (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai added a comment.
In https://reviews.llvm.org/D49282#1164050, @labath wrote:
> In https://reviews.llvm.org/D49282#1163853, @xiaobai wrote:
>
> > In https://reviews.llvm.org/D49282#1163517, @labath wrote:
> >
> > > I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
> >
xiaobai created this revision.
xiaobai added reviewers: sas, labath.
Herald added a subscriber: mgorny.
Currently, if you build lldb-framework the entire framework doesn't
actually build. In order to build the entire framework, you need to actually
build lldb-suite. This abstraction doesn't feel
xiaobai updated this revision to Diff 155790.
xiaobai added a comment.
Accidentally merged the contents of two commits into one. Removing the contents
of one of the commits from this one.
https://reviews.llvm.org/D49406
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
xiaobai created this revision.
xiaobai added reviewers: sas, smeenai, labath, davide.
Herald added a subscriber: mgorny.
This install command is used to install all the python modules and
python bindings. Currently the only way to install it is this:
`cmake -P
xiaobai planned changes to this revision.
xiaobai added a comment.
This isn't quite doing what I want yet. I intend on adding an install target.
https://reviews.llvm.org/D48993
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
xiaobai abandoned this revision.
xiaobai added a comment.
Gonna take some time to rethink and better understand this.
https://reviews.llvm.org/D48993
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
1 - 100 of 1319 matches
Mail list logo
