Author: ki.stfu
Date: Tue Apr 4 03:00:28 2017
New Revision: 299417
URL: http://llvm.org/viewvc/llvm-project?rev=299417=rev
Log:
Enable lldm-mi commands -stack-list-locals -stack-list-variables and
-var-create to work only with variables in scope
Patch by ayuckhulk
Reviewers: abidh,
ki.stfu requested changes to this revision.
ki.stfu added inline comments.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
if (!bOk)
-return m_pUnkwn;
+return kUnresolvedValue;
After couple of
ki.stfu accepted this revision.
ki.stfu added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder = "{...}";
+
ki.stfu requested changes to this revision.
ki.stfu added inline comments.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder =
ki.stfu added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:676-677
# If not found, disable the lldb-mi tests
-lldbMiExec = None
-if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"):
-lldbMiExec =
Author: ki.stfu
Date: Thu Sep 22 00:08:41 2016
New Revision: 282135
URL: http://llvm.org/viewvc/llvm-project?rev=282135=rev
Log:
Fix parsing expressions to evaluate with spaces and optional args (MI)
Summary:
When extracting options for long options (starting with `--`), the use of
This revision was automatically updated to reflect the committed changes.
ki.stfu marked an inline comment as done.
Closed by commit rL282135: Fix parsing expressions to evaluate with spaces and
optional args (MI) (authored by ki.stfu).
Changed prior to commit:
ki.stfu marked an inline comment as done.
Comment at: tools/lldb-mi/MICmdArgValOptionLong.cpp:187-188
@@ -186,12 +186,4 @@
const MIuint nArgIndex) {
- CMIUtilString::VecString_t vecOptions;
- MIuint nOptionsPresent = 0;
- if
ki.stfu updated this revision to Diff 72136.
ki.stfu added a comment.
Rebase againt ToT; Apply clang-format & autopep; Minor fix in condition
https://reviews.llvm.org/D24202
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py
tools/lldb-mi/MICmdArgValOptionLong.cpp
ki.stfu added a comment.
yes
Repository:
rL LLVM
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Hi! Please add tests for commands that you fixed. I'll take a look later this
week.
Repository:
rL LLVM
https://reviews.llvm.org/D24711
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: ki.stfu
Date: Mon Sep 12 02:14:51 2016
New Revision: 281199
URL: http://llvm.org/viewvc/llvm-project?rev=281199=rev
Log:
Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)
Summary: This patch adds a new test and fixes extra new-line before exit
Reviewers: abidh
Subscribers:
This revision was automatically updated to reflect the committed changes.
ki.stfu marked an inline comment as done.
Closed by commit rL281199: Add MiSyntaxTestCase.test_lldbmi_output_grammar test
(MI) (authored by ki.stfu).
Changed prior to commit:
ki.stfu updated this revision to Diff 70979.
ki.stfu marked 6 inline comments as done.
ki.stfu added a comment.
Rebase against ToT; Apply autopep8
https://reviews.llvm.org/D9740
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
tools/lldb-mi/MIDriver.cpp
Index:
ki.stfu updated this revision to Diff 70977.
ki.stfu added a comment.
Herald added a subscriber: ki.stfu.
Rebase against ToT
https://reviews.llvm.org/D9740
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
tools/lldb-mi/MIDriver.cpp
Index:
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
@edmunoz, good job. Thank you! Would you like me to commit?
Repository:
rL LLVM
https://reviews.llvm.org/D24202
___
lldb-commits
ki.stfu added a comment.
PS: I think it will look like:
Index: tools/lldb-mi/MICmdCmdBreak.cpp
===
--- tools/lldb-mi/MICmdCmdBreak.cpp (revision 281191)
+++ tools/lldb-mi/MICmdCmdBreak.cpp (working copy)
@@ -84,8 +84,7
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Hi @pieandcakes!
I'm sorry for the delay, have a lot of work. Please folllow my inline comments,
rebase against ToT and update CL's summary.
Comment at:
ki.stfu requested changes to this revision.
ki.stfu added a reviewer: ki.stfu.
ki.stfu added a comment.
This revision now requires changes to proceed.
You forgot to remove its header file
https://reviews.llvm.org/D23883
___
lldb-commits mailing
Author: ki.stfu
Date: Mon Sep 12 00:25:33 2016
New Revision: 281191
URL: http://llvm.org/viewvc/llvm-project?rev=281191=rev
Log:
Fix about a dozen compile warnings
Summary:
It fixes the following compile warnings:
1. '0' flag ignored with precision and ‘%d’ gnu_printf format
2. enumeral and
ki.stfu updated this revision to Diff 70976.
ki.stfu added a comment.
Apply clang-format
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
ki.stfu marked an inline comment as done.
Comment at: source/Target/StackFrame.cpp:1425
@@ -1423,3 +1424,3 @@
- if (offset >= pointee->GetByteSize()) {
+ if (offset > 0 && uint64_t(offset) >= pointee->GetByteSize()) {
int64_t index = offset / pointee->GetByteSize();
ki.stfu updated this revision to Diff 70656.
ki.stfu marked 3 inline comments as done.
ki.stfu added a comment.
Fixes per Zachary's comments
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
ki.stfu updated this revision to Diff 70654.
ki.stfu added a comment.
Apply clang-format
https://reviews.llvm.org/D24331
Files:
source/Core/Log.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
ki.stfu added a comment.
BTW, the following warnings remain:
1. unrecognized command line option ‘-Wno-vla-extension’
2. unrecognized command line option ‘-Wno-deprecated-register’
3. comparison of unsigned expression >= 0 is always true
[2782/3295] Building CXX object
ki.stfu created this revision.
ki.stfu added reviewers: clayborg, jingham, zturner.
ki.stfu added a subscriber: lldb-commits.
It fixes the following compile warnings:
1. '0' flag ignored with precision and ‘%d’ gnu_printf format
2. enumeral and non-enumeral type in conditional expression
3.
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm if tests are passed
https://reviews.llvm.org/D23882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ki.stfu added a comment.
Yes, that's what I said. We have to throw an error if location is not passed
(even if -f is specified).
Repository:
rL LLVM
https://reviews.llvm.org/D23026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Hi Hans!
The author of this commit asks me is there a chance to include this changes
to 3.9 release? I'm not sure about our policy when RC has already been
tagged.
On Fri, Jul 29, 2016 at 9:01 AM, Ilia K via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: ki.stfu
> Date
ki.stfu added a comment.
Hi!
So, what you want is to create pending breakpoints without locations?
I'm not sure it's the correct use of -break-insert so that lldb-mi has to exit
with an error in this case. The other question is why it doesn't do that and
sets BPs without locations even if -f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277117: Fix -break-insert not working when using absolute
paths (MI) (authored by ki.stfu).
Changed prior to commit:
https://reviews.llvm.org/D22902?vs=66055=66079#toc
Repository:
rL LLVM
Author: ki.stfu
Date: Fri Jul 29 01:01:20 2016
New Revision: 277117
URL: http://llvm.org/viewvc/llvm-project?rev=277117=rev
Log:
Fix -break-insert not working when using absolute paths (MI)
Summary:
When trying to parse the -break-insert arguments as a named location, the
string parsing was not
ki.stfu added a comment.
Could you add a test case for this in
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py?
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275381: Fix -break-enable/-break-disable commands (MI)
(authored by ki.stfu).
Changed prior to commit:
http://reviews.llvm.org/D21757?vs=63928=63932#toc
Repository:
rL LLVM
Author: ki.stfu
Date: Thu Jul 14 02:43:14 2016
New Revision: 275381
URL: http://llvm.org/viewvc/llvm-project?rev=275381=rev
Log:
Fix -break-enable/-break-disable commands (MI)
* Previously -break-enable mistakenly set BP's enabled flag to false.
* These commands print fake =breakpoint-modified
ki.stfu updated this revision to Diff 63928.
ki.stfu added a comment.
add checks for =breakpoint-modified
http://reviews.llvm.org/D21757
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdCmdBreak.cpp
Index: tools/lldb-mi/MICmdCmdBreak.cpp
ki.stfu accepted this revision.
ki.stfu added a comment.
@faxue, thank you for your patch! The fixes look good, but if you don't mind I
gonna improve your tests. After that I'll commit this patch.
Repository:
rL LLVM
http://reviews.llvm.org/D21757
ki.stfu added a comment.
Hi Chuck! Sorry for delay, didn't see this CL. I'll check it tomorrow, so pls
wait one more day.
Repository:
rL LLVM
http://reviews.llvm.org/D21757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ki.stfu added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-mi/symbol/symbol_list_lines_inline_test.h:20
@@ -19,3 +19,3 @@
{
-return a + b;
+return a + b; // FUNC_mfunc
}
and could you pick it up at 1 line
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
clang-format your changes please (there are many deviations from the coding
style)
I'll check it on Linux and say if everything is OK.
Comment at:
ki.stfu added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1536-1537
@@ -1508,1 +1535,4 @@
+bool has_path = (file_spec.GetDirectory().AsCString() != 0);
+int ncus = module->GetNumCompileUnits();
+for (size_t i = 0; i <
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:226
@@ -225,3 @@
-// Skip entries which don't match the desired source.
-if (strWantFile != strFile)
-continue;
Is strWantFile needed? Seems it's
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true,
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true,
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void ParseCommonArgs();
How about renaming it to AddCommonArgs and making it protected?
Comment at:
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void AddCommonArgs();
abidh wrote:
> Changed name.
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D14060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ki.stfu accepted this revision.
ki.stfu added a comment.
lgtm
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu added a comment.
But you still should get lgtm from @clayborg and @granata.enrico before landing.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Update the summary + a few inline comments below.
Comment at: test/tools/lldb-mi/startup_options/TestMiStartupOptions.py:13-31
@@ -12,3 +12,21 @@
ki.stfu created this revision.
ki.stfu added reviewers: abidh, brucem.
ki.stfu added subscribers: abidh, brucem, lldb-commits.
Allow to construct CMIUtilString using std::string directly (MI)
This patch cleans up lldb-mi code, and serves to simplify
the following case:
```
std::string
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdInterpreter.cpp:166
@@ -165,3 +165,3 @@
m_miCmdData.strMiCmdToken = strNum.c_str();
}
brucem wrote:
> Can this one be changed too?
Sure.
http://reviews.llvm.org/D13158
ki.stfu updated this revision to Diff 35703.
ki.stfu added a comment.
A little fix as @brucem requested; Remove CMIUtilString(const char *const
*vpData) and CMIUtilString(const char *vpData, size_t nLen) ctors; Cleanup
CMIUtilString::operator=(const std::string )
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:191-193
@@ -182,1 +190,5 @@
{
+CMIUtilString summary;
+if (TryGetValueSummary(summary))
+return summary;
+
evgeny777 wrote:
> ki.stfu wrote:
> > ```
> > const
ki.stfu added a comment.
I perceive it as a simple patch, so I am going to go ahead.
http://reviews.llvm.org/D13158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: include/lldb/API/SBTypeSummary.h:125-126
@@ -124,1 +124,4 @@
+
+bool
+DoesPrintValue (const SBValue& value);
You can use clang-format
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248566: Allow to construct CMIUtilString using std::string
directly + cleanup… (authored by ki.stfu).
Changed prior to commit:
http://reviews.llvm.org/D13158?vs=35703=35708#toc
Repository:
rL LLVM
Author: ki.stfu
Date: Fri Sep 25 03:28:58 2015
New Revision: 248566
URL: http://llvm.org/viewvc/llvm-project?rev=248566=rev
Log:
Allow to construct CMIUtilString using std::string directly + cleanup
CMIUtilString (MI)
Summary:
Allow to construct CMIUtilString using std::string directly +
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Your fix in assign operator looks good. Others go out of scope of this CL, so
please revert them.
Comment at: tools/lldb-mi/MIUtilString.cpp:41
@@ -40,3 +40,3 @@
ki.stfu requested changes to this revision.
ki.stfu added a comment.
Please, next time make a patch with full context:
svn diff --diff-cmd diff -x "-U" > mypatch.txt
This will help us to reduce the review time.
Comment at:
ki.stfu added a comment.
i. e. +1 with @zturner
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu added a comment.
In http://reviews.llvm.org/D12899#248657, @tberghammer wrote:
> In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote:
>
> > In http://reviews.llvm.org/D12899#248648, @zturner wrote:
> >
> > > One possible solution is to make an lldb-all target.
> >
> >
> > As I said,
ki.stfu added a comment.
In http://reviews.llvm.org/D12899#248648, @zturner wrote:
> One possible solution is to make an lldb-all target.
As I said, it would much better rather than changing lldb dependencies. But I'm
still not sure, do we really need something like lldb-all? Why we can't use
ki.stfu added a subscriber: clayborg.
ki.stfu added a comment.
For me it looks like a workaround because here is assumed the
SBProcess::Destroy will do all required work.
@clayborg, is it permissible to make a Process::Destroy(force_kill=false) for a
running process?
If so, it's a bug in lldb
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/tools/lldb-mi/symbol/main.cpp:12
@@ +11,3 @@
+// included in -symbol-list-lines main.cpp, by checking that all the lines
+// are between 20 and 29.
+// line 13
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Source code looks good but please move the test to TestMiData.py.
Comment at: test/tools/lldb-mi/variable/TestMiVar.py:39-42
@@ -38,2 +38,6 @@
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244573: Add size field to library load event (MI) (authored
by ki.stfu).
Changed prior to commit:
http://reviews.llvm.org/D11574?vs=31038id=31772#toc
Repository:
rL LLVM
70 matches
Mail list logo
