[jira] [Comment Edited] (LOG4J2-1305) Binary Layout

2016-03-03 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177735#comment-15177735 ] Ralph Goers edited comment on LOG4J2-1305 at 3/3/16 12:23 PM: -- Hessian

[jira] [Commented] (LOG4J2-1305) Binary Layout

2016-03-03 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177735#comment-15177735 ] Ralph Goers commented on LOG4J2-1305: - Hessian is a protocol - https://en.m.wikipedia.org/wiki

[jira] [Commented] (LOG4J2-1305) Binary Layout

2016-03-03 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177563#comment-15177563 ] Ralph Goers commented on LOG4J2-1305: - I was thinking of hessian. > Binary Lay

Re: [1/3] logging-log4j2 git commit: LOG4J2-1227 Test if the event is null before using it, to avoid NullPointerException. Add some unit tests. Submitted by: Olivier Lemasle <o.lema...@gmail.com>

2016-03-02 Thread Ralph Goers
It appears that the newly added testEventMapMessage is not working. Ralph > On Mar 2, 2016, at 8:08 PM, mattsic...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 60d1ccd93 -> a57fc35b9 > > > LOG4J2-1227 >Test if the event is null before using it,

Re: [jira] [Updated] (INFRA-8279) Add Log4j2 to Windows Buildbot

2016-03-02 Thread Ralph Goers
I would suggest that if we want a build job for Windows that we do it in Jenkins. We seem to have very little control over buildbot and watching failed builds go by for the last year without the ability to do anything has completely persuaded me to stay away from it. Ralph > On Mar 2, 2016,

Re: Build failed in Jenkins: Log4j 2.x #1750

2016-03-02 Thread Ralph Goers
Javadoc needing the import... > > Gary > > On Wed, Mar 2, 2016 at 5:40 AM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > Gary, Did you remove more than you should have? > > Ralph > > > On Mar 2, 2016, at 2:

Re: One Include to rule them all

2016-03-02 Thread Ralph Goers
sense that it does not require new Configuration elements or attributes. > I assume that you just list them one after the other in some sys prop. > Otherwise, I would not want Log4j hunting all over my classpath for config > files and merging them all, that would not be good IMO. >

Re: One Include to rule them all

2016-03-02 Thread Ralph Goers
I never really wanted to do includes. I would prefer to support multiple configuration files that are merged - see LOG4J2-494. I view the XInclude for XML files as a special case. If I did want to support includes I would not want to allow a monitorInterval on the include element. The value

Re: Build failed in Jenkins: Log4j 2.x #1750

2016-03-02 Thread Ralph Goers
Gary, Did you remove more than you should have? Ralph > On Mar 2, 2016, at 2:56 AM, Apache Jenkins Server > wrote: > > See > > Changes: > > [ggregory] [LOG4J2-1299] Add pattern converter for thread id and

Re: Multiple Markers vs. Marker multiple inheritance.

2016-03-01 Thread Ralph Goers
warn("...", objects); > ... > logger.throwing(ex4); > > > What I want is do deny log events originating from lines commented with // > GARY_MARKER. > > If I define (1) GARY and (2) GARY_THROWING to inherit from THROWING, would > this work? Woul

Re: Multiple Markers vs. Marker multiple inheritance.

2016-03-01 Thread Ralph Goers
> > I was hopping to filter on the same marker "GARY", but how? > > The only way I thought to do this now is for my custom marker to inherit from > the Log4j Core "THROWING" marker, but that won't even work since filtering on > "GARY" will not d

Re: Education

2016-02-29 Thread Ralph Goers
top using > commons-logging / SLF4J and use Log4J 2 directly instead. > > So I am one of the people who "think that log4j-api isn't analogous to > slf4j-api where log4j-core is like logback", and I like it that way. > > On Mon, Feb 29, 2016 at 4:41 PM, Ralph Goers

Re: Education

2016-02-29 Thread Ralph Goers
at 03:38, Mikael Ståldal <mikael.stal...@magine.com > <mailto:mikael.stal...@magine.com>> wrote: > Why is it important to point out that Log4j 2 has API / impl separation? > > On Fri, Feb 26, 2016 at 10:33 PM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go

Re: [2/2] logging-log4j2 git commit: [LOG4J2-1300] Make remaing StrLookups serializable.

2016-02-28 Thread Ralph Goers
StrLookup and StrSubstitutor originated in Commons but were modified to support log events. Again, who needs to serialize these? What is the use case? Ralph > On Feb 28, 2016, at 10:55 PM, Matt Sicker wrote: > > No, that's not it. That's a custom class for the GC-free epic.

Re: [1/2] logging-log4j2 git commit: [LOG4J2-1300] Make appender managers and dependencies serializable.

2016-02-28 Thread Ralph Goers
Why are you doing this? Ralph > On Feb 28, 2016, at 10:33 PM, Matt Sicker wrote: > > Not yet, but that's an important part of this to at least determine which > ones are even possible to serialize. > >> On 28 February 2016 at 23:30, Gary Gregory

[jira] [Comment Edited] (LOG4J2-1300) Make plugins consistently implement Serializable

2016-02-28 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171528#comment-15171528 ] Ralph Goers edited comment on LOG4J2-1300 at 2/29/16 7:30 AM: -- Why do you

[jira] [Commented] (LOG4J2-1300) Make plugins consistently implement Serializable

2016-02-28 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171528#comment-15171528 ] Ralph Goers commented on LOG4J2-1300: - Why do you care? Hat is the use case for serializing

Re: Education

2016-02-26 Thread Ralph Goers
Not on that site. The issue he is bringing up was discusses a few years ago either on one of our lists. Ralph > On Feb 26, 2016, at 2:24 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > Is that worth pointing out? > > Gary > > On Fri, Feb 26, 2016 at 1:0

Re: Education

2016-02-26 Thread Ralph Goers
> > Yeah, seems a little strong a reply. He sure has a lot of emotion attached to > the issue! > > Gary > > On Fri, Feb 26, 2016 at 12:13 PM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > > Wow. Ceki sure too

Re: Education

2016-02-26 Thread Ralph Goers
Wow. Ceki sure took offense to that! Ralph > On Feb 26, 2016, at 11:18 AM, Gary Gregory wrote: > > https://github.com/swagger-api/swagger-parser/issues/209#issuecomment-189377712 > > >

Re: Education

2016-02-26 Thread Ralph Goers
It more or less was. There was no separation of the API from the impl. Ralph > On Feb 26, 2016, at 12:32 PM, Matt Sicker wrote: > > Do people think log4j1 was just an implementation, too? > > On 26 February 2016 at 12:18, Gary Gregory

Re: [GitHub] commons-lang pull request: StrSubstitutor can preserve escapes

2016-02-25 Thread Ralph Goers
I don't see how it can hurt. Ralph > On Feb 25, 2016, at 7:00 PM, Gary Gregory wrote: > > Just FYI, is that something we can use? > > Should we port again? > > Gary > -- Forwarded message -- > From: samuelkarp > Date: Thu, Feb 25,

Re: Would it be worth it to migrate other CopyOnWriteArrayList usages to an AppenderControlArraySet-style class?

2016-02-25 Thread Ralph Goers
Do you have a list? Ralph > On Feb 25, 2016, at 1:07 PM, Matt Sicker wrote: > > So far I've found a couple places we use a CopyOnWriteArrayList for listeners > in StatusLogger and core.LoggerContext. I could refactor these usages to use > a custom set-like class like we use

Re: Update of datetime package

2016-02-25 Thread Ralph Goers
I would look at the commit history to see if any custom changes were made. Ralph > On Feb 25, 2016, at 12:44 AM, Gary Gregory wrote: > > Hi All" > > I ported locally (as simply as )possible the current git master from Apache > Commons Lang's fast date classes. I ran a

Re: GC lean way to convert StringBuilder to byte[]

2016-02-24 Thread Ralph Goers
I haven’t had 5 minutes to spare in 3 days. I will try to look at this tonight. Ralph > On Feb 24, 2016, at 3:46 PM, Gary Gregory wrote: > > On Tue, Feb 23, 2016 at 8:23 AM, Gary Gregory > wrote: > I see we now

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

2016-02-23 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159126#comment-15159126 ] Ralph Goers commented on LOG4J2-1297: - Why do loggers all need to be asynchronous? It isn't obvious

[jira] [Commented] (LOG4J2-1296) Add MessageFactory that reuses a cached Message instance

2016-02-23 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159104#comment-15159104 ] Ralph Goers commented on LOG4J2-1296: - I think saying "the whole epic goes out the window"

[jira] [Commented] (LOG4J2-1290) Add SoTimeout value config support when use SocketAppender

2016-02-22 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157161#comment-15157161 ] Ralph Goers commented on LOG4J2-1290: - Netty is useful because it handles failing connections better

[jira] [Commented] (LOG4J2-1290) Add SoTimeout value config support when use SocketAppender

2016-02-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156501#comment-15156501 ] Ralph Goers commented on LOG4J2-1290: - Well, waiting forever is NOT a good thing. Personally though

Re: FlowMessageFactory

2016-02-21 Thread Ralph Goers
t; Gary > > On Sun, Feb 21, 2016 at 5:20 PM, Matt Sicker <boa...@gmail.com > <mailto:boa...@gmail.com>> wrote: > Considering every log message in PropertiesUtil is an error message, maybe > that class could just use System.err instead. > > On 21 February 2016 at 1

Re: logging-log4j2 git commit: Add PerformanceSensitive annotation.

2016-02-21 Thread Ralph Goers
I like this. A lot of the logging code is critical path/performance sensitive. Allowing a “reason” or reasons helps a lot. Ralph > On Feb 21, 2016, at 9:25 PM, Matt Sicker wrote: > > Syntax-wise, you can use either @PerformanceSensitive("foo") or >

[jira] [Commented] (LOG4J2-1293) GC-friendly Message API enhancement

2016-02-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156486#comment-15156486 ] Ralph Goers commented on LOG4J2-1293: - I kind of wish I had thought of this in the first place. I

Re: FlowMessageFactory

2016-02-21 Thread Ralph Goers
zing s class constant, the failure resulted in a > NoClassDefError... > So I reverted to System.getProperties. > I can take another look, or if someone else has time, please feel free to > replace this with PropertiesUtil. > > On Saturday, 20 February 2016, Ralph Goers <ral

[jira] [Commented] (LOG4J2-1278) Garbage-free logging API (no varargs/autoboxing)

2016-02-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156190#comment-15156190 ] Ralph Goers commented on LOG4J2-1278: - Why 6 parameters? What is the 80-20 rule on this? I would

Re: release possibilities

2016-02-21 Thread Ralph Goers
I can’t do a release this weekend and would really like traceEntry(gson->toJson(request)) and traceExit(gson->toJson(response)) or their Message variations to work in the next release. Ralph > On Feb 21, 2016, at 4:48 AM, Remko Popma wrote: > > I am comfortable with

Re: [compress] BZip2 block size is invalid

2016-02-21 Thread Ralph Goers
I am wondering if this isn’t a multi-threading problem. When a rollover occurs the compression action is delegated to a separate thread so the main thread can get back to logging. It may simply be that the test case is trying to check the compressed file before it has actually finished being

Re: Jenkins build became unstable: Log4j 2.x #1692

2016-02-19 Thread Ralph Goers
It appears one of the MessageSupplier tests is now failing. Ralph > On Feb 19, 2016, at 5:11 PM, Apache Jenkins Server > wrote: > > See > > >

Re: Default flow logging text entry/exit

2016-02-19 Thread Ralph Goers
I am OK with that. Ralph > On Feb 19, 2016, at 5:15 PM, Gary Gregory wrote: > > Hi, > > At work our custom flow logging use "Enter" and "Exit" instead of "entry" and > "exit". > > First the word should be in init cap IMO since the word starts a "sentence": > >

Re: MessageSupplier and Supplier

2016-02-19 Thread Ralph Goers
Yes, I am OK with this. Ralph > On Feb 19, 2016, at 1:28 PM, Gary Gregory wrote: > > If we all agree that MS should be deprecated then yes, let's have one task to > remove new 2.6 MS APIs and deprecate existing 2.5 ones. > > Ralph? Are you OK with this? > > Then we

Re: FlowMessageFactory

2016-02-19 Thread Ralph Goers
I should have qualified this to say that the log4j2.component.properties file is managed by the PropertiesUtil class. Properties should be access through its methods. Ralph > On Feb 19, 2016, at 1:09 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > > I see two new prop

Re: FlowMessageFactory

2016-02-19 Thread Ralph Goers
gt;> wrote: > >> > >> I see, so there actually is a use case to remove the need for the > >> isTraceEnabled check with the Supplier param... > >> > >> Sent from my iPhone > >> > >> On 2016/02/19, at 14:10, Ralph Goers <ralph.go...@ds

Re: FlowMessageFactory

2016-02-18 Thread Ralph Goers
> That's fine with me. > > Gary > > > > > > > On Friday, 19 February 2016, Gary Gregory <garydgreg...@gmail.com > > <mailto:garydgreg...@gmail.com>> wrote: > >> > >> On Thu, Feb 18, 2016 at 4:22 PM, Ralph Goers <ralph.go...@dslextreme.

Re: FlowMessageFactory

2016-02-18 Thread Ralph Goers
Is it really necessary to have getLogger support FlowMessageFactory? These messages are really meant as wrappers for other messages. so I am not even sure what it would mean for getLogger() to support that. How would it know what Message it is wrapping? I am really getting sorry that I

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-17 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150505#comment-15150505 ] Ralph Goers commented on LOG4J2-1270: - Well, that is surprising. It is actually faster than your

[jira] [Commented] (LOG4J2-1271) ParameterizedMessage optimization

2016-02-17 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150504#comment-15150504 ] Ralph Goers commented on LOG4J2-1271: - That doesn't avoid a call to toString(), it just happens

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-17 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150402#comment-15150402 ] Ralph Goers commented on LOG4J2-1270: - Can you do me a favor and modify NoGcLayout to use

[jira] [Comment Edited] (LOG4J2-1271) ParameterizedMessage optimization

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149949#comment-15149949 ] Ralph Goers edited comment on LOG4J2-1271 at 2/17/16 5:56 AM: -- The way I

[jira] [Commented] (LOG4J2-1271) ParameterizedMessage optimization

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149949#comment-15149949 ] Ralph Goers commented on LOG4J2-1271: - The way I would prefer to handle this is to not call

[jira] [Commented] (LOG4J2-1274) Layout improvements to enable avoiding temporary object allocation

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149616#comment-15149616 ] Ralph Goers commented on LOG4J2-1274: - I am fine with this. > Layout improvements to enable avoid

[jira] [Issue Comment Deleted] (LOG4J2-1274) Layout improvements to enable avoiding temporary object allocation

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers updated LOG4J2-1274: Comment: was deleted (was: If you add it to the interface I would hope the method could be added

[jira] [Commented] (LOG4J2-1274) Layout improvements to enable avoiding temporary object allocation

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149615#comment-15149615 ] Ralph Goers commented on LOG4J2-1274: - If you add it to the interface I would hope the method could

[jira] [Comment Edited] (LOG4J2-1271) ParameterizedMessage optimization

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149599#comment-15149599 ] Ralph Goers edited comment on LOG4J2-1271 at 2/17/16 12:46 AM: --- I believe

[jira] [Commented] (LOG4J2-1271) ParameterizedMessage optimization

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149599#comment-15149599 ] Ralph Goers commented on LOG4J2-1271: - I believe the first 2 bullets are being done to avoid

[jira] [Comment Edited] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149594#comment-15149594 ] Ralph Goers edited comment on LOG4J2-1270 at 2/17/16 12:39 AM: --- Actually

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149594#comment-15149594 ] Ralph Goers commented on LOG4J2-1270: - Actually, it occurs to me that you can't use a ThreadLocal

[jira] [Comment Edited] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149573#comment-15149573 ] Ralph Goers edited comment on LOG4J2-1270 at 2/17/16 12:29 AM: --- Yes

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149575#comment-15149575 ] Ralph Goers commented on LOG4J2-1270: - I don't understand how this works for arbitrary Messages

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149573#comment-15149573 ] Ralph Goers commented on LOG4J2-1270: - Yes it is a big difference. But Classic uses

Re: traceExit and auto-boxing

2016-02-16 Thread Ralph Goers
...@gmail.com>> wrote: > I'd much prefer the annotation approach. > > On 16 February 2016 at 10:35, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > SLF4J created XLogger to do this. I wasn’t really happy with that and so >

Re: traceExit and auto-boxing

2016-02-16 Thread Ralph Goers
SLF4J created XLogger to do this. I wasn’t really happy with that and so added the methods to the Logger class when I started Log4j 2. The more I think about this I am wondering if the effort shouldn’t just be spent on implementing the annotations rather than arguing about this stuff. The

[jira] [Commented] (LOG4J2-1274) Layout improvements to enable avoiding temporary object allocation

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148508#comment-15148508 ] Ralph Goers commented on LOG4J2-1274: - This issue presupposes that there is a problem that needs

[jira] [Commented] (LOG4J2-1278) Garbage-free logging API (no varargs/autoboxing)

2016-02-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148504#comment-15148504 ] Ralph Goers commented on LOG4J2-1278: - Before spending time on this it would be great to know how

Re: Jenkins build is still unstable: Log4j 2.x #1682

2016-02-15 Thread Ralph Goers
Did someone add new Properties tests? They seem to be failing when the LoggerContextRule tries to find the configuration. Ralph > On Feb 15, 2016, at 10:01 PM, Apache Jenkins Server > wrote: > > See > > >

Re: Better flow logging

2016-02-15 Thread Ralph Goers
Well, this is where I currently rely on location information. The only problem I had with the existing methods is that sometimes the parameters being logged at entry or exit need to be formatted (for example gson->toJson(response)). I dislike immensely having to type in method names and

Re: Deprecate entry/exit()

2016-02-15 Thread Ralph Goers
Unfortunately, all the entry and exit methods can’t be deprecated. entry(Object… params) is ambiguous with traceEntry(String format, Object…params). That, and the fact that entry(String fqcn, Object… params) already existed is the only reason I created the traceEntry() methods. Ralph > On Feb

Re: traceExit() param order

2016-02-15 Thread Ralph Goers
6 one way, half a dozen the other. Ralph > On Feb 15, 2016, at 9:26 AM, Gary Gregory wrote: > > Hi All: > > It seems to me the param order in traceExit() is backward. > > It should be: traceExit(message, returnValue), not traceExit(returnValue, > message) > >

Re: LOG4J2-1255 Initial feedback on Logger/Message API changes

2016-02-13 Thread Ralph Goers
I didn’t create a branch because I didn’t think this was that big of a deal. All I was doing was adding new methods to make entry and exit tracing more usable. I created the MessageSupplier methods so the would be uniform with the debug, trace, etc methods. I see they have now been modified to

[jira] [Commented] (LOG4J2-33) Support Annotations

2016-02-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144478#comment-15144478 ] Ralph Goers commented on LOG4J2-33: --- I really had no intention of using the Lombok code. > Supp

[jira] [Commented] (LOG4J2-1270) Garbage-free steady-state logging

2016-02-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144486#comment-15144486 ] Ralph Goers commented on LOG4J2-1270: - I have no idea how you are going to avoid creating Message

[jira] [Comment Edited] (LOG4J2-33) Support Annotations

2016-02-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144478#comment-15144478 ] Ralph Goers edited comment on LOG4J2-33 at 2/12/16 11:31 AM: - I really had

Re: New traceEntry code

2016-02-11 Thread Ralph Goers
otes/tools/solaris/javac.html#processing > >> On Tue, Feb 9, 2016 at 6:43 PM, Ralph Goers <ralph.go...@dslextreme.com> >> wrote: >> True, but I should be able to save the method name and number in an object >> that can be used by the proxy. >> >> R

Re: New traceEntry code

2016-02-09 Thread Ralph Goers
JDBC specification we > implement (and a small select handful of other method). > > Using flow tracing everywhere would be silly IMO, for this use case, > implementing a JDBC driver. > > AspectJ is too heavy IMO anyway and a PITA to debug. > > Gary > > On Mon, Feb 8,

SLF4J Event Logger

2016-02-09 Thread Ralph Goers
Ceki just released 1.7.15 which introduces a LoggingEventAware interface. We will need to add that to the Logger to keep current with SLF4J before we bump the dependency. Ralph - To unsubscribe, e-mail:

Re: New traceEntry code

2016-02-09 Thread Ralph Goers
aul Benedict <pbened...@apache.org> wrote: > > Ralph, doesn't that require weaving or proxying? I think Gary was trying to > avoid both of those solutions. > > Cheers, > Paul > > On Tue, Feb 9, 2016 at 9:56 AM, Ralph Goers <ralph.go...@dslextreme.com > <

Re: SLF4J Event Logger

2016-02-09 Thread Ralph Goers
Ceki doesn’t follow our version numbering policy. Ralph > On Feb 9, 2016, at 9:56 AM, Matt Sicker <boa...@gmail.com> wrote: > > Shouldn't that be 1.8.0? :/ > > On 9 February 2016 at 10:45, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslex

Re: New traceEntry code

2016-02-09 Thread Ralph Goers
OH, you don't have the line numbers of the target -- but you would have the > method name. > > Cheers, > Paul > > On Tue, Feb 9, 2016 at 10:39 AM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > I’d have to let Gary commen

Re: Status of Chainsaw

2016-02-08 Thread Ralph Goers
be useful. Its > primary use in my view is reading arbitrary text log files which it does > pretty well. > > Scott > >> On Feb 7, 2016 10:31 PM, "Ralph Goers" <ralph.go...@dslextreme.com> wrote: >> Log4j 1 is now at end of life. As I understand it Chai

Re: Jenkins build became unstable: Log4j 2.x #1655

2016-02-08 Thread Ralph Goers
The FlumePersistentAppenderTest failed. Not sure why since nothing has changed as far as I can tell. Ralph > On Feb 8, 2016, at 8:45 PM, Matt Sicker wrote: > > I don't see anything wrong in the logs. Might be back to normal after another > build. > > On 8 February 2016 at

Locating the caller in LogEvent

2016-02-08 Thread Ralph Goers
I just now noticed that Log4jLogEvent’s calcLocation method is using a Throwable to locate the caller. For some reason I thought this was using ReflectionUtil.getCallerClass(fqcn). I don’t know how this slipped through as I believe it should improve logging with location information quite a

Re: Locating the caller in LogEvent

2016-02-08 Thread Ralph Goers
gt; > I did a bit of refactoring when I put everything together in ReflectionUtil. > I probably just missed that. I don't see any reason not to use it. > > On 8 February 2016 at 12:12, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: &g

Re: New traceEntry code

2016-02-08 Thread Ralph Goers
ydgreg...@gmail.com> wrote: > > On Mon, Feb 8, 2016 at 9:29 AM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > First, this probably should be on the dev list, not the users list. > > Second, the sample methods you provid

[jira] [Resolved] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-1255. - Resolution: Fixed Fix Version/s: 2.6 Fix committed. > Logger.entry and Logger.e

[jira] [Comment Edited] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136498#comment-15136498 ] Ralph Goers edited comment on LOG4J2-1222 at 2/7/16 10:46 PM: -- I built

[jira] [Commented] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136498#comment-15136498 ] Ralph Goers commented on LOG4J2-1222: - I built and ran the mini-app in Tomcat and didn't see

[jira] [Comment Edited] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136489#comment-15136489 ] Ralph Goers edited comment on LOG4J2-1255 at 2/7/16 10:34 PM: -- Fix committed

[jira] [Resolved] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-1222. - Resolution: Fixed > Initializing Logger during JVM shutdown fails with FATAL er

[jira] [Comment Edited] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136574#comment-15136574 ] Ralph Goers edited comment on LOG4J2-1222 at 2/8/16 3:55 AM: - Fix applied

[jira] [Commented] (LOG4J2-1222) Initializing Logger during JVM shutdown fails with FATAL error

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136574#comment-15136574 ] Ralph Goers commented on LOG4J2-1222: - Fix applied. The mini-app attached now shuts down without

[jira] [Assigned] (LOG4J2-1263) log4j2.properties: monitorInterval has not effect

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers reassigned LOG4J2-1263: --- Assignee: Ralph Goers > log4j2.properties: monitorInterval has not eff

[jira] [Commented] (LOG4J2-1263) log4j2.properties: monitorInterval has not effect

2016-02-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136618#comment-15136618 ] Ralph Goers commented on LOG4J2-1263: - It looks like PropertiesConfigurationFactory is not setting

Status of Chainsaw

2016-02-07 Thread Ralph Goers
Log4j 1 is now at end of life. As I understand it Chainsaw is still targeted at Log4j 1. The download page says the last build date was in 2006. The OS X .dmg file doesn’t work as it is for the PowerPC, which Apple hasn’t supported in quite a while. I do see commits in pom.xml that suggest

Log4j 1 web site

2016-02-06 Thread Ralph Goers
I have updated the Log4j 1 web site to indicate that it has reached end-of-life. I also modified the issue tracking page to indicate that bugzilla is now read-only. Ralph - To unsubscribe, e-mail:

[jira] [Commented] (LOG4J2-548) Log4j 2.0 with JBoss EAP 6.2

2016-02-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135901#comment-15135901 ] Ralph Goers commented on LOG4J2-548: No, Jboss does not use Apache Commons VFS. JBoss has its own

[jira] [Resolved] (LOG4J2-1264) ‘XSLTLayoutTest‘ test case is failing on Ubuntu 15.04 (ppc64le) while building log4j-extras package

2016-01-29 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-1264. - Resolution: Invalid This Jira project is for issues related to Log4j 2. > ‘XSLTLayoutTest‘ t

[jira] [Commented] (LOG4J2-494) Support composite configurations

2016-01-27 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119142#comment-15119142 ] Ralph Goers commented on LOG4J2-494: This should be possible to do. Creating a configuration is a two

Re: logging-log4j2 git commit: LOG4J2-124 - Add shutdown methods to LogManager

2016-01-26 Thread Ralph Goers
well, but let's > at least start to be clear about new methods from now.) > > On Tue, Jan 26, 2016 at 1:31 AM, Matt Sicker <boa...@gmail.com > <mailto:boa...@gmail.com>> wrote: > I like it! > > On 25 January 2016 at 18:23, Ralph Goers <ralph.go...@dsl

Re: Build failed in Jenkins: httpcomponents-client-5.x » Apache HttpComponents Client Parent #37

2016-01-26 Thread Ralph Goers
Wong list? You seem to have things confused today. Ralph > On Jan 26, 2016, at 7:04 PM, Gary Gregory wrote: > > I can build locally OK, can anyone duplicate this fail locally? > > Gary > > -- Forwarded message -- > From: Apache Jenkins Server

Re: Jenkins build is still unstable: Log4j 2.x #1643

2016-01-25 Thread Ralph Goers
Interesting. This time the SyslogAppenderTest failed. Ralph > On Jan 25, 2016, at 6:56 AM, Apache Jenkins Server > wrote: > > See > > > - > To

Re: logging-log4j2 git commit: LOG4J2-124 - Add shutdown methods to LogManager

2016-01-25 Thread Ralph Goers
gt; wrote: > > On Sun, Jan 24, 2016 at 10:07 PM, Gary Gregory <garydgreg...@gmail.com > <mailto:garydgreg...@gmail.com>> wrote: > On Sun, Jan 24, 2016 at 1:54 PM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> wrote: > Yes,

[jira] [Commented] (LOG4J2-494) Support composite configurations

2016-01-25 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115508#comment-15115508 ] Ralph Goers commented on LOG4J2-494: First, enhancing XInclude isn't something we can realistically do

<    6   7   8   9   10   11   12   13   14   15   >