[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 You’re right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

Said this, one may use his favorite line endings locally. When applying a patch with different line endings, the applier of tge patch will either reject the patch or fix line endings on thy fly. Sorry for the various mails on the same thread. Sending from mobiles is not really comfortable. On 16

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 `text` means "use native line-ends when checking out, translate to LF when sending" which is waht we want IMHO. --- If your project is set up for it, you can reply to this email and have your reply

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

I suggest to agree on one line ending and use that throughout the repository. Until today the only rule that exists is that each file must use exactly one type of line endings. Mixed line endings are forbidden by svn properties. On 16 Oct 2016 4:21 p.m., "JJoe2" wrote: >

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 The .gitattributes file you committed doesn’t specify line endings for most file types including .cs and .csproj (the most commonly modified ones). However I don’t feel competent to say

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 not sure `.gitattributes` will really help, I've copied and commited the one I use for XMLUnit.NET. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Thank you for your patience : I’ve learnt a lot about git this weekend which will stand me in good stead for the future (still hate it though). I subscribed to the dev list this morning, and

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Replaced by #37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

What do you think of adding a timezone field such that people can calculate the utc timestamp if they care? Nothing breaks while all usecases are taken care of. On 15 Oct 2016 7:23 p.m., "Dominik Psenner" wrote: I highly recommend to stay compatible and add a utc timestampas

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

I highly recommend to stay compatible and add a utc timestampas a new field and deprecate the old field for at least one release cyle. On 15 Oct 2016 7:20 p.m., "JJoe2" wrote: Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Thanks. I agree that I should have done a better job of keeping these changes separate but when I did the initial work I was very much a git novice. I’ll bite the bullet and separate

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 @JJoe2 I'm sorry, but now the patch contains all the changes we've made since you started your branch. It would be good if you could rebase your branch. Many thanks for the `w=1` trick, I

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 From your remarks I gather you aren’t too concerned about line ending inconsistencies. And since I did a bit of research today, and discovered that it’s possible to ignore whitespace /

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 To be honest I have no idea how svn line ends transfer to the git mirror. In svn line ends are CRLF on Windows and LF on Unix. What git makes from this depends on your `autocrlf` config and probably

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Some recent commits have changed line endings from LF to CRLF: some of the ones that affect me are listed below. Would it be possible for you to fix these line endings in the trunk? This will make

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 I've ensured all line-ends are consistent and set to native in svn trunk - git is not our primary repository, https://svn.apache.org/repos/asf/logging/log4net/trunk/ is. If you've got access to svn

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Hi Stefan, Thanks for the feedback. As you’ll have gathered I’m a novice as far as Git and Github are concerned, though slightly less so than I was when I created this patch.

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user bodewig commented on the issue: https://github.com/apache/log4net/pull/25 This PR seems to include #24 as well, could you provide a patch without it? Also, I'm not sure why `Flush` has been added to `ILoggerRepository` directly. It would be better if

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

On 2016-10-12, Dominik Psenner wrote: > The patch looks sensible. Whats your opinion stefan? all the whitespace changes are distracting. And the patch contains changes that are completely unrelated - it seems to contain pull request #24 as well. I'll comment on the PR. Stefan

Re: [GitHub] log4net issue #25: API to flush appenders that buffer logging data

The patch looks sensible. Whats your opinion stefan? On 12 Oct 2016 7:42 p.m., "Salgat" wrote: > Github user Salgat commented on the issue: > > https://github.com/apache/log4net/pull/25 > > Any news if this will ever get pulled? > > > --- > If your project is set up

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user Salgat commented on the issue: https://github.com/apache/log4net/pull/25 Any news if this will ever get pulled? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature