[GitHub] log4net pull request #41: Recursive logging

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/41 Recursive logging Fixes LOG4NET-550 This fix will be needed to implement logging from the AsyncAppender I am working on. You can merge this pull request into a Git repository by running

[GitHub] log4net pull request: Use UTC internally to avoid ambiguous times

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/24 Use UTC internally to avoid ambiguous times Currently log4net uses local times internally and converts to UTC on output when needed (e.g. UtcDatePatternConverter). This can result in inaccurate UTC

[GitHub] log4net pull request: API to flush appenders that buffer logging d...

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/25 API to flush appenders that buffer logging data Implementation of https://issues.apache.org/jira/browse/LOG4NET-511 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] log4net pull request: API to flush appenders that buffer logging d...

Github user JJoe2 commented on the pull request: https://github.com/apache/log4net/pull/25#issuecomment-214260923 Added two commits including a fix for https://issues.apache.org/jira/browse/LOG4NET-512 --- If your project is set up for it, you can reply to this email and have your

[GitHub] log4net pull request #35: Wip/app settings

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/35 Wip/app settings Implementation for LOG4NET-526 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/AppSettings Alternatively you

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Hi Stefan, Thanks for the feedback. As you’ll have gathered I’m a novice as far as Git and Github are concerned, though slightly less so than I was when I created this patch

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 I don’t have access to svn, so I’ll start by tidying up my fork in github this weekend. I understand your point that adding methods to a public interface is a breaking change. Though itâ

[GitHub] log4net pull request #24: Use UTC internally to avoid ambiguous times

Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 I’ve just fetched the latest trunk into my fork. As far as I see there are still some line-end inconsistencies in the git repository. For example core/LoggingEvent.cs has CRLF endings while

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Some recent commits have changed line endings from LF to CRLF: some of the ones that affect me are listed below. Would it be possible for you to fix these line endings in the trunk? This will make

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 From your remarks I gather you aren’t too concerned about line ending inconsistencies. And since I did a bit of research today, and discovered that it’s possible to ignore whitespace

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Thanks. I agree that I should have done a better job of keeping these changes separate but when I did the initial work I was very much a git novice. I’ll bite the bullet and separate

[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/36 Use UTC internally to avoid ambiguous timestamps Resubmitting replacement for #24 Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent

[GitHub] log4net pull request #25: API to flush appenders that buffer logging data

Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] log4net pull request #37: Implement flushing of appenders that buffer data

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/37 Implement flushing of appenders that buffer data Replaces #25 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/Flush

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Replaced by #37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 I'll rebase this after #36 and #37 have been processed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Thank you for your patience : I’ve learnt a lot about git this weekend which will stand me in good stead for the future (still hate it though). I subscribed to the dev list this morning, and

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 The .gitattributes file you committed doesn’t specify line endings for most file types including .cs and .csproj (the most commonly modified ones). However I don’t feel competent to say

[GitHub] log4net issue #25: API to flush appenders that buffer logging data

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 You’re right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 Hi Stefan, That's correct, those are the only changes. Thanks, From: Stefan Bodewig Sent: 23 October 2016 16:33:48 To: a

[GitHub] log4net issue #35: Wip/app settings

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 I’ll be happy to do the unit tests and possibly the doc. Are suitable XML comments enough? Now this is added, I’ll also be thinking about the next step, which is to allow the

[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps

Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/36 Closing for now - in its current form it's a breaking change - it changes LoggingEvent.DateTime from a field to a property. --- If your project is set up for it, you can reply to this emai

[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps

Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/36 Reopened - fixed breaking change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps

GitHub user JJoe2 reopened a pull request: https://github.com/apache/log4net/pull/36 Use UTC internally to avoid ambiguous timestamps Resubmitting replacement for #24 Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent

[GitHub] log4net pull request #38: Fixed log4net.Tests.vs2012.csproj reference to NUn...

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/38 Fixed log4net.Tests.vs2012.csproj reference to NUnit. Previous version included ..\..\..\ibatisnet-3\External-Bin\Net\2.0\nunit.framework.dll Changed this to reference NuGet package

[GitHub] log4net pull request #38: Fixed log4net.Tests.vs2012.csproj reference to NUn...

Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] log4net pull request #39: Added a unit test for AppSettingPatternConverter

GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/39 Added a unit test for AppSettingPatternConverter Unit test for PR #35 as requested. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net