Re: GUI changes for inserting citations in 2.2x

[Guillaume Munch]

Le 16/09/2016 à 13:53, Jürgen Spitzmüller a écrit :

Am Freitag, den 16.09.2016, 13:41 +0100 schrieb Guillaume Munch:

Am Freitag, den 16.09.2016, 12:39 +0100 schrieb Guillaume Munch:

Now one will expect "search on the fly" to be always activated,

for

consistency for other search fields. If this is done, it makes

sense

to
assign "Enter" to focus the available citations.


Note that this setting is saved between sessions, so everybody can

set

it as s/he feels fit.



I don't think this is related to my point.


I think it is, although I did not spell out my argumentation.


Thank you for clarifying.



The ones that "will expect 'search on the fly' to be always activated"
(and I doubt you can generalize that to a general "one" -- I am the
example that will falsify such a claim) can easily preset it once and
for all.


Actually I did generalize, by giving an objective reason: consistency
with other search fields.

I do not think that it all comes down to the tastes and habits of
developers. On the contrary, I believe that this sort of argument does
not lead to great design: it leads to dialogs with three different ways
to validate changes, where a button "Apply" does not have the same
effect between the two preferences dialogs, and where one is offered the
choice to search as one types or not. Another consequence is that I
often refrain myself from making (what I find are) small improvements
because I know that such changes can trigger long discussions.



The proposal to assign "Enter" to a different function seems to imply
the proposal to remove the option to toggle "search on fly". If you
mean this, I will object, since I'd like to have it switched off.


Yes, this is what I mean.



We could assign "Enter" to a second function anyway (if "search on fly"
is activated or even if it isn't, after the filter has been applied),
but I think this would be irritating. And in general, I think that the
binding of the Enter moving widgets is quite opaque.

What's wrong with Alt-V?



Nothing is wrong with Alt-V.

Re: GUI changes for inserting citations in 2.2x

[Guillaume Munch]

Le 16/09/2016 à 18:12, Jürgen Spitzmüller a écrit :

Am Freitag, den 16.09.2016, 10:20 -0600 schrieb Joel Kulesza:

Perhaps not something to be done immediately, but do you agree that
it is a reasonable request to be considered for implementation in the
future?


Yes. Note, though, that it seems to be non-trivial. I have tried to
implement it, but did not succeed to change the color in a sensible
way. Disabling the widget does not, as in the case of other widgets,
grey it out. The way to go seems to be playing with the color palette,
but I didn't manage to get it to work either (but did not try too
hard).


Yes, it seems that all that cannot be used to control the html
formatting, which the citation preview uses. I finally found that the
trick was to change the html. See attached.



In any case, if it is done, it should be done for all widgets that do
only display information.



Where else should that be done?

Guillaume

>From d803e0b6c566dc1d4ba74b7a901df1c6e1cceade Mon Sep 17 00:00:00 2001
From: Guillaume Munch 
Date: Fri, 16 Sep 2016 22:06:38 +0100
Subject: [PATCH] GuiCitation: Set infoML to read-only colors

---
 src/frontends/qt4/GuiCitation.cpp | 26 +++---
 src/frontends/qt4/GuiCitation.h   |  2 ++
 2 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/frontends/qt4/GuiCitation.cpp b/src/frontends/qt4/GuiCitation.cpp
index b294fd8..078a3e3 100644
--- a/src/frontends/qt4/GuiCitation.cpp
+++ b/src/frontends/qt4/GuiCitation.cpp
@@ -124,6 +124,9 @@ GuiCitation::GuiCitation(GuiView & lv)
 	searchOpts->addAction(instant_);
 	searchOptionsPB->setMenu(searchOpts);
 
+	//initialize info box
+	setInfoHtml(docstring());
+
 	connect(citationStyleCO, SIGNAL(activated(int)),
 		this, SLOT(on_citationStyleCO_currentIndexChanged(int)));
 	connect(fulllistCB, SIGNAL(clicked()),
@@ -366,14 +369,23 @@ void GuiCitation::setButtons()
 
 void GuiCitation::updateInfo(BiblioInfo const & bi, QModelIndex const & idx)
 {
-	if (!idx.isValid() || bi.empty()) {
-		infoML->document()->clear();
-		return;
-	}
+	docstring const html = (!idx.isValid() || bi.empty()) ? docstring()
+		: bi.getInfo(qstring_to_ucs4(idx.data().toString()),
+		 documentBuffer(),
+		 true);
+	setInfoHtml(html);
+}
 
-	QString const keytxt = toqstr(
-		bi.getInfo(qstring_to_ucs4(idx.data().toString()), documentBuffer(), true));
-	infoML->document()->setHtml(keytxt);
+
+void GuiCitation::setInfoHtml(docstring const & html)
+{
+	//set preview in window colors to denote read-only
+	QString body(""
+	 "%3"
+	 "");
+	body = body.arg(QPalette().windowText().color().name());
+	body = body.arg(QPalette().window().color().name());
+	infoML->document()->setHtml(body.arg(toqstr(html)));
 }
 
 
diff --git a/src/frontends/qt4/GuiCitation.h b/src/frontends/qt4/GuiCitation.h
index 035b2d2..fee8c60 100644
--- a/src/frontends/qt4/GuiCitation.h
+++ b/src/frontends/qt4/GuiCitation.h
@@ -95,6 +95,8 @@ private:
 	bool isSelected(const QModelIndex &);
 	/// update the display of BibTeX information
 	void updateInfo(BiblioInfo const & bi, QModelIndex const &);
+	/// format and insert text into the info QTextEdit
+	void setInfoHtml(docstring const & html);
 	/// enable/disable buttons
 	void setButtons();
 	/// fill the fields combo
-- 
2.7.4

Re: suspended ctests

[Kornel Benko]

Am Freitag, 16. September 2016 um 19:28:04, schrieb Guenter Milde 

> On 2016-09-13, Guenter Milde wrote:
> > On 2016-09-13, Kornel Benko wrote:
> 
> >>> >> * Do you still need the "suspendeTests"? What for?
> 
> >>> > Yes, we need them. This tests will not be executed with the call 'ctest
> >>> > -L export'.
> 
> ...
> 
> >>> In the meantime, we know the particular problem for most of the suspended
> >>> tests.
> >>> Some were fixed. Others require inversion (we know the problem is a
> >>> wontfix or a bug on trac).
> 
> Therefore, I'll reword the question:
> 
> Do you call `ctest -L export` regularely?

This is my alias for export:
ctest -j12 -timeout 300 -L export -E "xhtml|lyx16|lyx21|lyx22"

> Could you imagine calling `ctest -L export -LE "texissues|attic"` instead?

Sure, but if you think texissues should not be tested, make them part of 
suspended.

>   -1 more to type
>   
>   +1 filters not only 58 but 80 "wontfix" inverted tests
>   
>   +4 makes the test system less complicated.
> 
> Do you call `ctest -L inverted` regularely?

Sometimes, yes.

> Could you imagine calling `ctest -L inverted -LE "texissues|attic"` instead?
> 
> ...
> 
> >> My understanding is that they are suspended because of difficult to
> >> solve, therefore we do not try to tests them every time.
> 
> However, the "usual full run" (without -L) does test them.

Sure, I never claimed otherwise.

> How often is -L used without also -R to select specific tests via regexp?

Here? Almost always. That was one reason to invent/use labels.

> Günter

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: suspended ctests

[Guenter Milde]

On 2016-09-13, Guenter Milde wrote:
> On 2016-09-13, Kornel Benko wrote:

>>> >> * Do you still need the "suspendeTests"? What for?

>>> > Yes, we need them. This tests will not be executed with the call 'ctest
>>> > -L export'.

...

>>> In the meantime, we know the particular problem for most of the suspended
>>> tests.
>>> Some were fixed. Others require inversion (we know the problem is a
>>> wontfix or a bug on trac).

Therefore, I'll reword the question:

Do you call `ctest -L export` regularely?

Could you imagine calling `ctest -L export -LE "texissues|attic"` instead?

  -1 more to type
  
  +1 filters not only 58 but 80 "wontfix" inverted tests
  
  +4 makes the test system less complicated.

Do you call `ctest -L inverted` regularely?

Could you imagine calling `ctest -L inverted -LE "texissues|attic"` instead?

...

>> My understanding is that they are suspended because of difficult to
>> solve, therefore we do not try to tests them every time.

However, the "usual full run" (without -L) does test them.
How often is -L used without also -R to select specific tests via regexp?


Günter

Re: [LyX/master] ctests: rename pattern file "suspiciousTests" to "invertedTests".

[Guenter Milde]

On 2016-09-16, Kornel Benko wrote:

...
> for clean change I would expect also the renaming of list-variables in
> macro maketestname listsuspicious ->listinverted listsuspiciousx ->
> listinvertedx

>:)

Done (3294b16..d7d2393  master -> master)

Günter

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 13:31 -0400 schrieb Scott Kostyshak:
> On Fri, Sep 16, 2016 at 07:22:06PM +0200, Jürgen Spitzmüller wrote:
> > 
> > Am Freitag, den 16.09.2016, 12:59 -0400 schrieb Scott Kostyshak:
> > > 
> > > Is the style also remembered now? This is:
> > > http://www.lyx.org/trac/ticket/10256
> > 
> > No. However, if I understand the report correctly, it is not meant
> > to
> > store the style over sessions, but within a session.
> 
> I see. Thanks for checking.

Nevertheless I went ahead and implemented both.

Jürgen


> 
> Scott

signature.asc
Description: This is a digitally signed message part

Re: GUI changes for inserting citations in 2.2x

[Scott Kostyshak]

On Fri, Sep 16, 2016 at 07:22:06PM +0200, Jürgen Spitzmüller wrote:
> Am Freitag, den 16.09.2016, 12:59 -0400 schrieb Scott Kostyshak:
> > Is the style also remembered now? This is:
> > http://www.lyx.org/trac/ticket/10256
> 
> No. However, if I understand the report correctly, it is not meant to
> store the style over sessions, but within a session.

I see. Thanks for checking.

Scott


signature.asc
Description: PGP signature

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 12:59 -0400 schrieb Scott Kostyshak:
> Is the style also remembered now? This is:
> http://www.lyx.org/trac/ticket/10256

No. However, if I understand the report correctly, it is not meant to
store the style over sessions, but within a session.

Jürgen

> Scott

signature.asc
Description: This is a digitally signed message part

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 10:20 -0600 schrieb Joel Kulesza:
> Perhaps not something to be done immediately, but do you agree that
> it is a reasonable request to be considered for implementation in the
> future? 

Yes. Note, though, that it seems to be non-trivial. I have tried to
implement it, but did not succeed to change the color in a sensible
way. Disabling the widget does not, as in the case of other widgets,
grey it out. The way to go seems to be playing with the color palette,
but I didn't manage to get it to work either (but did not try too
hard).

In any case, if it is done, it should be done for all widgets that do
only display information.

Jürgen

signature.asc
Description: This is a digitally signed message part

Re: GUI changes for inserting citations in 2.2x

[Scott Kostyshak]

On Fri, Sep 16, 2016 at 01:50:11PM +0200, Jürgen Spitzmüller wrote:
> Am Freitag, den 16.09.2016, 12:39 +0100 schrieb Guillaume Munch:
> > Now one will expect "search on the fly" to be always activated, for 
> > consistency for other search fields. If this is done, it makes sense
> > to 
> > assign "Enter" to focus the available citations.
> 
> Note that this setting is saved between sessions, so everybody can set
> it as s/he feels fit.

Is the style also remembered now? This is:
http://www.lyx.org/trac/ticket/10256

Scott


signature.asc
Description: PGP signature

Re: GUI changes for inserting citations in 2.2x

[Joel Kulesza]

On Thu, Sep 15, 2016 at 11:43 PM, Jürgen Spitzmüller  wrote:

>
> That would mean to audit all other dialogs to have consistency. And I
> don't have time for that.
>
>
Perhaps not something to be done immediately, but do you agree that it is a
reasonable request to be considered for implementation in the future?

Re: Fwd: Re: [RFC][PATCH] Set window title according to platform UI

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 17:01 +0200 schrieb Jean-Marc Lasgouttes:
> Does anybody think that the em dash that we use currently in the
> title bar should be replaced by a plain dash?

I thought Qt outputs "the right thing" for the given platform.
That's what I would expect.

> I used it because Qt does it 
> too, but ubuntu/unity does not and windows does not either?

Nor does GNOME (except for KDE5 applications, that is).

> Is this a KDE thing?

Apparently (KDE5, more precisely, or however they call it nowadays).

Jürgen

> 
> JMarc


signature.asc
Description: This is a digitally signed message part

Fwd: Re: [RFC][PATCH] Set window title according to platform UI

[Jean-Marc Lasgouttes]

I realize that I replied to a private message from racoon.

Does anybody think that the em dash that we use currently in the title 
bar should be replaced by a plain dash? I used it because Qt does it 
too, but ubuntu/unity does not and windows does not either?


Is this a KDE thing?

JMarc

 Message transféré 
Sujet : Re: [RFC][PATCH] Set window title according to platform UI
Date : Fri, 9 Sep 2016 10:05:05 +0200
De : Jean-Marc Lasgouttes 
Pour : racoon 

Le 09/09/2016 à 09:54, racoon a écrit :

At least under windows it seems uncommon to use an mdash (0x2014)
between the filename and the application name. Rather a normal dash (-)
is used.


I used a mdash because this is what Qt does, but I agree that I do not 
see that on gnome either. Does someone else have ideas on the subject?


JMarc

Re: [LyX/master] ctests: rename pattern file "suspiciousTests" to "invertedTests".

[Kornel Benko]

Am Freitag, 16. September 2016 um 12:13:13, schrieb Günter Milde 

> commit 27420e84adeba6a7deb6892317417b499a633b9b
> Author: Günter Milde 
> Date:   Fri Sep 16 12:03:17 2016 +0200
> 
> ctests: rename pattern file "suspiciousTests" to "invertedTests".
> ---
>  development/autotests/ExportTests.cmake |   10 +-
>  development/autotests/invertedTests |4 +-
>  development/autotests/unreliableTests   |   13 +-
>  lib/doc/Development.lyx |  607 
> ++-
>  4 files changed, 452 insertions(+), 182 deletions(-)
> 

For (dirty) renaming it would have been sufficient to change
loadTestList(suspiciousTests suspiciousTests 7)
to
loadTestList(invertedTests suspiciousTests 7)
..
for clean change I would expect also the renaming of list-variables in macro 
maketestname
listsuspicious ->listinverted
listsuspiciousx -> listinvertedx

:)

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 13:41 +0100 schrieb Guillaume Munch:
> > Am Freitag, den 16.09.2016, 12:39 +0100 schrieb Guillaume Munch:
> >> Now one will expect "search on the fly" to be always activated,
> for
> >> consistency for other search fields. If this is done, it makes
> sense
> >> to
> >> assign "Enter" to focus the available citations.
> >
> > Note that this setting is saved between sessions, so everybody can
> set
> > it as s/he feels fit.
> >
> 
> I don't think this is related to my point.

I think it is, although I did not spell out my argumentation.

The ones that "will expect 'search on the fly' to be always activated"
(and I doubt you can generalize that to a general "one" -- I am the
example that will falsify such a claim) can easily preset it once and
for all.

The proposal to assign "Enter" to a different function seems to imply
the proposal to remove the option to toggle "search on fly". If you
mean this, I will object, since I'd like to have it switched off.

We could assign "Enter" to a second function anyway (if "search on fly"
is activated or even if it isn't, after the filter has been applied),
but I think this would be irritating. And in general, I think that the
binding of the Enter moving widgets is quite opaque.

What's wrong with Alt-V?

Jürgen

signature.asc
Description: This is a digitally signed message part

Re: Small problems with figure previews

[Scott Kostyshak]

On Fri, Sep 16, 2016 at 10:20:09AM +0200, Pietro Cortese wrote:
> Hello,
> 
> I'm including some figures in a lyx and I would like to have a preview with
> better resolution. I'm using a lyx file as a logbook and I would like to see
> clearly pictures and included documents.
> 
> Picture scaling increase the dimension but not the resolution.
> 
> I tried to add a new converter in Tools-File-handling-Converters from PDF to
> png but it didn't work.
> 
> Only solution seems to be to put the picture inside a preview box.
> 
> Another problem is when including external material with pdfpages. If you
> specify for example in the latex options "pages=4" in the preview you see
> always the first page. In this case if you include the pdfpages inside a
> preview box you get an error message on output Warning: Failed to produce 1
> preview snippet(s).
> 
> Please could you give me some suggestion?

Hi Pietro,

To make sure I understand, you are only referring to LyX's display
right? i.e. there is no problem with the final PDF output?

What is your LyX version?

You can run LyX as

 lyx -dbg graphics

to get more information about graphics conversions.

Scott


signature.asc
Description: PGP signature

Re: ctests (was: Intro with PDF(luatex))

[Scott Kostyshak]

On Fri, Sep 16, 2016 at 07:26:12AM +, Guenter Milde wrote:
> On 2016-09-15, Scott Kostyshak wrote:

> > But not the mystery. How did it work for you before and not for me? Do
> > you have \Esc defined locally somehow?
> 
> I must have run the tests while either the \Esc was commented or
> \usepackage{keystroke} in the preamble while updating git with uncommented
> \Esc and without keystroke :-(

Ah OK. So there is no difference between LaTeX installations (regarding
this issue).

Thanks,

Scott


signature.asc
Description: PGP signature

Re: tex2lyx fails with \subfloat without optional arguments

[José Abílio Matos]

On Tuesday, September 13, 2016 10:19:09 PM WEST Scott Kostyshak wrote:
> Do we have a ticket for this issue so it doesn't get forgotten?

Now we do. :-)

http://www.lyx.org/trac/ticket/10385

Thank you for reminder. :-)
 
> Scott

-- 
José Abílio

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 12:39 +0100 schrieb Guillaume Munch:
> Now one will expect "search on the fly" to be always activated, for 
> consistency for other search fields. If this is done, it makes sense
> to 
> assign "Enter" to focus the available citations.

Note that this setting is saved between sessions, so everybody can set
it as s/he feels fit.

Jürgen


signature.asc
Description: This is a digitally signed message part

Re: GUI changes for inserting citations in 2.2x

[Guillaume Munch]

Le 16/09/2016 à 08:22, Jürgen Spitzmüller a écrit :


I've pushed the stuff with these fixes to master.

Probably something to come back to for 2.2.3.



Works very well.

Now one will expect "search on the fly" to be always activated, for 
consistency for other search fields. If this is done, it makes sense to 
assign "Enter" to focus the available citations.

Small problems with figure previews

[Pietro Cortese]

Hello,

I'm including some figures in a lyx and I would like to have a preview 
with better resolution. I'm using a lyx file as a logbook and I would 
like to see clearly pictures and included documents.


Picture scaling increase the dimension but not the resolution.

I tried to add a new converter in Tools-File-handling-Converters from 
PDF to png but it didn't work.


Only solution seems to be to put the picture inside a preview box.

Another problem is when including external material with pdfpages. If 
you specify for example in the latex options "pages=4" in the preview 
you see always the first page. In this case if you include the pdfpages 
inside a preview box you get an error message on output Warning: Failed 
to produce 1 preview snippet(s).


Please could you give me some suggestion?

Many thanks,

Pietro

Re: ctests (was: Intro with PDF(luatex))

[Guenter Milde]

On 2016-09-15, Scott Kostyshak wrote:
> On Thu, Sep 15, 2016 at 07:19:50PM +, Guenter Milde wrote:

Dear Scott,

>> >> > >> > 280:export/export/Unicode-characters/077-79-mathops-technical-control-utf8_pdf2

>> >> > > I get the following error:
>> >> > 
>> >> > > ! Undefined control sequence.
>> >> > > l.114 ...380}]  Escape  TODO: user keystroke? \Esc
>> ...
>> >> In the .lyx file there is an ERT with \Esc

>> >> Somehow, \Esc is defined for you but not for me. Do you know where?

>> > Missing '\usepackage{keystroke}' in the preamble?

>> That solved the failure.

> But not the mystery. How did it work for you before and not for me? Do
> you have \Esc defined locally somehow?

I must have run the tests while either the \Esc was commented or
\usepackage{keystroke} in the preamble while updating git with uncommented
\Esc and without keystroke :-(

Günter

Re: GUI changes for inserting citations in 2.2x

[Jürgen Spitzmüller]

Am Freitag, den 16.09.2016, 07:45 +0200 schrieb Jürgen Spitzmüller:
> Am Donnerstag, den 15.09.2016, 22:30 +0100 schrieb Guillaume Munch:
> > 
> > * Why Fi instead of ?
> 
> A mystery. I set , but the designer reset it. Will fix it.
> 
> > 
> > * One could use the search field with the "clear" button already
> > present
> > in the outliner. But this can be done another time.
> 
> Yes, I thought of using the FancyLineEdit, but I was busy enough with
> the rest. Will check.
> 
> > 
> > * It would be great (in my opinion) if Filter is the field selected
> > when
> > opening the dialog. Pressing enter should focus the available
> > citations.
> > Like above, this is not urgent.
> 
> Yes, good idea.

I've pushed the stuff with these fixes to master.

Probably something to come back to for 2.2.3.

Jürgen

> 
> Thanks
> Jürgen

signature.asc
Description: This is a digitally signed message part