Re: [RFC][PATCH] Set window title according to platform UI

On Fri, Sep 23, 2016 at 11:26:31AM +0200, Jean-Marc Lasgouttes wrote: > > Actually, most of the used of getPixmap are like > QIcon(getPixmap(...)).pixmap(somesize); > > It looks like a strange code path to me. What does getPixmap return in the > case of a svg? Some rasterized version of the

Re: [RFC][PATCH] Set window title according to platform UI

Le 22/09/2016 à 04:06, Enrico Forestieri a écrit : Would something like that work for us? That looks good. Yep, that seems producing an image with same quality. The patch would be the attached one. Please, apply if you like it. Thaks for the patch, I pushed it. I was tempted to do the same

Re: [RFC][PATCH] Set window title according to platform UI

On Wed, Sep 21, 2016 at 10:20:57PM +0200, Jean-Marc Lasgouttes wrote: > > On this page, > http://stackoverflow.com/questions/10079011/qpixmap-and-svg > someone proposes > QIcon("filepath.svg").pixmap(QSize()) > > Would something like that work for us? That looks good. Yep, that seems

Re: [RFC][PATCH] Set window title according to platform UI

Le 21/09/2016 à 22:08, Enrico Forestieri a écrit : What I do not understand is why the code for getting the same image in the tab bar is so much simpler. It does not look really worse to me. Because QIcon internally does what we have to explicitly do for a pixmap. To be frank I never knew

Re: [RFC][PATCH] Set window title according to platform UI

On Wed, Sep 21, 2016 at 02:03:02PM +0200, Jean-Marc Lasgouttes wrote: > Le 11/09/2016 à 11:37, Enrico Forestieri a écrit : > >On Sun, Sep 11, 2016 at 03:48:55AM +0100, Guillaume Munch wrote: > >> > >>Getting the perfect result is a good reason for having such a > >>long code. Maybe the "ouch!"

Re: [RFC][PATCH] Set window title according to platform UI

Le 11/09/2016 à 11:37, Enrico Forestieri a écrit : On Sun, Sep 11, 2016 at 03:48:55AM +0100, Guillaume Munch wrote: Getting the perfect result is a good reason for having such a long code. Maybe the "ouch!" effect is because it is added as is. It looks like it could be made a function in

Re: Fwd: Re: [RFC][PATCH] Set window title according to platform UI

Am Freitag, den 16.09.2016, 17:01 +0200 schrieb Jean-Marc Lasgouttes: > Does anybody think that the em dash that we use currently in the > title bar should be replaced by a plain dash? I thought Qt outputs "the right thing" for the given platform. That's what I would expect. > I used it because

Fwd: Re: [RFC][PATCH] Set window title according to platform UI

Message transféré Sujet : Re: [RFC][PATCH] Set window title according to platform UI Date : Fri, 9 Sep 2016 10:05:05 +0200 De : Jean-Marc Lasgouttes <lasgout...@lyx.org> Pour : racoon <xraco...@gmx.de> Le 09/09/2016 à 09:54, racoon a écrit : At least under windows it se

Re: [RFC][PATCH] Set window title according to platform UI

On Sun, Sep 11, 2016 at 03:48:55AM +0100, Guillaume Munch wrote: > > Getting the perfect result is a good reason for having such a > long code. Maybe the "ouch!" effect is because it is added as is. > It looks like it could be made a function in qt_helpers or some other > appropriate place,

Re: [RFC][PATCH] Set window title according to platform UI

Le 08/09/2016 à 22:27, Enrico Forestieri a écrit : On Thu, Sep 08, 2016 at 03:04:17PM +0200, Jean-Marc Lasgouttes wrote: Le 08/09/2016 à 03:31, Enrico Forestieri a écrit : On Wed, Sep 07, 2016 at 03:13:38PM +0200, Jean-Marc Lasgouttes wrote: And of course, a screenshot (no you are not

Re: [RFC][PATCH] Set window title according to platform UI

On 07.09.2016 16:13, Jean-Marc Lasgouttes wrote: Le 07/09/2016 à 15:10, Jean-Marc Lasgouttes a écrit : Here is an updated patch following the feedback received here and at http://www.lyx.org/trac/ticket/10367 And of course, a screenshot (no you are not entitled to complain about the huge

Re: [RFC][PATCH] Set window title according to platform UI

On Thu, Sep 08, 2016 at 03:04:17PM +0200, Jean-Marc Lasgouttes wrote: > Le 08/09/2016 à 03:31, Enrico Forestieri a écrit : > > On Wed, Sep 07, 2016 at 03:13:38PM +0200, Jean-Marc Lasgouttes wrote: > > > > > And of course, a screenshot (no you are not entitled to complain about the > > > huge

Re: [RFC][PATCH] Set window title according to platform UI

Le 08/09/2016 à 15:04, Jean-Marc Lasgouttes a écrit : Your patch does not compile with Qt4, but removing the guard around #include fixes this. Was there a reason for this limitation? I removed the guard and pushed the patch. Hopefully, this will allow everybody to chime in if needed. This

Re: [RFC][PATCH] Set window title according to platform UI

Le 08/09/2016 à 03:31, Enrico Forestieri a écrit : On Wed, Sep 07, 2016 at 03:13:38PM +0200, Jean-Marc Lasgouttes wrote: And of course, a screenshot (no you are not entitled to complain about the huge readonly icon, only to help me fix it). Fixed in the attached. Thanks a lot, but let me

Re: [RFC][PATCH] Set window title according to platform UI

On Wed, Sep 07, 2016 at 03:13:38PM +0200, Jean-Marc Lasgouttes wrote: > And of course, a screenshot (no you are not entitled to complain about the > huge readonly icon, only to help me fix it). Fixed in the attached. -- Enrico From: Jean-Marc Lasgouttes Date: Tue, 6 Sep

Re: [RFC][PATCH] Set window title according to platform UI

Jean-Marc Lasgouttes wrote: > OK. And would a contextual menu be useful? It would not occur to me to click there honestly speaking... P

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 20:09, Pavel Sanda a écrit : I see, most of this is not currently implemented, few bits like author/commit/date were done for insetinfo, so one could dig in there. Personally I'm fine with just knowing that file is under VC & locking. Knowing commit history is one click away

Re: [RFC][PATCH] Set window title according to platform UI

Jean-Marc Lasgouttes wrote: >> What you mean by "state"? P > > I do not know. What would you like to know about the state of the document > in VC? If the answer is "nothing", then we can forget about that. > > Information could be for git: remote, branch, shortlog of last commit, > author... I

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 19:46, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: huge readonly icon, only to help me fix it). We can still use text instead of icon if there is no way to resize it. P Great minds thinking alike again :) JMarc

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 19:45, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Le 07/09/2016 ?? 15:10, Jean-Marc Lasgouttes a écrit : Here is an updated patch following the feedback received here and at http://www.lyx.org/trac/ticket/10367 If somebody gives me a method that describes the state of

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 19:30, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Le 06/09/2016 ?? 21:21, Jürgen Spitzmüller a écrit : We already display an icon on tabs for read-only. I'll remove the "read only" widget from status bar, then. Except that that icon is visible only in case multiple

Re: [RFC][PATCH] Set window title according to platform UI

Jean-Marc Lasgouttes wrote: > huge readonly icon, only to help me fix it). We can still use text instead of icon if there is no way to resize it. P

Re: [RFC][PATCH] Set window title according to platform UI

Jean-Marc Lasgouttes wrote: > Le 07/09/2016 ?? 15:10, Jean-Marc Lasgouttes a écrit : >> Here is an updated patch following the feedback received here and at >> http://www.lyx.org/trac/ticket/10367 > > If somebody gives me a method that describes the state of current VCS, I'll > gladly add it as a

Re: [RFC][PATCH] Set window title according to platform UI

Jean-Marc Lasgouttes wrote: > Le 06/09/2016 ?? 21:21, Jürgen Spitzmüller a écrit : >> We already display an icon on tabs for read-only. > > I'll remove the "read only" widget from status bar, then. Except that that icon is visible only in case multiple files are opened. I would let the read only

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 15:10, Jean-Marc Lasgouttes a écrit : Here is an updated patch following the feedback received here and at http://www.lyx.org/trac/ticket/10367 If somebody gives me a method that describes the state of current VCS, I'll gladly add it as a tooltip to the VCS label. JMarc

Re: [RFC][PATCH] Set window title according to platform UI

Le 06/09/2016 à 18:12, Jean-Marc Lasgouttes a écrit : Hello, The following patch uses Qt built-in mechanism for creating window title. This means that changed status is shown using an asterisk (except on Mac OS) and that read-only and version-control and not shown anymore. The patch also adds

Re: [RFC][PATCH] Set window title according to platform UI

Le 06/09/2016 à 23:31, Enrico Forestieri a écrit : Moreover, when connecting to a remote host via ssh and launching LyX, the string "@host" was appended to the window title. With this patch this is now lost. Could you show an example to me? I cannot reproduce that. JMarc

Re: [RFC][PATCH] Set window title according to platform UI

Le 06/09/2016 à 21:21, Jürgen Spitzmüller a écrit : We already display an icon on tabs for read-only. I'll remove the "read only" widget from status bar, then. I prefer a proper application name ("LyX") to the binary name (this is also what seems common). Version suffix information and such

Re: [RFC][PATCH] Set window title according to platform UI

Le 07/09/2016 à 03:53, Pavel Sanda a écrit : Enrico Forestieri wrote: The path info is lost This sucks, is it possible to get the path back? I use lot of automatically generated reports and they differ only where are the located, not by their name. Title used to be convenient way how to know

Re: [RFC][PATCH] Set window title according to platform UI

On Tue, Sep 06, 2016 at 06:42:38PM +0200, Jean-Marc Lasgouttes wrote: > For the laziest among you (I have names!), here is a screenshot. You underestimate my laziness. I would need both a before and an after screenshot :) Scott signature.asc Description: PGP signature

Re: [RFC][PATCH] Set window title according to platform UI

Enrico Forestieri wrote: > The path info is lost This sucks, is it possible to get the path back? I use lot of automatically generated reports and they differ only where are the located, not by their name. Title used to be convenient way how to know that. Pavel

Re: [RFC][PATCH] Set window title according to platform UI

On Tue, Sep 06, 2016 at 11:07:58PM +0200, Enrico Forestieri wrote: > On Tue, Sep 06, 2016 at 06:12:19PM +0200, Jean-Marc Lasgouttes wrote: > > Hello, > > > > The following patch uses Qt built-in mechanism for creating window title. > > This means that changed status is shown using an asterisk

Re: [RFC][PATCH] Set window title according to platform UI

On Tue, Sep 06, 2016 at 06:12:19PM +0200, Jean-Marc Lasgouttes wrote: > Hello, > > The following patch uses Qt built-in mechanism for creating window title. > This means that changed status is shown using an asterisk (except on Mac OS) > and that read-only and version-control and not shown

Re: [RFC][PATCH] Set window title according to platform UI

Am Dienstag, den 06.09.2016, 18:12 +0200 schrieb Jean-Marc Lasgouttes: > The following patch uses Qt built-in mechanism for creating window  > title. Excellent. > This means that changed status is shown using an asterisk (except  > on Mac OS) and that read-only and version-control and not shown

Re: [RFC][PATCH] Set window title according to platform UI

Le 06/09/2016 à 17:42, Jean-Marc Lasgouttes a écrit : Le 06/09/2016 à 18:12, Jean-Marc Lasgouttes a écrit : Hello, The following patch uses Qt built-in mechanism for creating window title. This means that changed status is shown using an asterisk (except on Mac OS) and that read-only and

[RFC][PATCH] Set window title according to platform UI

Hello, The following patch uses Qt built-in mechanism for creating window title. This means that changed status is shown using an asterisk (except on Mac OS) and that read-only and version-control and not shown anymore. The patch also adds two widgets to the status bar that provide this