Re: [patch] RFC: better submenu for tables

2015-11-17 Thread Uwe Stöhr
Am 17.11.2015 um 09:27 schrieb Jean-Marc Lasgouttes: Done now. I also added the toggles to Edit>Table. many thanks. regards Uwe

Re: [patch] RFC: better submenu for tables

2015-11-17 Thread Jean-Marc Lasgouttes
Le 17/11/2015 01:21, Uwe Stöhr a écrit : Am 13.11.2015 um 14:16 schrieb Jean-Marc Lasgouttes: Like the patch below? Yes, exactly, thanks. Please put this in. (and also the update of LFUNs.lyx in our doc folder.) Done now. I also added the toggles to Edit>Table. JMarc

Re: [patch] RFC: better submenu for tables

2015-11-16 Thread Uwe Stöhr
Am 13.11.2015 um 14:16 schrieb Jean-Marc Lasgouttes: Like the patch below? Yes, exactly, thanks. Please put this in. (and also the update of LFUNs.lyx in our doc folder.) Note that I renamed Dialog Settings to Settings... like everywhere else. OK. > And what should be done with the

Re: [patch] RFC: better submenu for tables

2015-11-16 Thread Kornel Benko
Am Sonntag, 15. November 2015 um 14:30:05, schrieb Jürgen Spitzmüller > Am Sonntag 15 November 2015, 14:10:07 schrieb Kornel Benko: > > Am Sonntag, 15. November 2015 um 13:36:50, schrieb Jürgen Spitzmüller > > > > > Am Freitag 13 November

Re: [patch] RFC: better submenu for tables

2015-11-15 Thread Kornel Benko
Am Sonntag, 15. November 2015 um 13:36:50, schrieb Jürgen Spitzmüller > Am Freitag 13 November 2015, 13:15:05 schrieb Kornel Benko: > > What about multipage table? > > Yes, why not. There are 5 strings which would need new wordings: 1 " long table" 2

Re: [patch] RFC: better submenu for tables

2015-11-15 Thread Jürgen Spitzmüller
Am Sonntag 15 November 2015, 14:10:07 schrieb Kornel Benko: > Am Sonntag, 15. November 2015 um 13:36:50, schrieb Jürgen Spitzmüller > > > Am Freitag 13 November 2015, 13:15:05 schrieb Kornel Benko: > > > What about multipage table? > > > > Yes, why not. > > There are 5

Re: [patch] RFC: better submenu for tables

2015-11-15 Thread Jürgen Spitzmüller
Am Freitag 13 November 2015, 13:15:05 schrieb Kornel Benko: > What about multipage table? Yes, why not. Jürgen

Re: [patch] RFC: better submenu for tables

2015-11-13 Thread Kornel Benko
Am Freitag, 13. November 2015 um 09:25:17, schrieb Jürgen Spitzmüller > Am Freitag 13 November 2015, 00:32:58 schrieb Uwe Stöhr: > > I changes it now as suggested by Jürgen and named it breakable table. > > As said, feel free to change this to a better name. > >

Re: [patch] RFC: better submenu for tables

2015-11-13 Thread Jürgen Spitzmüller
Am Freitag 13 November 2015, 00:32:58 schrieb Uwe Stöhr: > I changes it now as suggested by Jürgen and named it breakable table. > As said, feel free to change this to a better name. "Breakable table" sounds odd. I opt for "Allow page breaks" or "Allow page breaks in table" if you need to have

Re: [patch] RFC: better submenu for tables

2015-11-13 Thread Jean-Marc Lasgouttes
Le 12/11/2015 21:13, Andrew Parsloe a écrit : I think it is a mistake. I do not see why we should use this unenglish term. (I guess that "unenglish" is itself unenglish :) But "un-English" is in the New Oxford Dictionary of English. So that unenglish is un-Oxford. Thanks, I learn a little

Re: [patch] RFC: better submenu for tables

2015-11-13 Thread Jean-Marc Lasgouttes
Le 13/11/2015 00:36, Uwe Stöhr a écrit : I noticed that we don't have an LFUN to toggle the longtable and the booktabs. I therefore added now 2 entries to return to the default settings, despite I would like to have only 2 entries that toggle the feature. Like the patch below? Note that I

Re: [patch] RFC: better submenu for tables

2015-11-13 Thread Jean-Marc Lasgouttes
Le 13/11/2015 14:15, Jean-Marc Lasgouttes a écrit : Le 13/11/2015 00:36, Uwe Stöhr a écrit : I noticed that we don't have an LFUN to toggle the longtable and the booktabs. I therefore added now 2 entries to return to the default settings, despite I would like to have only 2 entries that toggle

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Andrew Parsloe
On 13/11/2015 3:23 a.m., Jean-Marc Lasgouttes wrote: Le 12/11/2015 01:30, Uwe Stöhr a écrit : +Menu "context-tabular" +Item "Formal style|F" "inset-modify tabular set-booktabs" +Item "Longtable|o" "inset-modify tabular set-longtabular" What about "Formal Table" and "Long

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Uwe Stöhr
Am 12.11.2015 um 17:12 schrieb Jürgen Spitzmüller: Personally, I would prefer something more transparent, such as "Allow page breaks". Nobody without knowledge of the longtable package knows what a "long table" is supposed to be. Good idea! Until we don't have a toggle entry, I named it

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Uwe Stöhr
Am 12.11.2015 um 15:23 schrieb Jean-Marc Lasgouttes: "Longtable" is used all over theplace in the docs as its own term I would therefore keep it. I think it is a mistake. I do not see why we should use this unenglish term. (I guess that "unenglish" is itself unenglish :) Because

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Scott Kostyshak
On Thu, Nov 12, 2015 at 01:02:17PM -0500, Richard Heck wrote: > On 11/12/2015 11:12 AM, Jürgen Spitzmüller wrote: > > 2015-11-12 16:14 GMT+01:00 Jean-Marc Lasgouttes: > > Likewise, > > "Longtable" feels like a German word : > > > I think > it is rather a LaTeXism. It is called "longtable"

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Uwe Stöhr
Am 12.11.2015 um 17:14 schrieb Jean-Marc Lasgouttes: Yes, allow page breaks looks nice. But of course this means that our dialog shall be reworked. Do we want to do that for 2.2, or wait until 2.3? I vote for now. It is just a changed string and the translators did not yet start their work.

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Uwe Stöhr
Am 12.11.2015 um 16:14 schrieb Jean-Marc Lasgouttes: OTOH, now that I actually tried the menu, I would say that it is not clear to know where table stuff starts. Having "Formal Table" would help. Is it better now? I noticed that we don't have an LFUN to toggle the longtable and the

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Guillaume Munch
Le 12/11/2015 00:30, Uwe Stöhr a écrit : Am 11.11.2015 um 13:13 schrieb Jean-Marc Lasgouttes: Many Thanks for reviewing. Since the menu name is about lines, should we just have entry Top/Bottom... Done. What about putting multirow with rows and multicolumns with columns? That#s a

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Guillaume Munch
Le 12/11/2015 00:34, Uwe Stöhr a écrit : Am 11.11.2015 um 13:57 schrieb Guillaume Munch: Well multirow and multicolumn is about cells, so I moved it with cells. multirow can be for several cells but also for complete rows. Therefore I don't think it is sensible to have a special cell group.

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Guillaume Munch
Le 12/11/2015 00:39, Uwe Stöhr a écrit : Am 11.11.2015 um 13:52 schrieb Guillaume Munch: Yes, I committed now a version which includes your and also JMarc's changes. Thanks again P.S.: it might be good to disable "inset-modify tabular multi(column|row)" when a single cell is selected and

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Jean-Marc Lasgouttes
Le 12/11/2015 01:30, Uwe Stöhr a écrit : +Menu "context-tabular" +Item "Formal style|F" "inset-modify tabular set-booktabs" +Item "Longtable|o" "inset-modify tabular set-longtabular" What about "Formal Table" and "Long Table"? "Longtable" is used all over theplace in the

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Jean-Marc Lasgouttes
Le 12/11/2015 12:16, Guillaume Munch a écrit : +Menu "context-tabular" +Item "Formal style|F" "inset-modify tabular set-booktabs" +Item "Longtable|o" "inset-modify tabular set-longtabular" What about "Formal Table" and "Long Table"? "Longtable" is used all over theplace in

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Richard Heck
On 11/12/2015 11:12 AM, Jürgen Spitzmüller wrote: > 2015-11-12 16:14 GMT+01:00 Jean-Marc Lasgouttes: > > Likewise, > "Longtable" feels like a German word : > > > I think it is rather a LaTeXism. It is called "longtable" (not "long table") since package, command and environment names cannot

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Jürgen Spitzmüller
2015-11-12 16:14 GMT+01:00 Jean-Marc Lasgouttes: > Likewise, "Longtable" feels like a German word : I think it is rather a LaTeXism. It is called "longtable" (not "long table") since package, command and environment names cannot have spaces. Personally, I would prefer something more

Re: [patch] RFC: better submenu for tables

2015-11-12 Thread Jean-Marc Lasgouttes
Le 12/11/2015 17:12, Jürgen Spitzmüller a écrit : 2015-11-12 16:14 GMT+01:00 Jean-Marc Lasgouttes: Likewise, "Longtable" feels like a German word : I think it is rather a LaTeXism. It is called "longtable" (not "long table") since package, command and environment names cannot have spaces.

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Jean-Marc Lasgouttes
Le 11/11/2015 01:53, Uwe Stöhr a écrit : I agree that submenus are better than to remove things. Attached is a patch. OK to go in? Thanks, we need something like that. A few comments: - Menu "context-tabular" - Item "Multicolumn|u" "inset-modify tabular multicolumn" -

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Guillaume Munch
Le 11/11/2015 12:57, Guillaume Munch a écrit : Le 11/11/2015 12:13, Jean-Marc Lasgouttes a écrit : Le 11/11/2015 01:53, Uwe Stöhr a écrit : I agree that submenus are better than to remove things. Attached is a patch. OK to go in? Thanks, we need something like that. A few comments (...)

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Guillaume Munch
Le 11/11/2015 12:13, Jean-Marc Lasgouttes a écrit : Le 11/11/2015 01:53, Uwe Stöhr a écrit : I agree that submenus are better than to remove things. Attached is a patch. OK to go in? Thanks, we need something like that. A few comments: Sorry, our messages crossed each-other. I could not

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Guillaume Munch
Le 11/11/2015 00:53, Uwe Stöhr a écrit : Am 04.11.2015 um 10:42 schrieb Jean-Marc Lasgouttes: This is not how contextual menus are supposed to work IMO. I would propose instead to use submenus and to micmick what libreoffice (for ex.) does. I agree that submenus are better than to remove

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Uwe Stöhr
Am 11.11.2015 um 13:57 schrieb Guillaume Munch: Many thanks for your review. I think that "Border" is clearer than "Line", and ok for just having Top/bottom... Done. Well multirow and multicolumn is about cells, so I moved it with cells. multirow can be for several cells but also for

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Uwe Stöhr
Am 11.11.2015 um 13:52 schrieb Guillaume Munch: I tried your patch, but it does not apply with "git apply". Did you use "git diff" to produce the diff? Yes, I did use unified diff. git apply works fine here. Then I applied it by hand. I like it but here are some minor comments: * I would

Re: [patch] RFC: better submenu for tables

2015-11-11 Thread Uwe Stöhr
Am 11.11.2015 um 13:13 schrieb Jean-Marc Lasgouttes: Many Thanks for reviewing. Since the menu name is about lines, should we just have entry Top/Bottom... Done. What about putting multirow with rows and multicolumns with columns? That#s a matter of taste. For multirow/column one needs