Re: Fwd: Try to wrap Midnight Commander in Rust
On 15.08.21 11:30, Yury V. Zaytsev wrote: Hello friends, I am was try to make Rust wrapper for Midnight Commander in >> https://github.com/vit1251/mc-rs <https://github.com/vit1251/mc-rs> could anyone please enlighten me, what's that all about ? Why replacing the well tested current automake build system by an rust program ? Just for the sake of calling it via cargo commend ? And if so, why not just calling the usual build system ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287 ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: leftover branches ?
* Andrew Borodin aboro...@vmail.ru schrieb: And now my questions to you: 1775_mvfs_9P 1775_mvfs_9P_2 1775_mvfs_9P_3 DEV_mvfs_fish DEV_mvfs_local METUX.mvfs Work in progress. I'll assign it to proper ticket when it passed test cycles. WTF? Why you created a lot of branches about your mvfs stuff??? Just continued the work I started about 1.5 years ago. MC dev team doesn't have any plans to use this unknown library. Did you do any one vote on that or do you now rule alone here ? Please remove that branches yourself and please don't push any mvfs-related code to the mc repo. Else your write access to the mc repo will be disabled. Are you sure you're officially authorized to impose those threats ? Did you check back with the guy who sponsors the infrastructure ? And do you think this is an appropriate reward for one of the people who practically revived mc from death ? If you develop the mc fork, please don't that in official mc server. In case you still didn't notice: the mvfs stuff was meant for upstream on day one. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Gentoo
* Sergei Trofimovich sly...@gentoo.org schrieb: Latest and greatest ebuilds do not have any patches, as they all are in upstream. So technically gentoo does not maintain local patches at all (there is no even single sed call). MC team does all maintenance for them and issues monthly releases. I find it good enough for such application. Great. If masking stage gives enough time to make bugfix release, this should suffice :) But what about the older releases ? Should we perhaps make hotfix releases for them ? Most of time gentoo users report bugs directly upstream and maintainer gets the solution from git tree if it can't wait next release. But those cases are too rare to maintain them separately. Those are the situations I'd like to circument (and for project where this happens frequently, there's oss-qm ;-)). BTW: one thing's a bit strange in the ebuilds: there's an dependency on e2fsprogs @linux. Seems that causes mc to include undelfs support. Better: have a separate useflags for the optional mc-vfs'es. It could be a dep on e2fsprogs-libs (which is a system depend and thus resides on most of gentoo boxes). ACK, of course. But my point was about the useflag: better introduce an separate one instead of automagically switching on kernel_linux. At this point it would be nice to introduce useflags for the vfs'es. It has more USE flags, but I find portage's aproach better: it exports to USEs only the things that matter for general user or have optional external depends. In particular 'use vfs ||' block looks horrible, and I don't think vfs use flag makes sense. In theory all VFSes could be exported to the use flags in a way APACHE2_MODULES, LINGUAS or INPUT_DEVICES. Exactly my proposal ;-p One thing should be kept in mind: The simpler ebuild the easier maintenance. Simplicity doesnt necessarily depend on amount of distinct useflags. You can cook-up the patch for latest ebuilds and push it to bugs.gentoo.org. Yep. Just let me finish up rebasing the mvfs branch to recent master (and see which of the vfs build fixes already have made it into master), then I'll look into the ebuild issue. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Gentoo
Hi folks, as some of us - Slyfox - now is initiated to the holy circle of Gentoo devs, this seems to be a good chance for a closer cooperation between mc.o + Gentoo. One concrete thing is that Gentoo still has several own patches, which i'd prefer to go away. So my proposal: maintain Gentoo branches/tags (on per-upstream-release basis) which contain all of Gentoo's changes directly (maybe there will also be several litte things which chould be done directly in the sourcetree instead of workarounds in the ebuilds) - this (IMHO) should make long-term maintenance (also for other distros which might be interested in Gentoo's changes). BTW: one thing's a bit strange in the ebuilds: there's an dependency on e2fsprogs @linux. Seems that causes mc to include undelfs support. Better: have a separate useflags for the optional mc-vfs'es. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Regular jabber meetings
Hi folks, what do you think about regular jabber meetings in a fixed timeframe (eg. 30mins, once or twice per week) where quickly discuss the project progress (what had been done, what's not done yet) and what the next steps should be ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Mc-devel Digest, Vol 66, Issue 5
* Yury V. Zaytsev y...@shurup.com schrieb: On Wed, 2010-01-06 at 16:33 +0100, Enrico Weigelt wrote: libmvfs is actively maintained by me (and I dont see any reason for abandoning it ever). As it's vital to several of my customer projects, I'll always maintain it. If you want it to be an open project, why wouldn't you for starters create a simple webpage for it so that others can participate? Why does participation need some website ? Everybody can grab the code and mail me. There are projects outside which now work for decades and are integral part of most GNU/Linux or xBSD distros. If you need anything concrete, just let me know. But please dont complain that such a small project doesnt have a big infrastructure. So far it's just a semi-private (probably publicly accessible though) git repo that no one even knows about. You (folks @ this list) know about it - that should be enough for MC's business. WHO is willing to fork it and maintain it if you are gone? * Who was willing to catch up the previously abandoned MC project ? * Who is willing to maintain the current mc-internal vfs ? * Who will be willing the - by certain folks here - planned completely new (again mc-internal) vfs layer ? No one knows about your project in the first place, that's the problem. Once there was a time nobody knew about Linux ... Even if I repeat myself now: my plan is to replace mc-internal vfs my mvfs in the long run. Of course, there's still a lot to do, mainly port existing vfs'es to mvfs. As smb is planned to be reimplemented ontop recent libsmb, this would be an ideal starting point. Once done, adding it to (mvfs-based) MC will take about 5mins. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Garbage collection
Hi folks, I'm working on using garbage collection (boehm-gc) instead of explicit free()'s. Perhaps you like to have a look at it. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Translation for mc
* Yury V. Zaytsev y...@shurup.com schrieb: In general, we try to release at least a beta release every two month with stable releases every 4-6 month or so. If you'd like to check what is the currently planned next release date, you can follow the roadmap on trac. Perhaps we could contigiously recreate the pot file and send diffs to the list / translators. Maybe this should directly happen on the WIP branches before merging. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: testfarm
Hi folks, I've now reworked the testfarm and put it into the MC-testfarm branch. Please have a look at it :) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: testfarm
Yury V. Zaytsev wrote: This looks interesting. Am I correct that this is only a framework for build tests for different combinations of build options (builds / doesn't build) and doesn't have anything to do with functional tests (e.g. works / doesn't work)? Right. Actually it's just a bunch of scripts which do tests builds. As you might already know, I'm building nightlies for all currently supported RH distros (with the exception of EL3) for almost half a year. Great. What configurations do you use ? Perhaps you could add them to the testfarm ? This has proved to be of great help, but now that I spared some money for new hardware I might consider doing the same for Debian / Ubuntu and running some kind of functional / build testsuite on a daily basis with the results published on the web / mailed to the list in case of failures. Yep, that was my idea for the next step: some build-results list where the bots post their results. or perhaps even create tickets (in an own category, so they dont mix up with the regular ones ;-o) It would be nice if we could introduce some officially supported testing framework in /contrib to check for most prominent bugs / general build options coverage etc. Yep, that's a good idea. I've just created a new ticket for it: http://www.midnight-commander.org/ticket/1891 Maybe we should also have a closer look at tinderbox or xenofarm. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ cellphone: +49 174 7066481 email: i...@metux.de skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
testfarm
hi folks, Slavo asked me to publish my test scripts, so here they're :) You probably need to fix some pathnames. Ah, and a copy of the repo has to be in __repo.git ... cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ cellphone: +49 174 7066481 email: i...@metux.de skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- testfarm.tar.bz2 Description: Binary data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Mc-devel Digest, Vol 66, Issue 5
* Yury V. Zaytsev y...@shurup.com schrieb: Hi, AFAIK, the samba library bundled with mc counts no ages. Not only it needs a rework, but it has to be throw out completely and replaced with a wrapper for some well supported samba library. actually, I'm writing on an MVFS backend for smb, so w/ MVFS support (which is awaiting votes for a long time now ;-o) MC will also get recent smb support. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #1813: Statifc buffer version of name_quote()
* MC Ticket System tick...@midnight-commander.org schrieb: 1. What about potential buffer overflow in execute_menu_command() (src/user.c:654)? User's input parameter is not length-limited. It will simply get cut-off if its larger than the buffer. Or simply stay w/ the allocating variant at this point. 2. The static buffer is effective when you allocate and free some piece of memory very often, many (hundred or thousand) times per second. But name_quote() is called once in each place where it's called. Maybe the saving is not that huge, but malloc()+free() add some overhead and a chance of memleaks. Even better would be utilizing alloca(), but that will involve a bit of preprocessor-fu, eg.: #define QUOTED_NAME(name,val) \ char* ##name = alloca(strlen(val)*2+2); \ __name_quote_buf(##name,val); cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: 4.7pre4
* Slava Zanko slavaza...@gmail.com schrieb: Hi, To me not. In really small systems better to use busybox without mc. Or just older versions of mc... What a great suggestion ;-o Why not? For example: do you tried to run KDE4 under your embedded hardware? I'm sure, you never think about this :). Is KDE1 or more lightweight (and older) WM have chance to run? I never ever considered KDE1 for embedded systems, always had been far too fat for that. But MC once was well suited for them. And what percentage of running mc greater: on end-user desktop (or on servers via ssh-connect) or in poor embedded devices? Actually, I know a lot of people using mc on small memory systems (from routers or controlling devices to VZs). Do you really want to piss off that userbase ? I'm talking about console file manager too. But I'm talking about less codebase and as result easy to support (maintain); use all standart technology(libraries), with many opportunities for featurefull development. What do you maintain on long approved code ? A result, I want to see mc with minimal size of executable and hard dependencies to glib and s-lang(ncurses) only. All other dependencies will calculated in runtime via dlopen/dlsum. And mc will have plugins for extend basic functionality. Plugins are a great way for making applications unreliable. Gratulations! For example, 'syntax coloring' plugin for editor. If some file is present (/usr/lib/mc/cooledit-syntaxhighlight.so) then editor have syntax highlight. Otherwise not. Same like for skins... or for filenames highlight... or for any other currently hardcoded visual effects. Why not just as a build-time flag ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: 4.7pre4
* Slava Zanko slavaza...@gmail.com schrieb: Hi, Small systems? In this case better way to use present libraries as possible for lesser size binary file and for less memory usage per one process. Assuming they're present at all. For lots of my systems, mc is currently the *only* app requiring glib, adding 868k. If libgio will come in, this will even extend to 99% of all my systems, adding 690k. To me not. In really small systems better to use busybox without mc. Or just older versions of mc... What a great suggestion ;-o I dont want the whole gnome blobs on dozens of small devices, VZs, etc just for mc. This is not a reason for drop external libraries from mc. No, but it's a reason for not adding more fat ones including their dependencies. Is you want big binary blobs of? In any case, for VZs you may use command: mount -obind /opt/VZ_environ/lib /home/some_user/vz/lib. Assuming, that sharing is possible at all (host *and* vz nodes are all under the same administration). What kind of power do you need from an VFS layer ? What's missing eg. in current mc's one ? WEBDAV; CURL; DeviceKit A matter of proper fileservers. (plan9 folks already have ones for http, webdav, ftp, ...) support; good realization of files/dirs change notification support etc. Besides local linux (inotify), there's little chance to get it working w/o cyclic reloading. No need to maintain any (builtin) libraries with mc (exclude in future libmc.so for better implementation of plugins). Plugins ?! What kind of scalability do you need ? In which direction should a VFS API scale ? Partially yes. Own realization of ini-files parser was good realization too (was grabbed some time ago from wine project). Aehm, what does an ini parser have to do w/ a VFS API ? Why we need for own VFS layer? libgio is full of things we most likely won't ever need. How do you know this? Does MC need the streaming stuff (which is just yet another wrapper around standard filesystem operations) ? Does MC need desktop icon stuff (render them in ascii ? ;-o) Does MC need yet another socket API (besides OS/libc) ? Does MC need yet another DNS resolver ? etc, etc, etc Note: I'm talking about whats really needed for a good _console_ file manager, not what could be done if certain people have too much tedium and dont care about loosing large parts of the traditional user base ;-o cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: 4.7pre4
* MP t...@centrum.cz schrieb: We could distribute multiple keybinding files aside of the default one -one in which MC will mimick Total commander keyboard shortcuts as close aspossible, one mimicking FAR manager as close as possible, perhaps someother if someone will send us something reasonable :) ACK. But we also should have the traditional one built-in as a compile-time option (for small systems). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: 4.7pre4
* Yury V. Zaytsev y...@shurup.com schrieb: I think that he wants us to pick another directory for configuration files like .mc-new, but even in this case I can't really follow his logic. ./configure --help ;-P cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: 4.7pre4
* SZABÓ Gergely s...@subogero.com schrieb: Actually mc implements a lot of CUA standards, but you seem to forget about the Norton/Total/Far traditions. I think it's equally (or more) important to conform to those traditions. Anybody who ever used a two-pane file-manager knows by heart what the keys F1 to F10 mean. And they all expect to be able to edit the command line without any further complications. ACK. These keybindings should not change (at least not in the default installation). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Originally from: http://www.midnight-commander.org/ticket/272#comment:7
* Slava Zanko slavaza...@gmail.com schrieb: Hi, Enrico, we need to concentrate on 'bugfixing' tickets, don't waste time on 'code cleanup' or on 'feature request' tickets, please. sure, but isn't the milestone @trac field the proper filter ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Home / End in viewer does not work in recent git
* Denys Vlasenko vda.li...@googlemail.com schrieb: My git-fu is weak, I don't know how to identify when exactly I did last git pull. git log shows this: Try git reflog cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
* Denys Vlasenko vda.li...@googlemail.com schrieb: For example, you can have a rule that committer is responsible for that. If you have a few people in your team whom you trust that they are organized enough to always do a compile test and a basic run test before committing, then they may be entrusted in fast-forwarding trivial stuff. Right, we sometimes have things that are trivial enough, eg. #1692. BUT: those things tend to be not important enough to get merged ASAP, so it doesnt hurt to wait until others had a look at them. And: there still may be better solutions, so it's always a good idea to have more eyes looking over it first. *If* we have really blocking things, there will be discussions here, triggering faster reviews, IMHO. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: duplicate definition of fast_reload
* Andrew Borodin aboro...@vmail.ru schrieb: On Wed, 28 Oct 2009 20:14:17 +0100 Enrico Weigelt wrote: just seen that the variable fast_reload is defined twice (once in main.c, once in screen.c), I cannot find that in main.c. fast_reload variable is declared as extern in panel.h and defined in screen.c only. Forget it, I fragged up my own code and just got confused ;-o sorry for the noise ... cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: building 4.6.2 with glib1
* Slava Zanko slavaza...@gmail.com schrieb: Hi, Enrico, 'been driven out of the team' is an incorrect words. At present time you have write access on git in m-c.o: I didnt talk about git/trac access, but the social climate in the dev-team, which - to me - wasnt a real team anymore. You know that it wasn't the glib issue, but was just the ignition spark. But I don't want to cook up those old silly stories - I'm just interested in technical advance, even if it requires maintaining my own fork. If you absolutely don't like glib - please, propose FULLY-replace library. That's just the start of the mess: one fat library for all. I'm currently in process of replacing glib stuff step by step, first things that can be done more efficiently and then those where other - specific and small - libs existing. The rule is _NOT_ kick off glib by any means (as opposite to the use glib by any means-doctrine), but carefully refactoring step by step. Not library with young age and/or poor-featured - need stable and fully-functional library. You want to support own library code? You want a stable library ? Then glib is not the right thing to look for. In my daily job (dev as well as operating), glib is one of the bigges troublemakers, especially incompatibe API changes within minor release - it really makes fun loosing important apps (like mc) on a production system just due an glib update. Glib may be smallest. For this, need to tuning glib (via glib bugzilla's feature request etc). Glib API is too big. It would require a complete refactoring, it had to be split into lots of smaller libs, ending up in an very different API. My experciences on glib-dev showed up that there's absolutely no interest in that there. MC just use convenient and 'soft' library. Yes, but with the inconvenience of loosing mc on several platforms. Many current features and thinks will impossible or will much harder to realize without glib. Isn't it? Which ones exactly ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Lots of breaks on -Werror
* Stan. S. Krupoderov pashel...@mail.ru schrieb: Feel free to create ticket and provide branch to review. See #1774 :) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
duplicate definition of fast_reload
Hi folks, just seen that the variable fast_reload is defined twice (once in main.c, once in screen.c), both declared as int and seem to be used as boolean. Are they actually the same variable ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: ncurses or slang
* Slava Zanko slavaza...@gmail.com schrieb: Hi folks, snip unless there's a damn good reason for slang, I'd prefer dropping slang in favour of ncurses. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: building 4.6.2 with glib1
* Gabor Z. Papp g...@papp.hu schrieb: Hi, Compiling current git with glib1 fails with the following error: you shouldn't be much surprised: glib1 and glib2 are totally different, very incompatible libraries, just happen to share the name and some ideas behind. BTW: I'm (again) working on getting rid of it at all, since glib is utterly broken/unusable on certain platforms (especially embedded ones) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: ncurses or slang
* Yury V. Zaytsev y...@shurup.com schrieb: On Tue, 2009-10-27 at 18:42 +0100, Enrico Weigelt wrote: unless there's a damn good reason for slang, I'd prefer dropping slang in favour of ncurses. Why would you drop anything at all unless there's a damn good reason for that? To make the whole code smaller and cleaner ;-P cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: building 4.6.2 with glib1
* Yury V. Zaytsev y...@shurup.com schrieb: On Tue, 2009-10-27 at 18:45 +0100, Enrico Weigelt wrote: BTW: I'm (again) working on getting rid of it at all, since glib is utterly broken/unusable on certain platforms (especially embedded ones) Would you please elaborate on how broken it is? For example makes trouble on uclibc (eg. Gentoo folks have theirs reasons to have it hardmasked on uclibc profiles). Oh, and it's quite fat - too fat for the targets I need mc for. P.S. It would be interesting to see your repo at some point. The links in your signature ATM are, unfortunately, broken/unusable on my platform ;-) Do you have a public mirror yet? Just was too lazy to reconfigure the signature for that list (because, since i'd been driven out of the team, i rarely come around here ...). My current projects are now exclusively in git repos - if you're interested in sth., just let me know. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: ncurses or slang
* Yury V. Zaytsev y...@shurup.com schrieb: On Tue, 2009-10-27 at 20:03 +0100, Enrico Weigelt wrote: * Yury V. Zaytsev y...@shurup.com schrieb: On Tue, 2009-10-27 at 18:42 +0100, Enrico Weigelt wrote: unless there's a damn good reason for slang, I'd prefer dropping slang in favour of ncurses. Why would you drop anything at all unless there's a damn good reason for that? To make the whole code smaller and cleaner ;-P Does not sound compelling enough to me. Did you try LFS? :-P yet too big for my targets. I've got my own build/distro system (which builds everything exclusively w/ sysroot'ed crosscompilers) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: building 4.6.2 with glib1
* Yury V. Zaytsev y...@shurup.com schrieb: On Tue, 2009-10-27 at 20:12 +0100, Enrico Weigelt wrote: Just was too lazy to reconfigure the signature for that list (because, since i'd been driven out of the team, i rarely come around here ...). My current projects are now exclusively in git repos - if you're interested in sth., just let me know. I'm interested in peeking in your branches :-) free-mc: git://git.metux.de/free-mc.git libmvfs: git://git.metux.de/libmvfs.git libmixp: git://git.metux.de/libmixp.git libmixpsrv: git://git.metux.de/libmixpsrv.git cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: EXTFS for Amazon S3
* Jakob Kemi jakob.k...@gmail.com schrieb: Hi, Ok, attached is an updated version of s3 extfs (updated instructions and clarified usage) This line is needed in extfs.ini: # Amazon S3 s3: I've added your patch into the extfs_amazon_s3 @ git://git.metux.de/free-mc.git Could you please provide some S3 account for testing ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: EXTFS for Amazon S3
* Jakob Kemi jakob.k...@gmail.com schrieb: I'm afraid not. Accounts are free but personal VISA/bank card information is needed. (see: http://aws.amazon.com/). Hopefully there are others that can verify it's functionality here. hmm, do you have an account so you can test it yourself ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Further Midnight Commander development
* Miguel de Icaza mig...@novell.com schrieb: The Midnight Commander development community is small and it is in my opinion a step backwards to fragment it at this point. Funny that you mention this, as it was *YOU* who forced another fork ;-o cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Re[2]: Further Midnight Commander development
* Miguel de Icaza mig...@novell.com schrieb: I agree with Pavel here. mc-dev has been for the most part dormant, and some terrible decisions (like that whole mhl fiasco) could have been avoided. I wouldn't call it fascio, rather a good lection that even the OSS world isn't free of people who press quasi-religous cruft and their own vanity over technical issues and resist against any attempt for a rational discussion. For a bunch of weeks we've formed a new, heavily motivated team, fixed a lot of ancient bugs, added lots of good patches floating around on other places for years and were working on several interesting features. In these few weeks we had a really active and motivated community with an very open and friendly climate. It was *YOU* destroyed that by climbing out of your deep dark tomb and behaving like the old king coming back which everyone has to submit to. It was you caused a lot of wasting resources (not just computer's but also human's) for your personal crusade against a lot of things we've done so far, without even listening to reasons why we did this, not because you had the slightest technical argument, but just because it didn't happen under your command. And that is exactly the reason why I abondened and created my own fork (*1) - as long as you are ruling here, I don't see the slightest bit of common ground. (and BTW, this was one of the major reasons why I've removed all my branches from mc.o git: I dont support dictators). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Further Midnight Commander development
* Miguel de Icaza mig...@novell.com schrieb: Hi, Your approach to development is my way or the high way. The consensus is that glib should stay, and even your concern about using glib was addressed by pointing you to eglib and I even ported mc and posted a patch to use eglib. First of all, it's not about technical reasons for glib, it's all about your glib fetishism, it's about having a hammer and then try to declare evrything as a nail to get more use for that hammer. BTW: * you totally ignored the user's request for having a glib-free MC, * you totally ignored that lots of the mhl-stuff had valid reasons, even *WITH* glib * you totally ignored that some glib functions have issues to be worked around * you totally ignored recommendation for defering this decision until eglib becomes production-ready * you totally ignored that lots of my changes you enforced your servants to revert, have *NOTHING* to do with mhl at all. You even didn't listen to my arguments. When you came out of your deep dark tomb, your first action was to declare that mhl must die. That was an declaration of war. Don't be pissed when somebody shoots back. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Re[2]: Further Midnight Commander development
* Enrico Weigelt weig...@metux.de schrieb: oh, forgot the link ;-o *1) git://git.metux.de/free-mc.git cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: updated: [fe95221] Rewrote the shell_escape function in order to make us of GString and g_string_append_c
* Patrick Winnertz win...@debian.org schrieb: The following commit has been merged in the master branch: commit fe95221f05e3cc4a80effdcb886768a9eb77efa7 Author: Patrick Winnertz win...@debian.org Date: Fri Feb 6 14:32:09 2009 +0100 Rewrote the shell_escape function in order to make us of GString and g_string_append_c As we decided to fully switch back to glb we needed to rewrite this function in order to use glib functions. This means in this case mostly that *ptr = c; ptr++; is replaced by something like this: g_string_append(str,c); with str a GString*. Am I the only one who sees how *stupid* this is ? Well, this is an good example of that crap I do NOT want to get along with and why I was forced to do my own fork ... cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Still many bugs in mhl/*.h
* Roland Illig roland.il...@gmx.de schrieb: Whenever I browse through the files in the new mhl/ directory, I stumble across lots of bugs. Feel free to report them. https://www.midnight-commander.org/newticket There are calls to isdigit(char) instead of the required isdigit(unsigned char), Where exactly does mhl/* use isdigit() ? many typos, Which ones exactly ? a buffer overflow in __mhl_str_concat_hlp, and probably many more. Where exactly ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] type accuracy in listbox routines
* Andrew Borodin aboro...@vmail.ru schrieb: Greetings! Since trac is still locked, I'm sending patch here. If you have git write access, you can also create a branch. (IMHO better than sending patches) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Abstracting away glib?
* Mourad De Clerck mou...@aquazul.com schrieb: Hi, a) memory requirements - as you probably know glib is being used for a lot of projects, to the point that it's hard to avoid at all, even on embedded; on platforms with really constrained memory (easy to OOM) glib is probably not ideal, but to be honest, I can't imagine running mc on those either; We're actually using only a *very* small percentage of glib - all we need easily fits in a bunch of .h files. Glib is just a fat blob which makes more hassle than it's worth it, IMHO ;-p b) performance - Enrico Weigelt mentioned some ways in which glib is underperforming or adding unnecessary abstractions. I'd argue that if it's just the implementation, it should be fixed in glib itself; In theory you're right. But from my own experience I can tell you that this won't happen (unless we're doing our own fork ;-o). c) possible interface breaks - I think every library has those, but I also think glib has been better than most in maintaining the compatibility since their last major API break 7 years ago. In recent years, I've experienced enough glib trouble (not just interface breaks) for disliking it, especially when it's not really needed. But I'd expected you to start using more of glib, instead of less. For what ? Where exactly is the benefit ? these; stuff like GIO/GVFS, No, please not. GVFS is yet another fat blob, and even worse: it runs everything over dbus. (dbus itself - IMHO - is an really stupid invention for things where an simple fs protocol like 9P would fit much better). We're currently in process of moving to libmvfs step by step, there's already a branch waiting for commit, which adds several libmvfs-based fs'es, like 9P. Once all of mc's own fs'es have been ported to libmvfs, we can replace mcvfs by libmvfs. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Building 4.6.2
* Patrick Winnertz win...@debian.org schrieb: It seeems that autogen.sh create links instead of copying the files to the correct place. Right, as it should be. The correct way is to run ./autogen.sh before ./configure, not just because there could be system dependent changes in autoconf stuff. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [161dc23] lib/mc.sh.in: fixes for non-bash shells (fixing #196)
The following commit has been merged in the mc-4.6 branch: commit 161dc235a618c33bda49dbd84295406d5273fb70 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 22:39:27 2009 +0100 lib/mc.sh.in: fixes for non-bash shells (fixing #196) diff --git a/ChangeLog b/ChangeLog index 9bdc617..74b6e0f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de + * lib/mc.sh.in: fixes for non-bash shells (fixing #196) + +2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #240) 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de diff --git a/lib/mc.sh.in b/lib/mc.sh.in index e3dc1fc..a829bf0 100644 --- a/lib/mc.sh.in +++ b/lib/mc.sh.in @@ -1 +1,3 @@ +# Don't define aliases in plain Bourne shell +[ -n ${BASH_VERSION}${KSH_VERSION}${ZSH_VERSION} ] || return 0 alias mc='. @suppbindir@/mc-wrapper.sh' -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [220f4f4] manually merged mc-4.6
The following commit has been merged in the master branch: commit 220f4f4cafb2a75fe9d9472cc93825fe986edd97 Merge: 41f06e42b143cb30256ded26923d8c7cf5d5e312 161dc235a618c33bda49dbd84295406d5273fb70 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Thu Feb 5 07:25:47 2009 +0100 manually merged mc-4.6 diff --combined ChangeLog index 92a95df,74b6e0f..82eca35 --- a/ChangeLog +++ b/ChangeLog @@@ -1,22 -1,21 +1,20 @@@ 2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #239, #240) + * lib/mc.sh.in: fixes for non-bash shells (fixing #196) 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il + * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) * vfs/extfs/u7z: patch from mandriva (#194) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -26,22 -25,13 +24,22 @@@ * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. odt2txt is now used @@@ -62,11 -52,6 +60,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -78,10 -63,6 +76,10 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + 2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: @@@ -91,12 -72,10 +89,12 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * vfs/extfs/rpm, vfs/extfs/trpm: removed obsolete rpm tags * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -104,32 -83,17 +102,32 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * configure.ac: + * lib/mc.ext.in: + * vfs/extfs/Makefile.am: + * vfs/extfs/extfs.ini: + * vfs/extfs/uace.in: + * vfs/extfs/uarc.in: + * vfs/extfs/uc1541.in: added support for historic archive formats +(patch provided by jpelletier) + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group * src/main.c: Removed unused function
updated: [03ec5ef] backported #199 branch
The following commit has been merged in the mc-4.6 branch: commit 03ec5ef5747da4f4b2913313fe6527491db330f2 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 00:29:28 2009 +0100 backported #199 branch diff --git a/ChangeLog b/ChangeLog index ed3c7f6..074fc58 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + * acinclude.m4: removed MC_SLANG_PRIVATE macro + * src/slint.c: removed HAVE_SLANG_PRIVATE conditional and + replaced SLang_getkey2(), SLang_input_pending2() * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) diff --git a/acinclude.m4 b/acinclude.m4 index f4c0e3b..aa2c6fa 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -299,44 +299,6 @@ AC_DEFUN([MC_USE_TERMCAP], [ dnl -dnl Check if private functions are available for linking -dnl -AC_DEFUN([MC_SLANG_PRIVATE], [ -AC_CACHE_CHECK([if S-Lang exports private functions], - [mc_cv_slang_private], [ - ac_save_LIBS=$LIBS - LIBS=$LIBS -lslang - AC_TRY_LINK([ -#ifdef HAVE_SLANG_SLANG_H -#include slang/slang.h -#else -#include slang.h -#endif -#if SLANG_VERSION = 1 -extern unsigned int SLsys_getkey (void); -#else -extern unsigned int _SLsys_getkey (void); -#endif - ], [ -#if SLANG_VERSION = 1 -_SLsys_getkey (); -#else -SLsys_getkey (); -#endif - ], - [mc_cv_slang_private=yes], - [mc_cv_slang_private=no]) - LIBS=$ac_save_LIBS -]) - -if test x$mc_cv_slang_private = xyes; then - AC_DEFINE(HAVE_SLANG_PRIVATE, 1, - [Define if private S-Lang functions are available]) -fi -]) - - -dnl dnl Check if the installed S-Lang library uses termcap dnl AC_DEFUN([MC_SLANG_TERMCAP], [ @@ -411,7 +373,6 @@ it's not fully supported yet]) if test x$with_screen = xslang; then AC_DEFINE(HAVE_SYSTEM_SLANG, 1, [Define to use S-Lang library installed on the system]) - MC_SLANG_PRIVATE screen_type=slang screen_msg=S-Lang library (installed on the system) else diff --git a/src/slint.c b/src/slint.c index c30fac1..cf87322 100644 --- a/src/slint.c +++ b/src/slint.c @@ -77,66 +77,6 @@ static int no_slang_delay; /* Forward declarations */ static void load_terminfo_keys (void); -#ifndef HAVE_SLANG_PRIVATE -/* Private interfaces have been stripped, so we cannot use them */ -#define SLang_getkey2() SLang_getkey() -#define SLang_input_pending2(s) SLang_input_pending(s) -#else -/* Copied from ../slang/slgetkey.c, removed the DEC_8Bit_HACK. */ -extern unsigned char SLang_Input_Buffer []; -#if SLANG_VERSION = 1 -extern unsigned int _SLsys_getkey (void); -extern int _SLsys_input_pending (int); -#else -extern unsigned int SLsys_getkey (void); -extern int SLsys_input_pending (int); -#endif - -static unsigned int SLang_getkey2 (void) -{ - unsigned int imax; - unsigned int ch; - - if (SLang_Input_Buffer_Len) - { - ch = (unsigned int) *SLang_Input_Buffer; - SLang_Input_Buffer_Len--; - imax = SLang_Input_Buffer_Len; - - memmove ((char *) SLang_Input_Buffer, - (char *) (SLang_Input_Buffer + 1), imax); - return(ch); - } -#if SLANG_VERSION = 1 - else return(_SLsys_getkey ()); -#else - else return(SLsys_getkey()); -#endif -} - -static int SLang_input_pending2 (int tsecs) -{ - int n, i; - unsigned char c; - - if (SLang_Input_Buffer_Len) return (int) SLang_Input_Buffer_Len; -#if SLANG_VERSION = 1 - n = _SLsys_input_pending (tsecs); -#else - n = SLsys_input_pending (tsecs); -#endif - if (n = 0) return 0; - - i = SLang_getkey2 (); - if (i == SLANG_GETKEY_ERROR) - return 0; /* don't put crippled error codes into the input buffer */ - c = (unsigned char)i; - SLang_ungetkey_string (c, 1); - - return n; -} -#endif /* HAVE_SLANG_PRIVATE */ - /* Only done the first time */ void slang_init (void) @@ -465,10 +405,10 @@ getch (void) { int c; if (no_slang_delay) - if (SLang_input_pending2 (0) == 0) + if (SLang_input_pending (0) == 0) return -1; -c = SLang_getkey2 (); +c = SLang_getkey (); if (c == SLANG_GETKEY_ERROR) { fprintf (stderr, SLang_getkey returned SLANG_GETKEY_ERROR\n -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [be98250] Merge commit 'origin/mc-4.6'
The following commit has been merged in the master branch: commit be982505ccc12065ee2ffe041c88107cd6b3041c Merge: 9b9cab58749217101ab16504a77efb301812cfbf 03ec5ef5747da4f4b2913313fe6527491db330f2 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 00:30:57 2009 +0100 Merge commit 'origin/mc-4.6' diff --combined ChangeLog index 832520c,074fc58..1bf1589 --- a/ChangeLog +++ b/ChangeLog @@@ -1,9 -1,11 +1,12 @@@ 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + * acinclude.m4: removed MC_SLANG_PRIVATE macro + * src/slint.c: removed HAVE_SLANG_PRIVATE conditional and + replaced SLang_getkey2(), SLang_input_pending2() * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -12,23 -14,17 +15,23 @@@ * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine - -2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de - * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. odt2txt is now used @@@ -42,6 -38,9 +45,6 @@@ * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type SHELL_ESCAPED_STR for more type safety - -2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de - * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ 2009-01-27 Sergei Trofimovich sly...@inbox.ru @@@ -49,11 -48,6 +52,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -65,11 -59,7 +68,11 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now -2009-01-25 Enrico Weigelt weig...@metux.de +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + +2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: @@@ -78,11 -68,9 +81,11 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -90,21 -78,17 +93,21 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group * src/main.c: Removed unused function do_mc_filename_rename * src/util.c: Removed unused struct whentm -2009-01-16 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-16
updated: [d4927f9] Merge commit 'origin/201_historic_compressors'
The following commit has been merged in the master branch: commit d4927f99efd0f073edbcebcc2e4aa8ab4426f5d9 Merge: be982505ccc12065ee2ffe041c88107cd6b3041c 173ca89fca88f65e9b459a520685b02d1bfafed0 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 00:41:30 2009 +0100 Merge commit 'origin/201_historic_compressors' diff --combined ChangeLog index 1bf1589,9106f7b..1842bf9 --- a/ChangeLog +++ b/ChangeLog @@@ -1,98 -1,15 +1,109 @@@ +2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + + * acinclude.m4: removed MC_SLANG_PRIVATE macro + * src/slint.c: removed HAVE_SLANG_PRIVATE conditional and +replaced SLang_getkey2(), SLang_input_pending2() + * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() +(patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) + +2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru + + * edit/editcmd.c, mhl/escape.h, mhl/string.h, mhl/types.h, src/Makefile.am, + * src/boxes.c, src/command.c, src/complete.c, src/complete.h, src/file.c, + * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, + * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: +fixed shell escaping issues in commandline completion engine + * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 +(out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() + +2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. +odt2txt is now used + +2009-01-29 Patrick Winnertz win...@debian.org Sergei Trofimovich sly...@inbox.ru + + * src/file.c: Added trailing dir separator for default path in copy/move dialogs. +This solves strange rename cases, when copying/moving is performed into +deleted directory. + +2009-01-27 Enrico Weigelt, metux ITS weig...@metux.de + + * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type +SHELL_ESCAPED_STR for more type safety + * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ + +2009-01-27 Sergei Trofimovich sly...@inbox.ru + + * syntax/python.syntax: Added syntax highlighting for + pytnoh-2.6+ keywords (patch sent by NNemec) + +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + +2009-01-25 Ilia Maslakov il.sm...@gmail.com + + * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: + * src/main.c, src/panel.h, src/screen.c, src/setup.c: +- Add support for showing executables at first in the panel view + +2009-01-25 Patrick Winnertz win...@debian.org Sergei Trofimovich sly...@inbox.ru + + * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code +so that symlinks and files which special characters works now + +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + +2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de + + * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: + * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: + * src/view.c, vfs/ftpfs.c, vfs/utilvfs.c: +- Made history section names statically instead of dynamic +translated strings. This breaks now once every history file +but afterwards this will be stable + +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de + + * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files + +2009-01-24 Patrick Winnertz win...@debian.org + + * edit/editcmd.c: Fix some issues about regex: +- prevent . to match a newline (\n) +- match from start of line and not from cursor position + 2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * configure.ac: + * lib/mc.ext.in: + * vfs/extfs/Makefile.am: + * vfs/extfs/extfs.ini: + * vfs
updated: [f2a745a] merged #242
The following commit has been merged in the master branch: commit f2a745a47d9152703e35d6dbf09d3bef49873802 Merge: e5cad3802b8080432230ba7d1d66e068a6f703a2 463a18623d550c62035ae82895fbe41bebb7bf31 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 00:47:29 2009 +0100 merged #242 diff --combined ChangeLog index 3d9b8e8,0cc786f..bde2924 --- a/ChangeLog +++ b/ChangeLog @@@ -1,12 -1,9 +1,13 @@@ 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de + * lib/mc.lib: added patch on #219 by angel_il + * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + * acinclude.m4: removed MC_SLANG_PRIVATE macro + * src/slint.c: removed HAVE_SLANG_PRIVATE conditional and +replaced SLang_getkey2(), SLang_input_pending2() * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) @@@ -97,17 -94,6 +98,17 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * configure.ac: + * lib/mc.ext.in: + * vfs/extfs/Makefile.am: + * vfs/extfs/extfs.ini: + * vfs/extfs/uace.in: + * vfs/extfs/uarc.in: + * vfs/extfs/uc1541.in: added support for historic archive formats +(patch provided by jpelletier) + 2009-01-19 Patrick Winnertz win...@debian.org * edit/edit.h: Add two more ints diff --combined configure.ac index 8bc7a16,1dad2ee..791a4d8 --- a/configure.ac +++ b/configure.ac @@@ -176,7 -176,7 +176,7 @@@ AC_CHECK_FUNCS([ cfgetospeed \ getegid geteuid getgid getsid getuid \ initgroups isascii \ - memcpy memmove memset \ + memcpy memset \ putenv \ setreuid setuid statfs strerror strftime sysconf \ tcgetattr tcsetattr truncate \ @@@ -605,12 -605,9 +605,12 @@@ vfs/extfs/lsl vfs/extfs/mailfs vfs/extfs/patchfs vfs/extfs/rpms +vfs/extfs/uace vfs/extfs/ualz vfs/extfs/uar +vfs/extfs/uarc vfs/extfs/uarj +vfs/extfs/uc1541 vfs/extfs/uha vfs/extfs/ulha vfs/extfs/urar -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [5d4d91c] fixed #239
The following commit has been merged in the master branch: commit 5d4d91cd361959edbef71bbdbfe3ba2077c50426 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Tue Feb 3 17:58:47 2009 +0100 fixed #239 diff --git a/ChangeLog b/ChangeLog index 026d3ce..4826718 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,8 @@ * lib/mc.lib: added patch on #219 by angel_il * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) + * mhl/escape.h: including stdbool.h for the bool type (fixing #239) + * mhl/types.h: removed redundant bool type (fixing #239) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [0c97636] fixed #240
The following commit has been merged in the master branch: commit 0c976362125a42ead215d11251fe0ebbd8ddf8ef Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Tue Feb 3 18:21:16 2009 +0100 fixed #240 diff --git a/ChangeLog b/ChangeLog index 4826718..47749be 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,7 @@ * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) * mhl/escape.h: including stdbool.h for the bool type (fixing #239) * mhl/types.h: removed redundant bool type (fixing #239) + * replaced bool type in mhl/types.h by stdbool.h (fixing #240) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de diff --git a/edit/usermap.c b/edit/usermap.c index b25cad9..7914d75 100644 --- a/edit/usermap.c +++ b/edit/usermap.c @@ -29,8 +29,8 @@ #include sys/types.h #include sys/stat.h #include unistd.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/edit/usermap.h b/edit/usermap.h index bf06d12..29097c4 100644 --- a/edit/usermap.h +++ b/edit/usermap.h @@ -1,7 +1,7 @@ #ifndef MC_USERMAP_H #define MC_USERMAP_H -#include mhl/types.h +#include stdbool.h #define MC_USERMAP .mc/cedit/cooledit.bindings diff --git a/src/ecs-test.c b/src/ecs-test.c index 963a63b..2493be9 100644 --- a/src/ecs-test.c +++ b/src/ecs-test.c @@ -28,8 +28,7 @@ #include assert.h #include locale.h #include stdio.h - -#include mhl/types.h +#include stdbool.h #include global.h #include ecs.h diff --git a/src/ecs.c b/src/ecs.c index a38c54e..cd8da0c 100644 --- a/src/ecs.c +++ b/src/ecs.c @@ -26,8 +26,8 @@ #include assert.h #include ctype.h +#include stdbool.h -#include mhl/types.h #include mhl/string.h #include global.h diff --git a/src/ecs.h b/src/ecs.h index 98e9a9a..1a53c6f 100644 --- a/src/ecs.h +++ b/src/ecs.h @@ -44,7 +44,7 @@ typedef char ecs_char; # define ECS_STR(s) (s) #endif -#include mhl/types.h +#include stdbool.h /* * String conversion functions between the wide character encoding and diff --git a/src/file.c b/src/file.c index 1a367ea..ebd414e 100644 --- a/src/file.c +++ b/src/file.c @@ -48,8 +48,8 @@ #include sys/types.h #include sys/stat.h #include unistd.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/escape.h #include mhl/string.h diff --git a/src/find.c b/src/find.c index bf95b7f..564ed86 100644 --- a/src/find.c +++ b/src/find.c @@ -26,8 +26,8 @@ #include stdlib.h #include string.h #include sys/stat.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/key.c b/src/key.c index 1434fa7..3bf66de 100644 --- a/src/key.c +++ b/src/key.c @@ -31,8 +31,8 @@ #include string.h #include sys/types.h #include unistd.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/logging.c b/src/logging.c index a48dcfb..60db3e6 100644 --- a/src/logging.c +++ b/src/logging.c @@ -25,9 +25,9 @@ #include stdarg.h #include stdio.h +#include stdbool.h #include mhl/memory.h -#include mhl/types.h #include global.h #include logging.h diff --git a/src/treestore.c b/src/treestore.c index cb08cb2..e8d81ec 100644 --- a/src/treestore.c +++ b/src/treestore.c @@ -40,8 +40,8 @@ #include sys/types.h #include sys/stat.h #include unistd.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/tty.c b/src/tty.c index 44b40e5..70dbfb6 100644 --- a/src/tty.c +++ b/src/tty.c @@ -28,6 +28,7 @@ #include signal.h #include stdarg.h +#include stdbool.h #include mhl/types.h diff --git a/src/tty.h b/src/tty.h index f6d520b..b7ea928 100644 --- a/src/tty.h +++ b/src/tty.h @@ -25,7 +25,7 @@ #endif /* WANT_TERM_H */ #endif /* USE_NCURSES */ -#include mhl/types.h +#include stdbool.h /* {{{ Input }}} */ diff --git a/src/utilunix.c b/src/utilunix.c index 4cf70dc..71f839a 100644 --- a/src/utilunix.c +++ b/src/utilunix.c @@ -32,7 +32,7 @@ #include stdio.h #include stdlib.h #include string.h - +#include stdbool.h #include sys/param.h #include sys/types.h #include sys/stat.h @@ -41,7 +41,6 @@ #endif #include unistd.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/view.c b/src/view.c index dcd3559..b00916a 100644 --- a/src/view.c +++ b/src/view.c @@ -42,8 +42,8 @@ #include sys/types.h #include sys/stat.h #include unistd.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/widget.c b/src/widget.c index 31afab6..e8f8be3 100644 --- a/src/widget.c +++ b/src/widget.c @@ -33,8 +33,8 @@ #include stdio.h #include string.h #include sys/types.h +#include stdbool.h -#include mhl/types.h #include mhl/memory.h #include mhl/string.h diff --git a/src/widget.h b/src/widget.h index d7596b1..772b1b7 100644 --- a/src/widget.h +++ b/src/widget.h @@ -1,7 +1,7 @@ #ifndef
updated: [d3d1ff4] changelog fixes
The following commit has been merged in the master branch: commit d3d1ff4faad9eda04663fde83666b6237727cb39 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 01:13:31 2009 +0100 changelog fixes diff --git a/ChangeLog b/ChangeLog index 47749be..696a1af 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,14 +1,11 @@ 2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de - * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #240) + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #239, #240) 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) - * mhl/escape.h: including stdbool.h for the bool type (fixing #239) - * mhl/types.h: removed redundant bool type (fixing #239) - * replaced bool type in mhl/types.h by stdbool.h (fixing #240) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [584caa7] manually merged mc-4.6
The following commit has been merged in the master branch: commit 584caa79497b3672624d2b5f913fa56198f4a930 Merge: d3d1ff4faad9eda04663fde83666b6237727cb39 adbe38172de077ce943e3de81a954bd7e2fa1b5e Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 01:26:28 2009 +0100 manually merged mc-4.6 diff --combined ChangeLog index 696a1af,2421f92..45c9f35 --- a/ChangeLog +++ b/ChangeLog @@@ -1,11 -1,11 +1,12 @@@ 2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de - * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #240) + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #239, #240) 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il + * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) + * vfs/extfs/u7z: patch from mandriva (#194) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de @@@ -15,7 -15,6 +16,7 @@@ * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -25,22 -24,13 +26,22 @@@ * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. odt2txt is now used @@@ -61,11 -51,6 +62,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -77,11 -62,7 +78,11 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now -2009-01-25 Enrico Weigelt weig...@metux.de +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + +2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: @@@ -90,11 -71,9 +91,11 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -102,32 -81,17 +103,32 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * configure.ac: + * lib/mc.ext.in: + * vfs/extfs/Makefile.am: + * vfs/extfs/extfs.ini: + * vfs/extfs/uace.in: + * vfs/extfs/uarc.in: + * vfs/extfs/uc1541.in: added support for historic archive formats +(patch provided by jpelletier) + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused
updated: [1d8ef0b] fixed #240
The following commit has been merged in the mc-4.6 branch: commit 1d8ef0b089bcb6828b0dde62076493178ed185ec Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 01:08:29 2009 +0100 fixed #240 diff --git a/ChangeLog b/ChangeLog index a529eb9..6e808b1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de + + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #240) + 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il @@ -18,9 +22,6 @@ * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine - -2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de - * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de @@ -42,9 +43,6 @@ * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type SHELL_ESCAPED_STR for more type safety - -2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de - * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ 2009-01-27 Sergei Trofimovich sly...@inbox.ru diff --git a/mhl/escape.h b/mhl/escape.h index 2ec4e0d..ed25b60 100644 --- a/mhl/escape.h +++ b/mhl/escape.h @@ -5,8 +5,7 @@ #include string.h #include stdlib.h - -#include mhl/types.h +#include stdbool.h #define mhl_shell_escape_toesc(x) \ (((x)==' ')||((x)=='!')||((x)=='#')||((x)=='$')||((x)=='%')|| \ diff --git a/mhl/types.h b/mhl/types.h index 1f84002..f88190c 100644 --- a/mhl/types.h +++ b/mhl/types.h @@ -7,10 +7,4 @@ #ifndef __MHL_TYPES_H #define __MHL_TYPES_H -typedef enum -{ -false = 0, -true = 1 -} bool; - #endif -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [adbe381] added patch from #194
The following commit has been merged in the mc-4.6 branch: commit adbe38172de077ce943e3de81a954bd7e2fa1b5e Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Tue Feb 3 03:21:32 2009 +0100 added patch from #194 diff --git a/ChangeLog b/ChangeLog index 6e808b1..2421f92 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,7 @@ 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il + * vfs/extfs/u7z: patch from mandriva (#194) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de diff --git a/vfs/extfs/u7z b/vfs/extfs/u7z index 0803574..b346d05 100644 --- a/vfs/extfs/u7z +++ b/vfs/extfs/u7z @@ -2,6 +2,7 @@ # # extfs support for p7zip # Written by Pavel Roskin pro...@gnu.org +# Some Bugfixes/workarounds by Sergiy Niskorodov s...@mail.zp.ua # Licensed under GNU GPL version 2 or later version. P7ZIP=7za @@ -19,7 +20,10 @@ mcu7zip_list () mcu7zip_copyout () { - $P7ZIP e -so $1 $2 $3 2/dev/null + #first we check if we have old p7zip archive with prefix ./ in filename + $P7ZIP l $1 $2 | grep -q 0 files \ + EXFNAME=*./$2 || EXFNAME=$2 + $P7ZIP e -so $1 $EXFNAME $3 2/dev/null } mcu7zip_copyin () @@ -31,19 +35,27 @@ mcu7zip_mkdir () { dir=`mktemp -d ${MC_TMPDIR:-/tmp}/mctmpdir-u7z.XX` || exit 1 mkdir -p $dir/$2 - $P7ZIP a -w$dir $1 $2 /dev/null 21 + $P7ZIP a -w$dir $1 $dir/$2 /dev/null 21 rm -rf $dir } mcu7zip_rm () { # NOTE: Version 4.20 fails to delete files in subdirectories - $P7ZIP d $1 $2 /dev/null 21 + #first we check if we have old p7zip archive with prefix ./ in filename + $P7ZIP l $1 $2 | grep -q 0 files \ + EXFNAME=*./$2 || EXFNAME=$2 + $P7ZIP d $1 $EXFNAME 21 | grep -q E_NOTIMPL /dev/null \ + { echo -e Function not implemented...\n7z cannot delete from solid archive. 2 ; exit 1 ; } } mcu7zip_rmdir () { - $P7ZIP d $1 $2/ /dev/null 21 + #first we check if we have old p7zip archive with prefix ./ in filename + $P7ZIP l $1 $2 | grep -q 0 files \ + EXFNAME=*./$2 || EXFNAME=$2 + $P7ZIP d $1 $EXFNAME/ 21 | grep -q E_NOTIMPL /dev/null \ + { echo -e Function not implemented...\n7z cannot delete from solid archive. 2 ; exit 1 ; } } # override any locale for dates -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [648a377] merged mc-4.6
The following commit has been merged in the master branch: commit 648a377ad87cea89af81773bc2f6ddf53735fcdd Merge: 584caa79497b3672624d2b5f913fa56198f4a930 5f84762472cd481e25bd5c2b9a115200192abbc3 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Wed Feb 4 04:11:17 2009 +0100 merged mc-4.6 diff --combined ChangeLog index 45c9f35,b48e121..92a95df --- a/ChangeLog +++ b/ChangeLog @@@ -1,11 -1,10 +1,11 @@@ 2009-02-04 Enrico Weigelt, metux ITS weig...@metux.de - * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #240) + * mhl/types.h, mhl/escape.h: replaced bool type by stdbool.h (fixing #239, #240) 2009-02-03 Enrico Weigelt, metux ITS weig...@metux.de * lib/mc.lib: added patch on #219 by angel_il + * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242) * vfs/extfs/u7z: patch from mandriva (#194) 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de @@@ -16,7 -15,6 +16,7 @@@ * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -26,22 -24,13 +26,22 @@@ * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. odt2txt is now used @@@ -62,11 -51,6 +62,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -78,10 -62,6 +78,10 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + 2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: @@@ -91,11 -71,10 +91,12 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de + * vfs/extfs/rpm, vfs/extfs/trpm: removed obsolete rpm tags * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -103,32 -82,17 +104,32 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * configure.ac: + * lib/mc.ext.in: + * vfs/extfs/Makefile.am: + * vfs/extfs/extfs.ini: + * vfs/extfs/uace.in: + * vfs/extfs/uarc.in: + * vfs/extfs/uc1541.in: added support for historic archive formats +(patch provided by jpelletier) + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group * src/main.c
updated: [0434e3d] manually merged 235_remove_g_snprintf
The following commit has been merged in the master branch: commit 0434e3de5d20323bed8b7b2dbff74c1d00a221ec Merge: 3410eb32290abe51e6845483ed7a3723823a768a e4a4f77ac28f064d0fd5611a1b48689594289408 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Mon Feb 2 20:53:03 2009 +0100 manually merged 235_remove_g_snprintf diff --combined ChangeLog index 2c39360,a54e8eb..3b5bab1 --- a/ChangeLog +++ b/ChangeLog @@@ -1,20 -1,7 +1,21 @@@ +2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + + * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() +(patch from andrew_b) + +2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru + + * edit/editcmd.c, mhl/escape.h, mhl/string.h, mhl/types.h, src/Makefile.am, + * src/boxes.c, src/command.c, src/complete.c, src/complete.h, src/file.c, + * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, + * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: +fixed shell escaping issues in commandline completion engine + 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de @@@ -31,11 -18,6 +32,11 @@@ This solves strange rename cases, when copying/moving is performed into deleted directory. +2009-01-27 Enrico Weigelt, metux ITS weig...@metux.de + + * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type +SHELL_ESCAPED_STR for more type safety + 2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ diff --combined edit/editcmd.c index 07286b6,792322d..7dae88a --- a/edit/editcmd.c +++ b/edit/editcmd.c @@@ -626,7 -626,7 +626,7 @@@ edit_raw_key_query (const char *heading NULL, heading, DLG_CENTER | DLG_TRYUP | DLG_WANT_TAB); add_widget (raw_dlg, - input_new (3 - cancel, w - 5, INPUT_COLOR, 2, , 0)); + input_new (3 - cancel, w - 5, INPUT_COLOR, 2, , 0, INPUT_COMPLETE_DEFAULT)); add_widget (raw_dlg, label_new (3 - cancel, 2, query)); if (cancel) add_widget (raw_dlg, @@@ -2337,7 -2337,7 +2337,7 @@@ edit_goto_cmd (WEdit *edit char *error; char s[32]; - g_snprintf (s, sizeof (s), %ld, line); + snprintf (s, sizeof (s), %ld, line); f = input_dialog (_( Goto line ), _( Enter line: ), MC_HISTORY_EDIT_GOTO_LINE, line ? s : ); if (!f) diff --combined src/boxes.c index 48ac3a9,23030ec..a46aeec --- a/src/boxes.c +++ b/src/boxes.c @@@ -197,7 -197,7 +197,7 @@@ display_init (int radio_sel, char *init status = input_new (10, 9, INPUT_COLOR, DISPLAY_X - 14, _status[radio_sel], - mini-input); + mini-input, INPUT_COMPLETE_DEFAULT); add_widget (dd, status); input_set_point (status, 0); @@@ -207,7 -207,7 +207,7 @@@ user = input_new (7, 9, INPUT_COLOR, DISPLAY_X - 14, init_text, - user-fmt-input); + user-fmt-input, INPUT_COMPLETE_DEFAULT); add_widget (dd, user); input_set_point (user, 0); @@@ -571,7 -571,7 +571,7 @@@ sel_charset_button (int action : codepages[new_display_codepage].name; /* avoid strange bug with label repainting */ - g_snprintf (buf, sizeof (buf), %-27s, cpname); + snprintf (buf, sizeof (buf), %-27s, cpname); label_set_text (cplabel, buf); return 0; } @@@ -772,12 -772,12 +772,12 @@@ configure_vfs (void ret_use_netrc = use_netrc; ret_ftpfs_use_passive_connections = ftpfs_use_passive_connections; ret_ftpfs_use_passive_connections_over_proxy = ftpfs_use_passive_connections_over_proxy; - g_snprintf(buffer3, sizeof (buffer3), %i, ftpfs_directory_timeout); + snprintf(buffer3, sizeof (buffer3), %i, ftpfs_directory_timeout); confvfs_widgets[8].text = buffer3; confvfs_widgets[10].text = ftpfs_anonymous_passwd; confvfs_widgets[5].text = ftpfs_proxy_host; #endif - g_snprintf (buffer2, sizeof (buffer2), %i, vfs_timeout); + snprintf (buffer2, sizeof (buffer2), %i, vfs_timeout); confvfs_widgets [3 + VFS_WIDGETBASE].text = buffer2; if (quick_dialog (confvfs_dlg) != B_CANCEL) { @@@ -1085,17 -1085,17 +1085,17 @@@ vfs_smb_get_authinfo (const char *host g_free (title); -in_user = input_new (5, istart, INPUT_COLOR, ilen, user, auth_name); +in_user = input_new (5, istart, INPUT_COLOR, ilen, user, auth_name, INPUT_COMPLETE_DEFAULT); add_widget (auth_dlg, in_user); -in_domain
updated: [fb745c7] manually merged 193_vhdl_syntax
The following commit has been merged in the master branch: commit fb745c77ff7636cfb2eedbac929679f06adbf28b Merge: 0434e3de5d20323bed8b7b2dbff74c1d00a221ec b1641d2540b992b0b614d613f97b042794c1eaae Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Mon Feb 2 20:58:55 2009 +0100 manually merged 193_vhdl_syntax diff --combined ChangeLog index 3b5bab1,c9d846b..f111f15 --- a/ChangeLog +++ b/ChangeLog @@@ -1,26 -1,6 +1,24 @@@ -2009-01-30 Enrico Weigelt, metux IT service weig...@metux.de +2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de - * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax + * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() +(patch from andrew_b) + +2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru + + * edit/editcmd.c, mhl/escape.h, mhl/string.h, mhl/types.h, src/Makefile.am, + * src/boxes.c, src/command.c, src/complete.c, src/complete.h, src/file.c, + * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, + * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: +fixed shell escaping issues in commandline completion engine - - 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de - + * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 +(out-of-tree builds) ++ * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. @@@ -32,13 -12,8 +30,10 @@@ This solves strange rename cases, when copying/moving is performed into deleted directory. -2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-27 Enrico Weigelt, metux ITS weig...@metux.de + * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type +SHELL_ESCAPED_STR for more type safety - - 2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de - * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ 2009-01-27 Sergei Trofimovich sly...@inbox.ru @@@ -46,11 -21,6 +41,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -66,7 -36,7 +61,7 @@@ * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) name filling. Can be configured (on|off) in 'Configure options' --2009-01-25 Enrico Weigelt weig...@metux.de ++2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: @@@ -75,9 -45,9 +70,11 @@@ translated strings. This breaks now once every history file but afterwards this will be stable --2009-01-24 Enrico Weigelt weig...@metux.de ++2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) ++ * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules ++for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -85,11 -55,11 +82,6 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position --2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de -- -- * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules --for Nemerle source files -- 2009-01-19 Patrick Winnertz win...@debian.org * edit/edit.h: Add two more ints @@@ -104,7 -74,7 +96,7 @@@ * src/main.c: Removed unused function do_mc_filename_rename * src/util.c: Removed unused struct whentm --2009-01-16 Enrico Weigelt, metux IT service weig...@metux.de ++2009-01-16 Enrico Weigelt, metux ITS weig...@metux.de * src/subshell: setting subshell pty to close-on-exec (taken from mandriva patches) @@@ -142,9 -112,9 +134,6 @@@ * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: added syntax definition for Haskell (taken from rhclub-tree) * syntax: added ebuild Syntax defition (taken from rhclub-tree) -- --2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de
updated: [7015de5] Merge commit 'origin/236_replace_gboolean'
The following commit has been merged in the master branch: commit 7015de5db51b00fe6c5ea6c49556ffcb526aca13 Merge: fb745c77ff7636cfb2eedbac929679f06adbf28b 4fcf4e9685d9b2e4b49bfa3f7d3709dbe48073b6 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Mon Feb 2 21:16:39 2009 +0100 Merge commit 'origin/236_replace_gboolean' diff --combined ChangeLog index f111f15,9e53731..b78cdd6 --- a/ChangeLog +++ b/ChangeLog @@@ -3,6 -3,7 +3,7 @@@ * src/util.c: fixed name_trunc() on NULL or empty parameters * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -11,14 -12,15 +12,14 @@@ * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: fixed shell escaping issues in commandline completion engine - -2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de - * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. @@@ -34,6 -36,9 +35,6 @@@ * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type SHELL_ESCAPED_STR for more type safety - -2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de - * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ 2009-01-27 Sergei Trofimovich sly...@inbox.ru @@@ -61,7 -66,7 +62,7 @@@ * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) name filling. Can be configured (on|off) in 'Configure options' -2009-01-25 Enrico Weigelt weig...@metux.de +2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: @@@ -70,11 -75,9 +71,11 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -82,6 -85,11 +83,6 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position -2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de - - * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules -for Nemerle source files - 2009-01-19 Patrick Winnertz win...@debian.org * edit/edit.h: Add two more ints @@@ -96,7 -104,7 +97,7 @@@ * src/main.c: Removed unused function do_mc_filename_rename * src/util.c: Removed unused struct whentm -2009-01-16 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-16 Enrico Weigelt, metux ITS weig...@metux.de * src/subshell: setting subshell pty to close-on-exec (taken from mandriva patches) @@@ -134,6 -142,9 +135,6 @@@ * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: added syntax definition for Haskell (taken from rhclub-tree) * syntax: added ebuild Syntax defition (taken from rhclub-tree) - -2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de - * edit/editcmd.c: * src/achown.c src/background.c src/boxes.c src/chmod.c: * src/chown.c src/cmd.c src/command.c src/dir.c src/execute.c: diff --combined src/file.c index 5fb0bfd,2ed0465..ffc93dd --- a/src/file.c +++ b/src/file.c @@@ -50,6 -50,7 +50,7 @@@ #include sys/stat.h #include unistd.h + #include mhl/types.h #include mhl/memory.h #include mhl/escape.h #include mhl/string.h @@@ -1034,7 -1035,7 +1035,7 @@@ move_file_file (FileOpContext *ctx, con { struct stat src_stats, dst_stats; int return_status = FILE_CONT; - gboolean copy_done = FALSE; + bool copy_done = FALSE; if (file_progress_show_source (ctx, s) == FILE_ABORT || file_progress_show_target (ctx, d) == FILE_ABORT) @@@ -1701,10 -1702,10 +1702,10 @@@ panel_operate_generate_prompt (const WP if (single_source) { i = fmd_xlen - strlen (format_string) - 4; - g_snprintf (cmd_buf, sizeof (cmd_buf), format_string
updated: [9b9cab5] manually merged 234_remove_g_string
The following commit has been merged in the master branch: commit 9b9cab58749217101ab16504a77efb301812cfbf Merge: 8b38cf44daee3b0f92591baa97f36d722be99280 f235b1976ee6dd7aa2be7e75c870784c424e3de3 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Mon Feb 2 22:39:12 2009 +0100 manually merged 234_remove_g_string diff --combined ChangeLog index 174e3aa,abbe625..832520c --- a/ChangeLog +++ b/ChangeLog @@@ -1,33 -1,14 +1,34 @@@ -2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de +2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() +(patch from andrew_b) + * replaced gboolean by bool (from mhl/types.h) + +2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru + + * edit/editcmd.c, mhl/escape.h, mhl/string.h, mhl/types.h, src/Makefile.am, + * src/boxes.c, src/command.c, src/complete.c, src/complete.h, src/file.c, + * src/find.c, src/main.c, src/panelize.c, src/util.c, src/utilunix.c, + * src/widget.c, src/widget.h, src/wtools.c, vfs/fish.c: +fixed shell escaping issues in commandline completion engine * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + * replaced g_snprintf() by snprintf() + * replaced GString stuff by static buffers 2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 (out-of-tree builds) + * syntax/Syntax, syntax/Makefile.am, syntax/vhdl.syntax: added VHDL syntax (#193) + * replaced calls to g_strdup() by mhl_str_dup() + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced calls to g_free() by mhl_mem_free() 2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. odt2txt is now used @@@ -37,10 -18,8 +38,10 @@@ This solves strange rename cases, when copying/moving is performed into deleted directory. -2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-27 Enrico Weigelt, metux ITS weig...@metux.de + * mhl/escape.h, src/complete.c, vfs/fish.c: introduced new type +SHELL_ESCAPED_STR for more type safety * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ 2009-01-27 Sergei Trofimovich sly...@inbox.ru @@@ -68,7 -47,7 +69,7 @@@ * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) name filling. Can be configured (on|off) in 'Configure options' -2009-01-25 Enrico Weigelt weig...@metux.de +2009-01-25 Enrico Weigelt, metux ITS weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: * src/hotlist.c, src/panelize.c, src/tree.c, src/user.c: @@@ -77,11 -56,9 +78,11 @@@ translated strings. This breaks now once every history file but afterwards this will be stable -2009-01-24 Enrico Weigelt weig...@metux.de +2009-01-24 Enrico Weigelt, metux ITS weig...@metux.de * src/cmd.c: fixed bug #35 (do_view_cmd is now calling repaint_screen()) + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files 2009-01-24 Patrick Winnertz win...@debian.org @@@ -89,6 -66,11 +90,6 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position -2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de - - * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules -for Nemerle source files - 2009-01-19 Patrick Winnertz win...@debian.org * edit/edit.h: Add two more ints @@@ -103,7 -85,7 +104,7 @@@ * src/main.c: Removed unused function do_mc_filename_rename * src/util.c: Removed unused struct whentm -2009-01-16 Enrico Weigelt, metux IT service weig...@metux.de +2009-01-16 Enrico Weigelt, metux ITS weig...@metux.de * src/subshell: setting subshell pty to close-on-exec (taken from mandriva patches) @@@ -141,6 -123,9 +142,6 @@@ * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: added syntax definition for Haskell (taken from rhclub-tree) * syntax: added ebuild Syntax defition (taken from rhclub-tree) - -2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de - * edit/editcmd.c: * src/achown.c src/background.c src/boxes.c src/chmod.c: * src/chown.c src/cmd.c src/command.c src/dir.c src/execute.c: diff --combined edit/edit.c index 82cca0d,1f8d851..36284df --- a/edit/edit.c +++ b/edit/edit.c @@@ -22,7 -22,6 +22,7 @@@ */ #include config.h + #include stdio.h #include stdarg.h #include
updated: [c76c6e5] Merge commit 'origin/230_fix_name_trunc' into mc-4.6
The following commit has been merged in the mc-4.6 branch: commit c76c6e5ffc6cbb8d62050f836debeccaeec32936 Merge: 80a68972718b68c5c5ae050999b187f1676c653b 6b6d4a222d145cbf1a14e968b753af1c5406e980 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Sun Feb 1 22:05:17 2009 +0100 Merge commit 'origin/230_fix_name_trunc' into mc-4.6 -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [74c5601] Merge commit 'origin/mc-4.6'
The following commit has been merged in the master branch: commit 74c5601339ac49b1ca6647ffc867c384b1355a14 Merge: 9fd798845ddd37c693a3f20f037711f4a75f24bc c76c6e5ffc6cbb8d62050f836debeccaeec32936 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Sun Feb 1 22:07:03 2009 +0100 Merge commit 'origin/mc-4.6' diff --combined ChangeLog index a63a22d,2d23d15..c6733e2 --- a/ChangeLog +++ b/ChangeLog @@@ -1,3 -1,8 +1,8 @@@ + 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + + * src/util.c: fixed name_trunc() on NULL or empty parameters + (patch from andrew_b) + 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru * edit/editcmd.c, mhl/escape.h, mhl/string.h, mhl/types.h, src/Makefile.am, @@@ -39,11 -44,6 +44,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -55,10 -55,6 +60,10 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + 2009-01-25 Enrico Weigelt weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: @@@ -78,19 -74,10 +83,19 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group @@@ -128,29 -115,7 +133,29 @@@ 2009-01-11 Patrick Winnertz win...@debian.org * syntax/pascal.syntax: Added syntax highlighting for - some delphi keywords +some delphi keywords + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: + added syntax definition for Haskell (taken from rhclub-tree) + * syntax: added ebuild Syntax defition (taken from rhclub-tree) + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * edit/editcmd.c: + * src/achown.c src/background.c src/boxes.c src/chmod.c: + * src/chown.c src/cmd.c src/command.c src/dir.c src/execute.c: + * src/ext.c src/file.c src/filegui.c src/find.c src/help.c: + * src/learn.c src/main.c src/panelize.c src/screen.c: + * src/selcodepage.c src/subshell.c src/tree.c src/user.c: + * src/utilunix.c src/view.c: + * vfs/cpio.c vfs/direntry.c vfs/extfs.c vfs/fish.c vfs/ftpfs.c: + * vfs/mcfs.c vfs/sfs.c vfs/smbfs.c vfs/tar.c vfs/undelfs.c: + * vfs/utilvfs.c vfs/vfs.c: + + Changed message type codes on calls to message(), query_dialog(), + close_error_pipe() from numeric IDs to symbols D_ERROR, D_NORMAL 2008-12-18 Roland Illig roland.il...@gmx.de @@@ -328,7 -293,7 +333,7 @@@ * doc/mc.1.in: Document `fish_directory_timeout'. -2006-02-18 David Martin dmart...@excite.com +2006-02-18 David Martin dmart...@excite.com * doc/es/mc.1.in: Cleanup. Fix key naming. diff --combined vfs/smbfs.c index bb82bc2,e027da8..b15952c --- a/vfs/smbfs.c +++ b/vfs/smbfs.c @@@ -49,6 -49,8 +49,8 @@@ #include string.h + #include mhl/string.h + #include vfs.h #include vfs-impl.h #include smbfs.h @@@ -366,7 -368,7 +368,7 @@@ smbfs_fill_names (struct vfs_class *me #define GNAL_VNC(s) unix_to_dos(s,False) /* does same as do_get() in client.c */ /* called from vfs.c:1080, count = buffer size */ -static int +static ssize_t smbfs_read (void *data, char *buffer, int count) { smbfs_handle *info = (smbfs_handle *) data; @@@ -380,7 -382,7 +382,7 @@@ return n; } -static int +static ssize_t smbfs_write (void *data, const char *buf, int nbyte
updated: [48a85a7] manually merged 232_fix_init_chown_advanced
The following commit has been merged in the mc-4.6 branch: commit 48a85a7b97ea88f7687126471c2a724e3e444619 Merge: c76c6e5ffc6cbb8d62050f836debeccaeec32936 6f9ef0b7befb9b5943fcbc0a91a2e00fa0f57cb2 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Sun Feb 1 22:37:57 2009 +0100 manually merged 232_fix_init_chown_advanced diff --combined ChangeLog index 2d23d15,5c0e973..ed3c7f6 --- a/ChangeLog +++ b/ChangeLog @@@ -1,6 -1,6 +1,7 @@@ 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de + * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [3410eb3] Merge commit 'origin/mc-4.6'
The following commit has been merged in the master branch: commit 3410eb32290abe51e6845483ed7a3723823a768a Merge: 74c5601339ac49b1ca6647ffc867c384b1355a14 48a85a7b97ea88f7687126471c2a724e3e444619 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Sun Feb 1 22:38:48 2009 +0100 Merge commit 'origin/mc-4.6' diff --combined ChangeLog index c6733e2,ed3c7f6..2c39360 --- a/ChangeLog +++ b/ChangeLog @@@ -1,6 -1,7 +1,7 @@@ 2009-02-01 Enrico Weigelt, metux ITS weig...@metux.de * src/util.c: fixed name_trunc() on NULL or empty parameters + * src/achown.c: fixed unitialized var in init_chown_advanced() (patch from andrew_b) 2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de, Patrick Winnertz win...@debian.org, Slava Zanko slavaza...@gmail.com, Sergei Trofimovich sly...@inbox.ru @@@ -44,11 -45,6 +45,11 @@@ * syntax/python.syntax: Added syntax highlighting for pytnoh-2.6+ keywords (patch sent by NNemec) +2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in +0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -60,10 -56,6 +61,10 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + 2009-01-25 Enrico Weigelt weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: @@@ -83,19 -75,10 +84,19 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group @@@ -133,29 -116,7 +134,29 @@@ 2009-01-11 Patrick Winnertz win...@debian.org * syntax/pascal.syntax: Added syntax highlighting for - some delphi keywords +some delphi keywords + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: + added syntax definition for Haskell (taken from rhclub-tree) + * syntax: added ebuild Syntax defition (taken from rhclub-tree) + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * edit/editcmd.c: + * src/achown.c src/background.c src/boxes.c src/chmod.c: + * src/chown.c src/cmd.c src/command.c src/dir.c src/execute.c: + * src/ext.c src/file.c src/filegui.c src/find.c src/help.c: + * src/learn.c src/main.c src/panelize.c src/screen.c: + * src/selcodepage.c src/subshell.c src/tree.c src/user.c: + * src/utilunix.c src/view.c: + * vfs/cpio.c vfs/direntry.c vfs/extfs.c vfs/fish.c vfs/ftpfs.c: + * vfs/mcfs.c vfs/sfs.c vfs/smbfs.c vfs/tar.c vfs/undelfs.c: + * vfs/utilvfs.c vfs/vfs.c: + + Changed message type codes on calls to message(), query_dialog(), + close_error_pipe() from numeric IDs to symbols D_ERROR, D_NORMAL 2008-12-18 Roland Illig roland.il...@gmx.de @@@ -333,7 -294,7 +334,7 @@@ * doc/mc.1.in: Document `fish_directory_timeout'. -2006-02-18 David Martin dmart...@excite.com +2006-02-18 David Martin dmart...@excite.com * doc/es/mc.1.in: Cleanup. Fix key naming. diff --combined src/achown.c index 8f436fb,6277110..de2ae07 --- a/src/achown.c +++ b/src/achown.c @@@ -539,9 -539,9 +539,9 @@@ init_chown_advanced (void int i; enum { dlg_h = 13, dlg_w = 74, n_elem = 4 }; #ifdef ENABLE_NLS - static int i18n_len; - - if (!i18n_len) { + static int i18n_len = 0; + + if (i18n_len == 0) { int dx, cx; for (i = 0 ; i n_elem ; i++) { chown_advanced_but[i].text = _(chown_advanced_but[i].text); @@@ -627,12 -627,12 +627,12 @@@ static void apply_advanced_chowns (stru fname = current_panel-dir.list[current_file].fname; need_update = end_chown = 1; if (mc_chmod (fname, get_mode ()) == -1) - message (1, MSG_ERROR, _( Cannot
updated: [a1b4718] manually merged 118_port_number_in_shell_link
The following commit has been merged in the master branch: commit a1b47185c952e9d31607d59420a0cb86e9f492ab Merge: 5f77615b35a09d8cb1941b0d37f5cf24d4b7dbc5 a73bd631e57d6f9ee89f3a3fc1870fa879b01fb0 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Sat Jan 31 19:29:15 2009 +0100 manually merged 118_port_number_in_shell_link diff --combined ChangeLog index 3d714e5,727c875..cc5b4da --- a/ChangeLog +++ b/ChangeLog @@@ -1,31 -1,9 +1,36 @@@ +2009-01-31 Enrico Weigelt, metux ITS weig...@metux.de + + * replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file() (in mhl/string.h) + +2009-01-30 Enrico Weigelt, metux ITS weig...@metux.de + + * src/Makefile.am, edit/Makefile.am vfs/Makefile.am: fixed #208 +(out-of-tree builds) + +2009-01-29 Mikhail S. Pobolovets styx...@gmail.com + * lib/mc.ext.in: update for OpenOffice and StarOffice viewer. +odt2txt is now used + +2009-01-29 Patrick Winnertz win...@debian.org Sergei Trofimovich sly...@inbox.ru + + * src/file.c: Added trailing dir separator for default path in copy/move dialogs. +This solves strange rename cases, when copying/moving is performed into +deleted directory. + +2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de + + * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ + +2009-01-27 Sergei Trofimovich sly...@inbox.ru + + * syntax/python.syntax: Added syntax highlighting for + pytnoh-2.6+ keywords (patch sent by NNemec) + 2009-01-26 Mikhail S. Pobolovets styx...@gmail.com + + * vfs/fish.c: Iterpret SUP.flags as port number if SUP.flags is not in + 0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -37,10 -15,6 +42,10 @@@ * mhl/string.h, vfs/fish.c, vfs/utilvfs.c, vfs/utilvfs.h: Reworked fish code so that symlinks and files which special characters works now +2009-01-25 Mikhail S. Pobolovets styx...@gmail.com + * src/cmd.c src/option.c src/setup.c src/main.h: Automatic new directory(Mkdir, F7) +name filling. Can be configured (on|off) in 'Configure options' + 2009-01-25 Enrico Weigelt weig...@metux.de * edit/editcmd.c, src/cmd.c, src/ext.c, src/history.h: -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: updated: [89d3cbd] Removed unneeded var to make build process a bit cleaner
* Patrick Winnertz win...@debian.org schrieb: #include ctype.h #include stdarg.h -#include mhl/memory.h +#include ../mhl/memory.h Why did you change this ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [2f6f6af] fixed comments to /* ... */
The following commit has been merged in the mc-4.6 branch: commit 2f6f6af4259f261f58c4e6dfd2c4ebd0a6e1a803 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Tue Jan 27 22:04:12 2009 +0100 fixed comments to /* ... */ diff --git a/ChangeLog b/ChangeLog index 016036d..92ad454 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de + + * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: diff --git a/mhl/escape.h b/mhl/escape.h index 2533388..8366833 100644 --- a/mhl/escape.h +++ b/mhl/escape.h @@ -54,12 +54,12 @@ static inline char* mhl_shell_unescape_buf(char* text) if (!text) return NULL; -// look for the first \ - that's quick skipover if there's nothing to escape +/* look for the first \ - that's quick skipover if there's nothing to escape */ char* readptr = text; while ((*readptr) ((*readptr)!='\\')) readptr++; if (!(*readptr)) return text; -// if we're here, we're standing on the first '\' +/* if we're here, we're standing on the first '\' */ char* writeptr = readptr; char c; while ((c = *readptr)) @@ -97,7 +97,7 @@ static inline char* mhl_shell_unescape_buf(char* text) (*writeptr) = c; writeptr++; break; } } - else// got a normal character + else/* got a normal character */ { (*writeptr) = *readptr; writeptr++; diff --git a/mhl/string.h b/mhl/string.h index e3c7d2f..c50228d 100644 --- a/mhl/string.h +++ b/mhl/string.h @@ -16,30 +16,29 @@ static inline char * mhl_str_dup_range(const char * s_start, const char * s_boun static inline char* mhl_str_trim(char* str) { -if (!str) return NULL; // NULL string ?! bail out. +if (!str) return NULL; /* NULL string ?! bail out. */ -// find the first non-space +/* find the first non-space */ char* start; for (start=str; ((*str) (!isspace(*str))); str++); -// only spaces ? +/* only spaces ? */ if (!(*str)) { *str = 0; return str; } -// get the size (cannot be empty - catched above) +/* get the size (cannot be empty - catched above) */ size_t _sz = strlen(str); -// find the proper end +/* find the proper end */ char* end; for (end=(str+_sz-1); ((endstr) (isspace(*end))); end--); -end[1] = 0;// terminate, just to be sure +end[1] = 0;/* terminate, just to be sure */ -// if we have no leading spaces, just trucate +/* if we have no leading spaces, just trucate */ if (start==str) { end++; *end = 0; return str; } - -// if it' only one char, dont need memmove for that +/* if it' only one char, dont need memmove for that */ if (start==end) { str[0]=*start; str[1]=0; return str; } -// by here we have a (non-empty) region between start end end +/* by here we have a (non-empty) region between start end end */ memmove(str,start,(end-start+1)); return str; } @@ -70,10 +69,9 @@ static inline char* __mhl_str_concat_hlp(const char* base, ...) va_list args; va_start(args,base); char* a; -// note: we use ((char*)(1)) as terminator - NULL is a valid argument ! +/* note: we use ((char*)(1)) as terminator - NULL is a valid argument ! */ while ((a = va_arg(args, char*))!=(char*)1) { -// printf(a=%u\n, a); if (a) { arg_ptr[count] = a; @@ -86,7 +84,7 @@ static inline char* __mhl_str_concat_hlp(const char* base, ...) if (!count) return mhl_str_dup(); -// now as we know how much to copy, allocate the buffer +/* now as we know how much to copy, allocate the buffer */ char* buffer = (char*)mhl_mem_alloc_u(totalsize+2); char* current = buffer; int x=0; @@ -104,8 +102,8 @@ static inline char* __mhl_str_concat_hlp(const char* base, ...) static inline char* mhl_str_reverse(char* ptr) { -if (!ptr) return NULL;// missing string -if (!(ptr[0] ptr[1])) return ptr; // empty or 1-ch string +if (!ptr) return NULL;/* missing string */ +if (!(ptr[0] ptr[1])) return ptr; /* empty or 1-ch string */ size_t _sz = strlen(ptr); char* start = ptr; -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
updated: [e34e748] Merge commit 'origin/mc-4.6'
The following commit has been merged in the master branch: commit e34e748666c0ad817013a5e8044cd1cba11f8e48 Merge: 753a663d2ddd3b91d7f7c235513dabe8016445bd 2f6f6af4259f261f58c4e6dfd2c4ebd0a6e1a803 Author: Enrico Weigelt, metux IT service weig...@metux.de Date: Tue Jan 27 22:53:12 2009 +0100 Merge commit 'origin/mc-4.6' diff --combined ChangeLog index d66c419,92ad454..9055511 --- a/ChangeLog +++ b/ChangeLog @@@ -1,3 -1,7 +1,7 @@@ + 2009-01-27 Enrico Weigelt, metux IT service weig...@metux.de + + * mhl/escape.h, mhl/string.h: fixed comments to use /* ... */ + 2009-01-25 Ilia Maslakov il.sm...@gmail.com * src/boxes.c, src/boxes.h, src/dir.c, src/dir.h: @@@ -28,19 -32,10 +32,19 @@@ - prevent . to match a newline (\n) - match from start of line and not from cursor position +2009-01-24 Enrico Weigelt, metux IT service weig...@metux.de + + * syntax/Syntax, syntax/nemerle.syntax: Added syntax rules +for Nemerle source files + +2009-01-19 Patrick Winnertz win...@debian.org + + * edit/edit.h: Add two more ints + * src/setup.c: Add keybinding to disable tab highlighting + 2009-01-18 Patrick Winnertz win...@debian.org - * edit/editdraw.c: Moved var into if clause as it's only used - there + * edit/editdraw.c: Moved var into if clause as it's only used there * edit/editlock.c: Removed unnecessary arguement to if condition * src/cmd.c: Removed unused pointer * src/hotlist.c: Removed unused function save_group @@@ -78,29 -73,7 +82,29 @@@ 2009-01-11 Patrick Winnertz win...@debian.org * syntax/pascal.syntax: Added syntax highlighting for - some delphi keywords +some delphi keywords + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * syntax/Makefile.am syntax/Syntax syntax/haskell.syntax: + added syntax definition for Haskell (taken from rhclub-tree) + * syntax: added ebuild Syntax defition (taken from rhclub-tree) + +2009-01-10 Enrico Weigelt, metux ITS weig...@metux.de + + * edit/editcmd.c: + * src/achown.c src/background.c src/boxes.c src/chmod.c: + * src/chown.c src/cmd.c src/command.c src/dir.c src/execute.c: + * src/ext.c src/file.c src/filegui.c src/find.c src/help.c: + * src/learn.c src/main.c src/panelize.c src/screen.c: + * src/selcodepage.c src/subshell.c src/tree.c src/user.c: + * src/utilunix.c src/view.c: + * vfs/cpio.c vfs/direntry.c vfs/extfs.c vfs/fish.c vfs/ftpfs.c: + * vfs/mcfs.c vfs/sfs.c vfs/smbfs.c vfs/tar.c vfs/undelfs.c: + * vfs/utilvfs.c vfs/vfs.c: + + Changed message type codes on calls to message(), query_dialog(), + close_error_pipe() from numeric IDs to symbols D_ERROR, D_NORMAL 2008-12-18 Roland Illig roland.il...@gmx.de @@@ -278,7 -251,7 +282,7 @@@ * doc/mc.1.in: Document `fish_directory_timeout'. -2006-02-18 David Martin dmart...@excite.com +2006-02-18 David Martin dmart...@excite.com * doc/es/mc.1.in: Cleanup. Fix key naming. -- Midnight Commander Development ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Server trouble: ssh down
Hi, the ssh access to the hq server is down: ssh_exchange_identification: Connection closed by remote host fatal: The remote end hung up unexpectedly Could be a filesystem problem (tmp or log dir full or ro). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: automatic symlink maintenance
* Janek Kozicki janek_li...@wp.pl schrieb: I checked 9P. It's a nice stuff, but in reality I don't see it in near future on my stock debian testing desktop. It will, as soon as mc's 9p support has gone into release ;-P (see HACK_mvfs branch) It's just a simple symlink tracking it can't be *that* difficult... Feel free to submit patches ;-P cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[win...@debian.org: Re: [Midnight Commander] #157: [PATCH] Micro helper library]
Forwarding to the list, as this mail obviously belongs here ;-o - Forwarded message from Patrick Winnertz win...@debian.org - From: Patrick Winnertz win...@debian.org Subject: Re: [Midnight Commander] #157: [PATCH] Micro helper library To: Enrico Weigelt weig...@metux.de Date: Sat, 10 Jan 2009 20:22:24 +0100 Hey, Currently we set the Milestone for this ticket to 4.7 as this is a restructurment but I would like to request to move from 4.7 to 4.6.2 because some of the functions will help to fix some nasty bugs. When adding this patch to 4.6.X we should have a eye on that we doesn't change anything else on the code execpt for bugfixing (e.g. moving from g_malloc to something else). So: Should we move this to 4.6.2 in order to fix some bugs (e.g: whitespaces in files via fish, comandline completion, ...)? Greetings Winnie ps: Please all review this patch... -- . '' `. Patrick Winnertz win...@debian.org : :' : proud Debian developer, author, administrator, and user `. `'`http://people.debian.org/~winnie - http://www.der-winnie.de `- Debian - when you have better things to do than fixing systems - End forwarded message - -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #155: savannah: Remove of WANT_WIDGETS
* MC Ticket System tick...@midnight-commander.org schrieb: It's not my patch, I'm only little rework it for resolve one conflict... But as fact, I'm patch-attacher... and I don't know, valid my vote, or no... Do you vote for my patch (moving out to separate .h file) ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #145: update m4/* files
* MC Ticket System tick...@midnight-commander.org schrieb: actually, it is generally considered bad practice to have generated files under version control at all. anything created by the bootstrap process (autogen.sh) should be purged from the tree. ACK, but that fact might change by the 135_drop_bundled_libintl branch. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #157: [PATCH] Micro helper library
* MC Ticket System tick...@midnight-commander.org schrieb: IMHO, 'mhl' name is not intuitively :) you have a better idea ? ;-p -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
* MC Ticket System tick...@midnight-commander.org schrieb: Patch don't applyed to branch - I think that the rules of good manners: branch must change by developer, who created the branch. The rest (all those involved in the ticket, not just developers) is temporarily becoming subordinates, developer (branch-starter) is temporarily becoming team leader. If this idea good - need to update workflow ;) Yes, each branch needs an owner, normally the one who created it or started working on its issue. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
* MC Ticket System tick...@midnight-commander.org schrieb: Comment(by slavazanko): In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next snip As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS Confirmed on Gentoo. But autoconf spits out a fat warning that these macros are obsolete, so we should get rid of 'em. I'd like to hear your votes ;-p cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #134: [PATCH] some time formatting fixes
* MC Ticket System tick...@midnight-commander.org schrieb: Comment: Enrico, where branch? :) Milestone changed to 4.7 because this patch is an enhancement, not bug fixing... IMHO. No, the issue started with some fix for a bug which makes mc segfault when it sees invalid mtime's - I've just refined it. So, it should go into next release, IMHO. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Glib or no glib - we need a decision
* Patrick Winnertz win...@debian.org schrieb: contra: - glib is huge and we only use a very small amount of functions. Rewriting this functions would make mc smaller and faster. This is important at least for embedded devices. Note that there's many many places where the glib functions aren't needed at all. a) wrappers for (often inline'd) libc functions (g_strcasecmp(), etc) This actually costs resources, *at least* an extra far call up to loosing the chance of inline'ing. It's IMHO stupid to use glib here just to use it. b) unncessary string duplications c) often an static buffer on stack is cheaper d) g_strconcat(): unnecessarily expensive and unrobust (just forget the last NULL parameter and go straight to hell) - I've replaced it by several faster inlines in my branch e) many things can be expressed more clear, cheaper and more robust through a few little macros. f) some glib functions are simply broken and must be circumvented at all (eg. shell-escaping ...) So my vote is to at least get rid of the unncessary glib calls, then let's see what remains and wether it's worth to keep it just for that few things BTW: glib is far from being robust over several versions. Just look at the 1.*/2.* issue: they actually call the 2.* successor versions of 1.*, but they're totally different things that just happen to share the name and some ideas behind. And even within the 2.* line there've been major interface breaks. Keep that in mind! cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Glib or no glib - we need a decision
* Slava Zanko slavaza...@gmail.com schrieb: Hi, What I mean: need to create some wrapper... like my first step to this in http://www.midnight-commander.org/ticket/125 Inspired by your idea, I've started writing some minimalistic helper library (./mhl/* - micro helper library) which actually just provides a bunch of macros and inlines. Meanwhile I've moved the whole memory management, string handling and even hashtable handling (using libhash) there. For now, wrapper may have #define'd via pseudo-functions... but in future (if someone from 'contra' want) will realize own library (call it as you want: mcglib, mccore, mclib.so,...), and will add in ./configure.ac option '--without-glib' Yes, that would be easy. But as I already wrote own (glib-free) implementations for that stuff, I doubt why we should glib at all ;-o cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [MPORTANT]: Created new default query for tickets
* Patrick Winnertz win...@debian.org schrieb: snip is it possible to set up an query which shows patches to review, which wasn't already voted by $self and also isnt tagged for rework ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: glib or not glib? (was: Re: [Midnight Commander] #150: [PATCH] More FHS-compliant install directories)
* Andrew Borodin aboro...@vmail.ru schrieb: Hi, First tiny step to get rid if glib. It's very strange. Do you think than mc must be free of glib? Yes, because glib is a fat blob we don't really need (the few things we currently use can be easily done w/ a bunch of macros or inline's). Isn't it rather absurd to maintain an stripped-down branch of slang for embedded systems, but at the same time import glib ? ;-O cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [r...@rover.dkm.cz: [repo.or.cz] midnight-commander clone completed]
* Pavel Roskin pro...@gnu.org schrieb: Hi, Thousands of OSS projects get mirrored all around the world, even without explicit knowledge of the devs, and - as far as I know - nobody feels pissed about that. What's the problem ? I don't want to be responsible for an obsolete repository. Which one is obsolete now ? And why are you resposible ? I believe it's important that the project developers act as a team and coordinate their actions. What is there to coordinate on just some dumb unofficial mirror ? Its name and who is responsible for mirroring. What kind of responsibility do you have in mind ? It's nothing more than like someone sets up an daily wget -R on some ftp server and tells the world where to reach this mirror. Wait, you really feel kicked-away, just because your mirror isn't the only one anyomore ? Quite strange, IMHO. There is no need for two mirrors on one site. Probably not. But does it hurt ? BTW: I didn't know that there's already another mirror. While reading the git docs I just came around that mirroring service and tried it out. Nothing more. If you don't have any use for the new mirror, just ignore it. Probably it will timeout after a while if nobody uses it. The only problem with the existing mirror was that you didn't control it. No, not for me - I don't have the slightest intent do control it. Actually, there is nothing to control - the mirrors are done 100% automatically. Right, and you did a great job. You volunteered to do an dirty, but important job, nobody else was willing to do. And I don't think anyone here won't appreciate that. So you *are* a valueable member of the team, and I don't see how some additional, uninteresting git mirror can change that fact. Thanks. I'm unsubscribing from the lists now and I'm not going to continue this discussion. Please don't, just because of that dumb mirror. It has nothing to do with your contributions. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [MPORTANT]: Created new default query for tickets
* Patrick Winnertz win...@debian.org schrieb: Hi, If someone has found a patch for a issue reported in a ticket and add this patch to this specific ticket, he can add a review keyword to the keywords list. If this keyword exists there this ticket will show up under this url: great ! Perhaps we could extend it a bit: * add votes via keywords (eg. vote-username) * if there are enough votes (currently: 2 devs), add the keyword approved. * patches that need rework get the rework keyword instead of review Could you please set up some more quries for this ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Trac - remove crap tickets
* Patrick Winnertz win...@debian.org schrieb: Am Sonntag 04 Januar 2009 09:44:43 schrieb Enrico Weigelt: Hi folks, is it possible to remove certain crap tickets (I mean those which are *really* crap, like testings, accidential double-posts, etc) ? Yes.. deleting via shell should be possible for me :) Which ticket should be removed? All those which are marked with ***TRASH***. You could hack up a little script for that which runs peridically. So removing a ticket is triggered just by renaming it to ***TRASH***. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: RFC: updated workflow [WAS: Re: git+patch workflow]
* Oswald Buddenhagen o...@kde.org schrieb: Hi, delete *the* stable branch, but not the concept of stable branches per se. doing so would mean that once you merged a feature patch to master, you cannot do a bugfix release any more until you make a feature release (*). to keep the option of bugfix releases open Actually, I dislike that idea. Instead we should declare, that 'master' branch is *always* what becomes the next release. We just have to take care that it's always in a state that it could be released ASAP - so: *no* development there. New features only get committed if they're really ready to get into next release (which in theory could come any second). Of course we should do stable tree releases quite frequently, *NOT* collecting too much which might introduce new bugs. We've already waited too long w/ 4.6.2. (and distributors really want that), Well, if distros want a bugfixed branch of older releases and don't want to take care all by themselves, they could simply join the OSS-QM project, which is meant as an bug-fixing overlay over existing *releases* (it's about QM exclusively, *NO* development). But according the lack of interest in all these years, the presure obviously can't be that hight ;-o cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Trac - remove crap tickets
Hi folks, is it possible to remove certain crap tickets (I mean those which are *really* crap, like testings, accidential double-posts, etc) ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [r...@rover.dkm.cz: [repo.or.cz] midnight-commander clone completed]
* Pavel Roskin pro...@gnu.org schrieb: Hi, I really don't see the problem. The problem is that the mirror already existed on that site. Now we have two mirrors. It's confusing to the users. Some may be tracking my mirror now. Instead of giving you control over the existing mirror, I'll need to ask the site administration to remove my mirror. The users will have to switch to your repository. Why do you have to close your mirror ? I dont see any reason. Thousands of OSS projects get mirrored all around the world, even without explicit knowledge of the devs, and - as far as I know - nobody feels pissed about that. What's the problem ? I believe it's important that the project developers act as a team and coordinate their actions. What is there to coordinate on just some dumb unofficial mirror ? I realize I'm not a team member anymore, but I've been maintaining the mirror for along time. Wait, you really feel kicked-away, just because your mirror isn't the only one anyomore ? Quite strange, IMHO. I spent quite a lot of time mapping CVS authors to the real names, and that mapping is used in your repository. Right, and you did a great job. You volunteered to do an dirty, but important job, nobody else was willing to do. And I don't think anyone here won't appreciate that. So you *are* a valueable member of the team, and I don't see how some additional, uninteresting git mirror can change that fact. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Reporting Bugs via mail works now (with drawbacks)
* Patrick Winnertz win...@debian.org schrieb: Yes.. according to the ticket system for trac itself this is an error of trac 0.11 ... some issue with the sql backend. Just a guess: sqlite locking issue ? The issues with the load of the server should be fixed...I hope that I'll get this issue also fixed. great :) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Reporting Bugs via mail works now (with drawbacks)
Hi, It's possible to add tickets, add comments to existing tickets and the emails will get carbon-copied back to the mc-devel list. opening a ticket seems to work now, but I didn't get any mail back yet. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: HAVE_MMAP still necessary ?
* MP singular...@gmail.com schrieb: We could have some get that file into memory call, that will try to use mmap if possible and store pointer to freeing the block (that would call munmap, free or some other method depending on how the block was acquired) Exactly :) The actual fs (and only it) should be responsible for getting the block into memory and later freeing it again - the clients even don't have to know that something like mmap exists at all. Such an interface could be very useful for everyone who just needs some file area in memory and doesnt want to care about sequential reading. Let's first try it out libmvfs, once it works fine, we can add it to mcvfs ... But we need to cope with situations, where the file won't fit in RAM and won't fit in virtual memory either. For example 8gb file on i386 architecture with 2 gb of ram. The vfs call will simply return an appropriate error if there's not enough memory available (whether virtual or physical is out the client's scope). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: automatic symlink maintenance [WAS: Removing myself from the project]
* Janek Kozicki janek_li...@wp.pl schrieb: IMHO, such a feature clearly doesn't belong into mc itself - it's a filesystem issue ;-P You are right! Thanks, it never occurred to me. I'm going to ask ext3 developers about that. Filesystem doesnt necessarily mean disk-filesystem. It's a job for some overlaying FS. (9P is your friend ;-P) cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Reporting Bugs via mail works now (with drawbacks)
* Enrico Weigelt weig...@metux.de schrieb: Hi, It's possible to add tickets, add comments to existing tickets and the emails will get carbon-copied back to the mc-devel list. opening a ticket seems to work now, but I didn't get any mail back yet. Okay, answers also come back now. But the server still tends to be overloaded. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bundled intl stuff necessary
* Roland Illig roland.il...@gmx.de schrieb: Enrico Weigelt schrieb: Hi folks, is it necessary to have the intl lib bundled into mc or could it be taken directly from the system ? (I admit, I don't know much about how it really works ;-o) I don't think it is necessary. There are many other projects who have dropped the internal intl/ directory. Okay, I'm trying to hack up something. This will also be my first reallife learning experience w/ git ;-) Please give me some hint how to send back my changes for review (directly via git). cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bundled intl stuff necessary
* Slava Zanko slavaza...@gmail.com schrieb: Hi, lib - in my mind must be sources of library(es) of project. What we see in directory lib? ACK. Currently, it contains lots of stuff which clearly don't belong there, but instead something like man/doc/shared-data/whatever. My purpose (in far-near future): doc man (current ${src_root}/doc) contributor (contributor manuals) developer (developers manual) What exactly is the difference between developer and contributor ? user (all README-files, readme about hotkeys, all other user-related) contrib contrib/extfs (current ${src_root}/vfs/extfs) Why do extfs scripts belong into contrib ? BTW: they should be installed into ${libexecdir}/mc, not ${datarootdir}/mc. Same w/ the stuff in ${datarootdir}/mc/bin. The global menu configs belong into ${sysconfdir}/mc. Hintfiles are locale stuff, so belong somewhere below ${datarootdir}/locale/ .. contrib/lib (current ${src_root}/lib, except mc.hint.* and README.xterm) And the lib/ChangeLog should be merged with the one in the toplevel dir. contrib/syntax (current ${src_root}/syntax) Why are the syntaxfiles contrib stuff ? lib/slang Why should we carry an own branch of slang at all ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Reporting Bugs via mail works now (with drawbacks)
* Slava Zanko slavaza...@gmail.com schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Enrico Weigelt wrote: Okay, answers also come back now. But the server still tends to be overloaded. Yes, 'database is locking'... :( ACK. Got the same error all the time. Any idea what's up w/ the server ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bundled intl stuff necessary
* Andrew Borodin aboro...@vmail.ru schrieb: On Sat, 3 Jan 2009 17:34:19 +0100 Enrico Weigelt wrote: Why do extfs scripts belong into contrib ? BTW: they should be installed into ${libexecdir}/mc, not ${datarootdir}/mc. Same w/ the stuff in ${datarootdir}/mc/bin. Why? ${datarootdir}/mc contains arch-independent files and mc-specific files. It's correct place in terms of FHS. Are you *absolutely* sure they're always arch-independent and ever will be ? Hintfiles are locale stuff, so belong somewhere below ${datarootdir}/locale/. Hintfiles are private data of mc. ${datarootdir}/mc is correct place for it. Yeah, same way private as .mo files, and they also serve almost the purpose: language specific messages. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bundled intl stuff necessary
* Slava Zanko slavaza...@gmail.com schrieb: Contributor... gm... may be I'm mistaken with word... 'maintainer' more like. - - How make packages in rpm, deb, tgz(Slackware) and other package-oriented distros - - How compile on *BSD/MaCOS, Cygwin/MinGW - - How compile on embedded systems - - ... other maintainer-related stuff hmm, isn't that just normal doc stuff ? ;-o (perhaps under the packager/ subdir) Why do extfs scripts belong into contrib ? contrib/syntax (current ${src_root}/syntax) Why are the syntaxfiles contrib stuff ? this not a part of mc executable and must be in conrtib area, IMHO They're needed by mcedit at runtime, same as shared libs, configs, etc. IMHO, contrib means: from external sources and not officially maintained by the upstream. I don't see that we really have this situation yet (besides distro-specific buildfiles, etc). BTW: they should be installed into ${libexecdir}/mc, not ${datarootdir}/mc. Same w/ the stuff in ${datarootdir}/mc/bin. The global menu configs belong into ${sysconfdir}/mc. Hintfiles are locale stuff, so belong somewhere below ${datarootdir}/locale/ .. This already applyed in Fedora-10 patch. Later I will publish this patch in trac. Ok. lib/slang Why should we carry an own branch of slang at all ? For embedded systems with less of memory, IMHO... Already suspected something like that. IMHO an stupid idea: Embedded maintainers should use an trimmed-down slang or do static linking, etc. BTW: the change of unnecessarily bloating up the system w/ bundled slang is quite good - just takes one more slang-using app and all benefit's gone. My vote is to completely dropping the bundled slang and let the embedded folks do the trim-down on their own. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Further Midnight Commander development
* Slava Zanko slavaza...@gmail.com schrieb: Hi, you meant: mcvfs = model ? No. model = any data source. mcvfs - one of sources for mc. Which other datasources do you have in mind ? yeah, even sockets: cat tcp://somehost:port/ (I'll add this to libmvfs in the next days ...) Cool. I'm waiting now this patch. :) Hmm, will take some time ... you can check out the open libmvfs branches (svn://anonymous:anonym...@nibiru.metux.de/public/libmvfs/) to see what's coming. Primary libmvfs-mcvfs bridging is already done in mc-9p branch (svn://nibiru.metux.de/public/mc-9p/), all it takes now is adding a new vfs_class structure per libmvfs-supported fs :) (perhaps we could invent some more automatic mapping someday ?) certain certain DE's ? Well, perhaps it would be even better to just directly support well-known DE's shortcut files ? But if file will open by DE, mc don't handle data from 'shorcut'. No, I meant, mc shall be able to understand certain DE's shortcut files and do the right things. For example, if the shortcut points to some ftp:// url, it just cd's to this url and let's ftpfs do the dirty work. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
git+patch workflow [WAS: bundled intl stuff necessary]
* Slava Zanko slavaza...@gmail.com wrote: (bouncing back to the list ;-p) Hi, I not fully understand... How automate process of patch submission, in your mind? Okay, let's take an example: I'm currently working on some sub-project. Now I've did my work, everything seems okay for me and I'd like to publish it. All I now (ideally) would have to do is enter some quick command line (eg. including some description) and the rest goes automatic: my work is published, ticket opened, etc. Coming from the other side, it would be cool to have some command get me the changes from ticket xyz, so we don't have to download and apply the patches manually. The best solution - use git branches for tracking patches, IMHO. hmm, heard of that, but never used it. How does it work ? hmm, do my changes then go to the current branch (assuming I've cloned from there) ? Yes, your changes will applyed to the main branch (named 'master'). You may create any count of commits (via git-commit), but this commits placed only in your local copy of repro. You may delete some of this commits, verge, revert commits... Okay, that's just normal working in the local repo ... but if you will run command 'git-push', all of your commits will frozen for changes. Because this commits transferred in parent repro and will see by any developer (via git-pull). git-pull will get latest changes from parent repro (like svn up, or full command: svn update). But this commits directly to our master repo, thus breaking our workflow, right ? If you want to have own 'sandbox' with some patches (not included in 'master'), you may create new local branch: Can I freely create branches within the master repo ? And more important: *should* I do this ? cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [r...@rover.dkm.cz: [repo.or.cz] midnight-commander clone completed]
* Pavel Roskin pro...@gnu.org schrieb: Hi, What's the point? I could have given you full access to the mc repository on the same site. After all, it's just a mirror. You could have rewritten the whole repository. Now we have two competing mirrors for the same project. I'm not going to keep it this way. Hey, it's just dumb *readonly* mirror. nobody can commit there (not even me) - it just syncs itself from the master periodically. the idea behind is nothing more to have yet another publically available copy to keep some unncessary traffic from the weak mc.o server. and in case something bad happens to the server, we've got an backup. It's not a fork or anything like that. I really don't see the problem. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: bundled intl stuff necessary
* Andrew Borodin aboro...@vmail.ru schrieb: On Sat, 3 Jan 2009 18:14:21 +0100 Enrico Weigelt wrote: * Andrew Borodin schrieb: ${datarootdir}/mc contains arch-independent files and mc-specific files. It's correct place in terms of FHS. Are you *absolutely* sure they're always arch-independent At current time -- yes. and ever will be ? Who knows? :-) That's the point. Some day someone writes an extfs in C (which is evrything but improbable) and the hassle begins. I'd prefer to keep such trouble out of the way even before it starts. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel