[MediaWiki-commits] [Gerrit] Add tests - change (mediawiki...InviteSignup)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243110 Change subject: Add tests .. Add tests Fix all issues so tests pass. Change-Id: I31124bf9fe7602e57141938b414b9d78ee8dd2ac --- M .gitignore

[MediaWiki-commits] [Gerrit] Add ferm rules for Spark - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has submitted this change and it was merged. Change subject: Add ferm rules for Spark .. Add ferm rules for Spark Bug: T83597 Change-Id: Icadb64ca8ee994b81a55e21fabf295fa270b2992 --- M

[MediaWiki-commits] [Gerrit] Persian Wikipedia configuration in wikipedia_family.py - change (pywikibot/core)

2015-10-02 Thread John Vandenberg (Code Review)
John Vandenberg has uploaded a new change for review. https://gerrit.wikimedia.org/r/243111 Change subject: Persian Wikipedia configuration in wikipedia_family.py .. Persian Wikipedia configuration in wikipedia_family.py -

[MediaWiki-commits] [Gerrit] [NumerAlpha] Add key to ignore - change (translatewiki)

2015-10-02 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. Change subject: [NumerAlpha] Add key to ignore .. [NumerAlpha] Add key to ignore https://gerrit.wikimedia.org/r/#/c/228419/7/i18n/en.json,unified Change-Id:

[MediaWiki-commits] [Gerrit] [NumerAlpha] Add key to ignore - change (translatewiki)

2015-10-02 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/243112 Change subject: [NumerAlpha] Add key to ignore .. [NumerAlpha] Add key to ignore

[MediaWiki-commits] [Gerrit] Converted node cache to using getMainStashInstance() - change (mediawiki...TorBlock)

2015-10-02 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/243113 Change subject: Converted node cache to using getMainStashInstance() .. Converted node cache to using getMainStashInstance() * This

[MediaWiki-commits] [Gerrit] T109077 Performance decreased saving pages for sites with n... - change (pywikibot/core)

2015-10-02 Thread John Vandenberg (Code Review)
John Vandenberg has uploaded a new change for review. https://gerrit.wikimedia.org/r/243114 Change subject: T109077 Performance decreased saving pages for sites with non-alphabetical code interwiki sort (interwiki_putfirst specified)

[MediaWiki-commits] [Gerrit] Track clicks on suggestions, etc., in "Did you mean" results - change (mediawiki...WikimediaEvents)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Track clicks on suggestions, etc., in "Did you mean" results .. Track clicks on suggestions, etc., in "Did you mean" results Add wprov=cirrusDYM-* to

[MediaWiki-commits] [Gerrit] Remove echo when MEDIAWIKI is not defined - change (mediawiki...UniversalLanguageSelector)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243170 Change subject: Remove echo when MEDIAWIKI is not defined .. Remove echo when MEDIAWIKI is not defined This breaks tests like in

[MediaWiki-commits] [Gerrit] [SmashPig] add php-composer-test to experimental - change (integration/config)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [SmashPig] add php-composer-test to experimental .. [SmashPig] add php-composer-test to experimental Will let us run composer test from Gerrit. Bug:

[MediaWiki-commits] [Gerrit] Composer entry point to run tests - change (wikimedia...SmashPig)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243173 Change subject: Composer entry point to run tests .. Composer entry point to run tests To be able to run the PHPUnit test suite (T104264), we

[MediaWiki-commits] [Gerrit] Do not use extension.json for MW 1.25.1 or 1.25.2, due to bu... - change (mediawiki...Cargo)

2015-10-02 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review. https://gerrit.wikimedia.org/r/243175 Change subject: Do not use extension.json for MW 1.25.1 or 1.25.2, due to bug in those .. Do not use extension.json for MW 1.25.1 or

[MediaWiki-commits] [Gerrit] Varnish: Add lint:ignore:quoted_booleans around a boolean th... - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Varnish: Add lint:ignore:quoted_booleans around a boolean that needs quoting. .. Varnish: Add lint:ignore:quoted_booleans around a boolean that needs

[MediaWiki-commits] [Gerrit] [IMPROV] nowcommons: Query at most one users - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] nowcommons: Query at most one users .. [IMPROV] nowcommons: Query at most one users To verify if a page is used it's only necessary to query one

[MediaWiki-commits] [Gerrit] Added dummy secrets/labstore/id_labstore to make puppet comp... - change (labs/private)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243183 Change subject: Added dummy secrets/labstore/id_labstore to make puppet compiler happy. .. Added dummy secrets/labstore/id_labstore to

[MediaWiki-commits] [Gerrit] Added dummy secrets/labstore/id_labstore to make puppet comp... - change (labs/private)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Added dummy secrets/labstore/id_labstore to make puppet compiler happy. .. Added dummy secrets/labstore/id_labstore to make puppet compiler happy.

[MediaWiki-commits] [Gerrit] analytics: modernize the ensure => link syntax in a couple ... - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: analytics: modernize the ensure => link syntax in a couple of places. .. analytics: modernize the ensure => link syntax in a couple of places.

[MediaWiki-commits] [Gerrit] update collector version - change (operations...cassandra-metrics-collector)

2015-10-02 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has uploaded a new change for review. https://gerrit.wikimedia.org/r/243121 Change subject: update collector version .. update collector version * introduce discovery of cassandra instances based on

[MediaWiki-commits] [Gerrit] Rename duplicate/outdated methods and parameters - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/243125 Change subject: Rename duplicate/outdated methods and parameters .. Rename duplicate/outdated methods and parameters Focus is

[MediaWiki-commits] [Gerrit] Introducing template format - change (mediawiki...TemplateData)

2015-10-02 Thread Eranroz (Code Review)
Eranroz has uploaded a new change for review. https://gerrit.wikimedia.org/r/243138 Change subject: Introducing template format .. Introducing template format Adding format for template data, which defines the preffered

[MediaWiki-commits] [Gerrit] Phase out yamllint - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243137 Change subject: Phase out yamllint .. Phase out yamllint The last repo using it was wikimedia/fundraising/tools, I have proposed a patch that

[MediaWiki-commits] [Gerrit] Refactor the code that determine insertion annotations - change (VisualEditor/VisualEditor)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Refactor the code that determine insertion annotations .. Refactor the code that determine insertion annotations Also use the cursor position with

[MediaWiki-commits] [Gerrit] Use zuul source @debian/precise-wikimedia - change (integration/jenkins)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use zuul source @debian/precise-wikimedia .. Use zuul source @debian/precise-wikimedia Run tests using Zuul as deployed on the gallium server which is

[MediaWiki-commits] [Gerrit] otrs: move systemd unit file into correct location - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: otrs: move systemd unit file into correct location .. otrs: move systemd unit file into correct location It was placed in the wrong directory

[MediaWiki-commits] [Gerrit] otrs: move systemd unit file into correct location - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/243143 Change subject: otrs: move systemd unit file into correct location .. otrs: move systemd unit file into correct location It was

[MediaWiki-commits] [Gerrit] otrs: scheduler is forking, set Type accordingly - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: otrs: scheduler is forking, set Type accordingly .. otrs: scheduler is forking, set Type accordingly Set systemd unit type to forking since that

[MediaWiki-commits] [Gerrit] otrs: scheduler is forking, set Type accordingly - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/243146 Change subject: otrs: scheduler is forking, set Type accordingly .. otrs: scheduler is forking, set Type accordingly Set systemd

[MediaWiki-commits] [Gerrit] Add tests - change (mediawiki...TwnMainPage)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243159 Change subject: Add tests .. Add tests Fix all issues so tests pass. Change-Id: Ifa53fe57532fcb8d58819900916b613ae20baa91 --- A .gitignore

[MediaWiki-commits] [Gerrit] Add tests - change (mediawiki...UserOptionStats)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243162 Change subject: Add tests .. Add tests Fix all issues so tests pass. Change-Id: I06cedc55c0d64950d94225cc12c1a57b961d06c0 --- M .gitignore

[MediaWiki-commits] [Gerrit] Remove Python 2.6 from the build matrix - change (pywikibot/core)

2015-10-02 Thread John Vandenberg (Code Review)
John Vandenberg has uploaded a new change for review. https://gerrit.wikimedia.org/r/243161 Change subject: Remove Python 2.6 from the build matrix .. Remove Python 2.6 from the build matrix Removing it before there are

[MediaWiki-commits] [Gerrit] [SmashPig] add composer backed test suite - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243174 Change subject: [SmashPig] add composer backed test suite .. [SmashPig] add composer backed test suite Drop phplint, not needed since the

[MediaWiki-commits] [Gerrit] puppet-lint: Turn on --no-puppet_url_without_modules-check - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243177 Change subject: puppet-lint: Turn on --no-puppet_url_without_modules-check .. puppet-lint: Turn on

[MediaWiki-commits] [Gerrit] Job for apps/android/java-mwapi - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243181 Change subject: Job for apps/android/java-mwapi .. Job for apps/android/java-mwapi Lets run `./gradlew clean checkstyle build`. Abstract

[MediaWiki-commits] [Gerrit] otrs: disable the scheduler watchdog - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/243182 Change subject: otrs: disable the scheduler watchdog .. otrs: disable the scheduler watchdog OTRS normally ships a watchdog

[MediaWiki-commits] [Gerrit] Add message docs for recent updates - change (mediawiki...NumerAlpha)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add message docs for recent updates .. Add message docs for recent updates Change-Id: I7b41af194facd488af02bac0217a74da0cf2164b --- M i18n/qqq.json 1

[MediaWiki-commits] [Gerrit] labstore: rearrange args to cleanup_snapshots - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243178 Change subject: labstore: rearrange args to cleanup_snapshots .. labstore: rearrange args to cleanup_snapshots Previously we had an

[MediaWiki-commits] [Gerrit] labstore: rearrange args to cleanup_snapshots - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: labstore: rearrange args to cleanup_snapshots .. labstore: rearrange args to cleanup_snapshots Previously we had an optional arg before a required

[MediaWiki-commits] [Gerrit] Persian Wikipedia configuration in wikipedia_family.py - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Persian Wikipedia configuration in wikipedia_family.py .. Persian Wikipedia configuration in wikipedia_family.py - One of category redirect templates was

[MediaWiki-commits] [Gerrit] interwiki: do not automatically log in - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: interwiki: do not automatically log in .. interwiki: do not automatically log in For interwiki.py, self.site is not necessarily the site we will write

[MediaWiki-commits] [Gerrit] Change special page title to be more human-friendly by default - change (mediawiki...MultiUpload)

2015-10-02 Thread Jack Phoenix (Code Review)
Jack Phoenix has uploaded a new change for review. https://gerrit.wikimedia.org/r/243165 Change subject: Change special page title to be more human-friendly by default .. Change special page title to be more human-friendly by

[MediaWiki-commits] [Gerrit] Pass staging state through Document#commit to ve.dm.Node upd... - change (VisualEditor/VisualEditor)

2015-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/243166 Change subject: Pass staging state through Document#commit to ve.dm.Node update event .. Pass staging state through Document#commit to

[MediaWiki-commits] [Gerrit] Update tests for Translate - change (integration/config)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243169 Change subject: Update tests for Translate .. Update tests for Translate Requires: * Change-Id: I934a9545c275c6a16fab83c52d077dd5b62a7ada

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: ec2ff26..d63dce1 - change (mediawiki/extensions)

2015-10-02 Thread Jenkins-mwext-sync (Code Review)
Jenkins-mwext-sync has submitted this change and it was merged. Change subject: Syncronize VisualEditor: ec2ff26..d63dce1 .. Syncronize VisualEditor: ec2ff26..d63dce1 Change-Id: I0594be2d110cd5d5a062a9627d4427c5fd35c940 --- M

[MediaWiki-commits] [Gerrit] [IMPROV] Use newer version of unicodecsv again - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] Use newer version of unicodecsv again .. [IMPROV] Use newer version of unicodecsv again Version 0.14.0 of `unicodecsv` is not compatible with

[MediaWiki-commits] [Gerrit] Cassandra: dequote some booleans. - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Cassandra: dequote some booleans. .. Cassandra: dequote some booleans. Note that in e.g.

[MediaWiki-commits] [Gerrit] Added dummy user/password passwords::mysql::labsdb - change (labs/private)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243184 Change subject: Added dummy user/password passwords::mysql::labsdb .. Added dummy user/password passwords::mysql::labsdb Change-Id:

[MediaWiki-commits] [Gerrit] Correctly identify qualifier from JSON - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Correctly identify qualifier from JSON .. Correctly identify qualifier from JSON Identifies any qualifier or reference if initialised through fromJSON()

[MediaWiki-commits] [Gerrit] MWExtensionNode: Fix selector to find dimension-less images - change (mediawiki...VisualEditor)

2015-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/243168 Change subject: MWExtensionNode: Fix selector to find dimension-less images .. MWExtensionNode: Fix selector to find dimension-less images

[MediaWiki-commits] [Gerrit] [SmashPig] add php-composer-test to experimental - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243172 Change subject: [SmashPig] add php-composer-test to experimental .. [SmashPig] add php-composer-test to experimental Will let us run composer

[MediaWiki-commits] [Gerrit] Do not use extension.json for MW 1.25.1 or 1.25.2, due to bu... - change (mediawiki...Cargo)

2015-10-02 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged. Change subject: Do not use extension.json for MW 1.25.1 or 1.25.2, due to bug in those .. Do not use extension.json for MW 1.25.1 or 1.25.2, due to bug in those

[MediaWiki-commits] [Gerrit] puppet-lint: enable quoted_booleans-check - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: puppet-lint: enable quoted_booleans-check .. puppet-lint: enable quoted_booleans-check Because mixing quoted booleans and unquoted ones are a source of

[MediaWiki-commits] [Gerrit] analytics/limn-mobile-data to Nodepool and run all tox env - change (integration/config)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: analytics/limn-mobile-data to Nodepool and run all tox env .. analytics/limn-mobile-data to Nodepool and run all tox env Source patch is

[MediaWiki-commits] [Gerrit] Omit includeredirects parameter for allpages generator - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Omit includeredirects parameter for allpages generator .. Omit includeredirects parameter for allpages generator - since includeredirects is listed in

[MediaWiki-commits] [Gerrit] Experiment YAML aliases and template inheritance - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243164 Change subject: Experiment YAML aliases and template inheritance .. Experiment YAML aliases and template inheritance The Jenkins jobs have

[MediaWiki-commits] [Gerrit] Always render generated content the first time, including er... - change (VisualEditor/VisualEditor)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Always render generated content the first time, including errors .. Always render generated content the first time, including errors While using an

[MediaWiki-commits] [Gerrit] proofreadpage.py: Fix an error in tests and errors in docstr... - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: proofreadpage.py: Fix an error in tests and errors in docstrings .. proofreadpage.py: Fix an error in tests and errors in docstrings Change-Id:

[MediaWiki-commits] [Gerrit] MWExtensionNode: Fix selector to find dimension-less images - change (mediawiki...VisualEditor)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: MWExtensionNode: Fix selector to find dimension-less images .. MWExtensionNode: Fix selector to find dimension-less images Change-Id:

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: ec2ff26..d63dce1 - change (mediawiki/extensions)

2015-10-02 Thread Jenkins-mwext-sync (Code Review)
Jenkins-mwext-sync has uploaded a new change for review. https://gerrit.wikimedia.org/r/243171 Change subject: Syncronize VisualEditor: ec2ff26..d63dce1 .. Syncronize VisualEditor: ec2ff26..d63dce1 Change-Id:

[MediaWiki-commits] [Gerrit] analytics: modernize the ensure => link syntax in a couple ... - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243179 Change subject: analytics: modernize the ensure => link syntax in a couple of places. .. analytics: modernize the ensure => link

[MediaWiki-commits] [Gerrit] WIP BannerHistoryLog: timeout for users without sendBeacon - change (mediawiki...CentralNotice)

2015-10-02 Thread AndyRussG (Code Review)
AndyRussG has uploaded a new change for review. https://gerrit.wikimedia.org/r/243180 Change subject: WIP BannerHistoryLog: timeout for users without sendBeacon .. WIP BannerHistoryLog: timeout for users without sendBeacon

[MediaWiki-commits] [Gerrit] Fix tox to be able to run tests - change (analytics/limn-mobile-data)

2015-10-02 Thread Nuria (Code Review)
Nuria has submitted this change and it was merged. Change subject: Fix tox to be able to run tests .. Fix tox to be able to run tests The test-requirements.txt has been removed. Reinstate it and list the requirements needed to

[MediaWiki-commits] [Gerrit] Disable NFS lookup cache on NFS client instances - change (operations/puppet)

2015-10-02 Thread coren (Code Review)
coren has submitted this change and it was merged. Change subject: Disable NFS lookup cache on NFS client instances .. Disable NFS lookup cache on NFS client instances This disables the lookup cache (which is very aggresive by

[MediaWiki-commits] [Gerrit] Added dummy user/password passwords::mysql::labsdb - change (labs/private)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Added dummy user/password passwords::mysql::labsdb .. Added dummy user/password passwords::mysql::labsdb Change-Id:

[MediaWiki-commits] [Gerrit] Add message docs for recent updates - change (mediawiki...NumerAlpha)

2015-10-02 Thread Jamesmontalvo3 (Code Review)
Jamesmontalvo3 has uploaded a new change for review. https://gerrit.wikimedia.org/r/243157 Change subject: Add message docs for recent updates .. Add message docs for recent updates Change-Id:

[MediaWiki-commits] [Gerrit] Add tests - change (mediawiki...Translate)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243160 Change subject: Add tests .. Add tests Fix all issues so tests pass. Change-Id: I934a9545c275c6a16fab83c52d077dd5b62a7ada --- M .gitignore

[MediaWiki-commits] [Gerrit] Ensure full error message is show when inspector is closed - change (mediawiki...VisualEditor)

2015-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/243167 Change subject: Ensure full error message is show when inspector is closed .. Ensure full error message is show when inspector is closed

[MediaWiki-commits] [Gerrit] Varnish: Add lint:ignore:quoted_booleans around a boolean th... - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/243176 Change subject: Varnish: Add lint:ignore:quoted_booleans around a boolean that needs quoting. .. Varnish: Add

[MediaWiki-commits] [Gerrit] Add tests - change (mediawiki...Renameuser)

2015-10-02 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/243119 Change subject: Add tests .. Add tests Fix all issues so tests pass. Change-Id: I4545276d84fc0d0405d7c16ab179332298eb682b --- M .gitignore

[MediaWiki-commits] [Gerrit] Adding wikiuser and wikiadmin grants to read the heartbeat t... - change (operations/puppet)

2015-10-02 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. Change subject: Adding wikiuser and wikiadmin grants to read the heartbeat table .. Adding wikiuser and wikiadmin grants to read the heartbeat table Change-Id:

[MediaWiki-commits] [Gerrit] sslcert: fix update-ocsp's non-proxy mode - change (operations/puppet)

2015-10-02 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. Change subject: sslcert: fix update-ocsp's non-proxy mode .. sslcert: fix update-ocsp's non-proxy mode update-ocsp already had code to deal with not passing a

[MediaWiki-commits] [Gerrit] [IMPROV] Don't use shell argument - change (integration/jenkins)

2015-10-02 Thread XZise (Code Review)
XZise has uploaded a new change for review. https://gerrit.wikimedia.org/r/243140 Change subject: [IMPROV] Don't use shell argument .. [IMPROV] Don't use shell argument The `shell` argument in `subprocess.check_output`

[MediaWiki-commits] [Gerrit] Clean up entityview - change (mediawiki...Wikibase)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Clean up entityview .. Clean up entityview * Switch from holding a reference to the entity terms jQuery DOM element to having a reference to the

[MediaWiki-commits] [Gerrit] Adding ferm::mariadb role to labsdb1004 (tools slave) - change (operations/puppet)

2015-10-02 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. https://gerrit.wikimedia.org/r/243129 Change subject: Adding ferm::mariadb role to labsdb1004 (tools slave) .. Adding ferm::mariadb role to labsdb1004 (tools slave) This will

[MediaWiki-commits] [Gerrit] Adding ferm::mariadb role to labsdb1004 (tools slave) - change (operations/puppet)

2015-10-02 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. Change subject: Adding ferm::mariadb role to labsdb1004 (tools slave) .. Adding ferm::mariadb role to labsdb1004 (tools slave) This will allow remote administration and

[MediaWiki-commits] [Gerrit] sslcert: fix update-ocsp's non-proxy mode - change (operations/puppet)

2015-10-02 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. https://gerrit.wikimedia.org/r/243133 Change subject: sslcert: fix update-ocsp's non-proxy mode .. sslcert: fix update-ocsp's non-proxy mode update-ocsp already had code

[MediaWiki-commits] [Gerrit] mariadb: update submodule in production repo - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/243148 Change subject: mariadb: update submodule in production repo .. mariadb: update submodule in production repo Change-Id:

[MediaWiki-commits] [Gerrit] Rename functions from thingBuilder to buildThing - change (mediawiki...Wikibase)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Rename functions from thingBuilder to buildThing .. Rename functions from thingBuilder to buildThing Since they are functions, not objects, a verb is a

[MediaWiki-commits] [Gerrit] Revert "Revert "Include foreign files in ApiQueryPageImages"" - change (mediawiki...PageImages)

2015-10-02 Thread Phuedx (Code Review)
Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/243124 Change subject: Revert "Revert "Include foreign files in ApiQueryPageImages"" .. Revert "Revert "Include foreign files in ApiQueryPageImages""

[MediaWiki-commits] [Gerrit] releases: Move the base::firewall include into the role - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/243123 Change subject: releases: Move the base::firewall include into the role .. releases: Move the base::firewall include into the role

[MediaWiki-commits] [Gerrit] WIP: Hiera-based assignment of grains for debdeploy - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/243142 Change subject: WIP: Hiera-based assignment of grains for debdeploy .. WIP: Hiera-based assignment of grains for debdeploy Also add two

[MediaWiki-commits] [Gerrit] mw.Upload.BookletLayout: Show errors and try to recover from... - change (mediawiki/core)

2015-10-02 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. https://gerrit.wikimedia.org/r/243144 Change subject: mw.Upload.BookletLayout: Show errors and try to recover from warnings .. mw.Upload.BookletLayout: Show errors and try to

[MediaWiki-commits] [Gerrit] otrs: Fix typo in scheduler cron entry - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: otrs: Fix typo in scheduler cron entry .. otrs: Fix typo in scheduler cron entry missing the /otrs/ part Change-Id:

[MediaWiki-commits] [Gerrit] Move base::firewall include into the role - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/243122 Change subject: Move base::firewall include into the role .. Move base::firewall include into the role All image scalers use ferm now,

[MediaWiki-commits] [Gerrit] build: Enable jscs jsDoc rule 'checkParamNames' and make pass - change (mediawiki...Wikibase)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: build: Enable jscs jsDoc rule 'checkParamNames' and make pass .. build: Enable jscs jsDoc rule 'checkParamNames' and make pass * order @param annotations

[MediaWiki-commits] [Gerrit] Fix merging of entity usage aspects - change (mediawiki...Wikibase)

2015-10-02 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/243135 Change subject: Fix merging of entity usage aspects .. Fix merging of entity usage aspects Fix merging of entity usage aspects by

[MediaWiki-commits] [Gerrit] Rough YAML linter for *.yaml.example files - change (wikimedia...tools)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243134 Change subject: Rough YAML linter for *.yaml.example files .. Rough YAML linter for *.yaml.example files Iterate the repository for files

[MediaWiki-commits] [Gerrit] Remove yamllint - change (integration/jenkins)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove yamllint .. Remove yamllint To lint yaml we are using python-yaml which has a few problems: - it can load an arbitrary python object which is

[MediaWiki-commits] [Gerrit] otrs: Ship systemd unit file for OTRS scheduler - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: otrs: Ship systemd unit file for OTRS scheduler .. otrs: Ship systemd unit file for OTRS scheduler Versions of OTRS > 3.3.x require an OTRS

[MediaWiki-commits] [Gerrit] Add the new OTRS scheduler watchdog cron entry - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: Add the new OTRS scheduler watchdog cron entry .. Add the new OTRS scheduler watchdog cron entry OTRS since 3.3.6 needs a cron entry for the

[MediaWiki-commits] [Gerrit] Add a .gitreview file - change (operations...mariadb)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: Add a .gitreview file .. Add a .gitreview file Useful for setting up git review Change-Id: I4abcc85bbda0350440ee7100a6d901ef35c5b07f --- A

[MediaWiki-commits] [Gerrit] jjb: expand git-cxserver-and-deploy-repos macro - change (integration/config)

2015-10-02 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/243149 Change subject: jjb: expand git-cxserver-and-deploy-repos macro .. jjb: expand git-cxserver-and-deploy-repos macro Only used once. Get rid of

[MediaWiki-commits] [Gerrit] Enable ferm on analytics1002 - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/243150 Change subject: Enable ferm on analytics1002 .. Enable ferm on analytics1002 As discussed earlier, let's start with the standby and

[MediaWiki-commits] [Gerrit] Enable ferm on analytics1001 - change (operations/puppet)

2015-10-02 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/243151 Change subject: Enable ferm on analytics1001 .. Enable ferm on analytics1001 Change-Id: I35d306f27eeb83b6da3df79154dbbfa61d4b5cfe --- M

[MediaWiki-commits] [Gerrit] Add block/inline icons - change (mediawiki...TemplateData)

2015-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/243155 Change subject: Add block/inline icons .. Add block/inline icons Change-Id: I7d07af249318e4f39d8e4a29d1fa3ccdd216e63b --- M

[MediaWiki-commits] [Gerrit] build: Enable jscs jsDoc rule 'requireReturnTypes' and make ... - change (mediawiki...Wikibase)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: build: Enable jscs jsDoc rule 'requireReturnTypes' and make pass .. build: Enable jscs jsDoc rule 'requireReturnTypes' and make pass As in MediaWiki core

[MediaWiki-commits] [Gerrit] Performance fix for sites using interwiki_putfirst option - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Performance fix for sites using interwiki_putfirst option .. Performance fix for sites using interwiki_putfirst option Bug: T109077 Change-Id:

[MediaWiki-commits] [Gerrit] interwiki.py: check for category before emptiness - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: interwiki.py: check for category before emptiness .. interwiki.py: check for category before emptiness Currently, page.isEmpty() requires parsing the

[MediaWiki-commits] [Gerrit] '-ignore' parameter throws exception in interwiki.py - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: '-ignore' parameter throws exception in interwiki.py .. '-ignore' parameter throws exception in interwiki.py Bug: T108838 Change-Id:

[MediaWiki-commits] [Gerrit] Fix docs in PageEntityUsages - change (mediawiki...Wikibase)

2015-10-02 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/243136 Change subject: Fix docs in PageEntityUsages .. Fix docs in PageEntityUsages Fix php docs in PageEntityUsages (return types)

[MediaWiki-commits] [Gerrit] otrs: Fix typo in scheduler cron entry - change (operations/puppet)

2015-10-02 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/243152 Change subject: otrs: Fix typo in scheduler cron entry .. otrs: Fix typo in scheduler cron entry missing the /otrs/ part

  1   2   3   4   >