[MediaWiki-commits] [Gerrit] mediawiki...Quiz[master]: Remove Shuffle feature if only one question is in quiz

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357781 ) Change subject: Remove Shuffle feature if only one question is in quiz .. Remove Shuffle feature if only one question is in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add @covers for stripBom and makeModuleRespo...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361623 ) Change subject: resourceloader: Add @covers for stripBom and makeModuleResponse tests .. resourceloader: Add @covers for stripBom and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add basic tests for getScript() and buildCon...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361622 ) Change subject: resourceloader: Add basic tests for getScript() and buildContent() .. resourceloader: Add basic tests for getScript() and

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "db-eqiad.php: Depool db1079"

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361621 ) Change subject: Revert "db-eqiad.php: Depool db1079" .. Revert "db-eqiad.php: Depool db1079" This reverts commit

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "db-eqiad.php: Depool db1079"

2017-06-26 Thread Marostegui (Code Review)
Hello Florianschmidtwelzow, jenkins-bot, Jcrespo, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/361621 to review the following change. Change subject: Revert "db-eqiad.php: Depool db1079"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add @covers for stripBom() test

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361620 ) Change subject: resourceloader: Add @covers for stripBom() test .. resourceloader: Add @covers for stripBom() test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Complete test coverage for FileModule::getTe...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361619 ) Change subject: resourceloader: Complete test coverage for FileModule::getTemplates() .. resourceloader: Complete test coverage for

[MediaWiki-commits] [Gerrit] operations/dns[master]: remove torrus.wikimedia.org

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361618 ) Change subject: remove torrus.wikimedia.org .. remove torrus.wikimedia.org Change-Id: I113e858007fafe3a82ae5fa0586dbcdc67ef696c --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: varnish/bacula: remove torrus directors

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361617 ) Change subject: varnish/bacula: remove torrus directors .. varnish/bacula: remove torrus directors Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: site: update TODO roles for netmon1002, no more torrus

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361616 ) Change subject: site: update TODO roles for netmon1002, no more torrus .. site: update TODO roles for netmon1002, no more torrus

[MediaWiki-commits] [Gerrit] operations/puppet[production]: site: update TODO roles for netmon1002, no more torrus

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361616 ) Change subject: site: update TODO roles for netmon1002, no more torrus .. site: update TODO roles for netmon1002, no more torrus Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: site: remove smokeping role from netmon1001

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361615 ) Change subject: site: remove smokeping role from netmon1001 .. site: remove smokeping role from netmon1001 This role moved to netmon1002 on

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: add backend for netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361614 ) Change subject: cache::misc: add backend for netmon1002 .. cache::misc: add backend for netmon1002 Since we are migrating netmon1001

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: add backend for netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361614 ) Change subject: cache::misc: add backend for netmon1002 .. cache::misc: add backend for netmon1002 Bug: T159756 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc/smokeping: switch smokeping backend to netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361608 ) Change subject: cache::misc/smokeping: switch smokeping backend to netmon1002 .. cache::misc/smokeping: switch smokeping backend to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: User: Avoid deprecated Linker::link()

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361613 ) Change subject: User: Avoid deprecated Linker::link() .. User: Avoid deprecated Linker::link() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DidYouMeanWidget: Don't use deprecated Linker::linkKnown()

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361612 ) Change subject: DidYouMeanWidget: Don't use deprecated Linker::linkKnown() .. DidYouMeanWidget: Don't use deprecated Linker::linkKnown()

[MediaWiki-commits] [Gerrit] purtle[master]: Update MediaWiki CodeSniffer to version 0.9.0

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360369 ) Change subject: Update MediaWiki CodeSniffer to version 0.9.0 .. Update MediaWiki CodeSniffer to version 0.9.0 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Update for deprecation of OOjs UI openWindow/closeWindow pro...

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357432 ) Change subject: Update for deprecation of OOjs UI openWindow/closeWindow promise .. Update for deprecation of OOjs UI

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Drop symlink from tarball, hurts Windows users

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361611 ) Change subject: Drop symlink from tarball, hurts Windows users .. Drop symlink from tarball, hurts Windows users (Or Windows

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Drop symlink from tarball, hurts Windows users

2017-06-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361611 ) Change subject: Drop symlink from tarball, hurts Windows users .. Drop symlink from tarball, hurts Windows users (Or Windows could just get

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: Remove not needed "return true" defaults from hook handlers

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361415 ) Change subject: Remove not needed "return true" defaults from hook handlers .. Remove not needed "return true" defaults from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Unbreak tableExists() with prefix on MySQL

2017-06-26 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361610 ) Change subject: Unbreak tableExists() with prefix on MySQL .. Unbreak tableExists() with prefix on MySQL

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Limit mmap to indexes (work-around for abnormal page faults)

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361506 ) Change subject: Limit mmap to indexes (work-around for abnormal page faults) .. Limit mmap to indexes (work-around for abnormal page

[MediaWiki-commits] [Gerrit] operations/puppet[production]: jenkins: lack of access_log produce invalid system unit

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361551 ) Change subject: jenkins: lack of access_log produce invalid system unit .. jenkins: lack of access_log produce invalid system unit

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Remove if extension table is empty

2017-06-26 Thread Mooeypoo (Code Review)
Mooeypoo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361609 ) Change subject: RCFilters: Remove if extension table is empty .. RCFilters: Remove if extension table is empty Bug: T168325 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: smokeping: allow rsync of data from netmon1001 to netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361606 ) Change subject: smokeping: allow rsync of data from netmon1001 to netmon1002 .. smokeping: allow rsync of data from netmon1001 to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Add 'single_option' group type

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360385 ) Change subject: RCFilters: Add 'single_option' group type .. RCFilters: Add 'single_option' group type Group type that only

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc/smokeping: switch smokeping backend to netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361608 ) Change subject: cache::misc/smokeping: switch smokeping backend to netmon1002 .. cache::misc/smokeping: switch smokeping backend to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Correct default view title

2017-06-26 Thread Mooeypoo (Code Review)
Mooeypoo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361607 ) Change subject: RCFilters: Correct default view title .. RCFilters: Correct default view title The key was changed from "label" to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: smokeping: allow rsync of data from netmon1001 to netmon1002

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361606 ) Change subject: smokeping: allow rsync of data from netmon1001 to netmon1002 .. smokeping: allow rsync of data from netmon1001 to netmon1002

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Make extra filters footer non-sticky

2017-06-26 Thread Mooeypoo (Code Review)
Mooeypoo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361605 ) Change subject: RCFilters: Make extra filters footer non-sticky .. RCFilters: Make extra filters footer non-sticky Bug: T168851

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update reading list onboarding UI

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359668 ) Change subject: Update reading list onboarding UI .. Update reading list onboarding UI This task update the visual design of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Simplify "Saved filter settings" to "Saved filters"

2017-06-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361604 ) Change subject: RCFilters: Simplify "Saved filter settings" to "Saved filters" .. RCFilters: Simplify "Saved filter settings" to "Saved

[MediaWiki-commits] [Gerrit] operations/dns[master]: decom mw2098

2017-06-26 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361603 ) Change subject: decom mw2098 .. decom mw2098 final step, removal of mgmt dns Bug:T164959 Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: decom mw2098

2017-06-26 Thread RobH (Code Review)
RobH has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361603 ) Change subject: decom mw2098 .. decom mw2098 final step, removal of mgmt dns Bug:T164959 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Always use the filled bookmark icon (unClip)

2017-06-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361602 ) Change subject: RCFilters: Always use the filled bookmark icon (unClip) .. RCFilters: Always use the filled bookmark icon (unClip) Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] RCFilters: Make view switch and save/reset buttons lig...

2017-06-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361601 ) Change subject: [WIP] RCFilters: Make view switch and save/reset buttons lighter .. [WIP] RCFilters: Make view switch and save/reset

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.30.0-wmf.6]: Reapply: Sidebar: Fix marker coordinates for outer resources

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361584 ) Change subject: Reapply: Sidebar: Fix marker coordinates for outer resources .. Reapply: Sidebar: Fix marker coordinates for

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Show a popup for first time Codemirror users

2017-06-26 Thread Niharika29 (Code Review)
Niharika29 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361600 ) Change subject: Show a popup for first time Codemirror users .. Show a popup for first time Codemirror users Bug: T165003 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: smokeping: ensure dnsutils is installed, use require_package

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361599 ) Change subject: smokeping: ensure dnsutils is installed, use require_package .. smokeping: ensure dnsutils is installed, use

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fonts: update submodule to https://gerrit.wikimedia.org/r/#/...

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361598 ) Change subject: Fonts: update submodule to https://gerrit.wikimedia.org/r/#/c/361195/ .. Fonts: update submodule to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: smokeping: ensure dnsutils is installed, use require_package

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361599 ) Change subject: smokeping: ensure dnsutils is installed, use require_package .. smokeping: ensure dnsutils is installed, use require_package

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fonts: update submodule to https://gerrit.wikimedia.org/r/#/...

2017-06-26 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361598 ) Change subject: Fonts: update submodule to https://gerrit.wikimedia.org/r/#/c/361195/ .. Fonts: update submodule to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make multiple colons escaping interlanguage links invalid, c...

2017-06-26 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361597 ) Change subject: Make multiple colons escaping interlanguage links invalid, consistently .. Make multiple colons escaping interlanguage

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Fix bug where up-to date is not advanced if there are no new...

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361594 ) Change subject: Fix bug where up-to date is not advanced if there are no new changes. .. Fix bug where up-to date is not

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Add getDesiredBound() for Labels

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361200 ) Change subject: Add getDesiredBound() for Labels .. Add getDesiredBound() for Labels This may make it easier for Optimizer to

[MediaWiki-commits] [Gerrit] operations...fonts[master]: Adding font files and license

2017-06-26 Thread MaxSem (Code Review)
MaxSem has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361195 ) Change subject: Adding font files and license .. Adding font files and license Bug: T168757 Change-Id:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WikimediaUI theme: Set ButtonElement's height per default

2017-06-26 Thread VolkerE (Code Review)
VolkerE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361596 ) Change subject: WikimediaUI theme: Set ButtonElement's height per default .. WikimediaUI theme: Set ButtonElement's height per default

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[wmf/1.30.0-wmf.6]: Add some logging to debug T166348

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361508 ) Change subject: Add some logging to debug T166348 .. Add some logging to debug T166348 Just putting this hack in wmf.6, not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nslcd: Remove Labs shell override

2017-06-26 Thread BryanDavis (Code Review)
BryanDavis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361595 ) Change subject: nslcd: Remove Labs shell override .. nslcd: Remove Labs shell override We used to set the shells for some LDAP accounts

[MediaWiki-commits] [Gerrit] operations/puppet[production]: netmon1002: add smokeping role

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361191 ) Change subject: netmon1002: add smokeping role .. netmon1002: add smokeping role Bug: T159756 Change-Id:

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Fix bug where up-to date is not advanced if there are no new...

2017-06-26 Thread Smalyshev (Code Review)
Smalyshev has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361594 ) Change subject: Fix bug where up-to date is not advanced if there are no new changes. .. Fix bug where up-to date is not advanced if

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Replace some usages of Linker::link with LinkRenderer

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/324819 ) Change subject: Replace some usages of Linker::link with LinkRenderer .. Replace some usages of Linker::link with LinkRenderer

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add awight to ores-admins

2017-06-26 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361593 ) Change subject: Add awight to ores-admins .. Add awight to ores-admins Bug: T168442 Change-Id: I51e92d67229edce9d9bfe8cce0e1cafa8bd2b526

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Add traffic from sister search

2017-06-26 Thread Bearloga (Code Review)
Bearloga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361592 ) Change subject: Add traffic from sister search .. Add traffic from sister search Bug: T164854 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Invert the muted state of inverted namespace options

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360759 ) Change subject: RCFilters: Invert the muted state of inverted namespace options .. RCFilters: Invert the muted state of

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Linter: Log error when DSR is missing

2017-06-26 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361591 ) Change subject: Linter: Log error when DSR is missing .. Linter: Log error when DSR is missing * Don't push the message into the

[MediaWiki-commits] [Gerrit] mediawiki...Linter[wmf/1.30.0-wmf.6]: Add debug logging for missing 'dsr'

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361588 ) Change subject: Add debug logging for missing 'dsr' .. Add debug logging for missing 'dsr' Bug: T168900 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable 'Linter' debug log channel

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361589 ) Change subject: Enable 'Linter' debug log channel .. Enable 'Linter' debug log channel Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: servermon: fix spec

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361590 ) Change subject: servermon: fix spec .. servermon: fix spec Add a few dependent modules. Mock secret(), required by scap. Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable 'Linter' debug log channel

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361589 ) Change subject: Enable 'Linter' debug log channel .. Enable 'Linter' debug log channel Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: Add debug logging for missing 'dsr'

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361587 ) Change subject: Add debug logging for missing 'dsr' .. Add debug logging for missing 'dsr' Bug: T168900 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Linter[wmf/1.30.0-wmf.6]: Add debug logging for missing 'dsr'

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361588 ) Change subject: Add debug logging for missing 'dsr' .. Add debug logging for missing 'dsr' Bug: T168900 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tilerator: mock secret()

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361586 ) Change subject: tilerator: mock secret() .. tilerator: mock secret() Create a secret() method for testing. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: Add debug logging for missing 'dsr'

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361587 ) Change subject: Add debug logging for missing 'dsr' .. Add debug logging for missing 'dsr' Bug: T168900 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: [DONOTMERGE] Don't always assume dsr is set

2017-06-26 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361585 ) Change subject: [DONOTMERGE] Don't always assume dsr is set .. [DONOTMERGE] Don't always assume dsr is set Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.30.0-wmf.6]: Revert "Revert "Sidebar: Fix marker coordinates for outer re...

2017-06-26 Thread MaxSem (Code Review)
Hello Hashar, 0x010C, jenkins-bot, Gehel, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/361584 to review the following change. Change subject: Revert "Revert "Sidebar: Fix marker coordinates for outer resources""

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bumps submodules for editquality/ores/wheels (1.3.15 update)

2017-06-26 Thread Awight (Code Review)
Awight has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361583 ) Change subject: Bumps submodules for editquality/ores/wheels (1.3.15 update) .. Bumps submodules for editquality/ores/wheels (1.3.15

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bumps submodules for editquality/ores/wheels (1.3.15 update)

2017-06-26 Thread Halfak (Code Review)
Halfak has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361583 ) Change subject: Bumps submodules for editquality/ores/wheels (1.3.15 update) .. Bumps submodules for editquality/ores/wheels (1.3.15 update)

[MediaWiki-commits] [Gerrit] operations/dns[master]: mw117[0-9] decommission

2017-06-26 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361582 ) Change subject: mw117[0-9] decommission .. mw117[0-9] decommission removal of production dns entries, mgmt entries will follow once

[MediaWiki-commits] [Gerrit] operations/puppet[production]: decom mw117[0-9]

2017-06-26 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361581 ) Change subject: decom mw117[0-9] .. decom mw117[0-9] removal of site.pp and dhcp lease entries Bug:T168271 Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: mw117[0-9] decommission

2017-06-26 Thread RobH (Code Review)
RobH has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361582 ) Change subject: mw117[0-9] decommission .. mw117[0-9] decommission removal of production dns entries, mgmt entries will follow once systems

[MediaWiki-commits] [Gerrit] operations/puppet[production]: decom mw117[0-9]

2017-06-26 Thread RobH (Code Review)
RobH has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361581 ) Change subject: decom mw117[0-9] .. decom mw117[0-9] removal of site.pp and dhcp lease entries Bug:T168271 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nrpe: fix spec (depends on stdlib)

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361580 ) Change subject: nrpe: fix spec (depends on stdlib) .. nrpe: fix spec (depends on stdlib) Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Does this pass CI?

2017-06-26 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361579 ) Change subject: Does this pass CI? .. Does this pass CI? Change-Id: Icb89a7209b24b67c40faf2c2055b462fef76bf81 --- A test 1 file changed, 0

[MediaWiki-commits] [Gerrit] operations/puppet[production]: jenkins: fix spec

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361578 ) Change subject: jenkins: fix spec .. jenkins: fix spec os_version needs lsbdistid/lisbdistrelease. Provide them as default facts targetting

[MediaWiki-commits] [Gerrit] operations/puppet[production]: aptrepo: fix spec

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361577 ) Change subject: aptrepo: fix spec .. aptrepo: fix spec Tests depends on wmflib and apt (for apt::pin) Stub Exec['apt-get update'] Provide

[MediaWiki-commits] [Gerrit] research...wheels[master]: Updates revscoring to 1.3.15

2017-06-26 Thread Ladsgroup (Code Review)
Ladsgroup has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361576 ) Change subject: Updates revscoring to 1.3.15 .. Updates revscoring to 1.3.15 Change-Id:

[MediaWiki-commits] [Gerrit] research...wheels[master]: Updates revscoring to 1.3.15

2017-06-26 Thread Halfak (Code Review)
Halfak has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361576 ) Change subject: Updates revscoring to 1.3.15 .. Updates revscoring to 1.3.15 Change-Id: I82ccbc1b674a026e9f3ecf6b01d95a52177883c2 --- D

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Labtestpuppetmaster2001: Initial node definition

2017-06-26 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361504 ) Change subject: Labtestpuppetmaster2001: Initial node definition .. Labtestpuppetmaster2001: Initial node definition

[MediaWiki-commits] [Gerrit] integration/config[master]: Publish WebPageTest job status to wikimedia-perf-bots

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360875 ) Change subject: Publish WebPageTest job status to wikimedia-perf-bots .. Publish WebPageTest job status to wikimedia-perf-bots

[MediaWiki-commits] [Gerrit] operations/puppet[production]: jenkins: lack of access_log produce invalid system unit

2017-06-26 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361551 ) Change subject: jenkins: lack of access_log produce invalid system unit .. jenkins: lack of access_log produce invalid system unit For some

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix typo in word 'necessary'

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361485 ) Change subject: Fix typo in word 'necessary' .. Fix typo in word 'necessary' Bug: T168844 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM][Code experiment] Use local part of entity id

2017-06-26 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361543 ) Change subject: [DNM][Code experiment] Use local part of entity id .. [DNM][Code experiment] Use local part of entity id Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Call parent::__construct() in TalkpageManagerTest

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361477 ) Change subject: Call parent::__construct() in TalkpageManagerTest .. Call parent::__construct() in TalkpageManagerTest

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: GenerateFlowAutoload: Call parent constructor

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361515 ) Change subject: GenerateFlowAutoload: Call parent constructor .. GenerateFlowAutoload: Call parent constructor Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Follow-up 2dfb4511e9: call parent constructor in gen-autoloa...

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361493 ) Change subject: Follow-up 2dfb4511e9: call parent constructor in gen-autoload.php .. Follow-up 2dfb4511e9: call parent

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Include message for comment diff

2017-06-26 Thread Tchanders (Code Review)
Tchanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361516 ) Change subject: Include message for comment diff .. Include message for comment diff Bug: T149821 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 0b05026

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361514 ) Change subject: Update mobileapps to 0b05026 .. Update mobileapps to 0b05026 List of changes: 830175b Remove announcements

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: GenerateFlowAutoload: Call parent constructor

2017-06-26 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361515 ) Change subject: GenerateFlowAutoload: Call parent constructor .. GenerateFlowAutoload: Call parent constructor Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.init.mw.DesktopArticleTarget: Remove some hacks

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359034 ) Change subject: ve.init.mw.DesktopArticleTarget: Remove some hacks .. ve.init.mw.DesktopArticleTarget: Remove some hacks No

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 0b05026

2017-06-26 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361514 ) Change subject: Update mobileapps to 0b05026 .. Update mobileapps to 0b05026 List of changes: 830175b Remove announcements 0b05026 Bump

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.filewarning: Increase the area of the warning button

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361480 ) Change subject: mw.filewarning: Increase the area of the warning button .. mw.filewarning: Increase the area of the warning

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Title: Remove needless $.type() and minor clean up

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361196 ) Change subject: mediawiki.Title: Remove needless $.type() and minor clean up .. mediawiki.Title: Remove needless $.type() and

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix possible crash(es) when saving images from Gallery or Feed.

2017-06-26 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361513 ) Change subject: Fix possible crash(es) when saving images from Gallery or Feed. .. Fix possible crash(es) when saving images from Gallery or

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use the …::class feature instead of "ClassName::staticMethod...

2017-06-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360812 ) Change subject: Use the …::class feature instead of "ClassName::staticMethod" strings .. Use the …::class feature instead of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: netmon: remove rancid role from netmon1001

2017-06-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361510 ) Change subject: netmon: remove rancid role from netmon1001 .. netmon: remove rancid role from netmon1001 It is now working on

[MediaWiki-commits] [Gerrit] operations/puppet[production]: netmon: remove rancid role from netmon1001

2017-06-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361510 ) Change subject: netmon: remove rancid role from netmon1001 .. netmon: remove rancid role from netmon1001 It is now working on netmon1002.

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove warning when badge label can not be found

2017-06-26 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361509 ) Change subject: Remove warning when badge label can not be found .. Remove warning when badge label can not be found I added it but now

  1   2   3   >