Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336586 )
Change subject: Hygiene: separate OkHttpConnectionFactory nested classes into
files
..
Hygiene: separate OkHttpConnectionFactory nested
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336588 )
Change subject: Fix: request network response when cache response is stale
..
Fix: request network response when cache response is stale
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336587 )
Change subject: Hygiene: add cache / network source OkHttp logging interceptor
..
Hygiene: add cache / network source OkHttp logging int
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336585 )
Change subject: Hygiene: move OkHttpConnectionFactory to okhttp subpackage
..
Hygiene: move OkHttpConnectionFactory to okhttp subpackage
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336431 )
Change subject: Fix: use response's cache-control not request
..
Fix: use response's cache-control not request
Change-Id: I7301b5d7c15e
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336345 )
Change subject: Fix: update cache must-revalidate header logic
..
Fix: update cache must-revalidate header logic
When caching HTTP requ
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336247 )
Change subject: Bump versionCode to 2.5.185
..
Bump versionCode to 2.5.185
Change-Id: Idd321762d22584a5eaeb33e391ee7d6505c57b2d
---
M a
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335946 )
Change subject: Hygiene: upgrade to OkHttp 3.6.0
..
Hygiene: upgrade to OkHttp 3.6.0
https://github.com/square/okhttp/blob/master/CHANG
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335719 )
Change subject: Update: page header subtitle leading
..
Update: page header subtitle leading
Reduce leading of page header subtitle tex
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335718 )
Change subject: Fix: swap yellow90 and yellow30
..
Fix: swap yellow90 and yellow30
Bug: T139187
Change-Id: Ic4729b9d67adf2534a39f78600b
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335720 )
Change subject: add support for exact leading
..
add support for exact leading
Change-Id: I241adb3454087f1dc1148468474c4bebc852a067
---
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335568 )
Change subject: Hygiene: upgrade to Android Plugin for Gradle v2.2.3
..
Hygiene: upgrade to Android Plugin for Gradle v2.2.3
Already ou
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335458 )
Change subject: Update: palette
..
Update: palette
Update the app color scheme to 2017-01-15[0]. Only the Foundation theme
was changed.
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335334 )
Change subject: Fix: add WikiSite unmarshaller for legacy JSON
..
Fix: add WikiSite unmarshaller for legacy JSON
Bug: T152980
Change-Id
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335182 )
Change subject: Update: improve WikiSite.authorityToLanguageCode() robustness
..
Update: improve WikiSite.authorityToLanguageCode() robu
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335099 )
Change subject: Hygiene: add Page @NonNull / @Nullable annotations
..
Hygiene: add Page @NonNull / @Nullable annotations
Add missing @N
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334741 )
Change subject: Update: add a couple WikiSite tests
..
Update: add a couple WikiSite tests
Change-Id: Id68f4efbccadf4c4e351d444832c47b2
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334736 )
Change subject: Hygiene: move WikiSite Parcelable test from PercelableTest to
WikiSiteTest
..
Hygiene: move WikiSite Parcelable test fr
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334739 )
Change subject: Hygiene: reorder PageTitle members and add annotations
..
Hygiene: reorder PageTitle members and add annotations
Reorde
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334738 )
Change subject: Hygiene: limit visibility of Parcel constructors
..
Hygiene: limit visibility of Parcel constructors
Parcelable impleme
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334743 )
Change subject: Hygiene: update comment in NamespaceTypeAdapterTest
..
Hygiene: update comment in NamespaceTypeAdapterTest
Change-Id: I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334742 )
Change subject: Update: throw Exception when trying to marshal ZeroConfig
..
Update: throw Exception when trying to marshal ZeroConfig
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334737 )
Change subject: Update: add equals() and hashCode() overrides to Tab and
PageBackStackItem
..
Update: add equals() and hashCode() overr
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334740 )
Change subject: Hygiene: reorder PageBackStackItem methods
..
Hygiene: reorder PageBackStackItem methods
Change-Id: I2f6eca294f69db197e
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334454 )
Change subject: Update: allow OkHttp Cache to serve stale responses
..
Update: allow OkHttp Cache to serve stale responses
Bug: T148675
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334447 )
Change subject: Report failed tab JSON
..
Report failed tab JSON
Change-Id: Ib1bf99ab5dea0af7ca12e7d7ad3d7eb11c3d25f0
---
M app/src/mai
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333920 )
Change subject: Fix: wrap long description inputs across multiple lines
..
Fix: wrap long description inputs across multiple lines
Sett
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333834 )
Change subject: Fix: leak of mfTempOpenSection() Minerva-only JavaScript
function
..
Fix: leak of mfTempOpenSection() Minerva-only Java
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333831 )
Change subject: Hygiene: add phpcs rule for function declaration equals spacing
..
Hygiene: add phpcs rule for function declaration equa
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333454 )
Change subject: Hygiene: consolidate org.wikipedia.server into
org.wikipedia.dataclient
..
Hygiene: consolidate org.wikipedia.server in
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333453 )
Change subject: Hygiene: rename Retrofit *Endpoints* to Service
..
Hygiene: rename Retrofit *Endpoints* to Service
Service terminology
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333455 )
Change subject: Hygiene: rename some MediaWiki action API response types
..
Hygiene: rename some MediaWiki action API response types
•
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333285 )
Change subject: Hygiene: split nearby MwApiResponsePage data into subclass
..
Hygiene: split nearby MwApiResponsePage data into subclass
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333286 )
Change subject: Fix: use app language when new nearby results are requested
..
Fix: use app language when new nearby results are request
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333147 )
Change subject: Fix: potential NPE in PageLeadProperties.getSections() clients
..
Fix: potential NPE in PageLeadProperties.getSections()
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333145 )
Change subject: Hygiene: replace StringUtil methods with Apache Commons
StringUtils
..
Hygiene: replace StringUtil methods with Apache
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333120 )
Change subject: Hygiene: very minor misc clean up
..
Hygiene: very minor misc clean up
Change-Id: I664b588dafbb45859ab26d11e5973a8c3e22
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333115 )
Change subject: WIP: remove saved pages
..
WIP: remove saved pages
Support in the OkHttp caching layer and the ability to refresh missi
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333037 )
Change subject: Fix: update AppTextViewWithImagesTest reference images
..
Fix: update AppTextViewWithImagesTest reference images
An ame
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332490 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331999 )
Change subject: Hygiene: consistently use 4 space indent in www/js
..
Hygiene: consistently use 4 space indent in www/js
find www/js -n
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331908 )
Change subject: Hygiene: remove unused css-color-parser JavaScript
..
Hygiene: remove unused css-color-parser JavaScript
Change-Id: Id2
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331573 )
Change subject: New: make it harder to be a single lingual dev
..
New: make it harder to be a single lingual dev
This patch may be cont
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331569 )
Change subject: Hygiene: remove unused method in SharedPreferenceCookieManager
..
Hygiene: remove unused method in SharedPreferenceCooki
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331567 )
Change subject: Hygiene: use ReleaseUtil directly instead of wrapping in
WikipediaApp
..
Hygiene: use ReleaseUtil directly instead of w
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331551 )
Change subject: Hygiene: remove unused PageProps class
..
Hygiene: remove unused PageProps class
Change-Id: Ic1480b187b003ca7b60743e903
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331550 )
Change subject: Hygiene: change terminology from night to dark mode
..
Hygiene: change terminology from night to dark mode
Change-Id: I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331544 )
Change subject: Hygiene: clean up static data
..
Hygiene: clean up static data
• Use immutable maps
• Don't use wildcard imports
• Ho
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331543 )
Change subject: Hygiene: don't generate iOS language JSON files
..
Hygiene: don't generate iOS language JSON files
Change-Id: Ieda41251
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331540 )
Change subject: Hygiene: change NearbyResult reference from implementation to
interface
..
Hygiene: change NearbyResult reference from
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331536 )
Change subject: Hygiene: remove unused DummyClient generic parameter
..
Hygiene: remove unused DummyClient generic parameter
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331539 )
Change subject: Hygiene: add Card.title() default implementation
..
Hygiene: add Card.title() default implementation
Change-Id: I1f2a7e
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331541 )
Change subject: Update: languages supported & namespace translation
..
Update: languages supported & namespace translation
scripts/ge
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331538 )
Change subject: Hygiene: remove unused param in MainPageCard
..
Hygiene: remove unused param in MainPageCard
Change-Id: Ibf70e79d0fdbc3
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331537 )
Change subject: Hygiene: change SearchClient superclass to DummyClient
..
Hygiene: change SearchClient superclass to DummyClient
Change
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331434 )
Change subject: Fix span Parcelable implementations
..
Fix span Parcelable implementations
Change-Id: I0d22917c9f90623c4834bb4231ffe3c7
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331431 )
Change subject: Hygiene: move SyntaxHighlight styling classes to enum
..
Hygiene: move SyntaxHighlight styling classes to enum
This wil
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331421 )
Change subject: Hygiene: convert SyntaxHighlighter comments to code
..
Hygiene: convert SyntaxHighlighter comments to code
Change-Id: I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331405 )
Change subject: Hygiene: consolidate parcel test logic in util
..
Hygiene: consolidate parcel test logic in util
Refactoring to a utili
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331400 )
Change subject: Hygiene: remove unused method, WikiSite.authorityToDesktop
..
Hygiene: remove unused method, WikiSite.authorityToDesktop
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331353 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331089 )
Change subject: Hygiene: replace DrawableUtil with DrawableCompat
..
Hygiene: replace DrawableUtil with DrawableCompat
Change-Id: Ie85a
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331087 )
Change subject: Hygiene: remove unused string
..
Hygiene: remove unused string
Change-Id: I69ecf6a4e7d56dc2eae59a9127a9017d55e06c9b
---
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330836 )
Change subject: New: add last 5 days of pageviews to most-read response
..
New: add last 5 days of pageviews to most-read response
Bug:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330617 )
Change subject: Hygiene: simplify most-read-filter.filterBotTraffic()
..
Hygiene: simplify most-read-filter.filterBotTraffic()
Change-I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330616 )
Change subject: Chore: update JSDoc param & return value nullity
..
Chore: update JSDoc param & return value nullity
As reported by `rg
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330583 )
Change subject: Hygiene: update api.checkResponseStatus() to allow promise
chaining
..
Hygiene: update api.checkResponseStatus() to all
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330233 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/328292 )
Change subject: Update: auto-sync Wikipedia Android and iOS apps
..
Update: auto-sync Wikipedia Android and iOS apps
• Automatically sy
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/328215 )
Change subject: Fix: make DescriptionEditHelpViewTest @SmallTest
..
Fix: make DescriptionEditHelpViewTest @SmallTest
Change-Id: Id2b8f2
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/328214 )
Change subject: Fix: ArticleHeaderViewTest screenshots
..
Fix: ArticleHeaderViewTest screenshots
ArticleHeaderView was updated but the
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/328188 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327655 )
Change subject: Fix: ArticleHeaderView leading and add LeadingSpanTest
..
Fix: ArticleHeaderView leading and add LeadingSpanTest
Bug: T
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327567 )
Change subject: Hygiene: don't constrain article header title height
..
Hygiene: don't constrain article header title height
This code
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327427 )
Change subject: Hygiene: add AppTextViewTest
..
Hygiene: add AppTextViewTest
This tests shows that simple usage doesn't cause incorrect
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326463 )
Change subject: Hygiene: add script for testing translations
..
Hygiene: add script for testing translations
This script isn't wired to
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326455 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326192 )
Change subject: WIP: Allow hacks.less inclusion to be configurable
..
WIP: Allow hacks.less inclusion to be configurable
Add a configur
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326172 )
Change subject: Demo: refactor description edit tutorial page views
..
Demo: refactor description edit tutorial page views
Bug: T148205
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326063 )
Change subject: Fix: update DescriptionEditSuccessViewTest screenshots
..
Fix: update DescriptionEditSuccessViewTest screenshots
These
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326056 )
Change subject: Update: SDK Build Tools to v25.0.1
..
Update: SDK Build Tools to v25.0.1
https://developer.android.com/studio/releases/
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326055 )
Change subject: Hygiene: fix or suppress miscellaneous lint
..
Hygiene: fix or suppress miscellaneous lint
Change-Id: Ib0fdf6a5e79b377f
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326054 )
Change subject: Hygiene: move lint rules to lint config
..
Hygiene: move lint rules to lint config
Also exclude the Facebook directory
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325987 )
Change subject: Hygiene: fix or suppress miscellaneous lint
..
Hygiene: fix or suppress miscellaneous lint
Change-Id: Iadd5b34119aa7ffa
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325982 )
Change subject: Hygiene: make ActionBarActivity exception handling more specific
..
Hygiene: make ActionBarActivity exception handling m
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325981 )
Change subject: Hygiene: simplify SingleFragmentActivityWithToolbar name
..
Hygiene: simplify SingleFragmentActivityWithToolbar name
Ch
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325954 )
Change subject: Demo: encapsulate DescriptionEditTutorialPageView children
(clone)
..
Demo: encapsulate DescriptionEditTutorialPageView
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325859 )
Change subject: Demo: encapsulate DescriptionEditTutorialPageView children
..
Demo: encapsulate DescriptionEditTutorialPageView children
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325709
Change subject: Hygiene: improve ESLint configuration
..
Hygiene: improve ESLint configuration
• Lint everything not in .eslintignore
• L
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325700
Change subject: Hygiene: move Mocha ESLint environment from tests to config
..
Hygiene: move Mocha ESLint environment from tests to config
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325698
Change subject: Chore: limit ESlint suppression
..
Chore: limit ESlint suppression
find test -iname \*.js|
xargs -rd\\n sed -ri '/no-
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325697
Change subject: Chore: add script to update test news sites
..
Chore: add script to update test news sites
Change-Id: I91624639a2c3f0a65c
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325612
Change subject: Update: add screenshot tests to AppTextViewWithImagesTest
..
Update: add screenshot tests to AppTextViewWithImagesTest
Bu
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325613
Change subject: Fix: AppTextViewWithImages spannable boundaries
..
Fix: AppTextViewWithImages spannable boundaries
Bug: T152141
Change-Id
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325586
Change subject: Fix: ListCardViewTest
..
Fix: ListCardViewTest
This test wasn't marked @SmallTest and so wasn't executed in CI. Fix and
e
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325580
Change subject: Fix: CardLargeHeaderViewTest
..
Fix: CardLargeHeaderViewTest
I'm not sure why this error wasn't seen in CI.
Change-Id: I
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325581
Change subject: Fix: PageTitleListCardItemViewTest
..
Fix: PageTitleListCardItemViewTest
This test wasn't marked @SmallTest and so wasn't
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325578
Change subject: Fix: PasswordTextInputTest
..
Fix: PasswordTextInputTest
This test wasn't marked @SmallTest and so wasn't executed in CI.
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325582
Change subject: Fix: enable tests in CI
..
Fix: enable tests in CI
The periodic CI job only executes tests annotated @SmallTest. Update
a
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325579
Change subject: Fix: BecauseYouReadCardViewTest
..
Fix: BecauseYouReadCardViewTest
This test wasn't marked @SmallTest and so wasn't execu
401 - 500 of 1372 matches
Mail list logo
