[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix select arrow overlapping contents

2017-12-15 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398550 ) Change subject: Fix select arrow overlapping contents .. Fix select arrow overlapping contents Fix select arrow to not overlap contents

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Tweak informationsharing message to be more upfront

2017-12-11 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397637 ) Change subject: Tweak informationsharing message to be more upfront .. Tweak informationsharing message to be more upfront Move "We do not

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Restyle payments forms

2017-11-23 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393096 ) Change subject: Restyle payments forms .. Restyle payments forms There are various inconsistencies and problems with the current payments

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix card type selection spacing on mobile

2017-11-20 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392536 ) Change subject: Fix card type selection spacing on mobile .. Fix card type selection spacing on mobile Fix - card types wrapping onto new

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Don't load CentralNotice on history or diff pages

2017-09-26 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380891 ) Change subject: Don't load CentralNotice on history or diff pages .. Don't load CentralNotice on history or diff pages History and diff

[MediaWiki-commits] [Gerrit] mediawiki...Petition[master]: Do not cache Special:Petition when transcluded

2017-09-25 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380560 ) Change subject: Do not cache Special:Petition when transcluded .. Do not cache Special:Petition when transcluded rMW7730dee63b1d means

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix Adyen iframe field styles on iOS

2017-09-21 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379665 ) Change subject: Fix Adyen iframe field styles on iOS .. Fix Adyen iframe field styles on iOS It seems the max-device-width media query is

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Don't select a submethod if there are errors in personal info

2017-08-24 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373704 ) Change subject: Don't select a submethod if there are errors in personal info .. Don't select a submethod if there are errors in personal

[MediaWiki-commits] [Gerrit] Update Spanish TY letter - change (wikimedia...crm)

2016-05-17 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Update Spanish TY letter .. Update Spanish TY letter Bug: T134489 Change-Id: I97d2cc1f5440f026d46aa7295c609bcba7dc5ed1 --- M

[MediaWiki-commits] [Gerrit] Thank You letters for executive director transition - change (wikimedia...crm)

2016-03-14 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Thank You letters for executive director transition .. Thank You letters for executive director transition Bug: T129373 Change-Id:

[MediaWiki-commits] [Gerrit] Update WMF's mailing address in thank-you letter - change (wikimedia...crm)

2015-12-09 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Update WMF's mailing address in thank-you letter .. Update WMF's mailing address in thank-you letter Bug: T120877 Change-Id:

[MediaWiki-commits] [Gerrit] Remove whitebox wiki template from forms - change (mediawiki...DonationInterface)

2015-11-24 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/255280 Change subject: Remove whitebox wiki template from forms .. Remove whitebox wiki template from forms Remove the whitebox wiki template [1]

[MediaWiki-commits] [Gerrit] More updates to the French thank-you template - change (wikimedia...crm)

2015-10-20 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: More updates to the French thank-you template .. More updates to the French thank-you template Bug: T115496 Change-Id:

[MediaWiki-commits] [Gerrit] Make "JimmyQuote" default appeal - change (mediawiki...DonationInterface)

2015-09-29 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/242169 Change subject: Make "JimmyQuote" default appeal .. Make "JimmyQuote" default appeal Currently the default appeal if nothing is specified in

[MediaWiki-commits] [Gerrit] Update pt-br thank you letter - change (wikimedia...crm)

2015-08-14 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Update pt-br thank you letter .. Update pt-br thank you letter Bug: T108703 Change-Id: Ie35e8683e5d00e2c870fc06a0f3417297a578b0c --- M

[MediaWiki-commits] [Gerrit] Correct recurring info text again - change (mediawiki...DonationInterface)

2015-04-28 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/207180 Change subject: Correct recurring info text again .. Correct recurring info text again Previous change should have had donors in place of

[MediaWiki-commits] [Gerrit] Correct recurring info text - change (mediawiki...DonationInterface)

2015-04-22 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/205849 Change subject: Correct recurring info text .. Correct recurring info text It was requested that we have For recurring donations at the

[MediaWiki-commits] [Gerrit] Change English error messages - change (mediawiki...DonationInterface)

2015-04-17 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/204798 Change subject: Change English error messages .. Change English error messages Change English error messages as requested by donor services

[MediaWiki-commits] [Gerrit] Change recurring info text for new legal requirements - change (mediawiki...DonationInterface)

2015-04-09 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/203041 Change subject: Change recurring info text for new legal requirements .. Change recurring info text for new legal requirements Europe now

[MediaWiki-commits] [Gerrit] Correct language code for Norwegian aggregation - change (wikimedia...DjangoBannerStats)

2015-03-12 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/195612 Change subject: Correct language code for Norwegian aggregation .. Correct language code for Norwegian aggregation Language code for

[MediaWiki-commits] [Gerrit] Minutely improve multiselect load issue - change (mediawiki...CentralNotice)

2015-03-02 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Minutely improve multiselect load issue .. Minutely improve multiselect load issue Probably won't change a thing. But I feel like it improves our odds by a

[MediaWiki-commits] [Gerrit] New thank you translation: sv - change (wikimedia...crm)

2015-02-20 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: New thank you translation: sv .. New thank you translation: sv Bug: T89611 Change-Id: I0a5da05d311dbe64e3d71a2317f48344b6d7498a --- M

[MediaWiki-commits] [Gerrit] Don't apply new input styles to radio buttons - change (mediawiki...DonationInterface)

2014-12-23 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/181622 Change subject: Don't apply new input styles to radio buttons .. Don't apply new input styles to radio buttons Applying the new input styles

[MediaWiki-commits] [Gerrit] (TR #2121) fr and he TY updates - change (wikimedia...crm)

2014-12-19 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: (TR #2121) fr and he TY updates .. (TR #2121) fr and he TY updates Change-Id: Ibe6ce2241ccd90862a48f4702b7d10fb9b165968 --- M

[MediaWiki-commits] [Gerrit] Legal-recommended update to English TY text - change (wikimedia...crm)

2014-12-10 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Legal-recommended update to English TY text .. Legal-recommended update to English TY text Change-Id: I5a03d63cde399b73ff212cbfd85dec2ced84f50b --- M

[MediaWiki-commits] [Gerrit] Stop clobbering reason from alterImpressionData - change (mediawiki...CentralNotice)

2014-11-19 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Stop clobbering reason from alterImpressionData .. Stop clobbering reason from alterImpressionData My last change to impression recording overwrote reasons

[MediaWiki-commits] [Gerrit] Matching gifts added to the English letter again - change (wikimedia...crm)

2014-10-10 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Matching gifts added to the English letter again .. Matching gifts added to the English letter again Change-Id: Ic3fb0bae0f4595da92937fdf6a74980ebfa5cb99 ---

[MediaWiki-commits] [Gerrit] One TY translation. - change (wikimedia...crm)

2014-10-07 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: One TY translation. .. One TY translation. Change-Id: Icc9a65ee0a7bd447db044d5f1692fc8d8b7e49f7 --- M

[MediaWiki-commits] [Gerrit] Priority languages for UnrecordedCharge mailing - change (wikimedia...crm)

2014-09-22 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Priority languages for UnrecordedCharge mailing .. Priority languages for UnrecordedCharge mailing Change-Id: Idcd9e160f30ab0d2de1a59caa0b7f8971a4aebf9 --- M

[MediaWiki-commits] [Gerrit] Remove non-existent column from Special:PetitionData download - change (mediawiki...Petition)

2014-07-16 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/146763 Change subject: Remove non-existent column from Special:PetitionData download .. Remove non-existent column from Special:PetitionData

[MediaWiki-commits] [Gerrit] Add a petitiondata group with the right view-petition-data - change (mediawiki...Petition)

2014-07-16 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/146904 Change subject: Add a petitiondata group with the right view-petition-data .. Add a petitiondata group with the right view-petition-data Add

[MediaWiki-commits] [Gerrit] Disable caching of petition CSV download - change (mediawiki...Petition)

2014-07-16 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/146970 Change subject: Disable caching of petition CSV download .. Disable caching of petition CSV download Set headers to explicitly disable

[MediaWiki-commits] [Gerrit] Add logging for signatures, and integration with CheckUser - change (mediawiki...Petition)

2014-07-10 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/145435 Change subject: Add logging for signatures, and integration with CheckUser .. Add logging for signatures, and integration with CheckUser

[MediaWiki-commits] [Gerrit] Store number of signatures count in memcached - change (mediawiki...Petition)

2014-07-04 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/144174 Change subject: Store number of signatures count in memcached .. Store number of signatures count in memcached Store the number of

[MediaWiki-commits] [Gerrit] Add rate limiting - change (mediawiki...Petition)

2014-07-03 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/144074 Change subject: Add rate limiting .. Add rate limiting Add rate limiting to saving petitions, using same settings as for edit action. Bug:

[MediaWiki-commits] [Gerrit] new translations - change (wikimedia...crm)

2014-07-02 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: new translations .. new translations Change-Id: I77d19f058a26f5417ec0ee410077d88a436dffd5 --- M sites/all/modules/thank_you/templates/html/thank_you.he.html

[MediaWiki-commits] [Gerrit] new translations - change (wikimedia...crm)

2014-07-02 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: new translations .. new translations Change-Id: I77d19f058a26f5417ec0ee410077d88a436dffd5 --- M sites/all/modules/thank_you/templates/html/thank_you.he.html

[MediaWiki-commits] [Gerrit] Convert from tag to includable special page, revamp tracking - change (mediawiki...Petition)

2014-06-27 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/142561 Change subject: Convert from tag to includable special page, revamp tracking .. Convert from tag to includable special page, revamp tracking

[MediaWiki-commits] [Gerrit] Prevent blocked users from signing petitions - change (mediawiki...Petition)

2014-06-27 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/142737 Change subject: Prevent blocked users from signing petitions .. Prevent blocked users from signing petitions Bug: 65850 Change-Id:

[MediaWiki-commits] [Gerrit] A few small timestamp fixes/cleanups - change (mediawiki...Petition)

2014-06-12 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: A few small timestamp fixes/cleanups .. A few small timestamp fixes/cleanups Change-Id: I852e2be5ee098e7bafd3207c25dc4dd43f2c2e72 --- M

[MediaWiki-commits] [Gerrit] When getting number of signatures, count on indexed column - change (mediawiki...Petition)

2014-06-12 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/139126 Change subject: When getting number of signatures, count on indexed column .. When getting number of signatures, count on indexed column

[MediaWiki-commits] [Gerrit] Escape equals signs in csv output - change (mediawiki...Petition)

2014-06-12 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/139285 Change subject: Escape equals signs in csv output .. Escape equals signs in csv output Escape equals signs at the start of fields in csv

[MediaWiki-commits] [Gerrit] Escape number of signatures - change (mediawiki...Petition)

2014-06-12 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/139286 Change subject: Escape number of signatures .. Escape number of signatures Escape number of signatures for output, just in case we change

[MediaWiki-commits] [Gerrit] New TY translations for ca, es, sv - change (wikimedia...crm)

2014-06-11 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: New TY translations for ca, es, sv .. New TY translations for ca, es, sv Change-Id: Ic6d1cfccffc32b4297d64e911d31ae61c445024f --- M

[MediaWiki-commits] [Gerrit] Fix table setup to support SQLite - change (mediawiki...Petition)

2014-05-21 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/134604 Change subject: Fix table setup to support SQLite .. Fix table setup to support SQLite SQLite requires pt_id to be set as primary key when

[MediaWiki-commits] [Gerrit] Store the title of the page the petition was on too - change (mediawiki...Petition)

2014-05-02 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/131242 Change subject: Store the title of the page the petition was on too .. Store the title of the page the petition was on too Add another

[MediaWiki-commits] [Gerrit] Add pattern to US zip code input, to trigger numeric keypad ... - change (mediawiki...DonationInterface)

2014-04-23 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/129181 Change subject: Add pattern to US zip code input, to trigger numeric keypad on iOS .. Add pattern to US zip code input, to trigger numeric

[MediaWiki-commits] [Gerrit] HTMLForm: fix double escaping of checkbox labels in vform - change (mediawiki/core)

2014-04-15 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/126004 Change subject: HTMLForm: fix double escaping of checkbox labels in vform .. HTMLForm: fix double escaping of checkbox labels in vform

[MediaWiki-commits] [Gerrit] Commit work so far - change (mediawiki...Petition)

2014-04-15 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/126011 Change subject: Commit work so far .. Commit work so far Change-Id: I71a02cbef620b57d197237cbd27b31a7b1f07eb7 --- A Petition.i18n.php A

[MediaWiki-commits] [Gerrit] update Thank You templates - change (wikimedia...crm)

2014-04-03 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: update Thank You templates .. update Thank You templates Change-Id: I4f1a25061cdf9a3737129e4bbad802608fd04207 --- M

[MediaWiki-commits] [Gerrit] Change email address inputs in GC forms to use type=email - change (mediawiki...DonationInterface)

2014-03-28 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/121690 Change subject: Change email address inputs in GC forms to use type=email .. Change email address inputs in GC forms to use type=email Use

[MediaWiki-commits] [Gerrit] Add Malay and Ukrainian to detail_languages for aggregation - change (wikimedia...DjangoBannerStats)

2014-03-20 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/119740 Change subject: Add Malay and Ukrainian to detail_languages for aggregation .. Add Malay and Ukrainian to detail_languages for aggregation

[MediaWiki-commits] [Gerrit] iDeal and Sofort forms - change amount options to match what... - change (mediawiki...DonationInterface)

2014-03-20 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/119775 Change subject: iDeal and Sofort forms - change amount options to match what we now use elsewhere .. iDeal and Sofort forms - change amount

[MediaWiki-commits] [Gerrit] Thank you messages - change (wikimedia...crm)

2014-03-13 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Thank you messages .. Thank you messages Change-Id: Id1f43f1225b58426d3e1508f1a2d35e40f5d0a0d --- M

[MediaWiki-commits] [Gerrit] Catalan and Spanish TY translation updates - change (wikimedia...crm)

2014-03-09 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Catalan and Spanish TY translation updates .. Catalan and Spanish TY translation updates Deleting the Spanish-Spain variant for the current campaign, since

[MediaWiki-commits] [Gerrit] Updating thank you templates - change (wikimedia...crm)

2014-02-13 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Updating thank you templates .. Updating thank you templates Change-Id: I671a3921083d2e90f1aaa98d35cc9770cce677b9 --- M

[MediaWiki-commits] [Gerrit] Updated thank you translations - change (wikimedia...crm)

2014-02-10 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Updated thank you translations .. Updated thank you translations Change-Id: I5264f5ba94bb3c4e1d651bf64a0b61c557317613 --- M

[MediaWiki-commits] [Gerrit] Updating fi language - change (wikimedia...crm)

2014-02-06 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Updating fi language .. Updating fi language Change-Id: I8c1b6a9970f932ad220e563f62056d72f9899724 --- M

[MediaWiki-commits] [Gerrit] Updating thank you zh message - change (wikimedia...crm)

2014-02-06 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Updating thank you zh message .. Updating thank you zh message Change-Id: I6ece74bf6fd43438097cdb7a8e24d8f25d63a7e0 --- M

[MediaWiki-commits] [Gerrit] Hand fixing names in zh varients - change (wikimedia...crm)

2014-02-06 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Hand fixing names in zh varients .. Hand fixing names in zh varients Change-Id: I499ba7e1b40ef1d75e91849af752903340d142cf --- M

[MediaWiki-commits] [Gerrit] Move silverpop_export into new directory, and add supporting... - change (wikimedia...tools)

2014-01-20 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/108528 Change subject: Move silverpop_export into new directory, and add supporting files. update.sh is the script to run for usual updates. ..

[MediaWiki-commits] [Gerrit] Updating Thank You Templates - change (wikimedia...crm)

2013-08-16 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: Updating Thank You Templates .. Updating Thank You Templates Change-Id: I8430ab3550d6bb84cb8a0fb7a84ce828826fb258 --- M

[MediaWiki-commits] [Gerrit] update silverpop_export script - change (wikimedia...tools)

2013-07-25 Thread Pcoombe (Code Review)
Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/75918 Change subject: update silverpop_export script .. update silverpop_export script Change-Id: I074dd15470992b0427d39a5ea15a3da8c27ad42b --- M

[MediaWiki-commits] [Gerrit] update silverpop_export script - change (wikimedia...tools)

2013-07-25 Thread Pcoombe (Code Review)
Pcoombe has submitted this change and it was merged. Change subject: update silverpop_export script .. update silverpop_export script Change-Id: I074dd15470992b0427d39a5ea15a3da8c27ad42b --- M silverpop_export.sql 1 file