[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Don't use deprecated DatabaseMysql

2018-01-17 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404712 ) Change subject: Don't use deprecated DatabaseMysql .. Don't use deprecated DatabaseMysql Bug: T120333 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...OdbcDatabase[master]: Don't use deprecated DatabaseMysql

2018-01-16 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404543 ) Change subject: Don't use deprecated DatabaseMysql .. Don't use deprecated DatabaseMysql Bug: T120333 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Don't use deprecated DatabaseMysql

2018-01-16 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404541 ) Change subject: Don't use deprecated DatabaseMysql .. Don't use deprecated DatabaseMysql Bug: T120333 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove support for PHP extension 'mysql' (not mysqli!)

2018-01-16 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404523 ) Change subject: Remove support for PHP extension 'mysql' (not mysqli!) .. Remove support for PHP extension 'mysql' (not mysqli!) This PHP

[MediaWiki-commits] [Gerrit] mediawiki...ApprovedRevs[master]: Error when displaying a blank page

2018-01-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404167 ) Change subject: Error when displaying a blank page .. Error when displaying a blank page When the content is set to blank for unapproved

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improve discoverability of $wgMediaWikiFarmSyslog

2017-12-04 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394993 ) Change subject: Improve discoverability of $wgMediaWikiFarmSyslog .. Improve discoverability of $wgMediaWikiFarmSyslog Particularly for

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Alternative declaration of wikis for small setups

2017-12-04 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394974 ) Change subject: Alternative declaration of wikis for small setups .. Alternative declaration of wikis for small setups This was suggested in

[MediaWiki-commits] [Gerrit] mediawiki...Arrays[master]: Use dedicated functions for i18n

2017-11-29 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394032 ) Change subject: Use dedicated functions for i18n .. Use dedicated functions for i18n A specific call triggers a 'Sessions are disabled for

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Cancel button returns Undefined error

2017-11-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393282 ) Change subject: Cancel button returns Undefined error .. Cancel button returns Undefined error The associated HTML changed in MediaWiki

[MediaWiki-commits] [Gerrit] mediawiki...HitCounters[master]: Fix {{NUMBEROFVIEWS}} in MediaWiki 1.29

2017-11-22 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393010 ) Change subject: Fix {{NUMBEROFVIEWS}} in MediaWiki 1.29 .. Fix {{NUMBEROFVIEWS}} in MediaWiki 1.29 The function

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Enumerate all known wikis

2017-09-28 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381236 ) Change subject: Enumerate all known wikis .. Enumerate all known wikis A CLI script is added to output the list of wikis known by

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: New function readAnyFile to read a file with any extension

2017-09-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380394 ) Change subject: New function readAnyFile to read a file with any extension .. New function readAnyFile to read a file with any extension

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Always check Composer extensions independantly of ExtensionR...

2017-09-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380317 ) Change subject: Always check Composer extensions independantly of ExtensionRegistration .. Always check Composer extensions independantly of

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug: Relaunch the tests before 5 minutes removed some coverage

2017-09-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380315 ) Change subject: Bug: Relaunch the tests before 5 minutes removed some coverage .. Bug: Relaunch the tests before 5 minutes removed some

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug: Composer extensions were no more loaded

2017-09-23 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380002 ) Change subject: Bug: Composer extensions were no more loaded .. Bug: Composer extensions were no more loaded When fixing T168807 in 442efe5,

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add LICENSE

2017-09-23 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379969 ) Change subject: Add LICENSE .. Add LICENSE Bug: T123943 Change-Id: If1285cc848734b24f579190ae03d1e22d1f8aa1e --- A LICENSE 1 file changed,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve GitInfo for reading packed refs

2017-09-15 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378223 ) Change subject: Improve GitInfo for reading packed refs .. Improve GitInfo for reading packed refs GitInfo only reads branches in files

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improved reading of config files

2017-09-10 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377055 ) Change subject: Improved reading of config files .. Improved reading of config files 1. The cached files are always prefered over the origin

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix MW-CS to a fixed version

2017-09-02 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375542 ) Change subject: Fix MW-CS to a fixed version .. Fix MW-CS to a fixed version Change-Id: I9c0c6dc09b07100f3d2b64be27f301dcc0b98c6b --- M

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Use xxx.php as an alias of maintenance/xxx.php

2017-09-01 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375374 ) Change subject: Use xxx.php as an alias of maintenance/xxx.php .. Use xxx.php as an alias of maintenance/xxx.php Previously only xxx was an

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Always verify an extension exists, even if the mechanism is ...

2017-08-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374034 ) Change subject: Always verify an extension exists, even if the mechanism is forced .. Always verify an extension exists, even if the

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug: a Composer extension could not be deactivated

2017-08-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374031 ) Change subject: Bug: a Composer extension could not be deactivated .. Bug: a Composer extension could not be deactivated In the case of a

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Split out utilitary functions into dedicated classes

2017-08-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373941 ) Change subject: Split out utilitary functions into dedicated classes .. Split out utilitary functions into dedicated classes This reduces

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Move classes for scripts from ./src to ./src/bin

2017-08-22 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373105 ) Change subject: Move classes for scripts from ./src to ./src/bin .. Move classes for scripts from ./src to ./src/bin - …and the same for the

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Small bug during logging

2017-08-22 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373034 ) Change subject: Small bug during logging .. Small bug during logging Missing global scope during configuration of logging in scripts, hence

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Define more precisely the set of existing wikis

2017-08-21 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372884 ) Change subject: Define more precisely the set of existing wikis .. Define more precisely the set of existing wikis Given there are two

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Update coding rules according to phpcs

2017-08-19 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372757 ) Change subject: Update coding rules according to phpcs .. Update coding rules according to phpcs Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: phpcs.xml: Escape . in exclude-pattern

2017-08-07 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367485 ) Change subject: phpcs.xml: Escape . in exclude-pattern .. phpcs.xml: Escape . in exclude-pattern See T129664 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: gitignore for the Composer files

2017-08-05 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370360 ) Change subject: gitignore for the Composer files .. gitignore for the Composer files Change-Id: I669685e653a5d8b65421494aae3e745f1c144298

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add logging for exceptions inside DerrableUpdate

2017-06-27 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361787 ) Change subject: Add logging for exceptions inside DerrableUpdate .. Add logging for exceptions inside DerrableUpdate Bug: T168347 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add support for wgExtensionDirectory and wgStyleDirectory

2017-06-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361388 ) Change subject: Add support for wgExtensionDirectory and wgStyleDirectory .. Add support for wgExtensionDirectory and wgStyleDirectory By

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Execute scripts when wikis are path-based

2017-06-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361302 ) Change subject: Execute scripts when wikis are path-based .. Execute scripts when wikis are path-based Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Make DeferredUpdates detect LBFactory transaction rounds

2017-06-12 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358461 ) Change subject: Make DeferredUpdates detect LBFactory transaction rounds .. Make DeferredUpdates detect LBFactory transaction rounds

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Use AutoCommitUpdate instead of Database->onTransactionIdle

2017-06-07 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357561 ) Change subject: Use AutoCommitUpdate instead of Database->onTransactionIdle .. Use AutoCommitUpdate instead of Database->onTransactionIdle

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Use AutoCommitUpdate instead of Database->onTransactionIdle

2017-06-07 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357560 ) Change subject: Use AutoCommitUpdate instead of Database->onTransactionIdle .. Use AutoCommitUpdate instead of Database->onTransactionIdle

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Better handling of jobs execution in post-connection shutdown

2017-06-02 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356887 ) Change subject: Better handling of jobs execution in post-connection shutdown .. Better handling of jobs execution in post-connection

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Better handling of jobs execution in post-connection shutdown

2017-06-02 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356880 ) Change subject: Better handling of jobs execution in post-connection shutdown .. Better handling of jobs execution in post-connection

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Better handling of jobs execution in post-connection shutdown

2017-06-02 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356799 ) Change subject: Better handling of jobs execution in post-connection shutdown .. Better handling of jobs execution in post-connection

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use AtomicSectionUpdate instead of Database->onTransactionIdle

2017-06-01 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356619 ) Change subject: Use AtomicSectionUpdate instead of Database->onTransactionIdle .. Use AtomicSectionUpdate instead of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: More properly close MediaWiki jobs

2017-05-29 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356120 ) Change subject: More properly close MediaWiki jobs .. More properly close MediaWiki jobs In the postprocessing, some jobs can be executed

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Refactoring: extraction of configuration compilation

2017-05-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355633 ) Change subject: Refactoring: extraction of configuration compilation .. Refactoring: extraction of configuration compilation The main class

[MediaWiki-commits] [Gerrit] mediawiki...Flow[REL1_28]: Fix warnings and bugs in generateForwardedCookieForCli()

2017-05-22 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355088 ) Change subject: Fix warnings and bugs in generateForwardedCookieForCli() .. Fix warnings and bugs in generateForwardedCookieForCli()

[MediaWiki-commits] [Gerrit] mediawiki...SecureSessions[master]: Better escaping

2017-05-21 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354999 ) Change subject: Better escaping .. Better escaping In French, the special page Session displays " Adresse IP: " because of a parser rule +

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: [i18n] Names of the new content models

2017-05-19 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354543 ) Change subject: [i18n] Names of the new content models .. [i18n] Names of the new content models Bug: T155520 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Typo

2017-04-23 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349794 ) Change subject: Typo .. Typo And added some missing parameter to make it explicit instead of implicit. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improve cache consistency

2017-04-23 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349785 ) Change subject: Improve cache consistency .. Improve cache consistency * Check if origin file is still present, else cache is considered

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add a timeout in wfShellExec

2017-04-10 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347417 ) Change subject: Add a timeout in wfShellExec .. Add a timeout in wfShellExec In wfShellExec the function stream_select waits indefinitely

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Prevent PHPDBG from issuing notices in unit tests

2017-04-10 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347355 ) Change subject: Prevent PHPDBG from issuing notices in unit tests .. Prevent PHPDBG from issuing notices in unit tests Although issuing PHP

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Execute mwcomposer just like composer

2017-04-09 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347222 ) Change subject: Execute mwcomposer just like composer .. Execute mwcomposer just like composer Previously mwcomposer selected the directory

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: [WIP] Support for farms given by subdirectories in addition ...

2017-03-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344881 ) Change subject: [WIP] Support for farms given by subdirectories in addition of subdomains .. [WIP] Support for farms given by subdirectories

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Wrong PHP version for phpDocumentor2

2017-03-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344831 ) Change subject: Wrong PHP version for phpDocumentor2 .. Wrong PHP version for phpDocumentor2 Obviously I carefully crafted the previous

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Documentation and heavy testing

2017-03-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344830 ) Change subject: Documentation and heavy testing .. Documentation and heavy testing Documentation: * Configured phpDocumentor2 to report

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Exclude .git in phpcs.xml instead of command line argument

2017-03-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344797 ) Change subject: Exclude .git in phpcs.xml instead of command line argument .. Exclude .git in phpcs.xml instead of command line argument In

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Restore 100% code coverage

2017-03-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344784 ) Change subject: Restore 100% code coverage .. Restore 100% code coverage Change-Id: I0adbef2d9113679b4793b41beb7a92621db198cc --- M

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug when a mwcomposer was used but no Composer-managed e...

2017-03-25 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344781 ) Change subject: Fix bug when a mwcomposer was used but no Composer-managed extension is activated .. Fix bug when a mwcomposer was

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug when a mwcomposer was used but no Composer-managed e...

2017-03-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344781 ) Change subject: Fix bug when a mwcomposer was used but no Composer-managed extension is activated .. Fix bug when a mwcomposer was used but

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug about empty lists/objects in composer.json

2017-03-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344766 ) Change subject: Fix bug about empty lists/objects in composer.json .. Fix bug about empty lists/objects in composer.json During installation

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Ignore directory .git in PHP_CodeSniffer

2017-03-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344610 ) Change subject: Ignore directory .git in PHP_CodeSniffer .. Ignore directory .git in PHP_CodeSniffer Unfortunately I have a local branch

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Move the hook onUnitTestsList on a separate file

2017-03-24 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344607 ) Change subject: Move the hook onUnitTestsList on a separate file .. Move the hook onUnitTestsList on a separate file It is not useful it

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Documentation

2017-03-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342762 ) Change subject: Documentation .. Documentation Fix phpDoc errors Change-Id: I2142530d4c811b28156f2f331c94a21cf1c1149e --- M

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: A log was a false positive

2017-03-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342674 ) Change subject: A log was a false positive .. A log was a false positive This log message says an extension is requested but missing; in the

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Forgot default value for the new config parameter

2017-03-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342628 ) Change subject: Forgot default value for the new config parameter .. Forgot default value for the new config parameter Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add a logging infrastructure

2017-03-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342620 ) Change subject: Add a logging infrastructure .. Add a logging infrastructure Some errors and exceptions were already collected but not

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug when autoloading Composer without MediaWikiFarm

2017-02-03 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335789 ) Change subject: Fix bug when autoloading Composer without MediaWikiFarm .. Fix bug when autoloading Composer without MediaWikiFarm Sometimes

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix timestamp format in maintenance/manageJobs.php

2017-02-02 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335636 ) Change subject: Fix timestamp format in maintenance/manageJobs.php .. Fix timestamp format in maintenance/manageJobs.php Follow-up of

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: l10n: Tamil namespaces

2017-01-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332065 ) Change subject: l10n: Tamil namespaces .. l10n: Tamil namespaces Bug: T142287 Change-Id: Ib46d530b301516b44976b65996a51a2b2fc9a6d1 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: i18n: Add some messages

2017-01-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332052 ) Change subject: i18n: Add some messages .. i18n: Add some messages The messages for translating the tab were missing, better is to declare

[MediaWiki-commits] [Gerrit] mediawiki...WikiLexicalData[master]: Use getter instead of property

2017-01-14 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332043 ) Change subject: Use getter instead of property .. Use getter instead of property TextContent has the dedicated getter getNativeData() to

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Fix the ProofreadPage’s VisualEditor

2017-01-11 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331800 ) Change subject: Fix the ProofreadPage’s VisualEditor .. Fix the ProofreadPage’s VisualEditor The ProofreadPage’s VisualEditor was broken

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: [WIP] Use the parser to get each template parameter in the I...

2017-01-11 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331643 ) Change subject: [WIP] Use the parser to get each template parameter in the Index: namespace .. [WIP] Use the parser to get each template

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Replace mocks of DatabaseMysql by DatabaseMysqli

2016-12-31 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329764 ) Change subject: Replace mocks of DatabaseMysql by DatabaseMysqli .. Replace mocks of DatabaseMysql by DatabaseMysqli The class DatabaseMysql

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Soft deprecation of DatabaseMysql

2016-12-30 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329682 ) Change subject: Soft deprecation of DatabaseMysql .. Soft deprecation of DatabaseMysql This class is the driver for MySQL databases

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug in the previous commit in multiversion mode

2016-12-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329225 ) Change subject: Bug in the previous commit in multiversion mode .. Bug in the previous commit in multiversion mode Bugs: * When running farm

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Change internal data structure for extensions

2016-12-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329223 ) Change subject: Change internal data structure for extensions .. Change internal data structure for extensions Architecture: * Previously

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: [WIP] Activate Composer extensions in the same way than othe...

2016-12-20 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328347 ) Change subject: [WIP] Activate Composer extensions in the same way than other extensions are activated .. [WIP] Activate Composer extensions

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug monoversion installation, maintenance

2016-12-17 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327915 ) Change subject: Bug monoversion installation, maintenance .. Bug monoversion installation, maintenance Bugs: * Monoversion installation was

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: The automatic test in MediaWikiTestCase was marked as risky

2016-12-11 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326363 ) Change subject: The automatic test in MediaWikiTestCase was marked as risky .. The automatic test in MediaWikiTestCase was marked as risky

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Refactoring of the cache data architecture

2016-12-05 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/325306 Change subject: Refactoring of the cache data architecture .. Refactoring of the cache data architecture Architecture: * At the beginning

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Cleaning

2016-12-03 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Cleaning .. Cleaning Remove unused code, replaced by dedicated code since some time. Change-Id: Ida232cfde250c7f4bcc98dfea89bd8f5e40756c7 --- M

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Cleaning

2016-12-03 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/325130 Change subject: Cleaning .. Cleaning Remove unused code, replaced by dedicated code since some time. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Special config case

2016-12-03 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Special config case .. Special config case In the special case where the config key is a single wiki, the config file does not have a 'parameter-wiki-value'

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Special config case

2016-12-03 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/325127 Change subject: Special config case .. Special config case In the special case where the config key is a single wiki, the config file does not

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improve testing

2016-12-01 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/324693 Change subject: Improve testing .. Improve testing * Instead of a hacky 'sed -i' in composer.json, dynamically declare the class

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add phpunit/phpunit 4.8.x to require-dev

2016-12-01 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Add phpunit/phpunit 4.8.x to require-dev .. Add phpunit/phpunit 4.8.x to require-dev Lets one use composer install && composer unit when PHPUnit is not

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmAccount[master]: Fix PHP notice 'Only variables should be assigned by reference'

2016-11-30 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/324515 Change subject: Fix PHP notice 'Only variables should be assigned by reference' .. Fix PHP notice 'Only variables should be assigned by

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmAccount[REL1_26]: Fix permission denied

2016-11-27 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/323688 Change subject: Fix permission denied .. Fix permission denied Related to talk page https://www.mediawiki.org/wiki/Topic:Sf6zgc7plebtit4v

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug introduced in the previous commit, optimisations

2016-11-20 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/322503 Change subject: Fix bug introduced in the previous commit, optimisations .. Fix bug introduced in the previous commit, optimisations Bugs: *

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Added a mechanism to cache server name in the first step (se...

2016-11-19 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Added a mechanism to cache server name in the first step (server recognition) .. Added a mechanism to cache server name in the first step (server recognition)

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Added special configuration to force a loading mechanism

2016-11-13 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/321187 Change subject: Added special configuration to force a loading mechanism .. Added special configuration to force a loading mechanism Sometimes

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug: there was no more update of the cache when the origin f...

2016-11-13 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Bug: there was no more update of the cache when the origin file changed .. Bug: there was no more update of the cache when the origin file changed This worked

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Bug: there was no more update of the cache when the origin f...

2016-11-13 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/321171 Change subject: Bug: there was no more update of the cache when the origin file changed .. Bug: there was no more update of the cache when the

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Fix bug in auto-detecting server name

2016-10-05 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Fix bug in auto-detecting server name .. Fix bug in auto-detecting server name CLI scripts don’t have $_SERVER['HTTP_HOST'] and hence MediaWiki’s

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add standalone PHPUnit and make some tests more robust

2016-09-26 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Add standalone PHPUnit and make some tests more robust .. Add standalone PHPUnit and make some tests more robust Code: * Replaced the previous parameter

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Add standalone PHPUnit and make some tests more robust

2016-09-26 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/312968 Change subject: Add standalone PHPUnit and make some tests more robust .. Add standalone PHPUnit and make some tests more robust Code: *

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improvement of CLI scripts

2016-09-19 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Improvement of CLI scripts .. Improvement of CLI scripts Code: * In case of error, exit codes in CLI were wrongly the same as HTTP return codes, but exit

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Improvement of CLI scripts

2016-09-19 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/311624 Change subject: Improvement of CLI scripts .. Improvement of CLI scripts Code: * In case of error, exit codes in CLI were wrongly the same as

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Minor refactoring of CLI part

2016-09-16 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Minor refactoring of CLI part .. Minor refactoring of CLI part Code: * Create an abstract class AbstractMediaWikiFarmScript containing general-purpose

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Minor refactoring of CLI part

2016-09-16 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/311196 Change subject: Minor refactoring of CLI part .. Minor refactoring of CLI part Code: * Create an abstract class AbstractMediaWikiFarmScript

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Minor maintenance

2016-09-15 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Minor maintenance .. Minor maintenance Code: * An inherited method did not have the same signature. Code doc: * Fixed the some doc issues. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Minor maintenance

2016-09-15 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/310755 Change subject: Minor maintenance .. Minor maintenance Code: * An inherited method did not have the same signature. Code doc: * Fixed the

  1   2   3   >