Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297531
Change subject: Tweak Feed footer margins
..
Tweak Feed footer margins
Move save and share footer actions 6dp closer to the extract and
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297535
Change subject: Tweak Feed paragraph text
..
Tweak Feed paragraph text
Make paragraph text a darker #555 color, and size to 14sp with a
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297539
Change subject: Update Feed date format to "MMM DD, "
..
Update Feed date format to "MMM DD, "
Bug: T139382
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297825
Change subject: Tweak continue reading & because you read cards
..
Tweak continue reading & because you read cards
• Resize header and
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297826
Change subject: Hygiene: convert setOnClickListener() to @OnClick
..
Hygiene: convert setOnClickListener() to @OnClick
No functiona
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297812
Change subject: Allow for picture of the day without description
..
Allow for picture of the day without description
See also
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297811
Change subject: Don't return a picture of the day null description
..
Don't return a picture of the day null description
Sometimes
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298014
Change subject: Don't repeat news Feed card
..
Don't repeat news Feed card
Bug: T139480
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298009
Change subject: Limit read more queries to non-main pages
..
Limit read more queries to non-main pages
Bug: T139375
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297665
Change subject: Tweak Feed list card item UI
..
Tweak Feed list card item UI
• Titles are now a roman font with a color of #222 and 6dp
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297688
Change subject: Move test to JUnit v4
..
Move test to JUnit v4
• Update ImageUrlMapTests to use JUnit v4.
• Move ImageUrlMapTests to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297620
Change subject: Pad Feed cards not the RecyclerView
..
Pad Feed cards not the RecyclerView
When swiped left or right, Feed cards are
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297861
Change subject: Hygiene: rename page_activity to main_activity
..
Hygiene: rename page_activity to main_activity
Missed in f4bb28c. No
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297906
Change subject: Hygiene: remove unnecessary merge nodes
..
Hygiene: remove unnecessary merge nodes
• Remove needless merge nodes. Merge
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297918
Change subject: Hygiene: misc Feed clean up
..
Hygiene: misc Feed clean up
• Remove unused footers. These are currently unused and seem
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297920
Change subject: Remove Feed feature flag
..
Remove Feed feature flag
Feed is about production ready so always enable it and remove the
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297414
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298296
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296790
Change subject: Remove Feed demo card
..
Remove Feed demo card
Change-Id: I81b271e95b6f93448cc64e2d40940fd5c0613e1a
---
M
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296848
Change subject: Allow cards to be dimissed by swiping
..
Allow cards to be dimissed by swiping
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296667
Change subject: Use Norwegian Bokmål language code not wiki code
..
Use Norwegian Bokmål language code not wiki code
A follow up to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/29
Change subject: Update languages supported & namespace translation
..
Update languages supported & namespace translation
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296942
Change subject: Update Feed strings
..
Update Feed strings
• Promote experimental strings from no_translate and add qq
descriptions.
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297101
Change subject: Remove Feed "MostReadClient"
..
Remove Feed "MostReadClient"
Most read cards are available in the aggregated feed.
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296964
Change subject: Keep the Feed background from overlapping contents
..
Keep the Feed background from overlapping contents
When scrolling
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296392
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305268
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305341
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Icd7ceb3f67e069ff2c7c5ef0b157f1a080023bc0
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335568 )
Change subject: Hygiene: upgrade to Android Plugin for Gradle v2.2.3
..
Hygiene: upgrade to Android Plugin for Gradle v2.2.3
Already
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335718 )
Change subject: Fix: swap yellow90 and yellow30
..
Fix: swap yellow90 and yellow30
Bug: T139187
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335720 )
Change subject: add support for exact leading
..
add support for exact leading
Change-Id: I241adb3454087f1dc1148468474c4bebc852a067
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335719 )
Change subject: Update: page header subtitle leading
..
Update: page header subtitle leading
Reduce leading of page header subtitle
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335946 )
Change subject: Hygiene: upgrade to OkHttp 3.6.0
..
Hygiene: upgrade to OkHttp 3.6.0
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336345 )
Change subject: Fix: update cache must-revalidate header logic
..
Fix: update cache must-revalidate header logic
When caching HTTP
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336431 )
Change subject: Fix: use response's cache-control not request
..
Fix: use response's cache-control not request
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336669 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I740a1e75713c89d4398ba9d1232fb4cda48cda04
---
M app/build.gradle
1
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336717 )
Change subject: Fix: unit error in polling period for Wikidata notifications
..
Fix: unit error in polling period for Wikidata
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336721 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ia4917bc55671da59ba5dffdafd1dda68b96ac25d
---
M app/build.gradle
1
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335458 )
Change subject: Update: palette
..
Update: palette
Update the app color scheme to 2017-01-15[0]. Only the Foundation theme
was
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336247 )
Change subject: Bump versionCode to 2.5.185
..
Bump versionCode to 2.5.185
Change-Id: Idd321762d22584a5eaeb33e391ee7d6505c57b2d
---
M
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336586 )
Change subject: Hygiene: separate OkHttpConnectionFactory nested classes into
files
..
Hygiene: separate OkHttpConnectionFactory
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336587 )
Change subject: Hygiene: add cache / network source OkHttp logging interceptor
..
Hygiene: add cache / network source OkHttp logging
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336585 )
Change subject: Hygiene: move OkHttpConnectionFactory to okhttp subpackage
..
Hygiene: move OkHttpConnectionFactory to okhttp
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336588 )
Change subject: Fix: request network response when cache response is stale
..
Fix: request network response when cache response is
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335334 )
Change subject: Fix: add WikiSite unmarshaller for legacy JSON
..
Fix: add WikiSite unmarshaller for legacy JSON
Bug: T152980
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333453 )
Change subject: Hygiene: rename Retrofit *Endpoints* to Service
..
Hygiene: rename Retrofit *Endpoints* to Service
Service terminology
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333455 )
Change subject: Hygiene: rename some MediaWiki action API response types
..
Hygiene: rename some MediaWiki action API response types
•
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333454 )
Change subject: Hygiene: consolidate org.wikipedia.server into
org.wikipedia.dataclient
..
Hygiene: consolidate org.wikipedia.server
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333831 )
Change subject: Hygiene: add phpcs rule for function declaration equals spacing
..
Hygiene: add phpcs rule for function declaration
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333834 )
Change subject: Fix: leak of mfTempOpenSection() Minerva-only JavaScript
function
..
Fix: leak of mfTempOpenSection() Minerva-only
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335099 )
Change subject: Hygiene: add Page @NonNull / @Nullable annotations
..
Hygiene: add Page @NonNull / @Nullable annotations
Add missing
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335182 )
Change subject: Update: improve WikiSite.authorityToLanguageCode() robustness
..
Update: improve WikiSite.authorityToLanguageCode()
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334738 )
Change subject: Hygiene: limit visibility of Parcel constructors
..
Hygiene: limit visibility of Parcel constructors
Parcelable
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334743 )
Change subject: Hygiene: update comment in NamespaceTypeAdapterTest
..
Hygiene: update comment in NamespaceTypeAdapterTest
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334742 )
Change subject: Update: throw Exception when trying to marshal ZeroConfig
..
Update: throw Exception when trying to marshal ZeroConfig
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334736 )
Change subject: Hygiene: move WikiSite Parcelable test from PercelableTest to
WikiSiteTest
..
Hygiene: move WikiSite Parcelable test
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334739 )
Change subject: Hygiene: reorder PageTitle members and add annotations
..
Hygiene: reorder PageTitle members and add annotations
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334741 )
Change subject: Update: add a couple WikiSite tests
..
Update: add a couple WikiSite tests
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334737 )
Change subject: Update: add equals() and hashCode() overrides to Tab and
PageBackStackItem
..
Update: add equals() and hashCode()
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334740 )
Change subject: Hygiene: reorder PageBackStackItem methods
..
Hygiene: reorder PageBackStackItem methods
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334447 )
Change subject: Report failed tab JSON
..
Report failed tab JSON
Change-Id: Ib1bf99ab5dea0af7ca12e7d7ad3d7eb11c3d25f0
---
M
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334454 )
Change subject: Update: allow OkHttp Cache to serve stale responses
..
Update: allow OkHttp Cache to serve stale responses
Bug:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338061 )
Change subject: Hygiene: remove dead code in PageActivity
..
Hygiene: remove dead code in PageActivity
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338058 )
Change subject: Hygiene: remove superfluous @TargetApi annotations
..
Hygiene: remove superfluous @TargetApi annotations
Lint now
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338064 )
Change subject: Update: use app language for UI
..
Update: use app language for UI
Bug: T142019
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338062 )
Change subject: Hygiene: remove redundant theme change subscriber in
MainActivity
..
Hygiene: remove redundant theme change subscriber
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338060 )
Change subject: Fix: SearchFragment NPE in async callback UI update
..
Fix: SearchFragment NPE in async callback UI update
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338059 )
Change subject: Hygiene: move language switching code to ResourceUtil
..
Hygiene: move language switching code to ResourceUtil
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338056 )
Change subject: Hygiene: make common base Activity ancestor & DRY up
ActivityUtil
..
Hygiene: make common base Activity ancestor & DRY
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338057 )
Change subject: Hygiene: consolidate more into BaseActivity
..
Hygiene: consolidate more into BaseActivity
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338063 )
Change subject: Hygiene: rename event bus subscribers
..
Hygiene: rename event bus subscribers
Remove verbose redundant event bus
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339117 )
Change subject: Fix: don't require HTML formatting for notification strings
..
Fix: don't require HTML formatting for notification
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339591 )
Change subject: Fix: persist settings screen toolbar on Activity recreation
..
Fix: persist settings screen toolbar on Activity
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339574 )
Change subject: Update: add second OkHttp cache for saved content
..
Update: add second OkHttp cache for saved content
Bug: T156917
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339680 )
Change subject: Hygiene: upgrade to eslint-config-node-services v2.0.1
..
Hygiene: upgrade to eslint-config-node-services v2.0.1
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339808 )
Change subject: Hygiene: move collapseTables.getTableHeader to applib
..
Hygiene: move collapseTables.getTableHeader to applib
Bug:
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/335092 )
Change subject: New: diff tests
..
New: diff tests
Useful for regression testing. These tests do diffs of JSON output of
MCS,
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336893 )
Change subject: Fix: add vibration permission on API < 19 for W0
..
Fix: add vibration permission on API < 19 for W0
Add vibration
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337054 )
Change subject: Fix: refresh login token before saving description edit
..
Fix: refresh login token before saving description edit
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337088 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ia2579200aa509b4a6947d976b1a66e529623b37d
---
M app/build.gradle
1
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337728 )
Change subject: WIP: Hygiene: use HTTP POST for EventLogging
..
WIP: Hygiene: use HTTP POST for EventLogging
Since recording a funnel
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337709 )
Change subject: Hygiene: rename DefaultUserOptionDataClient service interface
..
Hygiene: rename DefaultUserOptionDataClient service
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336836 )
Change subject: Hygiene: require source files to end with a newline
..
Hygiene: require source files to end with a newline
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336832 )
Change subject: Fix: copy ArrayUtils.removeAllOccurrences()
..
Fix: copy ArrayUtils.removeAllOccurrences()
Some OEMs appear to have
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334392 )
Change subject: Hygiene: don't assume gradlew is in PATH
..
Hygiene: don't assume gradlew is in PATH
The gradlew is script is normally
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337928 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ie2862f859e9cfe1dd651f58a119b57cc7f62f619
---
M app/build.gradle
1
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333920 )
Change subject: Fix: wrap long description inputs across multiple lines
..
Fix: wrap long description inputs across multiple lines
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336848 )
Change subject: Fix: try to avoid out of memory errors when detecting faces
..
Fix: try to avoid out of memory errors when detecting
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332490 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333115 )
Change subject: WIP: remove saved pages
..
WIP: remove saved pages
Support in the OkHttp caching layer and the ability to refresh
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333120 )
Change subject: Hygiene: very minor misc clean up
..
Hygiene: very minor misc clean up
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333145 )
Change subject: Hygiene: replace StringUtil methods with Apache Commons
StringUtils
..
Hygiene: replace StringUtil methods with Apache
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333147 )
Change subject: Fix: potential NPE in PageLeadProperties.getSections() clients
..
Fix: potential NPE in
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333037 )
Change subject: Fix: update AppTextViewWithImagesTest reference images
..
Fix: update AppTextViewWithImagesTest reference images
An
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333286 )
Change subject: Fix: use app language when new nearby results are requested
..
Fix: use app language when new nearby results are
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333285 )
Change subject: Hygiene: split nearby MwApiResponsePage data into subclass
..
Hygiene: split nearby MwApiResponsePage data into
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305760
Change subject: add pre-commit test
..
add pre-commit test
Change-Id: I6878785f694c09212725559eaa30140c4b2d0ed8
---
M
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305756
Change subject: fail on error #chore
..
fail on error #chore
replace manual `|| exit 1` with the standard `set -euo pipefail` setting
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305757
Change subject: move repeat code to function #chore
..
move repeat code to function #chore
• move `git diff --name-only --cached` to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305759
Change subject: functionalize code #chore
..
functionalize code #chore
Change-Id: I8c05ba50a42a89fd15d516ce86114d92cc8bb61b
---
M
601 - 700 of 1370 matches
Mail list logo
