[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceInterWikiLinks[master]: Set used tables in unit test

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405579 )

Change subject: Set used tables in unit test
..

Set used tables in unit test

1) BSApiTasksInterWikiLinksManagerTest::testEditInterWikiLink
MWException: When testing database state, the test cases's needDB()
method should return true. Use @group Database or $this->tablesUsed.

Change-Id: I2d35ccf2c4b6f3373ffc2e223a9dc336f2d46b09
---
M tests/phpunit/BSApiTasksInterWikiLinksManagerTest.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceInterWikiLinks 
refs/changes/79/405579/1

diff --git a/tests/phpunit/BSApiTasksInterWikiLinksManagerTest.php 
b/tests/phpunit/BSApiTasksInterWikiLinksManagerTest.php
index 374d599..2b0c00b 100644
--- a/tests/phpunit/BSApiTasksInterWikiLinksManagerTest.php
+++ b/tests/phpunit/BSApiTasksInterWikiLinksManagerTest.php
@@ -8,6 +8,11 @@
  * @group BlueSpiceInterWikiLnksManager
  */
 class BSApiTasksInterWikiLinksManagerTest extends BSApiTasksTestBase {
+   protected function setUp() {
+   parent::setUp();
+   $this->tablesUsed[] = 'interwiki';
+   }
+
protected function getModuleName( ) {
return 'bs-interwikilinks-tasks';
}
@@ -75,4 +80,3 @@
return false;
}
 }
-

-- 
To view, visit https://gerrit.wikimedia.org/r/405579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d35ccf2c4b6f3373ffc2e223a9dc336f2d46b09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInterWikiLinks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceInterWikiLinks[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405332 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..


Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: I9ce90cc1bd5dad8e8db0d5e08257c0581cebfb5f
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index 73e405b..a7189db 100644
--- a/extension.json
+++ b/extension.json
@@ -10,6 +10,12 @@
],
"descriptionmsg": "bs-interwikilinks-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"bsgExtensions": {
"BlueSpiceInterWikiLinks": {
"className": "InterWikiLinks",

-- 
To view, visit https://gerrit.wikimedia.org/r/405332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ce90cc1bd5dad8e8db0d5e08257c0581cebfb5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInterWikiLinks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePermissionManager[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405331 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..


Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: Ie0b392a5e32065e69b820c2d2d3839cbc5c0c1f7
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index 2d1a0c7..9c6f97f 100644
--- a/extension.json
+++ b/extension.json
@@ -9,6 +9,12 @@
],
"descriptionmsg": "bs-permissionmanager-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"attributes": {
"BlueSpiceFoundation": {
"Extensions": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0b392a5e32065e69b820c2d2d3839cbc5c0c1f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpicePermissionManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceSmartlist[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405330 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..


Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: I4c369b95f4d95142153a935858203c496c34eee4
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index b39a5bb..ef050c5 100644
--- a/extension.json
+++ b/extension.json
@@ -12,6 +12,12 @@
],
"descriptionmsg": "bs-smartlist-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"attributes": {
"BlueSpiceFoundation": {
"Extensions": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c369b95f4d95142153a935858203c496c34eee4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceSmartlist
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Bypass wfGetDB when LoadBalancer is used in scope

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405542 )

Change subject: Bypass wfGetDB when LoadBalancer is used in scope
..

Bypass wfGetDB when LoadBalancer is used in scope

wfGetDB calls LoadBalander::getConnection for $wiki=false,
when there is already a LoadBalancer in scope, call it directly

Change-Id: I4e29fd4e93a0d1f274e61af99c96021d3d06f8f3
---
M includes/page/WikiPage.php
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/405542/1

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 788ae61..d403ab5 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -434,8 +434,9 @@
 
if ( is_int( $from ) ) {
list( $index, $opts ) = 
DBAccessObjectUtils::getDBOptions( $from );
-   $data = $this->pageDataFromTitle( wfGetDB( $index ), 
$this->mTitle, $opts );
$loadBalancer = 
MediaWikiServices::getInstance()->getDBLoadBalancer();
+   $db = $loadBalancer->getConnection( $index );
+   $data = $this->pageDataFromTitle( $db, $this->mTitle, 
$opts );
 
if ( !$data
&& $index == DB_REPLICA
@@ -444,7 +445,8 @@
) {
$from = self::READ_LATEST;
list( $index, $opts ) = 
DBAccessObjectUtils::getDBOptions( $from );
-   $data = $this->pageDataFromTitle( wfGetDB( 
$index ), $this->mTitle, $opts );
+   $db = $loadBalancer->getConnection( $index );
+   $data = $this->pageDataFromTitle( $db, 
$this->mTitle, $opts );
}
} else {
// No idea from where the caller got this data, assume 
replica DB.
@@ -1426,7 +1428,7 @@
$baseRevId = null;
if ( $edittime && $sectionId !== 'new' ) {
$lb = 
MediaWikiServices::getInstance()->getDBLoadBalancer();
-   $dbr = wfGetDB( DB_REPLICA );
+   $dbr = $lb->getConnection( DB_REPLICA );
$rev = Revision::loadFromTimestamp( $dbr, 
$this->mTitle, $edittime );
// Try the master if this thread may have just added it.
// This could be abstracted into a Revision method, but 
we don't want
@@ -1435,7 +1437,7 @@
&& $lb->getServerCount() > 1
&& $lb->hasOrMadeRecentMasterChanges()
) {
-   $dbw = wfGetDB( DB_MASTER );
+   $dbw = $lb->getConnection( DB_MASTER );
$rev = Revision::loadFromTimestamp( $dbw, 
$this->mTitle, $edittime );
}
if ( $rev ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/405542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e29fd4e93a0d1f274e61af99c96021d3d06f8f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Patroller[master]: Fix use of wfMessage

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405541 )

Change subject: Fix use of wfMessage
..

Fix use of wfMessage

wgMessage and wfMessages does not work

Change-Id: I62049a9c79388b391a09ea2844d8555c1295dc34
---
M SpecialPatroller.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Patroller 
refs/changes/41/405541/1

diff --git a/SpecialPatroller.php b/SpecialPatroller.php
index 688efcb..ece3a2b 100644
--- a/SpecialPatroller.php
+++ b/SpecialPatroller.php
@@ -58,18 +58,18 @@
// Mark the change patrolled
if ( !$wgUser->isBlocked( false ) ) {
RecentChange::markPatrolled( 
$rcid );
-   $wgOut->setSubtitle( 
wfMessages( 'patrol-endorsed-ok' )->escaped() );
+   $wgOut->setSubtitle( wfMessage( 
'patrol-endorsed-ok' )->escaped() );
} else {
-   $wgOut->setSubtitle( 
wgMessages( 'patrol-endorsed-failed' )->escaped() );
+   $wgOut->setSubtitle( wfMessage( 
'patrol-endorsed-failed' )->escaped() );
}
} elseif ( $wgRequest->getCheck( 
'wpPatrolRevert' ) ) {
// Revert the change
$edit = $this->loadChange( $rcid );
$msg = $this->revert( $edit, 
$this->revertReason( $wgRequest ) ) ? 'ok' : 'failed';
-   $wgOut->setSubtitle( wgMessage( 
'patrol-reverted-' . $msg )->escaped() );
+   $wgOut->setSubtitle( wfMessage( 
'patrol-reverted-' . $msg )->escaped() );
} elseif ( $wgRequest->getCheck( 'wpPatrolSkip' 
) ) {
// Do nothing
-   $wgOut->setSubtitle( wgMessage( 
'patrol-skipped-ok' )->escaped() );
+   $wgOut->setSubtitle( wfMessage( 
'patrol-skipped-ok' )->escaped() );
}
}
}
@@ -378,7 +378,7 @@
 * @return string Reasons
 */
private function revertReasonsDropdown() {
-   $msg = wgMessage( 'patrol-reasons' 
)->inContentLanguage()->text();
+   $msg = wfMessage( 'patrol-reasons' 
)->inContentLanguage()->text();
if ( $msg == '-' || $msg == 'patrol-reasons' ) {
return '';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/405541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62049a9c79388b391a09ea2844d8555c1295dc34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Patroller
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update eslint and stylelint

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404720 )

Change subject: Update eslint and stylelint
..


Update eslint and stylelint

Change-Id: I6c316a927427b7ab5f4f47ae5e35bddf5deac419
---
M package.json
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index 24cb748..a4a2911 100644
--- a/package.json
+++ b/package.json
@@ -11,12 +11,13 @@
"test": "grunt test"
},
"devDependencies": {
+   "eslint": "4.9.0",
"eslint-config-wikimedia": "0.5.0",
"grunt": "1.0.1",
"grunt-banana-checker": "0.6.0",
-   "grunt-eslint": "20.0.0",
+   "grunt-eslint": "20.1.0",
"grunt-jsonlint": "1.1.0",
-   "grunt-stylelint": "0.8.0",
+   "grunt-stylelint": "0.9.0",
"stylelint": "8.2.0",
"stylelint-config-wikimedia": "0.4.2"
}

-- 
To view, visit https://gerrit.wikimedia.org/r/404720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c316a927427b7ab5f4f47ae5e35bddf5deac419
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePagesVisited[master]: Fix hook callback

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405288 )

Change subject: Fix hook callback
..


Fix hook callback

Change-Id: I0ce66690791631dbb051dbbe25880c9be180805a
---
R src/Hook/GetPreferences/AddWidgetSortOdr.php
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved
  Thiemo Kreuz (WMDE): Looks good to me, but someone else must approve



diff --git a/src/Hook/GetPreferences/WidgetSortOdr.php 
b/src/Hook/GetPreferences/AddWidgetSortOdr.php
similarity index 100%
rename from src/Hook/GetPreferences/WidgetSortOdr.php
rename to src/Hook/GetPreferences/AddWidgetSortOdr.php

-- 
To view, visit https://gerrit.wikimedia.org/r/405288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ce66690791631dbb051dbbe25880c9be180805a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpicePagesVisited
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/extensions[master]: Add extension VersionCompare

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405423 )

Change subject: Add extension VersionCompare
..

Add extension VersionCompare

Change-Id: I2d5dde3c52589d100d3c529c7bb5a47441e19fc4
---
M .gitmodules
A VersionCompare
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/23/405423/1

diff --git a/.gitmodules b/.gitmodules
index 0c3c3e3..2453227 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -2874,6 +2874,10 @@
path = Variables
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Variables
branch = .
+[submodule "VersionCompare"]
+   path = VersionCompare
+   url = https://gerrit.wikimedia.org/r/mediawiki/extensions/VersionCompare
+   branch = .
 [submodule "Video"]
path = Video
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Video
diff --git a/VersionCompare b/VersionCompare
new file mode 16
index 000..5f04aa1
--- /dev/null
+++ b/VersionCompare
@@ -0,0 +1 @@
+Subproject commit 5f04aa122c0265808dee3cdf1bc528174adf06df

-- 
To view, visit https://gerrit.wikimedia.org/r/405423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d5dde3c52589d100d3c529c7bb5a47441e19fc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/extensions[master]: Add extension VersionCompare

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405423 )

Change subject: Add extension VersionCompare
..


Add extension VersionCompare

Change-Id: I2d5dde3c52589d100d3c529c7bb5a47441e19fc4
---
M .gitmodules
A VersionCompare
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/.gitmodules b/.gitmodules
index 0c3c3e3..2453227 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -2874,6 +2874,10 @@
path = Variables
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Variables
branch = .
+[submodule "VersionCompare"]
+   path = VersionCompare
+   url = https://gerrit.wikimedia.org/r/mediawiki/extensions/VersionCompare
+   branch = .
 [submodule "Video"]
path = Video
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Video
diff --git a/VersionCompare b/VersionCompare
new file mode 16
index 000..5f04aa1
--- /dev/null
+++ b/VersionCompare
@@ -0,0 +1 @@
+Subproject commit 5f04aa122c0265808dee3cdf1bc528174adf06df

-- 
To view, visit https://gerrit.wikimedia.org/r/405423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d5dde3c52589d100d3c529c7bb5a47441e19fc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: Use tabs in extension.json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405329 )

Change subject: Use tabs in extension.json
..


Use tabs in extension.json

Change-Id: I665d97fa62ef241595b49753bb82aef489b508cb
---
M extension.json
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Umherirrender: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index 3f2eb51..8e16e90 100644
--- a/extension.json
+++ b/extension.json
@@ -3,7 +3,7 @@
"license-name":"GPL-3.0-only",
"version": "3.0.0",
"url": "https://help.bluespice.com/index.php/Namespacemanager;,
-   "author":   [
+   "author": [
"Sebastian Ulbricht",
"Stefan Widmann",
"Robert Vogel"
@@ -27,7 +27,7 @@
"requires": {
"extensions": {
"BlueSpiceFoundation": "*"
-}
+   }
},
"LogTypes": [
"bs-namespace-manager"

-- 
To view, visit https://gerrit.wikimedia.org/r/405329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I665d97fa62ef241595b49753bb82aef489b508cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Set some BlueSpice extensions to non-voting tests

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405408 )

Change subject: Set some BlueSpice extensions to non-voting tests
..

Set some BlueSpice extensions to non-voting tests

Tests are failing at the moment
Changed BlueSpiceAbout to composer test to see autoloaded classes from
dependeny BlueSpiceFoundation

Change-Id: I5bd7aca7c79471229c358d39923da59c67d28952
---
M zuul/layout.yaml
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/08/405408/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3f56ec8..9345063 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -4392,7 +4392,7 @@
 
   - name: mediawiki/extensions/BlueSpiceAbout
 template:
-  - name: extension-unittests-generic
+  - name: extension-unittests-composer-non-voting
   - name: mwgate-npm
 
   - name: mediawiki/extensions/BlueSpicePageAccess
@@ -4530,7 +4530,7 @@
 
   - name: mediawiki/extensions/BlueSpiceInterWikiLinks
 template:
-  - name: extension-unittests-composer
+  - name: extension-unittests-composer-non-voting
   - name: mwgate-npm
 
   - name: mediawiki/extensions/BlueSpiceMultiUpload
@@ -4540,7 +4540,7 @@
 
   - name: mediawiki/extensions/BlueSpiceNamespaceManager
 template:
-  - name: extension-unittests-composer
+  - name: extension-unittests-composer-non-voting
   - name: mwgate-npm
 
   - name: mediawiki/extensions/BlueSpicePageAssignments
@@ -4565,7 +4565,7 @@
 
   - name: mediawiki/extensions/BlueSpicePermissionManager
 template:
-  - name: extension-unittests-composer
+  - name: extension-unittests-composer-non-voting
   - name: mwgate-npm
 
   - name: mediawiki/extensions/BlueSpiceReaders
@@ -4585,7 +4585,7 @@
 
   - name: mediawiki/extensions/BlueSpiceSmartlist
 template:
-  - name: extension-unittests-composer
+  - name: extension-unittests-composer-non-voting
   - name: mwgate-npm
 
   - name: mediawiki/extensions/BlueSpiceSMWConnector

-- 
To view, visit https://gerrit.wikimedia.org/r/405408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bd7aca7c79471229c358d39923da59c67d28952
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ConfigFactory: Improve error message for invalid callback

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405407 )

Change subject: ConfigFactory: Improve error message for invalid callback
..

ConfigFactory: Improve error message for invalid callback

Getting the following error for an invalid callback in extension
registration is not helpful:
Fatal error: Uncaught exception 'InvalidArgumentException' with message
'Invalid callback provided' in /includes/config/ConfigFactory.php:108

Changed message to
Invalid callback '$1' provided

Added a test case for the instanceof part of the if

Change-Id: I425e2607b651c666336289c2c0d93730bb6312ed
---
M includes/config/ConfigFactory.php
M tests/phpunit/includes/config/ConfigFactoryTest.php
2 files changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/405407/1

diff --git a/includes/config/ConfigFactory.php 
b/includes/config/ConfigFactory.php
index e175765..2c7afda 100644
--- a/includes/config/ConfigFactory.php
+++ b/includes/config/ConfigFactory.php
@@ -105,7 +105,12 @@
 */
public function register( $name, $callback ) {
if ( !is_callable( $callback ) && !( $callback instanceof 
Config ) ) {
-   throw new InvalidArgumentException( 'Invalid callback 
provided' );
+   if ( is_array( $callback ) ) {
+   $callback = '[ ' . implode( ', ', $callback ) . 
' ]';
+   } elseif ( is_object( $callback ) ) {
+   $callback = 'instanceof ' . get_class( 
$callback );
+   }
+   throw new InvalidArgumentException( 'Invalid callback 
\'' . $callback . '\' provided' );
}
 
unset( $this->configs[$name] );
diff --git a/tests/phpunit/includes/config/ConfigFactoryTest.php 
b/tests/phpunit/includes/config/ConfigFactoryTest.php
index 608d8d9..c0e51d7 100644
--- a/tests/phpunit/includes/config/ConfigFactoryTest.php
+++ b/tests/phpunit/includes/config/ConfigFactoryTest.php
@@ -25,6 +25,15 @@
/**
 * @covers ConfigFactory::register
 */
+   public function testRegisterInvalidInstance() {
+   $factory = new ConfigFactory();
+   $this->setExpectedException( InvalidArgumentException::class );
+   $factory->register( 'invalidInstance', new stdClass );
+   }
+
+   /**
+* @covers ConfigFactory::register
+*/
public function testRegisterInstance() {
$config = GlobalVarConfig::newInstance();
$factory = new ConfigFactory();

-- 
To view, visit https://gerrit.wikimedia.org/r/405407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I425e2607b651c666336289c2c0d93730bb6312ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceAbout[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405334 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: Ifa3ecc7402004cf14a8031f4b63555b2ee35fb45
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceAbout 
refs/changes/34/405334/1

diff --git a/extension.json b/extension.json
index fa7bbd4..6d92d40 100644
--- a/extension.json
+++ b/extension.json
@@ -6,6 +6,12 @@
"author": "Markus Glaser",
"descriptionmsg": "bs-bluespiceabout-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"SpecialPages": {
"BlueSpiceAbout": "SpecialBlueSpiceAbout"
},

-- 
To view, visit https://gerrit.wikimedia.org/r/405334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa3ecc7402004cf14a8031f4b63555b2ee35fb45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceAbout
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceGroupManager[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405333 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: Iae81eb0d246efd7a3830109b6d97a182f508fbfa
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceGroupManager 
refs/changes/33/405333/1

diff --git a/extension.json b/extension.json
index a32af32..014f787 100644
--- a/extension.json
+++ b/extension.json
@@ -13,6 +13,12 @@
},
"descriptionmsg": "bs-groupmanager-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"callback": "GroupManager::onRegistration",
"bsgExtensions": {
"BlueSpiceGroupManager": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae81eb0d246efd7a3830109b6d97a182f508fbfa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceGroupManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePermissionManager[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405331 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: Ie0b392a5e32065e69b820c2d2d3839cbc5c0c1f7
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpicePermissionManager
 refs/changes/31/405331/1

diff --git a/extension.json b/extension.json
index 2d1a0c7..9c6f97f 100644
--- a/extension.json
+++ b/extension.json
@@ -9,6 +9,12 @@
],
"descriptionmsg": "bs-permissionmanager-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"attributes": {
"BlueSpiceFoundation": {
"Extensions": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0b392a5e32065e69b820c2d2d3839cbc5c0c1f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpicePermissionManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceSmartlist[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405330 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: I4c369b95f4d95142153a935858203c496c34eee4
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceSmartlist 
refs/changes/30/405330/1

diff --git a/extension.json b/extension.json
index b39a5bb..ef050c5 100644
--- a/extension.json
+++ b/extension.json
@@ -12,6 +12,12 @@
],
"descriptionmsg": "bs-smartlist-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"attributes": {
"BlueSpiceFoundation": {
"Extensions": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c369b95f4d95142153a935858203c496c34eee4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceSmartlist
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceInterWikiLinks[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405332 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: I9ce90cc1bd5dad8e8db0d5e08257c0581cebfb5f
---
M extension.json
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceInterWikiLinks 
refs/changes/32/405332/1

diff --git a/extension.json b/extension.json
index 73e405b..a7189db 100644
--- a/extension.json
+++ b/extension.json
@@ -10,6 +10,12 @@
],
"descriptionmsg": "bs-interwikilinks-desc",
"type": "bluespice",
+   "requires": {
+   "MediaWiki": ">= 1.31.0",
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+   }
+   },
"bsgExtensions": {
"BlueSpiceInterWikiLinks": {
"className": "InterWikiLinks",

-- 
To view, visit https://gerrit.wikimedia.org/r/405332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ce90cc1bd5dad8e8db0d5e08257c0581cebfb5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInterWikiLinks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: Use tabs in extension.json

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405329 )

Change subject: Use tabs in extension.json
..

Use tabs in extension.json

Change-Id: I665d97fa62ef241595b49753bb82aef489b508cb
---
M extension.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceNamespaceManager 
refs/changes/29/405329/1

diff --git a/extension.json b/extension.json
index 3f2eb51..8e16e90 100644
--- a/extension.json
+++ b/extension.json
@@ -3,7 +3,7 @@
"license-name":"GPL-3.0-only",
"version": "3.0.0",
"url": "https://help.bluespice.com/index.php/Namespacemanager;,
-   "author":   [
+   "author": [
"Sebastian Ulbricht",
"Stefan Widmann",
"Robert Vogel"
@@ -27,7 +27,7 @@
"requires": {
"extensions": {
"BlueSpiceFoundation": "*"
-}
+   }
},
"LogTypes": [
"bs-namespace-manager"

-- 
To view, visit https://gerrit.wikimedia.org/r/405329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I665d97fa62ef241595b49753bb82aef489b508cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Config stylelint to lint css files

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405324 )

Change subject: Config stylelint to lint css files
..

Config stylelint to lint css files

Already part of package.json

Change-Id: I98c67ea480bf5613a459caf4ae2211c89beb27ef
---
A .stylelintrc.json
M Gruntfile.js
2 files changed, 16 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/24/405324/1

diff --git a/.stylelintrc.json b/.stylelintrc.json
new file mode 100644
index 000..2c90730
--- /dev/null
+++ b/.stylelintrc.json
@@ -0,0 +1,3 @@
+{
+   "extends": "stylelint-config-wikimedia"
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 7cef05d..dff19be 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -6,6 +6,7 @@
grunt.loadNpmTasks( 'grunt-contrib-watch' );
grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-stylelint' );
 
grunt.initConfig( {
eslint: {
@@ -20,8 +21,9 @@
banana: conf.MessagesDirs,
watch: {
files: [
-   '.eslintrc.json',
-   '<%= eslint.all %>'
+   '.{stylelintrc,eslintrc}.json',
+   '<%= eslint.all %>',
+   '<%= stylelint.all %>'
],
tasks: 'test'
},
@@ -32,10 +34,18 @@
'!vendor/**',
'!docs/**'
]
+   },
+   stylelint: {
+   all: [
+   '**/*.css',
+   '!node_modules/**',
+   '!vendor/**',
+   '!docs/**'
+   ]
}
} );
 
-   grunt.registerTask( 'lint', [ 'eslint', 'jsonlint', 'banana' ] );
+   grunt.registerTask( 'lint', [ 'eslint', 'jsonlint', 'banana', 
'stylelint' ] );
grunt.registerTask( 'test', 'lint' );
grunt.registerTask( 'default', 'test' );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/405324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c67ea480bf5613a459caf4ae2211c89beb27ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalPreferences[master]: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405323 )

Change subject: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
..

Require MediaWiki 1.31 in extension.json for AutoloadNamespaces

AutoloadNamespaces is a new feature in 1.31

Change-Id: Id67f1fe3afc4e11e0883b262f7993c206be4517d
---
M extension.json
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences 
refs/changes/23/405323/1

diff --git a/extension.json b/extension.json
index ced4d65..3394073 100644
--- a/extension.json
+++ b/extension.json
@@ -8,6 +8,9 @@
"url": "https://www.mediawiki.org/wiki/Extension:GlobalPreferences;,
"descriptionmsg": "globalprefs-desc",
"type": "specialpage",
+   "requires": {
+   "MediaWiki": ">= 1.31.0"
+   },
"config": {
"GlobalPreferencesDB": null
},

-- 
To view, visit https://gerrit.wikimedia.org/r/405323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67f1fe3afc4e11e0883b262f7993c206be4517d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DataTransfer[master]: Use tabs in extension.json

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405322 )

Change subject: Use tabs in extension.json
..

Use tabs in extension.json

Change-Id: I2d7523e3d328de5a396c278ff0ee5e9b8eecbc27
---
M extension.json
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTransfer 
refs/changes/22/405322/1

diff --git a/extension.json b/extension.json
index d35206c..36650a3 100644
--- a/extension.json
+++ b/extension.json
@@ -24,9 +24,9 @@
"ImportCSV": "DTImportCSV",
"ImportSpreadsheet": "DTImportSpreadsheet"
},
-"JobClasses": {
-  "dtImport": "DTImportJob"
-},
+   "JobClasses": {
+   "dtImport": "DTImportJob"
+   },
"MessagesDirs": {
"DataTransfer": [
"i18n"

-- 
To view, visit https://gerrit.wikimedia.org/r/405322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d7523e3d328de5a396c278ff0ee5e9b8eecbc27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTransfer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SendGrid[master]: Add PHP_CodeSniffer for codestyle checks to SendGrid extension

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404880 )

Change subject: Add PHP_CodeSniffer for codestyle checks to SendGrid extension
..


Add PHP_CodeSniffer for codestyle checks to SendGrid extension

Bug: T185159
Change-Id: I137a88c48739936e752c2b909a35e5b166d50bd4
---
A .phpcs.xml
M SendGrid.php
M composer.json
3 files changed, 15 insertions(+), 2 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved
  D3r1ck01: Looks good to me, but someone else must approve



diff --git a/.phpcs.xml b/.phpcs.xml
new file mode 100644
index 000..b15894e
--- /dev/null
+++ b/.phpcs.xml
@@ -0,0 +1,11 @@
+
+
+   
+   
+   
+   
+   
+   .
+   
+   
+
diff --git a/SendGrid.php b/SendGrid.php
index a11fe97..5db9cd7 100644
--- a/SendGrid.php
+++ b/SendGrid.php
@@ -11,4 +11,4 @@
return;
 } else {
die( 'This version of the SendGrid extension requires MediaWiki 1.25+' 
);
-}
\ No newline at end of file
+}
diff --git a/composer.json b/composer.json
index ca92d26..149ad7f 100644
--- a/composer.json
+++ b/composer.json
@@ -7,17 +7,19 @@
},
"require-dev": {
"phpunit/phpunit": "4.*",
-   "squizlabs/php_codesniffer": "2.*",
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
+   "mediawiki/mediawiki-codesniffer": "15.0.0",
"mediawiki/minus-x": "0.2.1"
},
"scripts": {
"test": [
"parallel-lint . --exclude vendor --exclude 
node_modules",
+   "phpcs -p -s",
"minus-x check ."
],
"fix": [
+   "phpcbf",
"minus-x fix ."
]
},

-- 
To view, visit https://gerrit.wikimedia.org/r/404880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I137a88c48739936e752c2b909a35e5b166d50bd4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/SendGrid
Gerrit-Branch: master
Gerrit-Owner: Phantom42 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: D3r1ck01 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Remove unneeded closing declaration comments

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404767 )

Change subject: Remove unneeded closing declaration comments
..

Remove unneeded closing declaration comments

It does not place very well with the newline single comment sniff.

Change-Id: I0cb7a9c7b54759dd3680380a23ac196e2cd993c3
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
M MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax.php
2 files changed, 0 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/67/404767/1

diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php 
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index 3c63e4b..bb53b01 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -57,7 +57,6 @@
public function register() {
return [ T_FUNCTION ];
}
-   // end register()
 
/**
 * Processes this test, when one of its tokens is encountered.
@@ -172,7 +171,6 @@
$this->processParams( $phpcsFile, $stackPtr, $commentStart );
$this->processCovers( $phpcsFile, $stackPtr, $commentStart );
}
-   // end process()
 
/**
 * Process the return comment of this function comment.
@@ -351,9 +349,7 @@
$error = 'Missing @return tag in function comment';
$phpcsFile->addError( $error, 
$tokens[$commentStart]['comment_closer'], 'MissingReturn' );
}
-   // end if
}
-   // end processReturn()
 
/**
 * Process any throw tags that this function comment has.
@@ -415,9 +411,7 @@
}
}
}
-   // end foreach
}
-   // end processThrows()
 
/**
 * Process any covers tags that this function comment has.
@@ -445,9 +439,7 @@
}
// TODO: Asset that the item being covered is valid.
}
-   // end foreach
}
-   // end processThrows()
 
/**
 * Process the function parameter comments.
@@ -534,12 +526,10 @@
$error = 'Missing parameter name';
$phpcsFile->addError( $error, $tag, 
'MissingParamName' );
}
-   // end if
} else {
$error = 'Missing parameter type';
$phpcsFile->addError( $error, $tag, 
'MissingParamType' );
}
-   // end if
$params[] = [
'tag' => $tag,
'type' => $type,
@@ -551,7 +541,6 @@
'var_space' => $varSpace,
];
}
-   // end foreach
$realParams = $phpcsFile->getMethodParameters( $stackPtr );
$foundParams = [];
// We want to use ... for all variable length arguments, so 
added
@@ -662,7 +651,6 @@
$phpcsFile->addError( $error, $param['tag'], 
'ExtraParamComment' );
}
$foundParams[] = $var;
-   // end if
// Check the short type of boolean and integer
$explodedType = explode( '|', $param['type'] );
$fixType = false;
@@ -714,7 +702,6 @@
}
}
}
-   // end foreach
$realNames = [];
foreach ( $realParams as $realParam ) {
$realNames[] = $realParam['name'];
@@ -727,7 +714,6 @@
$phpcsFile->addError( $error, $commentStart, 
'MissingParamTag', $data );
}
}
-   // end processParams()
 
/**
 * Replace a @param comment
@@ -997,4 +983,3 @@
}
}
 }
-// end class
diff --git a/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax.php 
b/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax.php
index 5b22aeb..74bb5e9 100644
--- a/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax.php
+++ b/MediaWiki/Tests/files/AlternativeSyntax/alternative_syntax.php
@@ -71,5 +71,3 @@
echo $i;
}
 }
-
-// end passed examples.

-- 
To view, visit https://gerrit.wikimedia.org/r/404767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cb7a9c7b54759dd3680380a23ac196e2cd993c3
Gerrit-PatchSet: 1
Gerrit-Project: 

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Use @covers instead of plain text in tests

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404739 )

Change subject: Use @covers instead of plain text in tests
..

Use @covers instead of plain text in tests

Rename PageAssessmentsBody to PageAssessmentsDAO was done in
I1a5ef32df6c3164ff0f9bf8d2a0260d6d1a9c935
Renamed the test file to match content

Change-Id: I6dff9a19b5dc5449514faa15a0c095b92d15e776
---
R tests/phpunit/PageAssessmentsDAOTest.php
1 file changed, 7 insertions(+), 13 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments 
refs/changes/39/404739/1

diff --git a/tests/phpunit/PageAssessmentsTest.php 
b/tests/phpunit/PageAssessmentsDAOTest.php
similarity index 83%
rename from tests/phpunit/PageAssessmentsTest.php
rename to tests/phpunit/PageAssessmentsDAOTest.php
index 25030bc..7d45128 100644
--- a/tests/phpunit/PageAssessmentsTest.php
+++ b/tests/phpunit/PageAssessmentsDAOTest.php
@@ -3,8 +3,9 @@
 use MediaWiki\Extension\PageAssessments\PageAssessmentsDAO;
 
 /**
- * Test the database access and core functionality of PageAssessmentsBody.
+ * Test the database access and core functionality of PageAssessmentsDAO.
  *
+ * @covers MediaWiki\Extension\PageAssessments\PageAssessmentsDAO
  * @group Database
  * @group PageAssessments
  */
@@ -19,7 +20,7 @@
}
 
/**
-* Test the insertRecord() function in PageAssessmentsBody class
+* @covers 
MediaWiki\Extension\PageAssessments\PageAssessmentsDAO::insertRecord()
 */
public function testInsert() {
$pageBody = new PageAssessmentsDAO;
@@ -40,7 +41,7 @@
}
 
/**
-* Test the updateRecord() function in PageAssessmentsBody class
+* @covers 
MediaWiki\Extension\PageAssessments\PageAssessmentsDAO::updateRecord()
 */
public function testUpdate() {
$this->testInsert();
@@ -62,7 +63,7 @@
}
 
/**
-* Test the deleteRecord() function in PageAssessmentsBody class
+* @covers 
MediaWiki\Extension\PageAssessments\PageAssessmentsDAO::deleteRecord()
 */
public function testDelete() {
$this->testInsert();
@@ -78,7 +79,7 @@
}
 
/**
-* Test the getAllProjects() function in PageAssessmentsBody class
+* @covers 
MediaWiki\Extension\PageAssessments\PageAssessmentsDAO::getAllProjects()
 */
public function testGetAllProjects() {
$pageBody = new PageAssessmentsDAO;
@@ -102,19 +103,12 @@
}
 
/**
-* Test the cleanProjectTitle() function in PageAssessmentsBody class
+* @covers 
MediaWiki\Extension\PageAssessments\PageAssessmentsDAO::cleanProjectTitle()
 */
public function testCleanProjectTitle() {
$pageBody = new PageAssessmentsDAO;
$projectTitle = "Drinks/the '''Coffee task force'''";
$cleanedProjectTitle = $pageBody->cleanProjectTitle( 
$projectTitle );
$this->assertEquals( "Drinks/Coffee task force", 
$cleanedProjectTitle );
-   }
-
-   /**
-* Tear down - called at the end
-*/
-   protected function tearDown() {
-   parent::tearDown();
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/404739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dff9a19b5dc5449514faa15a0c095b92d15e776
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePageTemplates[master]: Fix use of "config_prefix" in extension.json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404218 )

Change subject: Fix use of "config_prefix" in extension.json
..


Fix use of "config_prefix" in extension.json

Change-Id: I01fedbf010db4be0b856df97f25c3d92ebc96797
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/extension.json b/extension.json
index 4e5b23c..76a3d5d 100644
--- a/extension.json
+++ b/extension.json
@@ -47,7 +47,7 @@
"ExtensionMessagesFiles": {
"PageTemplatesAdminAlias": 
"includes/specials/SpecialPageTemplatesAdmin.alias.php"
},
-   "config-prefix": "bsg",
+   "config_prefix": "bsg",
"config": {
"PageTemplatesExcludeNs": {
"value": [

-- 
To view, visit https://gerrit.wikimedia.org/r/404218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01fedbf010db4be0b856df97f25c3d92ebc96797
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpicePageTemplates
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: Fix use of "config_prefix" and set "requires" in extension.json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404220 )

Change subject: Fix use of "config_prefix" and set "requires" in extension.json
..


Fix use of "config_prefix" and set "requires" in extension.json

"requires" sets the load order in the extension registry to have
BSCONFIGDIR defined when needed

Change-Id: Ib302787af9ea7f23897acae9c11558b59d878bcb
---
M extension.json
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Umherirrender: Verified
  Robert Vogel: Looks good to me, approved



diff --git a/extension.json b/extension.json
index c399168..ce50fef 100644
--- a/extension.json
+++ b/extension.json
@@ -21,6 +21,11 @@
}
},
"callback": "NamespaceManager::onRegistration",
+   "requires": {
+   "extensions": {
+   "BlueSpiceFoundation": "*"
+}
+   },
"LogTypes": [
"bs-namespace-manager"
],
@@ -45,7 +50,7 @@
"ExtensionMessagesFiles": {
"NamespaceManagerAlias": 
"includes/specials/SpecialNamespaceManager.alias.php"
},
-   "config-prefix": "bsg",
+   "config_prefix": "bsg",
"config": {
"NamespaceManagerNsOffset": {
"value": 2999

-- 
To view, visit https://gerrit.wikimedia.org/r/404220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib302787af9ea7f23897acae9c11558b59d878bcb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: Fix use of "config_prefix" in extension.json

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404220 )

Change subject: Fix use of "config_prefix" in extension.json
..

Fix use of "config_prefix" in extension.json

Change-Id: Ib302787af9ea7f23897acae9c11558b59d878bcb
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceNamespaceManager 
refs/changes/20/404220/1

diff --git a/extension.json b/extension.json
index c399168..ade10e0 100644
--- a/extension.json
+++ b/extension.json
@@ -45,7 +45,7 @@
"ExtensionMessagesFiles": {
"NamespaceManagerAlias": 
"includes/specials/SpecialNamespaceManager.alias.php"
},
-   "config-prefix": "bsg",
+   "config_prefix": "bsg",
"config": {
"NamespaceManagerNsOffset": {
"value": 2999

-- 
To view, visit https://gerrit.wikimedia.org/r/404220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib302787af9ea7f23897acae9c11558b59d878bcb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePageTemplates[master]: Fix use of "config_prefix" in extension.json

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404218 )

Change subject: Fix use of "config_prefix" in extension.json
..

Fix use of "config_prefix" in extension.json

Change-Id: I01fedbf010db4be0b856df97f25c3d92ebc96797
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpicePageTemplates 
refs/changes/18/404218/1

diff --git a/extension.json b/extension.json
index 4e5b23c..76a3d5d 100644
--- a/extension.json
+++ b/extension.json
@@ -47,7 +47,7 @@
"ExtensionMessagesFiles": {
"PageTemplatesAdminAlias": 
"includes/specials/SpecialPageTemplatesAdmin.alias.php"
},
-   "config-prefix": "bsg",
+   "config_prefix": "bsg",
"config": {
"PageTemplatesExcludeNs": {
"value": [

-- 
To view, visit https://gerrit.wikimedia.org/r/404218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01fedbf010db4be0b856df97f25c3d92ebc96797
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpicePageTemplates
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceReaders[master]: Add minus-x to composer.json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403364 )

Change subject: Add minus-x to composer.json
..


Add minus-x to composer.json

Bug: T175794
Change-Id: Ie0d6037892757f6ad4de4ec28f86368082938bc7
---
M composer.json
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/composer.json b/composer.json
index 63e0b2c..d41665b 100644
--- a/composer.json
+++ b/composer.json
@@ -13,11 +13,14 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "jakub-onderka/php-console-highlighter": "0.3.2"
+   "jakub-onderka/php-console-highlighter": "0.3.2",
+   "mediawiki/minus-x": "0.3.0"
},
"scripts": {
+   "fix": "minus-x fix .",
"test": [
-   "parallel-lint . --exclude vendor --exclude 
node_modules"
+   "parallel-lint . --exclude vendor --exclude 
node_modules",
+   "minus-x check ."
]
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d6037892757f6ad4de4ec28f86368082938bc7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/BlueSpiceReaders
Gerrit-Branch: master
Gerrit-Owner: Divadsn 
Gerrit-Reviewer: D3r1ck01 
Gerrit-Reviewer: Divadsn 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceReaders[master]: Fix use of "config_prefix" in extension.json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403359 )

Change subject: Fix use of "config_prefix" in extension.json
..


Fix use of "config_prefix" in extension.json

Change-Id: I6d999b22420d19b9277600ad19bb4e645dcf160b
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/extension.json b/extension.json
index a56f55c..2fc62ca 100644
--- a/extension.json
+++ b/extension.json
@@ -37,7 +37,7 @@
"ExtensionMessagesFiles": {
"ReadersAlias": "languages/SpecialReaders.alias.php"
},
-   "config-prefix": "bsg",
+   "config_prefix": "bsg",
"config": {
"ReadersNumOfReaders": {
"value": 10,

-- 
To view, visit https://gerrit.wikimedia.org/r/403359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d999b22420d19b9277600ad19bb4e645dcf160b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceReaders
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceEditNotifyConnector[master]: Use SPDX 3.0 license identifier

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/401872 )

Change subject: Use SPDX 3.0 license identifier
..


Use SPDX 3.0 license identifier

SPDX released version 3 of their license list (),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: If6571354cfd42ac63324621984ab5c5aa6334273
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Verified
  Ladsgroup: Looks good to me, approved
  Addshore: Looks good to me, approved
  Legoktm: Looks good to me, approved



diff --git a/extension.json b/extension.json
index 351bc15..2301623 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
"name": "BlueSpiceEditNotifyConnector",
-   "license-name": "GPL-3.0",
+   "license-name": "GPL-3.0-only",
"version": "3.0.0-alpha",
"url": 
"https://www.mediawiki.org/wiki/Extension:BlueSpiceEditNotifyConnector;,
"descriptionmsg": "bluespiceeditnotifyconnector-desc",

-- 
To view, visit https://gerrit.wikimedia.org/r/401872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6571354cfd42ac63324621984ab5c5aa6334273
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceEditNotifyConnector
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleFeedbackv5[master]: Use SPDX 3.0 license identifier

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/401845 )

Change subject: Use SPDX 3.0 license identifier
..


Use SPDX 3.0 license identifier

SPDX released version 3 of their license list (),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: Ia9906a1ae32383559cf3c7448962e53e80fa4062
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index cd8ff0a..dd8de97 100644
--- a/extension.json
+++ b/extension.json
@@ -18,7 +18,7 @@
"Matthias Mullie",
"Jack Phoenix"
],
-   "license-name": "GPL-2.0+",
+   "license-name": "GPL-2.0-or-later",
"requires": {
"MediaWiki": ">= 1.28.0"
},

-- 
To view, visit https://gerrit.wikimedia.org/r/401845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9906a1ae32383559cf3c7448962e53e80fa4062
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove "Created on" from file header comments

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403992 )

Change subject: Remove "Created on" from file header comments
..

Remove "Created on" from file header comments

It is the job of git and svn to provide this information/metadata.
The form was different, some with short, some with long month name
some with leading zero at the day, some without.
The year is also present in the Copyright clause

Change-Id: If006907b82b9e45f13cfa2e45d41107a95570e1a
---
M includes/MergeHistory.php
M includes/api/ApiBase.php
M includes/api/ApiBlock.php
M includes/api/ApiCheckToken.php
M includes/api/ApiClearHasMsg.php
M includes/api/ApiDelete.php
M includes/api/ApiDisabled.php
M includes/api/ApiEditPage.php
M includes/api/ApiEmailUser.php
M includes/api/ApiExpandTemplates.php
M includes/api/ApiFeedContributions.php
M includes/api/ApiFeedWatchlist.php
M includes/api/ApiFileRevert.php
M includes/api/ApiFormatBase.php
M includes/api/ApiFormatFeedWrapper.php
M includes/api/ApiFormatJson.php
M includes/api/ApiFormatNone.php
M includes/api/ApiFormatPhp.php
M includes/api/ApiFormatRaw.php
M includes/api/ApiFormatXml.php
M includes/api/ApiHelp.php
M includes/api/ApiHelpParamValueMessage.php
M includes/api/ApiImageRotate.php
M includes/api/ApiLogin.php
M includes/api/ApiLogout.php
M includes/api/ApiMain.php
M includes/api/ApiMergeHistory.php
M includes/api/ApiModuleManager.php
M includes/api/ApiMove.php
M includes/api/ApiOptions.php
M includes/api/ApiPageSet.php
M includes/api/ApiParamInfo.php
M includes/api/ApiParse.php
M includes/api/ApiPatrol.php
M includes/api/ApiProtect.php
M includes/api/ApiQuery.php
M includes/api/ApiQueryAllCategories.php
M includes/api/ApiQueryAllDeletedRevisions.php
M includes/api/ApiQueryAllImages.php
M includes/api/ApiQueryAllLinks.php
M includes/api/ApiQueryAllMessages.php
M includes/api/ApiQueryAllPages.php
M includes/api/ApiQueryAllRevisions.php
M includes/api/ApiQueryAllUsers.php
M includes/api/ApiQueryBacklinks.php
M includes/api/ApiQueryBacklinksprop.php
M includes/api/ApiQueryBase.php
M includes/api/ApiQueryBlocks.php
M includes/api/ApiQueryCategories.php
M includes/api/ApiQueryCategoryInfo.php
M includes/api/ApiQueryCategoryMembers.php
M includes/api/ApiQueryContributors.php
M includes/api/ApiQueryDeletedRevisions.php
M includes/api/ApiQueryDeletedrevs.php
M includes/api/ApiQueryDisabled.php
M includes/api/ApiQueryDuplicateFiles.php
M includes/api/ApiQueryExtLinksUsage.php
M includes/api/ApiQueryExternalLinks.php
M includes/api/ApiQueryFilearchive.php
M includes/api/ApiQueryGeneratorBase.php
M includes/api/ApiQueryIWBacklinks.php
M includes/api/ApiQueryIWLinks.php
M includes/api/ApiQueryImageInfo.php
M includes/api/ApiQueryImages.php
M includes/api/ApiQueryInfo.php
M includes/api/ApiQueryLangBacklinks.php
M includes/api/ApiQueryLangLinks.php
M includes/api/ApiQueryLinks.php
M includes/api/ApiQueryLogEvents.php
M includes/api/ApiQueryPagePropNames.php
M includes/api/ApiQueryPageProps.php
M includes/api/ApiQueryPagesWithProp.php
M includes/api/ApiQueryProtectedTitles.php
M includes/api/ApiQueryQueryPage.php
M includes/api/ApiQueryRandom.php
M includes/api/ApiQueryRecentChanges.php
M includes/api/ApiQueryRevisions.php
M includes/api/ApiQueryRevisionsBase.php
M includes/api/ApiQuerySearch.php
M includes/api/ApiQuerySiteinfo.php
M includes/api/ApiQueryTags.php
M includes/api/ApiQueryTokens.php
M includes/api/ApiQueryUserContributions.php
M includes/api/ApiQueryUserInfo.php
M includes/api/ApiQueryUsers.php
M includes/api/ApiQueryWatchlist.php
M includes/api/ApiQueryWatchlistRaw.php
M includes/api/ApiRevisionDelete.php
M includes/api/ApiRollback.php
M includes/api/ApiSerializable.php
M includes/api/ApiSetNotificationTimestamp.php
M includes/api/ApiSetPageLanguage.php
M includes/api/ApiTokens.php
M includes/api/ApiUnblock.php
M includes/api/ApiUndelete.php
M includes/api/ApiUpload.php
M includes/api/ApiWatch.php
M includes/skins/SkinApi.php
M includes/skins/SkinApiTemplate.php
M tests/phpunit/includes/api/query/ApiQueryBasicTest.php
M tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php
M tests/phpunit/includes/api/query/ApiQueryTestBase.php
102 files changed, 0 insertions(+), 356 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/403992/1

diff --git a/includes/MergeHistory.php b/includes/MergeHistory.php
index b969e03..0e9bb46 100644
--- a/includes/MergeHistory.php
+++ b/includes/MergeHistory.php
@@ -1,10 +1,6 @@
 
  *
  * This program is free software; you can redistribute it and/or modify
diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index 4d7ef28..6ae45d4 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -1,9 +1,5 @@
 @gmail.com"
  *
  * This program is free software; you can redistribute it and/or modify
diff --git a/includes/api/ApiBlock.php b/includes/api/ApiBlock.php
index df30a2d..f4aea98 100644

[MediaWiki-commits] [Gerrit] labs/libraryupgrader[master]: Add mediawiki/tools/minus-x to upgrade list

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403948 )

Change subject: Add mediawiki/tools/minus-x to upgrade list
..

Add mediawiki/tools/minus-x to upgrade list

It is using mediawiki/codesniffer

Change-Id: Iab89ca2f8ab7b0cabb0af2a35cccf0a0c2f8c13e
---
M upgrade.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/libraryupgrader 
refs/changes/48/403948/1

diff --git a/upgrade.py b/upgrade.py
index f6ca6f0..844a587 100755
--- a/upgrade.py
+++ b/upgrade.py
@@ -50,6 +50,7 @@
 'css-sanitizer',
 'integration/docroot',
 'labs/tools/stewardbots',
+'mediawiki/tools/minus-x',
 'mediawiki/tools/phan/SecurityCheckPlugin',
 'oojs',
 'oojs/ui',

-- 
To view, visit https://gerrit.wikimedia.org/r/403948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab89ca2f8ab7b0cabb0af2a35cccf0a0c2f8c13e
Gerrit-PatchSet: 1
Gerrit-Project: labs/libraryupgrader
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Detect variadic arguments in function comments

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403940 )

Change subject: Detect variadic arguments in function comments
..

Detect variadic arguments in function comments

Avoid false positive detection of
"Doc comment for parameter "$params" missing"
in combination with
"Doc comment for parameter $params,... does not match actual variable
name $params"
when $params is part of the argument list.
The other option, when $params is not part of the argument list,
already works.

Bug: T175504
Change-Id: I051150bdb281ae22b8a3a2638dc09e60cadf46c9
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
M MediaWiki/Tests/files/Commenting/commenting_function.php
M MediaWiki/Tests/files/Commenting/commenting_function.php.expect
M MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
4 files changed, 55 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/40/403940/1

diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php 
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index 3c63e4b..e01db1f 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -540,10 +540,21 @@
$phpcsFile->addError( $error, $tag, 
'MissingParamType' );
}
// end if
+   $isVariadicArg = substr_compare( $var, ',...', -4, 4 ) 
=== 0;
+   if ( $isVariadicArg ) {
+   // Variadic args sometimes part of the argument 
list,
+   // sometimes not. Remove the variadic indicator 
from the doc name to
+   // compare it against the real name, when it is 
part of the argument list.
+   // If it is not part of the argument list,
+   // the name of the extra paremter will not be 
checked.
+   // This does not take care for the php5.6 
...$var feature
+   $var = substr( $var, 0, -4 );
+   }
$params[] = [
'tag' => $tag,
'type' => $type,
'var' => $var,
+   'variadic_arg' => $isVariadicArg,
'comment' => $comment,
'comment_first' => $commentFirst,
'param_space' => $paramSpace,
@@ -623,7 +634,7 @@
$var = $param['var'];
// Check for unneeded punctation
$matches = [];
-   if ( preg_match( 
'/^(.*?)((?:(?![\[\]_{}])\p{P})+)(?addFixableError(
'Param name should not end with 
punctuation "%s"',
$param['tag'],
@@ -656,7 +667,7 @@
$error .= 'actual variable name %s';
$phpcsFile->addError( $error, 
$param['tag'], $code, $data );
}
-   } elseif ( substr( $var, -4 ) !== ',...' ) {
+   } elseif ( !$param['variadic_arg'] ) {
// We must have an extra parameter comment.
$error = 'Superfluous parameter comment';
$phpcsFile->addError( $error, $param['tag'], 
'ExtraParamComment' );
@@ -746,6 +757,9 @@
$content  = $fixParam['type'];
$content .= str_repeat( ' ', $fixParam['type_space'] );
$content .= $fixParam['var'];
+   if ( $fixParam['variadic_arg'] ) {
+   $content .= ',...';
+   }
$content .= str_repeat( ' ', $fixParam['var_space'] );
$content .= $fixParam['comment_first'];
$phpcsFile->fixer->replaceToken( ( $fixParam['tag'] + 2 ), 
$content );
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php 
b/MediaWiki/Tests/files/Commenting/commenting_function.php
index fc48879..6d9e69e 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php
@@ -185,6 +185,22 @@
$out = $in * $inOut;
$inOut = $in / $out;
}
+
+   /**
+* Test with variadic argument in the list
+* @param string $key A comment
+* @param string $params,... A comment
+*/
+   public function testVariadicArgInArgList( $key, $params /* ... */ ) {
+   }
+
+   /**
+* Test with variadic argument not in the list
+* @param string $key A comment
+* 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: List new comment tables in ParserTestRunner

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403834 )

Change subject: List new comment tables in ParserTestRunner
..

List new comment tables in ParserTestRunner

Running the parser tests while in the migration,
some tables are missing.

Bug: T182416
Change-Id: I1010f4a35e5bf4626e522629447e43c413a05668
---
M tests/parser/ParserTestRunner.php
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/403834/1

diff --git a/tests/parser/ParserTestRunner.php 
b/tests/parser/ParserTestRunner.php
index e07d4a0..6cf1fca 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -1151,6 +1151,8 @@
 * @return array
 */
private function listTables() {
+   global $wgCommentTableSchemaMigrationStage;
+
$tables = [ 'user', 'user_properties', 'user_former_groups', 
'page', 'page_restrictions',
'protected_titles', 'revision', 'ip_changes', 'text', 
'pagelinks', 'imagelinks',
'categorylinks', 'templatelinks', 'externallinks', 
'langlinks', 'iwlinks',
@@ -1160,6 +1162,13 @@
'archive', 'user_groups', 'page_props', 'category'
];
 
+   if ( $wgCommentTableSchemaMigrationStage >= 
MIGRATION_WRITE_BOTH ) {
+   // The new tables for comments are in use
+   $tables[] = 'comment';
+   $tables[] = 'revision_comment_temp';
+   $tables[] = 'image_comment_temp';
+   }
+
if ( in_array( $this->db->getType(), [ 'mysql', 'sqlite', 
'oracle' ] ) ) {
array_push( $tables, 'searchindex' );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/403834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1010f4a35e5bf4626e522629447e43c413a05668
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...XAnalytics[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403748 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ia6381370eae10170f45764a9a347020d994f2719
---
M .phpcs.xml
M XAnalytics.class.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/XAnalytics 
refs/changes/48/403748/1

diff --git a/.phpcs.xml b/.phpcs.xml
index e853884..f189ea1 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,10 @@
 


-   



.

-   
-   vendor
-   node_modules
+   
 
diff --git a/XAnalytics.class.php b/XAnalytics.class.php
index 6bc939e..f0e2bed 100644
--- a/XAnalytics.class.php
+++ b/XAnalytics.class.php
@@ -8,6 +8,7 @@
 * @var bool
 */
private static $addedHeader = false;
+
/**
 * Set X-Analytics header before the output buffer is flushed.
 *
@@ -22,6 +23,8 @@
 * by calling XAnalytics;:addItem().
 *
 * @see https://wikitech.wikimedia.org/wiki/X-Analytics
+* @param OutputPage &$out
+* @param Skin &$skin
 */
public static function onBeforePageDisplay( OutputPage &$out, Skin 
&$skin ) {
self::generateHeader( $out );

-- 
To view, visit https://gerrit.wikimedia.org/r/403748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6381370eae10170f45764a9a347020d994f2719
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/XAnalytics
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ApiFeatureUsage[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403747 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I49afc5b8691659821ceeae2ae0ba5f6ab1ac5b9c
---
M .phpcs.xml
M ApiFeatureUsageQueryEngine.php
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApiFeatureUsage 
refs/changes/47/403747/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d87bc24..150a1ab 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,7 +4,6 @@



-   


.
diff --git a/ApiFeatureUsageQueryEngine.php b/ApiFeatureUsageQueryEngine.php
index a7b12f0..7154658 100644
--- a/ApiFeatureUsageQueryEngine.php
+++ b/ApiFeatureUsageQueryEngine.php
@@ -3,6 +3,7 @@
public $options;
 
/**
+* @param Config $config
 * @return ApiFeatureUsageQueryEngine
 */
public static function getEngine( Config $config ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49afc5b8691659821ceeae2ae0ba5f6ab1ac5b9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiFeatureUsage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CookieWarning[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403744 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I8ee2396e6a804ab69965383a9ee6b30787c1f9af
---
M .phpcs.xml
M includes/CookieWarning.hooks.php
2 files changed, 10 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CookieWarning 
refs/changes/44/403744/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 001deda..38b0041 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,12 +3,9 @@



-   
-   


.

-   
-   vendor
+   
 
diff --git a/includes/CookieWarning.hooks.php b/includes/CookieWarning.hooks.php
index 22beb7e..d4d21c7 100644
--- a/includes/CookieWarning.hooks.php
+++ b/includes/CookieWarning.hooks.php
@@ -9,10 +9,10 @@
 * If the disablecookiewarning POST data is send, disables the 
cookiewarning bar with a
 * cookie or a user preference, if the user is logged in.
 *
-* @param Title $title
-* @param null $unused
-* @param OutputPage $output
-* @param User $user
+* @param Title &$title
+* @param null &$unused
+* @param OutputPage &$output
+* @param User &$user
 * @param WebRequest $request
 * @param MediaWiki $mediawiki
 */
@@ -36,8 +36,8 @@
 *
 * Adds the CookieWarning information bar to the output html.
 *
-* @param SkinTemplate $sk
-* @param QuickTemplate $tpl
+* @param SkinTemplate &$sk
+* @param QuickTemplate &$tpl
 */
public static function onSkinTemplateOutputPageBeforeExec(
SkinTemplate &$sk, QuickTemplate &$tpl
@@ -157,7 +157,7 @@
/**
 * ResourceLoaderGetConfigVars hook handler.
 *
-* @param array $vars
+* @param array &$vars
 */
public static function onResourceLoaderGetConfigVars( array &$vars ) {
$conf = self::getConfig();
@@ -186,7 +186,7 @@
 * this page.
 *
 * @param IContextSource $context
-* @return boolean Returns true, if the cookie warning should be 
visible, false otherwise.
+* @return bool Returns true, if the cookie warning should be visible, 
false otherwise.
 */
private static function showWarning( IContextSource $context ) {
$user = $context->getUser();
@@ -253,7 +253,7 @@
 * @see https://www.mediawiki.org/wiki/Manual:Hooks/GetPreferences
 *
 * @param User $user
-* @param array $defaultPreferences
+* @param array &$defaultPreferences
 * @return bool
 */
public static function onGetPreferences( User $user, 
&$defaultPreferences ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ee2396e6a804ab69965383a9ee6b30787c1f9af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CookieWarning
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PagePopups[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403741 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Id7411295a7c1b2462f1e73efc52d5df8d2d3f750
---
M .phpcs.xml
M PagePopups.hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PagePopups 
refs/changes/41/403741/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 4077be7..5c2c9f8 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
 


-   
-   



.

-   
-   vendor
+   
tests/test.inc
 
diff --git a/PagePopups.hooks.php b/PagePopups.hooks.php
index 718ae2a..5ef304b 100644
--- a/PagePopups.hooks.php
+++ b/PagePopups.hooks.php
@@ -2,8 +2,8 @@
 
 class PagePopupsHooks {
/**
-* @param Skin $skin
-* @param string $text
+* @param OutputPage &$out
+* @param Skin &$skin
 * @return bool
 */
public static function onBeforePageDisplay( OutputPage &$out, Skin 
&$skin ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7411295a7c1b2462f1e73efc52d5df8d2d3f750
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagePopups
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Memento[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403740 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ie97524f0e613a8438633ed78e74560b415a015d2
---
M .phpcs.xml
M Memento/Memento.body.php
M Memento/MementoResource.php
M Memento/TimeMap.php
M Memento/TimeMapResource.php
M tests/lib/HTTPFetch.php
M tests/lib/MementoParse.php
M tests/lib/TestSupport.php
8 files changed, 47 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Memento 
refs/changes/40/403740/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 545cabc..2dc2bbf 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   



@@ -12,10 +10,8 @@



-   


-   

.

diff --git a/Memento/Memento.body.php b/Memento/Memento.body.php
index 516904c..7b3ec7e 100644
--- a/Memento/Memento.body.php
+++ b/Memento/Memento.body.php
@@ -34,17 +34,17 @@
 class Memento {
 
/**
-* @var MementoResource $mementoResource: object that implements memento
+* @var MementoResource $mementoResource object that implements memento
 */
private $mementoResource;
 
/**
-* @var string $articleDatetime: datetime of the article loaded
+* @var string $articleDatetime datetime of the article loaded
 */
private $articleDatetime;
 
/**
-* @var boolean $oldIDSet: flag to indicate if this is an oldid page
+* @var bool $oldIDSet flag to indicate if this is an oldid page
 */
private $oldIDSet;
 
@@ -52,13 +52,13 @@
 * The ImageBeforeProduce HTML hook, used here to provide datetime
 * negotiation for embedded images.
 *
-* @param Skin $skin Skin object for this page
-* @param Title $title Title object for this image
-* @param File $file File object for this image
-* @param array $frameParams frame parameters
-* @param array $handlerParams handler parameters
-* @param string $time not really used by hook
-* @param string $res used to replace HTML for image rendering
+* @param Skin &$skin Skin object for this page
+* @param Title &$title Title object for this image
+* @param File &$file File object for this image
+* @param array &$frameParams frame parameters
+* @param array &$handlerParams handler parameters
+* @param string &$time not really used by hook
+* @param string &$res used to replace HTML for image rendering
 *
 * @return bool indicating whether caller should use $res instead of
 *  default HTML for image rendering
@@ -90,8 +90,8 @@
 *
 * @param Parser $parser Parser object for this page
 * @param Title $title Title object for this page
-* @param bool $skip boolean flag allowing the caller to skip the rest 
of statelessFetchTemplate
-* @param int $id revision id of this page
+* @param bool &$skip boolean flag allowing the caller to skip the rest 
of statelessFetchTemplate
+* @param int &$id revision id of this page
 *
 * @return bool indicating success to the caller
 */
@@ -112,10 +112,10 @@
 *
 * Note: this is not called when the Edit, Diff or History pages are 
loaded.
 *
-* @param Article $article pointer to the Article Object from the hook
-* @param bool $outputDone pointer to variable that indicates that
+* @param Article &$article pointer to the Article Object from the hook
+* @param bool &$outputDone pointer to variable that indicates that
 * the output should be terminated
-* @param bool $pcache pointer to variable that indicates whether the 
parser
+* @param bool &$pcache pointer to variable that indicates whether the 
parser
 *  cache should try retrieving the cached results
 *
 * @return bool indicating success to the caller
diff --git a/Memento/MementoResource.php b/Memento/MementoResource.php
index cfdd146..426491b 100644
--- a/Memento/MementoResource.php
+++ b/Memento/MementoResource.php
@@ -463,7 +463,7 @@
 * @fixme make this compatible with parser cache
 * @param Title $title
 * @param Parser $parser
-* @param int $id
+* @param int &$id
 *
 * @return array containing the text, finalTitle, and deps
 */
diff --git a/Memento/TimeMap.php b/Memento/TimeMap.php
index 8b4e9cb..5d537d7 100644
--- a/Memento/TimeMap.php
+++ b/Memento/TimeMap.php
@@ -53,7 +53,7 @@
 * The init 

[MediaWiki-commits] [Gerrit] mediawiki...OOJsUIAjaxLogin[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403739 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I7702c3019bd003e6ba79266c217c04961e007767
---
M .phpcs.xml
M includes/OOJsUIAjaxLogin.hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OOJsUIAjaxLogin 
refs/changes/39/403739/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 91829ee..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,12 +2,9 @@
 


-   
-   


.

-   
-   vendor
+   
 
diff --git a/includes/OOJsUIAjaxLogin.hooks.php 
b/includes/OOJsUIAjaxLogin.hooks.php
index 9bad91b..6fd52d7 100644
--- a/includes/OOJsUIAjaxLogin.hooks.php
+++ b/includes/OOJsUIAjaxLogin.hooks.php
@@ -4,8 +4,8 @@
/**
 * BeforePageDisplay hook handler. Add the required module for this 
extension.
 *
-* @param OutputPage $out
-* @param Skin $sk
+* @param OutputPage &$out
+* @param Skin &$sk
 */
public static function onBeforePageDisplay( OutputPage &$out, Skin &$sk 
) {
if ( !$out->getUser()->isLoggedIn() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7702c3019bd003e6ba79266c217c04961e007767
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OOJsUIAjaxLogin
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GPGMail[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403737 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I680630cff5b558037450be8e53f9a6fa660716a4
---
M .phpcs.xml
M GPGMailHooks.php
2 files changed, 12 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GPGMail 
refs/changes/37/403737/1

diff --git a/.phpcs.xml b/.phpcs.xml
index c2c9ce3..d1b5f11 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,11 +2,8 @@
 


-   
-   

.

-   
-   vendor
+   
 
diff --git a/GPGMailHooks.php b/GPGMailHooks.php
index 8b7fe20..80fb27e 100644
--- a/GPGMailHooks.php
+++ b/GPGMailHooks.php
@@ -29,7 +29,7 @@
/**
 * Add GPG checkbox + key textbox to user preferences.
 * @param User $user
-* @param array $preferences
+* @param array &$preferences
 * @return bool
 */
public static function onGetPreferences( User $user, array 
&$preferences ) {
@@ -51,7 +51,7 @@
 
/**
 * Prevent bulk mailing users who requested encryption
-* @param MailAddress[] $to
+* @param MailAddress[] &$to
 * @return bool
 */
public static function onUserMailerSplitTo( &$to ) {
@@ -71,8 +71,8 @@
/**
 * @param MailAddress[] $to
 * @param MailAddress $from
-* @param string|array $body Email plaintext or an array with 'text' 
and 'html' keys
-* @param Message|string $error Error message when encryption fails
+* @param string|array &$body Email plaintext or an array with 'text' 
and 'html' keys
+* @param Message|string &$error Error message when encryption fails
 * @return bool
 */
public static function onUserMailerTransformContent( array $to, $from, 
&$body, &$error ) {
@@ -105,10 +105,10 @@
/**
 * @param MailAddress[] $to
 * @param MailAddress $from
-* @param string $subject Email subject (not MIME encoded)
-* @param array $headers Email headers
-* @param string $body Email body (MIME-encoded)
-* @param Message|string $error Error message when encryption fails
+* @param string &$subject Email subject (not MIME encoded)
+* @param array &$headers Email headers
+* @param string &$body Email body (MIME-encoded)
+* @param Message|string &$error Error message when encryption fails
 * @return bool
 */
public static function onUserMailerTransformMessage( $to, $from,
@@ -151,7 +151,7 @@
 
/**
 * Encrypts the message if the target user asked for that.
-* @param string $text Text of the message
+* @param string &$text Text of the message
 * @param User $user User to whom the message will be sent
 * @return Status Success or an error message
 */
@@ -170,8 +170,8 @@
}
 
/**
-* @param array $headers Email headers
-* @param string $body Email body (MIME-encoded)
+* @param array &$headers Email headers
+* @param string &$body Email body (MIME-encoded)
 * @param User $user User to whom the message will be sent
 * @return Status Success or an error message
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/403737
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I680630cff5b558037450be8e53f9a6fa660716a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GPGMail
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ShowMe[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403735 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ia3af80241b82c2c09e9e4588873fdd54883ef48c
---
M .phpcs.xml
M ShowMe.hooks.php
2 files changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ShowMe 
refs/changes/35/403735/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 93dbffe..d46c55a 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
 


-   
-   




.

-   
-   vendor
+   
 
diff --git a/ShowMe.hooks.php b/ShowMe.hooks.php
index 4109ced..2a9ec48 100644
--- a/ShowMe.hooks.php
+++ b/ShowMe.hooks.php
@@ -10,7 +10,7 @@
 
/**
 *
-* @param Parser $parser
+* @param Parser &$parser
 * @return bool
 */
public static function onParserFirstCallInit( Parser &$parser ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3af80241b82c2c09e9e4588873fdd54883ef48c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ShowMe
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...StopForumSpam[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403733 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I66c80966b9c826819f3985630720a7078e7326ef
---
M .phpcs.xml
M includes/Hooks.php
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/StopForumSpam 
refs/changes/33/403733/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 6ad584b..06b0951 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,8 +3,6 @@



-   
-   



@@ -12,5 +10,4 @@
.


-   vendor
 
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 15d71b8..2f4a3f5 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -104,8 +104,8 @@
/**
 * If an IP address is blacklisted, don't let them edit.
 *
-* @param Title $title Title being acted upon
-* @param User $user User performing the action
+* @param Title &$title Title being acted upon
+* @param User &$user User performing the action
 * @param string $action Action being performed
 * @param array &$result Will be filled with block status if blocked
 * @return bool
@@ -162,7 +162,7 @@
}
 
/**
-* @param array $msg
+* @param array &$msg
 * @param string $ip
 * @return bool
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/403733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66c80966b9c826819f3985630720a7078e7326ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/StopForumSpam
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BaseHooks[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403732 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I7a40173b54998a3a34fbf2d294c1f71d6ccd61a3
---
M .phpcs.xml
M BaseHooks.hooks.php
2 files changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BaseHooks 
refs/changes/32/403732/1

diff --git a/.phpcs.xml b/.phpcs.xml
index c17605e..2b3c5a5 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
 


-   
-   



.

-   
-   vendor
+   
tests/test.inc
 
diff --git a/BaseHooks.hooks.php b/BaseHooks.hooks.php
index ea3e04c..5e1dcdd 100644
--- a/BaseHooks.hooks.php
+++ b/BaseHooks.hooks.php
@@ -3,7 +3,7 @@
 class BaseHooksHooks {
/**
 * @param Skin $skin
-* @param string $text
+* @param string &$text
 * @return bool
 */
public static function onSkinAfterBottomScripts( Skin $skin, &$text = 
'' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a40173b54998a3a34fbf2d294c1f71d6ccd61a3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BaseHooks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AJAXPoll[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403729 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I11cdca3812a6bb6d93ffbc916a632b6589ca70b9
---
M .phpcs.xml
M includes/AJAXPoll.class.php
2 files changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AJAXPoll 
refs/changes/29/403729/1

diff --git a/.phpcs.xml b/.phpcs.xml
index bd7b626..3a6373b 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,9 +2,6 @@
 


-   
-   
-   



@@ -15,6 +12,5 @@

.

-   
-   vendor
+   
 
diff --git a/includes/AJAXPoll.class.php b/includes/AJAXPoll.class.php
index cc22178..a395a97 100644
--- a/includes/AJAXPoll.class.php
+++ b/includes/AJAXPoll.class.php
@@ -18,7 +18,7 @@
/**
 * Register  tag with the parser
 *
-* @param parser Parser (not necessarily $wgParser
+* @param Parser $parser (not necessarily $wgParser
 * @return bool true
 */
static function onParserInit( $parser ) {
@@ -27,7 +27,14 @@
return true;
}
 
-   # The callback function for converting the input text to HTML output
+   /**
+* The callback function for converting the input text to HTML output
+* @param string $input
+* @param array $args
+* @param Parser $parser
+* @param PPFrame $frame
+* @return string
+*/
static function AJAXPollRender( $input, $args = [], Parser $parser, 
$frame ) {
global $wgUser, $wgRequest, $wgUseAjax;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/403729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11cdca3812a6bb6d93ffbc916a632b6589ca70b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AJAXPoll
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MolHandler[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403723 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ieb0b5e4f58fccbf8e8376e56023488b3d2b87ee6
---
M .phpcs.xml
M MolHandler.mime.php
M MolHandlerHooks.php
3 files changed, 7 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MolHandler 
refs/changes/23/403723/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 1447505..6f3c89d 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,10 +1,7 @@
 
 

-   

-   
-   



@@ -12,6 +9,4 @@
.


-   vendor
-   node_modules
 
diff --git a/MolHandler.mime.php b/MolHandler.mime.php
index a581d7e..f0e20d3 100644
--- a/MolHandler.mime.php
+++ b/MolHandler.mime.php
@@ -28,7 +28,6 @@
 * Hook: MimeMagicInit.
 *
 * @param MimeMagic $mimeMagic
-* @param object $addToList Callback function
 * @return bool Always true
 */
public static function onMimeMagicInit( $mimeMagic ) {
@@ -84,7 +83,7 @@
 *
 * @param MimeMagic $mimeMagic
 * @param string $ext File extension
-* @param string $mime In: Previously detected MIME; Out: Improved MIME
+* @param string &$mime In: Previously detected MIME; Out: Improved MIME
 * @return bool Always true
 */
public static function onMimeMagicImproveFromExtension( $mimeMagic, 
$ext, &$mime ) {
@@ -95,8 +94,8 @@
/**
 * Guess chemical MIME types from file content.
 *
-* @param string $head 1024 bytes of the head
-* @param string $tail 1024 bytes of the tail
+* @param string &$head 1024 bytes of the head
+* @param string &$tail 1024 bytes of the tail
 * @param string $file
 * @return bool|string Mime type
 */
@@ -154,10 +153,10 @@
 * Hook: MimeMagicGuessFromContent.
 *
 * @param MimeMagic $mimeMagic
-* @param string $head
-* @param string $tail
+* @param string &$head
+* @param string &$tail
 * @param string $file
-* @param string $mime
+* @param string &$mime
 * @return bool Always true
 */
public static function onMimeMagicGuessFromContent(
diff --git a/MolHandlerHooks.php b/MolHandlerHooks.php
index 76e0e57..92e03a7 100644
--- a/MolHandlerHooks.php
+++ b/MolHandlerHooks.php
@@ -2,7 +2,7 @@
 class MolHandlerHooks {
/**
 * Hook to add unit tests
-* @param array $files list of testcases
+* @param array &$files list of testcases
 * @return bool
 */
public static function onUnitTestsList( array &$files ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb0b5e4f58fccbf8e8376e56023488b3d2b87ee6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MolHandler
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403721 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I4962326963f80afa0c295121c82b0f53dff4740e
---
M .phpcs.xml
M includes/Query/CompSuggestQueryBuilder.php
M includes/Query/NearMatchQueryBuilder.php
M includes/Query/PrefixSearchQueryBuilder.php
M maintenance/saneitizeJobs.php
M tests/unit/Maintenance/AnalysisConfigBuilderTest.php
M tests/unit/Query/FullTextQueryStringQueryBuilder.php
M tests/unit/Query/QueryHelperTest.php
M tests/unit/SearcherTest.php
M tests/unit/SuggestScoringTest.php
10 files changed, 16 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/21/403721/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 124fc11..a700742 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -6,7 +6,6 @@



-   



diff --git a/includes/Query/CompSuggestQueryBuilder.php 
b/includes/Query/CompSuggestQueryBuilder.php
index 2a0c19b..fbd0f92 100644
--- a/includes/Query/CompSuggestQueryBuilder.php
+++ b/includes/Query/CompSuggestQueryBuilder.php
@@ -201,7 +201,7 @@
 *
 * @param CompletionResultsCollector $collector
 * @param ResultSet $results
-* @param $indexName
+* @param string $indexName
 * @return int total hits
 */
public function postProcess( CompletionResultsCollector $collector, 
ResultSet $results, $indexName ) {
diff --git a/includes/Query/NearMatchQueryBuilder.php 
b/includes/Query/NearMatchQueryBuilder.php
index ddd8164..4cf0a25 100644
--- a/includes/Query/NearMatchQueryBuilder.php
+++ b/includes/Query/NearMatchQueryBuilder.php
@@ -13,7 +13,7 @@
 
/**
 * @param SearchContext $searchContext the search context
-* @param $term string the original search term
+* @param string $term the original search term
 * @throws \ApiUsageException if the query is too long
 */
public function build( SearchContext $searchContext, $term ) {
diff --git a/includes/Query/PrefixSearchQueryBuilder.php 
b/includes/Query/PrefixSearchQueryBuilder.php
index cacbbb3..07bc595 100644
--- a/includes/Query/PrefixSearchQueryBuilder.php
+++ b/includes/Query/PrefixSearchQueryBuilder.php
@@ -16,7 +16,7 @@
 
/**
 * @param SearchContext $searchContext the search context
-* @param $term string the original search term
+* @param string $term the original search term
 * @param array|null $variants list of variants
 * @throws \ApiUsageException if the query is too long
 */
diff --git a/maintenance/saneitizeJobs.php b/maintenance/saneitizeJobs.php
index 65a99bc..f1c1f1f 100644
--- a/maintenance/saneitizeJobs.php
+++ b/maintenance/saneitizeJobs.php
@@ -307,8 +307,8 @@
}
 
/**
-* @param $lastLoop int|null last loop start time
-* @param $minLoopDuration int minimal duration of a loop
+* @param int|null $lastLoop last loop start time
+* @param int $minLoopDuration minimal duration of a loop
 * @return bool true if minLoopDuration is not reached false otherwize
 */
private function checkMinLoopDuration( $lastLoop, $minLoopDuration ) {
diff --git a/tests/unit/Maintenance/AnalysisConfigBuilderTest.php 
b/tests/unit/Maintenance/AnalysisConfigBuilderTest.php
index 9f11ee7..fcd8aa4 100644
--- a/tests/unit/Maintenance/AnalysisConfigBuilderTest.php
+++ b/tests/unit/Maintenance/AnalysisConfigBuilderTest.php
@@ -394,8 +394,8 @@
 *  the results of generation obvious and tracked in git
 *
 * @dataProvider provideLanguageAnalysis
-* @param $expected
-* @param $langCode
+* @param mixed $expected
+* @param string $langCode
 * @param array $extraConfig
 */
public function testLanguageAnalysis( $expected, $langCode, array 
$extraConfig ) {
diff --git a/tests/unit/Query/FullTextQueryStringQueryBuilder.php 
b/tests/unit/Query/FullTextQueryStringQueryBuilder.php
index a4503ef..55aa9a4 100644
--- a/tests/unit/Query/FullTextQueryStringQueryBuilder.php
+++ b/tests/unit/Query/FullTextQueryStringQueryBuilder.php
@@ -123,6 +123,8 @@
 
/**
 * @dataProvider syntaxUsedProvider
+* @param string $term
+* @param array $expected
 */
public function testSyntaxUsed( $term, $expected ) {
// To make things a little more consistent with how it is
diff --git a/tests/unit/Query/QueryHelperTest.php 
b/tests/unit/Query/QueryHelperTest.php
index ccd37db..85e763f 100644
--- a/tests/unit/Query/QueryHelperTest.php
+++ b/tests/unit/Query/QueryHelperTest.php
@@ -11,10 +11,10 @@
/**
 * @dataProvider provideMatchPage
 *
-* 

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmAccount[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403717 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I964cfc2d2563e617a195d6b2b6f0acab4dea4efc
---
M .phpcs.xml
M ConfirmAccount.setup.php
M backend/ConfirmAccount.class.php
M backend/UserAccountRequest.php
M business/AccountConfirmSubmission.php
M business/AccountRequestSubmission.php
M frontend/ConfirmAccountUI.hooks.php
M frontend/ConfirmAccountUI.setup.php
M frontend/specialpages/actions/ConfirmAccount_body.php
M frontend/specialpages/actions/ConfirmAccountsPager.php
M frontend/specialpages/actions/RequestAccount_body.php
M frontend/specialpages/actions/UserCredentials_body.php
12 files changed, 51 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmAccount 
refs/changes/17/403717/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 31951f0..bcfe27a 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,9 +4,6 @@



-   
-   
-   



diff --git a/ConfirmAccount.setup.php b/ConfirmAccount.setup.php
index 31497e0..4c6023f 100644
--- a/ConfirmAccount.setup.php
+++ b/ConfirmAccount.setup.php
@@ -7,10 +7,9 @@
 * Register source code paths.
 * This function must NOT depend on any config vars.
 *
-* @param $classes Array $classes
-* @param $messagesDirs Array $messagesDirs
-* @param $messagesFiles Array $messagesFiles
-* @return void
+* @param array &$classes
+* @param array &$messagesDirs
+* @param array &$messagesFiles
 */
public static function defineSourcePaths(
array &$classes, array &$messagesDirs, array &$messagesFiles
diff --git a/backend/ConfirmAccount.class.php b/backend/ConfirmAccount.class.php
index 39c635d..c9aa4a3 100644
--- a/backend/ConfirmAccount.class.php
+++ b/backend/ConfirmAccount.class.php
@@ -82,7 +82,7 @@
 * Generate, store, and return a new email confirmation code.
 * A hash (unsalted since it's used as a key) is stored.
 * @param User $user
-* @param string $expiration
+* @param string &$expiration
 * @return string
 */
public static function getConfirmationToken( $user, &$expiration ) {
@@ -125,7 +125,7 @@
/**
 * Get a request name from an email confirmation token
 *
-* @param $code string
+* @param string $code
 * @return string|false
 */
public static function requestNameFromEmailToken( $code ) {
@@ -141,8 +141,8 @@
 
/**
 * Get the number of account requests for a request type
-* @param $type int
-* @return Array Assosiative array with 'open', 'held', 'type' keys 
mapping to integers
+* @param int $type
+* @return array Assosiative array with 'open', 'held', 'type' keys 
mapping to integers
 */
public static function getOpenRequestCount( $type ) {
$dbr = wfGetDB( DB_REPLICA );
@@ -163,7 +163,7 @@
 
/**
 * Get the number of open email-confirmed account requests for a 
request type
-* @param $type int|string A request type or '*' for all
+* @param int|string $type A request type or '*' for all
 * @return int
 */
public static function getOpenEmailConfirmedCount( $type = '*' ) {
diff --git a/backend/UserAccountRequest.php b/backend/UserAccountRequest.php
index e24da51..2481648 100644
--- a/backend/UserAccountRequest.php
+++ b/backend/UserAccountRequest.php
@@ -32,7 +32,7 @@
}
 
/**
-* @param $row
+* @param stdClass $row
 * @return UserAccountRequest
 */
public static function newFromRow( $row ) {
@@ -68,7 +68,7 @@
}
 
/**
-* @param $fields array
+* @param array $fields
 * @return UserAccountRequest
 */
public static function newFromArray( array $fields ) {
@@ -121,8 +121,8 @@
}
 
/**
-* @param $id int
-* @param $from string|null 'dbmaster' to use DB master
+* @param int $id
+* @param string|null $from 'dbmaster' to use DB master
 * @return UserAccountRequest|null
 */
public static function newFromId( $id, $from = null ) {
@@ -137,8 +137,8 @@
}
 
/**
-* @param $name string
-* @param $from string|null 'dbmaster' to use DB master
+* @param string $name
+* @param string|null $from 'dbmaster' to use DB master
 * @return UserAccountRequest|null
 */
public static function newFromName( $name, $from = null ) {
@@ -209,7 +209,7 @@
}
 
/**
-* @param $flat string Use 'flat' to get a raw 

[MediaWiki-commits] [Gerrit] mediawiki...XenForoAuth[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403714 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I7ef1922b8a3fffca7366e67fb481637bdc870509
---
M .phpcs.xml
M includes/Hooks.php
M includes/XenForoUser.php
3 files changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/XenForoAuth 
refs/changes/14/403714/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 336d3de..6cc1952 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,9 @@
 


-   
-   
-   


.

-   
-   vendor
+   
 
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 29549f3..6334108 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -30,7 +30,7 @@
 * @param array $requests
 * @param array $fieldInfo
 * @param array $formDescriptor
-* @param $action
+* @param string $action
 */
public static function onAuthChangeFormFields( array $requests, array 
$fieldInfo,
array &$formDescriptor, $action
diff --git a/includes/XenForoUser.php b/includes/XenForoUser.php
index dd2bace..29adb3c 100644
--- a/includes/XenForoUser.php
+++ b/includes/XenForoUser.php
@@ -111,7 +111,7 @@
/**
 * Check, if the XenForo user ID is already connected to another wiki 
account or not.
 *
-* @param $id
+* @param string $xfUserId
 * @param int $flags
 * @return bool
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/403714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ef1922b8a3fffca7366e67fb481637bdc870509
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/XenForoAuth
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LifeWeb[master]: Exclude /lib/ from phpcs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403713 )

Change subject: Exclude /lib/ from phpcs
..

Exclude /lib/ from phpcs

Change-Id: Idb5873575e99fa9439b0e4938fb46cd94649e938
---
M .phpcs.xml
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LifeWeb 
refs/changes/13/403713/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 4259c51..2a28a16 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,11 +2,6 @@
 


-   
-   
-   
-   
-   



@@ -14,4 +9,5 @@
.


+   ./lib/*
 

-- 
To view, visit https://gerrit.wikimedia.org/r/403713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb5873575e99fa9439b0e4938fb46cd94649e938
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LifeWeb
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TweetANew[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403709 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ie735da8dfffa57129d8a2e1bd8156af1080fd9ff
---
M .phpcs.xml
M TweetANew.body.php
M TweetANew.php
3 files changed, 16 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TweetANew 
refs/changes/09/403709/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 25901c7..0b6785e 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,7 @@
 


-   
-   
+   



diff --git a/TweetANew.body.php b/TweetANew.body.php
index 1ac1358..7c9fce1 100644
--- a/TweetANew.body.php
+++ b/TweetANew.body.php
@@ -14,9 +14,9 @@
/**
 * Function for tweeting new wiki pages
 *
-* @param $wikiPage WikiPage
-* @param $user User
-* @param $summary
+* @param WikiPage $wikiPage
+* @param User $user
+* @param string $summary
 *
 * @return bool
 */
@@ -87,11 +87,11 @@
/**
 * Function for tweeting edited articles
 *
-* @param $wikiPage WikiPage
-* @param $user User
-* @param $content Content
-* @param $summary string
-* @param $isMinor bool
+* @param WikiPage $wikiPage
+* @param User $user
+* @param Content $content
+* @param string $summary
+* @param bool $isMinor
 *
 * @return bool
 */
@@ -216,7 +216,7 @@
/**
 * Function shortening url via outside service or leaving for t.co 
service if none are enabled
 *
-* @param $longurl
+* @param string $longurl
 *
 * @return string
 */
@@ -249,9 +249,9 @@
/**
 * Function for connecting to Twitter, preparing and then sending tweet
 *
-* @param $wikiPage WikiPage
-* @param $tweet_text
-* @param $finalurl
+* @param WikiPage $wikiPage
+* @param string $tweet_text
+* @param string $finalurl
 *
 * @return bool
 */
diff --git a/TweetANew.php b/TweetANew.php
index 838cfc1..bb7e31b 100644
--- a/TweetANew.php
+++ b/TweetANew.php
@@ -211,9 +211,9 @@
 /**
  * Function for tweeting about new or edited articles when auto-tweet if 
disabled
  *
- * @param $editpage
- * @param $checkboxes
- * @param $tabindex
+ * @param EditPage $editpage
+ * @param array &$checkboxes
+ * @param null|int &$tabindex
  *
  * @return bool
  */

-- 
To view, visit https://gerrit.wikimedia.org/r/403709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie735da8dfffa57129d8a2e1bd8156af1080fd9ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TweetANew
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403708 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I7e32340cca77ec4989a9be6d7ac93b1f1aeb6587
---
M .phpcs.xml
M includes/SpecialOverrideThrottle.php
M includes/ThrottleOverrideHooks.php
3 files changed, 3 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ThrottleOverride 
refs/changes/08/403708/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d47a43e..50e2c6c 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,9 +2,6 @@
 


-   
-   
-   



diff --git a/includes/SpecialOverrideThrottle.php 
b/includes/SpecialOverrideThrottle.php
index 70f96d7..77414e7 100644
--- a/includes/SpecialOverrideThrottle.php
+++ b/includes/SpecialOverrideThrottle.php
@@ -242,7 +242,7 @@
 * @param string $target IP address or range
 * @param string|bool $expiry
 * @param string $types
-* $param array $parsedRange
+* @param array $parsedRange
 * @return array
 */
public static function validateFields( $target, $expiry, $types, 
$parsedRange ) {
diff --git a/includes/ThrottleOverrideHooks.php 
b/includes/ThrottleOverrideHooks.php
index 43bb38b..16083e0 100644
--- a/includes/ThrottleOverrideHooks.php
+++ b/includes/ThrottleOverrideHooks.php
@@ -37,9 +37,9 @@
/**
 * @throws InvalidArgumentException If $action is invalid
 *
-* @param User $user
+* @param User &$user
 * @param string $action
-* @param $result
+* @param bool &$result
 * @param null|string $ip
 *
 * @return bool

-- 
To view, visit https://gerrit.wikimedia.org/r/403708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e32340cca77ec4989a9be6d7ac93b1f1aeb6587
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Patroller[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403706 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I947c4e867eb68efeaeafd821597413a2fe8f6fa5
---
M .phpcs.xml
M Patroller.hooks.php
M SpecialPatroller.php
3 files changed, 22 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Patroller 
refs/changes/06/403706/1

diff --git a/.phpcs.xml b/.phpcs.xml
index bc1c593..aae442c 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,8 +1,6 @@
 
 

-   
-   



@@ -10,6 +8,5 @@

.

-   
-   vendor
+   
 
diff --git a/Patroller.hooks.php b/Patroller.hooks.php
index daf23a5..b1b070c 100644
--- a/Patroller.hooks.php
+++ b/Patroller.hooks.php
@@ -14,9 +14,8 @@
/**
 * Setup the database tables
 *
-* @access  public
-* @param   class   The updater
-* @return  void
+* @param DatabaseUpdater $updater The updater
+* @return void
 */
public static function onLoadExtensionSchemaUpdates( $updater ) {
$updater->addExtensionTable( 'patrollers', __DIR__ . 
'/sql/add-patrollers.sql' );
diff --git a/SpecialPatroller.php b/SpecialPatroller.php
index f10d9ba..30c653e 100644
--- a/SpecialPatroller.php
+++ b/SpecialPatroller.php
@@ -14,7 +14,7 @@
/**
 * Constructor
 *
-* @return  void
+* @return void
 */
public function __construct() {
parent::__construct( 'Patrol', 'patroller' );
@@ -27,9 +27,8 @@
/**
 * Execution
 *
-* @access  public
-* @param   array   Parameters passed to the page
-* @return  void
+* @param array $par Parameters passed to the page
+* @return void
 */
public function execute( $par ) {
global $wgUser, $wgRequest, $wgOut;
@@ -116,9 +115,7 @@
/**
 * Produce a stub recent changes listing for a single diff.
 *
-* @access  private
-* @param   class   Diff. to show the listing for
-* @return  void
+* @param RecentChange &$edit Diff. to show the listing for
 */
private function showDiffDetails( &$edit ) {
global $wgOut;
@@ -135,9 +132,7 @@
/**
 * Output a trimmed down diff view corresponding to a particular change
 *
-* @access  private
-* @param   class   Recent change to produce a diff for
-* @return  void
+* @param RecentChange &$edit Recent change to produce a diff for
 */
private function showDiff( &$edit ) {
$diff = new DifferenceEngine(
@@ -151,9 +146,7 @@
/**
 * Output a bunch of controls to let the user endorse, revert and skip 
changes
 *
-* @access  private
-* @param   class   RecentChange being dealt with
-* @return  void
+* @param RecentChange &$edit RecentChange being dealt with
 */
private function showControls( &$edit ) {
global $wgUser, $wgOut;
@@ -217,9 +210,8 @@
 *   - hasn't been patrolled
 *   - isn't assigned to a user
 *
-* @access  private
-* @param   class   User to suppress edits for
-* @return  boolean RecentChange
+* @param User &$user User to suppress edits for
+* @return false|RecentChange
 */
private function fetchChange( &$user ) {
$dbr = wfGetDB( DB_REPLICA );
@@ -261,9 +253,8 @@
/**
 * Fetch a particular recent change given the rc_id value
 *
-* @access  private
-* @param   integer rc_id value of the row to fetch
-* @return  boolean RecentChange
+* @param int $rcid rc_id value of the row to fetch
+* @return bool|RecentChange
 */
private function loadChange( $rcid ) {
$dbr = wfGetDB( DB_REPLICA );
@@ -286,9 +277,8 @@
 * Assign the patrolling of a particular change, so other users don't 
pull
 * it up, duplicating effort
 *
-* @access  private
-* @param   string  RecentChange item to assign
-* @return  boolean If rows were changed
+* @param RecentChange &$edit RecentChange item to assign
+* @return bool If rows were changed
 */
private function assignChange( &$edit ) {
$dbw = wfGetDB( DB_MASTER );
@@ -307,9 +297,7 @@
/**
 * Remove the assignment for a particular change, to let another user 
handle it
 *
-* @access  private
-* @param   integer 

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403702 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I1a03afc58d87cce2f60e52d58fe930fecdf0aa9d
---
M .phpcs.xml
M includes/ContributorsHooks.php
2 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Contributors 
refs/changes/02/403702/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 4e2f687..b057584 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,9 +4,6 @@



-   
-   
-   



diff --git a/includes/ContributorsHooks.php b/includes/ContributorsHooks.php
index 3384bc1..9177aa6 100644
--- a/includes/ContributorsHooks.php
+++ b/includes/ContributorsHooks.php
@@ -10,7 +10,7 @@
/**
 * Set up the #contributors parser function
 *
-* @param Parser $parser
+* @param Parser &$parser
 *
 * @return bool
 */
@@ -57,8 +57,10 @@
/**
 * Prepare the toolbox link
 *
-* @var $skintemplate SkinTemplate
-*
+* @param SkinTemplate &$skintemplate
+* @param array &$nav_urls
+* @param int &$oldid
+* @param int &$revid
 * @return bool
 */
public static function onSkinTemplateBuildNavUrlsNav_urlsAfterPermalink(
@@ -81,6 +83,7 @@
/**
 * Output the toolbox link
 *
+* @param BaseTemplate &$monobook
 * @return bool
 */
public static function onSkinTemplateToolboxEnd( BaseTemplate 
&$monobook ) {
@@ -118,15 +121,15 @@
 *
 * @param WikiPage $wikiPage
 * @param User $user
-* @param $content
-* @param $summary
-* @param $isMinor
-* @param $isWatch
-* @param $section
-* @param $flags
-* @param $revision
-* @param $status
-* @param $baseRevId
+* @param Content $content
+* @param string $summary
+* @param bool $isMinor
+* @param bool $isWatch
+* @param string $section
+* @param int $flags
+* @param Revision $revision
+* @param Status $status
+* @param int $baseRevId
 *
 * @throws Exception
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/403702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a03afc58d87cce2f60e52d58fe930fecdf0aa9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Contributors
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContributionScores[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403696 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I1d6bece3380b6d2144feee512de736c12d62d09e
---
M .phpcs.xml
M ContributionScores_body.php
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionScores 
refs/changes/96/403696/1

diff --git a/.phpcs.xml b/.phpcs.xml
index e656bbd..482be95 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,8 +1,6 @@
 
 

-   
-   



@@ -11,6 +9,5 @@

.

-   
-   vendor
+   
 
diff --git a/ContributionScores_body.php b/ContributionScores_body.php
index 1fe0ae0..0b0c50f 100644
--- a/ContributionScores_body.php
+++ b/ContributionScores_body.php
@@ -21,11 +21,11 @@
/**
 * Function generates Contribution Scores tables in HTML format (not 
wikiText)
 *
-* @param $days int Days in the past to run report for
-* @param $limit int Maximum number of users to return (default 50)
-* @param $title Title (default null)
-* @param $options array of options (default none; nosort/notools)
-* @return Html Table representing the requested Contribution Scores.
+* @param int $days Days in the past to run report for
+* @param int $limit Maximum number of users to return (default 50)
+* @param string|null $title The title of the table
+* @param array $options array of options (default none; nosort/notools)
+* @return string Html Table representing the requested Contribution 
Scores.
 */
function genContributionScoreTable( $days, $limit, $title = null, 
$options = 'none' ) {
global $wgContribScoreIgnoreBots, 
$wgContribScoreIgnoreBlockedUsers, $wgContribScoresUseRealName;
@@ -188,7 +188,7 @@
/**
 * Called when being included on a normal wiki page.
 * Cache is disabled so it can depend on the user language.
-* @param $par
+* @param string|null $par A subpage give to the special page
 */
function showInclude( $par ) {
$days = null;

-- 
To view, visit https://gerrit.wikimedia.org/r/403696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6bece3380b6d2144feee512de736c12d62d09e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContributionScores
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BatchUserRights[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403692 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I08c943179d394db26f69d3542ca38d7bd56c8880
---
M .phpcs.xml
M BatchUserRights_body.php
2 files changed, 13 insertions(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BatchUserRights 
refs/changes/92/403692/1

diff --git a/.phpcs.xml b/.phpcs.xml
index c2adbf9..1e83498 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,7 @@
 


-   
-   
+   



diff --git a/BatchUserRights_body.php b/BatchUserRights_body.php
index cadef15..8e1b784 100644
--- a/BatchUserRights_body.php
+++ b/BatchUserRights_body.php
@@ -42,7 +42,7 @@
 * Manage forms to be shown according to posted data.
 * Depending on the submit button used, call a form or a save function.
 *
-* @param $par Mixed: string if any subpage provided, else null
+* @param string|null $par string if any subpage provided, else null
 */
public function execute( $par ) {
global $wgBatchUserRightsGrantableGroups;
@@ -128,10 +128,9 @@
 * Save user groups changes in the database.
 * Data comes from the showEditUserGroupsForm() form function
 *
-* @param $username String: username to apply changes to.
-* @param $addgroup Array: group names which the user should be added 
to.
-* @param $reason String: reason for group change
-* @return null
+* @param string $username username to apply changes to.
+* @param array $addgroup group names which the user should be added to.
+* @param string $reason reason for group change
 */
function saveUserGroups( $username, $addgroup, $reason = '' ) {
if ( $username == $this->getUser()->getName() ) {
@@ -186,6 +185,10 @@
 
/**
 * Add a rights log entry for an action.
+* @param User $user
+* @param array $oldGroups
+* @param array $newGroups
+* @param string $reason
 */
function addLogEntry( $user, $oldGroups, $newGroups, $reason = '' ) {
$logEntry = new ManualLogEntry( 'rights', 'rights' );
@@ -205,7 +208,8 @@
 * return a user (or proxy) object for manipulating it.
 *
 * Side effects: error output for invalid access
-* @return mixed User, UserRightsProxy, or null
+* @param string $username
+* @return User|UserRightsProxy|null
 */
function fetchUser( $username ) {
global $wgUserrightsInterwikiDelimiter;
@@ -382,7 +386,7 @@
}
 
/**
-* @param  $group String: the name of the group to check
+* @param string $group the name of the group to check
 * @return bool Can we remove the group?
 */
private function canRemove( $group ) {
@@ -393,7 +397,7 @@
}
 
/**
-* @param $group string: the name of the group to check
+* @param string $group the name of the group to check
 * @return bool Can we add the group?
 */
private function canAdd( $group ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08c943179d394db26f69d3542ca38d7bd56c8880
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BatchUserRights
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AkismetKlik[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403690 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I73943d1ea3e186cec896a1ca1030a1e87e5939f6
---
M .phpcs.xml
M Akismet.class.php
M AkismetKlik_body.php
3 files changed, 15 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AkismetKlik 
refs/changes/90/403690/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 1c65831..7813849 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,14 +3,11 @@



-   
-   




.

-   
-   vendor
+   
 
diff --git a/Akismet.class.php b/Akismet.class.php
index 3eb12ac..3d2d307 100644
--- a/Akismet.class.php
+++ b/Akismet.class.php
@@ -150,9 +150,9 @@
 
/**
 * makes a request to the Akismet service
-* @param $request
-* @param $host
-* @param $path
+* @param string $request
+* @param string $host
+* @param string $path
 * @return array
 */
private function sendRequest( $request, $host, $path ) {
@@ -275,7 +275,7 @@
 * The type of comment being submitted.
 *
 * May be blank, comment, trackback, pingback, or a made up value like 
"registration" or "wiki".
-* @param $commentType
+* @param string $commentType
 */
public function setCommentType( $commentType ) {
$this->comment['comment_type'] = $commentType;
@@ -283,7 +283,7 @@
 
/**
 * The name that the author submitted with the comment.
-* @param $commentAuthor
+* @param string $commentAuthor
 */
public function setCommentAuthor( $commentAuthor ) {
$this->comment['comment_author'] = $commentAuthor;
@@ -293,7 +293,7 @@
 * The email address that the author submitted with the comment.
 *
 * The address is assumed to be valid.
-* @param $authorEmail string
+* @param string $authorEmail
 */
public function setCommentAuthorEmail( $authorEmail ) {
$this->comment['comment_author_email'] = $authorEmail;
@@ -301,7 +301,7 @@
 
/**
 * The URL that the author submitted with the comment.
-* @param $authorURL
+* @param string $authorURL
 */
public function setCommentAuthorURL( $authorURL ) {
$this->comment['comment_author_url'] = $authorURL;
@@ -309,7 +309,7 @@
 
/**
 * The comment's body text.
-* @param $commentBody
+* @param string $commentBody
 */
public function setCommentContent( $commentBody ) {
$this->comment['comment_content'] = $commentBody;
@@ -319,7 +319,7 @@
 * Lets you override the user agent used to submit the comment.
 * you may wish to do this when submitting ham/spam.
 * Defaults to $_SERVER['HTTP_USER_AGENT']
-* @param $userAgent
+* @param string $userAgent
 */
public function setCommentUserAgent( $userAgent ) {
$this->comment['user_agent'] = $userAgent;
@@ -327,7 +327,7 @@
 
/**
 * Defaults to 80
-* @param $apiPort
+* @param string $apiPort
 */
public function setAPIPort( $apiPort ) {
$this->apiPort = $apiPort;
@@ -335,7 +335,7 @@
 
/**
 * Defaults to rest.akismet.com
-* @param $akismetServer
+* @param string $akismetServer
 */
public function setAkismetServer( $akismetServer ) {
$this->akismetServer = $akismetServer;
diff --git a/AkismetKlik_body.php b/AkismetKlik_body.php
index 125a4ec..e498dba 100644
--- a/AkismetKlik_body.php
+++ b/AkismetKlik_body.php
@@ -6,7 +6,7 @@
public $previousFilter;
 
/**
-* @param $settings array
+* @param array $settings
 */
function __construct( $settings = [] ) {
foreach ( $settings as $name => $value ) {
@@ -16,8 +16,8 @@
 
/**
 * Hook function for EditFilterMergedContent, replaces wfAkismetFilter
-* @param $context IContextSource
-* @param $content Content
+* @param IContextSource $context
+* @param Content $content
 * @return bool
 */
public static function onAkismetFilterMergedContent( $context, $content 
) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73943d1ea3e186cec896a1ca1030a1e87e5939f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AkismetKlik
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

[MediaWiki-commits] [Gerrit] mediawiki...AddThis[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403686 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I579505bcc556d370e842133b3782366bc1876f9f
---
M .phpcs.xml
M AddThis.body.php
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AddThis 
refs/changes/86/403686/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 2c2a50d..21e0cec 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,13 +1,11 @@
 
 

-   
-   
+   



.

-   
-   vendor
+   
 
diff --git a/AddThis.body.php b/AddThis.body.php
index d39e4d8..c4d4667 100644
--- a/AddThis.body.php
+++ b/AddThis.body.php
@@ -13,7 +13,7 @@
/**
 * Register parser hook
 *
-* @param $parser Parser
+* @param Parser &$parser
 * @return bool
 */
public static function AddThisHeaderTag( &$parser ) {
@@ -25,7 +25,7 @@
/**
 * Parser hook for the  tag extension.
 *
-* @param $parser
+* @param Parser $parser
 * @return string
 */
public static function parserHook( $parser ) {
@@ -59,9 +59,9 @@
/**
 * Function for article header toolbar
 *
-* @param $article Article
-* @param $outputDone
-* @param $pcache
+* @param Article &$article
+* @param bool &$outputDone
+* @param bool &$pcache
 * @return bool|bool
 */
public static function AddThisHeader( &$article, &$outputDone, &$pcache 
) {
@@ -107,9 +107,9 @@
/**
 * Function for sidebar portlet
 *
-* @param $skin
-* @param $bar
-* @return bool|array|bool
+* @param Skin $skin
+* @param Sidebar &$bar
+* @return bool|array
 */
public static function AddThisSidebar( $skin, &$bar ) {
global $wgOut, $wgAddThis, $wgAddThispubid, $wgAddThisSidebar, 
$wgAddThisSBServ;
@@ -144,7 +144,7 @@
/**
 * Converts an array definition of links into HTML tags
 *
-* @param $links array
+* @param array $links
 * @return string
 */
protected static function makeLinks( $links ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I579505bcc556d370e842133b3782366bc1876f9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AddThis
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AddMessages[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403687 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I3d704c26b005e93e6a4799b13a6582e366d28567
---
M .phpcs.xml
M AddMessages.class.php
2 files changed, 4 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AddMessages 
refs/changes/87/403687/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 7959489..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,9 @@
 


-   
-   
-   


.

-   
-   vendor
+   
 
diff --git a/AddMessages.class.php b/AddMessages.class.php
index 7b6e68c..6f4b701 100644
--- a/AddMessages.class.php
+++ b/AddMessages.class.php
@@ -12,9 +12,9 @@
 * or add a new message
 *
 * @global array $wgAmMessages
-* @param $cache
-* @param $code
-* @param array $alldata
+* @param LocalisationCache $cache
+* @param string $code
+* @param array &$alldata
 * @return bool
 */
public static function onLocalisationCacheRecache( $cache, $code, 
&$alldata ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d704c26b005e93e6a4799b13a6582e366d28567
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AddMessages
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403447 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ic85f74fc8dcefe86a3620e2d12f0b2ad2386ee23
---
M .phpcs.xml
M engines/LuaCommon/LanguageLibrary.php
M engines/LuaCommon/LuaCommon.php
M engines/LuaCommon/TitleLibrary.php
M tests/phpunit/engines/LuaCommon/LuaEngineTestBase.php
5 files changed, 69 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/47/403447/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 0765bc8..f46e3ef 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -5,9 +5,6 @@



-   
-   
-   



@@ -15,6 +12,4 @@
.


-   node_modules/
-   vendor/
 
diff --git a/engines/LuaCommon/LanguageLibrary.php 
b/engines/LuaCommon/LanguageLibrary.php
index 4c5faad..62af385 100644
--- a/engines/LuaCommon/LanguageLibrary.php
+++ b/engines/LuaCommon/LanguageLibrary.php
@@ -106,6 +106,10 @@
 
/**
 * Language object method handler
+* @param string $name
+* @param array $args
+* @return string
+* @throws Scribunto_LuaError
 */
function languageMethod( $name, $args ) {
$name = strval( $name );
@@ -153,6 +157,9 @@
 
/**
 * convertPlural handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function convertPlural( $lang, $args ) {
$number = array_shift( $args );
@@ -166,6 +173,9 @@
 
/**
 * convertGrammar handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function convertGrammar( $lang, $args ) {
$this->checkType( 'convertGrammar', 1, $args[0], 'string' );
@@ -175,6 +185,9 @@
 
/**
 * gender handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function gender( $lang, $args ) {
$this->checkType( 'gender', 1, $args[0], 'string' );
@@ -220,6 +233,9 @@
 
/**
 * formatNum handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function formatNum( $lang, $args ) {
$num = $args[0];
@@ -236,6 +252,10 @@
 
/**
 * formatDate handler
+* @param Language $lang
+* @param array $args
+* @return array
+* @throws Scribunto_LuaError
 */
function formatDate( $lang, $args ) {
$this->checkType( 'formatDate', 1, $args[0], 'string' );
@@ -308,6 +328,9 @@
 
/**
 * formatDuration handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function formatDuration( $lang, $args ) {
$this->checkType( 'formatDuration', 1, $args[0], 'number' );
@@ -323,6 +346,9 @@
 
/**
 * getDurationIntervals handler
+* @param Language $lang
+* @param array $args
+* @return array
 */
function getDurationIntervals( $lang, $args ) {
$this->checkType( 'getDurationIntervals', 1, $args[0], 'number' 
);
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index b59a61e..6269dd3 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -253,6 +253,11 @@
 
/**
 * Execute a module chunk in a new isolated environment, and return the 
specified function
+* @param string $chunk
+* @param string $functionName
+* @param string $frame
+* @return mixed
+* @throws ScribuntoException
 */
public function executeModule( $chunk, $functionName, $frame ) {
$resetFrames = null;
@@ -278,6 +283,9 @@
 
/**
 * Execute a module function chunk
+* @param string $chunk
+* @param PPFrame|null $frame
+* @return array
 */
public function executeFunctionChunk( $chunk, $frame ) {
// $resetFrames is a ScopedCallback, so it has a purpose even 
though it appears unused.
@@ -599,6 +607,10 @@
/**
 * Handler for newChildFrame()
 *
+* @param string $frameId
+* @param string $title
+* @param array $args
+* @return array
 * @throws Scribunto_LuaError
 */
function newChildFrame( $frameId, $title, array $args ) {
@@ -636,6 +648,7 @@
 
/**
 * Handler for setTTL()
+* @param int $ttl
 */
function setTTL( $ttl ) {
$args = func_get_args();
@@ -647,6 +660,9 @@
 

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403302 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ie1a2d264c5829f599fd6707fa303b69a8c1bc2b3
---
M .phpcs.xml
M Hooks.php
M includes/Actions/PurgeAction.php
M includes/Api/ApiFlow.php
M includes/Api/ApiFlowBase.php
M includes/Api/ApiFlowBaseGet.php
M includes/Api/ApiFlowBasePost.php
M includes/Api/ApiFlowEditHeader.php
M includes/Api/ApiFlowEditPost.php
M includes/Api/ApiFlowEditTitle.php
M includes/Api/ApiFlowEditTopicSummary.php
M includes/Api/ApiFlowLockTopic.php
M includes/Api/ApiFlowModeratePost.php
M includes/Api/ApiFlowModerateTopic.php
M includes/Api/ApiFlowNewTopic.php
M includes/Api/ApiFlowReply.php
M includes/Api/ApiFlowUndoEditHeader.php
M includes/Api/ApiFlowUndoEditPost.php
M includes/Api/ApiFlowUndoEditTopicSummary.php
M includes/Api/ApiFlowViewHeader.php
M includes/Api/ApiFlowViewPost.php
M includes/Api/ApiFlowViewPostHistory.php
M includes/Api/ApiFlowViewTopic.php
M includes/Api/ApiFlowViewTopicHistory.php
M includes/Api/ApiFlowViewTopicList.php
M includes/Api/ApiFlowViewTopicSummary.php
M includes/Api/ApiParsoidUtilsFlow.php
M includes/Api/ApiQueryPropFlowInfo.php
M includes/Block/Block.php
M includes/Block/Topic.php
M includes/Block/TopicSummary.php
M includes/Data/Index/FeatureIndex.php
M includes/Data/Listener/AbstractListener.php
M includes/Data/Listener/UserNameListener.php
M includes/Data/Mapper/BasicObjectMapper.php
M includes/Data/Mapper/CachingObjectMapper.php
M includes/Data/ObjectLocator.php
M includes/Data/ObjectManager.php
M includes/Data/Storage/BoardHistoryStorage.php
M includes/Data/Storage/DbStorage.php
M includes/Data/Storage/PostRevisionStorage.php
M includes/Data/Storage/RevisionStorage.php
M includes/Data/Storage/TopicListStorage.php
M includes/Data/Utils/MultiDimArray.php
M includes/Data/Utils/ResultDuplicator.php
M includes/Data/Utils/SortRevisionsByRevisionId.php
M includes/DbFactory.php
M includes/Dump/Exporter.php
M includes/Exception/ExceptionHandling.php
M includes/Formatter/ContributionsFormatter.php
M includes/Formatter/ContributionsQuery.php
M includes/Formatter/RevisionDiffViewFormatter.php
M includes/Formatter/RevisionFormatter.php
M includes/Formatter/RevisionUndoViewFormatter.php
M includes/Formatter/RevisionViewQuery.php
M includes/Formatter/TopicListQuery.php
M includes/Import/EnableFlow/EnableFlowWikitextConversionStrategy.php
M includes/Import/LiquidThreadsApi/ConversionStrategy.php
M includes/Import/LiquidThreadsApi/Objects.php
M includes/Import/LiquidThreadsApi/Source.php
M includes/Import/Wikitext/ConversionStrategy.php
M includes/Import/Wikitext/ImportSource.php
M includes/Model/HtmlRenderingInformation.php
M includes/Model/Reference.php
M includes/Model/URLReference.php
M includes/Model/WikiReference.php
M includes/Model/Workflow.php
M includes/Notifications/Controller.php
M includes/Parsoid/Extractor/CategoryExtractor.php
M includes/Parsoid/Extractor/ExtLinkExtractor.php
M includes/Parsoid/Extractor/ImageExtractor.php
M includes/Parsoid/Extractor/PlaceholderExtractor.php
M includes/Parsoid/Extractor/TransclusionExtractor.php
M includes/Parsoid/Extractor/WikiLinkExtractor.php
M includes/Repository/TreeRepository.php
M includes/Search/Iterators/HeaderIterator.php
M includes/Search/Iterators/TopicIterator.php
M includes/Search/SearchEngine.php
M includes/Search/Updaters/HeaderUpdater.php
M includes/Search/Updaters/TopicUpdater.php
M includes/TalkpageManager.php
M includes/WatchedTopicItems.php
M maintenance/FlowUpdateUserWiki.php
M maintenance/FlowUpdateWorkflowPageId.php
M maintenance/MaintenanceDebugLogger.php
M maintenance/benchUuidTimestampConversion.php
M tests/phpunit/Mock/MockImportHeader.php
M tests/phpunit/Mock/MockImportPost.php
M tests/phpunit/Mock/MockImportRevision.php
M tests/phpunit/Mock/MockImportSource.php
M tests/phpunit/Mock/MockImportTopic.php
M tests/phpunit/api/ApiTestCase.php
92 files changed, 295 insertions(+), 155 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/02/403302/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 1ae6078..e1dd968 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -7,7 +7,6 @@



-   



@@ -16,9 +15,6 @@



-   
-   
-   */maintenance/*



diff --git a/Hooks.php b/Hooks.php
index de887c1..11df22e 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -730,7 +730,11 @@
return true;
}
 
-   // Static variables that do not vary by request; delivered through 
startup module
+   /**
+* Static variables that do not vary by request; delivered through 
startup module
+* @param array &$vars
+* @return true
+*/
   

[MediaWiki-commits] [Gerrit] mediawiki...apex[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403224 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Idd55d52910550e18b2cea40970c9bdfb9511cb47
---
M .phpcs.xml
M ApexTemplate.php
M SkinApex.php
3 files changed, 11 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/apex 
refs/changes/24/403224/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 76de051..55ab46e 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -8,8 +8,7 @@



-   
-   
+   



diff --git a/ApexTemplate.php b/ApexTemplate.php
index 9c14d6c..a9c83e2 100644
--- a/ApexTemplate.php
+++ b/ApexTemplate.php
@@ -164,7 +164,7 @@
/**
 * Render a series of portals
 *
-* @param $portals array
+* @param array $portals
 */
protected function renderPortals( $portals ) {
// Force the rendering of the following portals
@@ -201,10 +201,10 @@
}
 
/**
-* @param $name string
-* @param $content array
-* @param $msg null|string
-* @param $hook null|string|array
+* @param string $name
+* @param array $content
+* @param null|string $msg
+* @param null|string|array $hook
 */
protected function renderPortal( $name, $content, $msg = null, $hook = 
null ) {
if ( $msg === null ) {
@@ -247,7 +247,7 @@
 * Render one or more navigations elements by name, automatically 
reveresed
 * when UI is in RTL mode
 *
-* @param $elements array
+* @param array $elements
 */
protected function renderNavigation( $elements ) {
// If only one element was given, wrap it in an array, allowing 
more
diff --git a/SkinApex.php b/SkinApex.php
index 05b6e0d..0618484 100644
--- a/SkinApex.php
+++ b/SkinApex.php
@@ -13,7 +13,7 @@
 
/**
 * Initializes output page and sets up skin-specific parameters
-* @param $out OutputPage object to initialize
+* @param OutputPage $out OutputPage object to initialize
 */
public function initPage( OutputPage $out ) {
global $wgLocalStylePath;
@@ -40,7 +40,7 @@
/**
 * Load skin and user CSS files in the correct order
 * fixes bug 22916
-* @param $out OutputPage object
+* @param OutputPage $out OutputPage object
 */
function setupSkinUserCss( OutputPage $out ) {
parent::setupSkinUserCss( $out );
@@ -53,8 +53,8 @@
/**
 * Adds classes to the body element.
 *
-* @param $out OutputPage object
-* @param &$bodyAttrs Array of attributes that will be set on the body 
element
+* @param OutputPage $out OutputPage object
+* @param array &$bodyAttrs Array of attributes that will be set on the 
body element
 */
function addToBodyAttributes( $out, &$bodyAttrs ) {
if ( isset( $bodyAttrs['class'] ) && strlen( 
$bodyAttrs['class'] ) > 0 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd55d52910550e18b2cea40970c9bdfb9511cb47
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/apex
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Farmer[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402934 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I2349c03faf9d59e9201913d610d1e790d1b5ec57
---
M .phpcs.xml
M MediaWikiFarmer.php
M MediaWikiFarmer_Extension.php
M MediaWikiFarmer_Wiki.php
M SpecialFarmer.php
5 files changed, 41 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Farmer 
refs/changes/34/402934/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 4b0f68a..cdefebc 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,9 +2,6 @@
 


-   
-   
-   



@@ -14,5 +11,4 @@
.


-   vendor
 
diff --git a/MediaWikiFarmer.php b/MediaWikiFarmer.php
index f5186c0..8b60e8f 100644
--- a/MediaWikiFarmer.php
+++ b/MediaWikiFarmer.php
@@ -71,9 +71,7 @@
}
 
/**
-* Constructor
-*
-* @param $params Array of parameters to control behavior
+* @param array $params Array of parameters to control behavior
 *
 * @todo Load up special page
 */
@@ -141,6 +139,7 @@
 
/**
 * Get the active wiki for this MediaWikiFarmer instance
+* @return MediaWikiFarmer_Wiki
 */
public function getActiveWiki() {
return $this->_activeWiki;
@@ -355,6 +354,8 @@
 
/**
 * Returns the database table prefix, as suitable for $wgDBprefix
+* @param string $wiki
+* @return array
 */
public function splitWikiDB( $wiki ) {
$callback = $this->_dbFromWikiFunction;
@@ -365,9 +366,9 @@
 * Default callback function to get an database name and prefix for a 
wiki
 * in the farm
 *
-* @param $farmer MediaWikiFarmer
-* @param $wiki String
-* @return Array
+* @param MediaWikiFarmer $farmer
+* @param string $wiki
+* @return array
 */
// @codingStandardsIgnoreStart
protected static function _prefixTable( MediaWikiFarmer $farmer, $wiki 
) {
@@ -385,8 +386,8 @@
/**
 * Get a database object
 *
-* @param $type integer: either DB_SLAVE for DB_MASTER
-* @return Database object
+* @param int $type Either DB_REPLICA for DB_MASTER
+* @return \Wikimedia\Rdbms\IDatabase
 */
public function getDB( $type ) {
if ( !$this->useDatabase() ) {
@@ -410,8 +411,8 @@
/**
 * Determines whether the user can create a wiki
 *
-* @param $user User object
-* @param $wiki String: wiki name (optional)
+* @param User $user User object
+* @param string $wiki wiki name (optional)
 *
 * @return bool
 */
@@ -422,8 +423,8 @@
/**
 * Determines whether manage the wiki farm
 *
-* @param $user User object
-* @return Boolean
+* @param User $user User object
+* @return bool
 */
public static function userIsFarmerAdmin( $user ) {
return $user->isAllowed( 'farmeradmin' );
@@ -446,7 +447,8 @@
/**
 * Gets extensions objects
 *
-* @return Array
+* @param bool $forceReload
+* @return array
 */
public function getExtensions( $forceReload = false ) {
if ( $this->_extensionsLoaded && !$forceReload ) {
@@ -480,6 +482,7 @@
 
/**
 * Register an extension so that it's available for all wikis in the 
farm
+* @param MediaWikiFarmer_Extension $e
 */
public function registerExtension( MediaWikiFarmer_Extension $e ) {
if ( $this->useDatabase() ) {
diff --git a/MediaWikiFarmer_Extension.php b/MediaWikiFarmer_Extension.php
index 2d30c17..874467a 100644
--- a/MediaWikiFarmer_Extension.php
+++ b/MediaWikiFarmer_Extension.php
@@ -33,6 +33,8 @@
/**
 * Magic method so we can access variables directly without accessor
 * functions
+* @param string $key
+* @return mixed
 */
public function __get( $key ) {
$property = '_' . $key;
@@ -43,6 +45,7 @@
/**
 * Sees if extension is valid by looking at included files and 
attempting to
 * open them
+* @return bool
 */
public function isValid() {
foreach ( $this->_includeFiles as $file ) {
diff --git a/MediaWikiFarmer_Wiki.php b/MediaWikiFarmer_Wiki.php
index 67cd3ec..066df53 100644
--- a/MediaWikiFarmer_Wiki.php
+++ b/MediaWikiFarmer_Wiki.php
@@ -34,6 +34,8 @@
 
/**
 * Creates a wiki instance from a wiki name
+* @param string $wiki
+* @param array $variables
 */
public 

[MediaWiki-commits] [Gerrit] mediawiki...Farmer[master]: Fix return void in MediaWikiFarmer::run

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402933 )

Change subject: Fix return void in MediaWikiFarmer::run
..

Fix return void in MediaWikiFarmer::run

MediaWikiFarmer::_doWiki returns void, no need to use a return statement
here

Change-Id: Ie41fb46109592efa47ba180c21a86265e27ef7ff
---
M MediaWikiFarmer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Farmer 
refs/changes/33/402933/1

diff --git a/MediaWikiFarmer.php b/MediaWikiFarmer.php
index 80084c8..f5186c0 100644
--- a/MediaWikiFarmer.php
+++ b/MediaWikiFarmer.php
@@ -183,7 +183,7 @@
$wiki = strtolower( preg_replace( '/[^[:alnum:_\-]]/', 
'', $wiki ) );
 
// now we have a valid wiki name
-   return $this->_doWiki( $wiki );
+   $this->_doWiki( $wiki );
 
} else {
throw new MWException(

-- 
To view, visit https://gerrit.wikimedia.org/r/402933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie41fb46109592efa47ba180c21a86265e27ef7ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Farmer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402900 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ic8e321286c8028c60839cd97a93dbd59010ee7f7
---
M .phpcs.xml
M CentralNotice.hooks.php
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
M CentralNoticePageLogPager.php
M CentralNoticePager.php
M api/ApiCentralNoticeCdnCacheUpdateBanner.php
M api/ApiCentralNoticeLogs.php
M api/ApiCentralNoticeQueryCampaign.php
M includes/AllocationCalculator.php
M includes/Banner.php
M includes/BannerMessage.php
M includes/BannerMessageGroup.php
M includes/BannerRenderer.php
M includes/CNBannerPager.php
M includes/CNCampaignPager.php
M includes/CNChoiceDataResourceLoaderModule.php
M includes/Campaign.php
M includes/ChoiceDataProvider.php
M includes/HtmlFormElements/HTMLCentralNoticeBanner.php
M includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
M includes/IBannerMixin.php
M special/SpecialBannerAllocation.php
M special/SpecialBannerRandom.php
M special/SpecialCentralNotice.php
M special/SpecialCentralNoticeLogs.php
M special/SpecialGlobalAllocation.php
M special/SpecialHideBanners.php
M special/SpecialNoticeTemplate.php
M tests/CNTestFixturesResourceLoaderModule.php
M tests/CentralNoticeTestFixtures.php
31 files changed, 125 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/00/402900/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 9d96d27..114efbc 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -5,8 +5,6 @@



-   
-   



diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 7a0a930..84315da 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -100,6 +100,8 @@
 
/**
 * Tell the UserMerge extension where we store user ids
+* @param array[] &$updateFields
+* @return true
 */
public static function onUserMergeAccountFields( &$updateFields ) {
global $wgNoticeInfrastructure;
diff --git a/CentralNoticeBannerLogPager.php b/CentralNoticeBannerLogPager.php
index 01a078d..15e90bf 100644
--- a/CentralNoticeBannerLogPager.php
+++ b/CentralNoticeBannerLogPager.php
@@ -10,6 +10,7 @@
 
/**
 * Sort the log list by timestamp
+* @return string
 */
function getIndexField() {
return 'tmplog_timestamp';
@@ -17,6 +18,7 @@
 
/**
 * Pull log entries from the database
+* @return array
 */
function getQueryInfo() {
return [
@@ -27,6 +29,8 @@
 
/**
 * Generate the content of each table row (1 row = 1 log entry)
+* @param stdClass $row
+* @return string HTML
 */
function formatRow( $row ) {
global $wgExtensionAssetsPath;
diff --git a/CentralNoticeCampaignLogPager.php 
b/CentralNoticeCampaignLogPager.php
index f47b705..21e8e86 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -16,6 +16,7 @@
 
/**
 * Sort the log list by timestamp
+* @return string
 */
function getIndexField() {
return 'notlog_timestamp';
@@ -23,6 +24,7 @@
 
/**
 * Pull log entries from the database
+* @return array[]
 */
function getQueryInfo() {
$request = $this->getRequest();
@@ -74,6 +76,8 @@
 
/**
 * Generate the content of each table row (1 row = 1 log entry)
+* @param stdClass $row
+* @return string HTML
 */
function formatRow( $row ) {
global $wgExtensionAssetsPath;
@@ -504,6 +508,7 @@
 
/**
 * Specify table headers
+* @return string HTML
 */
function getStartBody() {
$htmlOut = '';
@@ -534,6 +539,7 @@
 
/**
 * Close table
+* @return strint HTML
 */
function getEndBody() {
$htmlOut = '';
diff --git a/CentralNoticePageLogPager.php b/CentralNoticePageLogPager.php
index 914daa7..b8417ee 100644
--- a/CentralNoticePageLogPager.php
+++ b/CentralNoticePageLogPager.php
@@ -23,6 +23,7 @@
 
/**
 * Sort the log list by timestamp
+* @return string
 */
function getIndexField() {
return 'rc_timestamp';
@@ -30,6 +31,7 @@
 
/**
 * Pull log entries from the database
+* @return array[]
 */
function getQueryInfo() {
$conds = [
@@ -77,6 +79,8 @@
 
/**
 * Generate the content of each table row (1 row = 1 log entry)
+* @param stdClass $row
+* @return string HTML
 */
function formatRow( $row 

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Remove direction from @param

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402871 )

Change subject: Remove direction from @param
..

Remove direction from @param

[in], [out] or [in,out] are not used in MediaWiki code style

https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdparam

Change-Id: Ia18f0deab50dfddeb3a1d1b28647e0f3a4da72e1
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
M MediaWiki/Tests/files/Commenting/commenting_function.php
M MediaWiki/Tests/files/Commenting/commenting_function.php.expect
M MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
4 files changed, 43 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/71/402871/1

diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php 
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index 40cd69b..bdf5d05 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -465,9 +465,6 @@
$maxVar = 0;
foreach ( $tokens[$commentStart]['comment_tags'] as $pos => 
$tag ) {
$tagContent = $tokens[$tag]['content'];
-   if ( $tagContent !== '@param' && $tagContent !== 
'@params' ) {
-   continue;
-   }
 
if ( $tagContent === '@params' ) {
$error = 'Use @param tag in function comment 
instead of @params';
@@ -475,6 +472,16 @@
if ( $fix === true ) {
$phpcsFile->fixer->replaceToken( $tag, 
'@param' );
}
+   } elseif ( $tagContent === '@param[in]' || $tagContent 
=== '@param[out]' ||
+   $tagContent === '@param[in,out]'
+   ) {
+   $error = 'Use @param tag in function comment 
instead of %s';
+   $fix = $phpcsFile->addFixableError( $error, 
$tag, 'DirectionParam', [ $tagContent ] );
+   if ( $fix === true ) {
+   $phpcsFile->fixer->replaceToken( $tag, 
'@param' );
+   }
+   } elseif ( $tagContent !== '@param' ) {
+   continue;
}
 
$paramSpace = 0;
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php 
b/MediaWiki/Tests/files/Commenting/commenting_function.php
index ae5a2d0..fc48879 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php
@@ -175,6 +175,16 @@
public function testSyntaxDocTag( $a ) {
return $a;
}
+
+   /**
+* @param[in] int $in A comment
+* @param[out] int &$out A comment
+* @param[in,out] int &$inOut A comment
+*/
+   public function testDirectionParam( $in, &$out, &$inOut ) {
+   $out = $in * $inOut;
+   $inOut = $in / $out;
+   }
 }
 
 class TestPassedExamples {
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect 
b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
index 95b563e..b86abf8 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
@@ -175,10 +175,19 @@
  |   | (MediaWiki.Commenting.FunctionComment.SpacingDocStar)
  173 | ERROR | [x] Expected 1 spaces before @return; 2 found
  |   | (MediaWiki.Commenting.FunctionComment.SpacingDocTag)
- 180 | ERROR | [ ] Only one object structure is allowed in a file
+ 180 | ERROR | [x] Use @param tag in function comment instead of
+ |   | @param[in]
+ |   | (MediaWiki.Commenting.FunctionComment.DirectionParam)
+ 181 | ERROR | [x] Use @param tag in function comment instead of
+ |   | @param[out]
+ |   | (MediaWiki.Commenting.FunctionComment.DirectionParam)
+ 182 | ERROR | [x] Use @param tag in function comment instead of
+ |   | @param[in,out]
+ |   | (MediaWiki.Commenting.FunctionComment.DirectionParam)
+ 190 | ERROR | [ ] Only one object structure is allowed in a file
  |   | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
- 247 | ERROR | [ ] Only one object structure is allowed in a file
+ 257 | ERROR | [ ] Only one object structure is allowed in a file
  |   | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
- 253 | ERROR | [ ] Only one object structure is allowed in a file
+ 263 | ERROR | [ ] Only one object structure is allowed in a file
  |   | 

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402655 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I4f5f3e9cd0c044ad29440475b61781957f4ef507
---
M .phpcs.xml
M api/ApiCodeDiff.php
M api/ApiCodeUpdate.php
M api/ApiQueryCodeComments.php
M api/ApiQueryCodePaths.php
M api/ApiQueryCodeRevisions.php
M api/ApiQueryCodeTags.php
M api/ApiRevisionUpdate.php
M backend/Subversion.php
M ui/SpecialCode.php
10 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview 
refs/changes/55/402655/1

diff --git a/.phpcs.xml b/.phpcs.xml
index aa00a4e..759a46d 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -9,7 +9,6 @@



-   



diff --git a/api/ApiCodeDiff.php b/api/ApiCodeDiff.php
index 451db8a..42d2953 100644
--- a/api/ApiCodeDiff.php
+++ b/api/ApiCodeDiff.php
@@ -86,7 +86,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiCodeUpdate.php b/api/ApiCodeUpdate.php
index 4a6a0a6..1c1ed4b 100644
--- a/api/ApiCodeUpdate.php
+++ b/api/ApiCodeUpdate.php
@@ -106,7 +106,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiQueryCodeComments.php b/api/ApiQueryCodeComments.php
index 858f57e..f7621d7 100644
--- a/api/ApiQueryCodeComments.php
+++ b/api/ApiQueryCodeComments.php
@@ -144,7 +144,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiQueryCodePaths.php b/api/ApiQueryCodePaths.php
index 4d70df5..eae40e2 100644
--- a/api/ApiQueryCodePaths.php
+++ b/api/ApiQueryCodePaths.php
@@ -84,7 +84,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiQueryCodeRevisions.php b/api/ApiQueryCodeRevisions.php
index 767a4ea..0bbff46 100644
--- a/api/ApiQueryCodeRevisions.php
+++ b/api/ApiQueryCodeRevisions.php
@@ -221,7 +221,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiQueryCodeTags.php b/api/ApiQueryCodeTags.php
index 16eebeb..286a9d3 100644
--- a/api/ApiQueryCodeTags.php
+++ b/api/ApiQueryCodeTags.php
@@ -67,7 +67,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/api/ApiRevisionUpdate.php b/api/ApiRevisionUpdate.php
index 69bf1d3..e38fb56 100644
--- a/api/ApiRevisionUpdate.php
+++ b/api/ApiRevisionUpdate.php
@@ -182,7 +182,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/backend/Subversion.php b/backend/Subversion.php
index da564ee..23f3419 100644
--- a/backend/Subversion.php
+++ b/backend/Subversion.php
@@ -84,6 +84,7 @@
 * Nobody ever bothered filling in the documentation on php.net though.
 * The function returns a big array of a bunch of info about the 
repository
 * It throws a warning if the repository does not exist.
+* @return true
 */
function canConnect() {
// MediaWiki\suppressWarnings();
diff --git a/ui/SpecialCode.php b/ui/SpecialCode.php
index 6a2844d..553de39 100644
--- a/ui/SpecialCode.php
+++ b/ui/SpecialCode.php
@@ -161,6 +161,7 @@
 
/**
 * Only list me on Special:SpecialPages when configured.
+* @return true
 */
public function isListed() {
return $this->getConfig()->get( 'CodeReviewListSpecialPage' );

-- 
To view, visit https://gerrit.wikimedia.org/r/402655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f5f3e9cd0c044ad29440475b61781957f4ef507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...intersection[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402654 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I8b1c4c8900838b92289a7e4b0764d3114e36a8b8
---
M .phpcs.xml
M DynamicPageList.hooks.php
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/intersection 
refs/changes/54/402654/1

diff --git a/.phpcs.xml b/.phpcs.xml
index a9d9ba2..df18878 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,15 +2,11 @@
 


-   
-   



.

-   
+   
intersection.php
-   vendor
-   node_modules
 
diff --git a/DynamicPageList.hooks.php b/DynamicPageList.hooks.php
index e0c19f0..7daeea7 100644
--- a/DynamicPageList.hooks.php
+++ b/DynamicPageList.hooks.php
@@ -14,6 +14,10 @@
 
/**
 * The callback function for converting the input text to HTML output
+* @param string $input
+* @param array $args
+* @param Parser $mwParser
+* @return string
 */
public static function renderDynamicPageList( $input, $args, $mwParser 
) {
global $wgContLang;

-- 
To view, visit https://gerrit.wikimedia.org/r/402654
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b1c4c8900838b92289a7e4b0764d3114e36a8b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/intersection
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fix return in PFTemplate and PFOpenLayersInput

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402652 )

Change subject: Fix return in PFTemplate and PFOpenLayersInput
..

Fix return in PFTemplate and PFOpenLayersInput

PFTemplate::loadTemplateFieldsSMWAndOther return void, no need for
another return
PFOpenLayersInput::parseCoordinatesString needs a return value, choose
null and moved the trim behind the check, because a null string could be
trimmed to an empty string

Change-Id: Id58350acfe01a3c92d9307a37ddf789c1405a94d
---
M .phpcs.xml
M includes/PF_Template.php
M includes/forminputs/PF_OpenLayersInput.php
3 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms 
refs/changes/52/402652/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 4764e29..30ee060 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -18,7 +18,6 @@



-   



diff --git a/includes/PF_Template.php b/includes/PF_Template.php
index 6de0603..3483ee2 100644
--- a/includes/PF_Template.php
+++ b/includes/PF_Template.php
@@ -64,7 +64,7 @@
return;
}
}
-   return $this->loadTemplateFieldsSMWAndOther();
+   $this->loadTemplateFieldsSMWAndOther();
}
 
/**
diff --git a/includes/forminputs/PF_OpenLayersInput.php 
b/includes/forminputs/PF_OpenLayersInput.php
index 99b836d..21492a5 100644
--- a/includes/forminputs/PF_OpenLayersInput.php
+++ b/includes/forminputs/PF_OpenLayersInput.php
@@ -202,12 +202,13 @@
 * Copied from CargoStore::parseCoordinateString() in the Cargo
 * extension.
 * @param string $coordinatesString
+* @return string|null
 */
public static function parseCoordinatesString( $coordinatesString ) {
-   $coordinatesString = trim( $coordinatesString );
if ( $coordinatesString == null ) {
-   return;
+   return null;
}
+   $coordinatesString = trim( $coordinatesString );
 
// This is safe to do, right?
$coordinatesString = str_replace( array( '[', ']' ), '', 
$coordinatesString );

-- 
To view, visit https://gerrit.wikimedia.org/r/402652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id58350acfe01a3c92d9307a37ddf789c1405a94d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GraphViz[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402651 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I3ff96ec363776a12be0cc5247b3de74d172c6bd9
---
M .phpcs.xml
M includes/GraphViz.php
M includes/UploadFromLocalFile.php
M includes/UploadLocalFile.php
4 files changed, 98 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GraphViz 
refs/changes/51/402651/1

diff --git a/.phpcs.xml b/.phpcs.xml
index f9408cd..6cbe822 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -6,8 +6,6 @@



-   
-   

.

diff --git a/includes/GraphViz.php b/includes/GraphViz.php
index c1f5d91..d64c7cc 100644
--- a/includes/GraphViz.php
+++ b/includes/GraphViz.php
@@ -185,7 +185,8 @@
/**
 * Check if a given image type is probably allowed to be uploaded
 * (does not consult any file extension blacklists).
-* @param[in] string $imageType is the type of image (e.g. png) to 
check.
+* @param string $imageType is the type of image (e.g. png) to check.
+* @return bool
 * @author Keith Welter
 */
public static function imageTypeAllowed( $imageType ) {
@@ -201,6 +202,7 @@
/**
 * Set parser hook functions for supported graph types.
 * @author Keith Welter
+* @param Parser &$parser
 * @return true
 */
public static function onParserInit( Parser &$parser ) {
@@ -213,6 +215,10 @@
/**
 * When an article is deleted, delete all the associated graph files.
 * @author Keith Welter
+* @param Article &$article
+* @param User &$user
+* @param string $reason
+* @param int $id
 */
public static function onArticleDeleteComplete( &$article, User &$user, 
$reason, $id ) {
self::deleteArticleUploadedFiles( $article, self::getImageDir() 
);
@@ -223,6 +229,8 @@
/**
 * For a given title, get the corresponding graph file base name.
 * @author Keith Welter
+* @param Title $title
+* @return string
 */
public static function getGraphFileBaseNameFromTitle( $title ) {
$baseName = $title->getFulltext();
@@ -233,6 +241,8 @@
/**
 * Delete all the graph files associated with the given article and 
path.
 * @author Keith Welter
+* @param Article $article
+* @param string $path
 */
public static function deleteArticleFiles( $article, $path ) {
$title = $article->getTitle();
@@ -244,6 +254,8 @@
 
/**
 * Detect if the given title has associated graph files at the given 
path.
+* @param TItle $title
+* @param string $path
 * @return True if the title has associated graph files.  Otherwise 
false.
 * @author Keith Welter
 */
@@ -262,6 +274,8 @@
/**
 * Delete all uploaded files associated with the given article and path.
 * @author Keith Welter
+* @param Article $article
+* @param string $path
 */
public static function deleteArticleUploadedFiles( $article, $path ) {
wfDebug( __METHOD__ . ": entering\n" );
@@ -280,6 +294,8 @@
/**
 * Delete all the graph files associated with the graph name and path.
 * @author Keith Welter
+* @param string $graphName
+* @param string $path
 */
public static function deleteGraphFiles( $graphName, $path ) {
$globPattern = $path . $graphName . "*.*";
@@ -293,6 +309,10 @@
 * the parser cache reflects the canceled edit rather than the saved 
graph so we must
 * reject it.
 * @author Keith Welter
+* @param ParserOutput $parserOutput
+* @param WikiPage $wikiPage
+* @param ParserOptions $parserOptions
+* @return bool
 */
public static function onRejectParserCacheValue( $parserOutput, 
$wikiPage, $parserOptions ) {
$title = $wikiPage->getTitle();
@@ -313,6 +333,16 @@
 * (graph images for which the source wiki text has been deleted).
 * Graph images for extant wiki source will be regenerated when parsed.
 * @author Keith Welter
+* @param \WikiPage $wikiPage
+* @param User $user
+* @param Content $content
+* @param string $summary
+* @param bool $isMinor
+* @param bool $isWatch
+* @param string|int $section
+* @param int $flags
+* @param Status $status
+* @return true
 */
public static function onPageContentSave(
\WikiPage $wikiPage, $user, $content,
@@ -329,7 +359,7 @@
}
 
/**
-* 

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaIncubator[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402649 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ie83c1380e7804146090ca14ccd67bdd7efae4c2f
---
M .phpcs.xml
M InfoPage.php
M ListUsersTestWiki.php
M SpecialIncubatorFirstSteps.php
M SpecialSearchWiki.php
M WikimediaIncubator.class.php
6 files changed, 53 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaIncubator 
refs/changes/49/402649/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 73c6331..9cfdd4b 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   



diff --git a/InfoPage.php b/InfoPage.php
index da613ce..24cfff9 100644
--- a/InfoPage.php
+++ b/InfoPage.php
@@ -140,6 +140,9 @@
}
 
/**
+* @param string $beforetitle
+* @param string $aftertitle
+* @param string $content
 * @return String the core HTML for the info page
 */
public function StandardInfoPage( $beforetitle, $aftertitle, $content ) 
{
diff --git a/ListUsersTestWiki.php b/ListUsersTestWiki.php
index 713b6aa..dcd4284 100644
--- a/ListUsersTestWiki.php
+++ b/ListUsersTestWiki.php
@@ -21,6 +21,9 @@
 
/**
 * Input form
+* @param Pager $pager
+* @param string &$out
+* @return true
 */
static function onSpecialListusersHeaderForm( $pager, &$out ) {
$testwiki = WikimediaIncubator::getUrlParam();
@@ -53,6 +56,9 @@
 
/**
 * Query
+* @param Pager $pager
+* @param array &$query
+* @return true
 */
static function onSpecialListusersQueryInfo( $pager, &$query ) {
$testwiki = WikimediaIncubator::getUrlParam();
diff --git a/SpecialIncubatorFirstSteps.php b/SpecialIncubatorFirstSteps.php
index 8090c65..685d6bf 100644
--- a/SpecialIncubatorFirstSteps.php
+++ b/SpecialIncubatorFirstSteps.php
@@ -47,6 +47,7 @@
 * @param Message $msg Message object
 * @param bool $opaque
 * @param bool $done
+* @return string
 */
protected function showHeader( $msg, $opaque = true, $done = false ) {
$attrs = [];
diff --git a/SpecialSearchWiki.php b/SpecialSearchWiki.php
index 524d250..12ecfbb 100644
--- a/SpecialSearchWiki.php
+++ b/SpecialSearchWiki.php
@@ -98,6 +98,7 @@
/**
 * @param string $projectQuery
 * @param string $languageQuery
+* @return string
 */
protected function doSearch( $projectQuery, $languageQuery ) {
## Match project ##
diff --git a/WikimediaIncubator.class.php b/WikimediaIncubator.class.php
index fb3241b..26f7a95 100644
--- a/WikimediaIncubator.class.php
+++ b/WikimediaIncubator.class.php
@@ -125,6 +125,7 @@
/**
 * This validates a given language code.
 * Only "xx[x]" and "xx[x]-x[]" are allowed.
+* @param string $code
 * @return bool
 */
static function validateLanguageCode( $code ) {
@@ -278,7 +279,10 @@
/**
 * display the prefix by the given project and code
 * (or the URL = or user preference if no parameters are given)
-* @return String
+* @param string $project
+* @param string $code
+* @param bool $allowSister
+* @return string
 */
static function displayPrefix( $project = '', $code = '', $allowSister 
= false ) {
global $wmincSisterProjects;
@@ -371,7 +375,11 @@
 * Disables editing pages belonging to existing wikis (+ shows message)
 * Disables creating an unprefixed page (+ shows error message)
 * See also: WikimediaIncubator::onShowMissingArticle()
-* @return Boolean
+* @param Title $title
+* @param User $user
+* @param string $action
+* @param array &$result
+* @return bool
 */
static function onGetUserPermissionsErrors( $title, $user, $action, 
&$result ) {
$titletext = $title->getText();
@@ -425,7 +433,11 @@
/**
 * Return an error if the user wants to move
 * an existing page to an unprefixed title
-* @return Boolean
+* @param string $oldtitle
+* @param string $newtitle
+* @param User $user
+* @param array &$error
+* @return bool
 */
static function checkPrefixMovePermissions( $oldtitle, $newtitle, 
$user, &$error ) {
$status = new Status();
@@ -441,6 +453,10 @@
 * Add a link to Special:ViewUserLang from 
Special:Contributions/USERNAME
 * if the user has 'viewuserlang' permission
 * Based on code from extension LookupUser made by Tim Starling
+* @param int 

[MediaWiki-commits] [Gerrit] mediawiki...ReplaceText[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402648 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Iedadec2058cd979c659708876f131328a7614649
---
M .phpcs.xml
M SpecialReplaceText.php
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReplaceText 
refs/changes/48/402648/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 1c73823..aaeb946 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,8 +1,7 @@
 
 

-   
-   
+   



@@ -13,5 +12,4 @@
.


-   vendor
 
diff --git a/SpecialReplaceText.php b/SpecialReplaceText.php
index b4fc1df..be616a7 100644
--- a/SpecialReplaceText.php
+++ b/SpecialReplaceText.php
@@ -383,6 +383,9 @@
/**
 * Copied almost exactly from MediaWiki's SpecialSearch class, i.e.
 * the search page
+* @param array $namespaces
+* @param int $rowsPerTable
+* @return array
 */
function namespaceTables( $namespaces, $rowsPerTable = 3 ) {
global $wgContLang;
@@ -529,6 +532,10 @@
 * Extract context and highlights search text
 *
 * @todo The bolding needs to be fixed for regular expressions.
+* @param string $text
+* @param string $target
+* @param bool $use_regex
+* @return string
 */
function extractContext( $text, $target, $use_regex = false ) {
global $wgLang;

-- 
To view, visit https://gerrit.wikimedia.org/r/402648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedadec2058cd979c659708876f131328a7614649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402647 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ic445760aa7afec15cf56222a7053c3f9de6f559d
---
M .phpcs.xml
M ApiQueryProofread.php
M ApiQueryProofreadInfo.php
M ProofreadPage.body.php
M includes/Index/CustomIndexFieldsParser.php
M includes/Index/DatabaseIndexContentLookup.php
M includes/Index/EditIndexPage.php
M includes/Index/IndexContent.php
M includes/Index/IndexContentHandler.php
M includes/Index/IndexContentLookup.php
M includes/Index/IndexDifferenceEngine.php
M includes/Index/IndexRedirectContent.php
M includes/Page/DatabaseIndexForPageLookup.php
M includes/Page/EditPagePage.php
M includes/Page/IndexForPageLookup.php
M includes/Page/PageContent.php
M includes/Page/PageContentHandler.php
M includes/Page/PageDifferenceEngine.php
M includes/Page/PageDisplayHandler.php
M includes/Pagination/FilePagination.php
M includes/Pagination/PagePagination.php
M includes/Pagination/Pagination.php
M includes/Parser/PagelistTagParser.php
M includes/Parser/PagequalityTagParser.php
M includes/Parser/PagesTagParser.php
M includes/Parser/TagParser.php
M maintenance/fixProofreadIndexPagesContentModel.php
M maintenance/fixProofreadPagePagesContentModel.php
M tests/phpunit/FileProviderMock.php
M tests/phpunit/Index/IndexContentLookupMock.php
M tests/phpunit/Page/IndexForPageLookupMock.php
31 files changed, 110 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/47/402647/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 2855261..9b83b12 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,15 +4,10 @@



-   
-   




-   
-   
-   */maintenance/*



diff --git a/ApiQueryProofread.php b/ApiQueryProofread.php
index a2b0583..36893eb 100644
--- a/ApiQueryProofread.php
+++ b/ApiQueryProofread.php
@@ -114,7 +114,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/ApiQueryProofreadInfo.php b/ApiQueryProofreadInfo.php
index a5c1fb2..18689a4 100644
--- a/ApiQueryProofreadInfo.php
+++ b/ApiQueryProofreadInfo.php
@@ -88,7 +88,7 @@
}
 
/**
-* @see ApiBase::getExamplesMessages()
+* @inheritDoc
 */
protected function getExamplesMessages() {
return [
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index b50dea5..b467703 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -618,6 +618,8 @@
 
/**
 * Adds canonical namespaces.
+* @param array &$list
+* @return true
 */
public static function addCanonicalNamespaces( &$list ) {
$list[self::getPageNamespaceId()] = 'Page';
@@ -661,6 +663,7 @@
 * Add the links to previous, next, index page and scan image to Page: 
pages.
 * @param SkinTemplate &$skin
 * @param array &$links Structured navigation links
+* @return true
 */
public static function onSkinTemplateNavigation( SkinTemplate &$skin, 
array &$links ) {
$title = $skin->getTitle();
@@ -751,6 +754,7 @@
 * Add proofreading status to action=info
 * @param IContextSource $context
 * @param array &$pageInfo The page information
+* @return true
 */
public static function onInfoAction( IContextSource $context, array 
&$pageInfo ) {
if ( !$context->canUseWikiPage() ) {
diff --git a/includes/Index/CustomIndexFieldsParser.php 
b/includes/Index/CustomIndexFieldsParser.php
index c7673b0..570e394 100644
--- a/includes/Index/CustomIndexFieldsParser.php
+++ b/includes/Index/CustomIndexFieldsParser.php
@@ -156,6 +156,7 @@
 
/**
 * Return metadata from the index page that have to be given to header 
template.
+* @param IndexContent $content
 * @return CustomIndexField[]
 */
public function parseCustomIndexFieldsForHeader( IndexContent $content 
) {
@@ -172,6 +173,8 @@
/**
 * Return the index entry with the same name or null if it's not found
 * Note: the comparison is case insensitive
+* @param IndexContent $content
+* @param string $fieldName
 * @return CustomIndexField
 * @throws OutOfBoundsException
 */
diff --git a/includes/Index/DatabaseIndexContentLookup.php 
b/includes/Index/DatabaseIndexContentLookup.php
index 36cd727..9827776 100644
--- a/includes/Index/DatabaseIndexContentLookup.php
+++ b/includes/Index/DatabaseIndexContentLookup.php
@@ -15,7 +15,7 @@
private 

[MediaWiki-commits] [Gerrit] mediawiki...OAuthAuthentication[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402646 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Iebc7d5eb0d0eb15a12193f2b7b1db98c08d94069
---
M .phpcs.xml
M utils/Hooks.php
2 files changed, 6 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication 
refs/changes/46/402646/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 78a662d..b15894e 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,14 +1,11 @@
 
 

-   
-   
-   
+   



.

-   
-   vendor
+   
 
diff --git a/utils/Hooks.php b/utils/Hooks.php
index 51cfb1b..1ee68fd 100644
--- a/utils/Hooks.php
+++ b/utils/Hooks.php
@@ -117,7 +117,8 @@
 
/**
 * Check that the identity complies with the site policy
-*
+* @param \User $user
+* @return true
 */
public static function onUserLoadAfterLoadFromSession( \User $user ) {
global $wgOAuthAuthenticationMaxIdentityAge;
@@ -150,8 +151,8 @@
}
 
/**
-* @param $user \User
-* @param $abortError
+* @param \User $user
+* @param bool &$abortError
 * @return bool
 */
public static function onAbortNewAccount( $user, &$abortError ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/402646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebc7d5eb0d0eb15a12193f2b7b1db98c08d94069
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OnlineStatus[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402645 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Iaab5cc7473f5ac85b8422149ce1a2f7e389448c2
---
M .phpcs.xml
M OnlineStatus.body.php
2 files changed, 33 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OnlineStatus 
refs/changes/45/402645/1

diff --git a/.phpcs.xml b/.phpcs.xml
index debe53d..8c77608 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,14 +1,12 @@
 
 

-   
-   
+   




.

-   
-   vendor
+   
 
diff --git a/OnlineStatus.body.php b/OnlineStatus.body.php
index ff0392f..9d9a012 100644
--- a/OnlineStatus.body.php
+++ b/OnlineStatus.body.php
@@ -6,6 +6,7 @@
 *
 * @param mixed $title string of Title object, if it's a title, if has 
to be in
 * User: of User_talk: namespace.
+* @param bool $checkShowPref
 * @return array ( string status, string username   ) or null
 */
static function GetUserStatus( $title, $checkShowPref = false ) {
@@ -39,6 +40,9 @@
 
/**
 * Used for AJAX requests
+* @param string $action
+* @param bool $stat
+* @return string
 */
static function Ajax( $action, $stat = false ) {
global $wgUser;
@@ -99,6 +103,8 @@
 
/**
 * Hook for ParserFirstCallInit
+* @param Parser $parser
+* @return true
 */
static function ParserFirstCallInit( $parser ) {
global $wgAllowAnyUserOnlineStatusFunction;
@@ -111,6 +117,10 @@
 
/**
 * Callback for {{#anyuserstatus:}}
+* @param Parser &$parser
+* @param User $user
+* @param bool $raw
+* @return array|string
 */
static function ParserHookCallback( &$parser, $user, $raw = false ) {
$status = self::GetUserStatus( $user );
@@ -130,6 +140,8 @@
 
/**
 * Hook function for MagicWordwgVariableIDs
+* @param array &$magicWords
+* @return true
 */
static function MagicWordVariable( &$magicWords ) {
$magicWords[] = 'onlinestatus_word';
@@ -140,6 +152,11 @@
 
/**
 * Hook function for ParserGetVariableValueSwitch
+* @param Parser &$parser
+* @param array &$varCache
+* @param string &$index
+* @param array &$ret
+* @return true
 */
static function ParserGetVariable( &$parser, &$varCache, &$index, &$ret 
) {
if ( $index == 'onlinestatus_word' ) {
@@ -169,6 +186,9 @@
 
/**
 * Hook for user preferences
+* @param User $user
+* @param array &$preferences
+* @return true
 */
public static function GetPreferences( $user, &$preferences ) {
$msg = wfMessage( 'onlinestatus-levels' 
)->inContentLanguage()->plain();
@@ -223,6 +243,8 @@
 
/**
 * Hook for UserLoginComplete
+* @param User $user
+* @return true
 */
static function UserLoginComplete( $user ) {
if ( $user->getOption( 'onlineonlogin' ) ) {
@@ -235,6 +257,10 @@
 
/**
 * Hook for UserLoginComplete
+* @param User &$newUser
+* @param string &$injected_html
+* @param string|null $oldName
+* @return true
 */
static function UserLogoutComplete( &$newUser, &$injected_html, 
$oldName = null ) {
if ( $oldName === null ) {
@@ -257,6 +283,8 @@
 
/**
 * Hook function for BeforePageDisplay
+* @param OutputPage &$out
+* @return true
 */
static function BeforePageDisplay( &$out ) {
global $wgRequest, $wgUser, $wgUseAjax;
@@ -289,6 +317,9 @@
 
/**
 * Hook for PersonalUrls
+* @param array &$urls
+* @param Title &$title
+* @return true
 */
static function PersonalUrls( &$urls, &$title ) {
global $wgUser, $wgUseAjax;

-- 
To view, visit https://gerrit.wikimedia.org/r/402645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaab5cc7473f5ac85b8422149ce1a2f7e389448c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OnlineStatus
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402644 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: If9f6b458c47d318482388b7441dfae57da29d26b
---
M .phpcs.xml
M WebVideoTranscode/WebVideoTranscode.php
M tests/phpunit/ApiTestCaseVideoUpload.php
M tests/phpunit/TestApiUploadVideo.php
M tests/phpunit/TestVideoThumbnail.php
M tests/phpunit/TestVideoTranscode.php
6 files changed, 16 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/44/402644/1

diff --git a/.phpcs.xml b/.phpcs.xml
index fef4d9a..cf7a5c0 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,15 +4,9 @@



-   
-   
-   



-   
-   
-   */maintenance/*



TimedMediaHandler\.i18n\.*\.php
diff --git a/WebVideoTranscode/WebVideoTranscode.php 
b/WebVideoTranscode/WebVideoTranscode.php
index c8125ab..48dddbb 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -852,6 +852,7 @@
 *
 * @param File $file File object
 * @param IDatabase|bool $db
+* @return array
 */
public static function getTranscodeState( $file, $db = false ) {
global $wgTranscodeBackgroundTimeLimit;
@@ -997,6 +998,10 @@
 *
 * If the source is not found, it will not be used yet...
 * Missing transcodes should be added by write tasks, not read tasks!
+* @param array &$file
+* @param array &$sources
+* @param string $transcodeKey
+* @param string $dataPrefix
 */
public static function addSourceIfReady( &$file, &$sources, 
$transcodeKey, $dataPrefix = '' ) {
// Check if the transcode is ready:
@@ -1371,6 +1376,8 @@
/**
 * Is the given transcode key the smallest configured transcode for
 * its video codec?
+* @param string $transcodeKey
+* @return true
 */
public static function isSmallestTranscodeForCodec( $transcodeKey ) {
global $wgEnabledTranscodeSet;
diff --git a/tests/phpunit/ApiTestCaseVideoUpload.php 
b/tests/phpunit/ApiTestCaseVideoUpload.php
index 4cf98e1..1b482eb 100644
--- a/tests/phpunit/ApiTestCaseVideoUpload.php
+++ b/tests/phpunit/ApiTestCaseVideoUpload.php
@@ -47,10 +47,10 @@
]
];
}
+
/**
 * Fixture -- run after every test
 * Clean up temporary files etc.
-*
 */
protected function tearDown() {
parent::tearDown();
@@ -65,6 +65,8 @@
 
/**
 * Do login
+* @param string $user
+* @return array
 */
protected function doLogin( $user = 'sysop' ) {
$user = self::$users['uploader'];
@@ -88,7 +90,9 @@
}
 
/**
-* uploads a file:
+* uploads a file
+* @param array $file
+* @return array
 */
public function uploadFile( $file ) {
global $wgUser;
diff --git a/tests/phpunit/TestApiUploadVideo.php 
b/tests/phpunit/TestApiUploadVideo.php
index 7ee4b89..598e321 100644
--- a/tests/phpunit/TestApiUploadVideo.php
+++ b/tests/phpunit/TestApiUploadVideo.php
@@ -19,6 +19,7 @@
 
/**
 * @dataProvider mediaFilesProvider
+* @param array $file
 */
public function testUploadVideoFiles( $file ) {
$result = $this->uploadFile( $file );
diff --git a/tests/phpunit/TestVideoThumbnail.php 
b/tests/phpunit/TestVideoThumbnail.php
index f3cfea4..b9af900 100644
--- a/tests/phpunit/TestVideoThumbnail.php
+++ b/tests/phpunit/TestVideoThumbnail.php
@@ -10,6 +10,7 @@
 * Once video files are uploaded test thumbnail generating
 *
 * @dataProvider mediaFilesProvider
+* @param array $file
 * Broken as per bug 61877
 * @group Broken
 */
diff --git a/tests/phpunit/TestVideoTranscode.php 
b/tests/phpunit/TestVideoTranscode.php
index b03ab4e..9a303b1 100644
--- a/tests/phpunit/TestVideoTranscode.php
+++ b/tests/phpunit/TestVideoTranscode.php
@@ -12,6 +12,7 @@
 *  Test if a transcode job is added for a file once requested
 *
 * @dataProvider mediaFilesProvider
+* @param array $file
 * Broken as per bug 61878
 * @group Broken
 */
@@ -87,7 +88,6 @@
}
}
 
-   // Run Transcode job
function runTranscodeJobs() {
$dbw = wfGetDB( DB_MASTER );
$type = 'webVideoTranscode';

-- 
To view, visit https://gerrit.wikimedia.org/r/402644
To unsubscribe, visit 

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Fix return void in SpecialOrphanedTimedText::execute

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402642 )

Change subject: Fix return void in SpecialOrphanedTimedText::execute
..

Fix return void in SpecialOrphanedTimedText::execute

QueryPage::execute returns void, no need to use a return statement here

Change-Id: I51d1863a1072dcf6a67ec824dd9ed20ed73b3f4c
---
M SpecialOrphanedTimedText.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/42/402642/1

diff --git a/SpecialOrphanedTimedText.php b/SpecialOrphanedTimedText.php
index 00153f4..ebbe1ab 100644
--- a/SpecialOrphanedTimedText.php
+++ b/SpecialOrphanedTimedText.php
@@ -58,7 +58,7 @@
$this->getOutput()->addWikiMsg( 
'orphanedtimedtext-unsupported' );
return;
}
-   return parent::execute( $par );
+   parent::execute( $par );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/402642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51d1863a1072dcf6a67ec824dd9ed20ed73b3f4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TwnMainPage[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402641 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I1cc6e7812ebf890f14a6621426bf31c1d507d8d5
---
M .phpcs.xml
M ProjectHandler.php
M ResourceLoaderProjectIconsModule.php
M specials/SpecialTwnMainPage.php
4 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage 
refs/changes/41/402641/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 7fca01b..cb6203b 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,17 +3,11 @@



-   
-   
-   
-   
-   




.

-   
-   vendor
+   
 
diff --git a/ProjectHandler.php b/ProjectHandler.php
index e53523b..0dac29f 100644
--- a/ProjectHandler.php
+++ b/ProjectHandler.php
@@ -45,7 +45,7 @@
/**
 * Sort the projects by to be determined algorithm. Like most sorting
 * functions in PHP this modifies passed list in place.
-* @param MessageGroup[] $groups
+* @param MessageGroup[] &$groups
 * @param string $language Language code.
 * @param array $stats Message group stats.
 */
diff --git a/ResourceLoaderProjectIconsModule.php 
b/ResourceLoaderProjectIconsModule.php
index 9b80382..703210d 100644
--- a/ResourceLoaderProjectIconsModule.php
+++ b/ResourceLoaderProjectIconsModule.php
@@ -33,7 +33,7 @@
 
/**
 * @see also resouces/css/ext.translate.mainpage.css
-* @param $context ResourceLoaderContext
+* @param ResourceLoaderContext $context
 * @return array CSS styles
 */
public function getStyles( ResourceLoaderContext $context ) {
diff --git a/specials/SpecialTwnMainPage.php b/specials/SpecialTwnMainPage.php
index 29e75ef..5db4730 100644
--- a/specials/SpecialTwnMainPage.php
+++ b/specials/SpecialTwnMainPage.php
@@ -433,7 +433,11 @@
return $count;
}
 
-   // Callback for CachedStat
+   /**
+* Callback for CachedStat
+* @param ProjectHandler $handler
+* @return array
+*/
public static function getTwnStats( ProjectHandler $handler ) {
$projects = count( $handler->getProjects() );
$translators = SiteStats::numberingroup( 'translator' );
@@ -448,7 +452,12 @@
];
}
 
-   // Callback for CachedStat
+   /**
+* Callback for CachedStat
+* @param string $code
+* @param int $period
+* @return array
+*/
public static function getUserStats( $code, $period ) {
return [
'translators' => TwnUserStats::getTranslationRankings( 
$code, $period ),
@@ -533,6 +542,7 @@
 
/**
 * Form that allows users to signup via sandbox.
+* @return true
 */
public function loginForm() {
$this->getOutput()->addModules( 'ext.translate.mainpage.signup' 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/402641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cc6e7812ebf890f14a6621426bf31c1d507d8d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TopTenPages[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402640 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I9c25b7fd492753415dcd546f345e6f740b416c62
---
M .phpcs.xml
M SpecialTopTenPages.php
M TopTenPages.hooks.php
3 files changed, 23 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TopTenPages 
refs/changes/40/402640/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d883e25..0bcff2b 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,15 +1,11 @@
 
 

-   
-   
+   


-   
-   

.

-   
-   vendor
+   
 
diff --git a/SpecialTopTenPages.php b/SpecialTopTenPages.php
index c7bb473..10dc71f 100644
--- a/SpecialTopTenPages.php
+++ b/SpecialTopTenPages.php
@@ -2,19 +2,27 @@
 use HitCounters\SpecialPopularPages;
 
 class SpecialTopTenPages extends SpecialPopularPages {
+   /**
+* @param string $name
+*/
public function __construct( $name = 'TopTenPages' ) {
parent::__construct( $name );
$inc = $this->including();
}
 
+   /** @inheritDoc */
public function isIncludable() {
return true;
}
 
+   /** @inheritDoc */
function isListed() {
return false;
}
 
+   /**
+* @param string|null $par
+*/
function execute( $par ) {
$inc = $this->including();
 
@@ -28,6 +36,10 @@
parent::execute( $par );
}
 
+   /**
+* @param int $offset
+* @return string
+*/
function openList( $offset ) {
global $wgTopTenPagesStartAtOne;
if ( $wgTopTenPagesStartAtOne ) {
@@ -36,6 +48,7 @@
return parent::openList( $offset );
}
 
+   /** @inheritDoc */
protected function getGroupName() {
return 'other';
}
diff --git a/TopTenPages.hooks.php b/TopTenPages.hooks.php
index 546cd88..a7e2573 100644
--- a/TopTenPages.hooks.php
+++ b/TopTenPages.hooks.php
@@ -1,12 +1,20 @@
 setHook( 'TopTenPages', 'TopTenPagesHooks::renderTag' 
);
}
 
/**
 * The callback function for converting the input text to HTML output.
+* @param string $text
+* @param array $args
+* @param Parser $parser
+* @param PPFrame $frame
+* @return string
 */
public static function renderTag( $text, array $args, Parser $parser, 
PPFrame $frame ) {
if ( array_key_exists( 'offset', $args ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/402640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c25b7fd492753415dcd546f345e6f740b416c62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TopTenPages
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SubpageSortkey[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402639 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
---
M .phpcs.xml
M SubpageSortkey_body.php
2 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SubpageSortkey 
refs/changes/39/402639/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 3773e8f..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,13 +1,10 @@
 
 

-   
-   
+   


.

-   
-   vendor
-   node_modules
+   
 
diff --git a/SubpageSortkey_body.php b/SubpageSortkey_body.php
index b903e8a..f5cfb40 100644
--- a/SubpageSortkey_body.php
+++ b/SubpageSortkey_body.php
@@ -14,6 +14,9 @@
 *
 * Another example: Configuration -3..-1 turns 1/2/3/4/5 -> 3/4
 * and -3.. turns 1/2/3/4/5 -> 3/4/5
+* @param Title $title
+* @param string &$unprefixed
+* @return true
 */
public static function onGetDefaultSortkey( $title, &$unprefixed ) {
global $wgSubpageSortkeyDefault,
@@ -60,10 +63,10 @@
}
 
/**
-* @param $index Int starting index of subpage.
-* @param $count Int how many elements, or false to denote all
-* @param $title Title
-* @return array of subpages (strings)
+* @param int $index starting index of subpage.
+* @param int $count how many elements, or false to denote all
+* @param Title $title
+* @return string[] array of subpages
 */
private static function getSubpage( $index, $count, $title ) {
$subpages = explode( '/', $title->getText() );

-- 
To view, visit https://gerrit.wikimedia.org/r/402639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I48b8a33f1fe37cddbe4a1fd7d5fed14e4026691d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SubpageSortkey
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SmiteSpam[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402638 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I20caa680a06519f34898b16ddea1d17f35b15961
---
M .phpcs.xml
M SmiteSpam.hooks.php
M SpecialSmiteSpam.php
M SpecialSmiteSpamTrustedUsers.php
M api/SmiteSpamApiQuery.php
M api/SmiteSpamApiTrustUser.php
M includes/SmiteSpamAnalyzer.php
M includes/SmiteSpamWikiPage.php
8 files changed, 31 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SmiteSpam 
refs/changes/38/402638/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 1898deb..84e8877 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,16 +1,13 @@
 
 

+   

-   

-   


-   

.

-   
-   vendor
+   
 
diff --git a/SmiteSpam.hooks.php b/SmiteSpam.hooks.php
index be583ce..aa7f0fc 100644
--- a/SmiteSpam.hooks.php
+++ b/SmiteSpam.hooks.php
@@ -1,13 +1,20 @@
 addExtensionTable( 'smitespam_trusted_user',
__DIR__ . '/smitespam.sql' );
return true;
}
 
+   /**
+* @param ALTree &$adminLinksTree
+*/
public static function addToAdminLinks( ALTree &$adminLinksTree ) {
$spamToolsMessage = wfMessage( 'specialpages-group-spam' 
)->text();
 
diff --git a/SpecialSmiteSpam.php b/SpecialSmiteSpam.php
index 004c063..9336602 100644
--- a/SpecialSmiteSpam.php
+++ b/SpecialSmiteSpam.php
@@ -8,6 +8,9 @@
parent::__construct( 'SmiteSpam', 'smitespam' );
}
 
+   /**
+* @param string|null $subPage
+*/
public function execute( $subPage ) {
if ( !$this->userCanExecute( $this->getUser() ) ) {
$this->displayRestrictionError();
@@ -61,6 +64,7 @@
] );
}
 
+   /** @inheritDoc */
function getGroupName() {
return 'spam';
}
diff --git a/SpecialSmiteSpamTrustedUsers.php b/SpecialSmiteSpamTrustedUsers.php
index 39687a5..065a9b8 100644
--- a/SpecialSmiteSpamTrustedUsers.php
+++ b/SpecialSmiteSpamTrustedUsers.php
@@ -6,10 +6,14 @@
parent::__construct( 'SmiteSpamTrustedUsers', 'smitespam' );
}
 
+   /** @inheritDoc */
public function doesWrites() {
return true;
}
 
+   /**
+* @param string|null $subPage
+*/
public function execute( $subPage ) {
if ( !$this->userCanExecute( $this->getUser() ) ) {
$this->displayRestrictionError();
diff --git a/api/SmiteSpamApiQuery.php b/api/SmiteSpamApiQuery.php
index bab89c1..29ffc1c 100644
--- a/api/SmiteSpamApiQuery.php
+++ b/api/SmiteSpamApiQuery.php
@@ -102,7 +102,7 @@
return true;
}
 
-   // Face parameter.
+   /** @inheritDoc */
public function getAllowedParams() {
return array_merge( parent::getAllowedParams(), [
'offset' => [
@@ -116,7 +116,7 @@
] );
}
 
-   // Get examples
+   /** @inheritDoc */
public function getExamples() {
return [
'api.php?action=smitespamanalyze=5=10'
diff --git a/api/SmiteSpamApiTrustUser.php b/api/SmiteSpamApiTrustUser.php
index fe1c8ac..183687a 100644
--- a/api/SmiteSpamApiTrustUser.php
+++ b/api/SmiteSpamApiTrustUser.php
@@ -44,7 +44,7 @@
return true;
}
 
-   // Face parameter.
+   /** @inheritDoc */
public function getAllowedParams() {
return array_merge( parent::getAllowedParams(), [
'username' => [
@@ -54,7 +54,7 @@
] );
}
 
-   // Get examples
+   /** @inheritDoc */
public function getExamples() {
return [
'api.php?action=smitespamtrustuser=Admin'
diff --git a/includes/SmiteSpamAnalyzer.php b/includes/SmiteSpamAnalyzer.php
index a02d07f..35d2288 100644
--- a/includes/SmiteSpamAnalyzer.php
+++ b/includes/SmiteSpamAnalyzer.php
@@ -9,6 +9,9 @@
 */
protected $config;
 
+   /**
+* @param bool $sort
+*/
public function __construct( $sort = true ) {
global $wgSmiteSpamCheckers, $wgSmiteSpamThreshold;
global $wgSmiteSpamIgnorePagesWithNoExternalLinks;
@@ -21,12 +24,15 @@
'sort' => $sort,
];
}
+
/**
 * Retrieves a list of pages in the wiki based on the offset and limit
 * and runs checks on each of them. Pages whose evaluated value exceeds 
the
 * threshold defined in the configuration are returned as an array.
 * @todo Perform DB queries in batches, else 

[MediaWiki-commits] [Gerrit] mediawiki...Git2Pages[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402637 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ie4f1f962c9fa07bf3632b0bb84ebfbe07d452d27
---
M .phpcs.xml
M Git2Pages.body.php
M GitRepository.php
3 files changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Git2Pages 
refs/changes/37/402637/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 69ede16..8c77608 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,15 +2,11 @@
 


-   
-   
-   




.

-   
-   vendor
+   
 
diff --git a/Git2Pages.body.php b/Git2Pages.body.php
index 0f613e6..423d7d8 100644
--- a/Git2Pages.body.php
+++ b/Git2Pages.body.php
@@ -16,6 +16,8 @@
 
/**
 * Registers the parser function hook
+* @param Parser $parser
+* @return true
 */
public static function Git2PagesSetup( $parser ) {
$parser->setFunctionHook( 'snippet', [ 'Git2PagesHooks', 
'PullContentFromRepo' ] );
@@ -26,8 +28,8 @@
 * Converts an array of values in form [0] => "name=value" into a real
 * associative array in form [name] => value
 *
-* @param array string $options
-* @return array $results
+* @param array $options
+* @return array
 */
static function extractOptions( array $options ) {
$results = [];
@@ -56,6 +58,7 @@
 * Pulls the content from a repository
 *
 * @param array $parser Array, the first element a Parser instance, 
then the user input values
+* @return string|array
 */
public static function PullContentFromRepo( $parser ) {
global $wgGit2PagesDataDir;
diff --git a/GitRepository.php b/GitRepository.php
index 6a3c5ac..da65fde 100644
--- a/GitRepository.php
+++ b/GitRepository.php
@@ -3,6 +3,7 @@
  * A class to manipulate a Git repository.
  */
 class GitRepository {
+   /** @var string $gitUrl */
protected $gitUrl;
 
/**
@@ -66,11 +67,14 @@
] );
chdir( $oldDir );
}
+
/**
 * Clones just the .git folder
 *
 * @param string $url
 * @param string $gitFolder
+* @param string $checkoutItem
+* @param string $branch
 */
static function SparseCheckoutNewRepo( $url, $gitFolder, $checkoutItem, 
$branch ) {
$oldDir = getcwd();
@@ -127,8 +131,12 @@
/**
 * Finds and reads the file.
 *
+* @param string $filename
 * @param string $gitFolder contains the path to Git repo folder
-* @param array $options contains user inputs
+* @param int $startLine
+* @param int $endLine
+* @return string
+* @throws Exception
 */
function FindAndReadFile( $filename, $gitFolder, $startLine = 1, 
$endLine = -1 ) {
# Remove file separators (dots) and slashes to prevent 
directory traversal attack

-- 
To view, visit https://gerrit.wikimedia.org/r/402637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4f1f962c9fa07bf3632b0bb84ebfbe07d452d27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Git2Pages
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CollapsibleVector[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402636 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I035113949da23a67058ec9d22b1079da3f97400a
---
M .phpcs.xml
M CollapsibleVectorHooks.php
2 files changed, 13 insertions(+), 21 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollapsibleVector 
refs/changes/36/402636/1

diff --git a/.phpcs.xml b/.phpcs.xml
index e9c55b5..04bdc33 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,16 +1,9 @@
 
 

-   
-   
-   
-   
-   
-   

-   
-   
-   */maintenance/*
+   
+   

.

diff --git a/CollapsibleVectorHooks.php b/CollapsibleVectorHooks.php
index 64981a6..24f65ee 100644
--- a/CollapsibleVectorHooks.php
+++ b/CollapsibleVectorHooks.php
@@ -8,8 +8,7 @@
 
 class CollapsibleVectorHooks {
 
-   /* Protected Static Members */
-
+   /** @var array $features */
protected static $features = [
'collapsiblenav' => [
'preferences' => [
@@ -35,15 +34,13 @@
],
];
 
-   /* Static Methods */
-
/**
 * Checks if a certain option is enabled
 *
 * This method is public to allow other extensions that use 
CollapsibleVector to use the
 * same configuration as CollapsibleVector itself
 *
-* @param $name string Name of the feature, should be a key of $features
+* @param string $name Name of the feature, should be a key of $features
 * @return bool
 */
public static function isEnabled( $name ) {
@@ -73,15 +70,14 @@
return false;
}
 
-   /* Static Methods */
-
/**
 * BeforePageDisplay hook
 *
 * Adds the modules to the page
 *
-* @param $out OutputPage output page
-* @param $skin Skin current skin
+* @param OutputPage $out output page
+* @param Skin $skin current skin
+* @return true
 */
public static function beforePageDisplay( $out, $skin ) {
if ( $skin instanceof SkinVector ) {
@@ -100,8 +96,9 @@
 *
 * Adds Vector-releated items to the preferences
 *
-* @param $user User current user
-* @param $defaultPreferences array list of default user preference 
controls
+* @param User $user current user
+* @param array &$defaultPreferences list of default user preference 
controls
+* @return true
 */
public static function getPreferences( $user, &$defaultPreferences ) {
global $wgCollapsibleVectorFeatures;
@@ -123,6 +120,8 @@
 * ResourceLoaderGetConfigVars hook
 *
 * Adds enabled/disabled switches for Vector modules
+* @param array &$vars
+* @return true
 */
public static function resourceLoaderGetConfigVars( &$vars ) {
global $wgCollapsibleVectorFeatures;
@@ -146,7 +145,7 @@
}
 
/**
-* @param $vars array
+* @param array &$vars
 * @return bool
 */
public static function makeGlobalVariablesScript( &$vars ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/402636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I035113949da23a67058ec9d22b1079da3f97400a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollapsibleVector
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402635 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ia3e62f7935db45350a6ff7d60befa1d0072b4b30
---
M .phpcs.xml
M Citoid.hooks.php
M CitoidDataModule.php
3 files changed, 26 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid 
refs/changes/35/402635/1

diff --git a/.phpcs.xml b/.phpcs.xml
index c4c4501..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,15 +1,10 @@
 
 

-   
-   
-   
+   

-   

.

-   
-   vendor
-   node_modules
+   
 
diff --git a/Citoid.hooks.php b/Citoid.hooks.php
index 7a27a36..b057134 100644
--- a/Citoid.hooks.php
+++ b/Citoid.hooks.php
@@ -10,6 +10,8 @@
 
/**
 * Adds extra variables to the global config
+* @param array &$vars
+* @return true
 */
public static function onResourceLoaderGetConfigVars( array &$vars ) {
global $wgCitoidServiceUrl;
@@ -23,6 +25,9 @@
 
/**
 * Register qunit unit tests
+* @param array &$testModules
+* @param ResourceLoader &$resourceLoader
+* @return true
 */
public static function onResourceLoaderTestModules(
array &$testModules,
@@ -47,6 +52,11 @@
return true;
}
 
+   /**
+* @param User $user
+* @param array &$preferences
+* @return true
+*/
public static function onGetPreferences( User $user, array 
&$preferences ) {
$preferences['citoid-mode'] = [
'type' => 'api'
diff --git a/CitoidDataModule.php b/CitoidDataModule.php
index c32e077..480a2cd 100644
--- a/CitoidDataModule.php
+++ b/CitoidDataModule.php
@@ -12,13 +12,16 @@
 
 class CitoidDataModule extends ResourceLoaderModule {
 
-   /* Protected Members */
-
+   /** @var string $origin */
protected $origin = self::ORIGIN_USER_SITEWIDE;
+
+   /** @var array $targets */
protected $targets = [ 'desktop', 'mobile' ];
 
-   /* Methods */
-
+   /**
+* @param ResourceLoaderContext $context
+* @return string
+*/
public function getScript( ResourceLoaderContext $context ) {
return 've.init.platform.addMessages(' . FormatJson::encode(
[
@@ -31,6 +34,10 @@
) . ');';
}
 
+   /**
+* @param ResourceLoaderContext|null $context
+* @return array
+*/
public function getDependencies( ResourceLoaderContext $context = null 
) {
return [
'ext.visualEditor.base',
@@ -38,6 +45,9 @@
];
}
 
+   /**
+* @return bool
+*/
public function enableModuleContentVersion() {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/402635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3e62f7935db45350a6ff7d60befa1d0072b4b30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402634 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I2f1dfd94674bc6a20134b56d41f05a02cb038e64
---
M .phpcs.xml
M includes/CentralAuthHooks.php
M includes/CentralAuthUser.php
M includes/api/ApiCentralAuthToken.php
M includes/api/ApiDeleteGlobalAccount.php
M includes/api/ApiGlobalUserRights.php
M includes/api/ApiQueryGlobalAllUsers.php
M includes/api/ApiQueryGlobalGroups.php
M includes/api/ApiQueryGlobalRenameStatus.php
M includes/api/ApiQueryGlobalUserInfo.php
M includes/api/ApiQueryWikiSets.php
M includes/api/ApiSetGlobalAccountStatus.php
M includes/specials/SpecialGlobalRenameRequest.php
13 files changed, 18 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/34/402634/1

diff --git a/.phpcs.xml b/.phpcs.xml
index ffef7f4..eb0da02 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,12 +1,9 @@
 
 

-   



-   
-   



diff --git a/includes/CentralAuthHooks.php b/includes/CentralAuthHooks.php
index b84cb05..c4abfe9 100644
--- a/includes/CentralAuthHooks.php
+++ b/includes/CentralAuthHooks.php
@@ -1324,9 +1324,9 @@
return true;
}
 
-   /*
+   /**
 * Handler for UserGetReservedNames
-* @param array $reservedUsernames
+* @param array &$reservedUsernames
 * @return bool
 */
public static function onUserGetReservedNames( &$reservedUsernames ) {
@@ -1451,6 +1451,7 @@
/**
 * Create databases for WMF Jenkins unit tests
 * @param DatabaseUpdater $updater
+* @return true
 */
public static function onLoadExtensionSchemaUpdates( DatabaseUpdater 
$updater ) {
global $wgWikimediaJenkinsCI;
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index a763bb6..9bb6feb 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -607,6 +607,7 @@
 
/**
 * Return the global-login token for this account.
+* @return string
 */
public function getAuthToken() {
global $wgAuthenticationTokenVersion;
@@ -677,6 +678,7 @@
/**
 * Returns the hidden level of
 * the account.
+* @return string
 */
public function getHiddenLevel() {
$this->loadState();
@@ -2628,6 +2630,7 @@
/**
 * Get the password hash.
 * Automatically converts to a new-style hash
+* @return string
 */
function getPassword() {
$this->loadState();
diff --git a/includes/api/ApiCentralAuthToken.php 
b/includes/api/ApiCentralAuthToken.php
index 855d654..2340cfc 100644
--- a/includes/api/ApiCentralAuthToken.php
+++ b/includes/api/ApiCentralAuthToken.php
@@ -98,9 +98,7 @@
];
}
 
-   /**
-* @see ApiBase::getExamplesMessages()
-*/
+   /** @inheritDoc */
protected function getExamplesMessages() {
return [
'action=centralauthtoken'
diff --git a/includes/api/ApiDeleteGlobalAccount.php 
b/includes/api/ApiDeleteGlobalAccount.php
index 2ab156e..e137604 100644
--- a/includes/api/ApiDeleteGlobalAccount.php
+++ b/includes/api/ApiDeleteGlobalAccount.php
@@ -29,8 +29,8 @@
  * @ingroup Extensions
  */
 class ApiDeleteGlobalAccount extends ApiBase {
-   /* Heavily based on code from SpecialCentralAuth::doSubmit */
public function execute() {
+   // Heavily based on code from SpecialCentralAuth::doSubmit
if ( is_callable( [ $this, 'checkUserRightsAny' ] ) ) {
$this->checkUserRightsAny( 'centralauth-unmerge' );
} else {
@@ -76,9 +76,7 @@
];
}
 
-   /**
-* @see ApiBase::getExamplesMessages()
-*/
+   /** @inheritDoc */
protected function getExamplesMessages() {
return [

'action=deleteglobalaccount=Example=Because+I+can'
diff --git a/includes/api/ApiGlobalUserRights.php 
b/includes/api/ApiGlobalUserRights.php
index 3e418d3..e0b10ae 100644
--- a/includes/api/ApiGlobalUserRights.php
+++ b/includes/api/ApiGlobalUserRights.php
@@ -34,9 +34,7 @@
return CentralAuthUser::availableGlobalGroups();
}
 
-   /**
-* @see ApiBase::getExamplesMessages()
-*/
+   /** @inheritDoc */
protected function getExamplesMessages() {
return [

'action=userrights=FooBot=bot=sysop|bureaucrat=123ABC'
diff --git a/includes/api/ApiQueryGlobalAllUsers.php 
b/includes/api/ApiQueryGlobalAllUsers.php
index 

[MediaWiki-commits] [Gerrit] mediawiki...VectorV2[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402632 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ib7d2baf09f52b269fa3f7e5ca54400db63a9e0dc
---
M .phpcs.xml
M SkinVectorV2.php
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/VectorV2 
refs/changes/32/402632/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 13d4d33..ea18ce1 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   



diff --git a/SkinVectorV2.php b/SkinVectorV2.php
index 0b06a9d..3ec3ad2 100644
--- a/SkinVectorV2.php
+++ b/SkinVectorV2.php
@@ -68,6 +68,7 @@
 
/**
 * Override to pass our Config instance to it
+* @inheritDoc
 */
public function setupTemplate( $classname, $repository = false, 
$cache_dir = false ) {
return new $classname( $this->vectorv2Config );

-- 
To view, visit https://gerrit.wikimedia.org/r/402632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7d2baf09f52b269fa3f7e5ca54400db63a9e0dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/VectorV2
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402631 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
---
M .phpcs.xml
M SkinMetrolook.php
M SkinMetrolookHooks.php
3 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Metrolook 
refs/changes/31/402631/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d57c719..3ba9483 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   

.

diff --git a/SkinMetrolook.php b/SkinMetrolook.php
index 961deff..89ff179 100644
--- a/SkinMetrolook.php
+++ b/SkinMetrolook.php
@@ -118,6 +118,7 @@
 
/**
 * Override to pass our Config instance to it
+* @inheritDoc
 */
public function setupTemplate( $classname, $repository = false, 
$cache_dir = false ) {
return new $classname( $this->metrolookConfig );
diff --git a/SkinMetrolookHooks.php b/SkinMetrolookHooks.php
index 2eae141..d462273 100644
--- a/SkinMetrolookHooks.php
+++ b/SkinMetrolookHooks.php
@@ -72,6 +72,7 @@
 *
 * @param OutputPage $out
 * @param Skin $skin
+* @return true
 */
public static function beforePageDisplay( $out, $skin ) {
if ( $skin instanceof SkinMetrolook ) {
@@ -92,6 +93,7 @@
 *
 * @param User current user $user
 * @param array list of default user preference controls 
&$defaultPreferences
+* @return true
 */
public static function getPreferences( $user, &$defaultPreferences ) {
global $wgMetrolookFeatures;
@@ -113,6 +115,8 @@
 * ResourceLoaderGetConfigVars hook
 *
 * Adds enabled/disabled switches for Vector modules
+* @param array &$vars
+* @return true
 */
public static function resourceLoaderGetConfigVars( &$vars ) {
global $wgMetrolookFeatures, $wgMetrolookSearchBar;

-- 
To view, visit https://gerrit.wikimedia.org/r/402631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve some parameter docs

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402630 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I31e983d7ac287158101b18ad95779d83537302a2
---
M includes/Feed.php
M includes/Preferences.php
M includes/Revision.php
M includes/Storage/RevisionStore.php
M includes/Xml.php
M includes/collation/IcuCollation.php
M includes/libs/objectcache/WANObjectCache.php
M includes/preferences/DefaultPreferencesFactory.php
M includes/resourceloader/ResourceLoader.php
M includes/shell/Result.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/watcheditem/WatchedItemStore.php
M includes/widget/ComplexNamespaceInputWidget.php
M includes/widget/ComplexTitleInputWidget.php
M includes/widget/DateInputWidget.php
M includes/widget/DateTimeInputWidget.php
M includes/widget/NamespaceInputWidget.php
M includes/widget/SearchInputWidget.php
M includes/widget/SelectWithInputWidget.php
M includes/widget/TitleInputWidget.php
M includes/widget/UsersMultiselectWidget.php
21 files changed, 143 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/30/402630/1

diff --git a/includes/Feed.php b/includes/Feed.php
index 0e715df..92eec08 100644
--- a/includes/Feed.php
+++ b/includes/Feed.php
@@ -153,6 +153,7 @@
/**
 * Get the description of this item without any escaping
 *
+* @return string
 */
public function getDescriptionUnescaped() {
return $this->description;
diff --git a/includes/Preferences.php b/includes/Preferences.php
index 0a41573..37de2a5 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -315,6 +315,7 @@
/**
 * @param array $formData
 * @param PreferencesForm $form
+* @return Status
 */
public static function tryUISubmit( $formData, $form ) {
$preferencesFactory = self::getDefaultPreferencesFactory();
diff --git a/includes/Revision.php b/includes/Revision.php
index 54c6de0..b1440d0 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -65,7 +65,7 @@
}
 
/**
-* @param bool|string $wikiId The ID of the target wiki database. Use 
false for the local wiki.
+* @param bool|string $wiki The ID of the target wiki database. Use 
false for the local wiki.
 *
 * @return SqlBlobStore
 */
diff --git a/includes/Storage/RevisionStore.php 
b/includes/Storage/RevisionStore.php
index 2e953fc..0950109 100644
--- a/includes/Storage/RevisionStore.php
+++ b/includes/Storage/RevisionStore.php
@@ -562,6 +562,7 @@
/**
 * MCR migration note: this replaces Revision::isUnpatrolled
 *
+* @param RevisionRecord $rev
 * @return int Rcid of the unpatrolled row, zero if there isn't one
 */
public function isUnpatrolled( RevisionRecord $rev ) {
diff --git a/includes/Xml.php b/includes/Xml.php
index 0091513..b20f66e 100644
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -532,8 +532,8 @@
 *
 * @param string $list Correctly formatted text (newline delimited) to 
be
 *   used to generate the options.
-* @param array $params Extra parameters
-* @param string $params['other'] If set, add an option with this as 
text and a value of 'other'
+* @param array $params Extra parameters:
+*   - string $params['other'] If set, add an option with this as text 
and a value of 'other'
 * @return array Array keys are textual labels, values are internal 
values
 */
public static function listDropDownOptions( $list, $params = [] ) {
diff --git a/includes/collation/IcuCollation.php 
b/includes/collation/IcuCollation.php
index 23f02de..36efdb3 100644
--- a/includes/collation/IcuCollation.php
+++ b/includes/collation/IcuCollation.php
@@ -492,7 +492,6 @@
}
 
/**
-* @param string $index
 * @return string
 * @since 1.16.3
 */
diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index 562819e..409f507 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -214,6 +214,9 @@
$this->asyncHandler = isset( $params['asyncHandler'] ) ? 
$params['asyncHandler'] : null;
}
 
+   /**
+* @param LoggerInterface $logger
+*/
public function setLogger( LoggerInterface $logger ) {
$this->logger = $logger;
}
@@ -1238,7 +1241,7 @@
 * @param string $key
 * @param bool $versioned
 * @param float $minTime
-* @param mixed $asOf
+* @param mixed &$asOf
 * @return mixed
 */
protected function getInterimValue( $key, $versioned, $minTime, &$asOf 
) {
diff --git 

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Fix SpaceyParenthesisSniff comment detection for ignore stat...

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402605 )

Change subject: Fix SpaceyParenthesisSniff comment detection for ignore 
statements
..

Fix SpaceyParenthesisSniff comment detection for ignore statements

When changed all the @codingStandardsIgnore in
I92ef235849bcc349c69e53504e664a155dd162c8 I have to move some of them in
tests provider to different line due to this bug. I assumed it in
upstream and therefore not looking in it deeper.
But I found it a problem in our own sniff, so fixing it.

Change-Id: Ia99b628001de7c522db27ca1da706806157fad45
---
M MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
M MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php
M MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php.fixed
3 files changed, 49 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/05/402605/1

diff --git a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php 
b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
index ce1a704..9e84d58 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
@@ -56,6 +56,19 @@
}
 
/**
+* @param int $token PHPCS token code.
+* @return boolean Whether the token code is a comment.
+*/
+   private function isComment( $token ) {
+   return $token === T_COMMENT
+   || $token === T_PHPCS_ENABLE
+   || $token === T_PHPCS_DISABLE
+   || $token === T_PHPCS_SET
+   || $token === T_PHPCS_IGNORE
+   || $token === T_PHPCS_IGNORE_FILE;
+   }
+
+   /**
 * @param File $phpcsFile File object.
 * @param int $stackPtr The current token index.
 * @return void
@@ -163,7 +176,7 @@
if ( $this->isOpen( $previousToken['code'] )
|| ( $previousToken['code'] === T_WHITESPACE
&& $previousToken['content'] === ' ' )
-   || ( $previousToken['code'] === T_COMMENT
+   || ( $this->isComment( $previousToken['code'] )
&& substr( $previousToken['content'], -1, 1 ) 
=== "\n" ) ) {
// If previous token was
// '(' or ' ' or a comment ending with a newline
@@ -180,7 +193,7 @@
}
 
// If the comment before all the whitespaces immediately 
preceding the ')' ends with a newline
-   if ( $tokens[$ptr]['code'] === T_COMMENT
+   if ( $this->isComment( $tokens[$ptr]['code'] )
&& substr( $tokens[$ptr]['content'], -1, 1 ) === "\n" ) 
{
return;
}
diff --git a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php 
b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php
index 0ebe73c..d5ba3c3 100644
--- a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php
+++ b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php
@@ -30,4 +30,21 @@
// 'foo' => 'baz',
];
(int)$arg->bar();
+
+   $fooArray = [
+   // phpcs:disable Generic.Files.LineLength
+   [
+   'Some',
+   'Parameter',
+   'For',
+   'Testprovider',
+   ],
+   [
+   'Some very',
+   
'nng
 Parameter',
+   'For',
+   'Testprovider',
+   ],
+   // phpcs:enable
+   ];
 }
diff --git a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php.fixed 
b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php.fixed
index 84fd45b..8272978 100644
--- a/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php.fixed
+++ b/MediaWiki/Tests/files/WhiteSpace/spacey_parenthesis.php.fixed
@@ -30,4 +30,21 @@
// 'foo' => 'baz',
];
(int)$arg->bar();
+
+   $fooArray = [
+   // phpcs:disable Generic.Files.LineLength
+   [
+   'Some',
+   'Parameter',
+   'For',
+   'Testprovider',
+   ],
+   [
+   'Some very',
+   
'nng
 Parameter',
+   'For',
+   'Testprovider',
+   ],
+   // phpcs:enable
+   ];
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/402605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Skip __construct on checking for @return tags

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402603 )

Change subject: Skip __construct on checking for @return tags
..

Skip __construct on checking for @return tags

PHP allows constructor to return objects, but it seems not useful to
have a @return for it.

Bug: T177323
Change-Id: I53fff4cc0c2fe736c0ee419450e728ae93fda444
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
M MediaWiki/Tests/files/Commenting/commenting_function.php
M MediaWiki/Tests/files/Commenting/commenting_function.php.expect
M MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
4 files changed, 36 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/03/402603/1

diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php 
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index e04f395..40cd69b 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -189,6 +189,12 @@
if ( !isset( $tokens[$stackPtr]['scope_opener'] ) ) {
return;
}
+
+   // Skip constructors
+   if ( $phpcsFile->getDeclarationName( $stackPtr ) === 
'__construct' ) {
+   return;
+   }
+
$endFunction = $tokens[$stackPtr]['scope_closer'];
$found = false;
for ( $i = $stackPtr + 1; $i < $endFunction; $i++ ) {
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php 
b/MediaWiki/Tests/files/Commenting/commenting_function.php
index f06a9e0..ae5a2d0 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php
@@ -249,3 +249,17 @@
$this->info = 'no documentation because obvious';
}
 }
+
+class TestReturnConstructor {
+   /**
+* With return.
+* @param int $a for test.
+* @param int $b for another test.
+*/
+   public function __construct( $a, $b ) {
+   if ( $b instanceof TestPassedExamples ) {
+   return $b;
+   }
+   $this->test( $a );
+   }
+}
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect 
b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
index b7552aa..95b563e 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
@@ -179,4 +179,6 @@
  |   | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
  247 | ERROR | [ ] Only one object structure is allowed in a file
  |   | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
+ 253 | ERROR | [ ] Only one object structure is allowed in a file
+ |   | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
 PHPCBF CAN FIX THE 72 MARKED SNIFF VIOLATIONS AUTOMATICALLY
diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php.fixed 
b/MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
index 24669b9..6e47368 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php.fixed
@@ -250,3 +250,17 @@
$this->info = 'no documentation because obvious';
}
 }
+
+class TestReturnConstructor {
+   /**
+* With return.
+* @param int $a for test.
+* @param int $b for another test.
+*/
+   public function __construct( $a, $b ) {
+   if ( $b instanceof TestPassedExamples ) {
+   return $b;
+   }
+   $this->test( $a );
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/402603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53fff4cc0c2fe736c0ee419450e728ae93fda444
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Expand sniff to replace some php aliases with main function

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402581 )

Change subject: Expand sniff to replace some php aliases with main function
..

Expand sniff to replace some php aliases with main function

- is_writeable => is_writable
- join => implode
- key_exists => array_key_exists
- pos => current
- sizeof => count

Bug: T183220
Change-Id: I0bc74cd3556f1cae513f1bc28cefae16c39a43a5
---
M MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/81/402581/1

diff --git a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php 
b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
index d607ea8..048a688 100644
--- a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
+++ b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
@@ -32,6 +32,11 @@
 */
private $functions = [
'is_integer' => 'is_int',
+   'is_writeable' => 'is_writable',
+   'join' => 'implode',
+   'key_exists' => 'array_key_exists',
+   'pos' => 'current',
+   'sizeof' => 'count',
'extract' => false,
// Deprecated in PHP 7.2
'create_function' => false,

-- 
To view, visit https://gerrit.wikimedia.org/r/402581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bc74cd3556f1cae513f1bc28cefae16c39a43a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Fix Undefined index: scope_opener in IfElseStructureSniff

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402418 )

Change subject: Fix Undefined index: scope_opener in IfElseStructureSniff
..

Fix Undefined index: scope_opener in IfElseStructureSniff

Bug: T183828
Change-Id: I17aa4604735b44a4fedd5d0261f8918d0b2e6ab2
---
M MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/18/402418/1

diff --git a/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php 
b/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
index 4a593f3..fa19043 100644
--- a/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
+++ b/MediaWiki/Sniffs/ControlStructures/IfElseStructureSniff.php
@@ -32,8 +32,11 @@
$tokens = $phpcsFile->getTokens();
$prevToken = $tokens[$stackPtr - 1];
$nextToken = $tokens[$stackPtr + 1];
-   $scopeOpener = $tokens[$stackPtr]['scope_opener'];
-   $isAlternativeIfSyntax = $tokens[$scopeOpener]['code'] === 
T_COLON;
+   $isAlternativeIfSyntax = false;
+   if ( isset( $tokens[$stackPtr]['scope_opener'] ) ) {
+   $scopeOpener = $tokens[$stackPtr]['scope_opener'];
+   $isAlternativeIfSyntax = $tokens[$scopeOpener]['code'] 
=== T_COLON;
+   }
 
// single space expected before else and elseif structure
if ( !$isAlternativeIfSyntax &&

-- 
To view, visit https://gerrit.wikimedia.org/r/402418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I17aa4604735b44a4fedd5d0261f8918d0b2e6ab2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Archive mediawiki/extensions/DataTypes

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402412 )

Change subject: Archive mediawiki/extensions/DataTypes
..

Archive mediawiki/extensions/DataTypes

See Ia52d81ed62b38c73fb202d787936398e7fbb0205

Change-Id: I5321aa042c811bb7971c9e52ec4a62954aeae050
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/12/402412/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index be396fd..d2ef2a3 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -4717,8 +4717,7 @@
 
   - name: mediawiki/extensions/DataTypes
 template:
-  - name: extension-unittests-generic
-  - name: extension-qunit-generic
+  - name: archived
 
   - name: mediawiki/extensions/DeleteOwn
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/402412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5321aa042c811bb7971c9e52ec4a62954aeae050
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultiLanguageManager[master]: Add apihelp-mlm-tasks-summary message

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402410 )

Change subject: Add apihelp-mlm-tasks-summary message
..

Add apihelp-mlm-tasks-summary message

Also change name of other messages to include the whole module name,
which is the default message name
This should fix the unit tests

Change-Id: Ic0b178fb4698057dda32213a5b1d9a97e0929f47
---
M i18n/en.json
M i18n/qqq.json
M src/Api/Tasks.php
3 files changed, 8 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultiLanguageManager 
refs/changes/10/402410/1

diff --git a/i18n/en.json b/i18n/en.json
index 26546bd..1126dfc 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -23,7 +23,8 @@
"mlm-input-label-delete": "Delete",
"mlm-input-label-cancel": "Cancel",
"mlm-contentaction-label": "Manage translations",
-   "apihelp-mlm-param-task": "The task that should be executed",
-   "apihelp-mlm-param-taskdata": "JSON string encoded object with 
arbitrary data for the task",
-   "apihelp-mlm-param-format": "The format of the result"
+   "apihelp-mlm-tasks-summary": "Manage translation tasks",
+   "apihelp-mlm-tasks-param-task": "The task that should be executed",
+   "apihelp-mlm-tasks-param-taskdata": "JSON string encoded object with 
arbitrary data for the task",
+   "apihelp-mlm-tasks-param-format": "The format of the result"
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index a46b41c..486f6bc 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -26,7 +26,8 @@
"mlm-input-label-delete": "Label for a delete 
button\n{{Identical|Delete}}",
"mlm-input-label-cancel": "Label for a delete 
button\n{{Identical|Cancel}}",
"mlm-contentaction-label": "Label of a content action link that opens 
Special:MultiLanguageManager",
-   "apihelp-mlm-param-task": "{{doc-apihelp-param|mlm-tasks|task}}",
-   "apihelp-mlm-param-taskdata": 
"{{doc-apihelp-param|mlm-tasks|taskdata}}",
-   "apihelp-mlm-param-format": "{{doc-apihelp-param|mlm-tasks|format}}"
+   "apihelp-mlm-tasks-summary": "{{doc-apihelp-summary|mlm-tasks}}",
+   "apihelp-mlm-tasks-param-task": "{{doc-apihelp-param|mlm-tasks|task}}",
+   "apihelp-mlm-tasks-param-taskdata": 
"{{doc-apihelp-param|mlm-tasks|taskdata}}",
+   "apihelp-mlm-tasks-param-format": 
"{{doc-apihelp-param|mlm-tasks|format}}"
 }
diff --git a/src/Api/Tasks.php b/src/Api/Tasks.php
index b2a9c27..767b923 100644
--- a/src/Api/Tasks.php
+++ b/src/Api/Tasks.php
@@ -277,18 +277,15 @@
'task' => array(
\ApiBase::PARAM_REQUIRED => true,
\ApiBase::PARAM_TYPE => 'string',
-   \ApiBase::PARAM_HELP_MSG => 
'apihelp-mlm-param-task',
),
'taskData' => array(
\ApiBase::PARAM_TYPE => 'string',
\ApiBase::PARAM_REQUIRED => false,
\ApiBase::PARAM_DFLT => '{}',
-   \ApiBase::PARAM_HELP_MSG => 
'apihelp-mlm-param-taskdata',
),
'format' => array(
\ApiBase::PARAM_DFLT => 'json',
\ApiBase::PARAM_TYPE => [ 'json', 'jsonfm' ],
-   \ApiBase::PARAM_HELP_MSG => 
'apihelp-mlm-param-format',
)
];
}

-- 
To view, visit https://gerrit.wikimedia.org/r/402410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0b178fb4698057dda32213a5b1d9a97e0929f47
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultiLanguageManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Remove .gitkeep files in non-empty folders

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402405 )

Change subject: Remove .gitkeep files in non-empty folders
..

Remove .gitkeep files in non-empty folders

.gitkeep files are used to keep empty folders in git,
but the folders here are not empty, so the file are not needed.

Change-Id: Idc1c1a8792ae91671b42bb8eec7cfcfb8598cbcb
---
D includes/.gitkeep
D resources/.gitkeep
2 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/05/402405/1

diff --git a/includes/.gitkeep b/includes/.gitkeep
deleted file mode 100644
index e69de29..000
--- a/includes/.gitkeep
+++ /dev/null
diff --git a/resources/.gitkeep b/resources/.gitkeep
deleted file mode 100644
index e69de29..000
--- a/resources/.gitkeep
+++ /dev/null

-- 
To view, visit https://gerrit.wikimedia.org/r/402405
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc1c1a8792ae91671b42bb8eec7cfcfb8598cbcb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PluggableAuth[master]: Use tabs in .phpcs.xml

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402403 )

Change subject: Use tabs in .phpcs.xml
..

Use tabs in .phpcs.xml

Use dot for file to scan also the root for php files

Change-Id: Iee8a93f6aa1f15ccadcd351bdcfb477bc277ca88
---
M .phpcs.xml
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PluggableAuth 
refs/changes/03/402403/1

diff --git a/.phpcs.xml b/.phpcs.xml
index f148e13..7cdd517 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,7 +1,7 @@
 
 
-  
-  includes
-  
-  
+   
+   .
+   
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/402403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee8a93f6aa1f15ccadcd351bdcfb477bc277ca88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PluggableAuth
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Change global function to closure in usort

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402402 )

Change subject: Change global function to closure in usort
..

Change global function to closure in usort

Change-Id: Ib9f08a60ad3a34524c94b535a11e7247458b9fed
---
M .phpcs.xml
M CollectionProposals.php
2 files changed, 13 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/02/402402/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 2e20643..3f98d46 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -16,11 +16,6 @@

*/templates/*\.php

-   
-   
-   
-   
-   
.


diff --git a/CollectionProposals.php b/CollectionProposals.php
index 42d7d77..177a285 100644
--- a/CollectionProposals.php
+++ b/CollectionProposals.php
@@ -333,7 +333,19 @@
}
}
}
-   usort( $prop, "wgCollectionCompareProps" );
+   usort(
+   $prop,
+   function ( $a, $b ) {
+   if ( $a['val'] == $b['val'] ) {
+   return strcmp( $a['name'], $b['name'] );
+   }
+   if ( $a['val'] < $b['val'] ) {
+   return 1;
+   } else {
+   return -1;
+   }
+   }
+   );
$this->mPropList = [];
$have_real_weights = false;
foreach ( $prop as $p ) {
@@ -391,30 +403,5 @@
 */
private function getPropCount() {
return count( $this->mPropList );
-   }
-}
-
-/**
- * sort $mPropList by the entries values
- * sort alphabetically by equal values
- *
- * @param array $a array that contain two entries
- *the keys: 'name' & 'val'
- *'name': an articlename
- *'val' : a value from 1 to 1.5
- * @param array $b array that contain two entries
- *the keys: 'name' & 'val'
- *'name': an articlename
- *'val' : a value from 1 to 1.5
- * @return int 1 -1 or 0
- */
-function wgCollectionCompareProps( $a, $b ) {
-   if ( $a['val'] == $b['val'] ) {
-   return strcmp( $a['name'], $b['name'] );
-   }
-   if ( $a['val'] < $b['val'] ) {
-   return 1;
-   } else {
-   return - 1;
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/402402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9f08a60ad3a34524c94b535a11e7247458b9fed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits