D8029: copy: add option to unmark file as copied

Closed by commit rHG8be0c63535b5: copy: add option to unmark file as copied (authored by martinvonz). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8029: copy: add option to unmark file as copied

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in commands.py:2339 > The other command with variable number of arguments I can think of usually > mark them as optional in their synopsis (eg: `hg bookmarks`), but I feel like > the situation in a bit different. > > The new

D8029: copy: add option to unmark file as copied

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in commands.py:2339 > Hmm, do we do that elsewhere? It would seem out of place to me, but if > there's precedent for doing it, I can do it here too. The other command with variable number of arguments I can think of usually

D8029: copy: add option to unmark file as copied

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in commands.py:2339 > What i mean is to put the equivalent of a synopsys line inside the > documentation text at tle location where --forget is defined. Hmm, do we do that elsewhere? It would seem out of place to me, but if

D8029: copy: add option to unmark file as copied

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in commands.py:2339 > > What I find the most confusing part is the piece refering to SOURCE and > > DEST for an > > operation that as no such pair. I would refer to an explicite TARGET > > argument and > > include some kind of

D8029: copy: add option to unmark file as copied

martinvonz updated this revision to Diff 20204. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=20199=20204 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL

D8029: copy: add option to unmark file as copied

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in commands.py:2339 > doing `hg cp a b` does not add copies information to `a`, so I don't think > there would be confusion from the users. > > What I find the most confusing part is the piece refering to `SOURCE` and > `DEST`

D8029: copy: add option to unmark file as copied

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in commands.py:2339 > If you first do `hg cp a b`, you can't then do `hg cp --forget a`, it needs > to be the destination. The "SOURCE" and "DEST" names refer to the names in > the synopsis. I was trying to clarify that that

D8029: copy: add option to unmark file as copied

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in cmdutil.py:1413 > Why are these two incompatible ? I can imagine running `--forget` with > `--dryrun` Just not implemented yet. Are you asking just out of curiosity or do you think it needs to be clarified to the user? >

D8029: copy: add option to unmark file as copied

This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. The UI seems good, but it seems like we should have `--dry-run` supports and I find the help text confusing (I made improvement suggestion). INLINE COMMENTS >

D8029: copy: add option to unmark file as copied

martinvonz updated this revision to Diff 20199. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=20174=20199 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL

D8029: copy: add option to unmark file as copied

martinvonz added a comment. In D8029#120701 , @pulkit wrote: > The commit message has a mention of `uncopy` which needs to be removed. Good catch. Done. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D8029: copy: add option to unmark file as copied

pulkit added a comment. The commit message has a mention of `uncopy` which needs to be removed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8029 To: martinvonz, #hg-reviewers, durin42,

D8029: copy: add option to unmark file as copied

martinvonz updated this revision to Diff 20174. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=20148=20174 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL

D8029: copy: add option to unmark file as copied

durin42 added a comment. durin42 accepted this revision. LGTM, would like @marmoute to chime in. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8029 To: martinvonz, #hg-reviewers, durin42,

D8029: copy: add option to unmark file as copied

martinvonz updated this revision to Diff 20148. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=20081=20148 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL

D8029: copy: add option to unmark file as copied

martinvonz updated this revision to Diff 20081. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=20068=20081 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL

D8029: copy: add option to unmark file as copied

martinvonz added a comment. In D8029#119818 , @martinvonz wrote: > In D8029#119813 , @marmoute wrote: > >> I am still not convinced by the command name. >> >> In D8029#118464

D8029: copy: add option to unmark file as copied

martinvonz edited the summary of this revision. martinvonz retitled this revision from "uncopy: add new `hg uncopy` command" to "copy: add option to unmark file as copied". martinvonz updated this revision to Diff 20068. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE