Re: [Mesa-dev] [PATCH 2/2] nir: implement the GLSL equivalent of if simplication in nir_opt_if

2018-05-30 Thread Ian Romanick
On 05/30/2018 06:35 PM, Ian Romanick wrote: > As is, this does a lot of damage on most Intel platforms. The Skylake > results are below. I've looked a couple of the worst-hit shaders, and I > may have a couple small fixes. I'm also going to try the patch tarceri > sent out earlier. I'll look

Re: [Mesa-dev] [PATCH] nir: optimize iand(ieq(a, 0), ieq(b, 0)) to ieq(ior(a, b), 0)

2018-05-30 Thread Timothy Arceri
On 31/05/18 10:44, Ian Romanick wrote: On 05/30/2018 01:48 AM, Samuel Pitoiset wrote: Totals from affected shaders: SGPRS: 80 -> 80 (0.00 %) VGPRS: 48 -> 48 (0.00 %) Code Size: 2120 -> 2096 (-1.13 %) bytes Max Waves: 16 -> 16 (0.00 %) Only two Rise of Tomb Raider shaders are affected on my

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Timothy Arceri
On 31/05/18 11:33, Ian Romanick wrote: "less than" whoops ... luckly I removed that bit from the description before pushing This regression is with "nir: implement the GLSL equivalent of if simplication in nir_opt_if"? I'll check to see if this helps the issues that I'm seeing with that

Re: [Mesa-dev] [PATCH 2/2] nir: implement the GLSL equivalent of if simplication in nir_opt_if

2018-05-30 Thread Ian Romanick
As is, this does a lot of damage on most Intel platforms. The Skylake results are below. I've looked a couple of the worst-hit shaders, and I may have a couple small fixes. I'm also going to try the patch tarceri sent out earlier. total instructions in shared programs: 14371511 -> 14373672

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
On 2018-05-30 17:35:11, wrote: > On Wed, May 30, 2018 at 7:53 PM, Jordan Justen > wrote: > > On 2018-05-30 14:14:18, Laura Ekstrand wrote: > >> The current plan is that this first patch series should just update the > >> website. Then we can swap out the theme easily with one or two commands in

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Ian Romanick
"less than" This regression is with "nir: implement the GLSL equivalent of if simplication in nir_opt_if"? I'll check to see if this helps the issues that I'm seeing with that patch... On 05/30/2018 04:09 AM, Timothy Arceri wrote: > This avoids loop unrolling regressions in Wolfenstein II on

Re: [Mesa-dev] [PATCH 1/2] nir: make is_comparison() a non-static helper function

2018-05-30 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick I'm currently running the next patch through shader-db. The initial results are... interesting. On 05/30/2018 05:21 AM, Samuel Pitoiset wrote: > Rename and change the prototype for consistency regarding > nir_tex_instr_is_query(). This function will be

[Mesa-dev] [Bug 106748] st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY broke qemu -display sdl, gl=on

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106748 --- Comment #1 from Ilia Mirkin --- That patch had nothing to do with ARB_ES3_compatibility -- if that got nuked, it probably did as well for radeonsi. Probably something silly in the version check logic. -- You are receiving this mail

[Mesa-dev] [Bug 106748] st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY broke qemu -display sdl, gl=on

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106748 Bug ID: 106748 Summary: st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY broke qemu -display sdl,gl=on Product: Mesa Version: git Hardware: x86 (IA32)

Re: [Mesa-dev] [PATCH] nir: optimize iand(ieq(a, 0), ieq(b, 0)) to ieq(ior(a, b), 0)

2018-05-30 Thread Ian Romanick
On 05/30/2018 01:48 AM, Samuel Pitoiset wrote: > Totals from affected shaders: > SGPRS: 80 -> 80 (0.00 %) > VGPRS: 48 -> 48 (0.00 %) > Code Size: 2120 -> 2096 (-1.13 %) bytes > Max Waves: 16 -> 16 (0.00 %) > > Only two Rise of Tomb Raider shaders are affected on my side. I got: total

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Rob Clark
On Wed, May 30, 2018 at 7:53 PM, Jordan Justen wrote: > On 2018-05-30 14:14:18, Laura Ekstrand wrote: >> The current plan is that this first patch series should just update the >> website. Then we can swap out the theme easily with one or two commands in >> the next series. > > If it's easy to

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Jason Ekstrand
On Wed, May 30, 2018 at 5:14 PM, Stuart Young wrote: > On 31 May 2018 at 02:15, Jason Ekstrand wrote: > >> Gitlab divides users into three categories per-project: Guests, >> Developers, and Masters. In general, developers and masters will have push >> access. Masters have the ability to add

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Stuart Young
On 31 May 2018 at 02:15, Jason Ekstrand wrote: > Gitlab divides users into three categories per-project: Guests, > Developers, and Masters. In general, developers and masters will have push > access. Masters have the ability to add developers to the project. > Masters will also have the

Re: [Mesa-dev] [PATCH 1/3] radv: Make the sem_info allocate/free functions static.

2018-05-30 Thread Timothy Arceri
Series is: Reviewed-by: Timothy Arceri On 31/05/18 09:51, Bas Nieuwenhuizen wrote: They are only used in 1 file. --- src/amd/vulkan/radv_device.c | 16 +--- src/amd/vulkan/radv_private.h | 8 2 files changed, 9 insertions(+), 15 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-05-30 Thread Timothy Arceri
On 31/05/18 03:06, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 8 2 files changed, 11 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
On 2018-05-30 14:14:18, Laura Ekstrand wrote: > The current plan is that this first patch series should just update the > website. Then we can swap out the theme easily with one or two commands in > the next series. If it's easy to do, then why not just do it? I don't think the mesa3d.org

[Mesa-dev] [PATCH 3/3] radv: Add startup debug option.

2018-05-30 Thread Bas Nieuwenhuizen
This adds a RADV_DEBUG=startup option to dump more info about instance creation and device enumeration. A common question end users have is why the direver is not loading for them, and this has two common reasons: 1) They did not install the driver. 2) AMDGPU is not used for the card in the

[Mesa-dev] [PATCH 2/3] radv: Add option to print errors even in optimized builds.

2018-05-30 Thread Bas Nieuwenhuizen
Errors are not that common of a case so we can eat a slight perf hit in having to call a function and do a runtime check. In turn this makes debugging random errors happening for end users easier, because they don't have to have a debug build on hand. --- src/amd/vulkan/radv_android.c|

[Mesa-dev] [PATCH 1/3] radv: Make the sem_info allocate/free functions static.

2018-05-30 Thread Bas Nieuwenhuizen
They are only used in 1 file. --- src/amd/vulkan/radv_device.c | 16 +--- src/amd/vulkan/radv_private.h | 8 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 93b6e611067..9709e73a4fe 100644 ---

[Mesa-dev] [Bug 106594] [regression, apitrace, bisected] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106594 Timothy Arceri changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |mathias.froehl...@web.de

[Mesa-dev] [PATCH v3 33/53] intel/fs: Emit LINE+MAC for LINTERP with unaligned coordinates

2018-05-30 Thread Jason Ekstrand
On g4x through Sandy Bridge, src1 (the coordinates) of the PLN instruction is required to be an even register number. When it's odd (which can happen with SIMD32), we have to emit a LINE+MAC combination instead. Unfortunately, we can't just fall through to the gen4 case because the input

Re: [Mesa-dev] [PATCH 3/3] i965/miptree: Stop retiling miptrees

2018-05-30 Thread Nanley Chery
On Wed, May 30, 2018 at 10:57:05PM +0100, Chris Wilson wrote: > Quoting Nanley Chery (2018-05-30 21:44:35) > > We previously retiled miptrees to work around limitations of the BLT > > engine. BLORP fallbacks can overcome these, so we no longer have need > > for retiling. > > > > Removing retiling

Re: [Mesa-dev] [PATCH 1/8] nir: Add lowering for bitfieldInsert without using bfi.

2018-05-30 Thread Eric Anholt
Eric Anholt writes: > If you don't have HW to do bfi, then lowering bitfieldInsert to bfi makes > things harder than keeping the "bits" argument around. > > This still uses bfm, but I've added the obvious lowering of bfm if you > need it. Anyone? Even just an ack, assuming that I'm passing the

Re: [Mesa-dev] [PATCH v2 33/53] intel/fs: Emit LINE+MAC for LINTERP with unaligned coordinates

2018-05-30 Thread Francisco Jerez
Jason Ekstrand writes: > On g4x through Sandy Bridge, src1 (the coordinates) of the PLN > instruction is required to be an even register number. When it's odd > (which can happen with SIMD32), we have to emit a LINE+MAC combination > instead. Unfortunately, we can't just fall through to the

[Mesa-dev] [PATCH v2 15/15] docs: Human edits to the website code for clarity.

2018-05-30 Thread Laura Ekstrand
There's a lot here. If you're interested, it's mostly whitespace fixes, switching variable names and function names to the Sphinx orange variable highlight style, and naming code blocks to take advantage of Pygments syntax highlighting. --- docs/application-issues.rst | 8 +- docs/autoconf.rst

[Mesa-dev] [PATCH v2 12/15] docs: Edits to fix toctrees.

2018-05-30 Thread Laura Ekstrand
ReStructured Text toctrees are used to automatically generate the sidebar. But all top-level headings get added to it by default. In order to workaround this, you must create one and only one top-level heading for each page. --- docs/download.rst | 2 +- docs/faq.rst | 2 +-

[Mesa-dev] [PATCH v2 11/15] docs: Toctree for systems.rst as in jhertel docs.

2018-05-30 Thread Laura Ekstrand
Toctree directives create automatically generated navigation sidebars. This is the new deprecated systems sidebar. --- docs/systems.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/systems.rst b/docs/systems.rst index 707abeeed9..b05aff0621 100644 --- a/docs/systems.rst +++

[Mesa-dev] [PATCH v2 14/15] docs: Major manual edits to environment vars.

2018-05-30 Thread Laura Ekstrand
This is a huge page. The edits I've done here take full advantage of reStructured text and Sphinx's awesome built-in style for explaining commands and variables. Enjoy! --- docs/envvars.rst | 604 ++- 1 file changed, 425 insertions(+), 179

[Mesa-dev] [PATCH v2 09/15] docs: Add a navigation sidebar.

2018-05-30 Thread Laura Ekstrand
From: Jean Hertel This is the new main sidebar. --- docs/index.rst | 90 ++ 1 file changed, 90 insertions(+) diff --git a/docs/index.rst b/docs/index.rst index dbb4a4ddec..1894b46a4b 100644 --- a/docs/index.rst +++ b/docs/index.rst @@

[Mesa-dev] [PATCH v2 04/15] docs: Result of script fixing html with Beautiful Soup.

2018-05-30 Thread Laura Ekstrand
Beautiful Soup patched our html in these ways: - Creating closing tags e.g. where there were none in order to create semantically complete html (like xhtml) - Removing the old header, which is no longer needed - Removing the old content bar to avoid confusion - Removing the outer from the

[Mesa-dev] [PATCH v2 05/15] docs: Rename html to rst

2018-05-30 Thread Laura Ekstrand
This should tell git that the files are really the same. That way, we don't lose the file history. --- docs/{application-issues.html => application-issues.rst} | 0 docs/{autoconf.html => autoconf.rst} | 0 docs/{bugs.html => bugs.rst} | 0

[Mesa-dev] [PATCH v2 13/15] docs: Fix Sphinx compile errors.

2018-05-30 Thread Laura Ekstrand
This just involves some quick fixes to formatting of the affected pages. --- docs/autoconf.rst| 1 + docs/dispatch.rst| 72 ++-- docs/egl.rst | 2 ++ docs/releasing.rst | 14 +- docs/relnotes/17.0.5.rst | 2

[Mesa-dev] [PATCH v2 06/15] docs: Add results of script - pandoc-generated rst pages.

2018-05-30 Thread Laura Ekstrand
--- docs/application-issues.rst | 90 +- docs/autoconf.rst | 406 ++- docs/bugs.rst | 75 +- docs/codingstyle.rst| 244 +- docs/conform.rst| 1343 +- docs/debugging.rst | 66 +- docs/developers.rst | 63 +-

[Mesa-dev] [PATCH v2 07/15] docs: Add Sphinx configuration file.

2018-05-30 Thread Laura Ekstrand
From: Jean Hertel This tells Sphinx how to build our website from reStructured Text. Signed-off-by: Jean Hertel --- docs/conf.py | 162 +++ 1 file changed, 162 insertions(+) create mode 100644 docs/conf.py diff --git a/docs/conf.py

[Mesa-dev] [PATCH v2 02/15] docs: Add python script that converts html to rst.

2018-05-30 Thread Laura Ekstrand
Use Beautiful Soup to fix bad html, then use pandoc for converting to rst. --- docs/rstConverter.py | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 docs/rstConverter.py diff --git a/docs/rstConverter.py b/docs/rstConverter.py new file mode 100755 index

[Mesa-dev] [PATCH v2 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Laura Ekstrand
v2: - Preserve git file history by forcing a rename - Squash Sphinx compiler fixes to conf.py and relnotes.rst into original configuration and toctree commits, respectively. - Rebase to include 18.1.0 and 18.2.0 releases. Some of these commits are large. I recommend going to view

[Mesa-dev] [PATCH v2 03/15] docs: Remove contents.html and old mesa.css file.

2018-05-30 Thread Laura Ekstrand
The old navigation bar, may it rest in peace, causes major problems when running the rstConverter.py script. It and the css file are also unneeded. Let's get rid of them now. --- docs/contents.html | 108 - docs/mesa.css | 63

[Mesa-dev] [PATCH v2 08/15] docs: Add command for Sphinx build.

2018-05-30 Thread Laura Ekstrand
This does two things. 1. It pulls a Docker image which is a Linux system with Sphinx and the Read the Docs Sphinx theme already installed. 2. It uses sphinx-build to build html from our rst pages. --- .gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 10/15] docs: Add toctree to relnotes

2018-05-30 Thread Laura Ekstrand
From: Jean Hertel Toctree directives create automatically generated navigation sidebars. This is the new relnotes sidebar. --- docs/relnotes.rst | 210 ++ 1 file changed, 210 insertions(+) diff --git a/docs/relnotes.rst b/docs/relnotes.rst

[Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-05-30 Thread Laura Ekstrand
For now, all this does is copy our current webpage into a public folder. Daniel Stone has the server configured to check this public folder and host the index.html as mesa-test.freedesktop.org. When this patch series is approved, Daniel will change it to point at mesa-3d.org. --- .gitlab-ci.yml |

Re: [Mesa-dev] [PATCH v3] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

2018-05-30 Thread Eric Anholt
Tomeu Vizoso writes: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This commit adds cases to handle specific formats so that the values > reported by the two calls match more closely

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 almos changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

2018-05-30 Thread Eric Anholt
"Juan A. Suarez Romero" writes: > Implement ir_binop_vector_extract using NIR operations. Based on SPIR-V > to NIR approach. > > This fixes: > dEQP-GLES3.functional.shaders.indexing.moredynamic.with_value_from_indexing_expression_fragment > Piglit's glsl-fs-vec4-indexing-8.shader_test > >

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Daniel Stone
Hey, On 30 May 2018 at 21:40, Ilia Mirkin wrote: > Given that not everyone will be a master by default, it would be good > to also set out criteria for adding and removing masters. I'm not > proposing anything heavy -- perhaps by a majority vote of the existing > masters to either add or remove

[Mesa-dev] [Bug 106594] [regression, apitrace, bisected] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106594 Kai changed: What|Removed |Added Summary|[radeonsi,regression,apitra |[regression,apitrace,bisect

Re: [Mesa-dev] [PATCH 3/3] i965/miptree: Stop retiling miptrees

2018-05-30 Thread Chris Wilson
Quoting Nanley Chery (2018-05-30 21:44:35) > We previously retiled miptrees to work around limitations of the BLT > engine. BLORP fallbacks can overcome these, so we no longer have need > for retiling. > > Removing retiling fixes a number of problems. If the row pitch was too > wide for the BLT

[Mesa-dev] [Bug 106594] [radeonsi, regression, apitrace] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106594 Kai changed: What|Removed |Added CC||bri...@vmware.com, |

[Mesa-dev] [Bug 106594] [radeonsi, regression, apitrace] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106594 --- Comment #7 from Kai --- Created attachment 139872 --> https://bugs.freedesktop.org/attachment.cgi?id=139872=edit git bisect log -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 2/3] i965/miptree: Allow blit maps with large row pitches

2018-05-30 Thread Nanley Chery
The BLORP fallback can handle large row pitches. A patch is on the piglit mailing list to modify the test, piglit.spec.!opengl 1_1.getteximage-simple, to hit this case. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff

[Mesa-dev] [PATCH 3/3] i965/miptree: Stop retiling miptrees

2018-05-30 Thread Nanley Chery
We previously retiled miptrees to work around limitations of the BLT engine. BLORP fallbacks can overcome these, so we no longer have need for retiling. Removing retiling fixes a number of problems. If the row pitch was too wide for the BLT engine, we retiled to linear and had the following

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Ilia Mirkin
On Wed, May 30, 2018 at 12:15 PM, Jason Ekstrand wrote: > All, > > As part of the move to GitLab, we have a few decisions to make regarding > users and groups. > > Question 1: Who should be masters? > > Gitlab divides users into three categories per-project: Guests, Developers, > and Masters. In

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Jason Ekstrand
On Wed, May 30, 2018 at 1:40 PM, Ilia Mirkin wrote: > On Wed, May 30, 2018 at 12:15 PM, Jason Ekstrand > wrote: > > All, > > > > As part of the move to GitLab, we have a few decisions to make regarding > > users and groups. > > > > Question 1: Who should be masters? > > > > Gitlab divides users

[Mesa-dev] [PATCH 1/3] i965: Make BLORP a fallback in blit maps

2018-05-30 Thread Nanley Chery
We're going to enable blit maps on row pitches greater than the BLT engine's limit. Make blit maps fall back to BLORP which can handle such pitches. --- src/mesa/drivers/dri/i965/intel_blit.c| 6 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 24 +-- 2 files

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)

2018-05-30 Thread Marek Olšák
Juan, Dylan, Yes, the patch is not needed in stable. Thanks, Marek On Wed, May 30, 2018 at 12:01 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-05-28 18:10:42) > > From: Marek Olšák > > > > Bindless texture handles can be passed via vertex attribs using this > type. > > They use the

Re: [Mesa-dev] Gitlab migration

2018-05-30 Thread Eric Anholt
Jason Ekstrand writes: > Mesa developers, > > tl;dr. Please go to gitlab.freedesktop.org, create your account, and > upload your SSH keys. Instructions are the bottom of this e-mail. > > The freedesktop.org admins are trying to move as many projects and services > as possible over to gitlab

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Fix crash on shaders using MSAA image load/store

2018-05-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Note that radeonsi doesn't support MSAA images. Marek On Wed, May 30, 2018 at 4:48 AM, Alex Smith wrote: > The value returned by tgsi_util_get_texture_coord_dim() does not > account for the sample index. This means image_fetch_coords() will not > fetch it, leading to

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-05-30 Thread Bas Nieuwenhuizen
On Wed, May 30, 2018 at 7:06 PM, Samuel Pitoiset wrote: > Similar for max(). > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/nir/nir.h| 3 +++ > src/compiler/nir/nir_opt_algebraic.py | 8 > 2 files changed, 11 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] v3d: Fix automake linking error.

2018-05-30 Thread Eric Anholt
Vinson Lee writes: > CXXLDgallium_dri.la > ../../../../src/broadcom/.libs/libbroadcom.a(clif_dump.o): In function > `clif_dump_packet': > src/broadcom/clif/clif_dump.c:87: undefined reference to > `v3d33_clif_dump_packet' > src/broadcom/clif/clif_dump.c:85: undefined reference to >

Re: [Mesa-dev] [PATCH] Revert "st/nir: use NIR for asm programs"

2018-05-30 Thread Eric Anholt
Timothy Arceri writes: > On 22/05/18 04:15, Eric Anholt wrote: >> Timothy Arceri writes: >> >>> On 18/05/18 00:53, Eric Anholt wrote: This reverts commit 5c33e8c7729edd5e16020ebb8703be96523e04f2. It broke fixed function vertex programs on vc4 and v3d, and apparently caused

[Mesa-dev] [PATCH 2/2] radv: enable lowering of minmax3

2018-05-30 Thread Samuel Pitoiset
Polaris10: Totals from affected shaders: SGPRS: 95672 -> 95808 (0.14 %) VGPRS: 91224 -> 90840 (-0.42 %) Spilled SGPRs: 3754 -> 3734 (-0.53 %) Code Size: 7384156 -> 7372872 (-0.15 %) bytes Max Waves: 7408 -> 7433 (0.34 %) Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 + 1

[Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-05-30 Thread Samuel Pitoiset
Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 8 2 files changed, 11 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f6086bd6c0..04991b7d04 100644 ---

[Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Jason Ekstrand
All, As part of the move to GitLab, we have a few decisions to make regarding users and groups. Question 1: Who should be masters? Gitlab divides users into three categories per-project: Guests, Developers, and Masters. In general, developers and masters will have push access. Masters have the

Re: [Mesa-dev] [PATCH 1/2] mesa: handle GL_UNSIGNED_INT64_ARB properly (v2)

2018-05-30 Thread Marek Olšák
On Wed, May 30, 2018, 4:14 AM Juan A. Suarez Romero wrote: > On Mon, 2018-05-28 at 21:10 -0400, Marek Olšák wrote: > > From: Marek Olšák > > > > Bindless texture handles can be passed via vertex attribs using this > type. > > This fixes a bunch of bindless piglit tests on radeonsi. > > > > Cc:

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)

2018-05-30 Thread Dylan Baker
Quoting Marek Olšák (2018-05-28 18:10:42) > From: Marek Olšák > > Bindless texture handles can be passed via vertex attribs using this type. > They use the double codepath, so don't use st_pipe_vertex_format. > > Cc: 18.0 18.1 > --- > src/mesa/state_tracker/st_atom_array.c | 3 ++- > 1 file

[Mesa-dev] [Bug 106472] Some applications randomly stuck under xorg server 1.20 (and rc's) for example steam client

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106472 --- Comment #3 from mikhail.v.gavri...@gmail.com --- Which mesa version was applied this patch? I am curious because mesa 18.1.0 which shipped in Fedora 29 (Rawhide) not contain this patch. And I need every time after mesa upgrade in

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 Nicolai Hähnle changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|REOPENED

[Mesa-dev] [PATCH v5] nv50/ir, nvc0: add debug options for shader replacement

2018-05-30 Thread Rhys Perry
Changes in v5: - Add a forgotten change to fix memory leaks of fname Changes in v4: - Move code to nv50_ir_dump.cpp - Dump headers of nvc0 programs - Use CRC-32 instead of a truncated SHA1 - Set prog->maxGPR to targ->getFileSize() - 1 and set prog->tlsSize - Don't compile the program if a

Re: [Mesa-dev] [PATCH 00/53] intel/fs: SIMD32 support for fragment shaders

2018-05-30 Thread Jason Ekstrand
On May 30, 2018 06:45:29 Eero Tamminen wrote: Hi, On 29.05.2018 18:58, Eero Tamminen wrote: On 25.05.2018 00:55, Jason Ekstrand wrote: This patch series adds back-end compiler support for SIMD32 fragment shaders. Support is added and everything works but it's currently hidden behind

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

2018-05-30 Thread Kyle Brenneman
On 05/29/2018 12:04 PM, Adam Jackson wrote: On Tue, 2018-05-29 at 09:54 -0700, Dylan Baker wrote: Quoting Adam Jackson (2018-05-29 06:50:46) GL_LIB expands to GLX_mesa, but applications should not link against that. -lGL is never wrong, just hardcode it. Actually There is this really

[Mesa-dev] [Bug 106401] swr driver failing mesa build on 32 bit

2018-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106401 --- Comment #1 from Gert Wollny --- I've proposed a patch on mesa-dev: https://patchwork.freedesktop.org/series/43820/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 2/2] nir: implement the GLSL equivalent of if simplication in nir_opt_if

2018-05-30 Thread Samuel Pitoiset
This pass turns: if (cond) { } else { do_work(); } into: if (!cond) { do_work(); } else { } Here's the vkpipeline-db stats (from affected shaders) on Polaris10: Totals from affected shaders: SGPRS: 17272 -> 17296 (0.14 %) VGPRS: 18712 -> 18740 (0.15 %) Spilled

[Mesa-dev] [PATCH 1/2] nir: make is_comparison() a non-static helper function

2018-05-30 Thread Samuel Pitoiset
Rename and change the prototype for consistency regarding nir_tex_instr_is_query(). This function will be used in the following patch. Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h | 24 +++ src/compiler/nir/nir_opt_move_comparisons.c | 26

Re: [Mesa-dev] [PATCH 00/53] intel/fs: SIMD32 support for fragment shaders

2018-05-30 Thread Eero Tamminen
Hi, On 29.05.2018 18:58, Eero Tamminen wrote: On 25.05.2018 00:55, Jason Ekstrand wrote: This patch series adds back-end compiler support for SIMD32 fragment shaders.  Support is added and everything works but it's currently hidden behind INTEL_DEBUG=do32.  We know that it improves performance

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Bas Nieuwenhuizen
On Wed, May 30, 2018 at 1:09 PM, Timothy Arceri wrote: > This avoids loop unrolling regressions in Wolfenstein II on DXVK > with an upcoming optimisation series from Samuel. > --- > src/compiler/nir/nir_opt_algebraic.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH] radv: Only expose subgroups shuflles on VI+.

2018-05-30 Thread Samuel Pitoiset
On 05/30/2018 01:17 PM, Bas Nieuwenhuizen wrote: On Wed, May 30, 2018 at 1:14 PM, Samuel Pitoiset wrote: why? Because it uses bpermutes, which are VI+ only. Okay. Reviewed-by: Samuel Pitoiset On 05/30/2018 08:52 AM, Bas Nieuwenhuizen wrote: Fixes: f2c6a550611 "radv: enable

Re: [Mesa-dev] [PATCH] radv: Only expose subgroups shuflles on VI+.

2018-05-30 Thread Bas Nieuwenhuizen
On Wed, May 30, 2018 at 1:14 PM, Samuel Pitoiset wrote: > why? Because it uses bpermutes, which are VI+ only. > > > On 05/30/2018 08:52 AM, Bas Nieuwenhuizen wrote: >> >> Fixes: f2c6a550611 "radv: enable subgroup capabilities" >> --- >> src/amd/vulkan/radv_device.c | 7 +-- >> 1 file

Re: [Mesa-dev] [PATCH] radv: Only expose subgroups shuflles on VI+.

2018-05-30 Thread Samuel Pitoiset
why? On 05/30/2018 08:52 AM, Bas Nieuwenhuizen wrote: Fixes: f2c6a550611 "radv: enable subgroup capabilities" --- src/amd/vulkan/radv_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Timothy Arceri
This avoids loop unrolling regressions in Wolfenstein II on DXVK with an upcoming optimisation series from Samuel. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index

Re: [Mesa-dev] [PATCH] radv: fix emitting descriptor pointers with LLVM < 7

2018-05-30 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Add a Fixes tag? On Wed, May 30, 2018 at 11:15 AM, Samuel Pitoiset wrote: > This was terribly wrong, I forced use of 32-bit pointers when > emitting shader descriptor pointers. This fixes GPU hangs with > LLVM 5&6 because 32-bit pointers are only supported with

Re: [Mesa-dev] [PATCH] nir: optimize iand(ieq(a, 0), ieq(b, 0)) to ieq(ior(a, b), 0)

2018-05-30 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, May 30, 2018 at 10:48 AM, Samuel Pitoiset wrote: > Totals from affected shaders: > SGPRS: 80 -> 80 (0.00 %) > VGPRS: 48 -> 48 (0.00 %) > Code Size: 2120 -> 2096 (-1.13 %) bytes > Max Waves: 16 -> 16 (0.00 %) > > Only two Rise of Tomb Raider shaders are

[Mesa-dev] [PATCH] radv: fix emitting descriptor pointers with LLVM < 7

2018-05-30 Thread Samuel Pitoiset
This was terribly wrong, I forced use of 32-bit pointers when emitting shader descriptor pointers. This fixes GPU hangs with LLVM 5&6 because 32-bit pointers are only supported with LLVM 7. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 -- 1 file changed, 4

[Mesa-dev] [PATCH] radeonsi: Fix crash on shaders using MSAA image load/store

2018-05-30 Thread Alex Smith
The value returned by tgsi_util_get_texture_coord_dim() does not account for the sample index. This means image_fetch_coords() will not fetch it, leading to a null deref in ac_build_image_opcode() which expects it to be present (the return value of ac_num_coords() *does* include the sample index).

[Mesa-dev] [PATCH] nir: optimize iand(ieq(a, 0), ieq(b, 0)) to ieq(ior(a, b), 0)

2018-05-30 Thread Samuel Pitoiset
Totals from affected shaders: SGPRS: 80 -> 80 (0.00 %) VGPRS: 48 -> 48 (0.00 %) Code Size: 2120 -> 2096 (-1.13 %) bytes Max Waves: 16 -> 16 (0.00 %) Only two Rise of Tomb Raider shaders are affected on my side. Cc: Ian Romanick Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)

2018-05-30 Thread Juan A. Suarez Romero
On Mon, 2018-05-28 at 21:15 -0400, Ilia Mirkin wrote: > Series is Reviewed-by: Ilia Mirkin > > Thanks for tracking down why this wasn't working cleanly in the first > place. This should make the NV int64 attrib extension much simpler. > > On Mon, May 28, 2018 at 9:10 PM, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCH 1/2] mesa: handle GL_UNSIGNED_INT64_ARB properly (v2)

2018-05-30 Thread Juan A. Suarez Romero
On Mon, 2018-05-28 at 21:10 -0400, Marek Olšák wrote: > From: Marek Olšák > > Bindless texture handles can be passed via vertex attribs using this type. > This fixes a bunch of bindless piglit tests on radeonsi. > > Cc: 18.0 18.1 Hello. This patch didn't apply cleanly on 18.0, so I just

Re: [Mesa-dev] [1/3] tegra: Remove usage of non-stable UAPI

2018-05-30 Thread Daniel Kolesa
On Wed, May 30, 2018, at 09:35, Juan A. Suarez Romero wrote: > On Tue, 2018-05-29 at 16:50 +0200, Thierry Reding wrote: > > On Tue, May 29, 2018 at 12:46:35PM +0200, Daniel Kolesa wrote: > > > Hello, > > > > > > On 2018/04/19 18:31, Thierry Reding wrote: > > > > From: Thierry Reding > > > > > >

Re: [Mesa-dev] [1/3] tegra: Remove usage of non-stable UAPI

2018-05-30 Thread Juan A. Suarez Romero
On Tue, 2018-05-29 at 16:50 +0200, Thierry Reding wrote: > On Tue, May 29, 2018 at 12:46:35PM +0200, Daniel Kolesa wrote: > > Hello, > > > > On 2018/04/19 18:31, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > This code path is no longer required with framebuffer modifier support.

[Mesa-dev] [PATCH] radv: Only expose subgroups shuflles on VI+.

2018-05-30 Thread Bas Nieuwenhuizen
Fixes: f2c6a550611 "radv: enable subgroup capabilities" --- src/amd/vulkan/radv_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 61b4fba23f8..93b6e611067 100644 --- a/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
On 2018-05-24 17:37:09, Laura Ekstrand wrote: > A few of the commits are quite large and awaiting list approval. I suggest > that you take a look at the code here: > https://gitlab.freedesktop.org/ldeks/mesa/tree/website1_75, > and the new website here: