Re: [Mesa-dev] [PATCH 4/6] ddebug: use util_snprintf() in dd_get_debug_filename_and_mkdir

2018-08-01 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 01.08.2018 20:53, Andres Gomez wrote: Instead of plain snprintf(). To fix the MSVC 2013 build: Compiling src\gallium\auxiliary\driver_ddebug\dd_draw.c ... dd_draw.c c:\projects\mesa\src\gallium\auxiliary\driver_ddebug\dd_util.h(60) : warning C4013:

[Mesa-dev] [RFC][PATCH 5/5] i965: add functional changes for AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
Gen >= 9 have ability to control clamping of depth values separately at near and far plane. z_w is clamped to the range [min(n,f), 0] if clamping at near plane is enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f) max(n,f)] if clamping at both plane is enabled.

[Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. Signed-off-by: Sagar Ghuge --- src/mesa/main/attrib.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index

[Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-01 Thread Sagar Ghuge
Add some basic types and storage for the AMD_depth_clamp_separate extension. Signed-off-by: Sagar Ghuge --- include/GL/glcorearb.h | 2 ++ src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 9 + 3 files changed, 12 insertions(+) diff --git

[Mesa-dev] [RFC][PATCH 4/5] mesa: implement glGet for AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
Signed-off-by: Sagar Ghuge --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 5 + 2 files changed, 6 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index db0079beb5..b310f014b7 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@

[Mesa-dev] [RFC][PATCH 2/5] glapi: define AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
Signed-off-by: Sagar Ghuge --- src/mapi/glapi/gen/AMD_depth_clamp_separate.xml | 15 +++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 3 +++ src/mapi/glapi/gen/meson.build | 1 + 4 files changed, 20

[Mesa-dev] [RFC][PATCH 1/5] mesa: add support for GL_AMD_depth_clamp_separate tokens

2018-08-01 Thread Sagar Ghuge
_mesa_set_enable() and _mesa_IsEnabled() extended to accept new two tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD. Signed-off-by: Sagar Ghuge --- src/mesa/main/enable.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-01 Thread Marek Olšák
On Wed, Aug 1, 2018 at 5:02 PM, Dieter Nützel wrote: > Am 01.08.2018 19:53, schrieb Marek Olšák: >> >> On Wed, Aug 1, 2018 at 12:02 PM, Dieter Nützel >> wrote: >>> >>> Am 01.08.2018 17:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel wrote: > >

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 103907, which changed state. Bug 103907 Summary: [gfx9/Vega] Arma 3 crashes on 17.3.0-rc5 but works on master https://bugs.freedesktop.org/show_bug.cgi?id=103907 What|Removed |Added

Re: [Mesa-dev] [PATCH v2] glsl: make a copy of array indices that are used to deref a function out param

2018-08-01 Thread Ian Romanick
On 07/20/2018 10:22 PM, Timothy Arceri wrote: > V2: make use of visit_tree() > > Fixes new piglit test: > tests/spec/glsl-1.20/execution/qualifiers/vs-out-conversion-int-to-float-vec4-index.shader_test Should this get tagged for stable? > --- > src/compiler/glsl/ast_function.cpp | 54

Re: [Mesa-dev] [PATCH v2 3/4] intel/nir: Split IO arrays into elements

2018-08-01 Thread Kenneth Graunke
On Tuesday, July 31, 2018 8:55:05 PM PDT Jason Ekstrand wrote: > On Tue, Jul 31, 2018 at 3:00 PM Jason Ekstrand wrote: > > > On July 31, 2018 14:54:54 Kenneth Graunke wrote: > > > > > On Tuesday, July 31, 2018 12:22:02 PM PDT Jason Ekstrand wrote: > > >> The NIR nir_lower_io_arrays_to_elements

[Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-01 Thread John Stultz
Just as a heads up, with mesa3d master (plus my other build fixups I just sent out), I'm seeing a new build failure when building under AOSP/master: external/mesa3d/src/amd/vulkan/Android.mk: error: vulkan.radv (SHARED_LIBRARIES android-arm64) missing libLLVM (SHARED_LIBRARIES android-arm64) You

Re: [Mesa-dev] [PATCH] nir: add fall through comment to nir_gather_info

2018-08-01 Thread Jason Ekstrand
rb On Wed, Aug 1, 2018 at 5:05 PM Timothy Arceri wrote: > This stops Coverity reporting a defect and helps make the code less > error-prone. > > Cc: Neil Roberts > --- > src/compiler/nir/nir_gather_info.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Mesa-dev] [PATCH] nir: add fall through comment to nir_gather_info

2018-08-01 Thread Timothy Arceri
This stops Coverity reporting a defect and helps make the code less error-prone. Cc: Neil Roberts --- src/compiler/nir/nir_gather_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_gather_info.c b/src/compiler/nir/nir_gather_info.c index d0b656ea741..4a030cb6256

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Marek Olšák
For patches 5 & 6: Reviewed-by: Marek Olšák I can't see patches 3 & 4 on the list. Marek On Wed, Aug 1, 2018 at 6:02 PM, Andres Gomez wrote: > The binary constant notation "0b" is a GCC extension. Instead, we use > hexadecimal notation to fix the MSVC 2013 build: > > Compiling

[Mesa-dev] [PATCH 7/8] st/mesa: add renderbuffer support for AMD_framebuffer_multisample_advanced

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_fbo.c | 61 ++ 1 file changed, 53 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index 811451656ca..0e535257cb4 100644 ---

[Mesa-dev] [PATCH 2/8] glapi: define AMD_framebuffer_multisample_advanced and add its functions

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mapi/glapi/gen/gl_API.xml | 27 +++ src/mesa/main/fbobject.c | 22 ++ src/mesa/main/fbobject.h | 10 ++ 3 files changed, 59 insertions(+) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 3/8] mesa: implement glGet for AMD_framebuffer_multisample_advanced

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/get.c | 8 src/mesa/main/get_hash_params.py | 7 +++ src/mesa/main/mtypes.h | 16 4 files changed, 32 insertions(+) diff --git a/src/mesa/main/extensions_table.h

[Mesa-dev] [PATCH 6/8] st/mesa: pass storage_sample_count parameter into st_choose_format

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_drawpixels.c | 14 ++--- src/mesa/state_tracker/st_cb_fbo.c| 6 +++--- src/mesa/state_tracker/st_cb_texture.c| 2 +- src/mesa/state_tracker/st_format.c| 24 ++-

[Mesa-dev] [PATCH 5/8] mesa: add functional FBO changes for AMD_framebuffer_multisample_advanced

2018-08-01 Thread Marek Olšák
From: Marek Olšák - relax FBO completeness rules - validate sample counts --- src/mesa/main/fbobject.c| 96 ++--- src/mesa/main/multisample.c | 52 2 files changed, 131 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 8/8] st/mesa: expose & set limits for AMD_framebuffer_multisample_advanced

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index dbaf7f6f8fe..1c01495e937 100644 ---

[Mesa-dev] [PATCH 4/8] mesa: add gl_renderbuffer::NumStorageSamples

2018-08-01 Thread Marek Olšák
From: Marek Olšák --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 ++ src/mesa/main/fbobject.c | 25 + src/mesa/main/mtypes.h| 1 + src/mesa/state_tracker/st_cb_fbo.c| 4 +++- 4 files changed, 23 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 0/8] GL_AMD_framebuffer_multisample_advanced for RadeonSI

2018-08-01 Thread Marek Olšák
Hi, This implements GL_AMD_framebuffer_multisample_advanced, which is AMD EQAA. I have also sent out a piglit test that tests the new API. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 1/8] mesa: add storageSamples parameter to renderbuffer functions

2018-08-01 Thread Marek Olšák
From: Marek Olšák It's just passed to other functions but otherwise unused. It will be used in following commits. --- src/mesa/drivers/common/meta.c | 2 +- src/mesa/main/fbobject.c | 41 +- src/mesa/main/fbobject.h | 3 ++-

[Mesa-dev] [PATCH 3/3 v3] CleanSpec.mk: Remove HOST_OUT_release

2018-08-01 Thread John Stultz
From: Dan Willemsen This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd633f11de0c6ac1ed333a28344c74fd9898df9e%5E%21/ Which replaces HOST_OUT_release with HOST_OUT As per Dan's explanation, the current code was incorrect to

[Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-01 Thread John Stultz
From: Sumit Semwal This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ Since https://android-review.googlesource.com/c/718518 added timespec_get() to bionic, mesa3d doesn't build

[Mesa-dev] [PATCH 1/3 v3] util: Android.mk: Convert implicit rules to static pattern rules

2018-08-01 Thread John Stultz
From: Dan Willemsen This is a partial cherry-pick from AOSP's mesa3d tree: https://android.googlesource.com/platform/external/mesa3d/+/a88dcf769eb00a4ffc7183a0396d881a28b5a29b%5E%21/ "We're deprecating make implicit rules, preferring static pattern rules, or just regular rules." Without this

[Mesa-dev] [PATCH] st/mesa: Don't set atomic counter size != 0 with atomic buffers == 0.

2018-08-01 Thread Eric Anholt
This is just asking for tests to get confused about the HW supporting atomics in this shader stage or not, such as dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.const_expression_vertex. --- src/mesa/state_tracker/st_extensions.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

2018-08-01 Thread Dylan Baker
I pushed a patch earlier that *should* make mkdir and getpid work with msvc Dylan Quoting Andres Gomez (2018-08-01 11:53:04) > Opt-out the code using mkdir() and getpid() which are spitting > warnings in the MSVC build: > > Compiling src\gallium\auxiliary\driver_ddebug\dd_draw.c ... >

[Mesa-dev] [Bug 107439] mesa defines likely/unlikely and these are C++20 keywords

2018-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107439 Casey Carter changed: What|Removed |Added CC||ca...@carter.net --- Comment #2 from

[Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
The binary constant notation "0b" is a GCC extension. Instead, we use hexadecimal notation to fix the MSVC 2013 build: Compiling src\mesa\main\texcompress_astc.cpp ... texcompress_astc.cpp src\mesa\main\texcompress_astc.cpp(111) : error C2059: syntax error : 'bad suffix on number' ...

Re: [Mesa-dev] [PATCH 1/2] scons: require scons 2.4 or greater

2018-08-01 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 19:48 +0200, Juan A. Suarez Romero wrote: > There is a bug with scons 2.3, used in Travis, where it fails to detect > some C functions. > --- > SConstruct | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/SConstruct

Re: [Mesa-dev] [PATCH 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
On Wed, 2018-08-01 at 16:43 -0400, Ilia Mirkin wrote: > On Wed, Aug 1, 2018 at 2:53 PM, Andres Gomez wrote: > > The binary constant notation "0b" is a GCC extension. Instead, we use > > hexadecimal notation to fix the MSVC 2013 build: > > > > Compiling src\mesa\main\texcompress_astc.cpp ... > >

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-08-01 Thread Kenneth Graunke
On Wednesday, July 25, 2018 5:12:20 PM PDT Jordan Justen wrote: > During code review, Jason pointed out that: > > 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" > > Didn't account for INTEL_SCALER_* environment variables. > > To fix this, let the compiler return the

[Mesa-dev] [PATCH 2/2] imx: make use of loader_open_name(..)

2018-08-01 Thread Christian Gmeiner
Gets rid of hard-coded gpu device path. Signed-off-by: Christian Gmeiner --- src/gallium/winsys/imx/drm/imx_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/imx/drm/imx_drm_winsys.c b/src/gallium/winsys/imx/drm/imx_drm_winsys.c index

[Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-01 Thread Christian Gmeiner
Add an improved drmOpenWithType(..) clone which fixes some serious flaws. Some highlights: - using busid works only with PCI devices - open() w/o O_CLOEXEC - when build w/o udev - it creates a node: mkdir, chown(root), chmod, mknod - calls back into Xserver/DDX module - last but no least -

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-01 Thread Dieter Nützel
Am 01.08.2018 19:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 12:02 PM, Dieter Nützel wrote: Am 01.08.2018 17:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel wrote: Am 01.08.2018 05:56, schrieb Timothy Arceri: On 01/08/18 13:09, Dieter Nützel wrote: Am

[Mesa-dev] [PATCH 1/2] scons: require scons 2.4 or greater

2018-08-01 Thread Juan A. Suarez Romero
There is a bug with scons 2.3, used in Travis, where it fails to detect some C functions. --- SConstruct | 6 ++ 1 file changed, 6 insertions(+) diff --git a/SConstruct b/SConstruct index a59a8ea210e..6e034fb968f 100644 --- a/SConstruct +++ b/SConstruct @@ -27,6 +27,12 @@ import SCons.Util

Re: [Mesa-dev] [PATCH 2/2] travis: install scons from pip

2018-08-01 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 19:48 +0200, Juan A. Suarez Romero wrote: > The ubuntu version provided by Travis is a bit old, and does not detect > correctly some C functions. > > Use a more modern version through scons. > --- > .travis.yml | 8 +--- > 1 file

[Mesa-dev] [PATCH 1/1] swr: Remove unnecessary memset call

2018-08-01 Thread Vlad Golovkin
Zeroing memory after calloc is not necessary. This also allows to avoid possible crash when allocation fails, because memset is called before checking screen for NULL. --- src/gallium/drivers/swr/swr_screen.cpp | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] vc4: Fix automake linking error.

2018-08-01 Thread Juan A. Suarez Romero
On Wed, 2018-08-01 at 18:03 +0300, Andres Gomez wrote: > This looks good but, unfortunately, it seems to be breaking Travis > build for the scons targets: > https://travis-ci.org/Igalia/mesa/jobs/410431266 > > Please, Eric, could you try to see a way of solving this. I'm stuck not > being able

[Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

2018-08-01 Thread Andres Gomez
Opt-out the code using mkdir() and getpid() which are spitting warnings in the MSVC build: Compiling src\gallium\auxiliary\driver_ddebug\dd_draw.c ... dd_draw.c c:\projects\mesa\src\gallium\auxiliary\driver_ddebug\dd_util.h(62): warning C4013: 'mkdir' undefined; assuming extern returning int

[Mesa-dev] [PATCH 0/6] fix the windows build with MSVC 2013

2018-08-01 Thread Andres Gomez
Just a small series of patches to fix the scons windows build with MSVC 2013. Detected while running with AppVeyor. Andres Gomez (6): glsl: use util_snprintf() gallium/aux/util: use util_snprintf() in test_texture_barrier kutil/queue: use util_snprintf() in util_queue_init ddebug: use

Re: [Mesa-dev] [PATCH 1/6] glsl: use util_snprintf()

2018-08-01 Thread Brian Paul
Series looks good. Thanks for doing this. Reviewed-by: Brian Paul On 08/01/2018 12:53 PM, Andres Gomez wrote: Instead of plain snprintf(). To fix the MSVC 2013 build. Fixes: 6ff0c6f4ebc ("gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times") Cc: Marek Olšák Cc:

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-08-01 Thread Marek Olšák
On Mon, Jul 23, 2018 at 11:33 PM, Timothy Arceri wrote: > On 24/07/18 11:15, Marek Olšák wrote: >> >> On Fri, Jul 20, 2018 at 12:53 AM, Dave Airlie wrote: >>> >>> On 20 July 2018 at 13:12, Marek Olšák wrote: From: Marek Olšák To make

[Mesa-dev] [PATCH 2/2] travis: install scons from pip

2018-08-01 Thread Juan A. Suarez Romero
The ubuntu version provided by Travis is a bit old, and does not detect correctly some C functions. Use a more modern version through scons. --- .travis.yml | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8b1730bec69..b0ddbe226cd 100644

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

2018-08-01 Thread Denis Pauk
Hi Bruce, Thank you. Best wishes to Alok. Could someone also update docs/features.txt with bptc/astc support? Look like we can mark bptc as done for all gallium software renders and astc_ldr for all gallium drivers. Best regards, Denis. On Wed, Aug 1, 2018, 6:14 PM Cherniak,

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-01 Thread Marek Olšák
On Wed, Aug 1, 2018 at 12:02 PM, Dieter Nützel wrote: > Am 01.08.2018 17:53, schrieb Marek Olšák: >> >> On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel >> wrote: >>> >>> Am 01.08.2018 05:56, schrieb Timothy Arceri: On 01/08/18 13:09, Dieter Nützel wrote: > > > Am

[Mesa-dev] [PATCH 1/1] swr: Remove unnecessary memset call

2018-08-01 Thread Vlad Golovkin
Zeroing memory after calloc is not necessary. This also allows to avoid possible crash when allocation fails, because memset is called before checking screen for NULL. --- src/gallium/drivers/swr/swr_screen.cpp | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/6] glsl: use util_snprintf()

2018-08-01 Thread Andres Gomez
Instead of plain snprintf(). To fix the MSVC 2013 build. Fixes: 6ff0c6f4ebc ("gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Signed-off-by: Andres Gomez --- .../glsl/ir_builder_print_visitor.cpp |

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-08-01 Thread Dave Airlie
Sounds like a major project for someone to fix llvm, doesn't AMD have compiled devs? Acked-by: Dave Airlie Dave. On Thu., 2 Aug. 2018, 04:43 Marek Olšák, wrote: > On Mon, Jul 23, 2018 at 11:33 PM, Timothy Arceri > wrote: > > On 24/07/18 11:15, Marek Olšák wrote: > >> > >> On Fri, Jul 20,

[Mesa-dev] [PATCH 2/6] gallium/aux/util: use util_snprintf() in test_texture_barrier

2018-08-01 Thread Andres Gomez
Instead of plain snprintf(). To fix the MSVC 2013 build: Compiling src\gallium\auxiliary\util\u_tests.c ... u_tests.c src\gallium\auxiliary\util\u_tests.c(624) : warning C4013: 'snprintf' undefined; assuming extern returning int ... gallium.lib(u_tests.obj) : error LNK2019: unresolved

[Mesa-dev] [PATCH 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
The binary constant notation "0b" is a GCC extension. Instead, we use hexadecimal notation to fix the MSVC 2013 build: Compiling src\mesa\main\texcompress_astc.cpp ... texcompress_astc.cpp src\mesa\main\texcompress_astc.cpp(111) : error C2059: syntax error : 'bad suffix on number' ...

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-01 Thread Dieter Nützel
Am 01.08.2018 17:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel wrote: Am 01.08.2018 05:56, schrieb Timothy Arceri: On 01/08/18 13:09, Dieter Nützel wrote: Am 31.07.2018 13:34, schrieb Timothy Arceri: On 31/07/18 13:50, Dieter Nützel wrote: Am 30.07.2018 05:24,

Re: [Mesa-dev] [PATCH] nir: Add a couple of iand/ior optimizations

2018-08-01 Thread Ian Romanick
On 07/23/2018 07:10 AM, Jason Ekstrand wrote: > On Mon, Jul 23, 2018 at 1:08 AM Timothy Arceri > wrote: > > Ian and I have been looking at these type of things recently. Ian has > started work on a pass to cover this stuff without having to add dozens >

Re: [Mesa-dev] [PATCH 1/2] mesa: add switch case for GL 2.1 in _mesa_compute_version()

2018-08-01 Thread Ian Romanick
On 07/27/2018 12:07 PM, Brian Paul wrote: > The xlib/swrast driver only supports GL 2.1. This patch fixes a > crash if the app calls glGetString(GL_SHADING_LANGUAGE_VERSION). > --- > src/mesa/main/version.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/version.c

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-08-01 Thread Marek Olšák
On Wed, Aug 1, 2018 at 3:20 PM, Dave Airlie wrote: > Sounds like a major project for someone to fix llvm, doesn't AMD have > compiled devs? Yes, but they are from entirely different teams. Marek > > Acked-by: Dave Airlie > > Dave. > > On Thu., 2 Aug. 2018, 04:43 Marek Olšák, wrote: >> >> On

[Mesa-dev] [PATCH 0/1] swr: Remove unnecessary memset call

2018-08-01 Thread Vlad Golovkin
This patch is identical to the previous one, but that time I forgot to mention that I didn't have commit rights, so I am sending the rebased patch for the review. Vlad Golovkin (1): swr: Remove unnecessary memset call src/gallium/drivers/swr/swr_screen.cpp | 1 - 1 file changed, 1 deletion(-)

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

2018-08-01 Thread Cherniak, Bruce
On Aug 1, 2018, at 8:10 AM, Denis Pauk mailto:pauk.de...@gmail.com>> wrote: Hi Marek, Could you merge this changes to master? Or someone else with push rights? Do mesa have some formal rule what amount of commits/contribution required for recieve "merge" rights? Hi Denis, We will push this

Re: [Mesa-dev] [PATCH] vc4: Fix automake linking error.

2018-08-01 Thread Andres Gomez
This looks good but, unfortunately, it seems to be breaking Travis build for the scons targets: https://travis-ci.org/Igalia/mesa/jobs/410431266 Please, Eric, could you try to see a way of solving this. I'm stuck not being able to create the 18.2 branch because of this build regression. On Tue,

[Mesa-dev] [PATCH] glx: Add checks for context being direct before calling GetGLXDRIDrawable

2018-08-01 Thread Danylo Piliaiev
If indirect context is explicitly created by application and not with LIBGL_ALWAYS_INDIRECT=1 then dri may be initialized in __glXInitialize which allows Mesa to take invalid code paths due to GetGLXDRIDrawable returning non-null value. In most such places there are already checks for context

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-08-01 Thread Robert Foss
Hey Rob, On 2018-07-18 15:30, Rob Herring wrote: On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote: This series implements kms_swrast support for the Android platform. And since having to debug a null pointer dereference, simplify that process for the next guy. So is this working for you

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #9 from Alex Smith --- (In reply to Timothy Arceri from comment #8) > Hmm ... I'm seeing the same issue on a i965 skylake machine that should > never have exposed compatibility profile support. Unfortunately the bug there is that

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

2018-08-01 Thread Denis Pauk
Hi Marek, Could you merge this changes to master? Or someone else with push rights? Do mesa have some formal rule what amount of commits/contribution required for recieve "merge" rights? On Sat, Jul 28, 2018 at 11:03 PM Denis Pauk wrote: > Hi Bruce, > > Thank you, could you please merge

Re: [Mesa-dev] loader_dri3: Handle mismatched depth 30 formats for Prime renderoffload.

2018-08-01 Thread Eric Engestrom
On Thursday, 2018-06-14 06:04:24 +0200, Mario Kleiner wrote: > Detect if the display (X-Server) gpu and Prime renderoffload gpu prefer > different channel ordering for color depth 30 formats ([X/A]BGR2101010 > vs. [X/A]RGB2101010) and perform format conversion during the blitImage() > detiling op

Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-08-01 Thread Emil Velikov
On 31 July 2018 at 14:35, Michel Dänzer wrote: > On 2018-07-31 10:03 AM, Yu, Qiang wrote: >> >> Seems the mesa driconf infrastructure is just what I need: >> https://dri.freedesktop.org/wiki/ConfigurationInfrastructure/ >> >> So I can reference the loader_get_dri_config_device_id implementation

[Mesa-dev] [PATCH 0/2] support config for third-party DRI driver load

2018-08-01 Thread Qiang Yu
This patch series is discussed in thread: https://lists.freedesktop.org/archives/mesa-dev/2018-July/201348.html amdgpu-pro driver can use drirc config to override the mesa radeonsi dri driver so that it can use the mesa libgbm instead of maintain a customized one. We also expand drirc config

[Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-01 Thread Qiang Yu
Add two places for hosting drirc config files: /usr/share/drirc.d/ /etc/drirc.d/ Driver and application can put their drirc files in these places with name xxx.conf. Config files will be read and applied in file name alphabete order. So there are four places for drirc listed in order: 1.

[Mesa-dev] [PATCH 2/2] loader: add dri_driver drirc option to override dri driver to load

2018-08-01 Thread Qiang Yu
drirc implementation of MESA_LOADER_DRIVER_OVERRIDE which can be used to override dri driver to load. Usage: override dri driver for device with spec kernel driver name: Signed-off-by: Qiang Yu --- src/loader/loader.c | 75 ++--

[Mesa-dev] [Bug 107439] mesa defines likely/unlikely and these are C++20 keywords

2018-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107439 --- Comment #1 from Gustaw Smolarczyk --- Are these really reserved keywords? I thought the attribute namespace was different from the keyword namespace. These are not listed as keywords, even for C++20:

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-01 Thread Dieter Nützel
Am 01.08.2018 05:56, schrieb Timothy Arceri: On 01/08/18 13:09, Dieter Nützel wrote: Am 31.07.2018 13:34, schrieb Timothy Arceri: On 31/07/18 13:50, Dieter Nützel wrote: Am 30.07.2018 05:24, schrieb Dieter Nützel: For the series Tested-by: Dieter Nützel with glmark2, glxgears, UH, UV,