Re: [Mesa-dev] [v4 PATCH 3/6] spirv_extensions: add list of extensions and to_string method

On 11/03/18 18:08, Dylan Baker wrote: > Quoting Alejandro Piñeiro (2018-03-08 07:00:16) >> Ideally this should be generated somehow. One option would be gather >> all the extension dependencies listed on the core grammar, but there >> would be the possibility of not including some of the

[Mesa-dev] [PATCH] cmake: Warn that MSVC is unmaintained.

It has been broken for a while, and not much interest from our side in keeping it going, as most of us are using MinGW cross-compilers anyway. I'm not sure if there are other people interested on MSVC, so just warn for the time being. Also tone down the MSVC warnings, so they don't overwhelm the

[Mesa-dev] [PATCH] gallium: Use struct gl_array_attributes* as st_pipe_vertex_format argument.

From: Mathias Fröhlich Hi Brian, As requested in the past review, change the argument of st_pipe_vertex_format to something more concise. Please review best Mathias Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_atom.h

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2018-03-12 5:23 GMT+01:00 Dave Airlie : > Did anything ever comes of this series, trying some soft fp64 shaders, > and glsl copy opt is taking 2-3 seconds on the big ones. > > Nearly all spent in hash table insertions. > > Dave. I still have the patches around. I also have a

Re: [Mesa-dev] [RFC PATCH 9/9] ac/nir: do not always preload PS inputs at beginning

On 03/11/2018 04:07 PM, Marek Olšák wrote: On Thu, Mar 8, 2018 at 9:08 AM, Samuel Pitoiset > wrote: RadeonSI does something similar, the VGPRs decrease is a win but not sure if we really want to implement that.

Re: [Mesa-dev] [PATCH] gallium: Use struct gl_array_attributes* as st_pipe_vertex_format argument.

On Monday, 2018-03-12 07:52:49 +0100, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Brian, > > As requested in the past review, change the argument > of st_pipe_vertex_format to something more concise. > > Please review > best > Mathias > > >

[Mesa-dev] [PATCH 1/2] anv/entrypoints: dispatches to VkQueue are device-level

--- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 485c6cfe8d..27f1aa 100644 --- a/src/intel/vulkan/anv_entrypoints_gen.py +++

[Mesa-dev] [PATCH 2/2] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

af5f2322d0c64 addressed this for extension commands, but the spec mandates this behavior also for core API commands. From the Vulkan spec, Table 2. vkGetDeviceProcAddr behavior: device pnamereturn -- (..)

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

On 03/11/2018 04:41 PM, Marek Olšák wrote: On Thu, Mar 8, 2018 at 5:48 PM, Ian Romanick wrote: On 03/08/2018 06:50 AM, Samuel Pitoiset wrote: This pass moves load UBO operations just before their first use, loosely based on nir_opt_move_comparisons. If I'm reading

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Hi Juan, On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> - CI Automation immediately builds/tests the proposed stable branch >>whenever it changes. Release

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Mon, 2018-03-12 at 11:49 +, Daniel Stone wrote: > Hi Juan, > > On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > > > Ilia Mirkin writes: > > > - CI Automation immediately

Re: [Mesa-dev] [PATCH 2/2] gbm: Add support for 10bpp BGR formats

Tested under nouveau-kms with a hacked kmscube to use GBM_FORMAT_ABGR2101010 successfully, and reject GBM_FORMAT_XBGR2101010, GBM_FORMAT_ARGB2101010, and GBM_FORMAT_XRGB2101010 as expected. Reviewed-and-Tested-by: Mario Kleiner On Fri, Mar 9, 2018 at 4:45 AM, Ilia

[Mesa-dev] [PATCH 5/9] ac/nir: change prototype of handle_shader_output_decl()

This allows to remove the ac_nir_context dependency. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 6/9] ac/nir: make handle_shader_output_decl() non-static

Required in order to move all RADV specific code outside of ac/nir. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 20 ++-- src/amd/common/ac_nir_to_llvm.h | 8 2 files changed, 18 insertions(+), 10 deletions(-) diff

[Mesa-dev] [PATCH 7/9] ac/nir: move radeon_llvm_reg_index_soa() to ac_nir_to_llvm.h

Required in order to move all RADV specific code outside of ac/nir. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 - src/amd/common/ac_nir_to_llvm.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

Hi folks, This series follows the previous ones that cleaned up the ac/nir codepath. Now, all the RADV shader code is located in radv_shader.c, this might avoid confusions when the ac/nir tag is used. The last patch is probably too big for the ML, a branch can be found here:

[Mesa-dev] [PATCH 4/9] ac/nir: move unpack_param() to ac_llvm_build.c

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 16 ++ src/amd/common/ac_llvm_build.h | 3 +++ src/amd/common/ac_nir_to_llvm.c | 49 ++--- 3 files changed, 35 insertions(+), 33 deletions(-) diff

[Mesa-dev] [PATCH 1/9] ac/nir: move ac_build_alloca() to ac_llvm_build.c

As well as si_build_alloca_undef() and drop the si prefix. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 33 src/amd/common/ac_llvm_build.h | 5 + src/amd/common/ac_nir_to_llvm.c | 42

[Mesa-dev] [PATCH 2/9] ac/nir: move cast_ptr() to ac_llvm_build.c

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 8 src/amd/common/ac_llvm_build.h | 3 +++ src/amd/common/ac_nir_to_llvm.c | 12 ++-- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

Tested with a hacked weston (to add xbgr2101010 support) under x11 and drm backend (with wl_drm and wl_dmabuf). All colors are displaying correctly, and "glmark2-wayland -d" confirms use of a RGBA 10-10-10-2 config. Also works with DRI_PRIME=1 for renderoffload to a AMD gpu. It did need some more

[Mesa-dev] [PATCH 3/9] ac/nir: move trim_vector to ac_llvm_build.c

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 19 +++ src/amd/common/ac_llvm_build.h | 3 +++ src/amd/common/ac_nir_to_llvm.c | 29 + 3 files changed, 27 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH 8/9] ac/nir: make emit_barrier() non-static

Required in order to move all RADV specific code outside of ac/nir. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 src/amd/common/ac_nir_to_llvm.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > Ilia Mirkin writes: > > > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov > > wrote: > > > So while others explore ways of improving the testing, let me propose > > > a few ideas for improving

[Mesa-dev] Vulkan version of shader_runner

Hi, I’ve made a start on a Vulkan version of Piglit’s shader_runner. I mostly just wanted it as a quick way to compare problems on Vulkan and GL_ARB_gl_spirv but maybe one day it could become part of a Vulkan testing suite. I just thought I’d announce it here in case anyone else finds it useful

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

Andres Gomez writes: > Hi, > > * Release schedule: move from pre-announce Wed, announcement Fri [0] >to pre-announce Mon, announcement Wed. This seems like an improvement to me. > * Why would we want to do this? >* We have delays in the release every now and

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

On 12 March 2018 at 14:35, Andres Gomez wrote: > Hi, > > * Release schedule: move from pre-announce Wed, announcement Fri [0] >to pre-announce Mon, announcement Wed. > * Why would we want to do this? >* We have delays in the release every now and then. When

[Mesa-dev] [PATCH v3] i965/miptree: Use cpu tiling/detiling when mapping

Rename the (un)map_gtt functions to (un)map_map (map by returning a map) and add new functions (un)map_tiled_memcpy that return a shadow buffer populated with the intel_tiled_memcpy functions. Tiling/detiling with the cpu will be the only way to handle Yf/Ys tiling, when support is added for

[Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

This is a revival of some old patches I had around to improve the compile times in the glsl compiler by reducing the time spend inserting items in the hash table in opt_copy_propagation. I've only rebased this, as my system don't even want to compile anything right now. I also don't remember if it

[Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index b7421a0144..f8d5d0f88a 100644 ---

[Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Walking the whole hash table, inserting entries by hashing them first is just a really bad idea. We can simply memcpy the whole thing. --- src/compiler/glsl/opt_copy_propagation.cpp | 13 -- .../glsl/opt_copy_propagation_elements.cpp | 29 -- 2 files

Re: [Mesa-dev] Few issues with Meson

Hi Dylan Do you have the link to patch on patchwork? I'll give it a go I'm using meson 0.45 however the cross-file requires more than just defining llvm-config, everything else is normally picked up from what portage is setting in the build environment - though strangely not if clang is used -

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

This is good, though some older distros only have libxcb 1.11. Marek On Sun, Mar 11, 2018 at 7:26 PM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer

Re: [Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

I've also uploaded this series to my github, if you wan to pull them down from there [1]. I've also uploaded my previously talked about pointer_map to my github account [2]. There's a pointer map, pointer set, and some patches for nir in there, and some for disabling asserts in some places. So

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

Hi Andres, On 12 March 2018 at 15:57, Andres Gomez wrote: > On Mon, 2018-03-12 at 16:45 +0100, Juan A. Suarez Romero wrote: >> > >> On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: > > [...] > I'm fully on board with your initial suggestion. >> > My proposal would be,

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-12 07:33:27) > > We're trying to be -Wundef clean so that we can turn it on (and > > eventually make it an error). > > > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > > of

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On 12 March 2018 at 17:45, Lepton Wu wrote: > Ping. Any more comments or missing stuff to get this commited into master? > As things have changed a bit (the original map/unmap behaviour is preserved) I was hoping that Tomasz will give it another look. If he prefers, I could

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On 03/12/2018 02:24 PM, Bas Nieuwenhuizen wrote: Hi Samuel, Can we put the code into a separate file, instead of into radv_shader.c? If you want yes, what filename? Also some stuff can be moved out of ac_nir_to_llvm.h I guess? (AFAIU radeonsi does not use all the shader key & info

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Thanks Mark for bringing this thread to my attention by Ccing me ☺ I'll try to be brief and just comment inline. On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > Ilia Mirkin writes: > > > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov > >

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Hi Juan, On 12 March 2018 at 12:10, Juan A. Suarez Romero wrote: > On Mon, 2018-03-12 at 11:49 +, Daniel Stone wrote: >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > We are improving this by moving to use Gitlab CI (still wip), which

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On Mon, Mar 12, 2018 at 2:50 PM, Samuel Pitoiset wrote: > > > On 03/12/2018 02:48 PM, Bas Nieuwenhuizen wrote: >> >> On Mon, Mar 12, 2018 at 2:48 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 03/12/2018 02:24 PM, Bas Nieuwenhuizen wrote:

Re: [Mesa-dev] [PATCH] cmake: Warn that MSVC is unmaintained.

For others just glancing at this, this pertains to the Mesa Demos repo, not Mesa. Reviewed-by: Brian Paul On 03/12/2018 03:19 AM, Jose Fonseca wrote: It has been broken for a while, and not much interest from our side in keeping it going, as most of us are using MinGW

Re: [Mesa-dev] [PATCH] gallium: Use struct gl_array_attributes* as st_pipe_vertex_format argument.

Reviewed-by: Brian Paul On 03/12/2018 12:52 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, As requested in the past review, change the argument of st_pipe_vertex_format to something more concise. Please review best Mathias

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On Mon, Mar 12, 2018 at 2:48 PM, Samuel Pitoiset wrote: > > > On 03/12/2018 02:24 PM, Bas Nieuwenhuizen wrote: >> >> Hi Samuel, >> >> Can we put the code into a separate file, instead of into radv_shader.c? > > > If you want yes, what filename? radv_nir_to_llvm.c ? Or

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On 03/12/2018 03:18 PM, Bas Nieuwenhuizen wrote: On Mon, Mar 12, 2018 at 2:50 PM, Samuel Pitoiset wrote: On 03/12/2018 02:48 PM, Bas Nieuwenhuizen wrote: On Mon, Mar 12, 2018 at 2:48 PM, Samuel Pitoiset wrote: On 03/12/2018 02:24

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

"Juan A. Suarez Romero" writes: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> >> > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov >> > wrote: >> > > So while others explore ways of improving

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

Hi, * Release schedule: move from pre-announce Wed, announcement Fri [0] to pre-announce Mon, announcement Wed. * Why would we want to do this? * We have delays in the release every now and then. When this happens, we step already into the weekend which is bad for the

Re: [Mesa-dev] [PATCH 2/2] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

On Mon, Mar 12, 2018 at 1:40 AM, Iago Toral Quiroga wrote: > af5f2322d0c64 addressed this for extension commands, but the spec mandates > this behavior also for core API commands. From the Vulkan spec, > Table 2. vkGetDeviceProcAddr behavior: > > device pname

[Mesa-dev] [Bug 105444] Enable GL disk shader cache when transform feedback is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=105444 Eero Tamminen changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On 03/12/2018 02:48 PM, Bas Nieuwenhuizen wrote: On Mon, Mar 12, 2018 at 2:48 PM, Samuel Pitoiset wrote: On 03/12/2018 02:24 PM, Bas Nieuwenhuizen wrote: Hi Samuel, Can we put the code into a separate file, instead of into radv_shader.c? If you want yes,

[Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

We're trying to be -Wundef clean so that we can turn it on (and eventually make it an error). Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead of #ifdef; I could've changed these, but the point of -Wundef is to catch typos, so we might as well make the change the right

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

On 03/12/2018 03:25 PM, Samuel Pitoiset wrote: On 03/12/2018 03:18 PM, Bas Nieuwenhuizen wrote: On Mon, Mar 12, 2018 at 2:50 PM, Samuel Pitoiset wrote: On 03/12/2018 02:48 PM, Bas Nieuwenhuizen wrote: On Mon, Mar 12, 2018 at 2:48 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

Thanks, 1-8 are Reviewed-by: Bas Nieuwenhuizen Patch 9 is Acked-by: Bas Nieuwenhuizen On Mon, Mar 12, 2018 at 3:52 PM, Samuel Pitoiset wrote: > > > On 03/12/2018 03:25 PM, Samuel Pitoiset wrote: >> >> >> >> On

Re: [Mesa-dev] [PATCH 0/9] move all RADV related shader code outside of ac/nir

Hi Samuel, Can we put the code into a separate file, instead of into radv_shader.c? Also some stuff can be moved out of ac_nir_to_llvm.h I guess? (AFAIU radeonsi does not use all the shader key & info structs there?) - Bas On Mon, Mar 12, 2018 at 12:56 PM, Samuel Pitoiset

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #14 from Samuel Pitoiset --- The shoot issue has been fixed with "* 99cdc019bf - ac: make use of if/loop build helpers (5 days ago)". Note that it's a side-effect, there is still an issue with the

Re: [Mesa-dev] [RFC] Mesa release improvements - Release calendar

Hi, * Release calendar policy: so far, we are setting the calendar [0] ad- hoc and it may be better to have a clear policy to deal with delays, etc. * If any stable release could be delayed due to high load, rise the hand as soon as possible so other person in the release

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Thanks for opening this thread Emil. I will open new branches for other topics that have been boiling in our minds for a while. I hope you, Emil, can forgive us for not having been more diligent with those, as you are already aware of some of them ...  On Tue, 2018-03-06 at 19:34 +, Emil

Re: [Mesa-dev] [PATCH 1/2] anv/entrypoints: dispatches to VkQueue are device-level

You need to also add support for VkQueue for trampoline functions. On Mon, Mar 12, 2018 at 1:40 AM, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/anv_entrypoints_gen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Hi Thomas, If I were you I'd split out the introduction of clone_acp() into a separate patch. Regardless of that suggestions, there seems to be a bug in this patch. On 12 March 2018 at 17:55, Thomas Helland wrote: > Walking the whole hash table, inserting entries by

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Thomas Helland writes: > Walking the whole hash table, inserting entries by hashing them first > is just a really bad idea. We can simply memcpy the whole thing. > --- > src/compiler/glsl/opt_copy_propagation.cpp | 13 -- >

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

ping. --Aaron On Thu, Mar 1, 2018 at 8:02 PM, Aaron Watry wrote: > Used to calculate the default CLC language version based on the --cl-std in > build args > and the device capabilities. > > According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: > 1) If

[Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

v2: Use assume() at the srcs[] definition instead. Cc: Jason Ekstrand Cc: Ian Romanick Cc: Eric Engestrom --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] meson: don't use compiler.has_header

Meson's compiler.has_header is completely useless, it only checks that a header exists, not whether it's usable. This creates problems if a header contains a conditional #error declaration, like so: > #if __x86_64__ > # error "Doesn't work with x86_64!" > #endif Compiler.has_header will return

Re: [Mesa-dev] Few issues with Meson

This is my cross file (Arch doesn't have a pkg-config for x86, so I have a shell wrapper that sets PKG_CONFIG_PATH), you'll probably need to adjust some paths ``` [binaries] c = '/usr/bin/gcc' cpp = '/usr/bin/g++' ar = '/usr/bin/ar' strip = '/usr/bin/strip' pkgconfig =

Re: [Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

Reviewed-by: Ian Romanick On 03/12/2018 11:21 AM, Eric Anholt wrote: > v2: Use assume() at the srcs[] definition instead. > > Cc: Jason Ekstrand > Cc: Ian Romanick > Cc: Eric Engestrom > ---

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 03:24, Emil Velikov wrote: > Hi Dave, > > On 11 March 2018 at 23:26, Dave Airlie wrote: >> From: Dave Airlie >> >> I'm not sure everyone wants to be updating their dri3 in a forced >> march setting, this allows

Re: [Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

Hi Thomas, On 12 March 2018 at 17:55, Thomas Helland wrote: > V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) > --- > src/util/hash_table.c | 22 ++ > src/util/hash_table.h | 2 ++ > 2 files changed, 24 insertions(+) > >

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 12 March 2018 at 18:48, Dave Airlie wrote: > On 13 March 2018 at 03:24, Emil Velikov wrote: >> Hi Dave, >> >> On 11 March 2018 at 23:26, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> I'm not sure everyone

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #1 from Philip Rebohle --- Created attachment 138038 --> https://bugs.freedesktop.org/attachment.cgi?id=138038=edit Witcher 3 hull shader which may suffer from the same issue FWIW, the tessellation

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

Quoting Eric Engestrom (2018-03-12 11:05:51) > On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-03-12 07:33:27) > > > We're trying to be -Wundef clean so that we can turn it on (and > > > eventually make it an error). > > > > > > Note that the OMX code

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 03:59, Marek Olšák wrote: > This is good, though some older distros only have libxcb 1.11. On those distros you likely just want to --disable-dri3 anyways. Dave. ___ mesa-dev mailing list

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 Bug ID: 105464 Summary: Reading per-patch outputs in Tessellation Control Shader returns undefined values Product: Mesa Version: git Hardware: Other OS:

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Dylan Baker writes: > Quoting Emil Velikov (2018-03-12 08:38:31) >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> >> Ilia Mirkin writes: >> >> >> >> > On Tue,

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

Hi, Juan and I have been talking lately that it is clear that reaching the final version of a feature releases is often getting hard. Therefore, we would like to propose that no stable release will be carried on by the same release team member while on duty doing a feature release. This will

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Mon, 2018-03-12 at 07:30 -0700, Mark Janes wrote: > "Juan A. Suarez Romero" writes: > > > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > > > Ilia Mirkin writes: > > > > > > > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov

[Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

Signed-off-by: Eric Engestrom --- Dylan, was there any reason to have -Werror=missing-prototypes and -Werror=implicit-function-declaration in C but not C++? Both sound to me like something we always want. --- meson.build | 17 ++--- 1 file changed, 6

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

On 12 March 2018 at 14:33, Eric Engestrom wrote: > We're trying to be -Wundef clean so that we can turn it on (and > eventually make it an error). > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > of #ifdef; I could've changed these, but the

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

On Mon, 2018-03-12 at 16:45 +0100, Juan A. Suarez Romero wrote: > > > On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: [...] > > My proposal would be, similarly to what Intel does to track [1] the > > stabilization for a release, 1 week (?) prior to the branching time to > > create a

[Mesa-dev] [PATCH mesa] meson: simplify omx logic

and let's make sure `with_gallium_omx` is never 'auto' and can only be one of [bellagio, tizonia, disabled]. Signed-off-by: Eric Engestrom --- meson.build | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

On Mon, Mar 12, 2018 at 6:18 AM, Samuel Pitoiset wrote: > > > On 03/11/2018 04:41 PM, Marek Olšák wrote: >> >> On Thu, Mar 8, 2018 at 5:48 PM, Ian Romanick wrote: >>> >>> On 03/08/2018 06:50 AM, Samuel Pitoiset wrote: This pass moves

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> >> > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov >> > wrote: >> > > So while others

[Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

From the spec: "When copying between compressed and uncompressed formats the extent members represent the texel dimensions of the source image and not the destination." However, as per 7b890a36, we must still use the destination image type when clamping the extent so that we copy

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

On Mon, 2018-03-12 at 16:35 +0200, Andres Gomez wrote: > Hi, > > * Release schedule: move from pre-announce Wed, announcement Fri [0] >to pre-announce Mon, announcement Wed. > * Why would we want to do this? >* We have delays in the release every now and then. When this >

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On 12 March 2018 at 14:20, Andres Gomez wrote: > Thanks for opening this thread Emil. > > I will open new branches for other topics that have been boiling in our > minds for a while. I hope you, Emil, can forgive us for not having been > more diligent with those, as you are

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

On 12 March 2018 at 15:01, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Dylan, was there any reason to have -Werror=missing-prototypes and > -Werror=implicit-function-declaration in C but not C++? > Both sound to me like

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: > Hi, > > Juan and I have been talking lately that it is clear that reaching the > final version of a feature releases is often getting hard. > > Therefore, we would like to propose that no stable release will be > carried on by the same

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

Quoting Eric Engestrom (2018-03-12 07:33:27) > We're trying to be -Wundef clean so that we can turn it on (and > eventually make it an error). > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > of #ifdef; I could've changed these, but the point of -Wundef is to > catch

Re: [Mesa-dev] [PATCH] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

On Fri, 2018-02-23 at 17:10 +0200, Eleni Maria Stea wrote: > Gen 7 GPUs store the compressed EAC/ETC2 images in other non-compressed > formats that can render. When GetCompressed* functions are called, the > pixels are returned in the non-compressed format that is used for the > rendering. > >

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

Hi Dave, On 11 March 2018 at 23:26, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distro that aren't brand new. >

Re: [Mesa-dev] [PATCH mesa] meson: simplify omx logic

Quoting Eric Engestrom (2018-03-12 09:12:33) > and let's make sure `with_gallium_omx` is never 'auto' and can only be > one of [bellagio, tizonia, disabled]. > > Signed-off-by: Eric Engestrom > --- > meson.build | 34 -- > 1 file

Re: [Mesa-dev] [PATCH 0/2] Enable shader cache for ARB_get_program_binary

On 12 March 2018 at 00:25, Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa program-binary-shader-cache > > I found that when running DOTA2, most programs were skipping the > shader cache. It appears that since DOTA2 uses ARB_get_program_binary, > the

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Quoting Emil Velikov (2018-03-12 08:38:31) > On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > >> Ilia Mirkin writes: > >> > >> > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov

Re: [Mesa-dev] [v4 PATCH 3/6] spirv_extensions: add list of extensions and to_string method

Adding Jason and Ian here for their opinions. Quoting Alejandro Piñeiro (2018-03-12 01:31:02) > On 11/03/18 18:08, Dylan Baker wrote: > > Quoting Alejandro Piñeiro (2018-03-08 07:00:16) > >> Ideally this should be generated somehow. One option would be gather > >> all the extension dependencies

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

Ping. Any more comments or missing stuff to get this commited into master? Thanks. On Wed, Mar 7, 2018 at 2:39 PM, Lepton Wu wrote: > If user calls map twice for kms_sw_displaytarget, the first mapped > buffer could get leaked. Instead of calling mmap every time, just >

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Hi Ilia, On 6 March 2018 at 20:09, Ilia Mirkin wrote: > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov wrote: >> So while others explore ways of improving the testing, let me propose >> a few ideas for improving the actual releasing process. >> >>

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Emil Velikov writes: > On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >>> - Patches are applied to proposed stable branch by automation when the >>>associated commit is pushed to

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: > On 13 March 2018 at 03:59, Marek Olšák wrote: >> This is good, though some older distros only have libxcb 1.11. > > On those distros you likely just want to --disable-dri3 anyways. > > Dave. Good one. I

Re: [Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

On Mon, Mar 5, 2018 at 10:21 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > OpSConvert interprets the MSB of the unsigned value as the sign bit and > extends it to the new type. If we want to preserve the value, we need > to use OpUConvert opcode. > > v2: > - No need to check dst

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

On 13 March 2018 at 05:58, Marek Olšák wrote: > On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: >> On 13 March 2018 at 03:59, Marek Olšák wrote: >>> This is good, though some older distros only have libxcb 1.11. >> >> On those distros

Re: [Mesa-dev] [PATCH] intel/tools: aubinator: Catch gen11 "enhanced execlist" submission

Tested-by: Rafael Antognolli On Fri, Mar 09, 2018 at 04:29:41PM -0800, Scott D Phillips wrote: > Different registers are used for execlist submission in gen11, so > also watch those. This code only watches element zero of the > submit queue, which is all aubdump

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

Quoting Emil Velikov (2018-03-12 09:09:50) > On 12 March 2018 at 15:01, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > Dylan, was there any reason to have -Werror=missing-prototypes and > >

  1   2   >