[Mesa-dev] [PATCH] docs/egl: Android platform can also be build using autotools

2016-05-23 Thread Nicolas Boichat
We added support for Android build using autotools (configure), update the documentation to reflect that. Signed-off-by: Nicolas Boichat --- docs/egl.html | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/egl.html b/docs/egl.html index

[Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-05-23 Thread Nicolas Boichat
platform_android.c needs to link with cutils, hardware, and sync libraries, as well as drm_gralloc libs. Also add appropriate tests in configure.ac. Signed-off-by: Nicolas Boichat --- configure.ac| 6 ++ src/egl/Makefile.am | 3 +++ 2 files changed, 9

Re: [Mesa-dev] [PATCH] i965/fs: Fix off-by-one region overlap comparison in copy propagation.

2016-05-23 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 24/05/16 05:34, Francisco Jerez wrote: > This was introduced in cf375ae54a01462f192202d609436e5fbec8 but > the blame is mine because the pseudocode I sent in my review comment > for the original patch suggesting to do things

Re: [Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Pohjolainen, Topi
On Tue, May 24, 2016 at 10:00:07AM +1000, Dave Airlie wrote: > From: Dave Airlie > > gcc6 warns about this. Thanks for doing this, it has been on my list, just kept forgetting it. Reviewed-by: Topi Pohjolainen > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] nvc0: enable 32 textures on kepler+

2016-05-23 Thread Ilia Mirkin
For fermi, this likely will require use of linked tsc mode. However on bindless architectures, we can have as many as we want. As it stands, the AUX_TEX_INFO has 32 teture handles reserved. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 2

[Mesa-dev] [PATCH] i965/gen7: Fix gl_HelperInvocation

2016-05-23 Thread Jordan Justen
It appears that UV immediates aren't working on Ivy Bridge. In this case, a signed version will work, and this fixes the piglit tests/spec/glsl-4.50/execution/helper-invocation.shader_test test. Signed-off-by: Jordan Justen Cc: Matt Turner ---

Re: [Mesa-dev] [PATCH] mesa: remove separate enable for KHR_robust_buffer_access_behavior

2016-05-23 Thread Jason Ekstrand
Fine with me Acked-by: Jason Ekstrand On Mon, May 23, 2016 at 7:44 PM, Ilia Mirkin wrote: > This extension appears to be a strict subset of the ARB version. Also > remove it from GL3.txt since it doesn't seem relevant. > > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 7:49 PM, Matt Turner wrote: > On Mon, May 23, 2016 at 6:43 PM, Jason Ekstrand > wrote: > > This prevents SPIR-V -> NIR from dying if we get a decoration we don't > know > > about. Compiling incorrect code is probably a better

[Mesa-dev] [PATCH] i965/fs: Fix off-by-one region overlap comparison in copy propagation.

2016-05-23 Thread Francisco Jerez
This was introduced in cf375ae54a01462f192202d609436e5fbec8 but the blame is mine because the pseudocode I sent in my review comment for the original patch suggesting to do things this way already had the off-by-one error. This may have caused copy propagation to be unnecessarily strict while

[Mesa-dev] [PATCH] docs: true up nvc0 status - images, etc

2016-05-23 Thread Ilia Mirkin
Images aren't supported on maxwell, but neither is tessellation. Don't overly confuse matters by trying to expose those subtleties in the GL3.txt file/relnotes. Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 10 +- docs/relnotes/11.3.0.html | 13

[Mesa-dev] [PATCH] st/mesa: enable ARB_ES3_1_compatibility when ES 3.1 would be exposed

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 22 ++ 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt

Re: [Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 6:43 PM, Jason Ekstrand wrote: > This prevents SPIR-V -> NIR from dying if we get a decoration we don't know > about. Compiling incorrect code is probably a better failure mode than > dying horribly. > > Bugzilla:

[Mesa-dev] [PATCH] mesa: remove separate enable for KHR_robust_buffer_access_behavior

2016-05-23 Thread Ilia Mirkin
This extension appears to be a strict subset of the ARB version. Also remove it from GL3.txt since it doesn't seem relevant. Signed-off-by: Ilia Mirkin --- Let me know if you think I'm missing something. From the KHR spec: 3) How does this extension differ from

[Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Jason Ekstrand
This prevents SPIR-V -> NIR from dying if we get a decoration we don't know about. Compiling incorrect code is probably a better failure mode than dying horribly. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95573 --- src/compiler/spirv/spirv_to_nir.c | 6 --

[Mesa-dev] [PATCH] glsl: add EXT_clip_cull_distance support based on ARB_cull_distance

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 12 +++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/compiler/glsl/linker.cpp | 35 ++--

[Mesa-dev] [PATCH V2] glsl: add support for doubles in GL 4.4+

2016-05-23 Thread Timothy Arceri
We disable varying packing in GL 4.4+ as we can no longer assume varying have the same interpolation qualifiers. However doubles used as fs inputs must always be qualified as "flat" and backends expect doubles to have been packed as floats so we enable packing for them. V2: fix comments and only

[Mesa-dev] [PATCH 4/3] glsl: add GL_EXT_geometry_point_size support

2016-05-23 Thread Ilia Mirkin
This mirrors existing GL_OES_geometry_point_size support. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 3 ++- src/compiler/glsl/glcpp/glcpp-parse.y| 2 ++ src/compiler/glsl/glsl_parser_extras.cpp | 1 +

Re: [Mesa-dev] [PATCH v3 08/16] i965/surface_formats: Update the VB column for new formats added on BYT

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 3:51 PM, Kenneth Graunke wrote: > On Friday, May 20, 2016 4:53:19 PM PDT Jason Ekstrand wrote: > > Bay Trail and Haswell added a bunch of new vertex formats. There was > also > > the addition of 64-bit passthrough formats for BDW+. > > --- > >

[Mesa-dev] [PATCH 2/3] glsl: allow invocations to be specified in ES 3.20 + exts

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 3 ++- src/compiler/glsl/glsl_parser.yy| 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/builtin_variables.cpp

[Mesa-dev] [PATCH 3/3] glsl: expose gl_Layer in fs for ES 3.20 + exts

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index e082572..d78ac88 100644 ---

[Mesa-dev] [PATCH 1/3] glsl: add GL_EXT_geometry_shader extension support

2016-05-23 Thread Ilia Mirkin
From: Kenneth Graunke [imirkin: add FramebufferTextureEXT entrypoint] Signed-off-by: Ilia Mirkin --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 6 +- src/mapi/glapi/gen/es_EXT.xml| 11

Re: [Mesa-dev] [PATCH] st/va: use drm render node for wayland display type

2016-05-23 Thread Emil Velikov
On 17 May 2016 at 20:16, Leo Liu wrote: > With xwayland, vainfo use VA_DISPLAY_WAYLAND as default and it fails > and fails when specify display with `vainfo --display wayland`. > In fact wayland support for libva uses drm path to connect device, > and should use drm pipe loader

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Clark
On Mon, May 23, 2016 at 8:12 PM, Emil Velikov wrote: > On 23 May 2016 at 22:19, Rob Clark wrote: >> On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >>> I run a buildtest in our CI to help Intel engineers avoid breaking

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Herring
On Mon, May 23, 2016 at 7:12 PM, Emil Velikov wrote: > On 23 May 2016 at 22:19, Rob Clark wrote: >> On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >>> I run a buildtest in our CI to help Intel engineers avoid breaking

Re: [Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 22:11, Giuseppe Bilotta wrote: > Hello Emil, > > On Mon, May 23, 2016 at 11:20 AM, Emil Velikov > wrote: >> It seems like this won't work if one builds --enable-clover --disable-dri. > > Argh, I hadn't considered this

Re: [Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 5:00 PM, Dave Airlie wrote: > From: Dave Airlie > > gcc6 warns about this. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/gen7_blorp.c | 18 +- > 1 file changed, 9

Re: [Mesa-dev] [PATCH 1/2] glsl: reindent line in ast_function.cpp

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 5:00 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes a warning with gcc -Wmisleading-indentation. > > Signed-off-by: Dave Airlie Both are Acked-by: Matt Turner

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 22:19, Rob Clark wrote: > On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >> I run a buildtest in our CI to help Intel engineers avoid breaking the >> builds for other Mesa targets. >> >> With this commit, it produces: >> >>

[Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Dave Airlie
From: Dave Airlie gcc6 warns about this. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/gen7_blorp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c

[Mesa-dev] [PATCH 1/2] glsl: reindent line in ast_function.cpp

2016-05-23 Thread Dave Airlie
From: Dave Airlie This fixes a warning with gcc -Wmisleading-indentation. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Timothy Arceri
On Mon, 2016-05-23 at 16:07 -0700, Kenneth Graunke wrote: > On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > > > > This prevents array overflow when the block is actually an array of > > UBOs or > > SSBOs.  On some hardware such as i965, such overflows can cause GPU > > hangs. > >

Re: [Mesa-dev] [PATCH 00/31] i965: Scalar back-end support for SIMD32, part 1.

2016-05-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, May 20, 2016 at 10:47 PM, Francisco Jerez > wrote: > >> The purpose of this series is to improve the back-end infrastructure >> so that lowering of most IR instructions that are too wide to execute >> natively (which

Re: [Mesa-dev] [PATCH] glsl: Use correct mode for split components.

2016-05-23 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-04-20 06:42:01, Bas Nieuwenhuizen wrote: > The mode should stay the same as the original struct. In > particular, shared should not be changed to temporary. > > Signed-off-by: Bas Nieuwenhuizen > --- >

Re: [Mesa-dev] [PATCH 00/31] i965: Scalar back-end support for SIMD32, part 1.

2016-05-23 Thread Jason Ekstrand
On Fri, May 20, 2016 at 10:47 PM, Francisco Jerez wrote: > The purpose of this series is to improve the back-end infrastructure > so that lowering of most IR instructions that are too wide to execute > natively (which is far more common than usual in SIMD32 dispatch mode)

Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Kenneth Graunke
On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > This prevents array overflow when the block is actually an array of UBOs or > SSBOs. On some hardware such as i965, such overflows can cause GPU hangs. > > Reviewed-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/23/2016 09:21 AM, Giuseppe Bilotta wrote: Code generation (kernel compilation) may sometimes hit LLVM-specific bugs. Adding the used LLVM version to the version string may make bug triaging easier. (This was inspired by a similar patch recently proposed for pocl.) Signed-off-by: Giuseppe

Re: [Mesa-dev] [PATCH v3 08/16] i965/surface_formats: Update the VB column for new formats added on BYT

2016-05-23 Thread Kenneth Graunke
On Friday, May 20, 2016 4:53:19 PM PDT Jason Ekstrand wrote: > Bay Trail and Haswell added a bunch of new vertex formats. There was also > the addition of 64-bit passthrough formats for BDW+. > --- > src/mesa/drivers/dri/i965/brw_surface_formats.c | 32 +++ +- > 1 file

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-23 Thread Marek Olšák
On Mon, May 23, 2016 at 10:31 PM, Miklós Máté wrote: > On 05/20/2016 05:42 PM, Ilia Mirkin wrote: >> >> On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: >>> >>> On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: From: Marek

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/24/2016 12:46 AM, Marek Olšák wrote: On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: I think it would be better to put stuff like this only into the renderer string of drivers

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Marek Olšák
On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: > On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: >> I think it would be better to put stuff like this only into the >> renderer string of drivers which use LLVM. The majority of drivers

Re: [Mesa-dev] [PATCH] glsl: fix explicit location validation for doubles

2016-05-23 Thread Anuj Phogat
On Sun, May 22, 2016 at 8:11 PM, Timothy Arceri wrote: > Previously we would fail to find a match for the second half of a > dvec4 as 'i' would get incremented to 1 before we added the var to > the array at component 0. > --- > src/compiler/glsl/link_varyings.cpp |

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Manolova, Plamena
Hi Brian, On Mon, May 23, 2016 at 9:51 PM, Brian Paul wrote: > Hi Plamena, > > Some style nitpicks below. Feel free to take 'em or leave 'em. > I'm not too involved in EGL. > > > > On 05/23/2016 10:27 AM, Plamena Manolova wrote: > >> According to the EGL specifications

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Mark Janes
Rob Clark writes: > On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >> I run a buildtest in our CI to help Intel engineers avoid breaking the >> builds for other Mesa targets. >> >> With this commit, it produces: >> >> make[2]: Entering directory

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, May 23, 2016 at 5:15 PM, Brian Paul wrote: > Otherwise, if the call executes normally we'll hit an assertion later > in the VBO code when we draw something. Note that these cases were > already handled correctly for the

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Ilia Mirkin
On Mon, May 23, 2016 at 5:12 PM, Dave Airlie wrote: > On 24 May 2016 at 06:56, Ilia Mirkin wrote: >> On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> The last version of this broke

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Clark
On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: > I run a buildtest in our CI to help Intel engineers avoid breaking the > builds for other Mesa targets. > > With this commit, it produces: > > make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' > CCLD

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Mark Janes
I run a buildtest in our CI to help Intel engineers avoid breaking the builds for other Mesa targets. With this commit, it produces: make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' CCLD libgbm.la backends/dri/.libs/gbm_dri.o: In function `mtx_init':

Re: [Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Anuj Phogat
On Mon, May 23, 2016 at 2:01 PM, Brian Paul wrote: > Err, "hexadecimal". Will fixe before pushing. > > > On 05/23/2016 03:00 PM, Brian Paul wrote: >> >> All the other error messages use decimal. Let's be consistent. >> --- >> src/mesa/main/bufferobj.c | 4 ++-- >> 1 file

[Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the glIsEnabled() function (and the API checks were copied from there). Tested with new piglit gl-3.1-enable-vertex-array test.

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
On 05/23/2016 03:03 PM, Ilia Mirkin wrote: On Mon, May 23, 2016 at 4:35 PM, Brian Paul wrote: Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Dave Airlie
On 24 May 2016 at 06:56, Ilia Mirkin wrote: > On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> The last version of this broke clipping, and I had to spend >> sometime getting this working properly. >> >>

Re: [Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

2016-05-23 Thread Giuseppe Bilotta
Hello Emil, On Mon, May 23, 2016 at 11:20 AM, Emil Velikov wrote: > It seems like this won't work if one builds --enable-clover --disable-dri. Argh, I hadn't considered this possibility. > The following should keep mesa and gallium code separate, can we try that one

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, May 23, 2016 1:35 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org Subject: [PATCH] mesa: raise error for

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Ilia Mirkin
On Mon, May 23, 2016 at 4:35 PM, Brian Paul wrote: > Otherwise, if the call executes normally we'll hit an assertion later > in the VBO code when we draw something. Note that these cases were > already handled correctly for the glIsEnabled() function (and the API > checks were

Re: [Mesa-dev] [PATCH 2/7] i965: Unset alpha blend for R10G10B10_SNORM_A2_UNORM

2016-05-23 Thread Nanley Chery
On Sat, May 21, 2016 at 08:50:13AM +0200, Eduardo Lima Mitev wrote: > On 05/21/2016 03:12 AM, Jason Ekstrand wrote: > > From: Nanley Chery > > > > This format does not support alpha blending, according to the SNB PRM. > > > > In general, it helps (at least review) to

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 10:41 AM, Nanley Chery wrote: > On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: > > This little series effectively moves the surface format table from > > brw_surface_formats.c into ISL. Previously, it got built into > >

Re: [Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Brian Paul
Err, "hexadecimal". Will fixe before pushing. On 05/23/2016 03:00 PM, Brian Paul wrote: All the other error messages use decimal. Let's be consistent. --- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Brian Paul
All the other error messages use decimal. Let's be consistent. --- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 34d81aa..33bc574 100644 --- a/src/mesa/main/bufferobj.c +++

[Mesa-dev] [PATCH 1/2] mesa: use enum name in bind_buffer_object() error message

2016-05-23 Thread Brian Paul
--- src/mesa/main/bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 22073dd..34d81aa 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1020,7 +1020,8 @@ bind_buffer_object(struct

Re: [Mesa-dev] [PATCH 2/2] mesa: allow GL_FRAMEBUFFER_DEFAULT_LAYERS to be queried with ES geometry

2016-05-23 Thread Anuj Phogat
On Mon, May 23, 2016 at 10:02 AM, Ilia Mirkin wrote: > When we have the geometry extensions, enable querying of the new param. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/fbobject.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Ilia Mirkin
On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: > From: Dave Airlie > > The last version of this broke clipping, and I had to spend > sometime getting this working properly. > > I had to introduce a third pass to count the clip/cull totals, > all due

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Brian Paul
Hi Plamena, Some style nitpicks below. Feel free to take 'em or leave 'em. I'm not too involved in EGL. On 05/23/2016 10:27 AM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Giuseppe Bilotta
On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: > I think it would be better to put stuff like this only into the > renderer string of drivers which use LLVM. The majority of drivers > don't care about the LLVM version. Hm, that might be a good point. Is there a way to

[Mesa-dev] [PATCH] [rfc] mesa/program_resource: return -1 for index if no location.

2016-05-23 Thread Dave Airlie
From: Dave Airlie The GL4.5 spec quote seems clear on this: "The value -1 will be returned by either command if an error occurs, if name does not identify an active variable on programInterface, or if name identifies an active variable that does not have a valid location

Re: [Mesa-dev] [PATCH 1/4] glsl: make max array trackers ints and use -1 as base.

2016-05-23 Thread Ilia Mirkin
On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes a bug that breaks cull distances. The problem > is the max array accessors can't tell the difference between > an never accessed unsized array and an accessed at

[Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the glIsEnabled() function (and the API checks were copied from there). Tested with new piglit gl-3.1-enable-vertex-array test.

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-23 Thread Miklós Máté
On 05/20/2016 05:42 PM, Ilia Mirkin wrote: On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: From: Marek Olšák This allows drivers to use their own fast path for texture uploads.

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

2016-05-23 Thread Nanley Chery
On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: > This little series effectively moves the surface format table from > brw_surface_formats.c into ISL. Previously, it got built into > libi965_compiler.la because we needed to share it between drivers and > didn't have a better place

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Serge Martin
On Monday 23 May 2016 09:21:51 Giuseppe Bilotta wrote: > Code generation (kernel compilation) may sometimes hit LLVM-specific > bugs. Adding the used LLVM version to the version string may make bug > triaging easier. (This was inspired by a similar patch recently > proposed for pocl.) > >

[Mesa-dev] [PATCH 1/2] mesa: allow xfb to be active in GLES when geometry shader is enabled.

2016-05-23 Thread Ilia Mirkin
OES_geometry_shader has wording to allow xfb when using Draw*Indirect and DrawElements. Signed-off-by: Ilia Mirkin --- src/mesa/main/api_validate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/api_validate.c

[Mesa-dev] [PATCH 2/2] mesa: allow GL_FRAMEBUFFER_DEFAULT_LAYERS to be queried with ES geometry

2016-05-23 Thread Ilia Mirkin
When we have the geometry extensions, enable querying of the new param. Signed-off-by: Ilia Mirkin --- src/mesa/main/fbobject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 70

[Mesa-dev] [Bug 95553] Requesting a new account for mesa and piglit (Andres Gomez)

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95553 --- Comment #1 from Andrés Gómez García --- Created attachment 124001 --> https://bugs.freedesktop.org/attachment.cgi?id=124001=edit PGP/GPG public key -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 95553] Requesting a new account for mesa and piglit (Andres Gomez)

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95553 --- Comment #2 from Andrés Gómez García --- Created attachment 124002 --> https://bugs.freedesktop.org/attachment.cgi?id=124002=edit SSH public key -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 95553] Requesting a new account for mesa and piglit (Andres Gomez)

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95553 Bug ID: 95553 Summary: Requesting a new account for mesa and piglit (Andres Gomez) Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] nvc0: do not invalidate compute constbufs on Kepler

2016-05-23 Thread Samuel Pitoiset
On 05/22/2016 08:39 PM, Ilia Mirkin wrote: Seems reasonable. I assume you tested some draw/compute interop deqp tests on kepler to make sure it didn't start failing? Just tested, no regressions with both piglit and deqp. Reviewed-by: Ilia Mirkin On Sun, May 22, 2016

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95159 --- Comment #7 from Emil Velikov --- I've got alternative solution that I'm rebasing atm. Keep an eye open for a dozen or so patches that brings some sense into the GL/CL interop header/implementation. -- You are

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Brian Paul
On 05/23/2016 09:22 AM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 70

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

2016-05-23 Thread Rob Herring
On Sun, May 22, 2016 at 2:28 PM, Mark Janes wrote: > Tom Stellard writes: > >> On Fri, May 20, 2016 at 04:29:07PM -0700, Mark Janes wrote: >>> Tom Stellard writes: >>> >>> > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky

[Mesa-dev] [Bug 95529] [regression, bisected] Image corruption in Chrome

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95529 --- Comment #2 from Brian Paul --- For the llvmpipe images, what exactly is the issue? I see a faint checkerboard pattern in some of the images. Is that it? Would it be possible for you to create an apitrace of the GL

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95159 --- Comment #6 from Rob Herring --- This is still broken on Android builds. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 95534] Requesting git commit acccess

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95534 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

2016-05-23 Thread Brian Paul
On 05/23/2016 03:20 AM, Emil Velikov wrote: Hi Giuseppe, On 23 May 2016 at 08:21, Giuseppe Bilotta wrote: Refactor the "Mesa " PACKAGE_VERSION [optional git SHA1] string into a separate version_string.h header, and use it from both Mesa and clover to report the

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Marek Olšák
I think it would be better to put stuff like this only into the renderer string of drivers which use LLVM. The majority of drivers don't care about the LLVM version. Marek On Mon, May 23, 2016 at 9:21 AM, Giuseppe Bilotta wrote: > Code generation (kernel compilation)

Re: [Mesa-dev] [PATCH] st/mesa: update inst->info along with inst->op

2016-05-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, May 22, 2016 at 10:52 PM, Ilia Mirkin wrote: > Otherwise we still have TGSI_OPCODE_CMP's info, which causes a number of > later logic to go wrong. This fixes > >

Re: [Mesa-dev] [PATCH] glsl: add support for doubles in GL 4.4+

2016-05-23 Thread Iago Toral
On Mon, 2016-05-23 at 12:41 +1000, Timothy Arceri wrote: > We disable varying packing in GL 4.4+ as we can no longer assume > varying have the same interpolation qualifiers. However doubles used > as fs inputs must always be qualified as "flat" and backends expect > doubles to have been packed as

Re: [Mesa-dev] [PATCH 2/2] mesa: Implement glGet*(GL_PRIMITIVE_RESTART_FOR_PATCHES_SUPPORTED).

2016-05-23 Thread Marek Olšák
Other than the get_shader_param thing, this series is: Reviewed-by: Marek Olšák Marek On Sat, May 21, 2016 at 8:06 PM, Kenneth Graunke wrote: > On Saturday, May 21, 2016 10:41:30 AM PDT Ilia Mirkin wrote: >> On Sat, May 21, 2016 at 1:31 AM, Kenneth

Re: [Mesa-dev] [PATCH 14/14] st/mesa: implement PBO downloads for ReadPixels

2016-05-23 Thread Marek Olšák
On Wed, May 18, 2016 at 5:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_cb_readpixels.c | 142 > +- > src/mesa/state_tracker/st_pbo.c | 16 >

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-23 Thread Rob Clark
On Sun, May 22, 2016 at 10:15 PM, Nicolas Boichat wrote: > Hi Emil, > > Apologies for the delay, it's easier to answer your questions now that > the project has launched > (https://chrome.googleblog.com/2016/05/the-google-play-store-coming-to.html). > Basically we are

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-23 Thread Nicolas Boichat
On Mon, May 23, 2016 at 8:20 PM, Emil Velikov wrote: > On 23 May 2016 at 12:17, Nicolas Boichat wrote: >> On Mon, May 23, 2016 at 5:49 PM, Emil Velikov >> wrote: >>> [...] > Do you guys have X related libraries on

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 12:17, Nicolas Boichat wrote: > On Mon, May 23, 2016 at 5:49 PM, Emil Velikov > wrote: >> [...] Do you guys have X related libraries on the host_os ? Or you explicitly disable those mesa features that depend on it ?

Re: [Mesa-dev] [PATCH v2] doxygen: Add missing modules to Windows runner

2016-05-23 Thread Emil Velikov
On 20 May 2016 at 23:58, Rhys Kidd wrote: > On 11 May 2016 at 07:51, Rhys Kidd wrote: >> >> On 10 May 2016 at 16:04, Elie TOURNIER wrote: >>> >>> --- >>> doxygen/doxy.bat | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>>

Re: [Mesa-dev] [PATCH v2 0/9] GBM map/unmap support

2016-05-23 Thread Emil Velikov
Hi Rob, all, On 4 May 2016 at 03:02, Rob Herring wrote: > This series adds map and unmap functions to GBM. These are needed to > provide a device independent buffer allocation interface to Android's > gralloc. > > Open questions: > - Need to flush context on unmap? > - Need

[Mesa-dev] [Bug 95456] glXGetFBConfigs has invalid screen bounds

2016-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95456 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-23 Thread Nicolas Boichat
On Mon, May 23, 2016 at 5:49 PM, Emil Velikov wrote: > [...] >>> Do you guys have X related libraries on the host_os ? Or you >>> explicitly disable those mesa features that depend on it ? >> >> AFAIK, no X libraries, neither on Chrome OS or Android side. >> > Just

Re: [Mesa-dev] [PATCH 03/39] llvmpipe: Fix overflow for 32 bits available memory computation

2016-05-23 Thread Emil Velikov
On 18 May 2016 at 20:50, Axel Davy wrote: > On 16/05/2016 20:08, Emil Velikov wrote: >> >> >> Then there's the question if other drivers want to apply, and thus >> move, it elsewhere. >> >> -Emil >> > Has anyone an opinion about that particular point ? > Most likely no-one is

Re: [Mesa-dev] [PATCH] egl/dri2: Don't check return result of mtx_unlock().

2016-05-23 Thread Emil Velikov
Thanks Matt. Feel free to drop the mtx_lock checking as well. Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] egl: add EGL_KHR_reusable_sync to egl_dri

2016-05-23 Thread Emil Velikov
On 6 April 2016 at 13:10, Emil Velikov wrote: > On 5 April 2016 at 22:32, Dongwon Kim wrote: >> Hi Emil, >> >> I don't think I still have a chance to update >> this to version 4 since this has already been pushed >> according to Marek... > Indeed

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 03:15, Nicolas Boichat wrote: > Hi Emil, > > Apologies for the delay, it's easier to answer your questions now that > the project has launched > (https://chrome.googleblog.com/2016/05/the-google-play-store-coming-to.html). > Basically we are running

  1   2   >