Re: [Mesa-dev] [PATCH] AndroidIA: android: add libmesa_genxml as dep to libmesa_isl

2017-03-29 Thread Tapani Pälli
doh sorry about that 'AndroidIA' there, we are using it to differentiate patches that we have in our tree and are not in Mesa master yet. On 03/30/2017 08:51 AM, Tapani Pälli wrote: This is to fix following compile error with libmesa_isl: mesa/src/intel/isl/isl.c:28:10: fatal error:

[Mesa-dev] [PATCH] AndroidIA: android: add libmesa_genxml as dep to libmesa_isl

2017-03-29 Thread Tapani Pälli
This is to fix following compile error with libmesa_isl: mesa/src/intel/isl/isl.c:28:10: fatal error: 'genxml/genX_bits.h' file not found Fixes: f0eaf38 ("genxml: New generated header genX_bits.h (v6)") Signed-off-by: Tapani Pälli --- src/intel/Android.isl.mk | 3 ++-

[Mesa-dev] [PATCH] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

2017-03-29 Thread Timothy Arceri
We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. --- src/mesa/main/debug_output.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/debug_output.c b/src/mesa/main/debug_output.c index bc933db..2b22645 100644 ---

[Mesa-dev] [AppVeyor] mesa master #3903 completed

2017-03-29 Thread AppVeyor
Build mesa 3903 completed Commit 36cb2003f1 by Harish Krupo on 3/28/2017 6:38 PM: android: pass sse4.1 flag as appropriate\n\nWe have functions which depend on sse4.1 support but we didnt pass\nthe right compile flag for it. This patch fixes

Re: [Mesa-dev] [PATCH] util/u_atomic: provide 64bit atomics where they're missing

2017-03-29 Thread Jonathan Gray
On Wed, Mar 29, 2017 at 04:55:54PM -0700, Matt Turner wrote: > On Wed, Mar 29, 2017 at 4:13 PM, Grazvydas Ignotas wrote: > > There are still some distributions trying to support unfortunate people > > with old or exotic CPUs that don't have 64bit atomic operations. When > >

Re: [Mesa-dev] [PATCH] mesa/glthread: add custom marshalling for ClearBufferfv()

2017-03-29 Thread Timothy Arceri
On 28/03/17 01:02, Gregory Hainaut wrote: Hello Timothy, 2 small questions: Will it work for DSA equivalent function, namely glClearNamedFramebufferfv ? It looks like we don't currently even bother to implement glClearNamedFramebufferfv properly. Would it be interesting to also do the

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Michel Dänzer
On 30/03/17 12:56 AM, Thomas Hellstrom wrote: > On 03/29/2017 02:34 PM, Emil Velikov wrote: >> On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >>> On 03/29/2017 01:30 PM, Emil Velikov wrote: On 28 March 2017 at 20:39, Thomas Hellstrom wrote:

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Michel Dänzer
On 30/03/17 02:31 AM, Bartosz Tomczyk wrote: > Call it directly when batch queue is empty. This avoids costly thread > synchronisation. With this fix games that previously regressed > with mesa_glthread=true like xonotic or grid autosport. The second sentence here is missing a verb (at least).

[Mesa-dev] [AppVeyor] mesa master #3902 failed

2017-03-29 Thread AppVeyor
Build mesa 3902 failed Commit a930c2c612 by Dave Airlie on 3/30/2017 3:09 AM: radv: fix mask attribs properly.\n\nsome days it just doesn't pay to get out of bed.\n\nSigned-off-by: Dave Airlie Configure your notification

Re: [Mesa-dev] [PATCH] drirc: Set glsl_zero_init for Kerbal Space Program.

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 7:41 PM, Francisco Jerez wrote: > This fixes the stripes of garbage rendered on the floor of the vehicle > assembly building among other rendering issues. The reason for the > misrendering seems to be that some of the GLSL shaders used by the >

[Mesa-dev] [PATCH] drirc: Set glsl_zero_init for Kerbal Space Program.

2017-03-29 Thread Francisco Jerez
This fixes the stripes of garbage rendered on the floor of the vehicle assembly building among other rendering issues. The reason for the misrendering seems to be that some of the GLSL shaders used by the application use variables before initializing them, incorrectly assuming that they will be

[Mesa-dev] [PATCH] stash

2017-03-29 Thread Jason Ekstrand
--- src/intel/blorp/blorp_gen4_exec_priv.h | 81 ++ src/intel/blorp/blorp_priv.h | 1 + 2 files changed, 82 insertions(+) diff --git a/src/intel/blorp/blorp_gen4_exec_priv.h b/src/intel/blorp/blorp_gen4_exec_priv.h index 90f9613..b0e4cba 100644 ---

Re: [Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

2017-03-29 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: use glsl_type::sampler_index()

2017-03-29 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util/u_atomic: provide 64bit atomics where they're missing

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 4:13 PM, Grazvydas Ignotas wrote: > There are still some distributions trying to support unfortunate people > with old or exotic CPUs that don't have 64bit atomic operations. When > compiling for such a machine, gcc conveniently inserts a library call to

[Mesa-dev] [PATCH] util/u_atomic: provide 64bit atomics where they're missing

2017-03-29 Thread Grazvydas Ignotas
There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations. When compiling for such a machine, gcc conveniently inserts a library call to a helper, but it's implementation is missing and we get a linker error. This allows

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Chris Wilson
On Wed, Mar 29, 2017 at 04:51:12PM +0100, Chris Wilson wrote: > On Wed, Mar 29, 2017 at 08:36:36AM -0700, Jason Ekstrand wrote: > >On Wed, Mar 29, 2017 at 1:51 AM, Chris Wilson > ><[1]ch...@chris-wilson.co.uk> wrote: > > > diff --git a/src/intel/vulkan/anv_private.h > >

[Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

2017-03-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/compiler/glsl_types.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 405aa3679a..cf0fe71d1a 100644 --- a/src/compiler/glsl_types.cpp +++

[Mesa-dev] [PATCH] st/glsl_to_tgsi: use glsl_type::sampler_index()

2017-03-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 68 +- 1 file changed, 2 insertions(+), 66 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-29 Thread Jose Fonseca
On 28/03/17 22:37, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-28 13:45:57) On 28/03/17 21:32, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-28 09:19:48) On 28/03/17 00:12, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-27 09:58:59) On 27/03/17 17:42, Dylan Baker wrote: Quoting

[Mesa-dev] [PATCH] i965/fs: Gracefully handle TXS on multisampled textures with no LOD

2017-03-29 Thread Jason Ekstrand
This can happen for multisampled textures since they are never mipmapped and textureSize(gsampler2DMS*) does not take an LOD parameter. This fixes a shader validation error in the new Sascha deferredmultisampling demo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100391 Cc: "13.0 17.0"

Re: [Mesa-dev] [PATCH v3] swr: [rasterizer codegen] Fix windows build

2017-03-29 Thread Rowley, Timothy O
Commit comment should not include “[rasterizer codegen]”, as it doesn’t modify that code. With that fixed, Reviewed-by: Tim Rowley > On Mar 28, 2017, at 4:44 PM, George Kyriazis

Re: [Mesa-dev] [PATCH 0/9] RadeonSI cleanups

2017-03-29 Thread Samuel Pitoiset
Patches 1-4 & 7 are: Reviewed-by: Samuel Pitoiset On 03/29/2017 07:58 PM, Marek Olšák wrote: General cleanups and cleanups in preparation for threaded gallium. Please review. Thanks, Marek ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 0/9] RadeonSI cleanups

2017-03-29 Thread Edmondo Tommasina
This series is Tested-by: Edmondo Tommasina On Wed, Mar 29, 2017 at 7:58 PM, Marek Olšák wrote: > General cleanups and cleanups in preparation for threaded gallium. > > Please review. > > Thanks, > Marek >

[Mesa-dev] [PATCH 4/4] radv: Use the guard band.

2017-03-29 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 6 ++- src/amd/vulkan/radv_private.h| 3 +- src/amd/vulkan/si_cmd_buffer.c | 94 +++- 3 files changed, 90 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 1/4] radv: Set proper viewport & scissor for meta draws.

2017-03-29 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_blit.c | 53 -- src/amd/vulkan/radv_meta_blit2d.c | 52 +++-- src/amd/vulkan/radv_meta_clear.c | 54 +--

[Mesa-dev] [PATCH 3/4] radv: Prepare for not using the guard band for lines & points.

2017-03-29 Thread Bas Nieuwenhuizen
Vulkan Clipping is defined in terms of vertices, the scissor based clipping happens on pixels. There is a difference with points and lines, as a vertex can be outside the viewport while some pixels are in. On Vulkan thoise pixels shouldn't be drawn, while they would be with the guardband.

[Mesa-dev] [PATCH 2/4] radv: Drop the default viewport when 0 viewports are given.

2017-03-29 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/si_cmd_buffer.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index 6e50f64a29a..55c82a9a685 100644 ---

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 ovarieg...@yahoo.com changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: fix host memory leak

2017-03-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand And pushed. On Wed, Mar 29, 2017 at 12:14 PM, wrote: > From: Craig Stout > > push_constants must be free'd. > > https://bugs.freedesktop.org/show_bug.cgi?id=100452 > --- >

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Jose Fonseca
On 29/03/17 19:02, Roland Scheidegger wrote: [resend with snipped bits as it's too big] A couple comments inline. [snip] --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c @@ -746,39 +746,30 @@ static void lp_exec_default(struct

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Samuel Pitoiset
On 03/29/2017 11:01 PM, Timothy Arceri wrote: On 30/03/17 06:53, Marek Olšák wrote: The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Correct. I was partly sending this out to see if anyone knew what was going on

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Timothy Arceri
On 30/03/17 06:53, Marek Olšák wrote: The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Correct. I was partly sending this out to see if anyone knew what was going on since Nvidia exposes this on their driver but I

Re: [Mesa-dev] [PATCH] configure.ac: require libdrm_amdgpu 2.4.76 for Vega

2017-03-29 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 03/29/2017 08:23 PM, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab9a91e..70885fb 100644 ---

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: fix dynamic state leak

2017-03-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Mar 29, 2017 at 12:11 PM, wrote: > From: Craig Stout > > anv_state_pool_alloc requires a matching free, whereas > anv_state_stream_alloc will be cleaned up on finish. > > Applies only to 13.0

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #10 from ovarieg...@yahoo.com --- It turns out in my case this is an issue with using pkgconf (Which worked previously) instead of pkg-config. It builds fine with pkg-config. I'd prefer to keep this open until the pkgconf devs have

Re: [Mesa-dev] [PATCH] radv: move to using nir clip/cull merge pass.

2017-03-29 Thread Bas Nieuwenhuizen
Acked-by: Bas Nieuwenhuizen On Wed, Mar 29, 2017 at 7:14 AM, Dave Airlie wrote: > From: Dave Airlie > > Doing this before tessellation makes doing some bits of > tessellation a bit cleaner. It also cleans up a bit of the > llvm

Re: [Mesa-dev] [PATCH] winsys/amdgpu: remove AMDGPU_INFO_NUM_EVICTIONS

2017-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Mar 29, 2017 at 9:06 PM, Samuel Pitoiset wrote: > This is now exposed with libdrm_amdgpu 2.4.76. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Thomas Helland
2017-03-29 21:17 GMT+02:00 Thomas Helland : > 2017-03-29 19:35 GMT+02:00 Bartosz Tomczyk : >> I would be very grateful if someone could help with testing performance >> impact of this change. >> > > Currently prepping some tests on my HTPC,

[Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-29 Thread Lionel Landwerlin
This is pretty much the same tool as what i-g-t has, only with a more fancy decoding of the instructions/registers. It also doesn't support anything before gen4. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.tools.am | 20 +-

[Mesa-dev] [PATCH 2/7] intel: genxml: add GFX_ARB_ERROR_RPT register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 12 src/intel/genxml/gen7.xml | 12 src/intel/genxml/gen75.xml | 13 + src/intel/genxml/gen8.xml | 18 ++ src/intel/genxml/gen9.xml | 18

[Mesa-dev] [PATCH 3/7] intel: genxml: add ACTHD registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen8.xml | 16 src/intel/genxml/gen9.xml | 16 2 files changed, 32 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 91573ae73a..be54748876

[Mesa-dev] [PATCH 1/7] intel: genxml: add INSTDONE registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 110 + src/intel/genxml/gen7.xml | 64 ++ src/intel/genxml/gen75.xml | 71 +

[Mesa-dev] [PATCH 4/7] intel: genxml: add gen7 ERR_INT register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen7.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml index ba9c8e8154..08307b3506 100644 --- a/src/intel/genxml/gen7.xml +++

[Mesa-dev] [PATCH 0/7] Aubinator error decode

2017-03-29 Thread Lionel Landwerlin
Hi, This series introduces a slightly enhanced version of intel_error_decode. Most Mesa developers working on the i965/vulkan drivers may have to deal with hangs related to a specific workload. Having the complete decoding of the instruction stream is quite useful. With the Anv driver genxml

[Mesa-dev] [PATCH 6/7] intel: genxml: add RING_BUFFER_CTL registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 40 +++ src/intel/genxml/gen7.xml | 40 +++ src/intel/genxml/gen75.xml | 54 src/intel/genxml/gen8.xml | 69

[Mesa-dev] [PATCH 5/7] intel: genxml: add FAULT_REG register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 48 ++ src/intel/genxml/gen7.xml | 48 ++ src/intel/genxml/gen75.xml | 64 ++

Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-29 Thread Marek Olšák
I'm OK with this patch. Marek On Wed, Mar 29, 2017 at 12:57 PM, Nicolai Hähnle wrote: > Hi Michal, > > thanks for the patch. That piglit test actually fails on radeonsi as well. > > > On 28.03.2017 22:39, Michal Srb wrote: >> >> st_finalize_texture always accesses image at

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Edmondo Tommasina
This patch helps against the massive performance drop of glthread with Two Worlds. The performance boost in Civ5 is not hurt by this patch. It looks good. Some trivial comments in the patch: On Wed, Mar 29, 2017 at 7:35 PM, Bartosz Tomczyk wrote: > I would be very

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Marek Olšák
The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Marek On Tue, Mar 28, 2017 at 6:35 AM, Timothy Arceri wrote: > There ES is no support for now as this requires > EGL_KHR_create_context_no_error to

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100424 --- Comment #4 from Darren Salt --- … okay, it's looking like the Steam overlay has a lot to do with this problem. (Tested with current Mesa git, but the same LLVM as before.) -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH v2 25/25] radeonsi: enable ARB_sparse_buffer

2017-03-29 Thread Marek Olšák
For patches 13-25: Reviewed-by: Marek Olšák I think the series will also need a newer libdrm than the one required by configure.ac, but my latest configure.ac patch for Vega should address that. Marek On Tue, Mar 28, 2017 at 11:12 AM, Nicolai Hähnle

[Mesa-dev] [PATCH v3 2/2] anv: Query the kernel for reset status

2017-03-29 Thread Jason Ekstrand
When a client causes a GPU hang (or experiences issues due to a hang in another client) we want to let it know as soon as possible. In particular, if it submits work with a fence and calls vkWaitForFences or vkQueueQaitIdle and it returns VK_SUCCESS, then the client should be able to trust the

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 ovarieg...@yahoo.com changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Thomas Helland
2017-03-29 19:35 GMT+02:00 Bartosz Tomczyk : > I would be very grateful if someone could help with testing performance > impact of this change. > Currently prepping some tests on my HTPC, which is a bit CPU-bound. I'll report back in about an hour or so. > On Wed,

[Mesa-dev] [PATCH] anv/cmd_buffer: fix host memory leak

2017-03-29 Thread cstout
From: Craig Stout push_constants must be free'd. https://bugs.freedesktop.org/show_bug.cgi?id=100452 --- src/intel/vulkan/anv_cmd_buffer.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c

[Mesa-dev] [PATCH] anv/cmd_buffer: fix dynamic state leak

2017-03-29 Thread cstout
From: Craig Stout anv_state_pool_alloc requires a matching free, whereas anv_state_stream_alloc will be cleaned up on finish. Applies only to 13.0 branch. x https://bugs.freedesktop.org/show_bug.cgi?id=100365 --- src/intel/vulkan/anv_private.h | 12

[Mesa-dev] [PATCH] winsys/amdgpu: remove AMDGPU_INFO_NUM_EVICTIONS

2017-03-29 Thread Samuel Pitoiset
This is now exposed with libdrm_amdgpu 2.4.76. Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c

Re: [Mesa-dev] [PATCH v2] anv: add support for allocating more than 1 block of memory

2017-03-29 Thread Jason Ekstrand
Looking over the patch, I think I've convinced myself that it's correct. (I honestly wasn't expecting to come to that conclusion without more iteration.) That said, this raises some interesting questions. I added Kristian to the Cc in case he has any input. 1. Should we do powers of two or

[Mesa-dev] [PATCH] configure.ac: require libdrm_amdgpu 2.4.76 for Vega

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab9a91e..70885fb 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,21 @@ OPENCL_VERSION=1 AC_SUBST([OPENCL_VERSION]) # The

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Roland Scheidegger
[resend with snipped bits as it's too big] A couple comments inline. [snip] > --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > @@ -746,39 +746,30 @@ static void lp_exec_default(struct lp_exec_mask *mask, > } > > > /* stores

[Mesa-dev] [PATCH 6/9] radeonsi: handle incompatible DCC formats in resource_copy_region

2017-03-29 Thread Marek Olšák
From: Marek Olšák Required because of later commits. --- src/gallium/drivers/radeonsi/si_blit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index bc5c2d6..ded8beb 100644 ---

[Mesa-dev] [PATCH 7/9] gallium/radeon: s/dcc_disable/disable_dcc/

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 4 ++-- src/gallium/drivers/radeonsi/si_blit.c| 10 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 4 files changed, 9

[Mesa-dev] [PATCH 8/9] radeonsi: decompress DCC in set_framebuffer_state instead of create_surface

2017-03-29 Thread Marek Olšák
From: Marek Olšák for threaded gallium, which can't use pipe_context in create_surface --- src/gallium/drivers/radeon/r600_pipe_common.h | 8 +++ src/gallium/drivers/radeon/r600_texture.c | 33 +++ src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 9/9] radeonsi: decompress DCC in set_sampler_view instead of create_sampler_view

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 14 +++--- src/gallium/drivers/radeonsi/si_pipe.h| 1 + src/gallium/drivers/radeonsi/si_state.c | 7 --- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 3/9] gallium/radeon: formalize that r600_query_hw_add_result doesn't need a context

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_perfcounter.c | 2 +- src/gallium/drivers/radeon/r600_query.c | 13 +++-- src/gallium/drivers/radeon/r600_query.h | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 0/9] RadeonSI cleanups

2017-03-29 Thread Marek Olšák
General cleanups and cleanups in preparation for threaded gallium. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/9] radeonsi: remove a workaround for inexact *8_SNORM blits

2017-03-29 Thread Marek Olšák
From: Marek Olšák All tests pass on Fiji now. This prevents DCC disablement due to incompatible DCC formats due to the fallback. --- src/gallium/drivers/radeonsi/si_blit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 4/9] gallium/radeon: add and use a new helper vi_dcc_enabled

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ src/gallium/drivers/radeon/r600_texture.c | 11 +-- src/gallium/drivers/radeonsi/si_blit.c| 6 ++ src/gallium/drivers/radeonsi/si_descriptors.c | 5 ++---

[Mesa-dev] [PATCH 1/9] gallium/util: use const in u_index_modify helpers

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_index_modify.c | 6 +++--- src/gallium/auxiliary/util/u_index_modify.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_index_modify.c

[Mesa-dev] [PATCH 2/9] radeonsi: don't make a copy of pipe_index_buffer in draw_vbo

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 59 +--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 8:59 AM, Kristian H. Kristensen wrote: > Jason Ekstrand writes: > > > This commit adds support for using the full 48-bit address space on > > Broadwell and newer hardware. Thanks to certain limitations, not all > > objects can

[Mesa-dev] [PATCH v2 2/2] anv: Query the kernel for reset status

2017-03-29 Thread Jason Ekstrand
When a client causes a GPU hang (or experiences issues due to a hang in another client) we want to let it know as soon as possible. In particular, if it submits work with a fence and calls vkWaitForFences or vkQueueQaitIdle and it returns VK_SUCCESS, then the client should be able to trust the

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Bartosz Tomczyk
I would be very grateful if someone could help with testing performance impact of this change. On Wed, Mar 29, 2017 at 7:31 PM, Bartosz Tomczyk < bartosz.tomczy...@gmail.com> wrote: > Call it directly when batch queue is empty. This avoids costly thread > synchronisation. With this fix games

[Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Bartosz Tomczyk
Call it directly when batch queue is empty. This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. --- src/mesa/main/glthread.c | 47 ++- 1 file changed, 34

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 16:27, Marek Olšák wrote: On Wed, Mar 29, 2017 at 12:26 PM, Nicolai Hähnle wrote: On 28.03.2017 21:46, Marek Olšák wrote: On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle TODO fill

Re: [Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 9:11 AM, Bartosz Tomczyk wrote: > This avoids costly thread synchronisation. With this fix games that > previously regressed with mesa_glthread=true like xonotic or grid autosport. > Could someone test if games that benefit from glthread

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 16:51, Marek Olšák wrote: > From: Marek Olšák > > Neved used. > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - >

Re: [Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 18:11, Bartosz Tomczyk wrote: This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? Please make sure the commit

[Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? --- src/mesa/main/glthread.c | 49

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
Hi, Emil, On 03/29/2017 02:34 PM, Emil Velikov wrote: > On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >> Hi, Emil, >> >> On 03/29/2017 01:30 PM, Emil Velikov wrote: >>> Hi Thomas, >>> >>> On 28 March 2017 at 20:39, Thomas Hellstrom wrote:

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 14:28, Philipp Zabel wrote: On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: On 29.03.2017 09:44, Philipp Zabel wrote: Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension.

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Kristian H. Kristensen
Jason Ekstrand writes: > This commit adds support for using the full 48-bit address space on > Broadwell and newer hardware. Thanks to certain limitations, not all > objects can be placed above the 32-bit boundary. In particular, general > and state base address need to

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Chris Wilson
On Wed, Mar 29, 2017 at 08:36:36AM -0700, Jason Ekstrand wrote: >On Wed, Mar 29, 2017 at 1:51 AM, Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Tue, Mar 28, 2017 at 05:41:12PM -0700, Jason Ekstrand wrote: > > This commit adds support for using the full 48-bit address

Re: [Mesa-dev] [PATCH] [RFC] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
Please ignore above patch. On Wed, Mar 29, 2017 at 5:48 PM, Bartosz Tomczyk < bartosz.tomczy...@gmail.com> wrote: > This avoids costly thread synchronisation. With this fix games that > previously regressed with mesa_glthread=true like xonotic or grid autosport. > Could someone test if games

[Mesa-dev] [PATCH] [RFC] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? --- src/mesa/main/glthread.c | 17 + 1 file changed, 13

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 1:51 AM, Chris Wilson wrote: > On Tue, Mar 28, 2017 at 05:41:12PM -0700, Jason Ekstrand wrote: > > This commit adds support for using the full 48-bit address space on > > Broadwell and newer hardware. Thanks to certain limitations, not all > >

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

2017-03-29 Thread Emil Velikov
Hi Jean, On 8 March 2017 at 16:12, Brian Paul wrote: >> >One thing that I would prefer so not see if heavy things like >> Bootstrap. >> >We definitely don't need it, I think writing our own few lines of CSS >> >(which can be inspired by anything you want) is

Re: [Mesa-dev] [PATCH 0/2] nir: Add support for 8 and 16-bit types

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 12:41 AM, Eduardo Lima Mitev wrote: > Both patches need rebase, but look fine otherwise. > The first has already landed (I think). The second definitely needs rebasing. Yesterday, I rebased it on top of the other two constant_expressions fixup patches

Re: [Mesa-dev] [PATCH v3] i965: expose BRW_OPCODE_[F32TO16/F16TO32] name on gen8+

2017-03-29 Thread Matt Turner
Thanks. That looks good. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3] i965: expose BRW_OPCODE_[F32TO16/F16TO32] name on gen8+

2017-03-29 Thread Alejandro Piñeiro
Technically those hw operations are only available on gen7, as gen8+ support the conversion on the MOV. But, when using the builder to implement nir operations (example: nir_op_fquantize2f16), it is not needed to do the gen check. This check is done later, on the final emission at brw_F32TO16

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Alejandro Piñeiro
On 29/03/17 16:15, Matt Turner wrote: > On Wed, Mar 29, 2017 at 4:47 AM, Alejandro Piñeiro > wrote: >> Technically those hw operations are only available on gen7, as gen8+ >> support the conversion on the MOV. But, when using the builder to >> implement nir operations

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-29 Thread Marek Olšák
On Wed, Mar 29, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 28.03.2017 21:46, Marek Olšák wrote: >> >> On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> TODO fill out caps in all

Re: [Mesa-dev] [PATCH] radv: move to using nir clip/cull merge pass.

2017-03-29 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 03/29/2017 04:14 PM, Dave Airlie wrote: > From: Dave Airlie > > Doing this before tessellation makes doing some bits of > tessellation a bit cleaner. It also cleans up a bit of the > llvm generator code. > >

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 4:47 AM, Alejandro Piñeiro wrote: > Technically those hw operations are only available on gen7, as gen8+ > support the conversion on the MOV. But, when using the builder to > implement nir operations (example: nir_op_fquantize2f16), it is not > needed

[Mesa-dev] [PATCH v2] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Alejandro Piñeiro
Technically those hw operations are only available on gen7, as gen8+ support the conversion on the MOV. But, when using the builder to implement nir operations (example: nir_op_fquantize2f16), it is not needed to do the gen check. This check is done later, on the final emission at brw_F32TO16

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Ilia Mirkin
I guess you want GEN_GE(GEN7), no? On Mar 29, 2017 7:48 AM, "Alejandro Piñeiro" wrote: > Technically those hw operations are only available on gen7, as gen8+ > support the conversion on the MOV. But, when using the builder to > implement nir operations (example:

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 13:02, Thomas Hellstrom wrote: > Hi, Emil, > > On 03/29/2017 01:30 PM, Emil Velikov wrote: >> Hi Thomas, >> >> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: >>> Drivers may queue dma operations on the context at unmap time so

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Philipp Zabel
On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: > On 29.03.2017 09:44, Philipp Zabel wrote: > > Stop trying to specify texture or renderbuffer objects for unsupported > > EGL images. Generate the error codes specified in the OES_EGL_image > > extension. > > > > EGLImageTargetTexture2D and

Re: [Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-29 Thread Emil Velikov
On 28 March 2017 at 19:11, Bas Nieuwenhuizen wrote: > On Tue, Mar 28, 2017 at 6:31 PM, Alex Smith > wrote: >> On 28 March 2017 at 17:09, Emil Velikov wrote: >>> >>> On 22 March 2017 at 10:06, Bas Nieuwenhuizen

  1   2   >