[Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v5]

2018-10-17 Thread Keith Packard
Offers three clocks, device, clock monotonic and clock monotonic raw. Could use some kernel support to reduce the deviation between clock values. v2: Ensure deviation is at least as big as the GPU time interval. v3: Set device->lost when returning DEVICE_LOST. Use MAX2

[Mesa-dev] Q: to which software renderers should we contribute to help virgl conformance testing

2018-10-17 Thread Gert Wollny
Dear all, we are looking into doing a CI for virglrenderer that also runs a subset of the GLES dEQP, and in order to be able to run this also in gitlab.fd.o we were looking into the available gallium software renderers. Inital tests by just running the dEQP-GLES2 were quite successful in the

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v5]

2018-10-17 Thread Keith Packard
Jason Ekstrand writes: > I like it When the comments are longer than the code, you know you're done? -- -keith signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
Eric Engestrom writes: > That's absolutely fair :) > > I wanted to ack your patch earlier, since fixing it is good regardless, > but freedreno isn't my area so I didn't feel comfortable doing so; > I changed my mind in the mean time though, so here you go :P > Acked-by: Eric Engestrom > > You

[Mesa-dev] [PATCH 3/3] i965/nir: use vectorization for non-scalar stages

2018-10-17 Thread Jason Ekstrand
From: Connor Abbott Shader-db results on Haswell: total instructions in shared programs: 2180337 -> 2154080 (-1.20%) instructions in affected programs: 959766 -> 933509 (-2.74%) helped: 5653 HURT: 2560 total cycles in shared programs: 12339326 -> 12307102 (-0.26%)

[Mesa-dev] [PATCH 1/3] intel/peephole_ffma: Fix swizzle propagation

2018-10-17 Thread Jason Ekstrand
The num_components value passed into get_mul_for_src is used to only compose the parts of the swizzle that we know will be used so we don't compose invalid swizzle components. However, we had a bug where we passed the number of components of the add all the way through. For the given source, we

[Mesa-dev] [PATCH 2/3] nir: add a vectorization pass

2018-10-17 Thread Jason Ekstrand
From: Connor Abbott This effectively does the opposite of nir_lower_alus_to_scalar, trying to combine per-component ALU operations with the same sources but different swizzles into one larger ALU operation. It uses a similar model as CSE, where we do a depth-first approach and keep around a hash

Re: [Mesa-dev] [PATCH 1/3] mesa/core: Add support for EXT_sRGB_write_control

2018-10-17 Thread Ilia Mirkin
On Wed, Oct 17, 2018 at 12:38 PM Gert Wollny wrote: > > From: Gert Wollny > > This GLES extension gives the applications the control over deciding whether > the conversion from linear space to sRGB is necessary by enabling or > disabling this conversion at framebuffer write or blending time just

[Mesa-dev] [PATCH 2/2] freedreno: Remove the Emacs mode lines

2018-10-17 Thread Neil Roberts
These are not necessary because the corresponding settings are set via the .dir-locals.el file anyway. Most of them were missing a ‘:’ after “tab-width” which was making Emacs display an annoying warning whenever you open the file. This patch was made with: sed -ri '/-\*- mode:/,/^$/d' \

[Mesa-dev] [PATCH 1/2] freedreno: Fix the Emacs indentation configuration file

2018-10-17 Thread Neil Roberts
The .dir-locals.el had the wrong name for the truthy value so it wasn’t setting indent-tabs-mode. --- src/gallium/drivers/freedreno/.dir-locals.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/.dir-locals.el

Re: [Mesa-dev] [PATCH 1/2] radeonsi: fix a VGT hang with primitive restart on Polaris10 and later

2018-10-17 Thread Jakob Bornecrantz
Tested-by: Jakob Bornecrantz On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote: > > From: Marek Olšák > > Cc: 18.1 18.2 > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Eric Engestrom
On Wednesday, 2018-10-17 17:25:22 +0200, Neil Roberts wrote: > Eric Engestrom writes: > > > You might want to remove these instead, and use the .editorconfig [1] > > already present at src/gallium/drivers/freedreno/.editorconfig This is > > much easier to maintain than per-files settings ;) > >

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-17 Thread Jason Ekstrand
On Wed, Oct 17, 2018 at 12:14 AM Keith Packard wrote: > Jason Ekstrand writes: > > > Doing all of the CPU sampling on one side or the other of the GPU > sampling > > would probably reduce our window. > > True, although as I said, it's taking several µs to get through the > loop, and the gpu

Re: [Mesa-dev] [PATCH 1/2] freedreno: Fix the Emacs indentation configuration file

2018-10-17 Thread Ilia Mirkin
Are you sure? It works fine for me... I'm not against fixing it to be "t", but the current contents definitely worked fine for me. (As I recall, I may be the one who checked this file in.) On Wed, Oct 17, 2018 at 11:38 AM Neil Roberts wrote: > > The .dir-locals.el had the wrong name for the

[Mesa-dev] [PATCH 1/2] radeonsi: fix a VGT hang with primitive restart on Polaris10 and later

2018-10-17 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 18.2 --- src/gallium/drivers/radeonsi/si_state_draw.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 83eb646b791..612ca910cb9 100644 ---

[Mesa-dev] [PATCH 2/2] radeonsi: clamp point size to the limit

2018-10-17 Thread Marek Olšák
From: Marek Olšák This fixes dEQP-GLES2.functional.rasterization.limits.points. Broken by: ea039f789d9b54e1bd1d644b6a29863ca3500314 --- src/gallium/drivers/radeonsi/si_get.c | 5 +++-- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 2 +- 3 files

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v5]

2018-10-17 Thread Jason Ekstrand
I like it Reviewed-by: Jason Ekstrand On Wed, Oct 17, 2018 at 11:49 AM Keith Packard wrote: > Offers three clocks, device, clock monotonic and clock monotonic > raw. Could use some kernel support to reduce the deviation between > clock values. > > v2: > Ensure deviation is at least as

[Mesa-dev] [PATCH 0/1] swr: Fix for LLVM 5 to 6 API change

2018-10-17 Thread Alok Hota
This is primarily a fix for the stable branch as it is still packaged with LLVM 5 libs. This fixes a compile error if a user tries to build with LLVM 6+ from an 18.2.x release tarball Alok Hota (1): swr/rast: ignore CreateElementUnorderedAtomicMemCpy

[Mesa-dev] [PATCH 1/1] swr/rast: ignore CreateElementUnorderedAtomicMemCpy

2018-10-17 Thread Alok Hota
This function's API changed between LLVM 5 and 6. Compile errors occur when building with LLVM 6+ if LLVM 5 was used for a dist tarball --- .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] intel/tools: Remove hardcoded PADDING_SIZE from sanitizer

2018-10-17 Thread Danylo Piliaiev
Signed-off-by: Danylo Piliaiev --- src/intel/tools/intel_sanitize_gpu.c | 38 +++- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/intel/tools/intel_sanitize_gpu.c b/src/intel/tools/intel_sanitize_gpu.c index 9b49b0bbf2..36c4725a2f 100644 ---

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
Eric Engestrom writes: > You might want to remove these instead, and use the .editorconfig [1] > already present at src/gallium/drivers/freedreno/.editorconfig This is > much easier to maintain than per-files settings ;) Either fixing it or removing it is fine by me. I now notice there is a

Re: [Mesa-dev] [PATCH 1/2] freedreno: Fix the Emacs indentation configuration file

2018-10-17 Thread Neil Roberts
Ilia Mirkin writes: > Are you sure? It works fine for me... I'm not against fixing it to be > "t", but the current contents definitely worked fine for me. (As I > recall, I may be the one who checked this file in.) Yes, I’m sure. If you type “true” and then do C-x C-e to evaluate it then Emacs

Re: [Mesa-dev] [PATCH 1/2] freedreno: Fix the Emacs indentation configuration file

2018-10-17 Thread Neil Roberts
> On Wed, Oct 17, 2018 at 12:45 PM Neil Roberts wrote: > >> I wonder if you have something else in your setup that is setting it? Ilia Mirkin writes: > Perhaps. It's the default, right? It is the default but the toplevel .dir-locals.el sets it to nil. These lower-level files are trying to

Re: [Mesa-dev] [PATCH 2/3] mesa/st: enable EXT_sRGB_write_control for drivers that support it

2018-10-17 Thread Gert Wollny
Am Mittwoch, den 17.10.2018, 12:56 -0400 schrieb Ilia Mirkin: > On Wed, Oct 17, 2018 at 12:39 PM Gert Wollny > wrote: > > > > From: Gert Wollny > > > > With this patch the extension EXT_sRGB_write_control is enabled for > > gallium drivers that support sRGB formats as render targets. > > > >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: clamp point size to the limit

2018-10-17 Thread Jakob Bornecrantz
Tested-by: Jakob Bornecrantz On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote: > > From: Marek Olšák > > This fixes dEQP-GLES2.functional.rasterization.limits.points. > Broken by: ea039f789d9b54e1bd1d644b6a29863ca3500314 > --- > src/gallium/drivers/radeonsi/si_get.c | 5 +++-- >

Re: [Mesa-dev] [PATCH 1/2] freedreno: Fix the Emacs indentation configuration file

2018-10-17 Thread Ilia Mirkin
On Wed, Oct 17, 2018 at 12:45 PM Neil Roberts wrote: > > Ilia Mirkin writes: > > > Are you sure? It works fine for me... I'm not against fixing it to be > > "t", but the current contents definitely worked fine for me. (As I > > recall, I may be the one who checked this file in.) > > Yes, I’m

[Mesa-dev] [PATCH v2] Fix setting indent-tabs-mode in the Emacs .dir-locals.el files

2018-10-17 Thread Neil Roberts
Some of the .dir-locals.el had the wrong name for the truthy value so it wasn’t setting indent-tabs-mode. --- src/gallium/drivers/freedreno/.dir-locals.el | 2 +- src/gallium/drivers/r600/.dir-locals.el | 2 +- src/gallium/drivers/radeon/.dir-locals.el| 2 +-

Re: [Mesa-dev] [PATCH 0/7] EGLDevice, take 2.1

2018-10-17 Thread Emil Velikov
On Wed, 3 Oct 2018 at 15:08, Emil Velikov wrote: > > Hi all, > > This re-spin of the series includes: > - correct flipped asserts > - cosmetic wording/comment fixes > - drop EGL_EXT_platform_device patches (swrast is broken) > - add the EGL_MESA_device_software spec patch > > At this point we

[Mesa-dev] [PATCH 0/3] Add and enable extension EXT_sRGB_write_control

2018-10-17 Thread Gert Wollny
From: Gert Wollny Dear all, this series adds the basic plumbing for EXT_sRGB_write_control and enables it for some drivers. Since this is the first time I add an extension I'd ask reviews this to take a specific look at the first patch. One thing I left out therefore, is to enable this

[Mesa-dev] [PATCH 3/3] intel/i965: Enable extension EXT_sRGB_write_control

2018-10-17 Thread Gert Wollny
From: Gert Wollny Enables and passes on i965: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* Signed-off-by: Gert Wollny --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c

[Mesa-dev] [PATCH 2/3] mesa/st: enable EXT_sRGB_write_control for drivers that support it

2018-10-17 Thread Gert Wollny
From: Gert Wollny With this patch the extension EXT_sRGB_write_control is enabled for gallium drivers that support sRGB formats as render targets. Tested (and pass) on r600(evergreen) and softpipe: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* with

[Mesa-dev] [PATCH 1/3] mesa/core: Add support for EXT_sRGB_write_control

2018-10-17 Thread Gert Wollny
From: Gert Wollny This GLES extension gives the applications the control over deciding whether the conversion from linear space to sRGB is necessary by enabling or disabling this conversion at framebuffer write or blending time just like it is possible for desktop GL. Signed-off-by: Gert Wollny

Re: [Mesa-dev] [PATCH 2/3] mesa/st: enable EXT_sRGB_write_control for drivers that support it

2018-10-17 Thread Ilia Mirkin
On Wed, Oct 17, 2018 at 12:39 PM Gert Wollny wrote: > > From: Gert Wollny > > With this patch the extension EXT_sRGB_write_control is enabled for > gallium drivers that support sRGB formats as render targets. > > Tested (and pass) on r600(evergreen) and softpipe: > >

Re: [Mesa-dev] [PATCH 1/3] mesa/core: Add support for EXT_sRGB_write_control

2018-10-17 Thread Ilia Mirkin
On Wed, Oct 17, 2018 at 12:49 PM Ilia Mirkin wrote: > On Wed, Oct 17, 2018 at 12:38 PM Gert Wollny wrote: > > diff --git a/src/mesa/main/extensions_table.h > > b/src/mesa/main/extensions_table.h > > index 09bf923bd0..1185156f23 100644 > > --- a/src/mesa/main/extensions_table.h > > +++

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Eric Engestrom
On Wednesday, 2018-10-17 15:48:41 +0200, Neil Roberts wrote: > The modeline was missing a ‘:’ after the tab-width and Emacs was > complaining every time you open a file. This patch was made with: > > sed -ri '1 s/; tab-width ([0-9])/; tab-width: \1/' \ > $(find -name \*.\[ch\] -exec grep -l

Re: [Mesa-dev] [PATCH] intel/tools: Remove hardcoded PADDING_SIZE from sanitizer

2018-10-17 Thread Rafael Antognolli
On Wed, Oct 17, 2018 at 06:08:34PM +0300, Danylo Piliaiev wrote: > Signed-off-by: Danylo Piliaiev > --- > src/intel/tools/intel_sanitize_gpu.c | 38 +++- > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/src/intel/tools/intel_sanitize_gpu.c >

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-17 Thread Marek Olšák
Can you test the attached patch? Marek On Wed, Oct 17, 2018 at 9:31 AM Michel Dänzer wrote: > On 2018-10-07 9:05 a.m., Marek Olšák wrote: > > From: Marek Olšák > > > > Fast color clears should be much faster. Also, fast color clears on > > evicted buffers should be 200x faster on GFX8 and

Re: [Mesa-dev] [PATCH v2] Fix setting indent-tabs-mode in the Emacs .dir-locals.el files

2018-10-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Oct 17, 2018 at 12:51 PM Neil Roberts wrote: > > Some of the .dir-locals.el had the wrong name for the truthy value so > it wasn’t setting indent-tabs-mode. > --- > src/gallium/drivers/freedreno/.dir-locals.el | 2 +- > src/gallium/drivers/r600/.dir-locals.el

Re: [Mesa-dev] Q: to which software renderers should we contribute to help virgl conformance testing

2018-10-17 Thread Roland Scheidegger
Am 17.10.18 um 19:15 schrieb Gert Wollny: > Dear all, > > we are looking into doing a CI for virglrenderer that also runs a > subset of the GLES dEQP, and in order to be able to run this also in > gitlab.fd.o we were looking into the available gallium software > renderers. Inital tests by just

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v5]

2018-10-17 Thread Keith Packard
Bas Nieuwenhuizen writes: > Reviewed-by: Bas Nieuwenhuizen Thanks to you, Jason and Lionel for reviewing the code and helping improve it. -- -keith signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/2] vulkan/wsi: Implement GetPhysicalDevicePresentRectanglesKHR

2018-10-17 Thread Jason Ekstrand
This got missed during 1.1 enabling because it was defined as an interaction between device groups and WSI and it wasn't obvious it was in the delta. The idea behind it is that it's supposed to provide a hint to the application in a multi-GPU setup to indicate which regions of the screen are

[Mesa-dev] [PATCH 1/2] vulkan/wsi: Store the instance allocator in wsi_device

2018-10-17 Thread Jason Ekstrand
We already have wsi_device and we know the instance allocator at wsi_device_init time so there's no need to pass it into the physical device queries. This also fixes a memory allocation domain bug that can occur if CreateSwapchain gets called prior to any queries (not likely) in which case the

[Mesa-dev] [PATCH] radv: use nir_opt_find_array_copies()

2018-10-17 Thread Timothy Arceri
Totals from affected shaders: SGPRS: 1112 -> 1112 (0.00 %) VGPRS: 1492 -> 1196 (-19.84 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 112172 -> 101316 (-9.68 %) bytes LDS: 0 -> 0

Re: [Mesa-dev] [PATCH] radv: use nir_opt_copy_prop_vars and nir_opt_dead_write_vars

2018-10-17 Thread Timothy Arceri
On 18/10/18 9:51 am, Bas Nieuwenhuizen wrote: On Thu, Oct 18, 2018 at 12:04 AM Timothy Arceri wrote: Totals from affected shaders: SGPRS: 2856 -> 2856 (0.00 %) VGPRS: 3236 -> 3248 (0.37 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %)

Re: [Mesa-dev] [PATCH] radv: use nir_opt_find_array_copies()

2018-10-17 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Oct 18, 2018 at 1:00 AM Timothy Arceri wrote: > > Totals from affected shaders: > SGPRS: 1112 -> 1112 (0.00 %) > VGPRS: 1492 -> 1196 (-19.84 %) > Spilled SGPRs: 0 -> 0 (0.00 %) > Spilled VGPRs: 0 -> 0 (0.00 %) > Private memory VGPRs: 0 -> 0 (0.00 %) >

Re: [Mesa-dev] [PATCH 2/2] radv: use nir_shrink_vec_array_vars()

2018-10-17 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. I wonder what the perf diff is for tessellation. See e.g. https://github.com/doitsujin/dxvk/issues/645 for a game where tessellation is hitting us hard. On Thu, Oct 18, 2018 at 1:28 AM Timothy Arceri wrote: > > Totals from affected shaders: >

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v5]

2018-10-17 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Oct 17, 2018 at 6:49 PM Keith Packard wrote: > > Offers three clocks, device, clock monotonic and clock monotonic > raw. Could use some kernel support to reduce the deviation between > clock values. > > v2: > Ensure deviation is at least as big as

Re: [Mesa-dev] [PATCH] radv: use nir_opt_find_array_copies()

2018-10-17 Thread Jason Ekstrand
For full effect, you want to also enable shrink_vec_var_arrays and split_array_vars On Wed, Oct 17, 2018 at 6:00 PM Timothy Arceri wrote: > Totals from affected shaders: > SGPRS: 1112 -> 1112 (0.00 %) > VGPRS: 1492 -> 1196 (-19.84 %) > Spilled SGPRs: 0 -> 0 (0.00 %) > Spilled VGPRs: 0 -> 0

Re: [Mesa-dev] [PATCH] radv: use nir_opt_find_array_copies()

2018-10-17 Thread Jason Ekstrand
and split_struct_vars while you're at it On Wed, Oct 17, 2018 at 6:15 PM Jason Ekstrand wrote: > For full effect, you want to also enable shrink_vec_var_arrays and > split_array_vars > > On Wed, Oct 17, 2018 at 6:00 PM Timothy Arceri > wrote: > >> Totals from affected shaders: >> SGPRS: 1112

[Mesa-dev] [PATCH 2/2] radv: use nir_shrink_vec_array_vars()

2018-10-17 Thread Timothy Arceri
Totals from affected shaders: SGPRS: 1096 -> 1096 (0.00 %) VGPRS: 1192 -> 1056 (-11.41 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 100940 -> 94384 (-6.49 %) bytes LDS: 0 -> 0 (0.00

[Mesa-dev] [PATCH 1/2] radv: use nir_split_array_vars()

2018-10-17 Thread Timothy Arceri
We call in the opt loop in case another pass results in an array with indirect access being turned into direct access. Totals from affected shaders: SGPRS: 512 -> 496 (-3.12 %) VGPRS: 456 -> 452 (-0.88 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0

[Mesa-dev] [PATCH 09/15] st/va: get mjpeg slice header

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 13 +- src/gallium/state_trackers/va/picture_mjpeg.c | 142 ++

[Mesa-dev] [PATCH 08/15] radeon/vcn: add jpeg decode implementation

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 21 ++-- src/gallium/drivers/radeon/radeon_vcn_dec.h

[Mesa-dev] [PATCH 07/15] radeon/vcn: separate send cmd call from end frame

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Use function pointer for sending cmd in end_frame call. By doing this, we can assign different cmd sending logics for Jpeg decode later. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 29 +++--

[Mesa-dev] [PATCH 11/15] radeon/vcn: implement jpeg bitstream buffer cmd

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Implement jpeg bitstream buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang Acked-by: Leo Liu --- .../drivers/radeon/radeon_vcn_dec_jpeg.c | 46 ++- 1 file changed, 45

[Mesa-dev] [PATCH 10/15] radeon/uvd: remove get mjpeg slice header

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 157 1 file changed, 157 deletions(-) diff --git

[Mesa-dev] [PATCH 13/15] amd/common: add vcn jpeg ip info query

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/amd/common/ac_gpu_info.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 766ad83547..8c50738c3f 100644 ---

[Mesa-dev] [PATCH 14/15] winsys/amdgpu: add vcn jpeg cs support

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Add vcn jpeg cs support, align cs by no-op. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

[Mesa-dev] [PATCH 12/15] radeon/vcn: implement jpeg target buffer cmd

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Implement jpeg target buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang Acked-by: Leo Liu --- .../drivers/radeon/radeon_vcn_dec_jpeg.c | 73 ++- 1 file changed, 72 insertions(+), 1

[Mesa-dev] [Bug 107765] [regression] Batman Arkham City crashes with DXVK under wine

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107765 --- Comment #13 from farmboy0+freedesk...@googlemail.com --- Can you tell me what settings you use? Do you use a 64 bit prefix? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 1/1] swr/rast: ignore CreateElementUnorderedAtomicMemCpy

2018-10-17 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 17, 2018, at 1:51 PM, Alok Hota wrote: > > This function's API changed between LLVM 5 and 6. Compile errors occur > when building with LLVM 6+ if LLVM 5 was used for a dist tarball > --- > .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3

[Mesa-dev] [PATCH] radv: use nir_opt_copy_prop_vars and nir_opt_dead_write_vars

2018-10-17 Thread Timothy Arceri
Totals from affected shaders: SGPRS: 2856 -> 2856 (0.00 %) VGPRS: 3236 -> 3248 (0.37 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 236560 -> 233548 (-1.27 %) bytes LDS: 0 -> 0 (0.00

Re: [Mesa-dev] [PATCH] radv: use nir_opt_copy_prop_vars and nir_opt_dead_write_vars

2018-10-17 Thread Bas Nieuwenhuizen
On Thu, Oct 18, 2018 at 12:04 AM Timothy Arceri wrote: > > Totals from affected shaders: > SGPRS: 2856 -> 2856 (0.00 %) > VGPRS: 3236 -> 3248 (0.37 %) > Spilled SGPRs: 0 -> 0 (0.00 %) > Spilled VGPRs: 0 -> 0 (0.00 %) > Private memory VGPRs: 0 -> 0 (0.00 %) > Scratch size: 0 -> 0 (0.00 %) dwords

Re: [Mesa-dev] [PATCH 00/15] A bunch of shared code and RadeonSI changes

2018-10-17 Thread Dieter Nützel
GREAT work Marek! Best speed up for months on Polaris 20, at least. Coming from vacation with injured right ankle joint, so I haven't had time for testing before commit. But 'glmark2' numbers are better than before all the Spectre shit (~8-9%?!). In German: 'Da geht noch was...' ;-)

[Mesa-dev] [PATCH 01/15] configure.ac: update libdrm amdgpu version to 2.4.95

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang VCN jpeg requires new hw ip Signed-off-by: Boyuan Zhang --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 520948b051..5fd7d8510d 100644 --- a/configure.ac +++ b/configure.ac @@ -74,7 +74,7 @@

[Mesa-dev] [PATCH v2 1/1] swr/rast: ignore CreateElementUnorderedAtomicMemCpy

2018-10-17 Thread Alok Hota
This function's API changed between LLVM 5 and 6. Compile errors occur when building with LLVM 6+ if LLVM 5 was used for a dist tarball CC: --- .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 0/1] swr: Fix for LLVM 5 to 6 API change

2018-10-17 Thread Alok Hota
This patch fixes a compile error resulting from a function whose API changed between LLVM versions 5 and 6. I sent this to mesa-dev, but it's primarly a fix for the stable branch as it affects releases with LLVM 5-based codegen. v2: included mesa-stable cc Alok Hota (1): swr/rast: ignore

[Mesa-dev] [PATCH 06/15] radeon/vcn: create cs based on ring type

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Add RING_VCN_JPEG for VCN Jpeg decode, and keep RING_VCN_DEC for other codecs. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 05/15] radeon/winsys: add vcn jpeg ring type

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Add a new ring type for vcn jpeg. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h

[Mesa-dev] [PATCH 04/15] radeon/vcn: add vcn jpeg decode interface

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Add VCN Jpeg decode interfaces and register defines. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.h | 90 + 1 file changed, 90 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.h

[Mesa-dev] [PATCH 03/15] radeon/vcn: move radeon decoder define to header file

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Move radeon_decoder definition from "radeon_vcn_dec.c" to "radeon_vcn_dec.h", so that it can be included by other files later. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 31

[Mesa-dev] [PATCH 02/15] meson: update required amdgpu version to 2.4.95

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang VCN jpeg requires new hw ip Signed-off-by: Boyuan Zhang --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 002ce35a60..35e3e934a3 100644 --- a/meson.build +++ b/meson.build @@ -1108,7 +1108,7 @@

[Mesa-dev] [PATCH 15/15] radeonsi: enable vcn jpeg decode for raven

2018-10-17 Thread boyuan.zhang
From: Boyuan Zhang Enable vcn jpeg decode for raven. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index

[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108355 Hadrien Nilsson changed: What|Removed |Added Component|Drivers/Gallium/softpipe|Drivers/Gallium/swr --- Comment #7

[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108355 Michel Dänzer changed: What|Removed |Added Attachment #142059|text/x-log |text/plain mime type|

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #22 from Samuel Pitoiset --- Patch available here https://reviews.llvm.org/D53359 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Bas Nieuwenhuizen
On Wed, Oct 17, 2018 at 5:49 AM Timothy Arceri wrote: > > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324, ssa_391 > > Can be simplified to:

[Mesa-dev] [PATCH] intel/compiler: fix node interference of simd16 instructions

2018-10-17 Thread Iago Toral Quiroga
SIMD16 instructions need to have additional interferences to prevent source / destination hazards when the source and destination registers are off by one register. While we already have code to handle this, it was only running for SIMD16 dispatches, however, we can have SIDM16 instructions in a

[Mesa-dev] [Bug 108105] [DXVK] Dauntless Helmets rendering incorrectly on Vega, works in AMDVLK

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108105 --- Comment #13 from Samuel Pitoiset --- Patch available here https://reviews.llvm.org/D53359 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [RFC 4/7] spirv: Insert barriers to follow the Vulkan memory model

2018-10-17 Thread Iago Toral
On Mon, 2018-09-10 at 13:04 -0500, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 170 ++ > > 1 file changed, 103 insertions(+), 67 deletions(-) > (...) > @@ -2516,6 +2600,9 @@ vtn_handle_image(struct vtn_builder *b, SpvOp > opcode, > } else {

[Mesa-dev] [PATCH 2/3] gallium: Fix improper include guard

2018-10-17 Thread janisozaur
From: Michał Janiszewski Signed-off-by: Michał Janiszewski --- src/gallium/state_trackers/glx/xlib/xm_api.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.h b/src/gallium/state_trackers/glx/xlib/xm_api.h index

[Mesa-dev] [PATCH 1/3] gallium: Fix mismatched ifdef-guards

2018-10-17 Thread janisozaur
From: Michał Janiszewski Signed-off-by: Michał Janiszewski --- src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h

[Mesa-dev] [PATCH 3/3] mesa: Add missed include guards

2018-10-17 Thread janisozaur
From: Michał Janiszewski Signed-off-by: Michał Janiszewski --- src/compiler/glsl/ir_builder.h| 5 + src/gallium/drivers/svga/include/svga3d_surfacedefs.h | 5 + src/gallium/winsys/svga/drm/vmw_shader.h | 1 + src/glx/dri2_priv.h

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2018-10-17 at 14:49 +1100, Timothy Arceri wrote: > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324,

[Mesa-dev] [PATCH] freedreno: allocate batches from the cache in launch_grid

2018-10-17 Thread Hyunjun Ko
Needs to allocate batches from the cache so that it could get a valid index and make resource dependancy tracking right. And it doesn't need to flush the batch in each launch_grid from this approach. Also it could make it avoid potential memory leak of the batches. In addition this fixes

[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108355 --- Comment #6 from Michel Dänzer --- Does it still happen with xf86-video-amdgpu 18.1.0? Does amdgpu.dc=0 on the kernel command line avoid the problem? -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [PATCH 3/3] anv: Implement VK_EXT_conditional_rendering for gen 7.5+

2018-10-17 Thread Danylo Piliaiev
Conditional rendering affects next functions: - vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect - vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR - vkCmdDispatch, vkCmdDispatchIndirect, vkCmdDispatchBase - vkCmdClearAttachments To reduce readings from the

[Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

2018-10-17 Thread Danylo Piliaiev
This series implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering extensions. They are implemented together because they are highly interweaved. There are already tests in VK_CTS for VK_KHR_draw_indirect_count and I made a pull request with the tests for

[Mesa-dev] [PATCH 1/3] anv: Implement VK_KHR_draw_indirect_count for gen 7.5+

2018-10-17 Thread Danylo Piliaiev
Signed-off-by: Danylo Piliaiev --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/genX_cmd_buffer.c | 155 + 2 files changed, 156 insertions(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index

[Mesa-dev] [PATCH 2/3] anv: Implement VK_KHR_draw_indirect_count for gen 7

2018-10-17 Thread Danylo Piliaiev
Without MI_MATH we are forced to load MI_PREDICATE_SRC0 from memory on every predicate emission. Signed-off-by: Danylo Piliaiev --- src/intel/vulkan/anv_extensions.py | 2 +- src/intel/vulkan/genX_cmd_buffer.c | 12 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2018-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #17 from Sergii Romantsov --- Hello, Fabian. Unfortunately, probably, no one will be interest in that fix in the Mesa so much. The reason: actually issue is in the game. Specification doesn't specify exact way how to handle it. So

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Timothy Arceri
On 17/10/18 8:49 pm, Bas Nieuwenhuizen wrote: On Wed, Oct 17, 2018 at 5:49 AM Timothy Arceri wrote: For example: vec1 32 ssa_386 = feq ssa_333.x, ssa_6 vec1 32 ssa_387 = feq ssa_333.x, ssa_2 vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 vec1 32 ssa_396 = bcsel ssa_386,

Re: [Mesa-dev] [PATCH] radv: Add support for VK_KHR_driver_properties.

2018-10-17 Thread Alex Smith
This patch never landed in git, is that intentional? On Mon, 1 Oct 2018 at 17:46, Jason Ekstrand wrote: > On Sun, Sep 30, 2018 at 1:04 PM Bas Nieuwenhuizen > wrote: > >> --- >> src/amd/vulkan/radv_device.c | 27 +++ >> src/amd/vulkan/radv_extensions.py | 1 + >>

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-17 Thread Daniel Stone
On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote: > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > + \item Support free and open source projects through the > > freedesktop.org > > + infrastructure. For projects outside the scope of item (\ref{1}) > > support > >

[Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
The modeline was missing a ‘:’ after the tab-width and Emacs was complaining every time you open a file. This patch was made with: sed -ri '1 s/; tab-width ([0-9])/; tab-width: \1/' \ $(find -name \*.\[ch\] -exec grep -l -- '-\*- mode:' {} \+) ---

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-17 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote: > > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > > + \item Support free and open source projects through the > > > freedesktop.org > > > + infrastructure.

[Mesa-dev] [PATCH 1/2] freedreno: adds nondraw param to fd_bc_alloc_batch

2018-10-17 Thread Hyunjun Ko
Needs to specify nondraw when creating a batch through fd_bc_alloc_batch since it'd better create a batch through it rather than fd_batch_create. --- src/gallium/drivers/freedreno/a6xx/fd6_blitter.c | 2 +- src/gallium/drivers/freedreno/freedreno_batch_cache.c | 6 +++---

[Mesa-dev] [PATCH 2/2] freedreno: allocate batches from the cache in launch_grid

2018-10-17 Thread Hyunjun Ko
Needs to allocate batches from the cache so that it could get a valid index and make resource dependancy tracking right. In addition this fixes assertion on debug build since the commit 1a40faa8 landed. --- src/gallium/drivers/freedreno/freedreno_draw.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-17 Thread Michel Dänzer
On 2018-10-07 9:05 a.m., Marek Olšák wrote: > From: Marek Olšák > > Fast color clears should be much faster. Also, fast color clears on > evicted buffers should be 200x faster on GFX8 and older. Nice! Unfortunately, this broke clover with radeonsi. Everything using OpenCL seems to hang, see