[Mingw-w64-public] [PATCH] include: Move headers from direct-x/include/ to include/.

2019-12-18 Thread Jacek Caban
Signed-off-by: Jacek Caban --- The history of separated dir predates my involvement in the project, so I can only guess original reasoning. Those days WindowsSDK includes and depends on DX headers, so keeping it as an optional "SDK" does not seem sensible. This patch moves file

Re: [Mingw-w64-public] Incorrect GUID definitions in mfidl.h

2019-12-11 Thread Jacek Caban
On 12/11/19 12:44 PM, Liu Hao wrote: 在 2019/12/10 19:17, Jacek Caban 写道: On 12/10/19 12:10 PM, Liu Hao wrote: You could just use make include/mfidl.h if you use configure with --with-widl. This uses -DBOOL=WINBOOL when generating headers. IDL files should use BOOL, not WINBOOL, and leave

Re: [Mingw-w64-public] Incorrect GUID definitions in mfidl.h

2019-12-10 Thread Jacek Caban
On 12/10/19 12:10 PM, Liu Hao wrote: 在 2019/12/10 18:42, Eric Hassold 写道: Hi all, Tracking issue with one small program using Media Foundation was failing at runtime only if compiled with Mingw, I found out that definitions for some GUID in mfidl.h are incorrect (or mixed, with one ID getting

Re: [Mingw-w64-public] Generating new directx headers

2019-12-08 Thread Jacek Caban
Hi Zach, On 08/12/2019 16:17, Zach Bacon wrote: At this moment I'm looking at possibly including new directx headers namely 12, and I'm curious as to the process, would one begin with working on compatible headers first or the idl files? Those are already present in Wine, we may just

Re: [Mingw-w64-public] [PATCH] Header Additions

2019-12-06 Thread Jacek Caban
Hi Tom, Patches look good, I pushed them. Thanks, Jacek On 12/3/19 10:57 PM, Tom Ritter wrote: Okay, the attached fixes that issue, I think this is ready now. -tom On Tue, 3 Dec 2019 at 12:46, Tom Ritter wrote: Hm. I haven't debugged this yet; but apparently something is still missing:

[Mingw-w64-public] [PATCH] wincrypt.h: Add missing CERT_CHAIN_* flags.

2019-11-04 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/include/wincrypt.h | 4 1 file changed, 4 insertions(+) diff --git a/mingw-w64-headers/include/wincrypt.h b/mingw-w64-headers/include/wincrypt.h index 7425823f..0e84a351 100644 --- a/mingw-w64-headers/include/wincrypt.h +++ b/mingw-w64

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-04 Thread Jacek Caban
On 02/11/2019 15:46, Biswapriyo Nath wrote: Thank you for the help. I've sent the patch in Wine devel mailing list. Two questions: 1. If I want to improve a file which is in wine-import.sh shell script, should I send patch twice -- one for mingw-w64 and one for wine-devel? Sending to

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-03 Thread Jacek Caban
On 03/11/2019 02:01, Liu Hao wrote: 在 2019/11/3 2:06, Jacek Caban 写道: No, only if you touch files imported from Wine. See wine-import.sh script if you're unsure if it's from Wine. How do we know whether a specific header is imported from Wine or not? By checking Git logs I presume? Yes

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Jacek Caban
On 02/11/2019 10:08, Biswapriyo Nath wrote: Apology for any mistake. I didn't know any upstream-downstream relationship between wine and mingw-w64 repository. Some points: * If there any improvement need for mingw-w64 should I **always** send a patch to wine then mingw-w64? No, only if you

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Jacek Caban
Hi Biswapriyo, This patch is for a file imported from Wine. We have a script importing things from Wine and such changes would ideally go to Wine and be imported back to mingw-w64. Please consider upstreaming your changes to Wine. This was already committed to mingw-w64, so until they are in

Re: [Mingw-w64-public] [PATCH] headers: Don't use __gnu_inline__ with __mingw_ovr in C++ mode

2019-09-04 Thread Jacek Caban
On 03/09/2019 08:39, Martin Storsjö wrote: In C++ mode, __mingw_ovr is a plain "inline" without "static". Clang emits a standalone copy of functions in C++ for the combination of non-static inline and __gnu_inline__, leading to multiple definitions of symbols. I'm fine with this patch, but

Re: [Mingw-w64-public] [PATCH] headers: Default to the legacy wide string mode for ucrtbase, unless __USE_MINGW_ANSI_STDIO is defined

2019-09-01 Thread Jacek Caban
On 31/08/2019 23:08, Martin Storsjö wrote: Apparently we were both mistaken with regard to this; even in the latest MSVC 2019, the default for wide stdio functions still is the legacy, C99 incompatible behaviour (where %s in a wide function means a wchar_t pointer). And that makes the whole

Re: [Mingw-w64-public] [PATCH] shobjidl.idl: added definition for FOS_SUPPORTSTREAMABLEITEMS to FILEOPENDIALOGOPTIONS enum

2019-08-01 Thread Jacek Caban
On 7/31/19 9:18 PM, Richard Pospesel wrote: Signed-off-by: Richard Pospesel --- mingw-w64-headers/include/shobjidl.h | 8 +--- mingw-w64-headers/include/shobjidl.idl | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) I pushed the patch to git. Thanks, Jacek

Re: [Mingw-w64-public] [PATCH] shobjidl.idl: added definition for FOS_SUPPORTSTREAMABLEITEMS to FILEOPENDIALOGOPTIONS enum

2019-07-31 Thread Jacek Caban
On 01/08/2019 01:44, JonY via Mingw-w64-public wrote: On 7/31/19 7:18 PM, Richard Pospesel wrote: Signed-off-by: Richard Pospesel --- mingw-w64-headers/include/shobjidl.h | 8 +--- mingw-w64-headers/include/shobjidl.idl | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) diff

Re: [Mingw-w64-public] [PATCH] crt: Make a compat ___mb_cur_max_func on i386, to avoid forcing a dependency on XP

2019-07-16 Thread Jacek Caban
On 7/16/19 11:31 AM, Martin Storsjö wrote: Before b1634783c20dbae, we never used ___mb_cur_max_func() (available in msvcrt.dll since XP). Since that commit (done to unify things between msvcrt and ucrt), any use of MB_CUR_MAX uses this function. Therefore, make libmsvcrt-os.a for i386 provide

Re: [Mingw-w64-public] MB_CUR_MAX breaks 2K/NT4 applications

2019-07-16 Thread Jacek Caban
On 7/16/19 8:52 AM, Martin Storsjö wrote: On Mon, 15 Jul 2019, Gravis wrote: So apparently, two years ago, someone decided to break all Windows 2K/NT4 applications that use MB_CUR_MAX.  See also: https://sourceforge.net/p/mingw-w64/mailman/message/36107291/ As reasoned in the mail you

Re: [Mingw-w64-public] Missing include in uuid.c

2019-07-02 Thread Jacek Caban
On 7/2/19 4:42 PM, Tom Ritter wrote: The attached patch fixes an error from the recent commit for netlistmgr.h Pushed. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 7/2/19 1:35 PM, LRN wrote: On 02.07.2019 13:42, Jacek Caban wrote: On 02/07/2019 12:38, LRN wrote: On 02.07.2019 13:15, Jacek Caban wrote: On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 12:38, LRN wrote: On 02.07.2019 13:15, Jacek Caban wrote: On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership and are not unique identifiers); thread IDs (as `DWORD` or `unsigned long

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership and are not unique identifiers); thread IDs (as `DWORD` or `unsigned long`) would be a better alternative. This was

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-06-28 Thread Jacek Caban
Hi Eric, On 6/28/19 3:42 PM, NightStrike wrote: FYI, Eric posted this today to the GCC patches list. This may be of great interest to many who would prefer native threads instead of the winpthreads posix style interface. Great work, Eric! I look forward to trying this out! --

Re: [Mingw-w64-public] [PATCH] librpcrt4.a: Drop @0 suffix from varargs functions.

2019-06-20 Thread Jacek Caban
On 6/20/19 8:09 PM, Biswapriyo Nath wrote: Can you add a little comment upon those changes? It may help future contributions not to modify those and. I'm not sure if there is a place to put them. If I added comments to rpcrt4 importlib, that won't help someone changing other DLLs. It would

[Mingw-w64-public] [PATCH v2] librpcrt4.a: Drop @0 suffix from varargs functions.

2019-06-20 Thread Jacek Caban
Fixes a regression introduced by 047f934150cf5d14f7148ae12974c527a94bcca9 Signed-off-by: Jacek Caban --- mingw-w64-crt/lib32/rpcrt4.def | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/mingw-w64-crt/lib32/rpcrt4.def b/mingw-w64-crt/lib32/rpcrt4.def

[Mingw-w64-public] [PATCH] librpcrt4.a: Drop @0 suffix from varargs functions.

2019-06-20 Thread Jacek Caban
Fixes a regression introduced by 047f934150cf5d14f7148ae12974c527a94bcca9 Signed-off-by: Jacek Caban --- mingw-w64-crt/lib32/rpcrt4.def | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/mingw-w64-crt/lib32/rpcrt4.def b/mingw-w64-crt/lib32/rpcrt4.def index

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-06-06 Thread Jacek Caban
On 6/5/19 9:42 PM, Martin Storsjö wrote: On Wed, 5 Jun 2019, Francois Gouget wrote: 3. Build a few projects - to make sure they build. Wine, Wine Gecko, VLC should give a good coverage. That sounds like long running tasks so we will likely need new hardware so the TestBot can run them for

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-06-06 Thread Jacek Caban
On 6/5/19 8:21 AM, Francois Gouget wrote: 3. Build a few projects - to make sure they build. Wine, Wine Gecko, VLC should give a good coverage. That sounds like long running tasks so we will likely need new hardware so the TestBot can run them for every patch that gets submitted: if patches

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-06-03 Thread Jacek Caban
On 22/05/2019 21:45, Jacek Caban wrote: - Testing Wine has a TestBot and a number of test cases, which is a great tool for developers to make sure their patches are right. mingw-w64 does not have such thing and mostly depends on developers doing their own testing and regression reports

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-06-03 Thread Jacek Caban
On 22/05/2019 21:45, Jacek Caban wrote: - Source code sharing Technically, we could share much more code than we currently do. Duplicating efforts is quite suboptimal for everyone. Right now mingw-w64 imports a number of platform headers and widl tool from Wine via wine-import.sh script

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-06-03 Thread Jacek Caban
On 22/05/2019 21:45, Jacek Caban wrote: - mingw-w64 name There have been talks about rebranding mingw-w64 for a long time (longer than I am in joined the project). While it's a good name for a branch, an established project that is no longer related to mingw.org could have a better branding

Re: [Mingw-w64-public] Patches for various headers

2019-05-23 Thread Jacek Caban
On 5/23/19 5:28 AM, Tom Ritter wrote: On Wed, 22 May 2019 at 16:53, Jacek Caban wrote: [Fixes] Thanks! Here are updated versions. Those look good, pushed to git. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-05-23 Thread Jacek Caban
On 5/23/19 9:22 AM, Biswapriyo Nath wrote: Thank you for this great idea. I agree with the cooperation. But I have some questions and concerns. 1. What will happen to all the mails, patches, users contributions, issues, releases etc.? If we move ML, it would go to new ML. Same for issues.

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-05-23 Thread Jacek Caban
On 5/23/19 11:52 AM, NightStrike wrote: On Wed, May 22, 2019 at 3:44 PM Jacek Caban wrote: Hi all, [I'm addressing it to both mingw-w64-public and wine-devel] As most of you know, Wine and mingw-w64 have a lot in common and cooperate to some extend for quite a while. There have been talks

Re: [Mingw-w64-public] Wine and mingw-w64 cooperation

2019-05-22 Thread Jacek Caban
Hi Ruben, On 22/05/2019 22:17, Ruben Van Boxem wrote: All this probably is a great idea :). I just have (entirely worthless) 2c two share on one point you bring up: Thanks for sharing the opinion, it's definitely not worthless ;) Op wo 22 mei 2019 om 21:44 schreef Jacek Caban : - mingw

[Mingw-w64-public] Wine and mingw-w64 cooperation

2019-05-22 Thread Jacek Caban
Hi all, [I'm addressing it to both mingw-w64-public and wine-devel] As most of you know, Wine and mingw-w64 have a lot in common and cooperate to some extend for quite a while. There have been talks about tightening this relationship for years. Recent Wine move to using PE files for its

Re: [Mingw-w64-public] Patches for various headers

2019-05-22 Thread Jacek Caban
Hi Tom, I committed specstrings.h patch. On 5/22/19 6:12 PM, Tom Ritter wrote: +#define_Benign_race_begin_ __pragma(warning(push)) +#define_Benign_race_end_ __pragma(warning(pop)) +#define_No_competing_thread_begin_ __pragma(warning(push)) +#define_No_competing_thread_end_

Re: [Mingw-w64-public] [PATCH] crt: Call the right function for newmode from ucrtbase's __getmainargs

2019-05-20 Thread Jacek Caban
Hi Martin, The patch looks good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:11 PM, Martin Storsjö wrote: On Fri, 17 May 2019, Jacek Caban wrote: I see it now. The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. If I remove them, it behaves correctly. Do you remember it's called there? Note that crtexe.c already

Re: [Mingw-w64-public] [PATCH] crt: Don't call __set_app_type from ucrtbase's __getmainargs

2019-05-17 Thread Jacek Caban
Signed-off-by: Jacek Caban ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:02 PM, Jacek Caban wrote: The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. I obviously meant ucrtbase_compat.c. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 9:21 PM, Martin Storsjö wrote: On Fri, 17 May 2019, Jacek Caban wrote: On 5/17/19 10:44 AM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64

Re: [Mingw-w64-public] Update OpenGL headers

2019-05-17 Thread Jacek Caban
On 5/17/19 12:42 PM, LRN wrote: On 10.05.2019 16:28, LRN wrote: On 10.05.2019 15:53, NightStrike wrote: On Fri, May 10, 2019, 5:24 AM LRN wrote: TBH, i'm starting to think that we should radically cut the GL headers down and only ship GL.h and GLU.h, just like MS does (and also glaux.h,

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:44 AM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am |  2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in

Re: [Mingw-w64-public] [PATCH 1/2] include/ddk: Synchronize with ReactOS (1/2).

2019-05-14 Thread Jacek Caban
On 5/14/19 7:46 AM, Liu Hao wrote: 在 2019/5/10 21:31, Jacek Caban 写道: On 5/8/19 4:08 AM, Liu Hao wrote: All DDK headers have been copied from <https://github.com/reactos/reactos/tree/master/sdk/include/ddk>. There are quite a few new headers which will be added later. This commit contai

Re: [Mingw-w64-public] [PATCH 1/2] include/ddk: Synchronize with ReactOS (1/2).

2019-05-10 Thread Jacek Caban
On 5/8/19 4:08 AM, Liu Hao wrote: All DDK headers have been copied from . There are quite a few new headers which will be added later. This commit contains all headers that have been modified. What did you do about mingw-w64

Re: [Mingw-w64-public] [PATCH 2/2] crt: Merge msvcr120_app.def.in for 32 and 64 bit x86

2019-05-09 Thread Jacek Caban
On 5/6/19 2:24 PM, Martin Storsjö wrote: Also add differences for the arm32 version of the dll into the merged file. Signed-off-by: Martin Storsjö --- mingw-w64-crt/Makefile.am|8 +- mingw-w64-crt/lib-common/msvcr120_app.def.in | 2536 ++

Re: [Mingw-w64-public] [PATCH 1/2] crt: Provide an empty implementation of __set_app_type for msvcr120_app.dll

2019-05-09 Thread Jacek Caban
On 5/6/19 2:24 PM, Martin Storsjö wrote: This dll doesn't provide this function, but making it an empty no-op function should be fine. This somewhat allows running exes linked against this dll; the previous incorrect declaration of this function in the def files allowed compiling projects

Re: [Mingw-w64-public] [PATCH] headers: Use the msvcrt/ucrt setjmp functions on ARM64 is SEH is available

2019-05-09 Thread Jacek Caban
On 5/7/19 9:41 AM, Martin Storsjö wrote: This requires using a new builtin intrinsic __builtin_sponentry(), which was added in Clang 9. Signed-off-by: Martin Storsjö --- The new intrinsic was added yesterday. After some time we could remove the fallback setjmp/longjmp for ARM64, assuming that

Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

2019-05-06 Thread Jacek Caban
On 5/6/19 1:10 PM, Martin Storsjö wrote: On Mon, 6 May 2019, Jacek Caban wrote: Hi Martin, All patches look good to me. Thanks! So you agree that it should practically be safe to change the value of this define and very few external users should be hit by the change? (In practice I have

Re: [Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Jacek Caban
On 5/6/19 1:08 PM, Martin Storsjö wrote: On Mon, 6 May 2019, Jacek Caban wrote: On 5/6/19 11:18 AM, Martin Storsjö wrote: UCRT is handled in a separate ifdef further above. The patch looks good, but I'm curious about possible future changes. It seems tempting to use UCRT variant for all

Re: [Mingw-w64-public] [PATCH] crt: Add an implementation of gets() for msvcrt.dll for arm/arm64

2019-05-06 Thread Jacek Caban
Looks good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

2019-05-06 Thread Jacek Caban
Hi Martin, All patches look good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Jacek Caban
On 5/6/19 11:18 AM, Martin Storsjö wrote: UCRT is handled in a separate ifdef further above. The patch looks good, but I'm curious about possible future changes. It seems tempting to use UCRT variant for all crts (except problematic ARMs that have dedicated branch anyway) to unify builds

Re: [Mingw-w64-public] [PATCH 3/3] winstorecompat: Remove the getpid fallback

2019-04-15 Thread Jacek Caban
On 4/15/19 3:10 PM, Martin Storsjö wrote: All CRT variants should provide getpid in some form now. Both this series and arm series look good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.

2019-04-15 Thread Jacek Caban
On 4/15/19 3:03 PM, Martin Storsjö wrote: On Mon, 15 Apr 2019, Jacek Caban wrote: On 3/29/19 4:34 PM, Jacek Caban wrote: Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. Signed-off-by: Jacek Caban ---  mingw-w64-crt/crt/mingw_helpers.c  | 23 ---  mingw

Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.

2019-04-15 Thread Jacek Caban
On 3/29/19 4:34 PM, Jacek Caban wrote: Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. Signed-off-by: Jacek Caban ---  mingw-w64-crt/crt/mingw_helpers.c  | 23 ---  mingw-w64-crt/include/internal.h   |  4  mingw-w64-crt/lib32/msvcr90.def.in |  4

Re: [Mingw-w64-public] [PATCH] crt: Implement a fallback _getpid function for msvcrt.dll for arm/arm64

2019-04-15 Thread Jacek Caban
On 4/15/19 1:56 PM, Martin Storsjö wrote: On Mon, 15 Apr 2019, Jacek Caban wrote: Hi Martin, On 15/04/2019 12:50, Martin Storsjö wrote: Signed-off-by: Martin Storsjö ---   mingw-w64-crt/Makefile.am   |  6 --   mingw-w64-crt/misc/_getpid.c    | 18 ++   mingw-w64

Re: [Mingw-w64-public] [PATCH] crt: Implement a fallback _getpid function for msvcrt.dll for arm/arm64

2019-04-15 Thread Jacek Caban
Hi Martin, On 15/04/2019 12:50, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- mingw-w64-crt/Makefile.am | 6 -- mingw-w64-crt/misc/_getpid.c| 18 ++ mingw-w64-headers/crt/process.h | 4 3 files changed, 22 insertions(+), 6 deletions(-)

[Mingw-w64-public] [PATCH 1/2] pthread_unistd.h: Don't define _POSIX_THREAD_SAFE_FUNCTIONS.

2019-04-12 Thread Jacek Caban
Leave it up to time.h. Signed-off-by: Jacek Caban --- .../winpthreads/include/pthread_unistd.h | 20 --- 1 file changed, 20 deletions(-) diff --git a/mingw-w64-libraries/winpthreads/include/pthread_unistd.h b/mingw-w64-libraries/winpthreads/include/pthread_unistd.h

[Mingw-w64-public] [PATCH 2/2] time.h: Use __forceinline for *_r functions.

2019-04-12 Thread Jacek Caban
This partially reverts 6988d73a95fbbd97a0bdbb517008cf18f4eb5f02. Some projects have their own static inline implementations that conflict with ours. Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/time.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mingw-w64-public] [PATCH] winstorecompat: Remove no longer needed _wassert.

2019-04-11 Thread Jacek Caban
We no longer have the problematic _wassert in mingwex. Signed-off-by: Jacek Caban --- .../winstorecompat/Makefile.am| 1 - .../winstorecompat/src/_wassert.c | 50 --- 2 files changed, 51 deletions(-) delete mode 100644 mingw-w64-libraries

Re: [Mingw-w64-public] [PATCH] RFC: headers: Redirect _environ to the _get_environ function in msvcrt.dll for arm/arm64

2019-04-10 Thread Jacek Caban
On 4/10/19 11:15 PM, Martin Storsjö wrote: On Wed, 10 Apr 2019, Jacek Caban wrote: On 4/10/19 3:10 PM, Martin Storsjö wrote: The direct _environ pointer is not available in msvcrt.dll on arm/arm64. This provides a fallback read-only version of _environ, but code that tries to write it still

Re: [Mingw-w64-public] [PATCH 3/5] crt: arm: Use import libs for math functions

2019-04-10 Thread Jacek Caban
On 4/10/19 11:18 PM, Martin Storsjö wrote: On Wed, 10 Apr 2019, Jacek Caban wrote: On 4/10/19 3:11 PM, Martin Storsjö wrote: This avoids unnecessary precision loss e.g. in the log2 function, which previously was wrapped as log(x) / constant, which didn't return exact integers for powers

Re: [Mingw-w64-public] [PATCH] RFC: headers: Redirect _environ to the _get_environ function in msvcrt.dll for arm/arm64

2019-04-10 Thread Jacek Caban
On 4/10/19 3:10 PM, Martin Storsjö wrote: The direct _environ pointer is not available in msvcrt.dll on arm/arm64. This provides a fallback read-only version of _environ, but code that tries to write it still fails to compile though. This header is getting messy. How about using UCRT path of

Re: [Mingw-w64-public] [PATCH 3/3] RFC: headers: Don't declare getpid for msvcrt versions where it's missing

2019-04-10 Thread Jacek Caban
On 4/10/19 3:09 PM, Martin Storsjö wrote: If the getpid function is missing, user code might try to reimplement it, with minor mismatches to the signature. Signed-off-by: Martin Storsjö That looks reasonable to me. Jacek ___ Mingw-w64-public

[Mingw-w64-public] [PATCH] time.h: Use static inlines for time 32/64-bit forwarding functions.

2019-04-08 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/corecrt.h | 8 ++ mingw-w64-headers/crt/time.h| 48 - 2 files changed, 32 insertions(+), 24 deletions(-) diff --git a/mingw-w64-headers/crt/corecrt.h b/mingw-w64-headers/crt/corecrt.h index d171a013

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-08 Thread Jacek Caban
On 4/5/19 3:43 PM, Martin Storsjö wrote: How about doing things in msvc ucrt compatible way? Like the patch I attached as an example (not yet tested)? This looks good to me (but didn't test it yet). This approach of modernizing small areas at a time seems good also, wrt finding out what

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-08 Thread Jacek Caban
On 4/8/19 4:33 AM, Liu Hao wrote: 在 2019/4/5 下午8:07, Jacek Caban 写道: On 4/5/19 9:15 AM, Martin Storsjö wrote: It would be great to have __forceinline fixed. I've seen a problems in code using static __forceinline multiple times. I also recall that attempts to change that had their problems, so

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-05 Thread Jacek Caban
On 4/5/19 9:15 AM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in |  4 +- mingw

Re: [Mingw-w64-public] [PATCH 1/2] crt: Get rid of _ftime from mingwex.

2019-04-05 Thread Jacek Caban
On 4/5/19 9:19 AM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: It's already handled by importlibs. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am    |  2 +- mingw-w64-crt/stdio/_ftime.c | 19 --- 2 files changed, 1 insertion(+), 20 deletions

[Mingw-w64-public] [PATCH 2/2] crt: Move __mingw_setusermatherr and __mingw_raise_matherr into a separated object file.

2019-04-04 Thread Jacek Caban
_matherr may be overridden by an application and as such the default implementation should be in a separated object file. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 1 + mingw-w64-crt/crt/merr.c| 26 -- mingw-w64-crt/crt/usermatherr.c

[Mingw-w64-public] [PATCH 1/2] crt: Get rid of _ftime from mingwex.

2019-04-04 Thread Jacek Caban
It's already handled by importlibs. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am| 2 +- mingw-w64-crt/stdio/_ftime.c | 19 --- 2 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 mingw-w64-crt/stdio/_ftime.c diff --git a/mingw-w64-crt

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-04 Thread Jacek Caban
On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in |  4 +- mingw-w64-crt/lib32/msvcr100.def.in    |  4 +- mingw-w64-crt/lib32/msvcr80.def.in

[Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-04 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in | 4 +- mingw-w64-crt/lib32/msvcr100.def.in| 4 +- mingw-w64-crt/lib32/msvcr80.def.in | 2 + mingw-w64-crt/lib32/msvcr90.def.in | 4 +- mingw-w64-crt/lib64

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlibs for difftime* functions.

2019-04-04 Thread Jacek Caban
On 4/3/19 9:13 PM, Martin Storsjö wrote: On Wed, 3 Apr 2019, Jacek Caban wrote: Don't you have 32/64 the wrong way around here? Oh, good catch, those #ifdefs used opposite meaning and my test was stupid enough to not catch it. I'm not quite sure about the nuance and difference

[Mingw-w64-public] [PATCH 2/2] crt: Use importlibs for execv* functions.

2019-04-03 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/misc/execv.c | 6 -- mingw-w64-crt/misc/execve.c | 6 -- mingw-w64-crt/misc/execvp.c | 6 -- mingw-w64-crt/misc/execvpe.c| 6 -- mingw-w64-headers/crt/process.h | 16

[Mingw-w64-public] [PATCH 1/2] crt: Use importlibs for difftime* functions.

2019-04-03 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in | 4 ++-- mingw-w64-crt/lib32/msvcr100.def.in| 4 ++-- mingw-w64-crt/lib32/msvcr80.def.in | 2 ++ mingw-w64-crt/lib32/msvcr90.def.in | 4 ++-- mingw-w64-crt

[Mingw-w64-public] [PATCH] crt: Get rid of spawnv* forwards in mingwex.

2019-04-03 Thread Jacek Caban
Those are handled by importlibs already. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 4 ++-- mingw-w64-crt/misc/spawnv.c | 6 -- mingw-w64-crt/misc/spawnve.c| 6 -- mingw-w64-crt/misc/spawnvp.c| 6 -- mingw-w64-crt/misc/spawnvpe.c | 6

[Mingw-w64-public] [PATCH] mfobjects.idl: Add missing MFVideoTransferMatrix entries.

2019-04-03 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/include/mfobjects.idl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mingw-w64-headers/include/mfobjects.idl b/mingw-w64-headers/include/mfobjects.idl index 2fafc070..82462ff4 100644 --- a/mingw-w64-headers/include/mfobjects.idl +++ b

Re: [Mingw-w64-public] [PATCH v2] crt: Use importlibs for longjmp.

2019-04-03 Thread Jacek Caban
On 4/3/19 1:51 PM, Martin Storsjö wrote: On Wed, 3 Apr 2019, Jacek Caban wrote: Hello, This version addresses issues found by Martin and applies on top of his setjmp patch. Jacek Signed-off-by: Jacek Caban --- LGTM, please go ahead (and please push my setjmp patch at the same time). I

[Mingw-w64-public] [PATCH v2] crt: Use importlibs for longjmp.

2019-04-03 Thread Jacek Caban
Hello, This version addresses issues found by Martin and applies on top of his setjmp patch. Jacek Signed-off-by: Jacek Caban --- .../def-include/msvcrt-common.def.in | 4 ++-- .../api-ms-win-crt-private-l1-1-0.def.in | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for longjmp.

2019-04-03 Thread Jacek Caban
On 4/3/19 8:37 AM, Martin Storsjö wrote: Another aspect of this patch I didn't think of yesterday: diff --git a/mingw-w64-headers/crt/setjmp.h b/mingw-w64-headers/crt/setjmp.h index fc79f109..039c93f0 100644 --- a/mingw-w64-headers/crt/setjmp.h +++ b/mingw-w64-headers/crt/setjmp.h @@ -252,8

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for longjmp.

2019-04-03 Thread Jacek Caban
On 4/3/19 10:21 AM, Martin Storsjö wrote: On Wed, 3 Apr 2019, Martin Storsjö wrote: On Tue, 2 Apr 2019, Jacek Caban wrote: I think we could use the imported version for ARM, by making sure we pass NULL as the second parameter to the setjmp functions. I tried to recheck this now, and while

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for longjmp.

2019-04-02 Thread Jacek Caban
On 02/04/2019 22:18, Martin Storsjö wrote: On Tue, 2 Apr 2019, Jacek Caban wrote: We currently have pretty useless chunk of assembly in mingwex that recently caused problems with Wine mingw builds. The problem is that we have longjmp symbol defined in mingwex which in fact forwards the call

Re: [Mingw-w64-public] [PATCH] crt/lib-common/msvcrt.def.in: Make `_futime32()` available on x86 and x64.

2019-04-02 Thread Jacek Caban
On 4/2/19 4:51 PM, Liu Hao wrote: 在 2019/4/2 22:33, Jacek Caban 写道: On 4/2/19 4:22 PM, Liu Hao wrote: Personally I'm tempted to say that it's not of interest, but I think it's still officially supported. Anyway, in this case supporting XP should be as trivial as forwarding _futime32

Re: [Mingw-w64-public] [PATCH] crt/lib-common/msvcrt.def.in: Make `_futime32()` available on x86 and x64.

2019-04-02 Thread Jacek Caban
On 4/2/19 4:22 PM, Liu Hao wrote: Reference: https://sourceforge.net/p/msys2/mailman/message/36628134/ Signed-off-by: Liu Hao This apparently reverts modification of this function in 1035bed24e833ea5eb487c78f4f350ea48f31e8b. Is Windows XP still of interest today? Personally I'm tempted to

[Mingw-w64-public] [PATCH] crt: Use importlibs for longjmp.

2019-04-02 Thread Jacek Caban
Hello, We currently have pretty useless chunk of assembly in mingwex that recently caused problems with Wine mingw builds. The problem is that we have longjmp symbol defined in mingwex which in fact forwards the call to the imported function on x64 non-SEH and x86. I did some digging in git

Re: [Mingw-w64-public] [PATCH 2/2] crt: Split mingw_getsp and longjmp into separated files.

2019-04-01 Thread Jacek Caban
On 4/1/19 4:38 PM, Liu Hao wrote: 在 2019/4/1 22:09, Jacek Caban 写道: Signed-off-by: Jacek Caban ---  mingw-w64-crt/Makefile.am    |   1 +  mingw-w64-crt/misc/longjmp.S | 128 +++  mingw-w64-crt/misc/mingw_getsp.S | 122 -  3

[Mingw-w64-public] [PATCH 1/2] msvcrt.def.in: Fix _CxxThrowException import on x86.

2019-04-01 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/lib-common/msvcrt.def.in | 3 ++- mingw-w64-crt/lib32/msvcr80.def.in | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/lib-common/msvcrt.def.in b/mingw-w64-crt/lib-common/msvcrt.def.in index 19f7d929..b45f3f5a

[Mingw-w64-public] [PATCH 2/2] crt: Split mingw_getsp and longjmp into separated files.

2019-04-01 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am| 1 + mingw-w64-crt/misc/longjmp.S | 128 +++ mingw-w64-crt/misc/mingw_getsp.S | 122 - 3 files changed, 129 insertions(+), 122 deletions(-) create mode 100644 mingw

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am |  2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in    |  2 +- mingw-w64-crt/lib

[Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in| 2 +- mingw-w64-crt/lib-common/ucrtbase.def.in | 2 +- mingw-w64-crt/lib32/msvcr100.def.in

Re: [Mingw-w64-public] [PATCH v2 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
Please ignore that. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH v2 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in| 2 +- mingw-w64-crt/lib-common/ucrtbase.def.in | 2 +- mingw-w64-crt/lib32/msvcr100.def.in

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
On 3/29/19 7:47 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/misc/assert.c    | 31 --- mingw-w64-headers/crt/assert.h |  3 +-- 3 files changed, 2 insertions

[Mingw-w64-public] [PATCH 2/2] crt: Use importlib for _wassert.

2019-03-29 Thread Jacek Caban
It's not available on XP, so we need to provice a compat implementation for libmsvcrt-os.a. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 5 +- mingw-w64-crt/lib-common/msvcrt.def.in | 2 +- mingw-w64-crt/lib32/msvcr100.def.in| 2 +- mingw-w64-crt/lib32

[Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-03-29 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/misc/assert.c| 31 --- mingw-w64-headers/crt/assert.h | 3 +-- 3 files changed, 2 insertions(+), 34 deletions(-) delete mode 100644 mingw-w64-crt/misc/assert.c diff --git

[Mingw-w64-public] [PATCH] intsafe.h: Add SizeTToUInt32.

2019-03-25 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/include/intsafe.h | 1 + 1 file changed, 1 insertion(+) diff --git a/mingw-w64-headers/include/intsafe.h b/mingw-w64-headers/include/intsafe.h index 701d4cef..057c3796 100644 --- a/mingw-w64-headers/include/intsafe.h +++ b/mingw-w64-headers

[Mingw-w64-public] [PATCH] libd3dcompiler.a: Default to d3dcompiler_47.dll to match headers.

2019-03-22 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index c38816e6..e19beaaf 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -70,7 +70,7

Re: [Mingw-w64-public] d3dcompiler_43 -> 47

2019-03-22 Thread Jacek Caban
On 3/21/19 8:17 PM, Tom Ritter wrote: With the bump to d3dcompiler_47 in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/2d4e517ad0c7a9f0bd7001c42e6c131b977c15d9/ I think the following needed to be updated as well:

<    1   2   3   4   5   6   7   8   9   >