Re: [Mixxx-devel] Active Library Filter performance issues

2012-07-05 Thread Max Linke
On Wed, 27 Jun 2012 10:02:25 +0200 Daniel Schürmann dasch...@mixxx.org wrote: Max, are you able to estimate how much work it will be to adapt the general solution? I've looked a bit in the clementine code today. There should be 3 overall steps for this 1. move the library class to a new

Re: [Mixxx-devel] Active Library Filter performance issues

2012-07-05 Thread keithsalisb...@gmail.com
I agree the library backend should receive a nice stiff re-factoring to make it more capable of meeting the new requirements. I fear this will require a invasive patch that would require the attention of a senior developer with good knowledge of the whole project. Dan is right though that the

Re: [Mixxx-devel] Active Library Filter performance issues

2012-06-27 Thread Michał Wiśniewski
On Tue, 26 Jun 2012 12:15:42 -1000 keithsalisb...@gmail.com keithsalisb...@gmail.com wrote: Working together with Varun, we've realised that using the active library filter aka Selector feature, causes a hang in the interface each time one of the filters is applied. This is caused by the hit

[Mixxx-devel] Active Library Filter performance issues

2012-06-26 Thread keithsalisb...@gmail.com
Working together with Varun, we've realised that using the active library filter aka Selector feature, causes a hang in the interface each time one of the filters is applied. This is caused by the hit to the database, so I have two suggestions to improve the performace: 1. Implement the filters

Re: [Mixxx-devel] Active Library Filter performance issues

2012-06-26 Thread Max Linke
Hi see https://bugs.launchpad.net/mixxx/+bug/1010365 This is a serious problem affecting almost all db transactions. I like the idea of Daniel to move all the db transactions into its own thread. best Max On Tue, 26 Jun 2012 12:15:42 -1000 keithsalisb...@gmail.com keithsalisb...@gmail.com

Re: [Mixxx-devel] Active Library Filter - Active BPM filtering

2012-03-24 Thread keithsalisb...@gmail.com
OK, so the Active Filter now has harmonic keys filter - just need help with the stuff below (getRate) and I can add the active part of the filter for bpm and keys and I'd be happy to mark that down as iteration one complete. Give it a try if you have a moment, love to know thoughts about how it

Re: [Mixxx-devel] Active Library Filter - Active BPM filtering

2012-03-24 Thread keithsalisb...@gmail.com
HI Albert, Whats does IIRC mean? thanks keith On 24 March 2012 11:33, Albert Santoni albe...@mixxx.org wrote: Hey Keith, There's a rate control object for each deck, similar to the play ones we were looking at in dlgautodj.cpp. I think that's what you're looking for. IIRC the value

Re: [Mixxx-devel] Active Library Filter - Active BPM filtering

2012-03-24 Thread Albert Santoni
Hey Keith, If I recall correctly... sorry, I spend too much time on the internet! :) Albert On Sat, Mar 24, 2012 at 3:39 PM, keithsalisb...@gmail.com keithsalisb...@gmail.com wrote: HI Albert, Whats does IIRC mean? thanks keith On 24 March 2012 11:33, Albert Santoni albe...@mixxx.org

Re: [Mixxx-devel] Active Library Filter

2012-03-22 Thread Daniel Schürmann
Hey Keith, Hey Ryan, for my feeling we are talking about two different features or use cases looking at the high end solutions when finished: 1.) DJs best friend who answers the question which song suites best as next track 2.) Advanced Search for I now a fitting song but ... what was its

Re: [Mixxx-devel] Active Library Filter

2012-03-22 Thread keithsalisb...@gmail.com
Hey Daniel, Thanks for some great feedback!! Right now I'm just going to focus on maturing the feature to include Rating, and finally Key. 1. Do you know how I can create a rating selector with stars like in the track table view? 2. Do you know if people have A1, A2, B1 etc in their files for

Re: [Mixxx-devel] Active Library Filter

2012-03-22 Thread keithsalisb...@gmail.com
Anyone know how D ♯ minor is saved in most people's ID3 tags? What are the plans for the harmonic keys code when running the analyser? 2012/3/22 keithsalisb...@gmail.com keithsalisb...@gmail.com: Hey Daniel, Thanks for some great feedback!! Right now I'm just going to focus on maturing the

Re: [Mixxx-devel] Active Library Filter - Active BPM filtering

2012-03-22 Thread keithsalisb...@gmail.com
Currently the BPM filter simply looks at the track info to determine the BPM. I would like the filter to be a little smarter and use the actual bpm of the track - and so include the track pitch into the calculation. Does anyone have this calculation already, or is there code I can call to get

Re: [Mixxx-devel] Active Library Filter - Active BPM filtering

2012-03-22 Thread keithsalisb...@gmail.com
I think I need to get EngineBuffer-getRate() void SelectorLibraryTableModel::slotPlayingDeckChanged(int deck) { TrackPointer loaded_track = PlayerInfo::Instance( ).getTrackInfo(QString([Channel%1]).arg(deck)); } I'm using this to get the current track info - so can I get to the

[Mixxx-devel] Active Library Filter

2012-03-21 Thread Daniel Schürmann
::getControl(ConfigKey([Channel2], play))); But please keep in mind, that Mixxx 1.11 will be n-deck capable. Kind regards, Daniel Original-Nachricht Betreff:[Mixxx-devel] Active Library Filter Datum: Tue, 20 Mar 2012 15:41:44 -0800 Von

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread keithsalisb...@gmail.com
-Nachricht    Betreff:    [Mixxx-devel] Active Library Filter    Datum:      Tue, 20 Mar 2012 15:41:44 -0800    Von:        keithsalisb...@gmail.com keithsalisb...@gmail.com    An:         mixxx-devel@lists.sourceforge.net    So my active library filter is coming along quite nicely

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread keithsalisb...@gmail.com
A future option might be to take the set log tracks into account. Something like current track 70%, last track 30% The current set log play-list ID is stored in SetlogFrature::m_playlistId Quick thought on this, would be nice if there was a History view - which could be converted to a

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread martin
Hi Keith, I totally agree with Daniel that b) is better than a). Even greater would be the option to select (with a small button in the GUI) which deck(s) should be takes into consideration. Best regards, Martin

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread keithsalisb...@gmail.com
Ok peeps, so I did a bit of refactoring tonight, so now the filters are checkboxes rather than radio buttons - the advantage is that you can filter for both genre and bpm - and it works brilliantly. Also thanks to Daniels great suggestion I've hooked it up to the currentPlayingDeckChanged so its

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread Daniel Schürmann
: Wed, 21 Mar 2012 04:51:50 -0800 Von: keithsalisb...@gmail.com keithsalisb...@gmail.com An: mixxx-devel mixxx-devel@lists.sourceforge.net Betreff: Re: [Mixxx-devel] Active Library Filter Ok peeps, so I did a bit of refactoring tonight, so now the filters are checkboxes rather than radio buttons

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread Yves Adler
On 03/21/12 08:51, Daniel Schürmann wrote: I've created another library view with check boxes Genre and Bpm which when checked filter the library view to the track loaded in deck 1. So if you're playing a trance track with 130bpm, you library will filter to down to all

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread keithsalisb...@gmail.com
Hi Yves, Another thing that comes to my mind is to display tracks (on top of the list?) that you've played often in combination with the currently playing track. But I'm not sure if you have that kind of information in mixxx. That's something that might fit into what I have in mind for my

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread RJ Ryan
Hey Keith, Nice work! I like your idea of making this possible to do in any view. I think there are two main problems you should figure out how to solve if you're going to follow up on that: 1) How to make the checkboxes visible in any library-table-view, but hidable so they don't waste vertical

Re: [Mixxx-devel] Active Library Filter - Harmonic Key

2012-03-21 Thread keithsalisb...@gmail.com
Ok, so I'm finally here, at the feature that originally motivated me down this path. Filtering the library using Harmonic Keys. So I'm assuming most people are using the Camelot Wheel. Is this a fair assumption? None of my tracks are currently keyed so: What value do people have in their

Re: [Mixxx-devel] Active Library Filter

2012-03-21 Thread keithsalisb...@gmail.com
Hey Ryan, Thanks! I really like the idea of linking it up to the new search stuff - makes perfect sense really - and that way the active part of active filter is just that its listening to the currentDeckPlaying event. As for UI stuff - I'll have a play around, I've never been much of a UI