Re: [Mixxx-devel] Album Cover Support
Hello, I noted that FFMPEG doesn't build anymore because of missing Albumart stuff. I'll fix that and submit pull request later on. Tuukka 2014-11-07 20:15 GMT+02:00 Ilkka Tuohela ilkka.tuoh...@gmail.com: On 07 Nov 2014, at 16:40, Max Linke max_li...@gmx.de wrote: On Fri, 7 Nov 2014 01:01:51 +0200 Ilkka Tuohela ilkka.tuoh...@gmail.com wrote: Hi, The newly merged album art code in master is missing implementation for Opus codec, causing linker errors if libopus is detected and enabled. I added following to my hack branch to make it compile without explicitly disabling opus codec, but I’m not at all sure about the code. http://tuohela.net/irc/opus-fix.txt http://tuohela.net/irc/opus-fix.txt I opened a bug for this linking to your code. All those files we only support with compile flags are a bit annoying because I usually develop against the default compile flags. Tested with my large library and it seems to be OK. I think there was an issue with track analysis/waveform loading after first albumart import (no track had analysis data available during that session), but now when I restarted mixxx this is gone. Did you just upgrade from master or an older version of mixxx? I was running master fork from a couple of weeks ago. No code changes, just my own skin. -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111iu=/4140/ostg.clktrk ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Oh thanks that is good There already is a PR for this. https://github.com/mixxxdj/mixxx/pull/368 There still are some issue with this. The tests are failing and mixxx crashes after you scroll a bit with a warning that too many files are open. I would appreciate it if you could help there or maybe you can use it to base your work on. best Max On Fri, 14 Nov 2014 10:18:14 +0200 Tuukka Pasanen pasanen.tuu...@gmail.com wrote: Hello, I noted that FFMPEG doesn't build anymore because of missing Albumart stuff. I'll fix that and submit pull request later on. Tuukka 2014-11-07 20:15 GMT+02:00 Ilkka Tuohela ilkka.tuoh...@gmail.com: On 07 Nov 2014, at 16:40, Max Linke max_li...@gmx.de wrote: On Fri, 7 Nov 2014 01:01:51 +0200 Ilkka Tuohela ilkka.tuoh...@gmail.com wrote: Hi, The newly merged album art code in master is missing implementation for Opus codec, causing linker errors if libopus is detected and enabled. I added following to my hack branch to make it compile without explicitly disabling opus codec, but I’m not at all sure about the code. http://tuohela.net/irc/opus-fix.txt http://tuohela.net/irc/opus-fix.txt I opened a bug for this linking to your code. All those files we only support with compile flags are a bit annoying because I usually develop against the default compile flags. Tested with my large library and it seems to be OK. I think there was an issue with track analysis/waveform loading after first albumart import (no track had analysis data available during that session), but now when I restarted mixxx this is gone. Did you just upgrade from master or an older version of mixxx? I was running master fork from a couple of weeks ago. No code changes, just my own skin. -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111iu=/4140/ostg.clktrk ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111iu=/4140/ostg.clktrk ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
On Fri, 7 Nov 2014 01:01:51 +0200 Ilkka Tuohela ilkka.tuoh...@gmail.com wrote: Hi, The newly merged album art code in master is missing implementation for Opus codec, causing linker errors if libopus is detected and enabled. I added following to my hack branch to make it compile without explicitly disabling opus codec, but I’m not at all sure about the code. http://tuohela.net/irc/opus-fix.txt http://tuohela.net/irc/opus-fix.txt I opened a bug for this linking to your code. All those files we only support with compile flags are a bit annoying because I usually develop against the default compile flags. Tested with my large library and it seems to be OK. I think there was an issue with track analysis/waveform loading after first albumart import (no track had analysis data available during that session), but now when I restarted mixxx this is gone. Did you just upgrade from master or an older version of mixxx? -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Hi, The newly merged album art code in master is missing implementation for Opus codec, causing linker errors if libopus is detected and enabled. I added following to my hack branch to make it compile without explicitly disabling opus codec, but I’m not at all sure about the code. http://tuohela.net/irc/opus-fix.txt http://tuohela.net/irc/opus-fix.txt Sorry no pull request, because I’m not sure how this should be tested. I guess people who actually committed the code should test and fix this, because they should know what to test? Also how to test this properly with old and new taglib versions? Tested with my large library and it seems to be OK. I think there was an issue with track analysis/waveform loading after first albumart import (no track had analysis data available during that session), but now when I restarted mixxx this is gone. The bug with library field layout is very annoying, especially because it requires one extra restart of mixxx (when you hit the bug, you’ll lose any changes made to the layout again until first restart when the state is changed, the layout changes stick only after you have restarted mixxx once). Remember this is not a bug directly in albumart branch, it’s old bug with storing library column layouts which has just emerged again when number of options changed. *hile*-- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
I merged the cover art branch into master an hour ago. You can grab the code and try it out. If you start from an old config you will have to rescan your library to see the covers and likely also activate the column in the libraryview. Deere is currently the only skin that uses cover-art widgets outside of the library. Many thanks to Marcos for wokring on this during GSoC and Daniel and Ryan for their help. The alpha build should be updated once rryan fixes the faulty OSX build, which hopefully happens sometime next week. best Max On Sat, 18 Oct 2014 18:20:32 -0700 Gavin Swanson gavinswan...@gmail.com wrote: Crashing is not a reasonable response to a parse error, PERIOD. On Oct 18, 2014 4:13 PM, Owen Williams owilli...@mixxx.org wrote: Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
So far so good! Too bad so few of my tracks have cover art. I'll work on adding cover art support to LateNight soon. Unrelated to the overall quality of the patch -- is there any way we can fix the bug where if the available library columns change, my entire column layout gets fucked up? It's really annoying to carefully lay everything out again. Also, is there any way we can have the full art pop up when the user mouses over the truncated version in the library? On Wed, 2014-11-05 at 20:38 +0100, Max Linke wrote: I merged the cover art branch into master an hour ago. You can grab the code and try it out. If you start from an old config you will have to rescan your library to see the covers and likely also activate the column in the libraryview. Deere is currently the only skin that uses cover-art widgets outside of the library. Many thanks to Marcos for wokring on this during GSoC and Daniel and Ryan for their help. The alpha build should be updated once rryan fixes the faulty OSX build, which hopefully happens sometime next week. best Max On Sat, 18 Oct 2014 18:20:32 -0700 Gavin Swanson gavinswan...@gmail.com wrote: Crashing is not a reasonable response to a parse error, PERIOD. On Oct 18, 2014 4:13 PM, Owen Williams owilli...@mixxx.org wrote: Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net
Re: [Mixxx-devel] Album Cover Support
Hello, Can't tell why no parsing in separate process but sound bit harsh to me and doesn't really fix the problem of crashing.. I have question about compiling on mac OS X 10.6 (normal Mixxx compiles just fine) when compiling thins Pull request branch with 'scons ffmpeg=0 shoutcast=0 machine=x86_64' I get should I put some scons parameter or am I still using wrong branch? src/mixxx.cpp: In constructor ‘MixxxMainWindow::MixxxMainWindow(QApplication*, const CmdlineArgs)’: src/mixxx.cpp:274: error: ‘class DlgCoverArtFullSize::Singleton’ has not been declared src/mixxx.cpp: In destructor ‘virtual MixxxMainWindow::~MixxxMainWindow()’: src/mixxx.cpp:541: error: ‘class DlgCoverArtFullSize::Singleton’ has not been declared Thanks, Tuukka 2014-10-20 0:43 GMT+03:00 Owen Williams owilli...@mixxx.org: Please answer my second question about why we aren't parsing audio metadata in a separate process. On Sun, 2014-10-19 at 00:35 +, re-cy...@hushmail.com wrote: I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. *raises hand* As someone who has used Mixxx for live gigs, where it crashed enough times during various sets to sabotage my reputation as a promoter and DJ, I want to remind people that software used in live performances has to be held to the highest possible non-crash standard. I don't care if the thing looks like it was made by kindergarten students as a class project as long as it queues music properly and NEVER CRASHES LIVE. ~RAWRR On Sat, 18 Oct 2014 23:12:36 + Owen Williams owilli...@mixxx.org wrote: Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. --- --- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel - - Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel --- --- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho
Re: [Mixxx-devel] Album Cover Support
On Mon, 2014-10-20 at 09:01 +0300, Tuukka Pasanen wrote: Hello, Can't tell why no parsing in separate process but sound bit harsh to me and doesn't really fix the problem of crashing.. That's my point, RJ's contention is that if we don't have a separate process, we will get crashes. So I am saying, is it so crashy that we have to delay this feature until we can isolate the process, or can we consider the rare crash due to bad files an acceptable risk. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
No, I don't think it's worth blocking the feature. I do think long-term we want to be touching all untrusted data in separate processes though -- talking to the cachingreaders via FIFO, etc. It's a big hassle but it would eliminate a category of crashes we see. On Mon, Oct 20, 2014 at 9:05 AM, Owen Williams owilli...@mixxx.org wrote: On Mon, 2014-10-20 at 09:01 +0300, Tuukka Pasanen wrote: Hello, Can't tell why no parsing in separate process but sound bit harsh to me and doesn't really fix the problem of crashing.. That's my point, RJ's contention is that if we don't have a separate process, we will get crashes. So I am saying, is it so crashy that we have to delay this feature until we can isolate the process, or can we consider the rare crash due to bad files an acceptable risk. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Hello, Sounds very reasonable bit like they do it Chrome and Firefox (and others) that there is isolation for untrusted part (like Flash that tends to crash) and stuff that is rock solid. How much work this will need it obviously goes to 1.13? Tuukka 2014-10-20 17:10 GMT+03:00 RJ Ryan rr...@mixxx.org: No, I don't think it's worth blocking the feature. I do think long-term we want to be touching all untrusted data in separate processes though -- talking to the cachingreaders via FIFO, etc. It's a big hassle but it would eliminate a category of crashes we see. On Mon, Oct 20, 2014 at 9:05 AM, Owen Williams owilli...@mixxx.org wrote: On Mon, 2014-10-20 at 09:01 +0300, Tuukka Pasanen wrote: Hello, Can't tell why no parsing in separate process but sound bit harsh to me and doesn't really fix the problem of crashing.. That's my point, RJ's contention is that if we don't have a separate process, we will get crashes. So I am saying, is it so crashy that we have to delay this feature until we can isolate the process, or can we consider the rare crash due to bad files an acceptable risk. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Please answer my second question about why we aren't parsing audio metadata in a separate process. On Sun, 2014-10-19 at 00:35 +, re-cy...@hushmail.com wrote: I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. *raises hand* As someone who has used Mixxx for live gigs, where it crashed enough times during various sets to sabotage my reputation as a promoter and DJ, I want to remind people that software used in live performances has to be held to the highest possible non-crash standard. I don't care if the thing looks like it was made by kindergarten students as a class project as long as it queues music properly and NEVER CRASHES LIVE. ~RAWRR On Sat, 18 Oct 2014 23:12:36 + Owen Williams owilli...@mixxx.org wrote: Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. --- --- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel - - Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel --- --- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Crashing is not a reasonable response to a parse error, PERIOD. On Oct 18, 2014 4:13 PM, Owen Williams owilli...@mixxx.org wrote: Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable. I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: The main limitation with QtConcurrent is that it uses a single global thread pool -- and currently we use 4 worker threads in our global thread pool (for parsing 3rd-party libraries, etc). There is no notion of auto-scaling or the ability for sensing whether we are overloading the system inherent in QtConcurrent -- it's just a wrapper around a thread pool. For something as common and compute heavy as processing cover art we need more deliberate control. TagLib crashes will happen given the extreme diversity of library-from-hell files out there. We really do need a separate-process isolation feature for processing untrusted data but I'm pretty sure we don't have time for that for 1.12 if we want to release in 2014 :). On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann dasch...@mixxx.org wrote: Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Hi Developers, I think we should carefully consider risks and chances for the cover art support merge. My impression is that the branch has a good overall quality and is a real benefit for a upcoming 1.12 version. What are the points of risks, that makes this different to other pull requests. Here a probably incomplete List: 1) Reading picture files of poor quality 2) Extracting pictures from audio Files using tag-lib 3) Displaying pictures 4) Writing users library 5) Performance regressions 6) Threading issues Will re significant reduce these risk, if we have this PR another two years as developers compile option or it is better to have this a part of a public beta phase? for 1) here we have to rely on the Qt library. We can't do much if the picture byte stream is invalid or can we? for 2) We have plenty of Tag-lib issues in the past and have seen other music player apps to use a quarantine process because of this. I still get constantly reports that my Rhythmbox quarantine process crashes an a recent Ubuntu 14.4 installation. I do not know why but that is not a good idea to pull that to Mixxx. Is there a chance for a quarantine process for Mixxx 1.12? I have started it a while ago, but get stucked. Any Ideas? for 3) Displaying Pixamps is a regular task of Qt and Mixxx and should be not produce any GPU issues, since no openGL is involved. for 4) IMHO the current scheme is fine. for 5) These are easy to find and fix issues during the test phase for 6) Do we expect some? Such things should be discovered during a review. Finding them by testing is hard. For me, it sounds that this can be part of 1.12 if we have a solution for taglib crashes. Kind regards, Daniel 2014-10-16 14:49 GMT+02:00 Owen Williams owilli...@mixxx.org: That model has not worked well in the past. It doesn't matter how many warnings there are, people will see album art!, turn it on, and then get angry if/when it crashes. The new model I'd like to propose is: * Enable an unstable-but-desirable feature (like cover art) by default in development and nightly builds. * Disable it for release builds. I think this will prevent code rot, which was the biggest problem in the past with optional compile-time features. Everyone doing development will be using the feature and seeing any bugs it has. But then the release is still pristine and won't be compromised. Once the feature is stable, we can flip the flag and allow the feature to go to release. This does require that the compile flag is robust. There have been problems in the past with vinyl control, which is enabled for most builds but disabled for App Store builds. Things work great in development, and then the release build turns out to be broken. Having the buildbot should help prevent that -- we should set up a target to create release builds and run the tests, but not actually make them available for download. Owen On Thu, 2014-10-16 at 09:53 +0300, Tuukka Pasanen wrote: Hello, Ok I'm totally with this but I also understand RJ concerns about hitting unwanted behavior. Could this be integrated and only turned on if user makes it with BIG FAT WARNING about it is little bit experimental and polish it to 1.13? Tuukka 2014-10-12 15:13 GMT+03:00 Max Linke max_li...@gmx.de: That is exactly how it works. Currently ew only support local covers. We have some code to also download covers from amazon but I'm not sure if that will make it. Here is the algorithm that decides which cover we are loading. // Search Strategy // 0. If we have just one file, we will get it. // 1. %track-file-base%.jpg in the track directory for %track-file-base%.mp3 // 2. %album%.jpg // 3. cover.jpg // 4. front.jpg // 5. album.jpg // 6. folder.jpg // 7. anything else found in the folder (get the smallest one) On Sun, 12 Oct 2014 11:22:17 +0300 Tuukka Pasanen pasanen.tuu...@gmail.com wrote: Hello, Does this support scenario when you have used something like Beets (http://beets.radbox.org/) and allready have cover.jpg (or something) in every directory that contains music? It's nice to have somekind of downloader but there should be also support people like me who like to organize their music in specific way and have cover art in hand.. Tuukka -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list
Re: [Mixxx-devel] Album Cover Support
Am 18.10.2014 um 00:31 schrieb Max Linke: I haven't noticed any taglib crashes with mixxx. Plus the covers are all extracted in seperate threads. I have not experienced any crashes during the tests as well, so the issue is hopefully none. I was just trying to collect the point that might be risky. By the way: Segfaults in a extra thread will have the same effect than a segfault in the main thread, Mixxx will crash. So we can either rely on the quality of the new taglib version, or setup a quarantine process, that read the tags. -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Hello, Ok I'm totally with this but I also understand RJ concerns about hitting unwanted behavior. Could this be integrated and only turned on if user makes it with BIG FAT WARNING about it is little bit experimental and polish it to 1.13? Tuukka 2014-10-12 15:13 GMT+03:00 Max Linke max_li...@gmx.de: That is exactly how it works. Currently ew only support local covers. We have some code to also download covers from amazon but I'm not sure if that will make it. Here is the algorithm that decides which cover we are loading. // Search Strategy // 0. If we have just one file, we will get it. // 1. %track-file-base%.jpg in the track directory for %track-file-base%.mp3 // 2. %album%.jpg // 3. cover.jpg // 4. front.jpg // 5. album.jpg // 6. folder.jpg // 7. anything else found in the folder (get the smallest one) On Sun, 12 Oct 2014 11:22:17 +0300 Tuukka Pasanen pasanen.tuu...@gmail.com wrote: Hello, Does this support scenario when you have used something like Beets (http://beets.radbox.org/) and allready have cover.jpg (or something) in every directory that contains music? It's nice to have somekind of downloader but there should be also support people like me who like to organize their music in specific way and have cover art in hand.. Tuukka -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
That model has not worked well in the past. It doesn't matter how many warnings there are, people will see album art!, turn it on, and then get angry if/when it crashes. The new model I'd like to propose is: * Enable an unstable-but-desirable feature (like cover art) by default in development and nightly builds. * Disable it for release builds. I think this will prevent code rot, which was the biggest problem in the past with optional compile-time features. Everyone doing development will be using the feature and seeing any bugs it has. But then the release is still pristine and won't be compromised. Once the feature is stable, we can flip the flag and allow the feature to go to release. This does require that the compile flag is robust. There have been problems in the past with vinyl control, which is enabled for most builds but disabled for App Store builds. Things work great in development, and then the release build turns out to be broken. Having the buildbot should help prevent that -- we should set up a target to create release builds and run the tests, but not actually make them available for download. Owen On Thu, 2014-10-16 at 09:53 +0300, Tuukka Pasanen wrote: Hello, Ok I'm totally with this but I also understand RJ concerns about hitting unwanted behavior. Could this be integrated and only turned on if user makes it with BIG FAT WARNING about it is little bit experimental and polish it to 1.13? Tuukka 2014-10-12 15:13 GMT+03:00 Max Linke max_li...@gmx.de: That is exactly how it works. Currently ew only support local covers. We have some code to also download covers from amazon but I'm not sure if that will make it. Here is the algorithm that decides which cover we are loading. // Search Strategy // 0. If we have just one file, we will get it. // 1. %track-file-base%.jpg in the track directory for %track-file-base%.mp3 // 2. %album%.jpg // 3. cover.jpg // 4. front.jpg // 5. album.jpg // 6. folder.jpg // 7. anything else found in the folder (get the smallest one) On Sun, 12 Oct 2014 11:22:17 +0300 Tuukka Pasanen pasanen.tuu...@gmail.com wrote: Hello, Does this support scenario when you have used something like Beets (http://beets.radbox.org/) and allready have cover.jpg (or something) in every directory that contains music? It's nice to have somekind of downloader but there should be also support people like me who like to organize their music in specific way and have cover art in hand.. Tuukka -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
Hello, Does this support scenario when you have used something like Beets (http://beets.radbox.org/) and allready have cover.jpg (or something) in every directory that contains music? It's nice to have somekind of downloader but there should be also support people like me who like to organize their music in specific way and have cover art in hand.. Tuukka -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
That is exactly how it works. Currently ew only support local covers. We have some code to also download covers from amazon but I'm not sure if that will make it. Here is the algorithm that decides which cover we are loading. // Search Strategy // 0. If we have just one file, we will get it. // 1. %track-file-base%.jpg in the track directory for %track-file-base%.mp3 // 2. %album%.jpg // 3. cover.jpg // 4. front.jpg // 5. album.jpg // 6. folder.jpg // 7. anything else found in the folder (get the smallest one) On Sun, 12 Oct 2014 11:22:17 +0300 Tuukka Pasanen pasanen.tuu...@gmail.com wrote: Hello, Does this support scenario when you have used something like Beets (http://beets.radbox.org/) and allready have cover.jpg (or something) in every directory that contains music? It's nice to have somekind of downloader but there should be also support people like me who like to organize their music in specific way and have cover art in hand.. Tuukka -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Album Cover Support
I'll take a look. I'm worried about: 1) Increasing the risk of untrusted / junk data taking down Mixxx 2) Increasing the risk we tickle graphics driver bugs. But ultimately we're going to add cover art at some point so why not now. This release will be so massive that people probably aren't going to trust it immediately anyway. On Fri, Oct 10, 2014 at 12:59 PM, Max Linke max_li...@gmx.de wrote: Hi, Marcos Cardinot, one of our GSoC students, has implemented basic support for album covers in mixxx. I want to merge this as the last big feature for 1.12 next week. The code can be found at. https://github.com/mixxxdj/mixxx/pull/278 To test this you have to build the code yourself right now. I appricate any comments if something is not working or the covers for your files are not showing up. best Max -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
