On Wed, Dec 03, 2014 at 08:17:39 +0100, Max Kellermann wrote:
> Thus, MPD currently does not enable zeroconf when socket activation is
> used, because MPD does not know what port to announce.
Would getsockname(2) help?
--Ben
___
mpd-devel mailing list
m
On 2014/12/03 16:49, Ben Boeckel wrote:
> On Wed, Dec 03, 2014 at 08:17:39 +0100, Max Kellermann wrote:
> > Thus, MPD currently does not enable zeroconf when socket activation is
> > used, because MPD does not know what port to announce.
>
> Would getsockname(2) help?
Yes, that could be used to
From: Michal Nazarewicz
If $MPD_PORT is not a number, i.e. does not start with a digit,
attempt to resolve it using getservbyname, i.e. by reading the
/etc/services database.
---
src/settings.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/
From: Michal Nazarewicz
Instead of storing password in MPD_HOST environment variable (which
is passed around everywhere) allow saving password in an ~/.authinfo
file. This is especially useful if MPD is listening on default
host:port, i.e. localhost:6600, in which case all one needs to do is
to
Hi,
I'm sorry, but I don't see a single whitespace change in this patch.
Also, I didn't know what were the project policies, but the content of
the initial email is summed up in the commit message on top of the
patch,
Maybe you want me to send the patch as embedded text in this mail, or
with atta
On 2014/12/03 17:00, X Ryl wrote:
> I don't see a single whitespace change in this patch.
I do. Proof:
-# type"httpd"
+# type "httpd"
> Also, I didn't know what were the project policies, but the content of
> the initial email is summed up in the commit messa
On 2014/12/03 21:13, Michal Nazarewicz wrote:
> From: Michal Nazarewicz
>
> If $MPD_PORT is not a number, i.e. does not start with a digit,
> attempt to resolve it using getservbyname, i.e. by reading the
> /etc/services database.
This now passes the build test, but I don't like how this adds
u
On 2014/12/03 21:13, Michal Nazarewicz wrote:
> From: Michal Nazarewicz
>
> If $MPD_PORT is not a number, i.e. does not start with a digit,
> attempt to resolve it using getservbyname, i.e. by reading the
> /etc/services database.
One more thing: I'd like to know what is the point of this patch
> On 2014/12/03 21:13, Michal Nazarewicz wrote:
>> If $MPD_PORT is not a number, i.e. does not start with a digit,
>> attempt to resolve it using getservbyname, i.e. by reading the
>> /etc/services database.
On Wed, Dec 03 2014, Max Kellermann wrote:
> This now passes the build test, but I don't
Ok.
My intention was not to start a flamewar, but to contribute back a
feature that's missing in the daemon.
Actually you criticize that there was no documentation, but I do
include the documentation, since I've added it in the first file (and
by the way, I fixed the wrong comments in the file)!
A
On 2014/12/03 22:00, X Ryl wrote:
> Please find attached a new patch, with your other remarks fixed.
How is this change related to your patch description?
-# encoder "vorbis"# optional, vorbis or lame
+# encoder "vorbis"# optional, vorbis
On Wed, Dec 03, 2014 at 20:25:55 +0100, Max Kellermann wrote:
> But combining socket activation with zeroconf would be a rather
> pointless exercise. You would only be able to find MPD after you
> already connected to MPD.
Ah, indeed, that is a chicken-and-egg. I guess documentation would be
the
Thanks Max,
Thus, MPD currently does not enable zeroconf when socket activation is
> used, because MPD does not know what port to announce.
>
I understand this now.
> systemd would activate the socket on behalf of the service because you
> told it to. It is optional, and you enabled it ("syste
> How is this change related to your patch description?
>
> -# encoder "vorbis"# optional, vorbis or lame
> +# encoder "vorbis"# optional, vorbis or lame or
> any encoder (use mpd --verbose to get a list)
It's not. The comment is wrong, an
On 2014/12/03 23:09, X Ryl wrote:
> Actually, it's useful to clients but not only. In my use case, MPD is
> on a headless server. Without it, it's not possible to receive this
> stream in Javascript context due to Cross Origin protection in
> browsers. That prevents using HTTPD plugin as a audio s
15 matches
Mail list logo
