Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-03 Thread Punky
Thanks Max, Thus, MPD currently does not enable zeroconf when socket activation is > used, because MPD does not know what port to announce. > I understand this now. > systemd would activate the socket on behalf of the service because you > told it to. It is optional, and you enabled it ("syste

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-03 Thread Ben Boeckel
On Wed, Dec 03, 2014 at 20:25:55 +0100, Max Kellermann wrote: > But combining socket activation with zeroconf would be a rather > pointless exercise. You would only be able to find MPD after you > already connected to MPD. Ah, indeed, that is a chicken-and-egg. I guess documentation would be the

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-03 Thread Max Kellermann
On 2014/12/03 16:49, Ben Boeckel wrote: > On Wed, Dec 03, 2014 at 08:17:39 +0100, Max Kellermann wrote: > > Thus, MPD currently does not enable zeroconf when socket activation is > > used, because MPD does not know what port to announce. > > Would getsockname(2) help? Yes, that could be used to

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-03 Thread Ben Boeckel
On Wed, Dec 03, 2014 at 08:17:39 +0100, Max Kellermann wrote: > Thus, MPD currently does not enable zeroconf when socket activation is > used, because MPD does not know what port to announce. Would getsockname(2) help? --Ben ___ mpd-devel mailing list m

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-02 Thread Max Kellermann
On 2014/12/03 02:56, Punky wrote: > In zeroconf module, listen_port variable is used. listen_port variable > should be set to the value that MPD (successfully) listens to, and if TCP > port (default 6600) is being configured But listen_port is ignored when systemd socket activation is used. With

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-02 Thread Punky
Hi Max and all, On Wed, Dec 3, 2014 at 4:39 AM, Max Kellermann wrote: > > > listen_systemd_activation() is true. Then the function exit > > immediately without setting listen_port = port. > > Correct. Which value do you expect it to have, and where will it > obtain that value from? > In zeroc

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-02 Thread Max Kellermann
On 2014/12/02 08:13, Punky wrote: > Since jessie now uses systemd instead of sysvinit, But does it enable socket activation by default? > listen_systemd_activation() is true. Then the function exit > immediately without setting listen_port = port. Correct. Which value do you expect it to have

[mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-01 Thread Punky
Hi all, I am now trying Debian jessie with 0.19.1. However, zeroconf is not enabled, and /var/log/mpd/mpd.log shows "zeroconf: No global port, disabling zeroconf". Further looking into the code, I found the following in zeroconf/ZeroconfGlue.cxx, line 52-57: if (listen_port <= 0) { LogW