Changeset: 1672f0212f02
Author:chegar
Date: 2010-04-13 12:02 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1672f0212f02
6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName()
returned non null but empty String
Reviewed-by: alanb, michaelm, andrew
!
Changeset: ed61accf772e
Author:chegar
Date: 2010-04-15 16:37 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed61accf772e
6943219:
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java
fail in linux
Reviewed-by: andrew
!
Hi Alan,
net_util_md.h incorrectly defines the macro IN6_IS_ADDR_ANY to only look
at 12 bytes of the 16 byte address. This causes a bind to ::1 to be
treated as if it were a bind to the wildcard address.
Note: with the addition of the dual stack native implementation on Vista
this code is
On 26/04/2010 14:37, Alan Bateman wrote:
Chris Hegarty wrote:
Hi Alan,
net_util_md.h incorrectly defines the macro IN6_IS_ADDR_ANY to only
look at 12 bytes of the 16 byte address. This causes a bind to ::1 to
be treated as if it were a bind to the wildcard address.
Note: with the addition
Changeset: 0c27202d66c1
Author:chegar
Date: 2010-04-27 09:42 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0c27202d66c1
6718504: IN6_IS_ADDR_ANY tests only 12 bytes of 16-byte address
Reviewed-by: alanb
! src/windows/native/java/net/net_util_md.h
+
:
http://cr.openjdk.java.net/~chegar/6886723/webrev.01/webrev/
-Chris.
Chris Hegarty wrote:
Hi Michael,
The HttpExchange implementation, sun.net.httpserver.ExchangeImpl, does
not correctly handle HEAD requests. The test, described in the
'description section' of 6886723, invokes
length.
Thanks, I added some tests for Content-length also.
-Chris.
- Michael.
Chris Hegarty wrote:
Michael,
Since we spoke off line about this, I implemented the changes we
discussed. That is...
To adhere to the API sendResponseHeaders should be invoked with a
contentLength of -1, i.e
Hi Michael,
The Server implementation keeps a list of HttpConnection instances
(which hold SelektionKeyImpl instances) per connection. After accepting
a new connection a HttpConnection is created and added to the list. It
is never removed if the request turns out to be BAD.
Other instances
Michael,
A minor change to the encoder used for Basic Authentication.
Webrev:
http://cr.openjdk.java.net/~chegar/6947917/webrev.00/webrev/
The Basic Authentication implementation,
sun.net.www.protocol.http.BasicAuthentication, uses a
sun.misc.BASE64Encoder to encode the Authentication
Hi Alan,
This is a formal review for source changes for 6946673. We already
discussed the these spec changes off line.
Webrev:
http://cr.openjdk.java.net/~chegar/6946673/webrev.00/webrev/
BlenderRev:
http://cr.openjdk.java.net/~chegar/6946673/DatagramSocketBelnderRev.html
Problem
Changeset: 4fba3512c566
Author:chegar
Date: 2010-05-07 16:11 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4fba3512c566
6946673: DatagramSocket.connect() documentation contradicts the implementation
Reviewed-by: alanb
! src/share/classes/java/net/DatagramSocket.java
Changeset: 489c1720757b
Author:chegar
Date: 2010-06-08 10:46 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/489c1720757b
6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail
after rebranding
Reviewed-by: ohair, wetmore, alanb
!
Hi Michael, Max,
This is a code review request for CR 6954525: Testcase failure
java/net/Authenticator/B4769350.java.
Essentially, there is a race among requesting threads in the test. The
threads are making HTTP requests requiring authentication. This is fine,
and what the test is trying
Changeset: 6d274503d1b7
Author:chegar
Date: 2010-06-28 14:55 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d274503d1b7
6954525: Testcase failure java/net/Authenticator/B4769350.java
Reviewed-by: michaelm, weijun
!
Michael,
java/net/BindException/Test.java and java/net/ipv6tests/Tests.java have
code that iterator over the network interfaces looking for IPv4
addresses to test with. In some cases, it is possible to have an
interface that is up with an IPv4 address of 0.0.0.0. This is not
suitable for use
Changeset: 7c3da1f0e17c
Author:chegar
Date: 2010-06-28 20:52 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c3da1f0e17c
6961029: java/net/BindException/Test.java should not use wildcard address
Reviewed-by: michaelm, alanb
! test/ProblemList.txt
!
Michael,
CR 6967684: httpserver using a non thread-safe SimpleDateFormat
Bug description says it all. I guess in reality this may have gone
unseen for so long because, if two or more threads were servicing
requests the dates they would be generating should be fairly similar,
but worst case
On 07/09/10 10:10, Michael McMahon wrote:
Chris Hegarty wrote:
Michael,
CR 6967684: httpserver using a non thread-safe SimpleDateFormat
Bug description says it all. I guess in reality this may have gone
unseen for so long because, if two or more threads were servicing
requests the dates
On 07/09/10 11:27, Michael McMahon wrote:
Chris Hegarty wrote:
On 07/09/10 10:10, Michael McMahon wrote:
Chris Hegarty wrote:
Michael,
CR 6967684: httpserver using a non thread-safe SimpleDateFormat
Bug description says it all. I guess in reality this may have gone
unseen for so long
On 07/09/10 12:10, Michael McMahon wrote:
Chris Hegarty wrote:
On 07/09/10 11:27, Michael McMahon wrote:
Chris Hegarty wrote:
On 07/09/10 10:10, Michael McMahon wrote:
Chris Hegarty wrote:
Michael,
CR 6967684: httpserver using a non thread-safe SimpleDateFormat
Bug description says
Alan, Dmitry, Michael,
CR: Scope id no longer being set after 6931566
CR 6931566 accidentally removes the setting of the scope id for IPv6
addresses before adding them to the interface list. This was missed
during code review as there was a lot of refactoring to clean up the
code. The
On 07/12/10 12:32, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Dmitry, Michael,
CR: Scope id no longer being set after 6931566
CR 6931566 accidentally removes the setting of the scope id for IPv6
addresses before adding them to the interface list. This was missed
during code review
Dmitry, looks good.
-Chris.
Dmitry Samersoff wrote:
On 2010-07-12 22:30, Alan Bateman wrote:
Dmitry Samersoff wrote:
Alan,
Thank you for the comments.
Fixed.
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/
-Dmitry
The copyright date on the new test says 2008 :-)
Copy-paste
Alan,
Can you please review these various updates to the jdk net regression
tests. Mainly closing of sockets, samevm issues, dial back of tests, etc..
Webrev:
http://cr.openjdk.java.net/~chegar/6969395/webrev.00/webrev/
Thanks.
-Chris.
Alan Bateman wrote:
Weijun Wang wrote:
Hi All
I'm working on some Kerberos codes and need to use the
ResolverConfiguration class.
Webrev:
http://cr.openjdk.java.net/~weijun/6969683/webrev.01
Thanks for updating this. Looks good to me.
Yes, thanks for this. Looks good.
-Chris.
Dmitry, Alan,
Trivially update the @run tag to the correct class name.
diff -r f3a4c1947fd1 test/java/net/NetworkInterface/IPv4Only.java
--- a/test/java/net/NetworkInterface/IPv4Only.java Tue Jul 13 20:27:01
2010 +0800
+++ b/test/java/net/NetworkInterface/IPv4Only.java Tue Jul 20 10:06:05
On 07/19/10 15:11, Alan Bateman wrote:
Chris Hegarty wrote:
:
In samevm mode all the http server tests that use SSL fail with
java.lang.NoClassDefFoundError: Could not initialize class
javax.crypto.JceSecurityManager. This is really weird. I exchanged
mail with Jon Gibbons about this, but we
On 07/21/10 12:58, Alan Bateman wrote:
Chris Hegarty wrote:
:
Thinking about this. If the test ever fails, even with a rerun, can we
be certain that it is a bug or just a slow machine? I guess removing
the test may be the best course of action. If you agree, 'hg remove'
or something else?
I
Changeset: 58f325ba3e27
Author:chegar
Date: 2010-07-21 13:29 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27
6969395: TEST_BUG: Tests in java/net sun/net problems
Reviewed-by: alanb
! test/ProblemList.txt
! test/com/sun/net/httpserver/Test1.java
!
Changeset: f90999d7c404
Author:chegar
Date: 2010-07-21 13:52 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f90999d7c404
6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test
name in @run tag
Reviewed-by: alanb, dsamersoff
!
Dmitry, Alan,
The Solaris version of getFlags sets an Exception if the ioctl fails.
When used in addif getFlags will fail when access to the virtual
interface's parent is forbidden, i.e. in a zone. addif is called when
iterating over interfaces in enumIPvXInterfaces, if an exception occurs
On 07/28/10 10:25, Alan Bateman wrote:
Chris Hegarty wrote:
Dmitry, Alan,
The Solaris version of getFlags sets an Exception if the ioctl fails.
When used in addif getFlags will fail when access to the virtual
interface's parent is forbidden, i.e. in a zone. addif is called when
iterating over
Changeset: a8a79f5b669e
Author:chegar
Date: 2010-07-29 10:02 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8a79f5b669e
6972374: NetworkInterface.getNetworkInterfaces throws
java.net.SocketException on Solaris zone
Reviewed-by: alanb, dsamersoff
!
Michael,
Send the Proxy-Connection: keep-alive header with HTTP CONNECT
requests for compatibility with HTTP/1.0 proxies such as Squid. This is
required for NTLM authentication.
Webrev:
http://cr.openjdk.java.net/~chegar/6973030/webrev.00/webrev/
Thanks,
-Chris.
Michael, The change looks fine.
-Chris.
On 07/30/10 13:30, Michael McMahon wrote:
Michael McMahon wrote:
Chris,
Could you review this one please. Test opens 1000 sockets, which is close
to the default limit on many Linuxes. Solution is to run in othervm mode.
On 07/30/10 14:44, Michael McMahon wrote:
Chris Hegarty wrote:
Michael,
Send the Proxy-Connection: keep-alive header with HTTP CONNECT
requests for compatibility with HTTP/1.0 proxies such as Squid. This
is required for NTLM authentication.
Webrev:
http://cr.openjdk.java.net/~chegar/6973030
Changeset: 367b90ed38b1
Author:chegar
Date: 2010-08-03 12:03 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/367b90ed38b1
6973030: NTLM proxy authentication fails with https
Reviewed-by: michaelm
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
!
Alan,
Don't assume sockets will default to dual stack, explicitly set
IPV6_V6ONLY to 0. Apparently some Linux distros ship with
net.ipv6.bindv6only=1 restricting sending and receiving to IPv6 packets
only. Changes both net and nio code.
Webrev:
Alan Bateman wrote:
Chris Hegarty wrote:
Alan,
Don't assume sockets will default to dual stack, explicitly set
IPV6_V6ONLY to 0. Apparently some Linux distros ship with
net.ipv6.bindv6only=1 restricting sending and receiving to IPv6
packets only. Changes both net and nio code.
Webrev
Changeset: 1f996198877b
Author:chegar
Date: 2010-08-10 17:30 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f996198877b
6882910: Unexplained lack of IP4 network ability when transparent IP6 to IP4 is
disabled.
Reviewed-by: alanb
!
Michael, This change looks fine.
-Chris
Michael McMahon wrote:
Chris,
Could you review the following small change?
http://cr.openjdk.java.net/~michaelm/6339649/webrev.1/
I think it's a useful change, since many applications won't bother to
even catch the runtime exception except at a fairly
Michael,
java.net.HttpCookie uses static SimpleDateFormat which is not thread
safe. I think the best solution here is to simply create local
SimpleDateFormat as needed.
Webrev:
http://cr.openjdk.java.net/~chegar/6965924/webrev.00/webrev/
Thanks,
-Chris.
On 18/08/2010 11:28, gustav trede wrote:
On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com
mailto:chris.hega...@oracle.com wrote:
Michael,
java.net.HttpCookie uses static SimpleDateFormat which is not thread
safe. I think the best solution here is to simply create
gustav trede wrote:
On 18 August 2010 13:22, Michael McMahon michael.x.mcma...@oracle.com
mailto:michael.x.mcma...@oracle.com wrote:
gustav trede wrote:
On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com
mailto:chris.hega...@oracle.com
Changeset: fd28003bc1d6
Author:chegar
Date: 2010-08-23 14:35 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd28003bc1d6
6968584: Thread should not be Cloneable
Reviewed-by: dholmes
! src/share/classes/java/lang/Thread.java
Changeset: 03218163f4d5
Author:chegar
Date: 2010-08-23 16:27 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03218163f4d5
6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread
safe
Reviewed-by: michaelm
! src/share/classes/java/net/HttpCookie.java
Michael,
The file handler can fail with NPE in cases where permission is denied
to the directory. Small change, throw FileNotFoundException where a
directory listing is not available.
Webrev:
http://cr.openjdk.java.net/~chegar/6977851/webrev.00/webrev/
Thanks,
-Chris.
Michael McMahon wrote:
Chris Hegarty wrote:
Michael,
The file handler can fail with NPE in cases where permission is denied
to the directory. Small change, throw FileNotFoundException where a
directory listing is not available.
Webrev:
http://cr.openjdk.java.net/~chegar/6977851/webrev.00
Changeset: cb67f0263bd4
Author:chegar
Date: 2010-08-23 21:59 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb67f0263bd4
6977851: NPE from FileURLConnection.connect
Reviewed-by: michaelm
! src/share/classes/sun/net/www/protocol/file/FileURLConnection.java
+
Changeset: 6960b4f07bf9
Author:chegar
Date: 2010-09-10 15:57 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6960b4f07bf9
6980517: TEST_BUG sun\net\www\http\ChunkedInputStream\ChunkedEncodingTest.java
NullPointerException
Reviewed-by: michaelm
!
Michael,
When we're in streaming mode (chunked or fixed length) the HTTP client
implementation does not buffer the output data (this is the intention of
streaming mode). Since we don't know the users data then we cannot
silently retry in the event of an error when reading the response
Changeset: cd4aad589b3f
Author:chegar
Date: 2010-09-21 15:58 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd4aad589b3f
6672144: HttpURLConnection.getInputStream sends POST request after failed
chunked
Reviewed-by: michaelm
!
Changeset: 570f825ad872
Author:chegar
Date: 2010-09-29 17:33 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/570f825ad872
6987461: Handle leak when enabling java.net.useSystemProxies
Summary: Release the registry key handle if ProxyEnable is 0
Reviewed-by: michaelm
!
Some compiler warnings in the networking native code.
http://cr.openjdk.java.net/~chegar/6989690/webrev.00/webrev/
-Chris.
Changeset: 0e3daaccfbdf
Author:xuelei
Date: 2010-06-12 00:42 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0e3daaccfbdf
6914943: Implement final TLS renegotiation fix
Summary: RFC 5746 implementation
Reviewed-by: wetmore, weijun
!
Changeset: 4dbd83eb0250
Author:chegar
Date: 2010-10-12 11:11 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4dbd83eb0250
6989690: java/net native code compiler warnings
Reviewed-by: alanb
! src/solaris/native/java/net/PlainDatagramSocketImpl.c
!
Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,
This is the JDK part of the changes for this CR. Trivially, it just
fixes the unsafe lazy initialization of default instance of MimeTable.
http://cr.openjdk.java.net/~chegar/6863419/webrev.00/webrev/
Thanks,
-Chris.
Looks okay to me
Changeset: a4fd754f895d
Author:chegar
Date: 2010-10-12 17:01 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a4fd754f895d
6991300: MimeTable is unsafe
Reviewed-by: alanb, michaelm
! src/share/classes/sun/net/www/MimeTable.java
[bcc'ing off jdk7-dev and cc'ing net-dev, to continue the conversation]
Alan Bateman wrote:
Guenther Niess wrote:
.
I don't think there is a mailing list for JNDI here but given that this
seems to be an issue with the DNS provider, then net-dev would be a good
place to bring it up. It's
Hi Guenther,
Before we can accept patches or changes from an external contributor you
must sign the Contributor Agreement [1]. I looked at the list of
contributors and cannot find you listed.
I haven't looked at the patch yet, but I have looked at the testcase
that's in CR 6991580. Have you
Alan, Michael,
Clean up some issue found by findbugs; reference to mutable array being
exposed, unused variables/imports.
http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/
Thanks,
-Chris.
Alan, Michael,
While this is an internal API and not supported, there is certainly an
issue in the implementation that crept in a while back. setIfNotSet is
using cachePolicy while get() may not return this value (depending on
whether there is a security manager installed, or if the policy
Hi Michael,
The resetting of the read timeout after, error stream buffering, Expect
100-Continue handling, and keepalive cleaner, may be problematic if the
read timeout is the default value. The default read tmeout is -1 ( not
set ), but Networkclient.setReadTimeout ignores values less than
Hi Michael,
On some Linuxes, when bound to the loopback interface, sendto will fail
and errno will be set to EINVAL. When that happens, don't throw an
exception, just return false. We already do this in the case where we
cannot create raw sockets, i.e. when not running as root.
On 21/10/2010 14:05, Alan Bateman wrote:
Chris Hegarty wrote:
Hi Michael,
On some Linuxes, when bound to the loopback interface, sendto will
fail and errno will be set to EINVAL. When that happens, don't throw
an exception, just return false. We already do this in the case where
we cannot
On 21/10/2010 15:25, Alan Bateman wrote:
Chris Hegarty wrote:
:
It appears to be specific to the loopback interface. You can reproduce
the very same behavior using DatagramSocket and DatagramChannel; bind
to the loopback address and send a packet to a remote address.
I was not too happy
Changeset: 70bf328b7c65
Author:chegar
Date: 2010-10-21 16:49 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70bf328b7c65
6993490: SocketTimeoutException on HTTP keep-alive connections
Reviewed-by: michaelm
! src/share/classes/sun/net/NetworkClient.java
!
Changeset: 549257d35662
Author:chegar
Date: 2010-10-22 09:20 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/549257d35662
6947677: InetAddress.isReachable() throws java.net.SocketException:Invalid
argument on Linux if run as root
Reviewed-by: alanb
!
Alan, Michael,
connect(SocketAddress,int) should close the underlying file descriptor
if it fails for any reason. This is consistent with the other connect
methods. A little other cleanup while there.
http://cr.openjdk.java.net/~chegar/6994079/webrev.00/webrev/
-Chris.
Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,
connect(SocketAddress,int) should close the underlying file descriptor
if it fails for any reason. This is consistent with the other connect
methods. A little other cleanup while there.
http://cr.openjdk.java.net/~chegar/6994079
Changeset: 0b07344d5526
Author:chegar
Date: 2010-10-22 20:27 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b07344d5526
6994079: PlainSocketImpl should close the socket if it fails
Reviewed-by: alanb
! src/share/classes/java/net/AbstractPlainSocketImpl.java
Changeset: bf284d2db008
Author:chegar
Date: 2010-11-15 15:11 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf284d2db008
6993789: LinkedBlockingDeque iterator/descendingIterator loops and owns lock
forever
Reviewed-by: dl, dholmes
!
Changeset: d5489d652f6f
Author:dl
Date: 2010-11-19 10:43 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5489d652f6f
6712185: java/util/concurrent/Executors/AutoShutdown.java fails on slow or busy
systems
Reviewed-by: chegar, alanb
! test/ProblemList.txt
!
Changeset: 9e494de19690
Author:dl
Date: 2010-12-01 21:46 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9e494de19690
7003745: Code style cleanups (sync from Dougs CVS)
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/AbstractCollection.java
!
Hi Michael,
The native sockaddr is not being correctly set in sctp_setpeerprim.
Also, the value of SCTP_SET_PEER_PRIMARY_ADDR should not be an
IPv4-mapped address for IPv4 addresses on lksctp. It should be an IPv4
address, in a similar way to how we handle addresses being passed to bindx.
The changes look fine.
-Chris.
On 04/01/2011 15:08, Alan Bateman wrote:
jdk7-b123 has hs20-b04 and so has the changes to 6348631 to remove the
dependency on the HPI library. One causality is that
InetAddress.isReachable now crashes the VM on Windows as it hits a
ShouldNotReachHere guarantee.
Changeset: b8663921f5d7
Author:chegar
Date: 2011-01-07 13:08 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8663921f5d7
7000511: PrintStream, PrintWriter, Formatter, Scanner leave files open when
exception thrown
Reviewed-by: alanb, mduigou
!
Alan,
In socketGetOption() function if the option is
java_net_SocketOptions_SO_BINDADDR the code allocates a SOCKET_ADDRESS,
him, structure on the stack. This structure is 8 bytes long. 'len' is
then set to sizeof(struct sockaddr_in) which is 16. If it's an IPV6
socket the len could get set
Changeset: 6bf1c5958c22
Author:chegar
Date: 2011-01-07 21:02 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6bf1c5958c22
7009760: Possible stack corruption in
Java_java_net_TwoStacksPlainSocketImpl_socketGetOption
Summary: SOCKET_ADDRESS - SOCKETADDRESS
Reviewed-by: alanb
Michael, Alan,
Provide a property for setting the SOCKS V4 proxy version.
http://cr.openjdk.java.net/~chegar/6964547/webrev.00/
Thanks,
-Chris.
Changeset: cb3ecb5e4ce5
Author:dl
Date: 2011-01-12 14:40 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb3ecb5e4ce5
7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011
Reviewed-by: dholmes, chegar, mduigou
! src/share/classes/java/util/Collections.java
!
I received some offline comments on this.
1) SocksProxyVersionFour - SocksProxy
2) SocksProxy now contains the protocol version
Updated webrev:
http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/
-Chris.
On 01/11/11 03:00 PM, Chris Hegarty wrote:
Michael, Alan,
Provide a property
On 01/12/11 03:36 PM, Alan Bateman wrote:
Damjan Jovanovic wrote:
Can I also suggest that Proxy.Type.SOCKS gets deprecated and
Proxy.Type.SOCKS4 and Proxy.Type.SOCKS5 get introduced instead?
Just about every application treats SOCKS 4 and 5 as different proxy
types, only Java tries to lump
On 01/12/11 03:24 PM, Alan Bateman wrote:
Chris Hegarty wrote:
I received some offline comments on this.
1) SocksProxyVersionFour - SocksProxy
2) SocksProxy now contains the protocol version
Updated webrev:
http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/
-Chris.
This looks
On 01/12/11 06:25 PM, Alan Bateman wrote:
Chris Hegarty wrote:
:
Updated Webrev:
http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/
Looks fine except that that main thread needs to wait for the socks
server thread to terminate as otherwise the test might pass before the
thread sets
On 01/13/11 09:29 AM, Alan Bateman wrote:
Chris Hegarty wrote:
:
Ah yes, I just moved the socket close to after the version check. The
client will be blocked (in the socks protocol handhake) until the
socket on the server side is closed.
Updated test:
http://cr.openjdk.java.net/~chegar
Changeset: 694951adefec
Author:chegar
Date: 2011-01-13 13:24 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/694951adefec
6964547: Impossible to set useV4 in SocksSocketImpl
Summary: Add socksProxyVersion property
Reviewed-by: alanb, michaelm
! make/sun/net/FILES_java.gmk
!
Michael,
Trivially, the number of keep-alive connections is not being correctly
compared to the maximum number, set by http.maxConnections. The
condition is greater than and allows the cache keep a number of
http.maxConnections + 1.
hg diff
Michael, Alan,
There is an issue in InetAddress.getAddressesFromNameService, whereby if
the nameservice provider throws an unchecked exception it leaves the
host being looked up in the lookupTable. This will cause any further
lookups of that host to block and wait forever.
Once a host is
Changeset: e64b1f11cd0b
Author:chegar
Date: 2011-01-20 15:23 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e64b1f11cd0b
7011857: java/util/concurrent/Phaser/FickleRegister.java fails on solaris-sparc
Summary: Remove from ProblemList, failure resolved by 7009231
Reviewed-by:
On 20/01/2011 14:17, Alan Bateman wrote:
The changes to InetAddress look good to me. I see the existing tests for
this spi are in test/sun/net/InetAddress and maybe the tests should go
there (I realize it might mean moving some existing tests but the
benefit is that the tests for this
On 01/20/11 04:33 PM, Alan Bateman wrote:
...
One small suggestion is to rename B6442088.java while you are there (it
looks odd given that the rest of the tests have proper names).
All tests now have real names, and I updated the @build to @compile to
compile with -XDignore.symbol.file=true,
Changeset: 2a8d1a0a2418
Author:chegar
Date: 2011-01-21 17:02 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a8d1a0a2418
7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name
service spi
Reviewed-by: alanb, michaelm
!
On 01/28/11 12:27 PM, Alan Bateman wrote:
Joe pushed the changes to jdk7/tl/langtools a few days ago to remove the
general expression support from the try-with-resources statement. Looks
like one networking test was missing with the result that it no longer
compiles with a build of jdk7/tl.
Changeset: 3c86f24f7500
Author:chegar
Date: 2011-02-03 10:10 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c86f24f7500
7008595: Class loader leak caused by keepAliveTimer thread in KeepAliveCache
Reviewed-by: michaelm
!
Changeset: 0f5dc2fc81b1
Author:chegar
Date: 2011-02-03 11:56 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f5dc2fc81b1
6887710: Jar index should avoid putting META-INF in the INDEX.LIST
Reviewed-by: michaelm
! src/share/classes/sun/misc/JarIndex.java
+
Changeset: 94bcd9aa2119
Author:chegar
Date: 2011-02-07 14:08 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94bcd9aa2119
7016898: PlainSocketImpl.fd is null on Windows
Reviewed-by: alanb
! src/windows/classes/java/net/PlainSocketImpl.java
Changeset: 15ef6cf616d6
Author:chegar
Date: 2011-02-17 09:56 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15ef6cf616d6
7017901: OOME in
java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java
Summary: Unbounded queues should be disabled in the test
On 02/22/11 03:00 AM, Charles Lee wrote:
:
Hi,
A quick patch could be:
diff --git src/share/classes/java/net/SocketPermission.java
src/share/classes/java/net/SocketPermission.java
--- src/share/classes/java/net/SocketPermission.java
+++ src/share/classes/java/net/SocketPermission.java
@@
Changeset: 892c3fc7249e
Author:dl
Date: 2011-02-23 14:56 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/892c3fc7249e
7017493: ConcurrentLinkedDeque: Unexpected initialization order can lead to
crash due to use of Unsafe
Reviewed-by: chegar
!
1 - 100 of 1795 matches
Mail list logo
