Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote: We actually need two votes now per patch now: - 5.5.1 (now in pre1) +1(though I'd be tempted to set the two lengths at the start of the loop, rather than the end) - 5.6.1 (now in rc1) Hmm this isn't really a show-stopper, so strictly speaking shouldn't be applied. (Particularly since we're trying to be a bit more rapid at getting releases out of the door.) On the other hand, it's such a simple and safe patch that it seems churlish not to apply it. +1 IFF there are other changes applied to 5.6.1.rc1 (and hence a need for rc2) -1 otherwise Dave -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: doubt in nested table implementation
Thanks Wes. Ignore my last query on netsnmp_table_helper_add_indexes(). I found where I did make the mistake. From: sujata patra sujata_patra2...@yahoo.com To: Wes Hardaker harda...@users.sourceforge.net Cc: Wes Hardaker harda...@users.sourceforge.net; net-snmp-coders@lists.sourceforge.net Sent: Wed, December 22, 2010 2:46:33 PM Subject: Re: doubt in nested table implementation From: Wes Hardaker harda...@users.sourceforge.net To: sujata patra sujata_patra2...@yahoo.com Cc: Wes Hardaker harda...@users.sourceforge.net; net-snmp-coders@lists.sourceforge.net Sent: Wed, December 22, 2010 10:05:34 AM Subject: Re: doubt in nested table implementation On Tue, 21 Dec 2010 20:15:12 -0800 (PST), sujata patra sujata_patra2...@yahoo.com said: sp Thanks Wes. That's right . I have got it now and able to progress . I was sp confused whether to make tree structure . Tree structures are not supported by SMIv2 (the MIB language). If you're getting the point of needing to do that it's probably time to pick up a book on good mib design (Understanding SNMP MIBs is a good one). sp This is basically making the tree to linear array by storing the sp indexes of each parent/grand parent node. right ? If you're familiar with relational databases, MIBs follow similar concepts. The topic is much longer than I can explain quickly over mail, so I suggest you either read a good book or read the RFC itself (RFC2578). sp I have added all the columns. sp netsnmp_table_helper_add_indexes(table_info, The only columns you should add are the indexes. The rest of them shouldn't be there. But how to tell about the columns? I do update the values of table_info-min_column =; table_info-max_column = ; stack trace of crash point. This is for a single table. #0 snmp_set_var_value (vars=0x0, value=0xbfdcea12, len=10) at snmp_client.c:765 #1 0x08048f43 in messageTable_get_next_data_point (my_loop_context=0xbfdcecd8, my_data_context=0xbfdcecd4, put_index_data=0x91c17a8, mydata=0x9161718) at abcModule.c:158 #2 0x0015f572 in netsnmp_table_iterator_helper_handler (handler=0x9161748, reginfo=0x9161438, reqinfo=0x91a9d48, requests=0x91aa728) at helpers/table_iterator.c:587 #3 0x001206c2 in netsnmp_call_handler (next_handler=0x9161748, reginfo=0x9161438, reqinfo=0x91a9d48, requests=0x91aa728) at agent_handler.c:522 netsnmp_table_helper_add_indexes(table_info, ASN_INTEGER, /* ASN_OCTET_STR, ASN_INTEGER, ASN_INTEGER, ASN_INTEGER,*/ 0); It works fine if I uncomment the commented part from the above . any missing piece? attaching the file for your reference -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On Wed, Dec 22, 2010 at 3:28 AM, Dave Shield d.t.shi...@liverpool.ac.uk wrote: On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote: - 5.6.1 (now in rc1) Hmm this isn't really a show-stopper, so strictly speaking shouldn't be applied. It's somehow a regression against net-snmp 5.5, so IMO it is more important for 5.6. I can't explain what is different in 5.5 that it worked with the same code, but it did. Bill -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
CFV: Fix for bug 3109144: cant load vacmView from persistent storage
The bug describes how the view mask is lost when read from the snmpd persistent file. This patch fixes it (and removes some identity casts). The crucial point is setting the viewMaskLen before calling read_octet_string. Index: snmplib/vacm.c === --- snmplib/vacm.c (revision 19758) +++ snmplib/vacm.c (working copy) @@ -192,10 +192,10 @@ vptr-viewStatus = view.viewStatus; vptr-viewStorageType = view.viewStorageType; vptr-viewType = view.viewType; -viewMask = (u_char *) vptr-viewMask; +viewMask = vptr-viewMask; +vptr-viewMaskLen = sizeof(vptr-viewMask); line = -read_config_read_octet_string(line, (u_char **) viewMask, - vptr-viewMaskLen); +read_config_read_octet_string(line, viewMask, vptr-viewMaskLen); } /* This is relevant for all versions :-( /Niels -- Niels Baggesen -- @home -- Århus -- Denmark -- n...@users.sourceforge.net The purpose of computing is insight, not numbers -- R W Hamming -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On Wed, 22 Dec 2010 08:28:56 + Dave wrote: DS On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote: DS We actually need two votes now per patch now: DS DS - 5.5.1 (now in pre1) DS DS +1(though I'd be tempted to set the two lengths DS at the start of the loop, rather than the end) +1 (the lengths are initialized at the top of the function, so I think then end of the loop is fine. nothing is saved by moving it to the start.) DS - 5.6.1 (now in rc1) DS DS Hmm this isn't really a show-stopper, so strictly speaking DS shouldn't be applied. I dunno... I think broken AgentX processing is a pretty big deal. And given that we have a nice simple fix... +1. The other option, if no other show-stoppers come up, is to wuickly push rc1 as final, and prep for 5.6.1.1 or 5.6.2 almost immediately. -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: Fix for bug 3109144: cant load vacmView from persistent storage
On Wed, 22 Dec 2010 15:55:14 +0100 Niels wrote: NB The bug describes how the view mask is lost when read from the snmpd NB persistent file. NB NB This patch fixes it (and removes some identity casts). The crucial NB point is setting the viewMaskLen before calling read_octet_string. +1 -- Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On 22 December 2010 16:13, Robert Story rst...@freesnmp.com wrote: DS - 5.6.1 (now in rc1) DS DS Hmm this isn't really a show-stopper, so strictly speaking DS shouldn't be applied. I dunno... I think broken AgentX processing is a pretty big deal. But remember the definition of show stopper * A condition that results in a security vulnerability. * A condition such that a default configure; make; make install fails * A condition such that make test fails Unless I've missed something, the effects of this particular problem don't match any of these three cases. (I believe it results in wrong or missing information - though I haven't been paying much attention to the lists recently!) Maybe we need to review our definitions of show stopper at next month's admin meeting. The other option, if no other show-stoppers come up, is to wuickly push rc1 as final, and prep for 5.6.1.1 or 5.6.2 almost immediately. Rather than that, it would be more sensible to roll rc2. (If this problem is sufficient to trigger a minor minor release, then it's definitely sufficient to trigger another RC) Dave -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: Fix for bug 3109144: cant load vacmView from persistent storage
On 22 December 2010 14:55, Niels Baggesen n...@users.sourceforge.net wrote: The bug describes how the view mask is lost when read from the snmpd persistent file. 5.5.1: +1 5.6.1: +1 iff rc2 scheduled -1 otherwise Dave -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On Wed, 22 Dec 2010 18:55:49 +, Dave Shield d.t.shi...@liverpool.ac.uk said: DS Unless I've missed something, the effects of this particular problem DS don't match any of these three cases. (I believe it results in wrong DS or missing information - though I haven't been paying much attention DS to the lists recently!) Quick! Write a test case! More seriously, we have agentx test cases but none of them are currently requesting multiple varbinds at once. DS Maybe we need to review our definitions of show stopper at DS next month's admin meeting. Probably a worthy discussion. -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On Wed, 22 Dec 2010 07:34:44 -0500, Bill Fenner fen...@gmail.com said: BF It's somehow a regression against net-snmp 5.5, so IMO it is more BF important for 5.6. I can't explain what is different in 5.5 that it BF worked with the same code, but it did. I suspect luck was involved. I suspect if you ran it on a different architecture it may have even reared it's head. It certainly is interesting... Cause the problem is definitely there in both releases. -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds
On 22 December 2010 21:51, Wes Hardaker harda...@users.sourceforge.net wrote: DS Maybe we need to review our definitions of show stopper at DS next month's admin meeting. Probably a worthy discussion. I've added this to the agenda. (Having first created an agenda to add it to :-)) Dave -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
schedule for 5.6.1
5.6.1.rc2: 12/28 5.6.1: 1/4 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
