Re: eBPF: how to check the flow table

2016-09-18 Thread Eric Leblond
Hello, On Sun, 2016-09-18 at 14:02 +0200, Eric Leblond wrote: > Hello, > > I'm currently testing a code implementing AF_PACKET bypass for > Suricata. The idea is that Suricata is updating a hash table > containing > a list of flows it does not want to see anymore. > > I want to check flow timeou

[patch net-next] mlxsw: spectrum: Fix sparse warnings

2016-09-18 Thread Jiri Pirko
From: Ido Schimmel drivers/net/ethernet/mellanox/mlxsw//spectrum.c:251:28: warning: symbol 'mlxsw_sp_span_entry_find' was not declared. Should it be static? drivers/net/ethernet/mellanox/mlxsw//spectrum.c:265:28: warning: symbol 'mlxsw_sp_span_entry_get' was not declared. Should it be static? dri

[patch net-next] mlxsw: Change the RX LAG hash function from XOR to CRC

2016-09-18 Thread Jiri Pirko
From: Elad Raz Change the RX hash function from XOR to CRC in order to have better distribution of the traffic. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ether

Re: [PATCH] net: skbuff: Fix length validation in skb_vlan_pop()

2016-09-18 Thread Shmulik Ladkani
Hi, On Sun, 18 Sep 2016 13:26:30 -0700, pshe...@ovn.org wrote: > On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani > wrote: > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > index 1e329d4112..cc2c004838 100644 > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -4537,7 +4537,7

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-18 Thread Jiri Pirko
Mon, Sep 19, 2016 at 01:16:17AM CEST, ro...@cumulusnetworks.com wrote: >On 9/18/16, 1:00 PM, Florian Fainelli wrote: >> Le 06/09/2016 à 05:01, Jiri Pirko a écrit : >>> From: Jiri Pirko >>> >>> This is RFC, unfinished. I came across some issues in the process so I would >>> like to share those and

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-18 Thread Jiri Pirko
Sun, Sep 18, 2016 at 10:00:44PM CEST, f.faine...@gmail.com wrote: >Le 06/09/2016 à 05:01, Jiri Pirko a écrit : >> From: Jiri Pirko >> >> This is RFC, unfinished. I came across some issues in the process so I would >> like to share those and restart the fib offload discussion in order to make >>

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-18 Thread Jiri Pirko
Mon, Sep 19, 2016 at 01:23:47AM CEST, ro...@cumulusnetworks.com wrote: >On 9/6/16, 5:01 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This allows to pass information about added/deleted fib entries to >> whoever is interested. This is done in a very similar way as devinet >> notifies address add

Re: [PATCH net-next 00/11] rxrpc: Tracepoint addition and improvement

2016-09-18 Thread David Miller
From: David Howells Date: Sun, 18 Sep 2016 00:21:29 +0100 > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160917-2 Pulled.

Re: [PATCH net-next 00/14] rxrpc: Fixes & miscellany

2016-09-18 Thread David Miller
From: David Howells Date: Sun, 18 Sep 2016 00:17:44 +0100 > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160917-1 Pulled.

Re: [PATCH net-next 0/5] sched: convert queues to single-linked list

2016-09-18 Thread David Miller
From: Florian Westphal Date: Sun, 18 Sep 2016 00:57:29 +0200 > During Netfilter Workshop 2016 Eric Dumazet pointed out that qdisc > schedulers use doubly-linked lists, even though single-linked list > would be enough. > > The double-linked skb lists incur one extra write on enqueue/dequeue > ope

Re: [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()

2016-09-18 Thread David Miller
From: Wei Yongjun Date: Sat, 17 Sep 2016 15:52:17 + > From: Wei Yongjun > > Fix the retrn value check which testing the wrong variable > in cfg_queues_uld(). > > Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of > resources for ULD") > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next v3 0/3] net: ethernet: mediatek: add HW LRO functions

2016-09-18 Thread David Miller
From: Nelson Chang Date: Sat, 17 Sep 2016 23:54:07 +0800 > The series add the large receive offload (LRO) functions by hardware and > the ethtool functions to configure RX flows of HW LRO. Series applied.

Re: [net PATCH V3] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-18 Thread David Miller
From: Jesper Dangaard Brouer Date: Sat, 17 Sep 2016 17:48:00 +0200 > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes: 9ecc2d861

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-09-18 Thread Giuseppe CAVALLARO
Hello André On 9/18/2016 10:42 PM, André Roth wrote: Hello, For example, you could try disabling the scatter-gather or tx-cum via ethtool and seeing if there is some benefit; so we could image some problem on your HW or SYNP MAC integration for checksumming on tx side. disabling the followi

Re: [PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-18 Thread David Miller
From: Hariprasad Shenai Date: Sat, 17 Sep 2016 08:12:39 +0530 > Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like > cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with > cxgb4 driver and free them while unregistering. All the queues and the > interrupts

Re: [PATCH resend] sctp: Remove some redundant code

2016-09-18 Thread David Miller
From: Christophe JAILLET Date: Fri, 16 Sep 2016 23:05:35 +0200 > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was > hidden in 'sctp_skb_list_tail()' > > Now, the code around it looks redundant

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-18 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 16 Sep 2016 22:36:12 +0200 > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes: 9ecc2d861

Re: [PATCH net-next 0/5] mlx4 misc fixes and improvements

2016-09-18 Thread Or Gerlitz
On Mon, Sep 19, 2016 at 5:00 AM, David Miller wrote: > From: Tariq Toukan > Date: Sun, 18 Sep 2016 10:27:23 +0300 > >> Hi Dave, >> >> On 16/09/2016 2:21 AM, David Miller wrote: >>> From: Tariq Toukan >>> Date: Mon, 12 Sep 2016 16:20:11 +0300 >>> This patchset contains some bug fixes, a clea

Re: [PATCH v4 net 1/1] net sched actions: fix GETing actions

2016-09-18 Thread David Miller
From: Jamal Hadi Salim Date: Fri, 16 Sep 2016 16:27:04 -0400 > Fixes: > commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer > array"), > commit 824a7e8863b3 ("net_sched: remove an unnecessary list_del()") > commit f07fed82ad79 ("net_sched: remove the leftover cleanup_a()") Pl

Re: [PATCHv4 next 0/3] IPvlan introduce l3s mode

2016-09-18 Thread David Miller
From: Mahesh Bandewar Date: Fri, 16 Sep 2016 12:59:01 -0700 > Same old problem with new approach especially from suggestions from > earlier patch-series. > > First thing is that this is introduced as a new mode rather than > modifying the old (L3) mode. So the behavior of the existing modes is >

Re: [PATCH 0/2] cxgb4 FR_NSMR_TPTE_WR support

2016-09-18 Thread David Miller
From: Steve Wise Date: Fri, 16 Sep 2016 07:54:55 -0700 > This series enables a new work request to optimize small REG_MR > operations. This is intended for 4.9. If everyone agrees, I suggest > Doug take both the cxgb4 and iw_cxgb4 patches through his tree. I'm assuming this mean that I do _not

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-18 Thread David Miller
From: Vincent Bernat Date: Fri, 16 Sep 2016 14:55:31 +0200 > @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct net > *net, > return rt; > } > > +static int ip6_nh_valid(struct rt6_info *grt, > + struct net_device **dev, struct inet6_dev **idev

Re: [patch net-next v10 0/3] return offloaded stats as default and expose original sw stats

2016-09-18 Thread David Miller
From: Jiri Pirko Date: Fri, 16 Sep 2016 15:05:35 +0200 > The problem we try to handle is about offloaded forwarded packets > which are not seen by kernel. Let me try to draw it: > > port1 port2 (HW stats are counted here) > \ / >\

[PATCH 2/2] posix-timers: make it configurable

2016-09-18 Thread Nicolas Pitre
Many embedded systems typically don't need them. This removes about 22KB from the kernel binary size on ARM when configured out. Corresponding syscalls are routed to a stub logging the attempt to use those syscalls which should be enough of a clue if they were disabled without proper consideratio

[PATCH 0/2] make POSIX timers configurable

2016-09-18 Thread Nicolas Pitre
Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* it in their Kconfig entr

[PATCH 1/2] ptp_clock: allow for it to be optional

2016-09-18 Thread Nicolas Pitre
In order to break the hard dependency between the PTP clock subsystem and ethernet drivers capable of being clock providers, this patch provides simple PTP stub functions to allow linkage of those drivers into the kernel even when the PTP subsystem is configured out. And to make it possible for PT

Re: [PATCH 2/2] iw_cxgb4: add fast-path for small REG_MR operations

2016-09-18 Thread Leon Romanovsky
On Sun, Sep 18, 2016 at 07:40:29PM -0500, Steve Wise wrote: > > On Fri, Sep 16, 2016 at 07:54:52AM -0700, Steve Wise wrote: > > > When processing a REG_MR work request, if fw supports the > > > FW_RI_NSMR_TPTE_WR work request, and if the page list for this > > > registration is <= 2 pages, and the

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Leon Romanovsky
On Sun, Sep 18, 2016 at 08:36:55PM +, Adit Ranadive wrote: > On Sun, Sep 18, 2016 at 10:07:18 -0700, Leon Romanovsky wrote: > > On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > > > Hi Adit, > > > Please see my comments inline. > > > > > > Besides that I have no more comment for th

Re: [PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-18 Thread Marcelo Ricardo Leitner
Em 18-09-2016 23:06, David Miller escreveu: From: Marcelo Ricardo Leitner Date: Thu, 15 Sep 2016 15:12:30 -0300 No functional change. Just to avoid the usage of '&~3'. Also break the line to make it easier to read. You're reply later in this thread: "to make sure it is correctly ada

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

2016-09-18 Thread Neal Cardwell
On Sun, Sep 18, 2016 at 9:18 PM, Kenneth Klette Jonassen wrote: >> +static u64 bbr_rate_kbps(struct sock *sk, u64 rate) >> +{ >> + return bbr_rate_bytes_per_sec(sk, rate, BBR_UNIT) * 8 / 1000; > > > Consider div_u64() here to keep all builds happy. :-) This adds __udivdi3() > with the nxp po

Re: pull-request: mac80211-next 2016-09-16

2016-09-18 Thread David Miller
From: Johannes Berg Date: Fri, 16 Sep 2016 14:56:45 +0200 > And here's another set for net-next, it's been a month or so and we have a > reasonably large number of patches (for a change, mostly because I cleaned > up some WEP crypto thing and a few static checkers.) Pulled, thanks.

Re: pull-request: mac80211 2016-09-16

2016-09-18 Thread David Miller
From: Johannes Berg Date: Fri, 16 Sep 2016 14:47:22 +0200 > Sorry - I know you only just pulled my tree for the previous fixes, > but we found two more problems in the last few days; it'd be great > to get those fixes in as well. > > Let me know if there's any problem. Pulled, thanks Johannes.

Re: [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-18 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 16 Sep 2016 12:59:14 +0200 > @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb, struct > net_device *dev) > offset = offset_in_page(skb->data); > len = skb_headlen(skb); > > + /* The first req should be at least ETH_HLEN siz

Re: [PATCH][V2] net: r6040: add in missing white space in error message text

2016-09-18 Thread David Miller
From: Colin King Date: Fri, 16 Sep 2016 10:43:38 +0100 > From: Colin Ian King > > A couple of dev_err messages span two lines and the literal > string is missing a white space between words. Add the white > space and join the two lines into one. > > Signed-off-by: Colin Ian King Applied to n

Re: [PATCH (net.git)] stmmac: fix PWRDWN into the PMT register for global unicast.

2016-09-18 Thread David Miller
From: Giuseppe Cavallaro Date: Fri, 16 Sep 2016 10:50:13 +0200 > MAC devices use the RWKPKTEN and MGKPKTEN bits of the PMT Control/Status > register to generate power management events. > So this patch is to properly set the RWKPKTEN [BIT(2)] inside the > PMT register (needed in case of global un

Re: [PATCH net-next] pkt_sched: fq: use proper locking in fq_dump_stats()

2016-09-18 Thread David Miller
From: Eric Dumazet Date: Thu, 15 Sep 2016 16:20:01 -0700 > From: Eric Dumazet > > When fq is used on 32bit kernels, we need to lock the qdisc before > copying 64bit fields. > > Otherwise "tc -s qdisc ..." might report bogus values. > > Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet sc

Re: [PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-18 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Thu, 15 Sep 2016 19:11:53 -0300 > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. > > On a E5-2690 12-core system, usual throughput went from ~4Mpps to > ~15Mpps when f

Re: [PATCH v2 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

2016-09-18 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Thu, 15 Sep 2016 19:11:52 -0300 > On a system with only node 1 as possible, all statistics is going to be > accounted on node 0 as it will have a single writer. > > However, when getting and clearing the statistics, node 0 is not going > to be considered

Re: [PATCH v2 net-next 0/7] net: ILA resolver and generic resolver backend

2016-09-18 Thread David Miller
From: Tom Herbert Date: Thu, 15 Sep 2016 14:19:14 -0700 > This patch set implements an ILA host side resolver. This uses LWT > to implement the hook to a userspace resolver and tracks pending > unresolved address using the backend net resolver. Can you please repost this series with Herbert Xu p

Re: [PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-18 Thread David Miller
From: Marcelo Ricardo Leitner Date: Thu, 15 Sep 2016 15:12:30 -0300 > No functional change. Just to avoid the usage of '&~3'. > Also break the line to make it easier to read. You're reply later in this thread: "to make sure it is correctly adapted to some arch if necessary. (eve

Re: [PATCHv2 net 0/6] sctp: fix the transmit err process

2016-09-18 Thread David Miller
From: Xin Long Date: Wed, 14 Sep 2016 02:04:17 +0800 > This patchset is to improve the transmit err process and also fix some > issues. > > After this patchset, once the chunks are enqueued successfully, even > if the chunks fail to send out, no matter because of nodst or nomem, > no err retruns

Re: [PATCH net-next 0/5] mlx4 misc fixes and improvements

2016-09-18 Thread David Miller
From: Tariq Toukan Date: Sun, 18 Sep 2016 10:27:23 +0300 > Hi Dave, > > On 16/09/2016 2:21 AM, David Miller wrote: >> From: Tariq Toukan >> Date: Mon, 12 Sep 2016 16:20:11 +0300 >> >>> This patchset contains some bug fixes, a cleanup, and small >>> improvements >>> from the team to the mlx4 Eth

RE: [PATCH 2/2] iw_cxgb4: add fast-path for small REG_MR operations

2016-09-18 Thread Steve Wise
> On Fri, Sep 16, 2016 at 07:54:52AM -0700, Steve Wise wrote: > > When processing a REG_MR work request, if fw supports the > > FW_RI_NSMR_TPTE_WR work request, and if the page list for this > > registration is <= 2 pages, and the current state of the mr is INVALID, > > then use FW_RI_NSMR_TPTE_WR

Re: [PATCH net-next 2/3] r8152: support ECM mode

2016-09-18 Thread kbuild test robot
Hi Hayes, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Hayes-Wang/r8152-configuration-setting/20160907-192351 config: x86_64-randconfig-s0-09190146 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the a

[no subject]

2016-09-18 Thread Hello Email User
-- Sign-In Alert Hello Email User, We noticed a login to your Webmail account from an unrecognized device on Sunday Sept 18, 2016 4:07 PM GMT+1 from London, UK. Was this you? If so, please disregard the rest of this email. If this wasn't you, please follow the links below to keep your E-Mail

Re: skb_splice_bits() and large chunks in pipe (was Re: xfs_file_splice_read: possible circular locking dependency detected

2016-09-18 Thread Al Viro
On Sun, Sep 18, 2016 at 11:31:17PM +0100, Al Viro wrote: > At the moment there are 11 callers (10 in mainline; one more added in > conversion of vmsplice_to_pipe() to new pipe locking, but it's irrelevant > anyway - it gets fed an iovec-backed iov_iter). I'm looking through those > right now, hop

Re: skb_splice_bits() and large chunks in pipe (was Re: xfs_file_splice_read: possible circular locking dependency detected

2016-09-18 Thread Linus Torvalds
On Sun, Sep 18, 2016 at 3:31 PM, Al Viro wrote: > > What worries me is iov_iter_get_pages() and friends. So honestly, if it worries you, I'm not going to complain at all if you decide that you'd rather translate the pipe_buffer[] array into a kvec by always splitting at page boundaries. Even wit

Re: XDP_TX bug report on mlx4

2016-09-18 Thread Brenden Blanco
On Fri, Sep 16, 2016 at 09:24:43PM +0200, Jesper Dangaard Brouer wrote: > On Fri, 16 Sep 2016 12:17:27 -0700 > Brenden Blanco wrote: > > > On Fri, Sep 16, 2016 at 09:03:40PM +0200, Jesper Dangaard Brouer wrote: > > > Hi Brenden, > > > > > > I've discovered a bug with XDP_TX recycling of pages in

Re: [PATCH net-next 1/1] net sched: stylistic cleanups

2016-09-18 Thread Cong Wang
On Sun, Sep 18, 2016 at 5:45 AM, Jamal Hadi Salim wrote: > rtnl_register(PF_UNSPEC, RTM_NEWQDISC, tc_modify_qdisc, NULL, NULL); > rtnl_register(PF_UNSPEC, RTM_DELQDISC, tc_get_qdisc, NULL, NULL); > - rtnl_register(PF_UNSPEC, RTM_GETQDISC, tc_get_qdisc, tc_dump_qdisc, > NULL)

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-18 Thread Sargun Dhillon
On Fri, Sep 16, 2016 at 12:57:29PM -0700, Sargun Dhillon wrote: > On Wed, Sep 14, 2016 at 01:13:16PM +0200, Daniel Mack wrote: > > Hi Pablo, > > > > On 09/13/2016 07:24 PM, Pablo Neira Ayuso wrote: > > > On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: > > >> On 09/13/2016 01:56 PM, Pa

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-18 Thread Roopa Prabhu
On 9/6/16, 5:01 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This allows to pass information about added/deleted fib entries to > whoever is interested. This is done in a very similar way as devinet > notifies address additions/removals. > > Signed-off-by: Jiri Pirko > --- > include/net/ip_fib.h

[Patch net] sch_qfq: keep backlog updated with qlen

2016-09-18 Thread Cong Wang
Reported-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_qfq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c index f27ffee..ca0516e 100644

[Patch net] sch_sfb: keep backlog updated with qlen

2016-09-18 Thread Cong Wang
Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_sfb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c index add3cc7..20a350b 100644 --- a/net/sched/sch_sfb.c +++ b/

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-18 Thread Roopa Prabhu
On 9/18/16, 1:00 PM, Florian Fainelli wrote: > Le 06/09/2016 à 05:01, Jiri Pirko a écrit : >> From: Jiri Pirko >> >> This is RFC, unfinished. I came across some issues in the process so I would >> like to share those and restart the fib offload discussion in order to make >> it >> really usable.

[Patch net-next] net_sched: check NULL on error path in route4_change()

2016-09-18 Thread Cong Wang
On error path in route4_change(), 'f' could be NULL, so we should check NULL before calling tcf_exts_destroy(). Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()") Reported-by: kbuild test robot Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/cls_rou

Re: skb_splice_bits() and large chunks in pipe (was Re: xfs_file_splice_read: possible circular locking dependency detected

2016-09-18 Thread Al Viro
On Sun, Sep 18, 2016 at 01:12:21PM -0700, Linus Torvalds wrote: > So if the splice code ends up being confused by "this is not just > inside a single page", then the splice code is buggy, I think. > > Why would splice_write() cases be confused anyway? A filesystem needs > to be able to handle the

Quotation;東莞/深圳/廣州/中山/香港物流

2016-09-18 Thread Paul Tsang
Dear Sir/Miss This is the e-mail from Paul of HAOCHING INT'L LOGISTICS LTD in China. Our company is a well-staffed freight forwarding and logistics service company located in Shenzhen/Dongguan/Guangzhou/HuiZhou/Zhongshan GuangDong Province china,and provide safety, convenient and speedy logistic

[PATCH v3 net-next 13/16] tcp: allow congestion control to expand send buffer differently

2016-09-18 Thread Neal Cardwell
From: Yuchung Cheng Currently the TCP send buffer expands to twice cwnd, in order to allow limited transmits in the CA_Recovery state. This assumes that cwnd does not increase in the CA_Recovery. For some congestion control algorithms, like the upcoming BBR module, if the losses in recovery do n

[PATCH v3 net-next 15/16] tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88

2016-09-18 Thread Neal Cardwell
The TCP CUBIC module already uses 64 bytes. The upcoming TCP BBR module uses 88 bytes. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --- include/net/inet

[PATCH v3 net-next 12/16] tcp: export tcp_mss_to_mtu() for congestion control modules

2016-09-18 Thread Neal Cardwell
Export tcp_mss_to_mtu(), so that congestion control modules can use this to help calculate a pacing rate. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --

[PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

2016-09-18 Thread Neal Cardwell
This commit implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A detailed description of BBR will be published in ACM Queue, Vol. 14 No. 5, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR has significantly increased throughput and redu

[PATCH v3 net-next 09/16] tcp: export data delivery rate

2016-09-18 Thread Neal Cardwell
From: Yuchung Cheng This commit export two new fields in struct tcp_info: tcpi_delivery_rate: The most recent goodput, as measured by tcp_rate_gen(). If the socket is limited by the sending application (e.g., no data to send), it reports the highest measurement instead of the most

[PATCH v3 net-next 14/16] tcp: new CC hook to set sending rate with rate_sample in any CA state

2016-09-18 Thread Neal Cardwell
From: Yuchung Cheng This commit introduces an optional new "omnipotent" hook, cong_control(), for congestion control modules. The cong_control() function is called at the end of processing an ACK (i.e., after updating sequence numbers, the SACK scoreboard, and loss detection). At that moment we h

[PATCH v3 net-next 11/16] tcp: export tcp_tso_autosize() and parameterize minimum number of TSO segments

2016-09-18 Thread Neal Cardwell
To allow congestion control modules to use the default TSO auto-sizing algorithm as one of the ingredients in their own decision about TSO sizing: 1) Export tcp_tso_autosize() so that CC modules can use it. 2) Change tcp_tso_autosize() to allow callers to specify a minimum number of segments p

[PATCH v3 net-next 10/16] tcp: allow congestion control module to request TSO skb segment count

2016-09-18 Thread Neal Cardwell
Add the tso_segs_goal() function in tcp_congestion_ops to allow the congestion control module to specify the number of segments that should be in a TSO skb sent by tcp_write_xmit() and tcp_xmit_retransmit_queue(). The congestion control module can either request a particular number of segments in T

[PATCH v3 net-next 02/16] lib/win_minmax: windowed min or max estimator

2016-09-18 Thread Neal Cardwell
This commit introduces a generic library to estimate either the min or max value of a time-varying variable over a recent time window. This is code originally from Kathleen Nichols. The current form of the code is from Van Jacobson. A single struct minmax_sample will track the estimated windowed-m

[PATCH v3 net-next 08/16] tcp: track application-limited rate samples

2016-09-18 Thread Neal Cardwell
From: Soheil Hassas Yeganeh This commit adds code to track whether the delivery rate represented by each rate_sample was limited by the application. Upon each transmit, we store in the is_app_limited field in the skb a boolean bit indicating whether there is a known "bubble in the pipe": a point

[PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

2016-09-18 Thread Neal Cardwell
From: Eric Dumazet Revert to the tcp_skb_cb size check that tcp_init() had before commit b4772ef879a8 ("net: use common macro for assering skb->cb[] available size in protocol families"). As related commit 744d5a3e9fe2 ("net: move skb->dropcount to skb->cb[]") explains, the sock_skb_cb_check_size

[PATCH v3 net-next 07/16] tcp: track data delivery rate for a TCP connection

2016-09-18 Thread Neal Cardwell
From: Yuchung Cheng This patch generates data delivery rate (throughput) samples on a per-ACK basis. These rate samples can be used by congestion control modules, and specifically will be used by TCP BBR in later patches in this series. Key state: tp->delivered: Tracks the total number of data

[PATCH v3 net-next 06/16] tcp: count packets marked lost for a TCP connection

2016-09-18 Thread Neal Cardwell
Count the number of packets that a TCP connection marks lost. Congestion control modules can use this loss rate information for more intelligent decisions about how fast to send. Specifically, this is used in TCP BBR policer detection. BBR uses a high packet loss rate as one signal in its policer

[PATCH v3 net-next 04/16] net_sched: sch_fq: add low_rate_threshold parameter

2016-09-18 Thread Neal Cardwell
From: Eric Dumazet This commit adds to the fq module a low_rate_threshold parameter to insert a delay after all packets if the socket requests a pacing rate below the threshold. This helps achieve more precise control of the sending rate with low-rate paths, especially policers. The basic issue

[PATCH v3 net-next 03/16] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-18 Thread Neal Cardwell
Refactor the TCP min_rtt code to reuse the new win_minmax library in lib/win_minmax.c to simplify the TCP code. This is a pure refactor: the functionality is exactly the same. We just moved the windowed min code to make TCP easier to read and maintain, and to allow other parts of the kernel to use

[PATCH v3 net-next 00/16] tcp: BBR congestion control algorithm

2016-09-18 Thread Neal Cardwell
tcp: BBR congestion control algorithm This patch series implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A paper with a detailed description of BBR will be published in ACM Queue, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR is wi

[PATCH v3 net-next 01/16] tcp: cdg: rename struct minmax in tcp_cdg.c to avoid a naming conflict

2016-09-18 Thread Neal Cardwell
From: Soheil Hassas Yeganeh The upcoming change "lib/win_minmax: windowed min or max estimator" introduces a struct called minmax, which is then included in include/linux/tcp.h in the upcoming change "tcp: use windowed min filter library for TCP min_rtt estimation". This would create a compilatio

RE: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Adit Ranadive
On Sun, Sep 18, 2016 at 10:07:18 -0700, Leon Romanovsky wrote: > On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > > Hi Adit, > > Please see my comments inline. > > > > Besides that I have no more comment for this patch. > > > > Reviewed-by: Yuval Shaia > > > > Yuval > > > > On Thu,

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-09-18 Thread André Roth
Hello, > For example, you could try disabling the scatter-gather or tx-cum > via ethtool and seeing if there is some benefit; so we could image > some problem on your HW or SYNP MAC integration for checksumming > on tx side. disabling the following: ethtool -K eth0 sg off or: ethtool -K

[PATCH] net: explicitly whitelist sysctls for unpriv namespaces

2016-09-18 Thread Jann Horn
There were two net sysctls that could be written from unprivileged net namespaces, but weren't actually namespaced. To fix the existing issues and prevent stuff this from happening again in the future, explicitly whitelist permitted sysctls. Note: The current whitelist is "allow everything that w

Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h

2016-09-18 Thread Arnd Bergmann
On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no > previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_d

Re: [PATCH] net: skbuff: Fix length validation in skb_vlan_pop()

2016-09-18 Thread pravin shelar
On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani wrote: > In 93515d53b1 > "net: move vlan pop/push functions into common code" > skb_vlan_pop was moved from its private location in openvswitch to > skbuff common code. > > In case !vlan_tx_tag_present, the original 'pop_vlan()' assured > that skb

Re: [PATCH net 1/3] net/mlx5: Fix flow counter bulk command out mailbox allocation

2016-09-18 Thread Or Gerlitz
On Sun, Sep 18, 2016 at 9:02 PM, Leon Romanovsky wrote: > On Sun, Sep 18, 2016 at 06:20:27PM +0300, Or Gerlitz wrote: >> From: Roi Dayan >> @@ -425,11 +425,11 @@ struct mlx5_cmd_fc_bulk * >> mlx5_cmd_fc_bulk_alloc(struct mlx5_core_dev *dev, u16 id, int num) >> { >> struct mlx5_cmd_fc_bul

Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-18 Thread Tariq Toukan
Hi Alexei, On 07/09/2016 8:34 PM, Alexei Starovoitov wrote: On Wed, Sep 07, 2016 at 03:42:25PM +0300, Saeed Mahameed wrote: For non-striding RQ configuration before this patch we had a ring with pre-allocated SKBs and mapped the SKB->data buffers for device. For robustness and better RX data b

Re: skb_splice_bits() and large chunks in pipe (was Re: xfs_file_splice_read: possible circular locking dependency detected

2016-09-18 Thread Linus Torvalds
On Sun, Sep 18, 2016 at 12:31 PM, Al Viro wrote: > FWIW, I'm not sure if skb_splice_bits() can't land us in trouble; fragments > might come from compound pages and I'm not entirely convinced that we won't > end up with coalesced fragments putting more than PAGE_SIZE into a single > pipe_buffer. A

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-18 Thread Florian Fainelli
Le 06/09/2016 à 05:01, Jiri Pirko a écrit : > From: Jiri Pirko > > This is RFC, unfinished. I came across some issues in the process so I would > like to share those and restart the fib offload discussion in order to make it > really usable. > > So the goal of this patchset is to allow driver to

Re: [iproute PATCH] tc: don't accept qdisc 'handle' greater than ffff

2016-09-18 Thread Phil Sutter
On Fri, Sep 16, 2016 at 10:30:00AM +0200, Davide Caratti wrote: > since get_qdisc_handle() truncates the input value to 16 bit, return an > error and prompt "invalid qdisc ID" in case input 'handle' parameter needs > more than 16 bit to be stored. > > Signed-off-by: Davide Caratti Acked-by: Phil

[PATCH] netfilter: fix namespace handling in nf_log_proc_dostring

2016-09-18 Thread Jann Horn
nf_log_proc_dostring() used current's network namespace instead of the one corresponding to the sysctl file the write was performed on. Because the permission check happens at open time and the nf_log files in namespaces are accessible for the namespace owner, this can be abused by an unprivileged

Re: [PATCH net-next 2/2] net/sched: act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action

2016-09-18 Thread Jamal Hadi Salim
On 16-09-18 10:33 AM, Shmulik Ladkani wrote: TCA_VLAN_ACT_MODIFY allows one to change an existing tag. It accepts same attributes as TCA_VLAN_ACT_PUSH (protocol, id, priority). If packet is vlan tagged, then the tag gets overwritten according to user specified attributes. For example, this allo

skb_splice_bits() and large chunks in pipe (was Re: xfs_file_splice_read: possible circular locking dependency detected

2016-09-18 Thread Al Viro
FWIW, I'm not sure if skb_splice_bits() can't land us in trouble; fragments might come from compound pages and I'm not entirely convinced that we won't end up with coalesced fragments putting more than PAGE_SIZE into a single pipe_buffer. And that could badly confuse a bunch of code. Can that leg

[PATCH v2 net-next] MAINTAINERS: Add an entry for the core network DSA code

2016-09-18 Thread Andrew Lunn
The core distributed switch architecture code currently does not have a MAINTAINERS entry, which results in some contributions not landing in the right peoples inbox. Signed-off-by: Andrew Lunn --- v2: Add include/net/dsa.h and drivers/net/dsa/ MAINTAINERS | 9 + 1 file changed, 9 inser

Re: [PATCH net-next 2/3] r8152: support ECM mode

2016-09-18 Thread kbuild test robot
Hi Hayes, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Hayes-Wang/r8152-configuration-setting/20160907-192351 config: i386-randconfig-x0-09182136 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the att

Re: [PATCH net 1/3] net/mlx5: Fix flow counter bulk command out mailbox allocation

2016-09-18 Thread Leon Romanovsky
On Sun, Sep 18, 2016 at 06:20:27PM +0300, Or Gerlitz wrote: > From: Roi Dayan > > The FW command output length should be only the length of struct > mlx5_cmd_fc_bulk out field. Failing to do so will cause the memcpy > call which is invoked later in the driver to write over wrong memory > address a

Re: [PATCH iproute2] vxlan: allow specifying multiple default destinations

2016-09-18 Thread Tomasz Chmielewski
Signed-off-by: Mike Rapoport --- This patch depends on the pending changes to ip/iplink_vxlan.c as as well as on IPv6 support in vxlan. I'll rebase and resend it once all the changes to vxlan are merged. Was this one (and related) ever merged? Full thread here: http://marc.info/?t=13668879050

Re: [PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-18 Thread Rami Rosen
Acked-by: Rami Rosen On 18 September 2016 at 10:42, Ilan Tayari wrote: > commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") > introduced aead. The function attach_aead kmemdup()s the algorithm > name during xfrm_state_construct(). > However this memory is never freed. > Im

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

2016-09-18 Thread Jesper Dangaard Brouer
On Mon, 12 Sep 2016 16:46:08 -0700 Eric Dumazet wrote: > This XDP_TX thing was one of the XDP marketing stuff, but there is > absolutely no documentation on it, warning users about possible > limitations/outcomes. I will take care of documentation for the XDP project. -- Best regards, Jesper

[PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-18 Thread Ilan Tayari
commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") introduced aead. The function attach_aead kmemdup()s the algorithm name during xfrm_state_construct(). However this memory is never freed. Implementation has since been slightly modified in commit ee5c23176fcc ("xfrm: Clone s

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Leon Romanovsky
On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > Hi Adit, > Please see my comments inline. > > Besides that I have no more comment for this patch. > > Reviewed-by: Yuval Shaia > > Yuval > > On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote: > > On Wed, Sep 14, 2016 at 05:

Re: [PATCHv4 next 3/3] ipvlan: Introduce l3s mode

2016-09-18 Thread David Ahern
On 9/16/16 1:59 PM, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > In a typical IPvlan L3 setup where master is in default-ns and > each slave is into different (slave) ns. In this setup egress > packet processing for traffic originating from slave-ns will > hit all NF_HOOKs in slave-ns as we

Re: [v3] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-18 Thread David Ahern
On 9/18/16 9:46 AM, Vincent Bernat wrote: > Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop > lookups") introduced a regression: insertion of an IPv6 route in a table > not containing the appropriate connected route for the gateway but which > contained a non-connected route (like

[v3] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-18 Thread Vincent Bernat
Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups") introduced a regression: insertion of an IPv6 route in a table not containing the appropriate connected route for the gateway but which contained a non-connected route (like a default gateway) fails while it was previously w

Re: [PATCHv6 net-next 08/15] nfp: add BPF to NFP code translator

2016-09-18 Thread Daniel Borkmann
On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Add translator for JITing eBPF to operations which can be executed on NFP's programmable engines. Signed-off-by: Jakub Kicinski --- v6: - explicitly check for registers >= MAX_BPF_REG; - fix mem leak. Set looks good to me now, thanks a lot Jak

[PATCH net 2/3] net/mlx5: E-Switch, Fix error flow in the SRIOV e-switch init code

2016-09-18 Thread Or Gerlitz
When enablement of the SRIOV e-switch in certain mode (switchdev or legacy) fails, we must set the mode to none. Otherwise, we'll run into double free based crashes when further attempting to deal with the e-switch (such as when disabling sriov or unloading the driver). Signed-off-by: Or Gerlitz

  1   2   >