Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc

Mon, Aug 07, 2017 at 06:37:49AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Sat, 5 Aug 2017 16:53:22 +0200 > >> From: Jiri Pirko >> >> This patchset focuses on ndo_setup_tc and its args. >> Currently there are couple of things that do not make

Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

On Sun, 2017-08-06 at 21:57 +0400, Ilya Matveychikov wrote: > > On Aug 6, 2017, at 9:07 PM, Eric Dumazet wrote: > > > > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: > >> As tcp_data_queue() function is used just only twice it's better > >> to move out the

[PATCH v2] rtlwifi: constify rate_control_ops structure

rate_control_ops structure is only passed as an argument to the function ieee80211_rate_control_{register/unregister}. This argument is of type const, so declare the structure as const. Signed-off-by: Bhumika Goyal --- Changes in v2: * Change subject line.

Re: linux-next: manual merge of the net-next tree with the net tree

Hi Neal, On Sun, 6 Aug 2017 22:21:43 -0400 Neal Cardwell wrote: > > > I fixed it up (see below) and can carry the fix as necessary. This > > is now fixed as far as linux-next is concerned, but any non trivial > > conflicts should be mentioned to your upstream maintainer

FINANCING ASSISTANCE AT 2% INTEREST RATE

GOOD DAY,WE ARE OFFERING FINANCING ASSISTANCE AT 2% INTEREST RATE IF YOU NEED A LOAN CONTACT US

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

> The openvswitch kernel module calls the __skb_gso_segment()(and sets > tx_path = false) when passing packets to userspace. The UFO will set > the ip_summed to CHECKSUM_NONE. There are a lot of warn logs. The warn > log is shown as below. I guess we should revert the patch. Indeed, the software

Re: [PATCH v2 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device

From: David Ahern Date: Fri, 4 Aug 2017 13:16:56 -0700 > A missing piece to the VRF puzzle is the ability to bind sockets to > devices enslaved to a VRF. This patch set adds the enslaved device > index, sdif, to IPv4 and IPv6 socket lookups. The end result for users > is the

Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc

From: Jiri Pirko Date: Sat, 5 Aug 2017 16:53:22 +0200 > From: Jiri Pirko > > This patchset focuses on ndo_setup_tc and its args. > Currently there are couple of things that do not make much sense. > The type is passed in struct tc_to_netdev, but as it is

Re: [PATCH net-next 00/14] sctp: remove typedefs from structures part 5

From: Xin Long Date: Sat, 5 Aug 2017 19:59:50 +0800 > As we know, typedef is suggested not to use in kernel, even checkpatch.pl > also gives warnings about it. Now sctp is using it for many structures. > > All this kind of typedef's using should be removed. This patchset

Re: [PATCH v2 2/2] dt-bindings: net: Document bindings for anarion-gmac

From: Alexandru Gagniuc Date: Fri, 4 Aug 2017 13:08:52 -0700 > Signed-off-by: Alexandru Gagniuc Applied.

Re: [PATCH v2 1/2] net: stmmac: Add Adaptrum Anarion GMAC glue layer

From: Alexandru Gagniuc Date: Fri, 4 Aug 2017 13:08:51 -0700 > Before the GMAC on the Anarion chip can be used, the PHY interface > selection must be configured with the DWMAC block in reset. > > This layer covers a block containing only two registers. Although it > is

Re: [PATCH net-next 1/1] netvsc: fix rtnl deadlock on unregister of vf

From: Stephen Hemminger Date: Fri, 4 Aug 2017 12:14:00 -0700 > With new transparent VF support, it is possible to get a deadlock > when some of the deferred work is running and the unregister_vf > is trying to cancel the work element. The solution is to use > trylock

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

From: Florian Fainelli Date: Thu, 3 Aug 2017 21:33:27 -0700 > During testing with a background iperf pushing 1Gbit/sec worth of > traffic and having both ifconfig and ethtool collect statistics, we > could see quite frequent deadlocks. Convert the often accessed DSA slave

Re: [PATCH 0/2 v2 net-next] tcp cwnd undo refactor

From: Yuchung Cheng Date: Thu, 3 Aug 2017 20:38:50 -0700 > This patch series consolidate similar cwnd undo functions > implemented by various congestion control by using existing > tcp socket state variable. The first patch fixes a corner > case in of cwnd undo in Reno and

Re: [PATCH net 1/1] netvsc: fix race on sub channel creation

From: Stephen Hemminger Date: Thu, 3 Aug 2017 17:13:54 -0700 > The existing sub channel code did not wait for all the sub-channels > to completely initialize. This could lead to race causing crash > in napi_netif_del() from bad list. The existing code would send > an

Re: [PATCH v7 net-next] net: systemport: Support 64bit statistics

From: "Jianming.qiao" Date: Fri, 4 Aug 2017 00:07:45 +0100 > When using Broadcom Systemport device in 32bit Platform, ifconfig can > only report up to 4G tx,rx status, which will be wrapped to 0 when the > number of incoming or outgoing packets exceeds 4G, only taking >

Re: [PATCH net-next] liquidio: moved console_bitmask module param to lio_main.c

From: Felix Manlunas Date: Thu, 3 Aug 2017 15:10:17 -0700 > From: Intiyaz Basha > > Moving PF module param console_bitmask to lio_main.c for consistency. > > Signed-off-by: Intiyaz Basha > Signed-off-by: Felix

Re: [PATCH net-next] liquidio: add missing strings in oct_dev_state_str array

From: Felix Manlunas Date: Thu, 3 Aug 2017 13:08:24 -0700 > From: Intiyaz Basha > > There's supposed to be a one-to-one correspondence between the 18 macros > that #define the OCT_DEV states (in octeon_device.h) and the strings in the >

Re: [virtio-dev] repost: af_packet vs virtio (was packed ring layout proposal v2)

On Wed, Aug 02, 2017 at 04:50:03PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 01, 2017 at 08:54:27PM -0700, Steven Luong wrote: > > * Descriptor ring: > > > > Guest adds descriptors with unique index values and DESC_HW set in > > flags. > > Host overwrites used descriptors with

Re: [PATCH v9 0/4] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

On 2017/8/7 11:47, David Miller wrote: > From: Ding Tianhong > Date: Sat, 5 Aug 2017 15:15:09 +0800 > >> Some devices have problems with Transaction Layer Packets with the Relaxed >> Ordering Attribute set. This patch set adds a new PCIe Device Flag, >>

Re: [PATCH v4 net-next 02/13] nfp: change bpf verifier hooks to match new verifier data structures

From: Edward Cree Date: Thu, 3 Aug 2017 17:11:34 +0100 > Signed-off-by: Edward Cree Sorry, this doesn't work. The entire source tree must compile properly after each patch in the patch series. So if you change a datastructure, you have to update

Re: [PATCH RFC 00/13] phylink and sfp support

From: Andrew Lunn Date: Sun, 6 Aug 2017 20:26:22 +0200 > On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote: >> Hi, >> >> This patch series introduces generic support for SFP sockets found on >> various Marvell based platforms. The idea here is to provide

Re: [PATCH net-next 0/4] IP: cleanup LSRR option processing

From: Paolo Abeni Date: Thu, 3 Aug 2017 18:07:04 +0200 > The __ip_options_echo() function expect a valid dst entry in skb->dst; > as result we sometimes need to preserve the dst entry for the whole IP > RX path. > > The current usage of skb->dst looks more a relic from

Re: [RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo()

From: Hannes Frederic Sowa Date: Fri, 28 Jul 2017 16:47:42 -0400 > David Miller writes: > >> The red flag is that we are indexing 'start' with 'doffset' instead of >> 'soffset'. > > As Paolo pointed out, we should not put our own source address

Re: [PATCH v9 0/4] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

From: Ding Tianhong Date: Sat, 5 Aug 2017 15:15:09 +0800 > Some devices have problems with Transaction Layer Packets with the Relaxed > Ordering Attribute set. This patch set adds a new PCIe Device Flag, > PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch

Re: linux-next: manual merge of the net-next tree with the net tree

On Sun, Aug 6, 2017 at 10:01 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/tcp_output.c > > between commit: > > a2815817ffa6 ("tcp: enable xmit timer fix by having TLP use time when RTO > should

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/tcp_output.c between commit: a2815817ffa6 ("tcp: enable xmit timer fix by having TLP use time when RTO should fire") from the net tree and commit: bb4d991a28cc ("tcp: adjust tail loss probe timeout")

Re:Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

At 2017-08-03 01:13:36, "Cong Wang" wrote: >Hi, Gao > >On Tue, Aug 1, 2017 at 1:39 PM, Cong Wang wrote: >> From my understanding, this RCU is supposed to protect the pppox_sock >> pointers in 'callid_sock' which could be NULL'ed in del_chan().

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

On Fri, Aug 4, 2017 at 9:29 PM, Eric Dumazet wrote: > On Fri, 2017-08-04 at 06:11 -0700, Tonghao Zhang wrote: >> This patch will revert the b2504a5dbe "net: reduce >> skb_warn_bad_offload() noise". The ovs will call the >> __skb_gso_segment() with tx false. When segmenting

Re: [PATCH net] sctp: use __GFP_NOWARN for sctpw.fifo allocation

On Sun, Aug 06, 2017 at 06:14:39PM +1200, Xin Long wrote: > On Sun, Aug 6, 2017 at 5:08 AM, Marcelo Ricardo Leitner > wrote: > > On Sat, Aug 05, 2017 at 08:31:09PM +0800, Xin Long wrote: > >> Chen Wei found a kernel call trace when modprobe sctp_probe with > >> bufsize

Re: [PATCH v4 net-next 01/13] bpf/verifier: rework value tracking

On 08/03/2017 06:11 PM, Edward Cree wrote: Unifies adjusted and unadjusted register value types (e.g. FRAME_POINTER is now just a PTR_TO_STACK with zero offset). Tracks value alignment by means of tracking known & unknown bits. This also replaces the 'reg->imm' (leading zero bits)

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:52 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: >> On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: >> > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> >>

[PATCH] qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'

We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we check 'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'. 'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines above in 'qed_load_mcp_offsets()'. Update the test and check the result of the 2 'kzalloc()'

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> >> > +#ifdef __KERNEL__ > >> >> > +#include > >> >> > +#else > >> >> > +#include

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> > +#ifdef __KERNEL__ >> >> > +#include >> >> > +#else >> >> > +#include >> >> > +#endif /* __KERNEL__ */ >> >> >> >> This will break applications

[PATCH] i40e: Fix a potential NULL pointer dereference

If 'kzalloc()' fails, a NULL pointer will be dereferenced. Return an error code (-ENOMEM) instead. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> > +#ifdef __KERNEL__ > >> > +#include > >> > +#else > >> > +#include > >> > +#endif /* __KERNEL__ */ > >> > >> This will break applications that include manually. > >> I previously sent a patch to use libc-compat to make

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

>> > +#ifdef __KERNEL__ >> > +#include >> > +#else >> > +#include >> > +#endif /* __KERNEL__ */ >> >> This will break applications that include manually. >> I previously sent a patch to use libc-compat to make compilation succeed >> when both are included in the case where is included after >>

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:26:50PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn > wrote: > > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > >> linux/time.h conflicts with user space header time.h.

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:23:16PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > > linux/time.h conflicts with user space header time.h. Try to be compatible > > with both. > > > > Fixes userspace compilation error: > > > > error:

Re: NULL pointer deref bring up interfaces

On Sun, 6 Aug 2017 12:29:13 -0500 Rafael Cepeda wrote: > Just upgraded to 4.13rc2, rebooted, and my system crashed at my > netmount init script; says RIP is NULL, I am guessing a bad func call. > I immediately thought missing firmware in kernel, my kernel builds > firmware

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: >> linux/time.h conflicts with user space header time.h. Try to be compatible >> with both. >> >> Fixes userspace compilation

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > linux/time.h conflicts with user space header time.h. Try to be compatible > with both. > > Fixes userspace compilation error: > > error: array type has incomplete element type > struct timespec ts[3]; > > Signed-off-by:

Re: [patch net-next 06/15] mlx5e: push cls_flower and mqprio setup_tc processing into separate functions

On Sat, Aug 5, 2017 at 5:53 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Let mlx5e_setup_tc (former mlx5e_ndo_setup_tc) be a splitter for specific > setup_tc types and push out cls_flower and mqprio specific codes into > separate functions. Also change the

Re: [PATCH 2/4] atm: idt77252: Delete an error message for a failed memory allocation in seven functions

-four-function-calls-together-with-a-variable-assignment/20170806-081417 config: x86_64-randconfig-b0-08070032 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed

Re: [PATCH RFC 00/13] phylink and sfp support

On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote: > Hi, > > This patch series introduces generic support for SFP sockets found on > various Marvell based platforms. The idea here is to provide common > SFP socket support which can be re-used by network drivers as >

Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

> On Aug 6, 2017, at 9:07 PM, Eric Dumazet wrote: > > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: >> As tcp_data_queue() function is used just only twice it's better >> to move out the first check and wrap it with inline. It saves a >> single call in case

Re: [patch net-next 10/15] dsa: push cls_matchall setup_tc processing into a separate function

On 08/05/2017 07:53 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Let dsa_slave_setup_tc be a splitter for specific setup_tc types and > push out cls_matchall specific code into a separate function. > > Signed-off-by: Jiri Pirko Reviewed-by: Florian

Re: [PATCH net-next v2 3/3] net: dsa: remove useless args of dsa_slave_create

On 08/05/2017 01:20 PM, Vivien Didelot wrote: > dsa_slave_create currently takes 4 arguments while it only needs the > related dsa_port and its name. Remove all other arguments. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli

Re: [PATCH net-next v2 2/3] net: dsa: remove useless args of dsa_cpu_dsa_setup

On 08/05/2017 01:20 PM, Vivien Didelot wrote: > dsa_cpu_dsa_setup currently takes 4 arguments but they are all available > from the dsa_port argument. Remove all others. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli

Re: [PATCH net-next v2 1/3] net: dsa: remove useless argument in legacy setup

On 08/05/2017 01:20 PM, Vivien Didelot wrote: > dsa_switch_alloc() already assigns ds-dev, which can be used in > dsa_switch_setup_one and dsa_cpu_dsa_setups instead of requiring an > additional struct device argument. > > Signed-off-by: Vivien Didelot

NULL pointer deref bring up interfaces

Just upgraded to 4.13rc2, rebooted, and my system crashed at my netmount init script; says RIP is NULL, I am guessing a bad func call. I immediately thought missing firmware in kernel, my kernel builds firmware in it, so I upgraded my firmware to latest on git.kernel and made sure I had no

[PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

linux/time.h conflicts with user space header time.h. Try to be compatible with both. Fixes userspace compilation error: error: array type has incomplete element type struct timespec ts[3]; Signed-off-by: Mikko Rapeli Cc: Willem de Bruijn Cc: Soheil

[PATCH v06 35/36] uapi linux/tls.h: don't include in user space

It is not needed and not part of uapi headers, but causes user space compilation error: fatal error: net/tcp.h: No such file or directory #include ^ Signed-off-by: Mikko Rapeli Cc: Dave Watson Cc: Ilya Lesokhin

[PATCH v06 15/36] uapi linux/socket.h: include sys/socket.h in user space

This libc header has sockaddr definition in user space. Fixes user space compilation errors like these from kernel headers including only linux/socket.h: error: field ‘ifru_addr’ has incomplete type struct sockaddr ifru_addr; error: field ‘_sockaddr’ has incomplete type struct sockaddr

[PATCH v06 20/36] uapi linux/scc.h: include linux/sockios.h

Fixes userspace compilation error: error: ‘SIOCDEVPRIVATE’ undeclared here (not in a function) SIOCSCCRESERVED = SIOCDEVPRIVATE Signed-off-by: Mikko Rapeli Cc: netdev@vger.kernel.org Cc: linux-h...@vger.kernel.org Cc: Joerg Reuter ---

[PATCH v06 01/36] Add scripts/headers_compile_test.sh: compile test for exported uapi headers

Users of kernel uapi header files would be happier if they did not contain kernel specific parts and would contain #include statements for all other header files that they depend on, and in general would compile also in user space. If Linux kernal uapi headers compile in user space, then they can

[PATCH] isdn: kcapi: make capi_version const

Declare this structure as const as it is only used during a copy operation. Signed-off-by: Bhumika Goyal --- drivers/isdn/capi/kcapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c index

Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: > As tcp_data_queue() function is used just only twice it's better > to move out the first check and wrap it with inline. It saves a > single call in case the condition evaluated as true. > > Signed-off-by: Ilya V. Matveychikov

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

On Sun, Aug 6, 2017 at 3:44 AM, Willy Tarreau wrote: > > On Sun, Aug 06, 2017 at 07:39:57AM +, maowenan wrote: > > > > [Mao Wenan]It works well with these patches of v3.10, and the > > retransmission packet is about 250ms after TLP probe. > > Thank you very much for these patches

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

On Sun, Aug 6, 2017 at 3:44 AM, Willy Tarreau wrote: > > On Sun, Aug 06, 2017 at 07:39:57AM +, maowenan wrote: > > > > [Mao Wenan]It works well with these patches of v3.10, and the > > retransmission packet is about 250ms after TLP probe. > > Thank you very much for these patches

[PATCH net-next v3 10/13] net: dsa: Remove redundant MDB dump support

Currently the MDB HW database is synced with the bridge's one, thus, There is no need to support special dump functionality. Signed-off-by: Arkadi Sharshevsky --- include/net/dsa.h | 4 net/dsa/dsa_priv.h | 2 -- net/dsa/port.c | 11 --- net/dsa/slave.c

[PATCH net-next v3 09/13] net: dsa: Remove support for MDB dump from DSA's drivers

This is done as a preparation before removing support for MDB dump from DSA core. The MDBs are synced with the bridge and thus there is no need for special dump operation support. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/microchip/ksz_common.c | 9 -

[PATCH net-next v3 02/13] net: dsa: Remove prepare phase for FDB

The prepare phase for FDB add is unneeded because most of DSA devices can have failures during bus transactions (SPI, I2C, etc.), thus, the prepare phase cannot guarantee success of the commit stage. The support for learning FDB through notification chain, which will be introduced in the

[PATCH net-next v3 07/13] net: dsa: Remove support for vlan dump from DSA's drivers

This is done as a preparation before removing support for vlan dump from DSA core. The vlans are synced with the bridge and thus there is no need for special dump operation support. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 44

[PATCH net-next v3 12/13] net: bridge: Remove FDB deletion through switchdev object

At this point no driver supports FDB add/del through switchdev object but rather via notification chain, thus, it is removed. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot --- net/bridge/br_fdb.c | 18 --

[PATCH net-next v3 01/13] net: dsa: Change DSA slave FDB API to be switchdev independent

In order to support FDB add/del to be on a notifier chain the slave API need to be changed to be switchdev independent. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli

[PATCH net-next v3 05/13] net: dsa: Move FDB add/del implementation inside DSA

Currently DSA uses switchdev's implementation of FDB add/del ndos. This patch moves the implementation inside DSA in order to support the legacy way for static FDB configuration. Signed-off-by: Arkadi Sharshevsky --- net/dsa/dsa_priv.h | 7 +++ net/dsa/legacy.c | 22

[PATCH net-next v3 08/13] net: dsa: Remove support for bypass bridge port attributes/vlan set

The bridge port attributes/vlan for DSA devices should be set only from bridge code. Furthermore, The vlans are synced totally with the bridge so there is no need for special dump support. Signed-off-by: Arkadi Sharshevsky --- include/net/dsa.h | 4

[PATCH net-next v3 03/13] net: dsa: Remove switchdev dependency from DSA switch notifier chain

Currently, the switchdev objects are embedded inside the DSA notifier info. This patch removes this dependency. This is done as a preparation stage before adding support for learning FDB through the switchdev notification chain. Signed-off-by: Arkadi Sharshevsky

[PATCH net-next v3 06/13] net: dsa: Add support for querying supported bridge flags

The DSA drivers do not support bridge flags offload. Yet, this attribute should be added in order for the bridge to fail when one tries set a flag on the port, as explained in commit dc0ecabd6231 ("net: switchdev: Add support for querying supported bridge flags by hardware"). Signed-off-by:

[PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup

The patchset adds support for configuring static FDB entries via the switchdev notification chain. The current method for FDB configuration uses the switchdev's bridge bypass implementation. In order to support this legacy way and to perform the switchdev cleanup, the implementation is moved

[PATCH net-next v3 11/13] net: dsa: Move FDB dump implementation inside DSA

>From all switchdev devices only DSA requires special FDB dump. This is due to lack of ability for syncing the hardware learned FDBs with the bridge. Due to this it is removed from switchdev and moved inside DSA. Signed-off-by: Arkadi Sharshevsky --- v1->v2 - Cosmetics.

[PATCH net-next v3 04/13] net: dsa: Add support for learning FDB through notification

Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. In case of a successful FDB add a notification is sent back to bridge. In case of hw FDB del failure the static FDB will be deleted from the bridge, thus, the interface is moved to

[PATCH net-next v3 13/13] net: switchdev: Remove bridge bypass support from switchdev

Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded through the bridge code, making the switchdev's SELF bridge bypass implementation to be redundant. This implies several changes: - No need for dump infra in switchdev, DSA's special case is handled privately. - Remove

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

On 08/04/2017 06:29 PM, Vivien Didelot wrote: > Hi Arkadi, Jiri, > > Jiri Pirko writes: > >>> It seems impossible currently to move the self to be the default, and >>> this introduces regression which you don't approve, so it seems few >>> options left: >>> >>> a) Leave two

Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc

On 17-08-05 10:53 AM, Jiri Pirko wrote: From: Jiri Pirko This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo.

Re: [Patch net-next 2/2] net_sched: use void pointer for filter handle

On 17-08-05 12:31 AM, Cong Wang wrote: Now we use 'unsigned long fh' as a pointer in every place, it is safe to convert it to a void pointer now. This gets rid of many casts to pointer. I dont recall why unsigned long was used back then (by Alexey) given C has always allowed void * assigned

Re: [Patch net-next 1/2] net_sched: refactor notification code for RTM_DELTFILTER

On 17-08-05 12:31 AM, Cong Wang wrote: It is confusing to use 'unsigned long fh' as both a handle and a pointer, especially commit 9ee7837449b3 ("net sched filters: fix notification of filter delete with proper handle"). This patch introduces tfilter_del_notify() so that we can pass it as a

[PATCH] tcp_input: move out condition check from tcp_data_queue()

As tcp_data_queue() function is used just only twice it's better to move out the first check and wrap it with inline. It saves a single call in case the condition evaluated as true. Signed-off-by: Ilya V. Matveychikov --- net/ipv4/tcp_input.c | 14 +- 1 file

[PATCH] ATM-ENI: Delete an error message for a failed memory allocation in eni_start()

From: Markus Elfring Date: Sun, 6 Aug 2017 11:15:17 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

[PATCH] hamradio: baycom: make hdlcdrv_ops const

Make hdlcdrv_ops structures const as they are only passed to hdlcdrv_register function. The corresponding argument is of type const, so make the structures const. Signed-off-by: Bhumika Goyal --- drivers/net/hamradio/baycom_par.c | 2 +-

[PATCH] atm: solos-pci: Delete an error message for a failed memory allocation in fpga_probe()

From: Markus Elfring Date: Sun, 6 Aug 2017 10:37:31 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

[PATCH ipsec-next] xfrm: check that cached bundle is still valid

Quoting Ilan Tayari: 1. Set up a host-to-host IPSec tunnel (or transport, doesn't matter) 2. Ping over IPSec, or do something to populate the pcpu cache 3. Join a MC group, then leave MC group 4. Try to ping again using same CPU as before -> traffic doesn't egress the machine at all

[PATCH] ATM-nicstar: Delete an error message for a failed memory allocation in ns_init_card()

From: Markus Elfring Date: Sun, 6 Aug 2017 10:10:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

[PATCH] ATM-lanai: Delete an error message for a failed memory allocation in lanai_init_one()

From: Markus Elfring Date: Sun, 6 Aug 2017 09:42:52 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

On Sun, Aug 06, 2017 at 07:39:57AM +, maowenan wrote: > > > > -Original Message- > > From: Willy Tarreau [mailto:w...@1wt.eu] > > Sent: Saturday, August 05, 2017 2:19 AM > > To: Neal Cardwell > > Cc: maowenan; David Miller; netdev@vger.kernel.org; Yuchung Cheng; Nandita > >

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

> -Original Message- > From: Willy Tarreau [mailto:w...@1wt.eu] > Sent: Saturday, August 05, 2017 2:19 AM > To: Neal Cardwell > Cc: maowenan; David Miller; netdev@vger.kernel.org; Yuchung Cheng; Nandita > Dukkipati; Eric Dumazet > Subject: Re: [PATCH net 3/3] tcp: fix xmit timer to only

[PATCH] can: c_can_pci: make c_can_pci_data const

Make c_can_pci_data structures const as they are only used during a copy operation. Signed-off-by: Bhumika Goyal --- drivers/net/can/c_can/c_can_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can_pci.c

RE: XFRM pcpu cache issue

> -Original Message- > From: Florian Westphal [mailto:f...@strlen.de] > Subject: Re: XFRM pcpu cache issue > > I dropped the stale_bundle() check vs. rfc, that was a stupid thing > to do because that is what would detect this > > Does this help? Yes, this fixes the regression for

[PATCH 3/3] ATM-iphase: Adjust four checks for null pointers

From: Markus Elfring Date: Sat, 5 Aug 2017 22:30:04 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 2/3] ATM-iphase: Delete five error messages for a failed memory allocation

From: Markus Elfring Date: Sat, 5 Aug 2017 22:10:41 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link:

[PATCH 1/3] ATM-iphase: Adjust 11 function calls together with a variable assignment

From: Markus Elfring Date: Sat, 5 Aug 2017 21:39:06 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix affected source code places. Signed-off-by: Markus Elfring

[PATCH 0/3] ATM-iphase: Adjustments for some function implementations

From: Markus Elfring Date: Sun, 6 Aug 2017 08:18:28 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Adjust 11 function calls together with a variable assignment Delete five error messages for a

Re: [PATCH net] sctp: use __GFP_NOWARN for sctpw.fifo allocation

On Sun, Aug 6, 2017 at 5:08 AM, Marcelo Ricardo Leitner wrote: > On Sat, Aug 05, 2017 at 08:31:09PM +0800, Xin Long wrote: >> Chen Wei found a kernel call trace when modprobe sctp_probe with >> bufsize set with a huge value. >> >> It's because in sctpprobe_init when