Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-10-08 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 17: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2018 To

Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-10-05 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 16: @Ian, does the cb-jenkins matters? -- To view, visit https://asterix-gerri

Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-10-05 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 16: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2018 To

Change in asterixdb[master]: [ASTERIXDB-2119][COMP] Fix variable ordering of project push...

2017-10-03 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2119][COMP] Fix variable ordering of project pushdown .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2048 To unsub

Change in asterixdb[master]: [ASTERIXDB-2119][COMP] Fix variable ordering of project push...

2017-10-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2119][COMP] Fix variable ordering of project pushdown .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2048/3/hyracks-fullstack/alge

Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-09-28 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 8: (4 comments) I left some minor comments. https://asterix-gerrit.ics.uci.edu

Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-09-25 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 3: @Luo any ideas about the "cb-jenkins" test fail? I think you can ask @Adbulla

Change in asterixdb[master]: [ASTERIXDB-2103][STO] Too many disk components for Correlate...

2017-09-21 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-2103][STO] Too many disk components for CorrelatedPolicy .. Patch Set 2: (2 comments) I have two minor comments. https://asterix-gerrit.ics.uci.edu/

Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Corre...

2017-07-07 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Correlated Datasets .. Patch Set 6: Cloudberry currently only need an inverted index. So I didn't test oth

Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Corre...

2017-07-07 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Correlated Datasets .. Patch Set 6: @Chenluo, not much about this patch on the code side. I want to updat

Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Corre...

2017-07-05 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Correlated Datasets .. Patch Set 5: Code-Review+1 Maybe Abdullah or Yingyi can have a pass finally? -- T

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals

2017-06-26 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals .. Patch Set 10: Code-Review+1 I see. I will give a +1. I think the upsert issue as Murtadha's pointed out coul

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals

2017-06-25 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals .. Patch Set 10: (1 comment) why is shows can't merge? https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-f

Change in asterixdb[master]: Avoid always merging old components in prefix policy

2017-06-09 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-

Change in asterixdb[master]: Avoid always merging old components in prefix policy

2017-06-09 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 4: (7 comments) some minor comments. https://asterix-gerrit.ics.uci.edu/#/c/1818/4/hyracks-ful

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-06-07 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has submitted this change and it was merged. Change subject: Change logical plan to apply filter from 2ndary index .. Change logical plan to apply filter from 2ndary index - Changes the IntroduceLSMComponentFilterR

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-06-06 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#17). Change subject: Change logical plan to apply filter from 2ndary index .

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-06-06 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index .. Patch Set 15: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1727/15/asterixdb/asterix-algebra/src/

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-06-06 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#16). Change subject: Change logical plan to apply filter from 2ndary index .

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-27 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#13). Change subject: Change logical plan to apply filter from 2ndary index .

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-27 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index .. Patch Set 12: (27 comments) https://asterix-gerrit.ics.uci.edu/#/c/1727/11/asterixdb/asterix-algebra/src

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-27 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#12). Change subject: Change logical plan to apply filter from 2ndary index .

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-21 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#10). Change subject: Change logical plan to apply filter from 2ndary index .

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-20 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index .. Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1727/7/asterixdb/asterix-app/data/twitt

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-20 Thread Jianfeng Jia (Code Review)
Hello Ian Maxon, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#9). Change subject: Change logical plan to apply filter from 2ndary index ..

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-19 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index .. Patch Set 7: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1727/7/.gitignore File .gitignore: > W

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-19 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#8). Change subject: Change logical plan to apply filter from 2ndary index .. Change lo

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-17 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#7). Change subject: Change logical plan to apply filter from 2ndary index .. Change lo

Change in asterixdb[master]: ASTERIXDB-1905: Incorrect filter for post-load sidx

2017-05-15 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1905: Incorrect filter for post-load sidx .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1743 To unsubscribe, visit

Change in asterixdb[master]: ASTERIXDB-1905: Incorrect filter for post-load sidx

2017-05-15 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1905: Incorrect filter for post-load sidx .. Patch Set 3: Code-Review+1 LGTM. I think we should also fix that two formatting issues? -- To view, visit

Change in asterixdb[master]: ASTERIXDB-1905: Incorrect filter for post-load sidx

2017-05-14 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1905: Incorrect filter for post-load sidx .. Patch Set 2: any reason for the verify fail? -- To view, visit https://asterix-gerrit.ics.uci.edu/1743 To

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-13 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#4). Change subject: Change logical plan to apply filter from 2ndary index .. Change lo

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-12 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#3). Change subject: Change logical plan to apply filter from 2ndary index .. Change lo

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-11 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1727 to look at the new patch set (#2). Change subject: Change logical plan to apply filter from 2ndary index .. Change lo

Change in asterixdb[master]: Change logical plan to apply filter from 2ndary index

2017-05-07 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1727 Change subject: Change logical plan to apply filter from 2ndary index .. Change logical plan to apply filter from 2ndary index - Chang

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-04 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Carry filter in 2ndary-to-primary index search .. Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1720/7/hyracks-fullstack/hyracks/hyracks-examp

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-04 Thread Jianfeng Jia (Code Review)
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#8). Change subject: Carry filter in 2ndary-to-primary index search .. Carry

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-04 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Carry filter in 2ndary-to-primary index search .. Patch Set 6: (20 comments) https://asterix-gerrit.ics.uci.edu/#/c/1720/6/asterixdb/asterix-algebra/src/main/jav

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-04 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#7). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Carry filter in 2ndary-to-primary index search .. Patch Set 6: (6 comments) @Yingyi @Ian, this is patch expose the filter value and pass it along with index rec

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#6). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#5). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#4). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#3). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1720 to look at the new patch set (#2). Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in

Change in asterixdb[master]: Carry filter in 2ndary-to-primary index search

2017-05-01 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1720 Change subject: Carry filter in 2ndary-to-primary index search .. Carry filter in 2ndary-to-primary index search Change-Id: I287f1dbd2

Change in asterixdb[master]: Hyracks Unit tests for LSM Filters

2017-04-28 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix

Change in asterixdb[master]: Hyracks Unit tests for LSM Filters

2017-04-27 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 7: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-

Change in asterixdb[master]: Hyracks Unit tests for LSM Filters

2017-04-26 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 3: (1 comment) do we have the corresponding RTree/InvertedIndex merge filter test? https://asterix-gerrit.ics.uc

Change in asterixdb[master]: Document the Query Service API

2017-04-25 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsubscribe, visit https://asterix-gerr

Change in asterixdb[master]: Document the Query Service API

2017-04-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md File aste

Change in asterixdb[master]: Fix for ASTERIXDB-1886: Filter not selective

2017-04-19 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1886: Filter not selective .. Patch Set 2: Any test case we can add to make filter safer? -- To view, visit https://asterix-gerrit.ics.uci.edu

Change in asterixdb[master]: Fix for ASTERIXDB-1879

2017-04-12 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1879 .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1672 To unsubscribe, visit https://asterix-gerrit.ics.u

Change in asterixdb[master]: Fix for ASTERIXDB-1879

2017-04-11 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1879 .. Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1672/6/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-

Change in asterixdb[master]: Print filter information in logical plan

2017-04-11 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has submitted this change and it was merged. Change subject: Print filter information in logical plan .. Print filter information in logical plan Change-Id: I8c3893fc54337695df4837e34ad7f7e89758718e Reviewed-on: ht

Change in asterixdb[master]: Print filter information in logical plan

2017-04-11 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Print filter information in logical plan .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1673/2//COMMIT_MSG Commit Message: PS2, Line 9: wor

Change in asterixdb[master]: Print filter information in logical plan

2017-04-11 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1673 to look at the new patch set (#3). Change subject: Print filter information in logical plan .. Print filter informati

Change in asterixdb[master]: Fix for ASTERIXDB-1879

2017-04-11 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1879 .. Patch Set 1: I'm thinking an easier unit test. E.g., we can write a filter information to a page and read it later to see if we can get

Change in asterixdb[master]: Print filter information in logical plan

2017-04-10 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1673 to look at the new patch set (#2). Change subject: Print filter information in logical plan .. Print filter informati

Change in asterixdb[master]: Print filter information in logical plan

2017-04-10 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1673 Change subject: Print filter information in logical plan .. Print filter information in logical plan The following commits from your w

Change in asterixdb[master]: Fix for ASTERIXDB-1879

2017-04-10 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1879 .. Patch Set 1: so this means we have to re-ingest the data since the filter is not write correctly -- To view, visit https://aster

Change in asterixdb[master]: Fix for ASTERIXDB-1879

2017-04-10 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1879 .. Patch Set 1: should we have some sort of filter related unit test? -- To view, visit https://asterix-gerrit.ics.uci.edu/1672 To unsubs

Change in asterixdb[master]: ASTERIXDB-1877: Tokenizer in FullText Search fix

2017-04-09 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1877: Tokenizer in FullText Search fix .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1668 To unsubscribe, visit ht

Change in asterixdb[master]: ASTERIXDB-1877: Tokenizer in FullText Search fix

2017-04-09 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1877: Tokenizer in FullText Search fix .. Patch Set 4: Any plan to merge it soon? Cloudberry need it to make the current demo work :-) -- To view, vis

Change in asterixdb[master]: ASTERIXDB-1327, ASTERIXDB-1362 Fixed circle-point intersect ...

2017-03-07 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1327, ASTERIXDB-1362 Fixed circle-point intersect function .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1558 To

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-04 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 8: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1481 To unsubscribe,

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-03 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 6: Looks good. But I still feel there should be some simple *JUnit* test for the edit dist

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 4: Oh, one more thing, do you have some test cases that actually trigger the early termina

Change in asterixdb[master]: ASTERIXDB-1778: Optimize the edit-distance-check function

2017-02-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function .. Patch Set 4: (10 comments) Just some minor comments. https://asterix-gerrit.ics.uci.edu/#/c/1481/4/

Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has submitted this change and it was merged. Change subject: Support LSM-filter on multiple input paths .. Support LSM-filter on multiple input paths The IntroduceLSMComponentFilterRule only checked one input path,

Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Support LSM-filter on multiple input paths .. Patch Set 3: -Code-Review -- To view, visit https://asterix-gerrit.ics.uci.edu/1356 To unsubscribe, visit https://a

Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Hello Taewoo Kim, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1356 to look at the new patch set (#3). Change subject: Support LSM-filter on multiple input paths .. Support

Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Support LSM-filter on multiple input paths .. Patch Set 3: Code-Review+2 Forward Taewoo's +2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1356 To unsubs

Change in asterixdb[master]: Support filter on multiple input path

2016-11-22 Thread Jianfeng Jia (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1356 to look at the new patch set (#2). Change subject: Support filter on multiple input path .. Support filter on multipl

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

2016-11-22 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has abandoned this change. Change subject: Not suppose to MERGE, for discussion purpose The following commits from your working branch will be included: .. Abandoned -- To view, visit https://asterix-gerrit.ics.u

Change in asterixdb[master]: Support filter on multiple input path

2016-11-22 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1356 Change subject: Support filter on multiple input path .. Support filter on multiple input path The following commits from your working

Change in asterixdb[master]: ASTERIXDB-1700: fixed multiple same type of index applicatio...

2016-10-20 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1700: fixed multiple same type of index application error on the same field .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

2016-10-19 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit ht

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

2016-10-18 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1303 To unsubscribe, visit ht

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

2016-10-18 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Make Lock Manager Statistics at FINE granularity .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1303/3/asterixdb/asterix-events/src/main/reso

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

2016-10-12 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Not suppose to MERGE, for discussion purpose The following commits from your working branch will be included: .. Patch Set 1: That `println` only print if anythi

Change in asterixdb[master]: Tests for ASTERIXDB-1636

2016-10-05 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Tests for ASTERIXDB-1636 .. Patch Set 4: I have one small question that maybe not relevant to this patch. If you look at the *.aql, it is often ordered alphabeti

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

2016-10-04 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 12: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https:

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

2016-09-30 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 11: (1 comment) Just one comment https://asterix-gerrit.ics.uci.edu/#/c/1196/11/hyracks-fullstack/algeb

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

2016-09-29 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 10: Like this kind of test? :https://github.com/apache/asterixdb/blob/bce00de839d844e41de2958e1494a6

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

2016-09-28 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 10: (6 comments) Looks good in general. I have two main comments: 1. I saw this "numberOfNonMaterialize

Change in asterixdb[master]: Updated DeletableFrameTupleAppender to support reusing index...

2016-09-28 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Updated DeletableFrameTupleAppender to support reusing index slots. .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1214/2/hyracks-fullstack

Change in asterixdb[master]: Fix for ASTERIXDB-1636

2016-09-27 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1636 .. Patch Set 4: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1205 To unsubscribe, visit https://asterix-gerrit.ics.u

Change in asterixdb[master]: Updated DeletableFrameTupleAppender to support reusing index...

2016-09-27 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Updated DeletableFrameTupleAppender to support reusing index slots. .. Patch Set 1: (9 comments) Looks good in general. Just a few minor comments. https://aste

Change in asterixdb[master]: Fix for ASTERIXDB-1636

2016-09-25 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1636 .. Patch Set 4: (1 comment) I think maybe Taewoo knows better about the changes. Do we have some sort of unit test for storage codes? thi

Change in asterixdb[master]: Adding a new 101 tutorial for SQL++.

2016-09-14 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Adding a new 101 tutorial for SQL++. .. Patch Set 1: Thanks Yingyi for the explaination! -- To view, visit https://asterix-gerrit.ics.uci.edu/1131 To unsubscrib

Change in asterixdb[master]: Adding a new 101 tutorial for SQL++.

2016-09-13 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Adding a new 101 tutorial for SQL++. .. Patch Set 1: (7 comments) Looks good to me. All comments are more about the SQL++ syntax itself than the contents. Some

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

2016-09-08 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1144 To unsubscribe,

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

2016-09-08 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1144 To unsubscribe,

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

2016-09-08 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1144/3/hyracks-fullstack/hyracks/hyra

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

2016-09-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1144 To unsubscribe,

Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...

2016-09-02 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to conform to the memory budget .. Patch Set 9: @Taewoo, IMHO, the `The number of partitions for the

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

2016-08-31 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Not suppose to MERGE, for discussion purpose The following commits from your working branch will be included: .. Patch Set 1: @Yingyi, I think there maybe the is

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

2016-08-31 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1135 Change subject: Not suppose to MERGE, for discussion purpose The following commits from your working branch will be included: .. Not s

Change in asterixdb[master]: Fixes related to ASTERIXDB-1534

2016-08-25 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change. Change subject: Fixes related to ASTERIXDB-1534 .. Patch Set 2: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-ger

  1   2   >