Change in asterixdb[master]: [NO ISSUE][MTD] Fix Reading Dataset Compression From Dataset Record

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3445 )

Change subject: [NO ISSUE][MTD] Fix Reading Dataset Compression From Dataset 
Record
..


Patch Set 1: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3445
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdb1f64143fed43dc9eb37cf8a2fadbfd37dfde
Gerrit-Change-Number: 3445
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Comment-Date: Mon, 17 Jun 2019 01:35:46 +
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TEST] Allow asterix-dashboard skip

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][TEST] Allow asterix-dashboard skip
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3316
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie089a8649376caf731f989da3db4e8443981ec63
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for record deep comparison

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for record deep comparison
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3222/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java:

PS1, Line 402: getComplexFieldName
You can use RuntimeRecordTypeInfo to get the type without deserializing the 
string each time


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8bfbb014b86295749e980d123b0d3edf079beb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has abandoned this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Abandoned

Cannot be submitted as it's not backward-compatible.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3140

Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
..

[ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add unsigned short deserializer
- Try to detect overflowed offsets and try to ensure
  offsets are monotonically increasing.
- As a last resort, it sets the last field's (payload's)
  end offset as the size of the value.
- Add recovery test (passed 100KB record)

Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.2.ddl.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.3.update.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.4.txnqbc.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.5.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.6.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.7.txnqar.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.8.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/ShortPointable.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
17 files changed, 342 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/3140/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
index 7a1079d..c8da50a 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
@@ -415,8 +415,8 @@
 if (srcBuffer.position() + size > srcBuffer.limit()) {
 throw new BufferUnderflowException();
 }
+destTuple.resetByTupleOffset(srcBuffer.array(), srcBuffer.position(), 
size);
 destTuple.setFieldCount(fieldCnt);
-destTuple.resetByTupleOffset(srcBuffer.array(), srcBuffer.position());
 srcBuffer.position(srcBuffer.position() + size);
 return destTuple;
 }
diff --git 
a/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
new file mode 100644
index 000..7d441cd
--- /dev/null
+++ 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
@@ -0,0 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the 

Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has submitted this change and it was merged.

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..


[ASTERIXDB-2492][TXN] Skip filter update on undo

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Filter values should not be undone on UPDATE as the tuple
does not contain the filtered field.

Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3088
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Contrib: Jenkins 
Reviewed-by: Murtadha Hubail 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Murtadha Hubail: Looks good to me, approved

Objections:
  Anon. E. Moose #1000171: Violations found



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 946815f..3fce4d8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -75,7 +75,6 @@
 import org.apache.hyracks.storage.am.common.impls.NoOpIndexAccessParameters;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId.IdCompareResult;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentIdGenerator;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation.LSMIOOperationStatus;
@@ -752,6 +751,8 @@
 ILSMIndex index =
 (ILSMIndex) 
datasetLifecycleManager.getIndex(logRecord.getDatasetId(), 
logRecord.getResourceId());
 ILSMIndexAccessor indexAccessor = 
index.createAccessor(NoOpIndexAccessParameters.INSTANCE);
+ILSMIndexOperationContext opCtx = indexAccessor.getOpContext();
+opCtx.setFilterSkip(true);
 try {
 switch (logRecord.getNewOp()) {
 case 
AbstractIndexModificationOperationCallback.INSERT_BYTE:

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: [ASTERIXDB-2492][TXN] Skip filter update on undo

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3088

Change subject: [ASTERIXDB-2492][TXN] Skip filter update on undo
..

[ASTERIXDB-2492][TXN] Skip filter update on undo

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Filter values should not be undone on UPDATE as the tuple
does not contain the filtered field.

Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/88/3088/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 946815f..3fce4d8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -75,7 +75,6 @@
 import org.apache.hyracks.storage.am.common.impls.NoOpIndexAccessParameters;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentId.IdCompareResult;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentIdGenerator;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation;
 import 
org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation.LSMIOOperationStatus;
@@ -752,6 +751,8 @@
 ILSMIndex index =
 (ILSMIndex) 
datasetLifecycleManager.getIndex(logRecord.getDatasetId(), 
logRecord.getResourceId());
 ILSMIndexAccessor indexAccessor = 
index.createAccessor(NoOpIndexAccessParameters.INSTANCE);
+ILSMIndexOperationContext opCtx = indexAccessor.getOpContext();
+opCtx.setFilterSkip(true);
 try {
 switch (logRecord.getNewOp()) {
 case 
AbstractIndexModificationOperationCallback.INSERT_BYTE:

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3088
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b9c5d0350e1df94369e6733069dcf5af11a78b6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 

Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..


Patch Set 4:

Hi Murtadha, 
I will send an email to the dev to discuss this matter and submit a separate 
patch for the undo issue.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3065

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..

[ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

- user model changes: no
- storage format changes: yes
  - LogRecord format change
- interface changes: no

Details:
- Change field offset type from integer16 to integer32
- Skip updating the filter on undo operation
- Add recovery test

Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.2.ddl.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.3.update.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.4.txnqbc.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.5.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.6.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.7.txnqar.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.8.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
16 files changed, 298 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/65/3065/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3065

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes
..

[ASTERIXDB-2491,ASTERIXDB-2492][TXN] Recovery fixes

- user model changes: no
- storage format changes: yes
  - LogRecord format change
- interface changes: no

Details:
- Change field offset type from integer16 to integer32
- Skip updating the filter on undo operation
- Add recovery test

Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.3.update.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.4.txnqbc.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.5.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.6.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.7.txnqar.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.8.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
16 files changed, 298 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/65/3065/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Change field offset type to integer32

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3065

Change subject: [ASTERIXDB-2491][TXN] Change field offset type to integer32
..

[ASTERIXDB-2491][TXN] Change field offset type to integer32

- user model changes: no
- storage format changes: yes
  - LogRecord format change
- interface changes: no

Details:
- Change field offset type from integer16 to integer32
- Add recovery test

Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
---
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.3.update.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.4.txnqbc.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.5.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.6.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.7.txnqar.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.8.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
15 files changed, 296 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/65/3065/1

diff --git 
a/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
new file mode 100644
index 000..7d441cd
--- /dev/null
+++ 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
@@ -0,0 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+create_and_start.sh
\ No newline at end of file
diff --git 
a/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
new file mode 100644
index 000..a367ab7
--- /dev/null
+++ 
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *

Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Change field offset type to integer32

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new patch set (#2).

Change subject: [ASTERIXDB-2491][TXN] Change field offset type to integer32
..

[ASTERIXDB-2491][TXN] Change field offset type to integer32

- user model changes: no
- storage format changes: yes
  - LogRecord format change
- interface changes: no

Details:
- Change field offset type from integer16 to integer32
- Add recovery test

Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
---
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.1.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.2.ddl.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.3.update.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.4.txnqbc.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.5.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.6.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.7.txnqar.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100k/large_object_100K.8.script.aql
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A 
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
15 files changed, 296 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/65/3065/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171

Change in asterixdb[master]: [NO ISSUE][ING] TweetParserFactory fix

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][ING] TweetParserFactory fix
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3050
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If330bf060423027e01787224d1b2e93fd4d33d71
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring
..


Patch Set 6: Code-Review+2

I tested it locally as well. It failed because the size was not set.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3032
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring
..


Patch Set 5:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java:

PS5, Line 80: record
Also make this to take the initial buffer capacity.


https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java:

PS5, Line 54: 0
This is not needed anymore. You can make it to take the default buffer size.


https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java:

PS5, Line 63: 0
same


https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java:

PS5, Line 73: CharArrayRecord
You can move this out of the loop.


PS5, Line 99: CharArrayRecord
This one as well


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3032
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java:

PS5, Line 135: }
add:
this.size = strValue.length();


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3032
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2480][ING] Fix http-feed compatibility with JSON ...

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2480][ING] Fix http-feed compatibility with JSON 
parser
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3026
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I719c98376583a3316dbc291696df65a97dd4b26e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2480][ING] Fix http-feed compatibility with JSON ...

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2480][ING] Fix http-feed compatibility with JSON 
parser
..


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3026/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/http_feed_json/http_feed_json.3.post.http
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/http_feed_json/http_feed_json.3.post.http:

PS4, Line 20: body
It would good if we can have more than one record in a request. Just to make 
sure things work correctly?


https://asterix-gerrit.ics.uci.edu/#/c/3026/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java:

PS4, Line 60: CharArrayRecord
Maybe initializing it with inititalCapacity = 0?
new CharArrayRecord(0)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3026
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I719c98376583a3316dbc291696df65a97dd4b26e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][LOG] Ensure NC logDir ends with separator

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has submitted this change and it was merged.

Change subject: [NO ISSUE][LOG] Ensure NC logDir ends with separator
..


[NO ISSUE][LOG] Ensure NC logDir ends with separator

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: I492428fdbf84ed6f1c4afd136dce33ac84aea3c0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2982
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 
---
M asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified
  Ian Maxon: Looks good to me, approved



diff --git a/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf 
b/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
index e779dc2..2824219 100644
--- a/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
+++ b/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
@@ -17,6 +17,7 @@
 
 [common]
 log.level=INFO
+log.dir=logs
 
 [nc]
 txn.log.dir=txnlog
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
index 990d6c9..f4d10cb 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
@@ -18,6 +18,9 @@
  */
 package org.apache.hyracks.control.nc;
 
+import java.io.File;
+import java.net.URI;
+
 import org.apache.hyracks.control.common.controllers.NCConfig;
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.LoggerContext;
@@ -30,8 +33,6 @@
 import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
 import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
 
-import java.net.URI;
-
 public class NCLogConfigurationFactory extends ConfigurationFactory {
 private NCConfig config;
 
@@ -42,6 +43,7 @@
 public Configuration 
createConfiguration(ConfigurationBuilder builder) {
 String nodeId = config.getNodeId();
 String logDir = config.getLogDir();
+logDir = logDir.endsWith(File.separator) ? logDir : logDir + 
File.separator;
 builder.setStatusLevel(Level.WARN);
 builder.setConfigurationName("RollingBuilder");
 // create a rolling file appender

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2982
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I492428fdbf84ed6f1c4afd136dce33ac84aea3c0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ian2 Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has submitted this change and it was merged.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2857
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Contrib: Jenkins 
Reviewed-by: Murtadha Hubail 
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 18:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2857/17/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/AppendOnlyLinkedMetadataPageManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/AppendOnlyLinkedMetadataPageManager.java:

PS17, Line 256:  consider the index is not empty
  : return IBufferCache.INVALID_PAGEID;
  : }
> we don't allow a tree to be <2 pages anymore?
We need at least 2 pages to consider the tree as not empty (metadata page and 
root). Therefore, <2 means it's invalid.


https://asterix-gerrit.ics.uci.edu/#/c/2857/17/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java:

PS17, Line 303:  if (hasFailed()) {
  : throw HyracksDataException.create(getFailure());
  : }
  : bufferCache.finishQueue();
> why move this? is it the case that finishQueue doesn't have the metadata pa
The buffer cache is guarded against writing a deleted file (it is no-op). So 
there no reason for waiting for the queue. finishQueue for the metadata page is 
called at AppendOnlyLinkedMetadataPageManager#close() not in in the 
bulk-loader. I'm not sure if that was the case previously.


https://asterix-gerrit.ics.uci.edu/#/c/2857/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java:

PS17, Line 392: 
  : private boolean isCompressible(String fileName) {
  : return !fileName.endsWith(BLOOM_FILTER_SUFFIX) && 
!fileName.endsWith(DELETE_TREE_SUFFIX);
  : }
> should this also apply to rtrees ?
Yes. I Missed this one.
I was supporting the compression for RTrees but after running few experiments, 
it was not beneficial (doubles are mostly not compressible).

I can change that in a separate patch as the current RTree will have NoOp 
compressor.


https://asterix-gerrit.ics.uci.edu/#/c/2857/17/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java:

PS17, Line 111: );
> how many pages can you have confiscated at once for the LAF file?
It depends on how many extra pages and the buffer cache page size. If there are 
100 extra data pages and each page can hold 10 LAF entries, then we need 10 
pages for the LAF file.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#16).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 15:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2857/14/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/replication/bulkload_with_compression/bulkload.5.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/replication/bulkload_with_compression/bulkload.5.ddl.sqlpp:

PS14, Line 47: }
> remove
Done.
Sorry about that!


https://asterix-gerrit.ics.uci.edu/#/c/2857/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java:

PS14, Line 416: /**
> Please revert this to protected to allow extensions to add additional open 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#15).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/binary_type.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/double_end_record_token.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/usermd5.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/usermd5copy.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/utf8.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/big_object_20M.adm.template
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/customer.tbl.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/lineitem.tbl.big
A asterixdb/asterix-app/clusters/local/working_dir/data/big-object/order.tbl.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/order.tbl.verylong.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/classifications/animals.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/compression/incompressible_large_object.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/compression/incompressible_object.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/country.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/mountain.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/sea.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/55.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_01.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_02.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_sample.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_01.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_02.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_03.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_04_quote_error.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_05_space_error_1.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_06_space_error_2.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.cr
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.crlf
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.lf
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/customer-tiny-neg.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/customer-tiny.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/order-tiny.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/csx-small-multi-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-multi-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-nulls.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/more-dblp-small-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/part-0.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/part-1.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/demo0927/customerData.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/demo0927/orderData.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/duplicateKeys.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 14:

(1 comment)

@Murtadha:
Changed as suggested.

@Mike B.:
It failed because I forgot to change the AST after I modified the query to 
project only certain fields instead of all the fields of Metadata.Dataset. This 
is needed because of the added optinal open field 
`BlockLevelStorageCompression` in Metadata.Dataset, which appears only for 
compressed datasets.

https://asterix-gerrit.ics.uci.edu/#/c/2857/13/asterixdb/asterix-app/src/test/resources/cc-compression.conf
File asterixdb/asterix-app/src/test/resources/cc-compression.conf:

PS13, Line 39: 21MB
> is this increase needed?
Yes. Otherwise, big_object_load_20M and incompressible-pages/large-page would 
fail.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#14).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/binary_type.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/double_end_record_token.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/usermd5.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/usermd5copy.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/adm-load/utf8.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/big_object_20M.adm.template
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/customer.tbl.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/lineitem.tbl.big
A asterixdb/asterix-app/clusters/local/working_dir/data/big-object/order.tbl.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/big-object/order.tbl.verylong.big
A 
asterixdb/asterix-app/clusters/local/working_dir/data/classifications/animals.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/compression/incompressible_large_object.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/compression/incompressible_object.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/country.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/mountain.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/country/sea.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/55.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_01.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_02.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/fragile_sample.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_01.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_02.csv
A asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_03.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_04_quote_error.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_05_space_error_1.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_06_space_error_2.csv
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.cr
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.crlf
A 
asterixdb/asterix-app/clusters/local/working_dir/data/csv/sample_08_header.csv.lf
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/customer-tiny-neg.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/customer-tiny.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/custord-tiny/order-tiny.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/csx-small-multi-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-multi-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small-nulls.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/dblp-small.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/more-dblp-small-id.txt
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/part-0.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/dblp-small/part-1.adm
A 
asterixdb/asterix-app/clusters/local/working_dir/data/demo0927/customerData.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/demo0927/orderData.adm
A asterixdb/asterix-app/clusters/local/working_dir/data/duplicateKeys.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#13).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 12:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2857/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java:

PS12, Line 48: getDdlOrDefaultCompressionScheme
I added this method to ensure that 
Metadata.Dataset.BlockLevelStorageCompression includes the compression scheme 
(either the defined scheme in the DDL or the one in the cluster config) during 
the dataset creation. This is needed to guard against any compression 
alteration in the cluster configuration.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 12: -Code-Review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 12: Code-Review+2

(26 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java:

PS9, Line 253: Compr
> remove block
Done


Line 274: if (json != null) {
> do this at the beginning:
Done


PS9, Line 279: 
 : 
 : private IJsonSerializable deserializeDefault(Class defaultClass)
 : throws HyracksDataException {
 : //Ensure it is registered
 : final String resourceId = getResourceId(defaultClass);
 : try {
 : Class clazz = 
getResourceClass(resourceId);
 : //Using static method (fromJson)
 :  
> extract method e.g. deserializeDefault
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java:

PS9, Line 51: testsuite_sqlpp.xml"
> If a new test case that might cause problems to compression is added to the
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp:

PS9, Line 40: 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp:

PS9, Line 40: 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml
File asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml:

PS9, Line 80: Rebalance w
> Rebalance
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java:

PS9, Line 26: validate
> validates
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ConfigurationUtil.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ConfigurationUtil.java:

Line 34: }
> remove empty line
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java:

PS9, Line 63: return hints;
> We need to get rid of this completely.
Done


PS9, Line 133: 
> This shouldn't be treated as a hint.
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java:

PS9, Line 50: registeredSchemes
> remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java:

PS9, Line 245: private final IFIFOPageQ
> remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AbstractBufferedFileIOManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AbstractBufferedFileIOManager.java:

PS9, Line 38: unexpected 
> unexpected
Done


PS9, Line 43: protected
> private
Done


PS9, Line 47: IFileHan
> this doesn't need to be volatile anymore
Done


Line 48: private volatile boolean hasOpen;
> volatile
Done


PS9, Line 168: open
> opened
Done


PS9, Line 173: hasBeenOpen
> hasBeenOpened
Done


PS9, Line 283: throwException(Stri
> Errors in java are scary. Rename to something that doesn't have the word "e
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#12).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#11).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#10).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new configuration in the with-caluse to enable compression
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
  - Allow optional values in the LocalResource
  - Add compression information in Metadata.Dataset
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Add new integration test for this patch
  - Fix ASTERIXDB-2464
  - Add ddl-with-clause type validator

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/missing-non-optional/missing-non-optional.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/type-mismatch/type-mismatch.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-field/unsupported-field.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl-with-clause/unsupported-subfield/unsupported-subfield.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.10.post.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.11.get.http
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#9).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2857/6/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/impl/NoOpCompressorDecompressor.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/impl/NoOpCompressorDecompressor.java:

PS6, Line 19: org.apache.hyracks.api.compression.impl
> Could we move the implementations out of the hyracks-api module?
Sure. Is the compression restricted to storage only? or might be utilized 
somewhere else (e.g., SortRunGenerator)?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#6).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Patch Set 3:

(43 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml:

PS2, Line 54: 
> remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

PS2, Line 51: STORAGE_COMPRESSION_SCHEME(STRING, "
> remove
Done


PS2, Line 52: 
> This value should be referenced from somewhere else (e.g. CompressionManage
CompressionManager is not visible here.
It seems that we put string constants (e.g replication strategy in 
ReplicationProperties)?


PS2, Line 94: 
> The default compression scheme for storage
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java:

PS2, Line 183: public static final int UNKNOWN_COMPRESSION_SCHEME = 1095
> This shouldn't be needed. Replace it by illegal state exception
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java:

PS2, Line 34: C
> no such parameter
Done


PS2, Line 42: 
> This parameter doesn't seem right. Why would the compression manager know a
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS2, Line 170: 1095 = Unknown compression scheme %1$s. Supported schemes are 
%2$s
> shouldn't be needed
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java:

PS2, Line 60: CompressionSchemePara
> This seems to be a parameter and not a hint.
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java:

PS2, Line 38: private static final 
> remove
Done


PS2, Line 42:  * New compression schem
> remove
Done


PS2, Line 45: ible with the previ
> shouldn't be needed
Done


PS2, Line 46: 
> Call this from a static block.
Done


PS2, Line 58: 
: @Override
: publi
> Remove this
Done


PS2, Line 66: } catch (IllegalAccessException | InstantiationException 
e) {
: throw new IllegalStateException("Failed to 
instantiate compressor/decompressor: " + scheme, e);
: }
> Let's also add Java's "deflate" compressor, so users can enable compression
>From the API, Deflater is not thread-safe. Example:
 byte[] output = new byte[100];
 Deflater compresser = new Deflater();
 compresser.setInput(input);
 compresser.finish();
 int compressedDataLength = compresser.deflate(output);
 compresser.end();

Unless we're willing to create an object (Deflater, Inflater) for each 
compress/uncompress call? or synchronize it?


PS2, Line 66: } catch (IllegalAccessException | InstantiationException 
e) {
: throw new IllegalStateException("Failed to 
instantiate compressor/decompressor: " + scheme, e);
: }
> From the experiments results, it appears that snappy always outperformed th
Done


PS2, Line 89:true if it 
> you shouldn't need this
Done


PS2, Line 116: me != null ? ddlSche
> This should be illegal state exception
Done


PS2, Line 131: 
> The CC/NC will fail to start up and the only way to figure out what's happe
Done


https://asterix-gerrit.ics.uci.edu/#/c/2857/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/ICompressorDecompressor.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/compression/ICompressorDecompressor.java:

PS2, Line 37: The required buffer size 
> s/computeCompressBufferSize/computeCompressedBufferSize/
Done


PS2, Line 58: 
> s/uncompressedBuffer/uBuffer/
Done


PS2, Line 58: 
> s/compressedBuffer/cBuffer/
Done


PS2, Line 80: 
> s/uncompressedBuffer/uBuffer/
Done


PS2, Line 80: 
> s/compressedBuffer/cBuffer/
Done


PS2, Line 81: 
> s/length/cLength/
Done

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch
  - Fix ASTERIXDB-2464

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
A asterixdb/asterix-app/data/compression/incompressible_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compression_sqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_load_20M_compressed/big_object_load_20M.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page_no_compression/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page/small-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/small-page_no_compression/small-page_no_compression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/rebalance/all_datasets_compressed/all_datasets_compressed.1.ddl.sqlpp
A 

Change in asterixdb[master]: [NO ISSUE][LOG] Ensure NC logDir ends with separator

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2982

Change subject: [NO ISSUE][LOG] Ensure NC logDir ends with separator
..

[NO ISSUE][LOG] Ensure NC logDir ends with separator

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: I492428fdbf84ed6f1c4afd136dce33ac84aea3c0
---
M asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/82/2982/1

diff --git a/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf 
b/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
index e779dc2..2824219 100644
--- a/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
+++ b/asterixdb/asterix-server/src/main/opt/ansible/conf/cc.conf
@@ -17,6 +17,7 @@
 
 [common]
 log.level=INFO
+log.dir=logs
 
 [nc]
 txn.log.dir=txnlog
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
index 990d6c9..f4d10cb 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java
@@ -18,6 +18,9 @@
  */
 package org.apache.hyracks.control.nc;
 
+import java.io.File;
+import java.net.URI;
+
 import org.apache.hyracks.control.common.controllers.NCConfig;
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.LoggerContext;
@@ -30,8 +33,6 @@
 import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
 import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
 
-import java.net.URI;
-
 public class NCLogConfigurationFactory extends ConfigurationFactory {
 private NCConfig config;
 
@@ -42,6 +43,7 @@
 public Configuration 
createConfiguration(ConfigurationBuilder builder) {
 String nodeId = config.getNodeId();
 String logDir = config.getLogDir();
+logDir = logDir.endsWith(File.separator) ? logDir : logDir + 
File.separator;
 builder.setStatusLevel(Level.WARN);
 builder.setConfigurationName("RollingBuilder");
 // create a rolling file appender

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2982
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I492428fdbf84ed6f1c4afd136dce33ac84aea3c0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2857

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/incompressible-pages/large-page/large-page.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4/scheme-lz4.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4hc/scheme-lz4hc.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-none/scheme-none.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-snappy/scheme-snappy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 

Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE] User-defined Function Documentation update
..


Patch Set 15:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2804/14/asterixdb/asterix-doc/src/main/user-defined_function/udf.md
File asterixdb/asterix-doc/src/main/user-defined_function/udf.md:

Line 54: here is an example to use UDF `mysum` to compute the sum of two input 
integers.
> couldn't find a better way to point people to the right place let's if 
Maybe if we have a stand-alone package for the same example under a new repo 
(maybe astreixdb-udfs) which includes a pom file with all the needed 
dependencies. Or maybe under a new module and use it as a reference for how to 
write a UDF and deploy it?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2804
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17b1b4d639ca38689298ce88145257e794eb90e1
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ian2 Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has abandoned this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..


Abandoned

Local files was corrupted

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2810
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4a8ad8deafeefe96ada5e3be5126fbb32ee981a3
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2857

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/incompressible-pages/large-page/large-page.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4/scheme-lz4.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4hc/scheme-lz4hc.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-none/scheme-none.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-snappy/scheme-snappy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
A 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2810

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: I4a8ad8deafeefe96ada5e3be5126fbb32ee981a3
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/incompressible-pages/large-page/large-page.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4/scheme-lz4.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4hc/scheme-lz4hc.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-none/scheme-none.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-snappy/scheme-snappy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 

Change in asterixdb[master]: [ASTERIXDB-2414][STO] Fix name of merge files

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2414][STO] Fix name of merge files
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2820
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I861765bc0f293bdfdf0285f97884d536204fdb1e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2414][STO] Remove deleted component files from bu...

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2414][STO] Remove deleted component files from 
buffer cache
..


Patch Set 7: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2822/7/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/src/test/java/org/apache/hyracks/storage/am/lsm/common/component/TestLsmIndexFileManager.java
File 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/src/test/java/org/apache/hyracks/storage/am/lsm/common/component/TestLsmIndexFileManager.java:

PS7, Line 43: bufferCached
naming: bufferCache instead of bufferCached


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2822
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0f11bc222662e4b50c1b47b1dfa6b30d1463b2e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2810

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: I4a8ad8deafeefe96ada5e3be5126fbb32ee981a3
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/incompressible-pages/large-page/large-page.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4/scheme-lz4.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4hc/scheme-lz4hc.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-none/scheme-none.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-snappy/scheme-snappy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 

Change in asterixdb[master]: [ASTERIXDB-2422][STO] Introduce compressed storage

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2810

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
..

[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes
  - Add new key-value in hints
  - Add new nc configuration in the config file
- storage format changes: yes
  - Pages of the primary index can be compressed
  - Add a companion file (Look Aside File) with the compressed index
- interface changes: yes
  - ICCApplicationContext:
- Add getCompressionManager()
  - IBufferCache:
- Add getCompressedFileWriter(int fileId)
  - ICachedPageInternal:
- Add setCompressedPageOffset(long offset)
- Add getCompressedPageOffset()
- Add setCompressedPageSize(int size)
- Add getCompressedPageSize()

Details:
  - Added new integration test for this patch

Additional details in the design document:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: I4a8ad8deafeefe96ada5e3be5126fbb32ee981a3
---
A asterixdb/asterix-app/data/compression/incompressible_large_object.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java
A asterixdb/asterix-app/src/test/resources/cc-compression.conf
A asterixdb/asterix-app/src/test/resources/runtimets/compressionSqlpp.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/incompressible-pages/large-page/large-page.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/invalid-compression-scheme/invalid-compression-scheme.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4/scheme-lz4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-lz4hc/scheme-lz4hc.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/incompressible-pages/large-page/large-page.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4/scheme-lz4.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-lz4hc/scheme-lz4hc.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-none/scheme-none.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/compression/scheme-snappy/scheme-snappy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
A 

Change in asterixdb[master]: [ASTERIXDB-2357] ADMParser Improvements

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2357] ADMParser Improvements
..


Patch Set 6: Code-Review+1

(1 comment)

I have only one comment.

https://asterix-gerrit.ics.uci.edu/#/c/2573/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java:

PS6, Line 313: fieldName2Id
Can we use recType.getFieldIndex?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2573
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I106b58e79746b0a6f3d8b79473202653341a7009
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 14:

> Patch Set 14: Code-Review+2

As Dimitry's +2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 14: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2322

to look at the new patch set (#9).

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A asterixdb/asterix-app/data/boolean/3-var.adm
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
A 

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2322

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A asterixdb/asterix-app/data/boolean/3-var.adm
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct01/factor-common-conjunct01.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct02/factor-common-conjunct02.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/factor-common-conjunct03/factor-common-conjunct03.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condition-optimization/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
A 

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 7:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2322/5/asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp:

Line 63:   p_partkey: int64,
> remove trailing whitespace
Done


https://asterix-gerrit.ics.uci.edu/#/c/2322/5/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp:

Line 29: {"a" : false, "b":false, "c":true},
> remote trailing whitespace on both lines
Done


Line 37: where (a = b and b = c) or (a = b and c)
> let's add ORDER BY a,b,c
Done


https://asterix-gerrit.ics.uci.edu/#/c/2322/5/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp:

Line 29: {"a" : false, "b":false, "c":true},
> remove trailing whitespace in both lines
Done


Line 37: where a and a
> let's add ORDER BY a,b,c
Done


https://asterix-gerrit.ics.uci.edu/#/c/2322/5/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp:

Line 29: {"a" : false, "b":false, "c":true},
> remote trailing whitespace in both lines
Done


Line 37: where  a or a
> let's add ORDER BY a,b,c
Done


https://asterix-gerrit.ics.uci.edu/#/c/2322/5/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
File 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java:

Line 81:  * @param condRef
> only FactorCommonConjunctionFromDisjunctionRule uses this method, the other
Done


Line 85:  * {@code false} otherwise.
> can we just return 'null' and eliminate EMPTY_EXPRESSION_LIST constant?
I did this because sonar was complaining.
Now it returns null and added NOSONAR.


https://asterix-gerrit.ics.uci.edu/#/c/2322/6/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java
File 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java:

PS6, Line 49: if (disjunctExprs.size() == 1) {
: condRef.setValue(disjunctExprs.get(0).getValue());
: }
Similarly, I moved this inside the if statement.


https://asterix-gerrit.ics.uci.edu/#/c/2322/5/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java
File 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java:

Line 54: changed |= inlineCondititon(function);
> I think we want to rewrite and(x) -> x , or(x) -> x even if "changed=false"
Sure... Now it looks cleaner :)
Thank!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2322

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/factor-common-conjunct/factor-common-conjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java
23 files changed, 938 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/2322/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2322

to look at the new patch set (#6).

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q12_shipping_broadcast.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/factor-common-conjunct/factor-common-conjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java
24 files changed, 939 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/2322/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [WIP] Extract bulk loader out

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2367

Change subject: [WIP] Extract bulk loader out
..

[WIP] Extract bulk loader out

TODO:
- Clean up InvertedIndex bulkloader
- Extract external indexes bulkloader

Change-Id: I7f42a391a4de4b02acf6a8fdaf2b60818c1da806
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeBulkLoader.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IBulkLoadFinalizer.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndexBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndex.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/OnDiskInvertedIndexBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/PartitionedOnDiskInvertedIndex.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/ExternalRTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeBulkLoader.java
12 files changed, 915 insertions(+), 690 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/67/2367/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
index 6e2d694..98cb391 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
@@ -41,7 +41,6 @@
 import 
org.apache.hyracks.storage.am.btree.impls.BTreeOpContext.PageValidationInfo;
 import org.apache.hyracks.storage.am.common.api.IBTreeIndexTupleReference;
 import org.apache.hyracks.storage.am.common.api.IPageManager;
-import org.apache.hyracks.storage.am.common.api.ISplitKey;
 import org.apache.hyracks.storage.am.common.api.ITreeIndexAccessor;
 import org.apache.hyracks.storage.am.common.api.ITreeIndexCursor;
 import org.apache.hyracks.storage.am.common.api.ITreeIndexFrame;
@@ -50,7 +49,6 @@
 import org.apache.hyracks.storage.am.common.frames.FrameOpSpaceStatus;
 import org.apache.hyracks.storage.am.common.impls.AbstractTreeIndex;
 import org.apache.hyracks.storage.am.common.impls.NoOpIndexAccessParameters;
-import org.apache.hyracks.storage.am.common.impls.NodeFrontier;
 import org.apache.hyracks.storage.am.common.impls.TreeIndexDiskOrderScanCursor;
 import org.apache.hyracks.storage.am.common.ophelpers.IndexOperation;
 import org.apache.hyracks.storage.common.IIndexAccessParameters;
@@ -61,7 +59,6 @@
 import org.apache.hyracks.storage.common.ISearchOperationCallback;
 import org.apache.hyracks.storage.common.ISearchPredicate;
 import org.apache.hyracks.storage.common.MultiComparator;
-import org.apache.hyracks.storage.common.buffercache.BufferCache;
 import org.apache.hyracks.storage.common.buffercache.IBufferCache;
 import org.apache.hyracks.storage.common.buffercache.ICachedPage;
 import org.apache.hyracks.storage.common.file.BufferedFileHandle;
@@ -1000,204 +997,7 @@
 @Override
 public IIndexBulkLoader createBulkLoader(float fillFactor, boolean 
verifyInput, long numElementsHint,
 boolean checkIfEmptyIndex) throws HyracksDataException {
-return new BTreeBulkLoader(fillFactor, verifyInput);
-}
-
-public class BTreeBulkLoader extends 
AbstractTreeIndex.AbstractTreeIndexBulkLoader {
-protected final ISplitKey splitKey;
-protected final boolean verifyInput;
-
-public BTreeBulkLoader(float fillFactor, boolean verifyInput) throws 
HyracksDataException {
-super(fillFactor);
-this.verifyInput = verifyInput;
-splitKey = new 

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2322

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/factor-common-conjunct/factor-common-conjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java
23 files changed, 948 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/2322/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2322

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..

[ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Add a rule to factor out common conjunct from disjunct.
- Additional needed rules:
-- Remove redundant boolean expression
   e.g and(a, a)
-- Inline same boolean expressions
   e.g and(a, and(b, c))

Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpch/q19_discounted_revenue.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q19_discounted_revenue.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/minimum-disjunct/minimum-disjunct.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-conjunct-expression/redundant-conjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/redundant-disjunct-expression/redundant-disjunct-expression.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/factor-common-conjunct/factor-common-conjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/minimum-disjunct/minimum-disjunct.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-conjunct-expression/redundant-conjunct-expression.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/condititon/redundant-disjunct-expression/redundant-disjunct-expression.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractConditionExpressionRewriteRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FactorCommonConjunctionFromDisjunctionRule.java
A 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineAndRemoveRedundantBooleanExpressionsRule.java
23 files changed, 948 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/2322/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
index bd67ed4..6fa746b 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
@@ -97,8 +97,10 @@
 import org.apache.hyracks.algebricks.rewriter.rules.ExtractCommonOperatorsRule;
 import org.apache.hyracks.algebricks.rewriter.rules.ExtractGbyExpressionsRule;
 import 
org.apache.hyracks.algebricks.rewriter.rules.ExtractGroupByDecorVariablesRule;
+import 
org.apache.hyracks.algebricks.rewriter.rules.FactorCommonConjunctionFromDisjunctionRule;
 import 
org.apache.hyracks.algebricks.rewriter.rules.FactorRedundantGroupAndDecorVarsRule;
 import org.apache.hyracks.algebricks.rewriter.rules.InferTypesRule;
+import 
org.apache.hyracks.algebricks.rewriter.rules.InlineAndRemoveRedundantBooleanExpressionsRule;
 import 

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#9).

Change subject: [NO ISSUE] Jackson parser for JSON format
..

[NO ISSUE] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Details:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Parse temporal values from strings if defined
  only for DATE, TIME, DATETIME.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
A asterixdb/asterix-app/data/json/double-150-11.json
A asterixdb/asterix-app/data/json/duplicate-fields.json
A asterixdb/asterix-app/data/json/geometry.json
A asterixdb/asterix-app/data/json/int-100.json
A asterixdb/asterix-app/data/json/int-1000.json
A asterixdb/asterix-app/data/json/line-3-points.json
A asterixdb/asterix-app/data/json/malformed-json.json
A asterixdb/asterix-app/data/json/null-missing.json
A asterixdb/asterix-app/data/json/polygon-with-hole.json
A asterixdb/asterix-app/data/json/temporal.json
A asterixdb/asterix-app/data/json/unclosed-polygon.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.1.ddl.sqlpp
A 

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#8).

Change subject: [NO ISSUE] Jackson parser for JSON format
..

[NO ISSUE] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Details:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Parse temporal values from strings if defined
  only for DATE, TIME, DATETIME.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
A asterixdb/asterix-app/data/json/double-150-11.json
A asterixdb/asterix-app/data/json/duplicate-fields.json
A asterixdb/asterix-app/data/json/geometry.json
A asterixdb/asterix-app/data/json/int-100.json
A asterixdb/asterix-app/data/json/int-1000.json
A asterixdb/asterix-app/data/json/line-3-points.json
A asterixdb/asterix-app/data/json/malformed-json.json
A asterixdb/asterix-app/data/json/null-missing.json
A asterixdb/asterix-app/data/json/polygon-with-hole.json
A asterixdb/asterix-app/data/json/temporal.json
A asterixdb/asterix-app/data/json/unclosed-polygon.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.1.ddl.sqlpp
A 

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
..


Patch Set 7: -Code-Review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#7).

Change subject: [NO ISSUE] Jackson parser for JSON format
..

[NO ISSUE] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Details:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Parse temporal values from strings if defined
  only for DATE, TIME, DATETIME.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
A asterixdb/asterix-app/data/json/double-150-11.json
A asterixdb/asterix-app/data/json/duplicate-fields.json
A asterixdb/asterix-app/data/json/geometry.json
A asterixdb/asterix-app/data/json/int-100.json
A asterixdb/asterix-app/data/json/int-1000.json
A asterixdb/asterix-app/data/json/line-3-points.json
A asterixdb/asterix-app/data/json/malformed-json.json
A asterixdb/asterix-app/data/json/null-missing.json
A asterixdb/asterix-app/data/json/polygon-with-hole.json
A asterixdb/asterix-app/data/json/temporal.json
A asterixdb/asterix-app/data/json/unclosed-polygon.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.1.ddl.sqlpp
A 

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#6).

Change subject: [NO ISSUE] Jackson parser for JSON format
..

[NO ISSUE] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Features:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Parse temporal values from strings if defined
  only for DATE, TIME, DATETIME.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
A asterixdb/asterix-app/data/json/double-150-11.json
A asterixdb/asterix-app/data/json/duplicate-fields.json
A asterixdb/asterix-app/data/json/geometry.json
A asterixdb/asterix-app/data/json/int-100.json
A asterixdb/asterix-app/data/json/int-1000.json
A asterixdb/asterix-app/data/json/line-3-points.json
A asterixdb/asterix-app/data/json/malformed-json.json
A asterixdb/asterix-app/data/json/null-missing.json
A asterixdb/asterix-app/data/json/polygon-with-hole.json
A asterixdb/asterix-app/data/json/temporal.json
A asterixdb/asterix-app/data/json/unclosed-polygon.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.1.ddl.sqlpp
A 

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#5).

Change subject: [NO ISSUE] Jackson parser for JSON format
..

[NO ISSUE] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Features:
- 4X faster than the current ADM parser/
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
A asterixdb/asterix-app/data/json/double-150-11.json
A asterixdb/asterix-app/data/json/duplicate-fields.json
A asterixdb/asterix-app/data/json/geometry.json
A asterixdb/asterix-app/data/json/int-100.json
A asterixdb/asterix-app/data/json/int-1000.json
A asterixdb/asterix-app/data/json/line-3-points.json
A asterixdb/asterix-app/data/json/malformed-json.json
A asterixdb/asterix-app/data/json/null-missing.json
A asterixdb/asterix-app/data/json/polygon-with-hole.json
A asterixdb/asterix-app/data/json/temporal.json
A asterixdb/asterix-app/data/json/unclosed-polygon.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/duplicate-fields/duplicate-fields.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/malformed-json/malformed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-missing/nonoptional-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/nonoptional-null/nonoptional-null.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/null-missing/null-missing.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-demote-double-bigint/double-bigint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-float/float.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-promote-bigint-double/bigint-double.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint-overflow/tinyint-overflow.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/numeric-tinyint/tinyint.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-line-3-points/spatial-line-3-points.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-unclosed/spatial-polygon-unclosed.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial-polygon-with-hole/spatial-polygon-with-hole.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/json-parser/spatial/spatial.2.query.sqlpp
A 

Change in asterixdb[master]: [WIP] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#4).

Change subject: [WIP] Jackson parser for JSON format
..

[WIP] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make IDataParserFactory.setRecordType()
to throw AsterixException
  - Remove unused throws exception from
IAsterixListBuilder.reset()

Features:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parses GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Detects GeoJSON geometry objects
  (if enabled) for open types.

TODO:
- Add tests.
- Fix exceptions with error codes.
- Add tempoeal detection.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/JSONDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/AbstractRecordStreamParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ADMToken.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/GeometryCoParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ParserContext.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IAsterixListBuilder.java
15 files changed, 1,337 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/76/2076/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [WIP] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#3).

Change subject: [WIP] Jackson parser for JSON format
..

[WIP] Jackson parser for JSON format

- user model changes: no
- storage format changes: no
- interface changes: yes
  - Make AbstractRecordStreamParserFactory#setRecordType
to throw AsterixException

Features:
- 4X faster than the current ADM parser.
- Uses lower number of temporary buffers.
- Parse GeoJSON geometry objects if defined
  only for POINT, LINE and POLYGON.
- Detect GeoJSON geometry objects
  (if enabled) for open types.

TODO:
- Add tests.
- Fix exceptions with error codes.
- Add tempoeal type detection.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/JSONDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/AbstractRecordStreamParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ADMToken.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/GeometryCoParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ParserContext.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IAsterixListBuilder.java
15 files changed, 1,343 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/76/2076/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [WIP] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2076

to look at the new patch set (#2).

Change subject: [WIP] Jackson parser for JSON format
..

[WIP] Jackson parser for JSON format

Currently it gives around 4X speedup comapred with ADMDataParser.
TODO:
- Add tests.
- Check the ability to extend Jakson parser to include ADM types.
- Complete auto detection ability for Date and GeoJSON
- Add suport for points/line/polygon types from GeoJSON

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/JSONDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/AbstractRecordStreamParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ADMToken.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ParserContext.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IAsterixListBuilder.java
14 files changed, 944 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/76/2076/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [WIP] Jackson parser for JSON format

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2076

Change subject: [WIP] Jackson parser for JSON format
..

[WIP] Jackson parser for JSON format

Currently it gives around 4X speedup comapred with ADMDataParser.
TODO:
- Support streams.
- Add tests.
- Check the ability to extend Jakson parser to include ADM types.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/JSONDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IAsterixListBuilder.java
9 files changed, 642 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/76/2076/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index f960ce5..17e9dbe 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -238,6 +238,7 @@
 public static final int METADATA_DROP_FUCTION_IN_USE = 3109;
 public static final int FEED_FAILED_WHILE_GETTING_A_NEW_RECORD = 3110;
 public static final int FEED_START_FEED_WITHOUT_CONNECTION = 3111;
+public static final int PARSER_COLLECTION_ITEM_CANNOT_BE_NULL = 3112;
 
 // Lifecycle management errors
 public static final int DUPLICATE_PARTITION_ID = 4000;
diff --git 
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index 7362181..23d852d 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -227,6 +227,7 @@
 3109 = Function %1$s is being used. It cannot be dropped
 3110 = Feed failed while reading a new record
 3111 = Feed %1$s is not connected to any dataset
+3112 = Array/Multiset item cannot be null
 
 # Lifecycle management errors
 4000 = Partition id %1$d for node %2$s already in use by node %3$s
diff --git a/asterixdb/asterix-external-data/pom.xml 
b/asterixdb/asterix-external-data/pom.xml
index 37f91ce..eda44cf 100644
--- a/asterixdb/asterix-external-data/pom.xml
+++ b/asterixdb/asterix-external-data/pom.xml
@@ -412,5 +412,9 @@
   com.fasterxml.jackson.core
   jackson-databind
 
+
+  com.fasterxml.jackson.core
+  jackson-core
+
   
 
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
new file mode 100644
index 000..2080a96
--- /dev/null
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractNestedDataParser.java
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.external.parser;
+
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.BitSet;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.TreeMap;
+
+import org.apache.asterix.builders.AbvsBuilderFactory;
+import org.apache.asterix.builders.IARecordBuilder;
+import 

Change in asterixdb[master]: [NO ISSUE][API] Add Result Location API

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#10).

Change subject: [NO ISSUE][API] Add Result Location API
..

[NO ISSUE][API] Add Result Location API

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 403 insertions(+), 36 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 19:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java:

PS17, Line 26: 
> I see why you would like to have such factory. Let's pretend that we have o
Probably that would work.

Thanks!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][API] Add Result Location API

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#9).

Change subject: [NO ISSUE][API] Add Result Location API
..

[NO ISSUE][API] Add Result Location API

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
1- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 375 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: AsterixDB Schema Inferencer

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has abandoned this change.

Change subject: AsterixDB Schema Inferencer
..


Abandoned

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1003
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Sattam Alsubaiee 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [API] Add Result Location API.

[Wail Alkowaileet (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#7).

Change subject: [API] Add Result Location API.
..

[API] Add Result Location API.

- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 375 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 17:

> (1 comment)
 > 
 > Great work Illdar!
 > I have only one question about IChainedComponentBulkLoader
 > (inlined).
 > AFAIK, the LSM Stats Collector lives in the hyracks level. Som I'm
 > not sure if the Stat Collector requires similar approach.

I can extend it to let the upper layer levels handle them (if it's out of the 
scope of this patch).

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 17:

(1 comment)

Great work Illdar!
I have only one question about IChainedComponentBulkLoader (inlined).
AFAIK, the LSM Stats Collector lives in the hyracks level. Som I'm not sure if 
the Stat Collector requires similar approach.

https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java:

PS17, Line 26: IChainedComponentBulkLoader
AsterixDB Tuple Compactor works in AsterixDB level.
So what I probably need is a (serializable) factory for the 
IChainedComponentBulkLoader. The configuration of the bulkload task will be 
determined per dataset basis. In other words, It depends on the initial 
type/schema of the dataset and if the tuple compactor is enabled.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [API] Add Result Location API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#5).

Change subject: [API] Add Result Location API.
..

[API] Add Result Location API.

- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 374 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Add Result Location API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#4).

Change subject: Add Result Location API.
..

Add Result Location API.

- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 376 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add Result Location API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1742

to look at the new patch set (#3).

Change subject: Add Result Location API.
..

Add Result Location API.

- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 374 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1742
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add Result Location API.

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1742

Change subject: Add Result Location API.
..

Add Result Location API.

- Allows to retrieve result directly from the Distributed Result Framework.

Change-Id: I3c888bb11f90d119b01acc80576e127b84789ed8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.1.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_1/result_location_1.2.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.3.location.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/result_location_2/result_location_2.4.get.uri
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_1/result_location_1.2.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/async-deferred/result_location_2/result_location_1.2.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
19 files changed, 377 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1742/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
index 19f0dcc..1f8f98f 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
@@ -56,9 +56,13 @@
  */
 DEFERRED,
 /**
+ * Results are produced completely, but only a location handle is 
returned.
+ */
+LOCATION,
+/**
  * A result handle is returned before the resutlts are complete
  */
-ASYNC
+ASYNC;
 }
 
 class ResultMetadata implements Serializable {
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
index a4e72f7..a6d1bec 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
@@ -46,7 +46,10 @@
 RESULTS("results"),
 HANDLE("handle"),
 ERRORS("errors"),
-METRICS("metrics");
+METRICS("metrics"),
+RESULT_LOCATIONS("locations"),
+ADDRESS("address"),
+PORT("port");
 
 private final String str;
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
new file mode 100644
index 000..5d1eca4
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationAPIServlet.java
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has abandoned this change.

Change subject: Add result location HTTP API.
..


Abandoned

New patch has been submitted...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1692

to look at the new patch set (#2).

Change subject: ASTERIXDB-1885: Fix printing field separators for record printer
..

ASTERIXDB-1885: Fix printing field separators for record printer

- Fix commas to not appear at the beginning of a record.

Change-Id: I19e5c908367490a64104d961146bad2d870d0c58
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/insert_from_ext_ds/insert_from_ext_ds.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
7 files changed, 121 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/92/1692/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1692
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: ASTERIXDB-1885: Fix printing field separators for record printer
..


Patch Set 1:

It seems the test (temporal/insert_from_ext_ds) produces the same issue. I 
repeated it as a regression test (null-missing/print-ASTERIXDB-1885). If it's 
not necessary, I can delete it.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1692
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19e5c908367490a64104d961146bad2d870d0c58
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1885: Fix printing field separators for record pri...

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1692

Change subject: ASTERIXDB-1885: Fix printing field separators for record printer
..

ASTERIXDB-1885: Fix printing field separators for record printer

- Fix commas to not appear at the beginning of a record.

Change-Id: I19e5c908367490a64104d961146bad2d870d0c58
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/insert_from_ext_ds/insert_from_ext_ds.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
7 files changed, 113 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/92/1692/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp
new file mode 100644
index 000..10c6d29
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.1.ddl.sqlpp
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Test case name: date-insert.aql
+ * Description: verify insertion operation for date type
+ * Expected result: success
+ */
+
+drop  dataverse testdvt if exists;
+create  dataverse testdvt;
+
+use testdvt;
+
+
+create type testdvt.testtype as
+{
+  id : string,
+  dateField : date?,
+  timeField : time?,
+  datetimeField : datetime?,
+  durationField : duration?,
+  intervalField : interval?,
+  yearMonthDurationField : `year_month_duration`?,
+  dayTimeDurationField : `day_time_duration`?
+}
+
+create external  dataset testds(testtype) using 
localfs((`path`=`asterix_nc1://data/temporal/temporalData.json`),(`format`=`adm`));
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp
new file mode 100644
index 000..bd244d0
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.2.update.sqlpp
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/print-ASTERIXDB-1885/print-ASTERIXDB-1885.3.query.sqlpp
new file mode 100644

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#11).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.2.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.3.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.4.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.5.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.2.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.3.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.3.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.4.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.5.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
19 files changed, 423 insertions(+), 16 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#10).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.2.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.3.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.4.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.5.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.2.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.3.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.3.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.4.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.5.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
18 files changed, 416 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#9).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.2.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.3.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.async.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.4.pollget.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.5.get.http
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.2.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.3.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.3.ignore
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.4.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_2.5.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
19 files changed, 479 insertions(+), 33 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#8).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_1.3.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
11 files changed, 372 insertions(+), 27 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#7).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_1.3.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
11 files changed, 368 insertions(+), 27 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#6).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_1.3.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterixdb/asterix-experiments/pom.xml
13 files changed, 373 insertions(+), 32 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1178

to look at the new patch set (#5).

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultLocationsAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_2/result_location_2.3.rlocation.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_1/result_location_1.1.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/result_location_2/result_location_1.3.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
D asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-experiments/pom.xml
14 files changed, 373 insertions(+), 138 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 5:

isClosed doesn't mean it's optional or not optional. it means the field is 
defined despite the type. Optional fields has to be checked as a union type of 
(null, missing, actual-type). 

To produce the exception, use the following DDL (put breakpoint on the 
exception line: 221):

drop dataverse feeds if exists
create dataverse feeds;
use dataverse feeds;

create type Geo as closed {
coordinates: [double],
'type':string
}

create type Tweet as closed {
id: int64,
text:string,
geo:Geo?  
}
create dataset Tweets (Tweet)
primary key id

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 4:

For some reason, I cannot inline my comment. 
I will follow this format:
{line# : code
comment}

220 : if (curRecType.isClosedField(curFNames[iter1])) 
should that check if it's optional instead of closed. Because a field can be 
optional and that allows null.

Probably we can get rid of the first part (213 - 230). And make:
recType = curRecType == null ? ARecordType.FULLY_OPEN_RECORD_TYPE : curRecType;

236 : if (obj.isNull(attrName) || obj.length() == 0) 
is obj.length() ever going to equal zero? obj is the parent of attrName.

258: if (writeRecord == true) 
no need for == true

Great work.. Thanks!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has posted comments on this change.

Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
..


Patch Set 2:

Hi Xikui,

I tried to see the output of the new parser.
I noticed something different:
{ "id": 795240956979126272, "user": { "screen_name": "77mono7", "lang": "ja", 
"friends_count": 65, "statuses_count": 712 }, "in_reply_to_status_id_str": 
"795234196201426946", "in_reply_to_status_id": 795234196201426946, 
"created_at": "Sun Nov 06 12:26:33 + 2016", "in_reply_to_user_id_str": 
"762203399202799616", "source": "Twitter for iPhone", "retweet_count": 0, 
"retweeted": false, "filter_level": "low", "in_reply_to_screen_name": 
"77mono7", "is_quote_status": false, "id_str": "795240956979126272", 
"in_reply_to_user_id": 762203399202799616, "favorite_count": 0, "text": 
"仲良くしてね", "lang": "ja", "favorited": false, "truncated": false, "timestamp_ms": 
"1478435193663", "entities": {  } }

You can see 'entities' as an empty record. I'm not sure how is that mapped in 
AsterixDB ? it's not null or missing.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No