Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-18 Thread via GitHub
pgj commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-176756 Great work! I think it would be worth to cover the `text` indexes with tests in this PR otherwise it can easily go forgotten. -- This is an automated message from the Apache Git Service.

Re: [PR] Prevent delayed opener error from crashing index servers [couchdb]

2023-10-17 Thread via GitHub
jaydoane commented on code in PR #4811: URL: https://github.com/apache/couchdb/pull/4811#discussion_r1362871438 ## src/couch_index/src/couch_index_server.erl: ## @@ -167,19 +167,29 @@ handle_call({get_index, {_Mod, _IdxState, DbName, Sig} = Args}, From, State) -> [{_,

Re: [PR] Prevent delayed opener error from crashing index servers [couchdb]

2023-10-17 Thread via GitHub
nickva commented on code in PR #4811: URL: https://github.com/apache/couchdb/pull/4811#discussion_r1362879000 ## src/couch_index/src/couch_index_server.erl: ## @@ -167,19 +167,29 @@ handle_call({get_index, {_Mod, _IdxState, DbName, Sig} = Args}, From, State) -> [{_,

[PR] PoC Couch Stats Resource Tracker for tracking process local resource usage [couchdb]

2023-10-17 Thread via GitHub
chewbranca opened a new pull request, #4812: URL: https://github.com/apache/couchdb/pull/4812 # Couch Stats Resource Tracker Overview We currently lack visibility into the types of operations that are inducing system resource usage in CouchDB. We can see in the IOQ stats the raw

Re: [PR] Prevent delayed opener error from crashing index servers [couchdb]

2023-10-17 Thread via GitHub
jaydoane commented on code in PR #4811: URL: https://github.com/apache/couchdb/pull/4811#discussion_r1362887741 ## src/couch_index/src/couch_index_server.erl: ## @@ -167,19 +167,29 @@ handle_call({get_index, {_Mod, _IdxState, DbName, Sig} = Args}, From, State) -> [{_,

Re: [I] get_index call crashes couch_index_server instance [couchdb]

2023-10-17 Thread via GitHub
nickva closed issue #4809: get_index call crashes couch_index_server instance URL: https://github.com/apache/couchdb/issues/4809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Prevent delayed opener error from crashing index servers [couchdb]

2023-10-17 Thread via GitHub
nickva merged PR #4811: URL: https://github.com/apache/couchdb/pull/4811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-18 Thread via GitHub
nickva commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1364096728 ## src/mango/src/mango_selector.erl: ## @@ -1054,4 +1061,29 @@ fields_nor_test() -> }, ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-18 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1363693652 ## src/mango/src/mango_selector.erl: ## @@ -1054,4 +1061,29 @@ fields_nor_test() -> }, ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).

[PR] Bump @babel/traverse from 7.20.1 to 7.23.2 [couchdb-nano]

2023-10-18 Thread via GitHub
dependabot[bot] opened a new pull request, #334: URL: https://github.com/apache/couchdb-nano/pull/334 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.2. Release notes Sourced from

[PR] Bump @babel/traverse from 7.22.5 to 7.23.2 [couchdb-fauxton]

2023-10-19 Thread via GitHub
dependabot[bot] opened a new pull request, #1416: URL: https://github.com/apache/couchdb-fauxton/pull/1416 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. Release notes Sourced from

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-18 Thread via GitHub
nickva commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1364096728 ## src/mango/src/mango_selector.erl: ## @@ -1054,4 +1061,29 @@ fields_nor_test() -> }, ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-19 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1365581220 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-19 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1365554970 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
rnewson commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1755847211 Is it fixed by 882e7161acb692d3e721c7653d8cdc2e5e65d2ef? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
nickva commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1755852807 Good find @rnewson That patch hasn't been released yet I think. @catgirlinspace would you be able to build Apache CouchDB `main` from source? If you can, then you can

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
rnewson commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1755867763 also its implied the nodes are ipv6-only so if this is a cluster I don't think they can connect without a separate change in `vm.args` to switch the distribution protocol module to

Re: [I] macOS (ARM64) CouchDB 3.3.2 and CouchDB 3.2.3 zip files are cmp -l identical [couchdb]

2023-10-09 Thread via GitHub
big-r81 commented on issue #4797: URL: https://github.com/apache/couchdb/issues/4797#issuecomment-1752392185 > The couchdb.logs indicated that it had a dependency that had a dependency, that... depended on Homebrew being installed. After installing Homebrew (twice) the install *.pkg seemed

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
catgirlinspace commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756488038 Ah, that makes a lot more sense, thank you!! Would be good to maybe put that somewhere in the docs possibly. I didn't see an explanation like this anywhere when I was

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
catgirlinspace commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756686422 Ah, I'll try that, thanks! Might also make a PR to the docs on replication to add this stuff (unless you want to?). Feels like this is information that should be there but I

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
catgirlinspace commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1755747390 @nickva Not sure if that's the bug actually, as I'm getting this same error when using internal domains from fly.io that have records. I'm able to `curl` the same thing

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
nickva commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756164815 Clustering is a way to connect multiple Apache CouchDB nodes using Erlang's native clustering mechanism over TCP connections. At the HTTP API level it looks like a single Apache

Re: [I] macOS (ARM64) CouchDB 3.3.2 and CouchDB 3.2.3 zip files are cmp -l identical [couchdb]

2023-10-10 Thread via GitHub
wjblume commented on issue #4797: URL: https://github.com/apache/couchdb/issues/4797#issuecomment-1756182484 The macOS ARM 3.3.2 files from here: Following this, path both the the 3.3.2 and 3.2.3 macOS ARM's are still identical, actually 3.3.2 https://couchdb.apache.org/#download

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
catgirlinspace commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756136122 not at home to try that atm, but I'll try using a build of main tonight! Unrelated but feels like an ok opportunity to ask since it was mentioned--is there much of a

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
catgirlinspace commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756491509 @nickva good news-- building CouchDB from `main` and using the config option you provided fixed it!! -- This is an automated message from the Apache Git Service. To respond

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
nickva commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756661265 > good news-- building CouchDB from main and using the config option you provided fixed it!! That's great to hear. Credit also goes to @rnewson for both fixing the ipv6

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-10 Thread via GitHub
nickva commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1756696635 > Might also make a PR to the docs on replication to add this stuff That would be great, please do. Contributions are always welcome! -- This is an automated message

[PR] Remove suggestion to install curl/libcurl [couchdb]

2023-10-10 Thread via GitHub
nickva opened a new pull request, #4804: URL: https://github.com/apache/couchdb/pull/4804 We don't need curl since we don't have Javascript tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Remove suggestion to install curl/libcurl [couchdb]

2023-10-10 Thread via GitHub
nickva commented on PR #4804: URL: https://github.com/apache/couchdb/pull/4804#issuecomment-1756624159 Also remove Sphinx from the list since it's automatically installed by the pip requirements.txt file in docs app. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Remove suggestion to install curl/libcurl [couchdb]

2023-10-10 Thread via GitHub
nickva merged PR #4804: URL: https://github.com/apache/couchdb/pull/4804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

2023-10-20 Thread via GitHub
Sdas opened a new issue, #4815: URL: https://github.com/apache/couchdb/issues/4815 ## Description compaction_log_level to capture compaction information not working on Couchdb version 3.3.2. ## Steps to Reproduce [log] writer = journald level = error

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

2023-10-20 Thread via GitHub
Sdas commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1773280319 It is in default.ini https://github.com/apache/couchdb/blob/main/rel/overlay/etc/default.ini Line number 96 ; Sets the log level for informational compaction

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
rnewson commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773068107 I'd considered https://github.com/esl/fast_pbkdf2/ before I noticed they'd made it part of crypto.erl. It just hadn't occurred to me that it would be worse. I will switch to fast_pbkdf2

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
big-r81 commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773263772 Some additional infos about the iteration count: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2 -- This is an automated message from the Apache

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
nickva commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773108294 > I'd considered https://github.com/esl/fast_pbkdf2/ before I noticed they'd made it part of crypto.erl. It just hadn't occurred to me that it would be worse. I will switch to fast_pbkdf2

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
nickva commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773223659 Upstream OTP issue: https://github.com/erlang/otp/issues/7769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
rnewson commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773072702 I deliberately separated into multiple commits but I feel adding pbkdf2-sha256 with high iterations without the cache would lead to problems for folks. the password cache could be

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

2023-10-20 Thread via GitHub
big-r81 commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1773247146 Hi, looking at https://docs.couchdb.org/en/stable/config-ref.html#cap-log there is no `compaction_log_level` key. Try to set `level` properly. -- This is an automated

Re: [I] compaction_log_level not working on Couchdb version 3.3.2 [couchdb]

2023-10-20 Thread via GitHub
nickva commented on issue #4815: URL: https://github.com/apache/couchdb/issues/4815#issuecomment-1773335087 The `default.ini` has two(!) places where we configure the compaction log level. One is in the `[couchdb]` section, and the other is in the `[smoosh]` section. The one in `[couchdb]`

Re: [PR] Decouple offline hash strength from online [couchdb]

2023-10-20 Thread via GitHub
nickva commented on PR #4814: URL: https://github.com/apache/couchdb/pull/4814#issuecomment-1773480674 > I deliberately separated into multiple commits but I feel adding pbkdf2-sha256 with high iterations without the cache would lead to problems for folks. > The cache would be

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367714649 ## src/mango/src/mango_selector.erl: ## @@ -1054,4 +1061,29 @@ fields_nor_test() -> }, ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367716828 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,128 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367715142 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367716043 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1773768295 I miss the parts related to the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367718710 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-21 Thread via GitHub
pgj commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1773770413 Please add `text` tests for the integration test suite. I am fine if they do not fully work (like a draft) I can test them and provide feedback. For your information, I am currently

[I] path to certificates [couchdb-pkg]

2023-10-22 Thread via GitHub
alfille opened a new issue, #113: URL: https://github.com/apache/couchdb-pkg/issues/113 I'm using Debian 12 and snap couchdb What path do I use for "cert_file" in [ssl] ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] upgrade dropwizard to 4.0.3 [couchdb]

2023-10-22 Thread via GitHub
rnewson opened a new pull request, #4817: URL: https://github.com/apache/couchdb/pull/4817 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] path to certificates [couchdb-pkg]

2023-10-22 Thread via GitHub
sklassen commented on issue #113: URL: https://github.com/apache/couchdb-pkg/issues/113#issuecomment-1774314515 Any user-defined (editable) files need to be stored within `/var/snap/couchdb/current/`. If you need to debug further, there should be a couchdb.remsh script. You can use

Re: [PR] upgrade dropwizard to 4.0.3 [couchdb]

2023-10-23 Thread via GitHub
rnewson merged PR #4817: URL: https://github.com/apache/couchdb/pull/4817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Couch db throwing error "Error: normal. Reason: {gen_server,call,[<0.24064.2493>, {pread_iolist,327789}" [couchdb]

2023-10-23 Thread via GitHub
big-r81 commented on issue #4819: URL: https://github.com/apache/couchdb/issues/4819#issuecomment-1775419779 Hi, can you append your log file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Couch db error while accessing views [couchdb]

2023-10-23 Thread via GitHub
big-r81 closed issue #4818: Couch db error while accessing views URL: https://github.com/apache/couchdb/issues/4818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Couch db error while accessing views [couchdb]

2023-10-23 Thread via GitHub
big-r81 commented on issue #4818: URL: https://github.com/apache/couchdb/issues/4818#issuecomment-1775287246 Duplicate of #4724. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] cluster couchdb unstable (fabric_worker_timeout) [couchdb]

2023-10-23 Thread via GitHub
nickva commented on issue #4790: URL: https://github.com/apache/couchdb/issues/4790#issuecomment-1775466495 @alessio-congedo > How can you explain the fact that it's always the same node that crashes? Not sure I can explain that from the logs. It seems like other nodes also

[I] Couch db error while accessing views [couchdb]

2023-10-23 Thread via GitHub
rummitta opened a new issue, #4818: URL: https://github.com/apache/couchdb/issues/4818 ### Discussed in https://github.com/apache/couchdb/discussions/4724 Originally posted by **ajitpsingh** August 9, 2023 I am getting the below error while accessing the couchdb views.

[I] Couch db throwing error "Error: normal. Reason: {gen_server,call,[<0.24064.2493>, {pread_iolist,327789}" [couchdb]

2023-10-23 Thread via GitHub
rummitta opened a new issue, #4819: URL: https://github.com/apache/couchdb/issues/4819 Hi Team, We are using Couch db v 3.2.2. While trying to access a db view through automation, we are getting the below error Error: normal. Reason: {gen_server,call,[<0.24064.2493>,

[PR] Wait for compacted indexes to flip. [couchdb]

2023-10-23 Thread via GitHub
nickva opened a new pull request, #4821: URL: https://github.com/apache/couchdb/pull/4821 Noticed on a few production instances, we run a potentially long compaction, and when done, the call to commit the compacted state times out after 5 seconds. That, in turn, triggers are a

[PR] docs: Add Ubuntu 22.04 Jammy Jellyfish as supported OS [couchdb]

2023-10-16 Thread via GitHub
sblaisot opened a new pull request, #4805: URL: https://github.com/apache/couchdb/pull/4805 ## Overview Add Ubuntu 22.04 Jammy Jellyfish as supported OS in documentation. Deb packages for couchdb are available for that distribution. -- This is an automated message from the

Re: [I] Pipe (|) character in find query isn't returning data [couchdb]

2023-10-06 Thread via GitHub
gruberjl commented on issue #4802: URL: https://github.com/apache/couchdb/issues/4802#issuecomment-1750686995 I was using all docs but I had to switch because I need to filter on another field too. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Configure hex, gradle, pip and npm caches. [couchdb]

2023-10-06 Thread via GitHub
big-r81 commented on PR #4799: URL: https://github.com/apache/couchdb/pull/4799#issuecomment-1750533629 restarted the CI and it runs through ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] store update seq of docs [couchdb]

2023-10-04 Thread via GitHub
rnewson opened a new pull request, #4796: URL: https://github.com/apache/couchdb/pull/4796 https://github.com/apache/couchdb/pull/4782#issuecomment-1747071353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat(`mango`): add `allow_fallback` for user-specified indexes on `_find` [couchdb]

2023-10-04 Thread via GitHub
nickva commented on code in PR #4792: URL: https://github.com/apache/couchdb/pull/4792#discussion_r1346517007 ## src/mango/src/mango_cursor.erl: ## @@ -53,8 +53,24 @@ create(Db, Selector0, Opts, Kind) -> {UsableIndexes, Trace} = mango_idx:get_usable_indexes(Db, Selector,

Re: [PR] feat(`mango`): add `allow_fallback` for user-specified indexes on `_find` [couchdb]

2023-10-04 Thread via GitHub
nickva commented on code in PR #4792: URL: https://github.com/apache/couchdb/pull/4792#discussion_r1346517007 ## src/mango/src/mango_cursor.erl: ## @@ -53,8 +53,24 @@ create(Db, Selector0, Opts, Kind) -> {UsableIndexes, Trace} = mango_idx:get_usable_indexes(Db, Selector,

[PR] Fix flaky fabric_bench test [couchdb]

2023-10-04 Thread via GitHub
nickva opened a new pull request, #4795: URL: https://github.com/apache/couchdb/pull/4795 Rapidly creating and deleting a db in the this test triggers a race condition. A potential culprit might be the gen_server cast in

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-24 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1370074894 ## src/mango/test/25-beginswith-test.py: ## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-24 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1370081478 ## src/mango/src/mango_selector.erl: ## @@ -1054,4 +1061,29 @@ fields_nor_test() -> }, ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-24 Thread via GitHub
willholley commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1777115697 > Please add `text` tests for the integration test suite. I am fine if they do not fully work (like a draft) I can test them and provide feedback. For your information, I am currently

Re: [PR] Update proper [couchdb]

2023-10-23 Thread via GitHub
nickva merged PR #4823: URL: https://github.com/apache/couchdb/pull/4823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update MochiWeb to v3.2.1 [couchdb]

2023-10-23 Thread via GitHub
big-r81 merged PR #4822: URL: https://github.com/apache/couchdb/pull/4822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Replication - url_parsing_failed/nx_domain on IPv6 [couchdb]

2023-10-23 Thread via GitHub
ajithcnambiar commented on issue #3887: URL: https://github.com/apache/couchdb/issues/3887#issuecomment-1776133932 I also faced the same issue while migrating to the IPv6 cluster. When can we expect a release with this fix? Thanks, everyone -- This is an automated

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-24 Thread via GitHub
willholley commented on PR #4810: URL: https://github.com/apache/couchdb/pull/4810#issuecomment-1777336779 > Please add `text` tests for the integration test suite. I am fine if they do not fully work (like a draft) I can test them and provide feedback. For your information, I am currently

Re: [PR] mango: add $beginsWith operator [couchdb]

2023-10-24 Thread via GitHub
willholley commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1370565547 ## src/mango/src/mango_selector_text.erl: ## @@ -142,6 +142,10 @@ convert(Path, {[{<<"$exists">>, ShouldExist}]}) -> true -> FieldExists; false ->

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1685950963 @nickva  interesting! What we've observed (a huge rise in interactive ioq requests after a series of `_find` requests that haproxy classified as `sH--`, and the new `mango_stats`

[GitHub] [couchdb] rnewson commented on a diff in pull request #4445: Introduce ad-hoc Erlang cookie configuration for the `dev` scripts

2023-08-21 Thread via GitHub
rnewson commented on code in PR #4445: URL: https://github.com/apache/couchdb/pull/4445#discussion_r1299939816 ## rel/overlay/etc/vm.args: ## @@ -38,8 +38,7 @@ {{node_name}} # All nodes must share the same magic cookie for distributed Erlang to work. -# Uncomment the

[GitHub] [couchdb] pgj commented on a diff in pull request #4445: Introduce ad-hoc Erlang cookie configuration for the `dev` scripts

2023-08-21 Thread via GitHub
pgj commented on code in PR #4445: URL: https://github.com/apache/couchdb/pull/4445#discussion_r1299872841 ## rel/overlay/etc/vm.args: ## @@ -38,8 +38,7 @@ {{node_name}} # All nodes must share the same magic cookie for distributed Erlang to work. -# Uncomment the following

[GitHub] [couchdb] rnewson commented on a diff in pull request #4445: Introduce ad-hoc Erlang cookie configuration for the `dev` scripts

2023-08-21 Thread via GitHub
rnewson commented on code in PR #4445: URL: https://github.com/apache/couchdb/pull/4445#discussion_r1299939816 ## rel/overlay/etc/vm.args: ## @@ -38,8 +38,7 @@ {{node_name}} # All nodes must share the same magic cookie for distributed Erlang to work. -# Uncomment the

[GitHub] [couchdb] nickva commented on pull request #4726: Unlock build using Elixir 1.15

2023-08-17 Thread via GitHub
nickva commented on PR #4726: URL: https://github.com/apache/couchdb/pull/4726#issuecomment-1682446731 Thanks for fixing it @jjrodrig! I did notice in the last main full CI build for .deb packages failed to build with this error:

[GitHub] [couchdb] fr2lancer opened a new issue, #4733: file copy of .couch from 2.x isn't picked up by couchdb 3.3.2

2023-08-17 Thread via GitHub
fr2lancer opened a new issue, #4733: URL: https://github.com/apache/couchdb/issues/4733 [NOTE]: # file copy of .couch from 2.x isn't picked up by couchdb 3.3.2 ## Description Simple I copied one of .couch file to couchdb 3.3.2 GET '127.0.0.1:5984/ -> no database error

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686324050 I've built a large local database, 6 million docs, no artificial sleeps, and with dbg:tracer calls in fabric_rpc:all_docs. I have haproxy with a 10s server timeout. I've observed;

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686478247 In principle at least the experimental `socket` module does allow `peek`-ing with `recv` since OTP 24.0: https://www.erlang.org/doc/man/socket#type-msg_flag > ``` msg_flag()

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686341739 took me too long to realise, but I think the difference is the attempt to send data (between _changes and _find). that's the only time we notice the socket closed, and thus the processes

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686649525 I'm not entirely giving up on tcp keepalive (it ought to kill the process/port for the socket, which I think will kill the mochiweb process, but subject to testing) However, I'm

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686663150 > it ought to kill the process/port for the socket, which I think will kill the mochiweb process, but subject to testing It doesn't hurt to try I don't see how that could plausibly

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686579062 I've tried tweaking mochiweb to enable `{keepalive, true}` after it accepts a connection, so it can know if the client disconnects. But it seems not to have any effect, which is odd.

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1686633468 On localhost `keepalive` won't behave any differently for disconnects, as network handling is just a direct callback into the other peer's socket code at the kernel level. In other words

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-21 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1687030494 changed approach, though I don't think this is the final answer either. this diff adds a deadline by which a delayed response must start or be terminated. This helps when using

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric stream coordinators should exit if idle for a long period

2023-08-23 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-168926 > updated again. I've expanded fabric_streams existing 'cleanup' process to be a watchdog (in the classic sense). > > before starting a fabric_stream you must call

[GitHub] [couchdb] jjrodrig commented on issue #4706: Elixir-based tests fail to run with Elixir 1.15

2023-08-23 Thread via GitHub
jjrodrig commented on issue #4706: URL: https://github.com/apache/couchdb/issues/4706#issuecomment-1689656235 Hi @nickva It seems that the packaging process depends on the elixir environment but it is not prepared as we cleaned it completely. Some step is missing to recover it but

[GitHub] [couchdb] nickva commented on a diff in pull request #4729: Fabric stream coordinators should exit if idle for a long period

2023-08-22 Thread via GitHub
nickva commented on code in PR #4729: URL: https://github.com/apache/couchdb/pull/4729#discussion_r1302491408 ## src/fabric/src/fabric_streams.erl: ## @@ -152,45 +168,101 @@ handle_stream_start({ok, Error}, _, St) when Error == ddoc_updated; Error == ins

[GitHub] [couchdb-nano] crystalfp opened a new issue, #332: Error under electron: Adapter 'http' is not available in the build

2023-08-23 Thread via GitHub
crystalfp opened a new issue, #332: URL: https://github.com/apache/couchdb-nano/issues/332 ## Expected Behavior Used nano without errors under Node 20.4.0. I want to use the exactly same code under Electron that bundles Node 18.16.1 ## Current Behavior At the first call

[GitHub] [couchdb-nano] glynnbird commented on issue #332: Error under electron: Adapter 'http' is not available in the build

2023-08-23 Thread via GitHub
glynnbird commented on issue #332: URL: https://github.com/apache/couchdb-nano/issues/332#issuecomment-1689486613 Yes there's a branch that replaces axios with fetch, but haven't got round to merging it yet. It would be great if you could test it i.e replace your nano dependency with

[GitHub] [couchdb-nano] crystalfp commented on issue #332: Error under electron: Adapter 'http' is not available in the build

2023-08-23 Thread via GitHub
crystalfp commented on issue #332: URL: https://github.com/apache/couchdb-nano/issues/332#issuecomment-1689516738 With pleasure, @glynnbird ! Simply overwrote the package directory with the fetch branch content (Bad bad!). Besides installing `undici` and removing `requestDefaults` at

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric stream coordinators should exit if idle for a long period

2023-08-23 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1689544073 I would also prefer to detect the client disconnect directly but I am less keen to see the raw packet inspection stuff in couchdb in general, unless we can be confident that it causes no

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric stream coordinators should exit if idle for a long period

2023-08-23 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1689765902 I think that's the opposite direction, the coordinator making sure the workers are still alive and exiting if not. The problem we're trying to address is when the coordinator and

[GitHub] [couchdb] pgj commented on a diff in pull request #4445: Introduce ad-hoc Erlang cookie configuration for the `dev` scripts

2023-08-23 Thread via GitHub
pgj commented on code in PR #4445: URL: https://github.com/apache/couchdb/pull/4445#discussion_r1302765919 ## dev/remsh: ## @@ -23,6 +23,12 @@ if [ -z $HOST ]; then HOST="127.0.0.1" fi +if [ -n "$COOKIE" ]; then +_cookie_flag="-setcookie $COOKIE" +else +

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric stream coordinators should exit if idle for a long period

2023-08-22 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1689241307 A bit more of a cleaned up connection script version which should work on macos, linux and freebsd: ```erlang #!/usr/bin/env escript is_closed(Sock) -> OsType =

[GitHub] [couchdb] seifbm opened a new issue, #4734: CouchDB does not sync when connected to DSL line

2023-08-22 Thread via GitHub
seifbm opened a new issue, #4734: URL: https://github.com/apache/couchdb/issues/4734 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description On a Normal DSL couch DB does not sync data unless i restart apach couch db service or restart

[GitHub] [couchdb] rnewson commented on pull request #4710: feat(`mango`): strict index selection

2023-08-22 Thread via GitHub
rnewson commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1687827392 one further note here. when, in the future, you pass a selector to `_view` or _`search` we should send a `400 Bad Request` if mango would do a startkey/endkey that covers the entire

[GitHub] [couchdb] pgj commented on pull request #4710: feat(`mango`): strict index selection

2023-08-22 Thread via GitHub
pgj commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1687830558 Okay, thanks for the note @rnewson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

<    2   3   4   5   6   7   8   9   10   11   >