[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880857614 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880853138 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

pivotal-jbarrett commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880843445 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFir

[GitHub] [geode] Bill commented on a diff in pull request #7262: GEODE-6588: Cleanup static analyzer warnings.

Bill commented on code in PR #7262: URL: https://github.com/apache/geode/pull/7262#discussion_r880830479 ## geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java: ## @@ -98,11 +96,13 @@ public ClientMetadataService(Cache cache) { private f

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r880817043 ## geode-junit/src/main/java/org/apache/geode/test/version/TestVersion.java: ## @@ -17,18 +17,24 @@ import java.io.Serializable; import java.util.Objects; +@SuppressW

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r880816466 ## geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java: ## @@ -333,13 +333,15 @@ private ServerLauncher(final Builder builder) { controlHandler

[GitHub] [geode] albertogpz commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor

albertogpz commented on code in PR #7715: URL: https://github.com/apache/geode/pull/7715#discussion_r880727847 ## geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java: ## @@ -66,7 +67,9 @@ public class MemoryAllocatorImpl implements MemoryAllocator

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

pivotal-jbarrett commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880764715 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFir

[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880757642 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880752000 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880752000 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] Bill commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

Bill commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r880752000 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java: ## @@ -229,387 +235,209 @@ public class MessageType { * * @since GemFire 4.1.1

[GitHub] [geode] albertogpz commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor

albertogpz commented on code in PR #7715: URL: https://github.com/apache/geode/pull/7715#discussion_r880727847 ## geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java: ## @@ -66,7 +67,9 @@ public class MemoryAllocatorImpl implements MemoryAllocator

[GitHub] [geode-benchmarks] pivotal-jbarrett merged pull request #168: GEODE-10296: Prevent JVM exit on parser error.

pivotal-jbarrett merged PR #168: URL: https://github.com/apache/geode-benchmarks/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r880025107 ## geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java: ## @@ -333,13 +333,15 @@ private ServerLauncher(final Builder builder) { controlHandler

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r880024482 ## geode-junit/src/main/java/org/apache/geode/test/version/TestVersion.java: ## @@ -17,18 +17,24 @@ import java.io.Serializable; import java.util.Objects; +@SuppressW

[GitHub] [geode] Bill commented on a diff in pull request #7697: GEODE-10304: locator thread should not exit after reconnecting

Bill commented on code in PR #7697: URL: https://github.com/apache/geode/pull/7697#discussion_r879980214 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -1043,7 +1046,15 @@ public void waitToStop() throws InterruptedException {

[GitHub] [geode] Bill commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

Bill commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r879960279 ## geode-junit/src/main/java/org/apache/geode/test/version/TestVersion.java: ## @@ -17,18 +17,24 @@ import java.io.Serializable; import java.util.Objects; +@SuppressWarni

[GitHub] [geode] Bill commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

Bill commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r879954008 ## geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java: ## @@ -333,13 +333,15 @@ private ServerLauncher(final Builder builder) { controlHandler = n

[GitHub] [geode] kirklund commented on pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on PR #7571: URL: https://github.com/apache/geode/pull/7571#issuecomment-1135246054 ClusterCommunicationsDUnitTest failed one run of upgrade-test-openjdk11. I've searched Jira and now [I'm running that test through stress-new-test in another PR](https://github.com/apache/

[GitHub] [geode] kirklund opened a new pull request, #7719: [DO NOT REVIEW] Run ClusterCommunicationsDUnitTest in stress-new-test

kirklund opened a new pull request, #7719: URL: https://github.com/apache/geode/pull/7719 Add comment to make ClusterCommunicationsDUnitTest run in stress-new-test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [geode] onichols-pivotal merged pull request #7718: GEODE-10275: Bump spring from 5.3.19 to 5.3.20

onichols-pivotal merged PR #7718: URL: https://github.com/apache/geode/pull/7718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] onichols-pivotal opened a new pull request, #7718: GEODE-10275: Bump spring from 5.3.19 to 5.3.20

onichols-pivotal opened a new pull request, #7718: URL: https://github.com/apache/geode/pull/7718 Geode endeavors to update to the latest version of 3rd-party dependencies on develop wherever possible. Doing so increases the shelf life of releases and increases security and reliability

[GitHub] [geode] dschneider-pivotal opened a new pull request, #7717: on close/disconnect clear statics that keep large objects alive

dschneider-pivotal opened a new pull request, #7717: URL: https://github.com/apache/geode/pull/7717 TXManagerImpl.close now removes itself from the currentInstance static ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in

[GitHub] [geode] dschneider-pivotal merged pull request #7716: GEODE-10328: close data store stats on cache close

dschneider-pivotal merged PR #7716: URL: https://github.com/apache/geode/pull/7716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [geode] yozaner1324 closed pull request #7701: GEODE-10316: Convert rest API to Spring from Spring Boot

yozaner1324 closed pull request #7701: GEODE-10316: Convert rest API to Spring from Spring Boot URL: https://github.com/apache/geode/pull/7701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [geode] kirklund commented on pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on PR #7571: URL: https://github.com/apache/geode/pull/7571#issuecomment-1135072913 The latest precheckin run hit a flaky failure [GEODE-10090](https://issues.apache.org/jira/browse/GEODE-10090). The previous precheckin was GREEN. -- This is an automated message

[GitHub] [geode] pivotal-jbarrett commented on pull request #7688: GEODE-10326: Convert MessageType to enum.

pivotal-jbarrett commented on PR #7688: URL: https://github.com/apache/geode/pull/7688#issuecomment-1135041227 > You may have already checked into this - it looks like the old getString method did not return the exact same name as the constant in some cases. It looks like it was only used i

[GitHub] [geode] mivanac commented on pull request #7515: GEODE-10020: For Ping task avoid registering new destination endpoint

mivanac commented on PR #7515: URL: https://github.com/apache/geode/pull/7515#issuecomment-1135011787 Hi @kirklund, are changes OK with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mivanac commented on pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage

mivanac commented on PR #7323: URL: https://github.com/apache/geode/pull/7323#issuecomment-1135010351 Hi @kirklund , are changes OK with you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [geode] kirklund commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor

kirklund commented on code in PR #7715: URL: https://github.com/apache/geode/pull/7715#discussion_r879742177 ## geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java: ## @@ -66,7 +67,9 @@ public class MemoryAllocatorImpl implements MemoryAllocator {

[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7716: GEODE-10328: close data store stats on cache close

dschneider-pivotal commented on code in PR #7716: URL: https://github.com/apache/geode/pull/7716#discussion_r879714796 ## geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java: ## @@ -7767,6 +7768,16 @@ protected void postDestroyRegion(boolean destroyD

[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7716: GEODE-10328: close data store stats on cache close

dschneider-pivotal commented on code in PR #7716: URL: https://github.com/apache/geode/pull/7716#discussion_r879712799 ## geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java: ## @@ -7767,6 +7768,16 @@ protected void postDestroyRegion(boolean destroyD

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r879692658 ## geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java: ## @@ -333,13 +333,15 @@ private ServerLauncher(final Builder builder) { controlHandler

[GitHub] [geode] jinmeiliao merged pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

jinmeiliao merged PR #7703: URL: https://github.com/apache/geode/pull/7703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

demery-pivotal commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r879668886 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/ssl/CertificateRotationTest.java: ## @@ -339,16 +348,16 @@ private void startCluster() throws IOException

[GitHub] [geode] DonalEvans merged pull request #7680: GEODE-10297: Create SSLContext using default protocols

DonalEvans merged PR #7680: URL: https://github.com/apache/geode/pull/7680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] DonalEvans commented on a diff in pull request #7716: GEODE-10328: close data store stats on cache close

DonalEvans commented on code in PR #7716: URL: https://github.com/apache/geode/pull/7716#discussion_r879565795 ## geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java: ## @@ -7767,6 +7768,16 @@ protected void postDestroyRegion(boolean destroyDiskRegio

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878611092 ## geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java: ## @@ -333,13 +333,15 @@ private ServerLauncher(final Builder builder) { controlHandler

[GitHub] [geode] kirklund commented on pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on PR #7571: URL: https://github.com/apache/geode/pull/7571#issuecomment-1133486114 UPDATE: all checks have completed GREEN. Only LGTM Java is still in progress (it seems to be problematic lately) -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [geode] Bill commented on a diff in pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

Bill commented on code in PR #7703: URL: https://github.com/apache/geode/pull/7703#discussion_r878606034 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -707,71 +711,102 @@ private void startDistributedSystem() throws IOException {

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

demery-pivotal commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878598788 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/ssl/CertificateRotationTest.java: ## @@ -339,16 +348,16 @@ private void startCluster() throws IOException

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878598310 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/ssl/CertificateRotationTest.java: ## @@ -339,16 +348,16 @@ private void startCluster() throws IOException, Gen

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878596145 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/metrics/RegionEntriesGaugeTest.java: ## @@ -156,7 +158,8 @@ public void regionEntriesGaugeShowsCountOfLocalReg

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878595675 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/metrics/GatewayReceiverMetricsTest.java: ## @@ -178,7 +178,8 @@ public void stopClusters() { String stopRe

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878594588 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/rest/StandaloneClientManagementAPIAcceptanceTest.java: ## @@ -69,72 +65,94 @@ public static

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878594421 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/rest/StandaloneClientManagementAPIAcceptanceTest.java: ## @@ -69,72 +65,94 @@ public static

[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

kirklund commented on code in PR #7571: URL: https://github.com/apache/geode/pull/7571#discussion_r878590276 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/ServerStartupOnlineTest.java: ## @@ -116,13 +114,14 @@ public void startServerReturnsAfterStartupTask

[GitHub] [geode] dschneider-pivotal opened a new pull request, #7716: GEODE-10328: close data store stats on cache close

dschneider-pivotal opened a new pull request, #7716: URL: https://github.com/apache/geode/pull/7716 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest c

[GitHub] [geode] mhansonp closed pull request #6976: GEODE-9617: PartitionedRegionSingleHopDUnitTest fails with ConditionTimeoutException waiting for server to bucket map size

mhansonp closed pull request #6976: GEODE-9617: PartitionedRegionSingleHopDUnitTest fails with ConditionTimeoutException waiting for server to bucket map size URL: https://github.com/apache/geode/pull/6976 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [geode] nabarunnag merged pull request #7303: GEODE-9987: Refactored/Removal of deprecated APIs

nabarunnag merged PR #7303: URL: https://github.com/apache/geode/pull/7303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] mhansonp merged pull request #7708: Removing myself from CODEOWNERS

mhansonp merged PR #7708: URL: https://github.com/apache/geode/pull/7708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode

[GitHub] [geode] nabarunnag commented on a diff in pull request #7303: GEODE-9987: Refactored/Removal of deprecated APIs

nabarunnag commented on code in PR #7303: URL: https://github.com/apache/geode/pull/7303#discussion_r878485917 ## geode-core/src/distributedTest/java/org/apache/geode/distributed/HostedLocatorsDUnitTest.java: ## @@ -54,277 +45,163 @@ * @since GemFire 8.0 */ @Category({Clien

[GitHub] [geode] nabarunnag commented on a diff in pull request #7303: GEODE-9987: Refactored/Removal of deprecated APIs

nabarunnag commented on code in PR #7303: URL: https://github.com/apache/geode/pull/7303#discussion_r878485709 ## geode-core/src/distributedTest/java/org/apache/geode/distributed/HostedLocatorsDUnitTest.java: ## @@ -54,277 +45,163 @@ * @since GemFire 8.0 */ @Category({Clien

[GitHub] [geode] nabarunnag commented on pull request #7303: GEODE-9987: Refactored/Removal of deprecated APIs

nabarunnag commented on PR #7303: URL: https://github.com/apache/geode/pull/7303#issuecomment-1133246932 All review comments have been addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7697: GEODE-10304: locator thread should not exit after reconnecting

jinmeiliao commented on code in PR #7697: URL: https://github.com/apache/geode/pull/7697#discussion_r878477658 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -1043,7 +1046,15 @@ public void waitToStop() throws InterruptedException {

[GitHub] [geode] albertogpz opened a new pull request, #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor

albertogpz opened a new pull request, #7715: URL: https://github.com/apache/geode/pull/7715 The scheduled executor used in MemoryAllocatorImpl was scheduled in the constructor. This provoked intermittent failures in OffHeapStorageJUnitTest testCreateOffHeapStorage test cases due to a

[GitHub] [geode] mhansonp commented on a diff in pull request #7708: Removing myself from CODEOWNERS

mhansonp commented on code in PR #7708: URL: https://github.com/apache/geode/pull/7708#discussion_r878368517 ## CODEOWNERS: ## @@ -274,9 +274,9 @@ geode-core/**/org/apache/geode/internal/cache/control/** @kirklund @Don # Testing utilities #---

[GitHub] [geode] mhansonp commented on a diff in pull request #7708: Removing myself from CODEOWNERS

mhansonp commented on code in PR #7708: URL: https://github.com/apache/geode/pull/7708#discussion_r878358644 ## CODEOWNERS: ## @@ -274,9 +274,9 @@ geode-core/**/org/apache/geode/internal/cache/control/** @kirklund @Don # Testing utilities #---

[GitHub] [geode] onichols-pivotal commented on a diff in pull request #7708: Removing myself from CODEOWNERS

onichols-pivotal commented on code in PR #7708: URL: https://github.com/apache/geode/pull/7708#discussion_r877896631 ## CODEOWNERS: ## @@ -274,9 +274,9 @@ geode-core/**/org/apache/geode/internal/cache/control/** @kirklund @Don # Testing utilities #---

[GitHub] [geode] jinmeiliao commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

jinmeiliao commented on PR #7703: URL: https://github.com/apache/geode/pull/7703#issuecomment-1132414898 > The ArchUnit test is failing. I recommend moving the locator string parsing logic from the `geode-membership` subproject to a class in a new package in the `geode-common` subproject ma

[GitHub] [geode] Bill commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

Bill commented on PR #7703: URL: https://github.com/apache/geode/pull/7703#issuecomment-1132307557 The ArchUnit test is failing. I recommend moving the locator string parsing logic from the `geode-membership` subproject to a class in a new package in the `geode-common` subproject maybe:

[GitHub] [geode] jdeppe-pivotal merged pull request #7711: GEODE-10322: Run various Analyze Serializable tests from IntelliJ

jdeppe-pivotal merged PR #7711: URL: https://github.com/apache/geode/pull/7711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [geode] Bill commented on a diff in pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

Bill commented on code in PR #7703: URL: https://github.com/apache/geode/pull/7703#discussion_r877614962 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -707,71 +711,102 @@ private void startDistributedSystem() throws IOException {

[GitHub] [geode] onichols-pivotal merged pull request #7706: GEODE-10320: Bump micrometer from 1.8.5 to 1.9.0

onichols-pivotal merged PR #7706: URL: https://github.com/apache/geode/pull/7706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] demery-pivotal merged pull request #7712: GEODE-10257: Upgrade tests can upgrade Java (#7686)

demery-pivotal merged PR #7712: URL: https://github.com/apache/geode/pull/7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [geode] onichols-pivotal merged pull request #7714: update CODEOWNERS: restore min two owners per area and fix other warnings

onichols-pivotal merged PR #7714: URL: https://github.com/apache/geode/pull/7714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

jinmeiliao commented on code in PR #7703: URL: https://github.com/apache/geode/pull/7703#discussion_r877573410 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -707,71 +711,102 @@ private void startDistributedSystem() throws IOExcepti

[GitHub] [geode] Bill commented on a diff in pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

Bill commented on code in PR #7703: URL: https://github.com/apache/geode/pull/7703#discussion_r877572513 ## geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java: ## @@ -707,71 +711,102 @@ private void startDistributedSystem() throws IOException {

[GitHub] [geode] demery-pivotal merged pull request #7713: GEODE-10319: Clear meters when closing the meter registry

demery-pivotal merged PR #7713: URL: https://github.com/apache/geode/pull/7713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [geode] jdeppe-pivotal commented on pull request #7711: GEODE-10322: Run various Analyze Serializable tests from IntelliJ

jdeppe-pivotal commented on PR #7711: URL: https://github.com/apache/geode/pull/7711#issuecomment-1132210422 @kirklund I should have mentioned, in the summary, that I'm building / running tests using IntelliJ instead of Gradle (IntelliJ's Gradle setting). So the output directory, where clas

[GitHub] [geode] mivanac merged pull request #7690: GEODE-10310: Add disable reatempt on CacheClose

mivanac merged PR #7690: URL: https://github.com/apache/geode/pull/7690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.

[GitHub] [geode] metatype commented on pull request #7714: update CODEOWNERS: restore min two owners per area and fix other warnings

metatype commented on PR #7714: URL: https://github.com/apache/geode/pull/7714#issuecomment-1132069956 LGTM, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [geode] demery-pivotal opened a new pull request, #7713: GEODE-10319: Clear meters when closing the meter registry

demery-pivotal opened a new pull request, #7713: URL: https://github.com/apache/geode/pull/7713 (cherry picked from commit 802137f5487cc72927c4026895400f54dd2efc1b) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [geode] demery-pivotal opened a new pull request, #7712: GEODE-10257: Upgrade tests can upgrade Java (#7686)

demery-pivotal opened a new pull request, #7712: URL: https://github.com/apache/geode/pull/7712 Currently, upgrade tests upgrade from an old version of Geode to the current version, both running on the test JVM's version of Java. This commit enhances most upgrade tests so that they

[GitHub] [geode] jdeppe-pivotal opened a new pull request, #7711: GEODE-10322: Run various Analyze Serializable tests from IntelliJ

jdeppe-pivotal opened a new pull request, #7711: URL: https://github.com/apache/geode/pull/7711 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commi

[GitHub] [geode] demery-pivotal closed pull request #7710: backport/geode 10257/upgrade java

demery-pivotal closed pull request #7710: backport/geode 10257/upgrade java URL: https://github.com/apache/geode/pull/7710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [geode] demery-pivotal opened a new pull request, #7710: backport/geode 10257/upgrade java

demery-pivotal opened a new pull request, #7710: URL: https://github.com/apache/geode/pull/7710 - GEODE-10089: Remove unneeded scripts - GEODE-10089: Bump version to 1.15.0 - PR pipeline is per branch now - GEODE-10089: do more testing in parallel on support branch - GEODE-10089:

[GitHub] [geode] jinmeiliao commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

jinmeiliao commented on PR #7703: URL: https://github.com/apache/geode/pull/7703#issuecomment-1131987304 > The scope of this problem is in question. At the highest level it's not clear why (before this PR) it is necessary for an `InternalLocator` to add itself to the effective set of locato

[GitHub] [geode] mhansonp commented on a diff in pull request #7690: GEODE-10310: Add disable reatempt on CacheClose

mhansonp commented on code in PR #7690: URL: https://github.com/apache/geode/pull/7690#discussion_r877328839 ## geode-core/src/distributedTest/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionCacheCloseNoRetryDistributedTest.java: ## @@ -0,0 +1,288 @@ +/* + * Li

[GitHub] [geode] demery-pivotal merged pull request #7705: GEODE-10319: Clear meters when closing the meter registry

demery-pivotal merged PR #7705: URL: https://github.com/apache/geode/pull/7705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [geode] demery-pivotal closed pull request #7700: JdkEncapsulationTest

demery-pivotal closed pull request #7700: JdkEncapsulationTest URL: https://github.com/apache/geode/pull/7700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [geode] nabarunnag merged pull request #7704: Revert "GEODE-10294: Compare invalid token during putIfAbsent retry. …

nabarunnag merged PR #7704: URL: https://github.com/apache/geode/pull/7704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] mkevo commented on a diff in pull request #7629: GEODE-7875: fix create index gfsh command on partitioned region

mkevo commented on code in PR #7629: URL: https://github.com/apache/geode/pull/7629#discussion_r876900607 ## geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommandsIntegrationTestBase.java: ## @@ -136,7 +136,9 @@ public void testCannotCreateInde

[GitHub] [geode] mkevo opened a new pull request, #7707: GEODE-10317: fix comparison in range query when wildcard character is used

mkevo opened a new pull request, #7707: URL: https://github.com/apache/geode/pull/7707 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit

[GitHub] [geode] albertogpz closed pull request #7555: [DRAFT DO NOT REVIEW] POC to release stuck threads using two properties

albertogpz closed pull request #7555: [DRAFT DO NOT REVIEW] POC to release stuck threads using two properties URL: https://github.com/apache/geode/pull/7555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7705: GEODE-10319: Clear meters when closing the meter registry

demery-pivotal commented on code in PR #7705: URL: https://github.com/apache/geode/pull/7705#discussion_r876476283 ## geode-core/src/main/java/org/apache/geode/metrics/internal/InternalDistributedSystemMetricsService.java: ## @@ -227,6 +227,7 @@ private void clearAndCloseMeterRe

[GitHub] [geode] dschneider-pivotal merged pull request #7699: GEODE-10315: removed unneeded add-opens

dschneider-pivotal merged PR #7699: URL: https://github.com/apache/geode/pull/7699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [geode] onichols-pivotal opened a new pull request, #7706: GEODE-10320: Bump micrometer from 1.8.5 to 1.9.0

onichols-pivotal opened a new pull request, #7706: URL: https://github.com/apache/geode/pull/7706 Geode endeavors to update to the latest version of 3rd-party dependencies on develop wherever possible. Doing so increases the shelf life of releases and increases security and reliability

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7705: GEODE-10319: Clear meters when closing the meter registry

demery-pivotal commented on code in PR #7705: URL: https://github.com/apache/geode/pull/7705#discussion_r876371862 ## geode-core/src/main/java/org/apache/geode/metrics/internal/InternalDistributedSystemMetricsService.java: ## @@ -227,6 +227,7 @@ private void clearAndCloseMeterRe

[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7705: GEODE-10319: Clear meters when closing the meter registry

dschneider-pivotal commented on code in PR #7705: URL: https://github.com/apache/geode/pull/7705#discussion_r876365140 ## geode-core/src/main/java/org/apache/geode/metrics/internal/InternalDistributedSystemMetricsService.java: ## @@ -227,6 +227,7 @@ private void clearAndCloseMet

[GitHub] [geode] jinmeiliao merged pull request #7698: GEODE-10115: fix javadoc

jinmeiliao merged PR #7698: URL: https://github.com/apache/geode/pull/7698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] jinmeiliao commented on pull request #7698: GEODE-10115: fix javadoc

jinmeiliao commented on PR #7698: URL: https://github.com/apache/geode/pull/7698#issuecomment-1130448553 > I'm not sure if the new javadoc validation/enforcement will pass on this. If it complains try adding `throws AuthenticationFailedException` to the method signature even if it's an unch

[GitHub] [geode] nabarunnag opened a new pull request, #7704: Revert "GEODE-10294: Compare invalid token during putIfAbsent retry. …

nabarunnag opened a new pull request, #7704: URL: https://github.com/apache/geode/pull/7704 …(#7679)" This reverts commit 4f4af2a303142729708a951cc8a93f562c3de8bc. ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in

[GitHub] [geode] jinmeiliao opened a new pull request, #7703: GEODE-10318: do not add duplicate entries in the locators list

jinmeiliao opened a new pull request, #7703: URL: https://github.com/apache/geode/pull/7703 * refactor GMSUtil to parse a single address * some locator launcher api code cleanup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [geode] jinmeiliao closed pull request #7702: DO NOT REVIEW: just wanna see what tests would fail

jinmeiliao closed pull request #7702: DO NOT REVIEW: just wanna see what tests would fail URL: https://github.com/apache/geode/pull/7702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [geode] gesterzhou merged pull request #7670: GEODE-10290: GII requester should remove departed members

gesterzhou merged PR #7670: URL: https://github.com/apache/geode/pull/7670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] jchen21 commented on a diff in pull request #7670: GEODE-10290: GII requester should remove departed members

jchen21 commented on code in PR #7670: URL: https://github.com/apache/geode/pull/7670#discussion_r876224536 ## geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionRestartRebalanceDUnitTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] [geode-native] albertogpz commented on a diff in pull request #970: GEODE-10300: C++ native client: Allow locator responses greater than …

albertogpz commented on code in PR #970: URL: https://github.com/apache/geode-native/pull/970#discussion_r876196927 ## cppcache/src/StreamDataInput.hpp: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreeme

[GitHub] [geode] jinmeiliao commented on pull request #7699: GEODE-10315: removed unneeded add-opens

jinmeiliao commented on PR #7699: URL: https://github.com/apache/geode/pull/7699#issuecomment-1130302020 LGTM as long as all tests passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

<    2   3   4   5   6   7   8   9   10   11   >