Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Ignasi Barrera
nacx commented on this pull request. > +import org.jclouds.domain.LocationScope; +import org.jclouds.location.suppliers.all.JustProvider; + +import javax.inject.Inject; +import javax.inject.Singleton; + +import static com.google.inject.internal.util.$Iterables.getOnlyElement; +import static

Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)

2017-12-21 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @btrishkin! > + final DimensionDataCloudControlApi api) { + this.nodeNamingConvention = checkNotNull(namingConvention, "namingConvention").createWithoutPrefix(); + this.locations = checkNotNull(locations, "locations"); +

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-20 Thread Ignasi Barrera
nacx commented on this pull request. Many thanks for this huge effort! I've commented mostly style things. Excellent job! > +} + +@Provides +protected Predicate provideResourceAvailablePredicate(final AzureComputeApi api, +

Re: [jclouds/jclouds-labs] Jclouds 46 network and image tests (#401)

2017-12-19 Thread Ignasi Barrera
Closed #401. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/401#event-1395566789

Re: [jclouds/jclouds-labs] Jclouds 46 network and image tests (#401)

2017-12-19 Thread Ignasi Barrera
merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/9c74d22b) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6a25c793). Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions()

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
Closed #427. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427#event-1392092950

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
Squashed and pushed tp [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/889b34b9) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/bf34887e). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Ignasi Barrera
nacx commented on this pull request. Just one minor left. Thanks! > } @Provides @Named(SERVER_STOPPED_PREDICATE) @VisibleForTesting public Predicate provideServerStoppedPredicate(final DimensionDataCloudControlApi api, final ComputeServiceConstants.Timeouts

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-15 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @trevorflanagan! Just one small comment. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions()

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-14 Thread Ignasi Barrera
nacx commented on this pull request. Some small comments about the predicates and timeout configuration. Overall looks good. hanks @trevorflanagan! > + public static final String SERVER_STARTED_PREDICATE = > "SERVER_STARTED_PREDICATE"; + public static final String SERVER_STOPPED_PREDICATE

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-11 Thread Ignasi Barrera
nacx commented on this pull request. Comments added. Thanks @trevorflanagan! > +import java.util.Set; + +import static com.google.common.base.MoreObjects.firstNonNull; +import static java.lang.String.format; +import static org.jclouds.util.Predicates2.retry; + +@Singleton +public class

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-10 Thread Ignasi Barrera
nacx commented on this pull request. Many thanks @jmspring! This looks quite good! I've added some general comments. Apart from those, could you paste the summary of the live tests results? > @@ -53,6 +53,33 @@ Verify service principal az login -u -p --service-principal --tenant ```

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-12-10 Thread Ignasi Barrera
nacx commented on this pull request. > + @Fallback(NullOnNotFoundOr404.class) + @OAuthResource("https://vault.azure.net;) + DeletedKeyBundle deleteKey(@EndpointParam URI vaultBaseUrl, @PathParam("keyName") String keyName); + + @Named("key:get_versions") + @GET +

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-08 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/eaeea5c3) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/dab07d44). Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-08 Thread Ignasi Barrera
Closed #425. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425#event-1378864451

[jira] [Updated] (JCLOUDS-1365) Openstack Neutron SecurityGroupApi is not always an extension

2017-12-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1365: Labels: openstack-neutron (was: ) > Openstack Neutron SecurityGroupApi is not alw

[jira] [Commented] (JCLOUDS-1365) Openstack Neutron SecurityGroupApi is not always an extension

2017-12-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283528#comment-16283528 ] Ignasi Barrera commented on JCLOUDS-1365: - I've been using it in production for several years

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Ignasi Barrera
Thanks, @trevorflanagan! Just a couple minor final comments. Mind squashing the commits directly when fixing those? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Ignasi Barrera
nacx commented on this pull request. > + public void testApplyTags() { + api().applyTags(SERVER_ID, assetType, Collections.singletonList(TagInfo.create(tagKeyId, "jcloudsValue"))); + } + + @Test + public void testListTags() { + PagedIterable response = api().listTags(); +

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Ignasi Barrera
nacx commented on this pull request. > +public interface TagApi { + + @Named("tag:createTagKey") + @POST + @Path("/createTagKey") + @Produces(MediaType.APPLICATION_JSON) + @MapBinder(BindToJsonPayload.class) + @ResponseParser(TagKeyId.class) + String

[jira] [Assigned] (JCLOUDS-114) Support OpenStack Keystone v3 API

2017-12-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-114: -- Assignee: Ignasi Barrera > Support OpenStack Keystone v3

[jira] [Commented] (JCLOUDS-1365) Openstack Neutron SecurityGroupApi is not always an extension

2017-12-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282470#comment-16282470 ] Ignasi Barrera commented on JCLOUDS-1365: - The PR contains breaking changes. I wouldn't backport

Re: [jclouds/jclouds-labs-openstack] [JCLOUDS-1365] Feature/neutron security group (#209)

2017-12-07 Thread Ignasi Barrera
nacx approved this pull request. Please amend the commit message to include the JIRA issue ID before merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jira] [Resolved] (JCLOUDS-1363) failure to read user metadata from minio

2017-12-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1363. - Resolution: Fixed Fix Version/s: 2.1.0 > failure to read user metadata f

Re: [jclouds/jclouds] Fix case sensitivity of blobstore metadata (#1164)

2017-12-07 Thread Ignasi Barrera
Merged to master as [17cef565](http://git-wip-us.apache.org/repos/asf/jclouds/commit/17cef565). Thanks, @yuvalk! @gaul given this slightly changes the behavior, should we cherry-pick it to 2.0.x? -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds] Fix case sensitivity of blobstore metadata (#1164)

2017-12-07 Thread Ignasi Barrera
Closed #1164. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1164#event-1376378897

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @trevorflanagan! > +import java.util.List; + +@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class }) +@Consumes(MediaType.APPLICATION_JSON) +@Path("/{jclouds.api-version}/tag") +public interface TagApi { + +

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-05 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/172d6f34) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/caf4c19a). Thanks @trevorflanagan! I had to remove [an unnecessary call to

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-05 Thread Ignasi Barrera
Closed #422. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422#event-1372130453

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-12-05 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2b8bfcb8) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/8c1449bd). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-04 Thread Ignasi Barrera
nacx commented on this pull request. > + } + } + + private void attemptDeleteNatRule(final String serverId, final NetworkApi networkApi, final NatRule natRule) { + try { + if (natRule.state().isNormal()) { +networkApi.deleteNatRule(natRule.id()); + }

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-04 Thread Ignasi Barrera
nacx commented on this pull request. > + String networkDomainId = server.networkInfo().networkDomainId(); + final String internalIp = server.networkInfo().primaryNic().privateIpv4(); + + // delete nat rules associated to the server, if any + final NetworkApi

Re: [jclouds/jclouds-labs] Injectable current service principal (#424)

2017-12-04 Thread Ignasi Barrera
Thanks for the review @jmspring! According to your comments I've slightly changed the PR to: * Support both formats of the OAuth endpoint (tests added). * Extracted the service principal call into a GraphRBACApi class, so we can add additional methods there as needed. * Modified the structure

Re: [jclouds/jclouds-labs] Injectable current service principal (#424)

2017-12-04 Thread Ignasi Barrera
@nacx pushed 1 commit. 67c5466 Configure the Graph RBAC API and allow mocking service endpoints -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-01 Thread Ignasi Barrera
nacx commented on this pull request. Thanks, @trevorflanagan! Just some minor comments! > +import static java.lang.String.format; +import static org.jclouds.dimensiondata.cloudcontrol.utils.DimensionDataCloudControlResponseUtils.generateFirewallRuleName; +import static

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-12-01 Thread Ignasi Barrera
nacx approved this pull request. Thanks, @trevorflanagan! Mind squashing the commits into a single one for a clean merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Jclouds 46 network and image tests (#401)

2017-12-01 Thread Ignasi Barrera
Thanks, @btrishkin! Mind squashing the commits into a single one so I can cleanly merge the PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/401#issuecomment-348496470

Re: [jclouds/jclouds-labs] Jclouds 46 network and image tests (#401)

2017-12-01 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/401#pullrequestreview-80497568

[jclouds/jclouds-labs] Injectable current service principal (#424)

2017-12-01 Thread Ignasi Barrera
This PR exposes the current service principal in the Azure API and provides several improvements to allow APIs interact with the current user information and the different OAuth resources. * It uses the *Graph RBAC* API to retrieve the current Service Principal. * If binds it to the Guice

Re: [jclouds/jclouds-site] Minor tweaks to the 2.0.3 release notes (#205)

2017-12-01 Thread Ignasi Barrera
And published! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/205#issuecomment-348434353

Re: [jclouds/jclouds-site] Minor tweaks to the 2.0.3 release notes (#205)

2017-11-30 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/205#pullrequestreview-80267264

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Ignasi Barrera
>BTW @nacx I saw the comments on the site PR regarding the slack channel. Would >it be possible to invite @btrishkin and I? Sure. Send mean email with your emails and I'll send the invites. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Ignasi Barrera
I think it was a small confusion. ICLAs are not required for Apache contributors, only for committers. Contributors must just assume and accept (and sending a patch or opening a PR means that, that's why you copy our license headers too) that their contributions are meant to be distributed

Re: [jclouds/jclouds-site] Fix link for a Stack Overflow answer relating to Java HTTP clients and POODLE (#204)

2017-11-30 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/204#pullrequestreview-80220733

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-11-30 Thread Ignasi Barrera
nacx commented on this pull request. > - -maven-toolchains-plugin -1.1 - - - - toolchain - - - - - - -

[jclouds/jclouds-site] Add visibility to the Slack channel (#203)

2017-11-30 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/203 -- Commit Summary -- * Add visibility to the Slack channel -- File Changes -- M community/index.md (1) -- Patch Links --

Re: [jclouds/jclouds] Fix case sensitivity of blobstore metadata (#1164)

2017-11-30 Thread Ignasi Barrera
Thanks, @yuvalk! Could you file an issue in our [JIRA](https://issues.apache.org/jira/projects/JCLOUDS) so we can properly track this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-cli] Added Maven profile to define the build toolchain (#41)

2017-11-30 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-cli/commit/63ac1fff) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-cli/commit/1a731979). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-cli] Added Maven profile to define the build toolchain (#41)

2017-11-30 Thread Ignasi Barrera
Closed #41. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/41#event-1365335275

Re: [jclouds/jclouds-karaf] Added Maven profile to define the build toolchain (#106)

2017-11-30 Thread Ignasi Barrera
Closed #106. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/106#event-1365334265

Re: [jclouds/jclouds-karaf] Added Maven profile to define the build toolchain (#106)

2017-11-30 Thread Ignasi Barrera
merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/5c306551) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/28c00c55). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds-cli] Added Maven profile to define the build toolchain (#41)

2017-11-30 Thread Ignasi Barrera
Changes related to https://github.com/jclouds/jclouds/pull/1152. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-cli/pull/41 -- Commit Summary -- * Added Maven profile to define the build toolchain -- File Changes -- M project/pom.xml

[jclouds/jclouds-karaf] Added Maven profile to define the build toolchain (#106)

2017-11-30 Thread Ignasi Barrera
Changes related to https://github.com/jclouds/jclouds/pull/1152. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/106 -- Commit Summary -- * Added Maven profile to define the build toolchain -- File Changes -- M pom.xml (29)

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-30 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/624367df) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3bdc25c3). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-30 Thread Ignasi Barrera
Closed #1160. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#event-1365286718

Re: [jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-30 Thread Ignasi Barrera
Closed #1163. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1163#event-1365285222

Re: [jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-30 Thread Ignasi Barrera
merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/715994b1) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b0fa8abb). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-30 Thread Ignasi Barrera
nacx commented on this pull request. > + filter(transform(contentEntries, > deserializeSerialOutput(json)), notNull()), HasEncryptedPassword) + .transform(ExtractEncryptedPassword); + + if (retrievedPassword.isPresent()) { +

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-30 Thread Ignasi Barrera
Closed #1161. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1161#event-1365284043

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-30 Thread Ignasi Barrera
merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a0f659fa) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f1126a11). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-11-30 Thread Ignasi Barrera
Closed #1152. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1152#event-1365282883

[jira] [Updated] (JCLOUDS-1362) Randomly generated node password can be invalid in Azure ARM

2017-11-30 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1362: Summary: Randomly generated node password can be invalid in Azure ARM (was: Random

[jira] [Created] (JCLOUDS-1362) Random generated node password can be invalid in Azure ARM

2017-11-30 Thread Ignasi Barrera (JIRA)
Ignasi Barrera created JCLOUDS-1362: --- Summary: Random generated node password can be invalid in Azure ARM Key: JCLOUDS-1362 URL: https://issues.apache.org/jira/browse/JCLOUDS-1362 Project: jclouds

[jira] [Updated] (JCLOUDS-1353) AWS EC2 add support for Accelerated computing instance type

2017-11-29 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1353: Fix Version/s: (was: 2.0.4) (was: 2.1.0) > AWS EC2 add supp

[jira] [Updated] (JCLOUDS-1332) BaseComputeService.destroyNodesMatching and BaseComputeService.destroyNode different behavior

2017-11-29 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1332: Fix Version/s: (was: 2.0.4) (was: 2.1.0

[jira] [Updated] (JCLOUDS-1353) AWS EC2 add support for Accelerated computing instance type

2017-11-29 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1353: Fix Version/s: (was: 2.0.3) 2.0.4 > AWS EC2 add supp

[jira] [Updated] (JCLOUDS-1332) BaseComputeService.destroyNodesMatching and BaseComputeService.destroyNode different behavior

2017-11-29 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1332: Fix Version/s: (was: 2.0.3) 2.0.4

Re: [jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-29 Thread Ignasi Barrera
I've upgraded the plugins and it should work now: rebuild please! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1163#issuecomment-347889370

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-29 Thread Ignasi Barrera
And again! rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1161#issuecomment-347888646

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-29 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1161#issuecomment-347886142

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-29 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1161#issuecomment-347880774

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-29 Thread Ignasi Barrera
Sure! :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-347880602

Re: [jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-29 Thread Ignasi Barrera
Yes, same Jenkins plugin bug :( -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1163#issuecomment-347880334

[jclouds/jclouds] Fix GCE live tests (#1163)

2017-11-29 Thread Ignasi Barrera
Fixes all Google Compute Engine Live tests: :muscle: ```bash Tests run: 179, Failures: 0, Errors: 0, Skipped: 8 Total time: 01:04 h (Wall Clock) ``` You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1163 -- Commit Summary -- * Fix GCE

Re: [jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > +* [JCLOUDS-1282](https://issues.apache.org/jira/browse/JCLOUDS-1282) - > Support custom-data in Azure ARM template options +* [JCLOUDS-1314](https://issues.apache.org/jira/browse/JCLOUDS-1314) - B2 native prefix and delimiter support +*

Re: [jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > +* [JCLOUDS-1282](https://issues.apache.org/jira/browse/JCLOUDS-1282) - > Support custom-data in Azure ARM template options +* [JCLOUDS-1314](https://issues.apache.org/jira/browse/JCLOUDS-1314) - B2 native prefix and delimiter support +*

Re: [jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > +* [JCLOUDS-1342](https://issues.apache.org/jira/browse/JCLOUDS-1342) - > Azure-ARM Virtual Machine Scale Set Support +* [JCLOUDS-1351](https://issues.apache.org/jira/browse/JCLOUDS-1351) - AWS CentOS marketplace AMI misdetecting OS type +*

Re: [jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/202#issuecomment-347562275

[jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Ignasi Barrera
@demobox @gaul @andreaturli Please review and push your fixes directly to the branch! :smile: You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/202 -- Commit Summary -- * Release notes for jclouds 2.0.3 -- File Changes -- M

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-28 Thread Ignasi Barrera
The build seems to fail due to https://github.com/jenkinsci/ghprb-plugin/issues/579. I'll try to update the Jenkins plugins later today. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-28 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1161#issuecomment-347495276

[jclouds/jclouds] Fix DigitalOcean DropletApiLiveTest (#1161)

2017-11-28 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1161 -- Commit Summary -- * Fix DigitalOcean DropletApiLiveTest -- File Changes -- M providers/digitalocean2/pom.xml (2) M

[jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Ignasi Barrera
This pull request enables a per-request customization of the OAuth properties, such as the audience and resource. This is useful for providers that have APIs that authorize different resources, such as Azure ARM and the KeyVault API. The changes in this PR are backward-compatible and by default

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Ignasi Barrera
nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-27 Thread Ignasi Barrera
nacx commented on this pull request. Thanks for a small but important PR @trevorflanagan! > + private static final String REDHAT = "RedHat"; + private static final String UBUNTU = "Ubuntu"; + private static final String SUSE = "SuSE"; + private static final String WINDOWS = "Win"; + +

Re: [jclouds/jclouds-labs] Adding missing Parser tests (#420)

2017-11-24 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/13a0440d) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/1be24b46). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds-labs] Adding missing Parser tests (#420)

2017-11-24 Thread Ignasi Barrera
Closed #420. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/420#event-1357227674

Re: [jclouds/jclouds-labs] Adding missing Parser tests (#420)

2017-11-24 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/420#pullrequestreview-78926807

[jira] [Resolved] (JCLOUDS-1255) Add support for Dimension Data

2017-11-24 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1255. - Resolution: Fixed Fix Version/s: 2.0.3 2.1.0 > Add supp

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-24 Thread Ignasi Barrera
Closed #400. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/400#event-1357214293

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-24 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/730ced56) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f9ee0d6b). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-24 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/400#pullrequestreview-78921727

[jira] [Updated] (JCLOUDS-1357) Network API set feature add to SoftLayer provider

2017-11-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1357: Component/s: jclouds-compute > Network API set feature add to SoftLayer provi

[jira] [Updated] (JCLOUDS-1357) Network API set feature add to SoftLayer provider

2017-11-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1357: Fix Version/s: 2.1.0 > Network API set feature add to SoftLayer provi

[jira] [Updated] (JCLOUDS-1357) Network API set feature add to SoftLayer provider

2017-11-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1357: Labels: softlayer (was: ) > Network API set feature add to SoftLayer provi

[jira] [Updated] (JCLOUDS-1357) Network API set feature add to SoftLayer provider

2017-11-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1357: Affects Version/s: 2.0.2 > Network API set feature add to SoftLayer provi

Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device mappings to Nova (#1159)

2017-11-22 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1159#pullrequestreview-78396614

<    3   4   5   6   7   8   9   10   11   12   >