Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-04-05 Thread Andrew Phillips
@@ -59,7 +59,15 @@ */ public static enum Status { - ACTIVE, BUILD, REBUILD, SUSPENDED, PAUSED, RESIZE, VERIFY_RESIZE, REVERT_RESIZE, PASSWORD, REBOOT, HARD_REBOOT, DELETED, UNKNOWN, ERROR, STOPPED, UNRECOGNIZED; + ACTIVE, BUILD, REBUILD, SUSPENDED, PAUSED, RESIZE,

Re: [jclouds-site] Make mvn command more codey (#71)

2014-04-05 Thread Andrew Phillips
+1 - looks nice: ![image](https://cloud.githubusercontent.com/assets/223702/2624221/d73c3e20-bd2c-11e3-9b04-8cbd97a28497.png) Thanks, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/71#issuecomment-39656166

Re: [jclouds] Add deprecation warnings and provide links to new Swift APIs (#237)

2014-04-05 Thread Andrew Phillips
Deprecated means: You should not use it. Personally, I think of deprecated as you need to think about moving away from this at some point. Hopefully, the deprecation message gives more details about _when_ that needs to happen. But I generally do not immediately try to move away from all

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-04-05 Thread Andrew Phillips
Thanks, @jdaggett! My comments were only minor - we can leave as-is or address as part of a separate PR later. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/85#issuecomment-39656725

Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router (#88)

2014-04-05 Thread Andrew Phillips
However these should be addresses with separate PRs in master first (instead of modifying this PR). Agree? +1 to that, and good with this PR. Thanks, @zack-shoylev! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-05 Thread Andrew Phillips
if (action == Action.EXEC args.length PARAMETERS + 1) throw new IllegalArgumentException(please quote the command to exec as the last parameter); String command = (action == Action.EXEC) ? args[5] : echo hello; - if

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-05 Thread Andrew Phillips
java -jar target/compute-basics-jar-with-dependencies.jar provider identity credential mygroup listnodes -To list the images: *groupname* parameter is not used +To list all images (the *groupname* parameter is not used): java -jar

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-05 Thread Andrew Phillips
if (action == Action.EXEC args.length PARAMETERS + 1) throw new IllegalArgumentException(please quote the command to exec as the last parameter); String command = (action == Action.EXEC) ? args[5] : echo hello; - if

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-05 Thread Andrew Phillips
Thanks, @suriyapriya! The changes in this PR itself are fine (I've only made one minor comment), but I think there are a couple of other things in the docs we are modifying that you might like to fix too? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Backport openstack-swift and rackspace-cloudfiles to 1.7 (#91)

2014-04-05 Thread Andrew Phillips
Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/91#issuecomment-39656929

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
version${project.version}/version scopetest/scope /dependency dependency - groupIdorg.apache.jclouds.driver/groupId - artifactIdjclouds-sshj/artifactId - version${project.version}/version - scopetest/scope +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
*/ @Delegate - ProductPackageApi getProductPackageApi(); Are we totally removing this? If so, is that a change to add to a point release such as 1.7.2? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/296/files#r11324375

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ * + * @author Andrea Turli + */ +@Singleton +public class TagToJson implements Binder { + + private final Json json; + + @Inject + public TagToJson(Json json) { + this.json = checkNotNull(json, json); + } + + @Override + public R extends HttpRequest R

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ * The string is set into the payload of the HttpRequest + * + * @author Andrea Turli + */ +public class VirtualGuestToJson implements Binder { + + private final Json json; + + @Inject + public VirtualGuestToJson(Json json) { + this.json = checkNotNull(json, json); + }

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ String operatingSystemReferenceCode = checkNotNull(virtualGuest.getOperatingSystem() + .getOperatingSystemReferenceCode(), operatingSystemReferenceCode); + templateObject = new TemplateObject(hostname, domain, startCpus, maxMemory, true, +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ boolean localDiskFlag = checkNotNull(virtualGuest.isLocalDiskFlag(), localDiskFlag); + String datacenterName = checkNotNull(virtualGuest.getDatacenter().getName(), datacenterName); + SetNetworkComponent networkComponents = getNetworkComponents(virtualGuest); +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ .getOperatingSystemReferenceCode(), operatingSystemReferenceCode); + templateObject = new TemplateObject(hostname, domain, startCpus, maxMemory, true, + operatingSystemReferenceCode, null, localDiskFlag, new Datacenter(datacenterName),

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ templateObject = new TemplateObject(hostname, domain, startCpus, maxMemory, true, + operatingSystemReferenceCode, null, localDiskFlag, new Datacenter(datacenterName), networkComponents, + getBlockDevices(virtualGuest)); + } else

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-04-05 Thread Andrew Phillips
+ }); + return set; + } + + private HashSetNetworkComponent getNetworkComponents(VirtualGuest virtualGuest) { + if(virtualGuest.getVirtualGuestNetworkComponents() == null) return null; + return

Re: [jclouds] 1.7.x Backport: Remove Nova instance metadata limit (#325)

2014-04-06 Thread Andrew Phillips
Thanks, @jfriedly! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/325#issuecomment-39669528

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-06 Thread Andrew Phillips
Closed #42. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/42

Re: [jclouds-examples] Minor changes to compute-basics after code review (#42)

2014-04-06 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=5f644baa6b3462633a5aabd52d68ee75ac02f947). Thanks, @suriyapriya! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/42#issuecomment-39687540

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
@andreaturli Just getting back to this. I see this PR is against 1.7.x...could we start with master? Is this still an issue on master? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/20#issuecomment-39766904

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
* @see org.jclouds.googlecomputeengine.features.FirewallApi#patch(String, org.jclouds.googlecomputeengine.options.FirewallOptions) */ - private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions templateOptions, Network network, -

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
-network.getSelfLink(), -firewallOptions)); -operations.add(operation); - } - } - - for (AtomicReferenceOperation operation : operations) { + Firewall firewall = firewallApi.get(firewallName); + SetRule rules

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
retry(operationDonePredicate, operationCompleteCheckTimeout, operationCompleteCheckInterval, MILLISECONDS).apply(operation); - checkState(!operation.get().getHttpError().isPresent(),Could not create firewall, operation failed + operation); +

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
retry(operationDonePredicate, operationCompleteCheckTimeout, operationCompleteCheckInterval, MILLISECONDS).apply(operation); - checkState(!operation.get().getHttpError().isPresent(),Could not create firewall, operation failed + operation); +

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
@@ -459,7 +459,7 @@ public void testCreateNodeWhenNetworkNorFirewallExistDoesNotExist() throws RunNo .builder() .method(GET) .endpoint(https://www.googleapis; + -

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
+import javax.annotation.Resource; +import javax.inject.Named; +import java.io.IOException; +import java.util.Set; + +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertTrue; + +/** + * @author Andrea Turli + */ +@Test(groups = live, testName =

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-04-07 Thread Andrew Phillips
@@ -28,4 +33,13 @@ public GoogleComputeEngineSecurityGroupExtensionLiveTest() { provider = google-compute-engine; } + + @Override + protected Properties setupProperties() { + Properties props = super.setupProperties(); + setCredentialFromPemFile(props,

Re: [jclouds] openstack console (#339)

2014-04-07 Thread Andrew Phillips
+ */ +public class ParseServerConsole implements FunctionHttpResponse, Console { + +private final ParseJsonMapString, MapString, String parser; + +@Inject +public ParseServerConsole(ParseJsonMapString, MapString, String parser) { +this.parser = parser; +} + +

Re: [jclouds] openstack console (#339)

2014-04-07 Thread Andrew Phillips
Thanks, @pimenas! Haven't looked at the content yet, just starting with some formatting things. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/339#issuecomment-39799315

Re: [jclouds] openstack console (#339)

2014-04-07 Thread Andrew Phillips
+ + public void testGetConsoleWhenResponseIs401NotAuthorized() throws Exception { + String serverId = d3aae414-9dc9-46d1-a51b-e9b7071a84b7; + String type = novnc; + + HttpRequest getConsole = HttpRequest + .builder() + .method(POST) +

Re: [jclouds-site] Codify the mvn command (#73)

2014-04-08 Thread Andrew Phillips
@@ -41,7 +41,7 @@ Likewise you can go to the [Rackspace Cloud (UK)](https://buyonline.rackspace.co * `mkdir jclouds` * `cd jclouds` 1. Make a local copy of this [pom.xml](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/pom.xml) file in the jclouds directory.

Re: [jclouds-site] Codify the mvn command (#73)

2014-04-08 Thread Andrew Phillips
Change renders fine, just one small question... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/73#issuecomment-39907833

Re: [jclouds-site] Codify the mvn command (#73)

2014-04-08 Thread Andrew Phillips
@@ -41,7 +41,7 @@ Likewise you can go to the [Rackspace Cloud (UK)](https://buyonline.rackspace.co * `mkdir jclouds` * `cd jclouds` 1. Make a local copy of this [pom.xml](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/pom.xml) file in the jclouds directory.

Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)

2014-04-08 Thread Andrew Phillips
Code change itself looks fine to me. I'll leave it up to @zack-shoylev, @everett-toews or @jdaggett to comment on the removal of the extension itself. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/340#issuecomment-39914499

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-08 Thread Andrew Phillips
@@ -63,6 +64,9 @@ private final SocketOpen socketTester; private final PredicateAtomicReferenceNodeMetadata nodeRunning; private final ListeningExecutorService userExecutor; + @Inject(optional = true) + @Named(EXCLUDE_PUBLIC_IP) + private boolean excludePublicIp; Does

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-08 Thread Andrew Phillips
@@ -175,8 +179,14 @@ public String toString() { }; } - private static FluentIterableString checkNodeHasIps(NodeMetadata node) { - FluentIterableString ips = FluentIterable.from(concat(node.getPublicAddresses(), node.getPrivateAddresses())); + private static

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-08 Thread Andrew Phillips
@@ -175,8 +179,14 @@ public String toString() { }; } - private static FluentIterableString checkNodeHasIps(NodeMetadata node) { - FluentIterableString ips = FluentIterable.from(concat(node.getPublicAddresses(), node.getPrivateAddresses())); + private static

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-08 Thread Andrew Phillips
@@ -175,8 +179,14 @@ public String toString() { }; } - private static FluentIterableString checkNodeHasIps(NodeMetadata node) { - FluentIterableString ips = FluentIterable.from(concat(node.getPublicAddresses(), node.getPrivateAddresses())); + private static

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
All changes must include the corresponding unit tests in the ConcurrentOpenSocketFinderTest class. Er...yes, doh! Good catch, @nacx...thanks! ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/341#issuecomment-39959144

Re: [jclouds-site] Added GCE to the list of providers (#74)

2014-04-09 Thread Andrew Phillips
@@ -18,7 +18,8 @@ The following is the list of providers that are supported by the jclouds API. ## a id=compute/aComputeService ### a id=compute-providers/aProviders -The Maven Group ID for all supported providers below is

Re: [jclouds-site] Added GCE to the list of providers (#74)

2014-04-09 Thread Andrew Phillips
@@ -55,7 +56,7 @@ The Maven Group ID for all supported providers below is [org.apache.jclouds.prov tdUS-DC/td /tr tr -tdDigitalOcean/td +tdDigitalOcean em(labs)/em/td tddigitalocean/td td/td No ISO code?

Re: [jclouds-site] Added GCE to the list of providers (#74)

2014-04-09 Thread Andrew Phillips
@@ -85,6 +86,11 @@ The Maven Group ID for all supported providers below is [org.apache.jclouds.prov tdUS-CA,US-VA/td /tr tr +tdGoogle Compute Engine em(labs)/em/td +tdgoogle-compute-engine/td +td/td No ISO code? ---

Re: [jclouds-site] Added GCE to the list of providers (#74)

2014-04-09 Thread Andrew Phillips
Thanks, @nacx! Just a comment about whether italics and brackets are ideal formatting for labs on the provider overview page. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39968251

Re: [jclouds-site] Added GCE to the list of providers (#74)

2014-04-09 Thread Andrew Phillips
that's why I left them blank... Fine, thanks for explaining! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39972729

Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes() (#342)

2014-04-09 Thread Andrew Phillips
Let's see what BuildHive says. This looks good to me. Also needs to be backported to 1.7.x, I guess. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/342#issuecomment-39982885

Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes() (#342)

2014-04-09 Thread Andrew Phillips
@@ -196,7 +196,14 @@ public void testAlternateAccessIPs() { assertEquals(convertedNodeMetadata.getPublicAddresses(), ImmutableSet.of(67.23.10.132, 67.23.10.131, 76.32.1.231)); } - // TODO: clean up this syntax + @Test + public void testPortableNodeStatusNotNull() {

Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes() (#342)

2014-04-09 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=84e0b91179be6921ef0ce7be63934fe4c374f690) and [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=5b9f6b76465249d6b51a5820130258cfd0a52256) --- Reply to this email directly or view it on

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
@@ -191,4 +204,22 @@ private static void blockOn(IterableListenableFuture? immutableList) { throw propagate(e); } } + + + @VisibleForTesting + enum AllowedInterfaces{ `static`? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
+ @Test + public void testSocketFinderAllowedInterfacesPrivate() throws Exception { + ConcurrentOpenSocketFinder finder = new ConcurrentOpenSocketFinder(socketAlwaysOpen, nodeRunning, userExecutor); + finder.allowedInterfaces =

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
@@ -196,4 +233,14 @@ public boolean apply(HostAndPort input) { } } }; + + private SocketOpen selectOpenSocket(final String ip){ Add a space before `{` --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
checkState(size(ips) 0, node does not have IP addresses configured: + node); - return ips; + return FluentIterable.from(ips); With this setup, I think we can use a builder: ``` ImmutableSet.BuilderString ipsBuilder = ImmutableSet.builder(); if

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
@@ -191,4 +204,22 @@ private static void blockOn(IterableListenableFuture? immutableList) { throw propagate(e); } } + + + @VisibleForTesting + enum AllowedInterfaces{ All Java enum are implicitly static. Erm...yes...doh. Blanked out the `enum`. Thanks

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
@@ -175,10 +182,17 @@ public String toString() { }; } - private static FluentIterableString checkNodeHasIps(NodeMetadata node) { - FluentIterableString ips = FluentIterable.from(concat(node.getPublicAddresses(), node.getPrivateAddresses())); -

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
Thanks for the updates, @ashley-taylor! Some minor formatting things, but we can also take care of those during merging. A few [unused

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Phillips
PS: You should be able to see the Checkstyle result by looking at the latest jclouds-pull-requests build. Those builds should be publicly accessible. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/341#issuecomment-40044846

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
@@ -76,6 +76,11 @@ public CanonicalUser getOwner() { return null; } + @Override + public ServerSideEncryption getServerSideEncryption() { + return null; Should this be `null` or `NONE`? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
this.contentMetadata = new BaseMutableContentMetadata(); } public MutableObjectMetadataImpl(ObjectMetadata from) { - this.storageClass = StorageClass.STANDARD; + this.storageClass = from.getStorageClass(); Was this a different bug? I'm guessing this change is

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
@@ -84,6 +86,12 @@ public MutableObjectMetadata apply(HttpResponse from) { // amz has an etag, but matches syntax for usermetadata to.getUserMetadata().remove(object-etag); to.setCacheControl(from.getFirstHeaderOrNull(HttpHeaders.CACHE_CONTROL)); + String

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
@@ -32,6 +32,14 @@ public static class Builder { /** + * @see AWSS3PutObjectOptions#serverSideEncryption + */ + public static AWSS3PutObjectOptions serverSideEncryption(ObjectMetadata.ServerSideEncryption serverSideEncryption) { I'd say static import

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
@@ -35,6 +35,10 @@ */ public interface ObjectMetadata extends ComparableObjectMetadata { + public enum ServerSideEncryption { + NONE, AES256 What do we need `NONE` for, actually? Could we use `null` for that instead? After all, `NONE` isn't what comes **back** from S3 (if I'm

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-11 Thread Andrew Phillips
jclouds-pull-requests #749 UNSTABLE Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/749/testReport/) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/344#issuecomment-40226195

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-11 Thread Andrew Phillips
I believe that I can give it a +1 now. :) I believe so, indeed ;-) Just curious why the PR site builder didn't trigger this time. Want to make sure we're not breaking site generation by adding the file in the root of the site. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Fixing Jclouds-509 (#333)

2014-04-11 Thread Andrew Phillips
Will try to run a live test. It might take a bit time for me :( .. Have you had any chance to look into this, @lahirus? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333#issuecomment-40230928

Re: [jclouds-labs-google] add support for rhel, suse and windows images (#23)

2014-04-11 Thread Andrew Phillips
-import com.google.common.collect.ImmutableSet; -import com.google.common.collect.Lists; -import com.google.common.primitives.Ints; -import com.google.common.util.concurrent.Atomics; -import com.google.common.util.concurrent.UncheckedTimeoutException; -import com.google.inject.Inject;

Re: [jclouds-labs-google] add support for rhel, suse and windows images (#23)

2014-04-11 Thread Andrew Phillips
return Objects.firstNonNull(api.getImageApiForProject(userProject.get()).get(id), - Objects.firstNonNull(api.getImageApiForProject(DEBIAN_PROJECT).get(id), -

Re: [jclouds-labs-google] add support for rhel, suse and windows images (#23)

2014-04-11 Thread Andrew Phillips
jclouds » jclouds-labs-google #823 UNSTABLE jclouds-labs-google-pull-requests #54 UNSTABLE These look like [real](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/823/testReport/) [test

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-11 Thread Andrew Phillips
Closed #341. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/341

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-11 Thread Andrew Phillips
Let's just close'n'reopen to try this again... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75#issuecomment-40256682

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-11 Thread Andrew Phillips
Closed #75. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-11 Thread Andrew Phillips
Reopened #75. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-11 Thread Andrew Phillips
It doesn't render for me. Sorry, I meant the _homepage_ still renders. Yes, I think it's fine if the DOAP file itself goes straight to download. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75#issuecomment-40258540

Re: [jclouds] JCLOUDS-533: Amazon S3 server-side encryption (#344)

2014-04-12 Thread Andrew Phillips
@@ -35,6 +35,10 @@ */ public interface ObjectMetadata extends ComparableObjectMetadata { + public enum ServerSideEncryption { + NONE, AES256 Or use an `Optional`? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/344/files#r11559898

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-12 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-site.git;a=commit;h=bd51d784fbe5ddcc97b85e4427086936982da5f6) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75#issuecomment-40281008

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-12 Thread Andrew Phillips
Closed #75. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75

Re: [jclouds] Update README.md (#346)

2014-04-14 Thread Andrew Phillips
@@ -123,8 +123,8 @@ Resources * Project page: http://jclouds.org/ * Documentation: http://www.jclouds.org/documentation/index * Community: http://www.jclouds.org/documentation/reference/apps-that-use-jclouds -* User group: http://groups.google.com/group/jclouds -* Dev group:

Re: [jclouds] Update README.md (#346)

2014-04-14 Thread Andrew Phillips
@@ -123,8 +123,8 @@ Resources * Project page: http://jclouds.org/ * Documentation: http://www.jclouds.org/documentation/index * Community: http://www.jclouds.org/documentation/reference/apps-that-use-jclouds Shouldn't this point to http://jclouds.apache.org/community/, by the way? ---

Re: [jclouds-site] Adding ASF DOAP file (#75)

2014-04-14 Thread Andrew Phillips
[Published](http://jclouds.apache.org/doap_jclouds.rdf) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/75#issuecomment-40385182

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

2014-04-14 Thread Andrew Phillips
jclouds-java-7-pull-requests #1223 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1223/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/). Code change

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ * Server Console Connection structure. + * + * @author Epi Vou + * @see a href=http://api.openstack.org/api-ref-compute-v2-ext.html; / + */ +public class Console { + public enum Type { + NOVNC(novnc), + XVPVNC(xvpvnc), + SPICE_HTML5(spice-html5), +

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ } + + private final String type; + + Type(String type) { + this.type = type; + } + + public String type() { + return type; + } + + /** + * Used from jclouds builtin deserializer. + */ + public static Type

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ } + } + + private static class ConcreteBuilder extends BuilderConcreteBuilder { + @Override + protected ConcreteBuilder self() { + return this; + } + } + + private final URI url; + private final Type type; + + @ConstructorProperties({ +

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ } + } + + private final URI url; + private final Type type; + + @ConstructorProperties({ + url, type + }) + protected Console(URI url, Type type) { + this.url = checkNotNull(url, url); + this.type = checkNotNull(type, type); + } + + /** +*

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ + /** +* Get SPICE Console +* @param serverId Server id +* @param type Only spice-html5 is supported +* @return a Console object containing the console url and type. +*/ + Console getSPICEConsole(String serverId, Console.Type type); + + /** +* Get RDP

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
@@ -270,7 +270,6 @@ * @return A Map containing the collected values organized by key - value. * @Beta */ -OptionalMapString, String getDiagnostics(String id); - + OptionalMapString, String getDiagnostics(String id); Thanks for the cleanup, @pimenas ;-) --- Reply to

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ return /spice_console.json; + } + + @Override + @SelectJson(console) + @Consumes(MediaType.APPLICATION_JSON) + public Console expected() { + try { + return Console + .builder() + .url(new

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ return /rdp_console.json; + } + + @Override + @SelectJson(console) + @Consumes(MediaType.APPLICATION_JSON) + public Console expected() { + try { + return Console +.builder() +.url(new

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ return /vnc_console.json; + } + + @Override + @SelectJson(console) + @Consumes(MediaType.APPLICATION_JSON) + public Console expected() { + try { + return Console +.builder() +.url(new

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ +/** + * Provides asynchronous access to Consoles via the REST API. + * p/ + * + * @see ConsoleApi + * @author Epi Vou + * @see ExtensionAsyncApi + * @see a href= http://docs.openstack.org/api/openstack-compute/2/content/Extensions-d1e1444.html; / + * @see a

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ } + + private final String type; + + Type(String type) { + this.type = type; + } + + public String type() { + return type; + } + + /** + * Used from jclouds builtin deserializer. + */ + public static Type

Re: [jclouds-site] Link to guides from providers. (#76)

2014-04-14 Thread Andrew Phillips
Yep. I don't mind fixing it here. Thanks for fixing, @everett-toews! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/76#issuecomment-40420777

Re: [jclouds] openstack console (#339)

2014-04-14 Thread Andrew Phillips
+ + /** +* Get SPICE Console +* @param serverId Server id +* @param type Only spice-html5 is supported +* @return a Console object containing the console url and type. +*/ + Console getSPICEConsole(String serverId, Console.Type type); + + /** +* Get RDP

[jclouds-karaf] Using ServiceMix bundles for JSch and sshj agentproxy deps (#43)

2014-04-14 Thread Andrew Phillips
Follow-up to 094f698f. See * https://issues.apache.org/jira/browse/SMX4-1728 * https://issues.apache.org/jira/browse/SMX4-1729 You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf use-servicemix-features Or you can view, comment on it, or merge it

Re: [jclouds-karaf] Using ServiceMix bundles for JSch and sshj agentproxy deps (#43)

2014-04-15 Thread Andrew Phillips
jclouds » jclouds-karaf #892 UNSTABLE DEV@cloud is happy (just Checkstyle complaining) but here we have some [test failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/org.apache.jclouds.karaf$itests/894/testReport/). Trunk is not happy at present anyway, though, so we need

Re: [jclouds] Fixing Jclouds-509 (#333)

2014-04-15 Thread Andrew Phillips
Here is the results from live test, There were 19 failures and one skipped. Ah, great, thanks for that. @abayer @nacx Is this what we'd be expected to see here? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333#issuecomment-40505544

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

2014-04-15 Thread Andrew Phillips
mvn test passes against core, labs, and karaf. Against karaf, `mvn integration-test` probably needs to be run too. Not happy on BuildHive right now, but that might be a stale deps thing. Trying to get the DEV@cloud build happy again at the moment. --- Reply to this email directly or view it

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

2014-04-15 Thread Andrew Phillips
OK, something still missing in karaf: ``` features:install jclouds-dynect java.lang.Exception: Could not start bundle mvn:org.apache.jclouds.provider/dynect/1.8.0-SNAPSHOT in feature(s) jclouds-dynect-1.8.0-SNAPSHOT: Unresolved constraint in bundle dynect [85]: Unable to resolve 85.0: missing

[jclouds-karaf] Using the jclouds version for Chef, rather than the project version (#44)

2014-04-15 Thread Andrew Phillips
During releases, the reference should be to the released version of jclouds and jclouds-chef You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf change-chef-version-prop Or you can view, comment on it, or merge it online at:

<    1   2   3   4   5   6   7   8   9   10   >