ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
stale[bot] closed pull request #8730: Fix error control label Metrics validator
URL: https://github.com/apache/incubator-superset/pull/8730
This is an automated message from the Apache Git Service.
To respond to the message,
stale[bot] commented on issue #8756: Cannot upgrade database
URL:
https://github.com/apache/incubator-superset/issues/8756#issuecomment-586561150
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.
serenajiang opened a new issue #9148: [Explore] persist options after the
datasource is modified
URL: https://github.com/apache/incubator-superset/issues/9148
**Is your feature request related to a problem? Please describe.**
Not sure if this qualifies as a bug or a feature request.
mapingsheng1025 commented on issue #9143: fabmanager create-admin --app
superset
URL:
https://github.com/apache/incubator-superset/issues/9143#issuecomment-586542176
**Thank you, but another problem arises**
(superset) [root@node04 superset]# flask fab create-admin
Username
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their
ktmud commented on issue #9077: [SIP-35] Proposal for Improving Superset’s
Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586536501
Chime in my two cents as a passerby. I really like that different modules
have their independent
willbarrett opened a new pull request #9147: Move non-Superset-class views out
of views/core.py
URL: https://github.com/apache/incubator-superset/pull/9147
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [X] Refactor
- [ ] Add
suddjian commented on issue #8655: [SIP-30] Remove Tabs in SQL Lab
URL:
https://github.com/apache/incubator-superset/issues/8655#issuecomment-586524018
I've edited the SIP with the latest updates to this proposal. I think this
addresses the concerns that have been raised.
suddjian removed a comment on issue #8655: [SIP-30] Remove Tabs in SQL Lab
URL:
https://github.com/apache/incubator-superset/issues/8655#issuecomment-563458825
I've been thinking about this and discussing with colleagues, and there's an
alternative approach that I think would be better.
stale[bot] commented on issue #8697: Hope add data mining with the pytorch and
scikit-learn like Orange3！
URL:
https://github.com/apache/incubator-superset/issues/8697#issuecomment-586522741
This issue has been automatically marked as stale because it has not had
recent activity. It will
nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of
TypeScript
URL:
https://github.com/apache/incubator-superset/issues/9101#issuecomment-586518283
@kristw I'm not suggesting adding any more work to main plugins repo as
there's already plenty to be done there.
kristw commented on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using
Emotion
URL:
https://github.com/apache/incubator-superset/issues/9123#issuecomment-586516617
Just want to add another long-term benefit I see from using `css-in-js` is
avoiding dead css code. Currently it
kristw commented on issue #9101: [SIP-36] Proposal for standardizing use of
TypeScript
URL:
https://github.com/apache/incubator-superset/issues/9101#issuecomment-586516021
> Using elm or reason in the chart plugins seems like a good idea, if
someone wanted to implement their new plugin
codecov-io commented on issue #9146: [dashboard] clean up usage for old filter
immune metadata
URL:
https://github.com/apache/incubator-superset/pull/9146#issuecomment-586503457
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9146?src=pr=h1)
Report
> Merging
codecov-io commented on issue #9145: [dashboard] use filter_scopes metadata
when import old dashboard
URL:
https://github.com/apache/incubator-superset/pull/9145#issuecomment-586501932
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9145?src=pr=h1)
Report
> Merging
willbarrett commented on issue #8574: [SIP-26] Proposal for Implementing
Connection Pooling for Analytics Database Connections
URL:
https://github.com/apache/incubator-superset/issues/8574#issuecomment-586496585
I'm willing to compromise on the unstructured column. I've updated the SIP
graceguo-supercat opened a new pull request #9146: [dashboard] clean up usage
for old filter immune metadata
URL: https://github.com/apache/incubator-superset/pull/9146
### CATEGORY
Choose one
- [x] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
graceguo-supercat opened a new pull request #9145: [dashboard] update
filter_scopes metadata when import old dashboard
URL: https://github.com/apache/incubator-superset/pull/9145
### CATEGORY
Choose one
- [x] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ]
mistercrunch merged pull request #9102: [sqllab] fix: return pandas records in
execute_sql_statements
URL: https://github.com/apache/incubator-superset/pull/9102
This is an automated message from the Apache Git Service.
To
mistercrunch merged pull request #8658: fix: handle duplicate groupby keys
URL: https://github.com/apache/incubator-superset/pull/8658
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-io edited a comment on issue #9142: Support human readable datetime
type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#issuecomment-586053520
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9142?src=pr=h1)
Report
> Merging
suddjian commented on issue #9077: [SIP-35] Proposal for Improving Superset’s
Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586478075
@metaperl
Reviewers should help ensure that code is organized, and I think that's the
idea you
stale[bot] commented on issue #8847: 'pip wheel' requires the 'wheel' package.
To fix this, run: pip install wheel
URL:
https://github.com/apache/incubator-superset/issues/8847#issuecomment-586467122
This issue has been automatically marked as stale because it has not had
recent
metaperl commented on issue #9077: [SIP-35] Proposal for Improving Superset’s
Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586458890
> Blaming committers for these issues is not helpful or appropriate.
@suddjian - It certainly
suddjian commented on issue #9077: [SIP-35] Proposal for Improving Superset’s
Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586429496
@metaperl
> who let these problems get into the codebase in the first place?
graceguo-supercat commented on a change in pull request #9109: [migration]
metadata for dashboard filters
URL:
https://github.com/apache/incubator-superset/pull/9109#discussion_r379584994
##
File path: superset/utils/dashboard_filter_scopes_converter.py
##
@@ -0,0 +1,72
willbarrett commented on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586414197
First, thanks for your comments! I appreciate the community taking the issue
seriously.
nytai commented on issue #9143: fabmanager create-admin --app superset
URL:
https://github.com/apache/incubator-superset/issues/9143#issuecomment-586411975
@mapingsheng1025 `fabmanger` is deprecated, please use `flask fab
create-admin`
codecov-io commented on issue #9120: Add feature flags to control query
sharing, KV exposure
URL:
https://github.com/apache/incubator-superset/pull/9120#issuecomment-586410483
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9120?src=pr=h1)
Report
> Merging
nytai commented on issue #9029: databaseview/add should allow customization of
the extras attribute via superset_config.py
URL:
https://github.com/apache/incubator-superset/issues/9029#issuecomment-586409027
@metaperl seems like you have a fairly good grasp of the work involved here,
nytai commented on issue #9137: Document AUTH_DB configuration
URL:
https://github.com/apache/incubator-superset/issues/9137#issuecomment-586405296
@metaperl seems like this is a fairly simple docs change, mind opening a PR?
nytai commented on issue #9136: RECAPTCHA_DISABLE not supported by AUTH_DB
URL:
https://github.com/apache/incubator-superset/issues/9136#issuecomment-586404279
@metaperl seems like a simple enough config to add, would you be interested
in opening a PR?
john-bodley commented on issue #9138: [mypy] Enforcing typing for
db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#issuecomment-586404107
Thanks @etr2460 and @villebro for the feedback. I've addressed your comments.
john-bodley commented on a change in pull request #9138: [mypy] Enforcing
typing for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379568840
##
File path: superset/db_engine_specs/base.py
##
@@ -132,7 +138,9 @@ def
bkyryliuk commented on issue #8639: [SIP-27] Proposal for Paranoid Deletes
URL:
https://github.com/apache/incubator-superset/issues/8639#issuecomment-586398443
+1 for this proposal, we are thinking of implementing this @ dropbox as well
either through APIs & some heuristics. It would be
john-bodley commented on a change in pull request #9109: [migration] metadata
for dashboard filters
URL:
https://github.com/apache/incubator-superset/pull/9109#discussion_r379555209
##
File path: superset/utils/dashboard_filter_scopes_converter.py
##
@@ -0,0 +1,72 @@
+#
willbarrett commented on a change in pull request #9120: Add feature flags to
control query sharing, KV exposure
URL:
https://github.com/apache/incubator-superset/pull/9120#discussion_r379551238
##
File path: tests/core_tests.py
##
@@ -497,6 +504,9 @@ def
graceguo-supercat merged pull request #9140: [dashboard] remove loading spinner
in missing chart holder
URL: https://github.com/apache/incubator-superset/pull/9140
This is an automated message from the Apache Git Service.
metaperl edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586375971
> The root cause of that was a lack of shared understanding on the best code
structure for
DiggidyDave commented on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586376328
The empty `__init__.py` files alone would provide enormous value IMO. If
this SIP as a whole is
metaperl commented on issue #9077: [SIP-35] Proposal for Improving Superset’s
Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586375971
> The root cause of that was a lack of shared understanding on the best code
structure for Superset
stale[bot] commented on issue #8837: [Question] How to filter date data with
bar chart.
URL:
https://github.com/apache/incubator-superset/issues/8837#issuecomment-586371808
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no
willbarrett commented on a change in pull request #9129: [datasets] new, API
using command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379533085
##
File path: superset/commands/base.py
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache
etr2460 commented on a change in pull request #9142: Support human readable
datetime type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#discussion_r379528730
##
File path: superset/db_engine_specs/pinot.py
##
@@ -39,18 +40,41 @@ class
john-bodley edited a comment on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586349711
I agree with many issues/concerns raised in this SIP though I’m not overly
familiar with
john-bodley commented on issue #9077: [SIP-35] Proposal for Improving
Superset’s Python Code Organization
URL:
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586349711
I agree with many issues/concerns raised in this SIP though I’m not overly
familiar with commands
stale[bot] closed issue #8784: _get_slice_data fails to send slice data when
Celery Workers are on another instance
URL: https://github.com/apache/incubator-superset/issues/8784
This is an automated message from the Apache
villebro commented on a change in pull request #9142: Support human readable
datetime type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#discussion_r379497892
##
File path: superset/db_engine_specs/pinot.py
##
@@ -39,18 +40,41 @@ class
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379492319
##
File path: superset/db_engine_specs/base.py
##
@@ -486,14 +496,13 @@ def
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379489998
##
File path: superset/db_engine_specs/base.py
##
@@ -472,7 +482,7 @@ def
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379494767
##
File path: superset/db_engine_specs/presto.py
##
@@ -712,7 +720,7 @@ def
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379495119
##
File path: superset/db_engine_specs/snowflake.py
##
@@ -47,14 +49,13 @@ class
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379493972
##
File path: superset/db_engine_specs/hive.py
##
@@ -192,24 +195,23 @@ def
villebro commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379494124
##
File path: superset/db_engine_specs/hive.py
##
@@ -237,15 +239,17 @@ def progress(cls,
dpgaspar merged pull request #9054: [database] new, select star API migration
URL: https://github.com/apache/incubator-superset/pull/9054
This is an automated message from the Apache Git Service.
To respond to the message,
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379430544
##
File path: superset/datasets/commands/delete.py
##
@@ -0,0 +1,49 @@
+# Licensed to the
dpgaspar commented on issue #9129: [datasets] new, API using command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#issuecomment-586287905
@willbarrett,
Agree, it's looking far better, I also see great potential for the use of
commands outside of the REST API.
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379418836
##
File path: superset/datasets/dao.py
##
@@ -0,0 +1,119 @@
+# Licensed to the Apache
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379425525
##
File path: tests/dataset_api_tests.py
##
@@ -0,0 +1,445 @@
+# Licensed to the Apache
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379422828
##
File path: tests/dataset_api_tests.py
##
@@ -0,0 +1,445 @@
+# Licensed to the Apache
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379418836
##
File path: superset/datasets/dao.py
##
@@ -0,0 +1,119 @@
+# Licensed to the Apache
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379416111
##
File path: superset/datasets/commands/update.py
##
@@ -0,0 +1,83 @@
+# Licensed to the
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379414952
##
File path: superset/datasets/commands/delete.py
##
@@ -0,0 +1,57 @@
+# Licensed to the
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379414508
##
File path: superset/datasets/commands/delete.py
##
@@ -0,0 +1,49 @@
+# Licensed to the
stale[bot] closed issue #8632: docker-compose failed to build
URL: https://github.com/apache/incubator-superset/issues/8632
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379412720
##
File path: superset/commands/base.py
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379412720
##
File path: superset/commands/base.py
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache
dpgaspar commented on issue #9054: [database] new, select star API migration
URL:
https://github.com/apache/incubator-superset/pull/9054#issuecomment-586270082
@villebro good point, registered it on Preset's backlog
This
codecov-io edited a comment on issue #9054: [database] new, select star API
migration
URL:
https://github.com/apache/incubator-superset/pull/9054#issuecomment-581413926
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9054?src=pr=h1)
Report
> Merging
stale[bot] commented on issue #8819: Cannot add new country to CountryMap chart
URL:
https://github.com/apache/incubator-superset/issues/8819#issuecomment-586255755
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further
stale[bot] commented on issue #8841: /shortner API does not take into account
when Superset is behind a reverse proxy to be served over HTTPS
URL:
https://github.com/apache/incubator-superset/issues/8841#issuecomment-586255780
This issue has been automatically marked as stale because it
stale[bot] commented on issue #8842: Cant creating chart in superset via Kylin
URL:
https://github.com/apache/incubator-superset/issues/8842#issuecomment-586255810
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further
dpgaspar commented on a change in pull request #9129: [datasets] new, API using
command pattern
URL:
https://github.com/apache/incubator-superset/pull/9129#discussion_r379384670
##
File path: superset/datasets/commands/create.py
##
@@ -0,0 +1,82 @@
+# Licensed to the
dpgaspar opened a new pull request #9144: [database] Fix, tables endpoint
URL: https://github.com/apache/incubator-superset/pull/9144
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build /
mapingsheng1025 opened a new issue #9143: fabmanager create-admin --app
superset
URL: https://github.com/apache/incubator-superset/issues/9143
(superset) [root@node04 superset]# fabmanager create-admin --app superset
fabmanager is going to be deprecated in 2.2.X, you can use the same
stale[bot] commented on issue #8839: set dashboard owner can set role that
access all charts of the dashboard
URL:
https://github.com/apache/incubator-superset/pull/8839#issuecomment-586207649
This issue has been automatically marked as stale because it has not had
recent activity. It
stale[bot] commented on issue #8686: Error while changing data source in chart
URL:
https://github.com/apache/incubator-superset/issues/8686#issuecomment-586207684
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further
stale[bot] commented on issue #8840: Export data from Superset to Google sheets
URL:
https://github.com/apache/incubator-superset/issues/8840#issuecomment-586207678
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further
codecov-io edited a comment on issue #9142: Support human readable datetime
type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#issuecomment-586053520
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9142?src=pr=h1)
Report
> Merging
dpgaspar merged pull request #9134: [charts] Fix, double registration of charts
API
URL: https://github.com/apache/incubator-superset/pull/9134
This is an automated message from the Apache Git Service.
To respond to the
dpgaspar commented on issue #9134: [charts] Fix, double registration of charts
API
URL:
https://github.com/apache/incubator-superset/pull/9134#issuecomment-586158060
Totally @villebro and @nytai
This is an automated
fx19880617 commented on a change in pull request #9142: Support human readable
datetime type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#discussion_r379297196
##
File path: superset/db_engine_specs/pinot.py
##
@@ -44,13 +45,32 @@ def
fx19880617 commented on a change in pull request #9142: Support human readable
datetime type for PinotDB
URL:
https://github.com/apache/incubator-superset/pull/9142#discussion_r379297153
##
File path: superset/db_engine_specs/pinot.py
##
@@ -44,13 +45,32 @@ def
89 matches
Mail list logo
