[GitHub] michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021 In the new MetricsControl, selecting a column with an expression would fail because it's just using the column name

[GitHub] codecov-io commented on issue #5020: Make port number optional in superset for druid

2018-05-16 Thread GitBox
codecov-io commented on issue #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020#issuecomment-389665315 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=h1) Report > Merging

[GitHub] jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-16 Thread GitBox
jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389649681 @graceguo-supercat No, we don't have that case. But I think to support both cases, you may need another

[GitHub] xrmx commented on issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but

2018-05-16 Thread GitBox
xrmx commented on issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but when I tried to save it present the error: General Error . Any one have faced this before? URL:

[GitHub] amalakar opened a new pull request #5020: Make port number optional in superset for druid

2018-05-16 Thread GitBox
amalakar opened a new pull request #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020 It appears that urllib throws error with ssl if port number is provided ``` url = "https://example.com:443/druid/v2;

[GitHub] amalakar commented on issue #5020: Make port number optional in superset for druid

2018-05-16 Thread GitBox
amalakar commented on issue #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020#issuecomment-389658902 Full stack trace: ``` Traceback (most recent call last): File

[GitHub] john-bodley commented on issue #5019: fix missing datasource error message

2018-05-16 Thread GitBox
john-bodley commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389665676 Should we cascade deleted datasource and delete the corresponding slice(s)?

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-16 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing.

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-16 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing. I think deleting

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-16 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing. I think deleting

[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-16 Thread GitBox
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=h1) Report > Merging

[GitHub] hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()

2018-05-15 Thread GitBox
hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE() URL: https://github.com/apache/incubator-superset/issues/4857#issuecomment-389391118 Seems very closely related to

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @john-bodley @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1.

[GitHub] john-bodley commented on issue #5031: Dashboard initial page load logging with tabs

2018-05-23 Thread GitBox
john-bodley commented on issue #5031: Dashboard initial page load logging with tabs URL: https://github.com/apache/incubator-superset/pull/5031#issuecomment-391418634 I think there’s merit in providing more generic logging where each page component is uniquely identifiable. That provides

[GitHub] mistercrunch commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric

2018-05-20 Thread GitBox
mistercrunch commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390553650 @GabeLoins

[GitHub] hughhhh commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
hug commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190262556 ## File path: superset/assets/src/explore/store.js ## @@ -56,6 +56,10 @@

[GitHub] hughhhh commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
hug commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391362905  This is an automated message from the

[GitHub] codecov-io commented on issue #5055: Fixing tooltip displaying metrics in heatmap

2018-05-22 Thread GitBox
codecov-io commented on issue #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055#issuecomment-391102466 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=h1) Report > Merging

[GitHub] michellethomas commented on issue #4981: Make time filter more usable

2018-05-22 Thread GitBox
michellethomas commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391108467 Yeah after looking into it, it may be difficult to message because it depends on whether you are using a date or not (and also which

[GitHub] vylc commented on issue #4981: Make time filter more usable

2018-05-23 Thread GitBox
vylc commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391450331 Looks great! (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. (2) Re:

[GitHub] john-bodley opened a new pull request #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
john-bodley opened a new pull request #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062 This PR fixes an issue where a dashboard contained a markup slice with links to other dashboards, and when one tried to either export or explore a slice on

[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters

2018-05-23 Thread GitBox
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356316 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def

[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters

2018-05-23 Thread GitBox
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356344 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def

[GitHub] john-bodley closed pull request #5060: [get_df] Adding support for multi-statement SQL

2018-05-23 Thread GitBox
john-bodley closed pull request #5060: [get_df] Adding support for multi-statement SQL URL: https://github.com/apache/incubator-superset/pull/5060 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] betodealmeida commented on issue #4981: Make time filter more usable

2018-05-22 Thread GitBox
betodealmeida commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391093955 Yeah, I'm unsure about the naming. Maybe we could use "simple" and "custom", like the filters? @michellethomas, how are they

[GitHub] michellethomas opened a new pull request #5055: Fixing tooltip displaying metrics in heatmap

2018-05-22 Thread GitBox
michellethomas opened a new pull request #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055 Heatmap was showing `[object, object]` instead of metric name for adhoc metrics because it needed the metric label. @GabeLoins

[GitHub] GabeLoins commented on issue #5055: Fixing tooltip displaying metrics in heatmap

2018-05-22 Thread GitBox
GabeLoins commented on issue #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055#issuecomment-391096242 LGTM! This is an automated message from the Apache Git

[GitHub] mistercrunch closed issue #5061: Support Multi charts

2018-05-23 Thread GitBox
mistercrunch closed issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 On my environment the gamma user gets redirected to the welcome page. Have you run `superset init` since upgrade? The

[GitHub] ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart

2018-05-23 Thread GitBox
ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart URL: https://github.com/apache/incubator-superset/issues/1768 Make sure these boxes are checked before submitting your issue - thank you! - [yes ] I have

[GitHub] mistercrunch commented on issue #5061: Support Multi charts

2018-05-23 Thread GitBox
mistercrunch commented on issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061#issuecomment-391429655 Reopened the original issue This is an automated message from the Apache Git

[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190332713 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] mistercrunch commented on issue #5048: [bugfix] Render to section by override value

2018-05-23 Thread GitBox
mistercrunch commented on issue #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048#issuecomment-391432296 Why closing?  This is an automated message from the

[GitHub] aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency

2018-05-23 Thread GitBox
aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency URL: https://github.com/apache/incubator-superset/issues/5058#issuecomment-391438223 Amazing! I will do that--thanks This is an automated

[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 Have you run `superset init` since upgrade? The provided roles are updated/synced when running `supreset init`, perhaps `Gamma`

[GitHub] mistercrunch commented on issue #5053: Database Permission for version 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5053: Database Permission for version 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5053#issuecomment-391431982 What's keeping you from granting database access? Is the perm missing? it should show as `database access on

[GitHub] michellethomas commented on issue #4981: Make time filter more usable

2018-05-22 Thread GitBox
michellethomas commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391081201 For `Start/End` it would be nice to have the language make it clear if the range will be inclusive or exclusive. Druid and sqlalchemy

[GitHub] sbarlock commented on issue #5003: Date formating lost when selecting MAX(date)

2018-05-22 Thread GitBox
sbarlock commented on issue #5003: Date formating lost when selecting MAX(date) URL: https://github.com/apache/incubator-superset/issues/5003#issuecomment-391070630 @mistercrunch Thanks. So is there a way to display to a user, e.g. the last date a report was submitted?

[GitHub] GabeLoins commented on a change in pull request #4981: Make time filter more usable

2018-05-22 Thread GitBox
GabeLoins commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189983720 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190359546 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190360447 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging

[GitHub] betodealmeida commented on issue #4981: Make time filter more usable

2018-05-23 Thread GitBox
betodealmeida commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391458918 > (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. @vylc,

[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-18 Thread GitBox
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=h1) Report > Merging

[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto

2018-05-18 Thread GitBox
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates feedback from the 1. It abandons the presto specific logic and uses fetchmany to

[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto

2018-05-18 Thread GitBox
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates the various feedback I have received on this PR. 1. It abandons the presto

[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'

2018-05-21 Thread GitBox
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-390583363 > Did your original query work when doing heatmaps? I have a table which has row and column and a value at that row and

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all other dependent slices

[GitHub] michellethomas commented on issue #4897: Heatmap improvements

2018-05-17 Thread GitBox
michellethomas commented on issue #4897: Heatmap improvements URL: https://github.com/apache/incubator-superset/pull/4897#issuecomment-390059989 hey @mistercrunch it looks like this causes an issue with heatmaps that use `Value Bounds` with normalized turned off. The legend seems to

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189134922 ## File path: superset/utils.py ## @@ -841,3 +841,17 @@ def

[GitHub] john-bodley commented on a change in pull request #5019: fix missing datasource error message

2018-05-17 Thread GitBox
john-bodley commented on a change in pull request #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#discussion_r189138119 ## File path: superset/views/core.py ## @@ -1229,6 +1229,12 @@ def

[GitHub] codecov-io commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
codecov-io commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389645443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=h1) Report > Merging

[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-17 Thread GitBox
GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032 Previously to this PR, when adding/viewing a simple filter with number of comparators this could

[GitHub] john-bodley commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-21 Thread GitBox
john-bodley commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-390869422 @mistercrunch what are your thoughts about having metrics reference other metrics, or should metric

[GitHub] zhaoyongjie commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric

2018-05-21 Thread GitBox
zhaoyongjie commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390564358 @zhangjian0111 which visualization type do you choice?

[GitHub] miloradkrstevski closed issue #5036: Which db is best with Superset 0.24 and later (0.25+)?

2018-05-21 Thread GitBox
miloradkrstevski closed issue #5036: Which db is best with Superset 0.24 and later (0.25+)? URL: https://github.com/apache/incubator-superset/issues/5036 This is an automated message from the Apache Git Service. To respond

[GitHub] codecov-io commented on issue #4819: Visualization for multiple line charts

2018-05-21 Thread GitBox
codecov-io commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-383682187 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat opened a new pull request #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy

2018-05-21 Thread GitBox
graceguo-supercat opened a new pull request #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy URL: https://github.com/apache/incubator-superset/pull/5051 fix issue caused by #4900. @jasnovak @timifasubaa @mistercrunch

[GitHub] williaster commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown

2018-05-21 Thread GitBox
williaster commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown URL: https://github.com/apache/incubator-superset/pull/5038#issuecomment-390811715 LGTM This is an

[GitHub] williaster closed pull request #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown

2018-05-21 Thread GitBox
williaster closed pull request #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown URL: https://github.com/apache/incubator-superset/pull/5038 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] codecov-io commented on issue #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy

2018-05-21 Thread GitBox
codecov-io commented on issue #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy URL: https://github.com/apache/incubator-superset/pull/5051#issuecomment-390827213 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=h1) Report >

[GitHub] qin4zhang commented on issue #4398: database_access on [mydb] permissionview not created when database added

2018-05-22 Thread GitBox
qin4zhang commented on issue #4398: database_access on [mydb] permissionview not created when database added URL: https://github.com/apache/incubator-superset/issues/4398#issuecomment-390910303 Resolved? Which version? This

[GitHub] qin4zhang opened a new issue #5149: [Session] How to set session timeout?

2018-06-06 Thread GitBox
qin4zhang opened a new issue #5149: [Session] How to set session timeout? URL: https://github.com/apache/incubator-superset/issues/5149 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and

[GitHub] xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything

2018-06-06 Thread GitBox
xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148#issuecomment-395046659 Please reproduce with 0.25 or master This is an

[GitHub] claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything

2018-06-06 Thread GitBox
claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148 ### Superset version 0.24.0 ### Expected results All tabs, non-data words (e.g. "since" and "until," month names) are

[GitHub] nukeu666 opened a new issue #5145: Can see all datasources while making charts

2018-06-06 Thread GitBox
nukeu666 opened a new issue #5145: Can see all datasources while making charts URL: https://github.com/apache/incubator-superset/issues/5145 Make sure these boxes are checked before submitting your issue - thank you! - [-] I have checked the superset logs for python stacktraces and

[GitHub] MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox

2018-06-06 Thread GitBox
MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox URL: https://github.com/apache/incubator-superset/issues/5147 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python

[GitHub] k-hashimoto opened a new issue #5146: Configure to use Google BigQuery

2018-06-06 Thread GitBox
k-hashimoto opened a new issue #5146: Configure to use Google BigQuery URL: https://github.com/apache/incubator-superset/issues/5146 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included

[GitHub] hughhhh commented on issue #5152: Use Rison for the explore URL

2018-06-09 Thread GitBox
hug commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019222 @betodealmeida thank you blessing us with this. CC.geoviz definitely needs it :P

[GitHub] mistercrunch closed pull request #4193: Init docker for local development environment.

2018-06-09 Thread GitBox
mistercrunch closed pull request #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch commented on issue #4193: Init docker for local development environment.

2018-06-09 Thread GitBox
mistercrunch commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396019586 ![docker](https://user-images.githubusercontent.com/487433/41198310-c4eeb48e-6c2b-11e8-8553-94d4186e2774.gif)

[GitHub] xiaohanyu commented on issue #4193: Init docker for local development environment.

2018-06-09 Thread GitBox
xiaohanyu commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396018556 CI passed after two more commits! This is an automated

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-09 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019487 Only thing is this may have some intricacies that are hard to predict (maybe around `null`, `NaN`, `infinity` handling). The assumption

[GitHub] codecov-io commented on issue #4193: Init docker for local development environment.

2018-06-09 Thread GitBox
codecov-io commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396017411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4193: Init docker for local development environment.

2018-06-09 Thread GitBox
codecov-io commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396017411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-09 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019388 This LGTM. It could be good to add an entry in the FAQ ("How are the URL formatted?"), or mentioning Rison somewhere else in the docs.

[GitHub] rajivchodisetti commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz

2018-06-09 Thread GitBox
rajivchodisetti commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz URL: https://github.com/apache/incubator-superset/issues/4931#issuecomment-395971867 I am also facing this issue, I have installed super-set just a day back

[GitHub] john-bodley commented on issue #5143: strip druid metric type when value is postagg

2018-06-09 Thread GitBox
john-bodley commented on issue #5143: strip druid metric type when value is postagg URL: https://github.com/apache/incubator-superset/pull/5143#issuecomment-395976435 I agree with @mistercrunch, we should ensure that all inputs are stripped of leading and trailing whitespace when saving

[GitHub] john-bodley commented on a change in pull request #5119: [sqllab] allow gamma users to access their SQLLab views

2018-06-09 Thread GitBox
john-bodley commented on a change in pull request #5119: [sqllab] allow gamma users to access their SQLLab views URL: https://github.com/apache/incubator-superset/pull/5119#discussion_r194230629 ## File path: superset/security.py ## @@ -130,8 +131,13 @@ def

[GitHub] mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176 This is an automated message from the Apache Git Service. To

[GitHub] mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe URL: https://github.com/apache/incubator-superset/pull/4726#discussion_r194572936 ## File path: superset/viz.py ## @@ -170,11 +170,21 @@ def get_df(self,

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] kirankumarpv commented on issue #3690: URL Prefix Superset Flask

2018-06-11 Thread GitBox
kirankumarpv commented on issue #3690: URL Prefix Superset Flask URL: https://github.com/apache/incubator-superset/issues/3690#issuecomment-396435448 Hi, I am also having the same issue. I tried to fix it using Blurprints but superset doesn't seem to take into consideration

[GitHub] lynch0227 commented on issue #5169: How to disable preview data feature?

2018-06-11 Thread GitBox
lynch0227 commented on issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169#issuecomment-396436689 OK, I got it. Thanks for your explanation. This is an automated

[GitHub] lynch0227 closed issue #5169: How to disable preview data feature?

2018-06-11 Thread GitBox
lynch0227 closed issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mistercrunch commented on a change in pull request #5099: Dashboard level access control

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #5099: Dashboard level access control URL: https://github.com/apache/incubator-superset/pull/5099#discussion_r194570629 ## File path: superset/migrations/versions/76a4d742cf04_dashboard_role_many_to_many.py ## @@ -0,0

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396416232 @williaster the main driver is mostly readable, and maybe hackable urls. I really wish Rison was more popular / supported. Note that we

[GitHub] williaster closed pull request #5055: Fixing tooltip displaying metrics in heatmap

2018-06-11 Thread GitBox
williaster closed pull request #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs URL: https://github.com/apache/incubator-superset/pull/5122#discussion_r194571227 ## File path: superset/assets/package.json ## @@ -150,13 +152,15 @@ "react-addons-test-utils":

[GitHub] betodealmeida opened a new pull request #5177: Time shift difference

2018-06-11 Thread GitBox
betodealmeida opened a new pull request #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177 I added a new control to allow comparing comparing the main time series with time shifts. In addition to showing the time shift as individual lines, it's now

[GitHub] codecov-io commented on issue #5174: Gantt Chart visualization

2018-06-11 Thread GitBox
codecov-io commented on issue #5174: Gantt Chart visualization URL: https://github.com/apache/incubator-superset/pull/5174#issuecomment-396386176 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=h1) Report > Merging

[GitHub] john-bodley opened a new pull request #5178: John bodley sql percent sign

2018-06-11 Thread GitBox
john-bodley opened a new pull request #5178: John bodley sql percent sign URL: https://github.com/apache/incubator-superset/pull/5178 This PR came about due to an error when exporting a SQL Lab result to CSV. For example in Presto one can successfully run the following query: ```

[GitHub] codecov-io commented on issue #5177: Time shift difference

2018-06-11 Thread GitBox
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5177: Time shift difference

2018-06-11 Thread GitBox
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-11 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-395911509 These are the final set of 3x empirical tests per example dashboard before and after, on non-minimized code with

[GitHub] john-bodley commented on issue #5175: boto3 and botocore version mismatch

2018-06-11 Thread GitBox
john-bodley commented on issue #5175: boto3 and botocore version mismatch URL: https://github.com/apache/incubator-superset/issues/5175#issuecomment-396444621 @mistercrunch @timifasubaa found a similar issue with Celery and had to pin the `kombu` subcomponent in

<    3   4   5   6   7   8   9   10   11   12   >