[GitHub] [geode] kirklund merged pull request #5301: Revert "GEODE-8250: Create new custom log config acceptance tests (#5…

kirklund merged pull request #5301: URL: https://github.com/apache/geode/pull/5301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] kirklund commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

kirklund commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445693168 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -199,4 +220,23 @@ private void

[GitHub] [geode] jinmeiliao merged pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

jinmeiliao merged pull request #5299: URL: https://github.com/apache/geode/pull/5299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jinmeiliao commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

jinmeiliao commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445705089 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -199,4 +220,23 @@ private void

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #623: GEODE-8297: fix tcrmessage timeout

pivotal-jbarrett commented on a change in pull request #623: URL: https://github.com/apache/geode-native/pull/623#discussion_r445712619 ## File path: cppcache/src/TcrMessage.cpp ## @@ -124,7 +124,7 @@ TcrMessage::TcrMessage() m_chunkedResult(nullptr),

[GitHub] [geode] pivotal-jbarrett commented on pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

pivotal-jbarrett commented on pull request #5256: URL: https://github.com/apache/geode/pull/5256#issuecomment-649736064 Sorry for the rebase but apparently Concourse is unable to function properly without it. This is an

[GitHub] [geode] kirklund commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

kirklund commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445695124 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -199,4 +220,23 @@ private void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

dschneider-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445655890 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java ## @@ -77,7 +78,7 @@ private void

[GitHub] [geode] onichols-pivotal opened a new pull request #5304: GEODE-8300: add Windows checks to PR pipeline

onichols-pivotal opened a new pull request #5304: URL: https://github.com/apache/geode/pull/5304 since they are required to pass in the main pipeline, developers should be able to verify they pass in PR before merging, otherwise it's both embarrassing to break the main pipeline, and also

[GitHub] [geode] kirklund commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

kirklund commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445693168 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -199,4 +220,23 @@ private void

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #623: GEODE-8297: fix tcrmessage timeout

pdxcodemonkey opened a new pull request #623: URL: https://github.com/apache/geode-native/pull/623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] boglesby merged pull request #5279: GEODE-8287: Added another condition to cause the indexed value to be …

boglesby merged pull request #5279: URL: https://github.com/apache/geode/pull/5279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jinmeiliao commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r445592976 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the

[GitHub] [geode] lgtm-com[bot] commented on pull request #5289: GEODE-8295: refactor GeodeRedisServer

lgtm-com[bot] commented on pull request #5289: URL: https://github.com/apache/geode/pull/5289#issuecomment-649672240 This pull request **introduces 1 alert** and **fixes 1** when merging d4caf7bc9551cfbf3847d51e0ea7599b0873030d into 5e2baea7516b5e900f2699afddb63c59a20a1ab3 - [view on

[GitHub] [geode] kirklund commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

kirklund commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445691690 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -199,4 +220,23 @@ private void

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445903549 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445903215 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -145,9 +145,7 @@ public GfshExecution

[GitHub] [geode] Bill commented on a change in pull request #5269: GEODE-8240: View has old locator version number after rolling upgrade

Bill commented on a change in pull request #5269: URL: https://github.com/apache/geode/pull/5269#discussion_r442241602 ## File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberData.java ## @@ -220,12 +220,16 @@ public

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

dschneider-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445776709 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

lgtm-com[bot] commented on pull request #5256: URL: https://github.com/apache/geode/pull/5256#issuecomment-649762229 This pull request **fixes 1 alert** when merging 374d4d2302b06ee6fd811f528aa2854aa94bdfe7 into 561533c53cf44e53c42f26cd988eae6821af6769 - [view on

[GitHub] [geode] jchen21 commented on a change in pull request #5309: DRAFT: GEODE-8250: Create new custom log config acceptance tests

jchen21 commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445898605 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/logging/ServerWithCustomLogConfigAcceptanceTest.java ## @@ -0,0 +1,209 @@ +/* + *

[GitHub] [geode] jinmeiliao commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

jinmeiliao commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445930634 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -145,9 +145,7 @@ public GfshExecution

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445902008 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445902105 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445904267 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445904115 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] jdeppe-pivotal merged pull request #5310: GEODE-8305: Revert "Feature/expand pubsub support (#5284)"

jdeppe-pivotal merged pull request #5310: URL: https://github.com/apache/geode/pull/5310 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal opened a new pull request #5311: removed the numThreads redis sys prop

dschneider-pivotal opened a new pull request #5311: URL: https://github.com/apache/geode/pull/5311 also simplified initialization of the NettyRedisServer to have all final instance fields and do all its intialization in the constructor Thank you for submitting a contribution to

[GitHub] [geode] mhansonp opened a new pull request #5305: GEODE-8095 backport to 1.13

mhansonp opened a new pull request #5305: URL: https://github.com/apache/geode/pull/5305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal merged pull request #5289: GEODE-8295: refactor GeodeRedisServer

dschneider-pivotal merged pull request #5289: URL: https://github.com/apache/geode/pull/5289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal closed pull request #5302: Redis stats

dschneider-pivotal closed pull request #5302: URL: https://github.com/apache/geode/pull/5302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jinmeiliao merged pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao merged pull request #5285: URL: https://github.com/apache/geode/pull/5285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt commented on a change in pull request #5306: GEODE-8195: ConcurrentModificationException from LocatorMembershipLis…

bschuchardt commented on a change in pull request #5306: URL: https://github.com/apache/geode/pull/5306#discussion_r445840597 ## File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java ## @@ -328,6 +331,7 @@

[GitHub] [geode] agingade commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

agingade commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445867726 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java ## @@ -113,7 +113,7 @@ public class

[GitHub] [geode] Bill commented on a change in pull request #5306: GEODE-8195: ConcurrentModificationException from LocatorMembershipLis…

Bill commented on a change in pull request #5306: URL: https://github.com/apache/geode/pull/5306#discussion_r445836429 ## File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java ## @@ -328,6 +331,7 @@ public

[GitHub] [geode] pivotal-amurmann opened a new pull request #5308: GEODE-8304 - Better highlight steps for building documentation

pivotal-amurmann opened a new pull request #5308: URL: https://github.com/apache/geode/pull/5308 Make it clearer that neither a local Bookbinder nor Ruby interpreter is needed to build our documentation book. No tests added, since this is just a readme change.

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

pivotal-eshu commented on a change in pull request #5256: URL: https://github.com/apache/geode/pull/5256#discussion_r445823337 ## File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java ## @@ -242,12 +252,15 @@ public void

[GitHub] [geode] pivotal-jbarrett merged pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

pivotal-jbarrett merged pull request #5256: URL: https://github.com/apache/geode/pull/5256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

jdeppe-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445776826 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

pivotal-eshu commented on a change in pull request #5256: URL: https://github.com/apache/geode/pull/5256#discussion_r445823337 ## File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java ## @@ -242,12 +252,15 @@ public void

[GitHub] [geode] pivotal-eshu closed pull request #5225: GEODE-8217: Do not leave serialized bytes in DeltaSession

pivotal-eshu closed pull request #5225: URL: https://github.com/apache/geode/pull/5225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] pdxcodemonkey merged pull request #623: GEODE-8297: fix tcrmessage timeout

pdxcodemonkey merged pull request #623: URL: https://github.com/apache/geode-native/pull/623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jinmeiliao commented on a change in pull request #5300: GEODE-8095: Changes to make GEODE Respond to Restore Redundancy REST Command

jinmeiliao commented on a change in pull request #5300: URL: https://github.com/apache/geode/pull/5300#discussion_r445775612 ## File path: geode-web-management/src/main/java/org/apache/geode/management/internal/rest/controllers/RestoreRedundancyOperationController.java ## @@

[GitHub] [geode] dschneider-pivotal opened a new pull request #5307: GEODE-8301: redis stats

dschneider-pivotal opened a new pull request #5307: URL: https://github.com/apache/geode/pull/5307 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] bschuchardt commented on pull request #5306: GEODE-8195: ConcurrentModificationException from LocatorMembershipLis…

bschuchardt commented on pull request #5306: URL: https://github.com/apache/geode/pull/5306#issuecomment-649853272 DistributedTests failed due to GEODE-8172, which we're seeing in a lot of runs. This is an automated message

[GitHub] [geode] kirklund opened a new pull request #5309: GEODE-8250: Create new custom log config acceptance tests

kirklund opened a new pull request #5309: URL: https://github.com/apache/geode/pull/5309 Resubmit new acceptance tests after reverting initial commit. ServerWithCustomLogConfigAcceptanceTest was failing on Windows because it was attempting to use `locators=""` in the command to

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5310: Revert "Feature/expand pubsub support (#5284)"

jdeppe-pivotal opened a new pull request #5310: URL: https://github.com/apache/geode/pull/5310 This reverts commit 5e2baea7516b5e900f2699afddb63c59a20a1ab3. Tests are causing hangs on Windows Thank you for submitting a contribution to Apache Geode. In order to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5289: GEODE-8295: refactor GeodeRedisServer

lgtm-com[bot] commented on pull request #5289: URL: https://github.com/apache/geode/pull/5289#issuecomment-649265042 This pull request **introduces 1 alert** and **fixes 1** when merging b1827f612ae61b908f7f4f4098c691fafd96f6f9 into 5732a1c1ef9c8ccb979770a963d5c4b1b7324f1a - [view on

[GitHub] [geode] jdeppe-pivotal merged pull request #5284: Feature/expand pubsub support

jdeppe-pivotal merged pull request #5284: URL: https://github.com/apache/geode/pull/5284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jujoramos commented on a change in pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

jujoramos commented on a change in pull request #5303: URL: https://github.com/apache/geode/pull/5303#discussion_r445531653 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java ## @@ -117,19 +116,21 @@

[GitHub] [geode] alb3rtobr commented on a change in pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

alb3rtobr commented on a change in pull request #5303: URL: https://github.com/apache/geode/pull/5303#discussion_r445550192 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java ## @@ -117,19 +116,21 @@

[GitHub] [geode-native] mkevo merged pull request #621: GEODE-8213: Switch SerializationRegistry spinlock to mutex

mkevo merged pull request #621: URL: https://github.com/apache/geode-native/pull/621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jujoramos commented on a change in pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

jujoramos commented on a change in pull request #5303: URL: https://github.com/apache/geode/pull/5303#discussion_r445500467 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java ## @@ -129,7 +130,9 @@

[GitHub] [geode] alb3rtobr commented on a change in pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

alb3rtobr commented on a change in pull request #5303: URL: https://github.com/apache/geode/pull/5303#discussion_r445502667 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java ## @@ -129,7 +130,9 @@

[GitHub] [geode] jujoramos commented on a change in pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

jujoramos commented on a change in pull request #5303: URL: https://github.com/apache/geode/pull/5303#discussion_r445504922 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java ## @@ -129,7 +130,9 @@

[GitHub] [geode] alb3rtobr opened a new pull request #5303: GEODE-8176: Fix for flaky testPingWrongServer

alb3rtobr opened a new pull request #5303: URL: https://github.com/apache/geode/pull/5303 The DistributedPingMessage is handled asynchronously: I have check that if I introduce a sleep `process()` method of `DistributedPingServer`, the test case fails because the `ClientHealthMonitor` has

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r445552302 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

jdeppe-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445582180 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java ## @@ -77,7 +78,7 @@ private void