[GitHub] [incubator-superset] villebro commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
villebro commented on a change in pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426380594 ## File path: superset/connectors/base/models.py ## @@ -182,7 +182,7 @@ def short_data(self) -> Dict[str, Any]: } @property

[GitHub] [incubator-superset] Amylee520 closed issue #9785: superset-fontend Error after run npm run dev-server

2020-05-18 Thread GitBox
Amylee520 closed issue #9785: URL: https://github.com/apache/incubator-superset/issues/9785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] villebro opened a new pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
villebro opened a new pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831 ### SUMMARY The `getExploreUrlAndPayload` function is currently unnecessarily complex and returns an unmutated copy of one of its inputs (`formData`). Also, the `getURIDirectory`

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] zheya08 commented on issue #7921: Title garbled in Time-series Table

2020-05-18 Thread GitBox
zheya08 commented on issue #7921: URL: https://github.com/apache/incubator-superset/issues/7921#issuecomment-630041090 same issue +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] villebro commented on a change in pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
villebro commented on a change in pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#discussion_r426437041 ## File path: superset-frontend/spec/javascripts/explore/utils_spec.jsx ## @@ -123,20 +117,6 @@ describe('exploreUtils', () => {

[GitHub] [incubator-superset] codecov-io commented on pull request #9831: [WIP] chore: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io commented on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] Sam--Shan commented on issue #9719: Clickhouse connection issue

2020-05-18 Thread GitBox
Sam--Shan commented on issue #9719: URL: https://github.com/apache/incubator-superset/issues/9719#issuecomment-630022816 @rubenSastre @chuang39 hi,did you find any solution.i came across the issue,too,but different message: INFO:werkzeug:218.4.91.131 - - [18/May/2020 08:05:46]

[GitHub] [incubator-superset] brij100 commented on issue #8632: docker-compose failed to build

2020-05-18 Thread GitBox
brij100 commented on issue #8632: URL: https://github.com/apache/incubator-superset/issues/8632#issuecomment-630079535 you should follow below command & it might be help you guys! docker pull preset/superset docker run -d -p 8080:8080 --name superset preset/superset

[GitHub] [incubator-superset] KanishkSrivastava commented on issue #9785: superset-fontend Error after run npm run dev-server

2020-05-18 Thread GitBox
KanishkSrivastava commented on issue #9785: URL: https://github.com/apache/incubator-superset/issues/9785#issuecomment-630109118 @Amylee520 Did you solve this issue? This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] stevenlevey commented on issue #5307: Can't load plugin sqlalchemy.dialects:druid

2020-05-18 Thread GitBox
stevenlevey commented on issue #5307: URL: https://github.com/apache/incubator-superset/issues/5307#issuecomment-630115580 I have the same issue running the stock standard docker container. Does anyone have a solution to this?

[GitHub] [incubator-superset] stevenlevey edited a comment on issue #5307: Can't load plugin sqlalchemy.dialects:druid

2020-05-18 Thread GitBox
stevenlevey edited a comment on issue #5307: URL: https://github.com/apache/incubator-superset/issues/5307#issuecomment-630115580 I have the same issue running inside the Docker Container. Does anyone have a solution to this? This is query string I add into "SQLAlchemy URI"

[GitHub] [incubator-superset] kristw merged pull request #9808: feat: bump superset-ui/time-format and big-number

2020-05-18 Thread GitBox
kristw merged pull request #9808: URL: https://github.com/apache/incubator-superset/pull/9808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
etr2460 commented on a change in pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426852348 ## File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx ## @@ -60,7 +63,35 @@ export default class

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
john-bodley commented on a change in pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426869164 ## File path: superset/connectors/druid/models.py ## @@ -1240,7 +1268,7 @@ def run_query( # druid qry["limit"] = row_limit

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630371062 The old implementation can save new chart when user give `untitled` new chart a title. But I feel this behavior is also confusing: - when try to

[GitHub] [incubator-superset] etr2460 merged pull request #9835: fix: use snake_case for error_type

2020-05-18 Thread GitBox
etr2460 merged pull request #9835: URL: https://github.com/apache/incubator-superset/pull/9835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813 My point is this quick save makes Save behavior inconsistent. Auto save is a standard behavior for many application. If we want to offer auto-save, the

[GitHub] [incubator-superset] john-bodley commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
john-bodley commented on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630415479 @villebro thanks for the feedback. I've addressed your comments. Note https://github.com/apache/incubator-superset/pull/9833 is a prerequisite to fix the docs

[GitHub] [incubator-superset] ktmud commented on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-18 Thread GitBox
ktmud commented on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-630434253 @kristw @etr2460 This is now conflict free. Would you mind taking another look? This is an automated

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] jasmine-w-norman edited a comment on issue #2098: Be able to set Y-axis range

2020-05-18 Thread GitBox
jasmine-w-norman edited a comment on issue #2098: URL: https://github.com/apache/incubator-superset/issues/2098#issuecomment-630413458 Hi, was this feature ever implemented? I can't find a way to set default limits for the y-axis on bar charts. In the image below, I want the y-axis

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
john-bodley commented on a change in pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426872156 ## File path: superset/connectors/druid/models.py ## @@ -1322,13 +1347,13 @@ def run_query( # druid set([x for x in

[GitHub] [incubator-superset] jasmine-w-norman edited a comment on issue #2098: Be able to set Y-axis range

2020-05-18 Thread GitBox
jasmine-w-norman edited a comment on issue #2098: URL: https://github.com/apache/incubator-superset/issues/2098#issuecomment-630413458 Hi, was this feature ever implemented? I can't find a way to set default limits for the y-axis on bar charts. Example of issue:

[GitHub] [incubator-superset] jasmine-w-norman commented on issue #2098: Be able to set Y-axis range

2020-05-18 Thread GitBox
jasmine-w-norman commented on issue #2098: URL: https://github.com/apache/incubator-superset/issues/2098#issuecomment-630413458 Hi, was this feature ever implemented? Example of issue:

[GitHub] [incubator-superset] etr2460 commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
etr2460 commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630386661 to answer your questions: 1. When you first name a chart, we save the current state of everything to a new chart with that name. This is a pretty standard use

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813 My point is this quick save makes Save behavior inconsistent. Auto save is a standard behavior for many application. If we want to offer

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813 My point is this quick save makes Save behavior inconsistent. _Auto-save_ is a standard behavior for many application. If we want to offer

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9768: feat: partitionchart controls migration

2020-05-18 Thread GitBox
rusackas commented on a change in pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768#discussion_r426736914 ## File path: superset-frontend/spec/javascripts/components/ColumnOption_spec.jsx ## @@ -19,9 +19,9 @@ import React from 'react'; import {

[GitHub] [incubator-superset] rusackas merged pull request #9768: feat: partitionchart controls migration

2020-05-18 Thread GitBox
rusackas merged pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] esilver opened a new issue #9836: Filter generated alias cause bigquery error: 400 Unrecognized name

2020-05-18 Thread GitBox
esilver opened a new issue #9836: URL: https://github.com/apache/incubator-superset/issues/9836 When using a chart filter on a nested Big Query field, for example, field.field_name with the `like` operator %name%, superset will generate an alias in the `WHERE` clause of the query, which

[GitHub] [incubator-superset] codecov-io commented on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-io commented on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630454184 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] etr2460 opened a new pull request #9835: fix: use snake_case for error_type

2020-05-18 Thread GitBox
etr2460 opened a new pull request #9835: URL: https://github.com/apache/incubator-superset/pull/9835 ### SUMMARY To match the api standard, `errorType` should be `error_type` instead ### TEST PLAN CI, ensure the error message component is overridden when a custom message is

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813 My point is this quick save makes Save behavior inconsistent. - _Auto-save_ is a standard behavior for many application. If we want to

[GitHub] [incubator-superset] esilver commented on issue #9823: filter box be applyed to all charts of one dashboard

2020-05-18 Thread GitBox
esilver commented on issue #9823: URL: https://github.com/apache/incubator-superset/issues/9823#issuecomment-630400556 You can do it by adding the charts to the `filter_immune_slices` metadata field. It is in the documentation:

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813 My point is this quick save makes Save behavior inconsistent. - _Auto-save_ is a standard behavior for many application. If we want to

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
john-bodley commented on a change in pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426895317 ## File path: superset/connectors/base/models.py ## @@ -182,7 +182,7 @@ def short_data(self) -> Dict[str, Any]: }

[GitHub] [incubator-superset] etr2460 commented on pull request #9786: chore: bump python dependencies

2020-05-18 Thread GitBox
etr2460 commented on pull request #9786: URL: https://github.com/apache/incubator-superset/pull/9786#issuecomment-630461106 @villebro, @bkyryliuk, it looks like this broke s3cache since s3werkzeugcache relies on the old werkzeug format. I'm going to work on a fix now, but I think i'll

[GitHub] [incubator-superset] lilykuang commented on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
lilykuang commented on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-630305099 @etr2460 I misunderstood the issue. Changing to `logger.warning` to reduce sentry errors because it doesn't raise to sentry

[GitHub] [incubator-superset] michellethomas opened a new pull request #9832: Removing the logic to add timeseries_limit_metric to the data for table

2020-05-18 Thread GitBox
michellethomas opened a new pull request #9832: URL: https://github.com/apache/incubator-superset/pull/9832 ### SUMMARY Removing logic to add the timeseries_limit_metric to data for Table viz. This was previously necessary in the old Table viz to fix a bug where labeled metrics with a

[GitHub] [incubator-superset] john-bodley opened a new pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
john-bodley opened a new pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833 ### SUMMARY This PR fixes an issue which surfaced in https://github.com/apache/incubator-superset/pull/9824 with Sphinx when an auto-doc included a forward reference via

[GitHub] [incubator-superset] codecov-io commented on pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
codecov-io commented on pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#issuecomment-630341168 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9833?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] blinkov opened a new pull request #9834: Update the link to ClickHouse official website

2020-05-18 Thread GitBox
blinkov opened a new pull request #9834: URL: https://github.com/apache/incubator-superset/pull/9834 ### SUMMARY ClickHouse official domain have moved to a new domain earlier this year. Update the link instead of relying on redirect. ### TEST PLAN Click the link ###

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] willbarrett commented on pull request #9811: fix: Emit a warning message rather than an exception on query failure

2020-05-18 Thread GitBox
willbarrett commented on pull request #9811: URL: https://github.com/apache/incubator-superset/pull/9811#issuecomment-630273327 I think Craig's suggestion is the correct balance. I'll set `exec_info=True` to capture the stacktraces. To @mistercrunch 's point, many of those `.exception`

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
john-bodley commented on a change in pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#discussion_r426792346 ## File path: docs/sqllab.rst ## @@ -79,16 +79,11 @@ Superset's Jinja context: `Jinja's builtin filters

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9768: feat: partitionchart controls migration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768#issuecomment-625642984 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9768?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9768: feat: partitionchart controls migration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768#issuecomment-625642984 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9768?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
ktmud commented on a change in pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426823293 ## File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx ## @@ -60,7 +63,35 @@ export default class

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-629540939 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-629540939 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9816?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-629540939 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9816?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-629540939 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9816?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] remiremi commented on issue #3728: Can Filter values be passed as a parameter to query

2020-05-18 Thread GitBox
remiremi commented on issue #3728: URL: https://github.com/apache/incubator-superset/issues/3728#issuecomment-630320069 It's possible, using the `filter_values` jinja template. Doc: https://superset.incubator.apache.org/sqllab.html#superset.jinja_context.filter_values So it would

[GitHub] [incubator-superset] remiremi removed a comment on issue #3728: Can Filter values be passed as a parameter to query

2020-05-18 Thread GitBox
remiremi removed a comment on issue #3728: URL: https://github.com/apache/incubator-superset/issues/3728#issuecomment-630320069 It's possible, using the `filter_values` jinja template. Doc: https://superset.incubator.apache.org/sqllab.html#superset.jinja_context.filter_values So it

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#issuecomment-630341168 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#issuecomment-630341168 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9833?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630371062 The old implementation can save new chart when user give `untitled` new chart a title. But I feel this behavior is also confusing: - when try to save

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud commented on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
ktmud commented on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-630374097 LGTM, just a couple of style nits. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
ktmud commented on a change in pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426824394 ## File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx ## @@ -27,6 +27,9 @@ import SelectControl from

[GitHub] [incubator-superset] villebro merged pull request #9831: refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
villebro merged pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9816: fixes: limit no authorization error for sentry

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9816: URL: https://github.com/apache/incubator-superset/pull/9816#issuecomment-629540939 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9816?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] bkyryliuk closed pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
bkyryliuk closed pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9768: feat: partitionchart controls migration

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768#issuecomment-625642984 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9768?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] john-bodley merged pull request #9828: build: tox leveraging conditional factors

2020-05-18 Thread GitBox
john-bodley merged pull request #9828: URL: https://github.com/apache/incubator-superset/pull/9828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] craig-rueda opened a new pull request #9837: [Docker-Compose] Fixes issue with duplicated dependencies

2020-05-18 Thread GitBox
craig-rueda opened a new pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837 ### SUMMARY * Fixes issue with `pip` install failing when dependencies are duplicated across requirements files. * Removes `restart: always` from tests worker as it crash-loops

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] stale[bot] commented on issue #9288: Blank login Page when building from 0.36.rc1 release branch

2020-05-18 Thread GitBox
stale[bot] commented on issue #9288: URL: https://github.com/apache/incubator-superset/issues/9288#issuecomment-630515992 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-superset] stale[bot] commented on issue #9327: While running the complex query from the sqllab editor,its taking time and at the end its throwing error like "An error occurred",i h

2020-05-18 Thread GitBox
stale[bot] commented on issue #9327: URL: https://github.com/apache/incubator-superset/issues/9327#issuecomment-630515996 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] Sam--Shan commented on issue #9719: Clickhouse connection issue

2020-05-18 Thread GitBox
Sam--Shan commented on issue #9719: URL: https://github.com/apache/incubator-superset/issues/9719#issuecomment-630526691 I tried re install infi.clickhouse_orm and it works. pip uninstall infi.clickhouse_orm pip install infi.clickhouse_orm==1.0.4

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
etr2460 commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r426987520 ## File path: superset/config.py ## @@ -586,11 +586,24 @@ class CeleryConfig: # pylint: disable=too-few-public-methods # The directory

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
etr2460 commented on a change in pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#discussion_r426979019 ## File path: superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx ## @@ -65,24 +65,9 @@

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

  1   2   >