[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] jinghua-qa commented on issue #15322: [native filter] Enlarged default value window overlap with Multiple selection option.

2021-06-23 Thread GitBox
jinghua-qa commented on issue #15322: URL: https://github.com/apache/superset/issues/15322#issuecomment-866592551 also clicking 'X' on the second line of the default value has no reponse

[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] zhaoyongjie commented on a change in pull request #15318: fix: nvd3 bar chart sortby metric

2021-06-23 Thread GitBox
zhaoyongjie commented on a change in pull request #15318: URL: https://github.com/apache/superset/pull/15318#discussion_r656789078 ## File path: tests/core_tests.py ## @@ -999,7 +1000,8 @@ def test_explore_json_dist_bar_order(self): SELECT count(name) AS

[GitHub] [superset] codecov[bot] commented on pull request #15319: fix: Capitalize time granularity weekdays

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15319: URL: https://github.com/apache/superset/pull/15319#issuecomment-866574864 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 #

[GitHub] [superset] codecov[bot] commented on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] jinghua-qa opened a new issue #15322: [native filter] Enlarged default value window overlap with Multiple selection option.

2021-06-23 Thread GitBox
jinghua-qa opened a new issue #15322: URL: https://github.com/apache/superset/issues/15322 https://user-images.githubusercontent.com/81597121/123050821-f4879680-d3b5-11eb-93e6-bb40472728ef.png;> ## Description When select 3+ default value, the default value window will be

[GitHub] [superset] dpgaspar commented on a change in pull request #15184: fix: datasource payload is incorrect

2021-06-23 Thread GitBox
dpgaspar commented on a change in pull request #15184: URL: https://github.com/apache/superset/pull/15184#discussion_r656875243 ## File path: superset/connectors/connector_registry.py ## @@ -73,6 +74,47 @@ def get_all_datasources(cls, session: Session) ->

[GitHub] [superset] kgabryje opened a new pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
kgabryje opened a new pull request #15324: URL: https://github.com/apache/superset/pull/15324 ### SUMMARY Currently, if for some reason backend doesn't return `column_types` field in datasets query, we disable selecting time filters in native filters modal. This PR makes the feature

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 #

[GitHub] [superset] blackhawk28 opened a new issue #15327: Superset-Athena setup

2021-06-23 Thread GitBox
blackhawk28 opened a new issue #15327: URL: https://github.com/apache/superset/issues/15327 I have connected my superset with Athena using JDBC url, and i can see my athena tables on superset now but that is showing from a single catalog tables, suppose i have one more catalog in my

[GitHub] [superset] codecov[bot] commented on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] villebro commented on a change in pull request #15270: feat(editable-title): move cursor and scroll to the end

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15270: URL: https://github.com/apache/superset/pull/15270#discussion_r656792478 ## File path: superset-frontend/src/components/EditableTitle/index.tsx ## @@ -70,6 +70,13 @@ export default function EditableTitle({ useEffect(()

[GitHub] [superset] villebro commented on a change in pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15324: URL: https://github.com/apache/superset/pull/15324#discussion_r656887497 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx ## @@ -275,9

[GitHub] [superset] dpgaspar commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
dpgaspar commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r656889274 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as

[GitHub] [superset] suddjian commented on issue #15174: Dynamic plugin not showing up in VizTypeControl

2021-06-23 Thread GitBox
suddjian commented on issue #15174: URL: https://github.com/apache/superset/issues/15174#issuecomment-866655603 Thank you so much for your debugging efforts @krsnik93! I think I understand the problem before even needing to repro  I am actively working on this file so I should be able

[GitHub] [superset] codecov[bot] commented on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 #

[GitHub] [superset] jaythacker opened a new issue #15323: way to show schema and table for other project in big query

2021-06-23 Thread GitBox
jaythacker opened a new issue #15323: URL: https://github.com/apache/superset/issues/15323 My service account in big query has access to other project as well, and its required to join tables form both of the project. I am able to write query and do join, but I am not able to see

[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 #

[GitHub] [superset] kgabryje commented on a change in pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
kgabryje commented on a change in pull request #15324: URL: https://github.com/apache/superset/pull/15324#discussion_r656909789 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx ## @@ -275,9

[GitHub] [superset] samudurand opened a new pull request #15321: Allow to set service account on Helm deployment

2021-06-23 Thread GitBox
samudurand opened a new pull request #15321: URL: https://github.com/apache/superset/pull/15321 ### SUMMARY When deploying to AWS with helm3, the standard way to give a pod an IAM role is to use service accounts. This change allows to set the service account name on the deployment.

[GitHub] [superset] john-bodley commented on issue #6032: [SIP-11] Proposal for deprecating the native Druid NoSQL connector

2021-06-23 Thread GitBox
john-bodley commented on issue #6032: URL: https://github.com/apache/superset/issues/6032#issuecomment-866575832 @wchaofan apologies I just saw your comment. The `DRUID_IS_ACTIVE` flag is somewhat misleading and relates to whether the native Druid NoSQL connector is exposed. Per the SIP

[GitHub] [superset] codecov[bot] commented on pull request #15318: fix: nvd3 bar chart sortby metric

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 #

[GitHub] [superset] kgabryje closed issue #14974: [native-filters]close indicator popover on resize

2021-06-23 Thread GitBox
kgabryje closed issue #14974: URL: https://github.com/apache/superset/issues/14974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] kgabryje merged pull request #15305: fix(dashboard): Close FiltersBadge popover on window resize

2021-06-23 Thread GitBox
kgabryje merged pull request #15305: URL: https://github.com/apache/superset/pull/15305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 #

[GitHub] [superset] musduo opened a new issue #15331: nginx configuration

2021-06-23 Thread GitBox
musduo opened a new issue #15331: URL: https://github.com/apache/superset/issues/15331 I set the gunicorn to superset as it says in the doc. (https://superset.apache.org/docs/installation/configuring-superset)

[GitHub] [superset] hughhhh commented on a change in pull request #15206: feat: implement specific errors for SQL Lab

2021-06-23 Thread GitBox
hug commented on a change in pull request #15206: URL: https://github.com/apache/superset/pull/15206#discussion_r657179195 ## File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx ## @@ -207,3 +207,43 @@ The submitted payload has the incorrect schema. ``` Please

[GitHub] [superset] betodealmeida merged pull request #15206: feat: implement specific errors for SQL Lab

2021-06-23 Thread GitBox
betodealmeida merged pull request #15206: URL: https://github.com/apache/superset/pull/15206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] betodealmeida merged pull request #15184: fix: datasource payload is incorrect

2021-06-23 Thread GitBox
betodealmeida merged pull request #15184: URL: https://github.com/apache/superset/pull/15184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] blackhawk28 commented on issue #875: Support of JOIN statement for queries

2021-06-23 Thread GitBox
blackhawk28 commented on issue #875: URL: https://github.com/apache/superset/issues/875#issuecomment-866702345 > > > @xrmx that is correct, in general I would like to have the flexibility to define table with sql statement so to join more table, even coming from different

[GitHub] [superset] dpgaspar commented on pull request #15328: fix: downgrade selenium log level on timeout

2021-06-23 Thread GitBox
dpgaspar commented on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866706193 > LGTM. As a follow-up, I wonder if we should change the status of charts that have rendered a non-timeout related error to be able to distinguish between real and errored

[GitHub] [superset] kgabryje merged pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
kgabryje merged pull request #15324: URL: https://github.com/apache/superset/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] kgabryje commented on issue #15226: [native-filters] hide non-numeric columns in numeric range filter

2021-06-23 Thread GitBox
kgabryje commented on issue #15226: URL: https://github.com/apache/superset/issues/15226#issuecomment-866721523 @villebro This feature requires changes in the response from `/dataset/{id}` endpoint, as it doesn't return `type_generic` field for columns

[GitHub] [superset] musduo closed issue #15330: Uwsgi configuration

2021-06-23 Thread GitBox
musduo closed issue #15330: URL: https://github.com/apache/superset/issues/15330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [superset] kitkat73 opened a new issue #15332: Line chart tooltip doesn't show on Chrome

2021-06-23 Thread GitBox
kitkat73 opened a new issue #15332: URL: https://github.com/apache/superset/issues/15332 Similar to [this issue on Firefox](https://github.com/apache/superset/issues/7822), the tooltip on line charts is sometimes missing. The behavior is rather stochastic, see the description. ###

[GitHub] [superset] Ognian opened a new issue #15333: move docker-compose and needed docker directory to a new repo

2021-06-23 Thread GitBox
Ognian opened a new issue #15333: URL: https://github.com/apache/superset/issues/15333 moving docker compose and the needed ./docker directory to a new git repository (i.e apache/docker_compose_superset) would greatly simplify updating a local instance of superset, since we would

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] musduo opened a new issue #15330: Uwsgi configuration

2021-06-23 Thread GitBox
musduo opened a new issue #15330: URL: https://github.com/apache/superset/issues/15330 I have problems with superset uwsgi configuration. Below are the uwsgi log details and uwsgi.ini configuration settings. Installation Document:

[GitHub] [superset] codecov[bot] edited a comment on pull request #15328: fix: downgrade selenium log level on timeout

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 #

[GitHub] [superset] codecov[bot] commented on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r656877011 ## File path: superset/utils/pandas_postprocessing.py ## @@ -425,9 +429,11 @@ def select( @validate_column_args("columns") -def diff(df:

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r656928933 ## File path: superset/common/query_context.py ## @@ -97,6 +101,62 @@ def __init__( # pylint: disable=too-many-arguments

[GitHub] [superset] juleslagarde opened a new issue #15329: docker build failed (with fix)

2021-06-23 Thread GitBox
juleslagarde opened a new issue #15329: URL: https://github.com/apache/superset/issues/15329 Command `docker build` failed ### Expected results build sucessfull ### Actual results error In file included from Modules/LDAPObject.c:9:0:

[GitHub] [superset] villebro commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15302: URL: https://github.com/apache/superset/pull/15302#discussion_r656965106 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx ## @@ -580,6

[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
kgabryje commented on a change in pull request #15302: URL: https://github.com/apache/superset/pull/15302#discussion_r656971367 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx ## @@ -56,11

[GitHub] [superset] blackhawk28 commented on issue #875: Support of JOIN statement for queries

2021-06-23 Thread GitBox
blackhawk28 commented on issue #875: URL: https://github.com/apache/superset/issues/875#issuecomment-866701274 > > > @gclsoft `SELECT` in expressions as IN > > ``` > SELECT (SELECT...) ... > ``` > > isn't supported by all database engines. > > Just create

[GitHub] [superset] zhaoyongjie commented on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-23 Thread GitBox
zhaoyongjie commented on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-866702014 > Some comments. Also, I'm unable to get the offsets to work. When I try to do a 1 year offset, I get the following results (notice that the offset label is correct, but

[GitHub] [superset] codecov[bot] edited a comment on pull request #15328: fix: downgrade selenium log level on timeout

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 #

[GitHub] [superset] kgabryje commented on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
kgabryje commented on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866815980 @graceguo-supercat Would you like to verify that this PR works properly on Airbnb environments before it's merged? -- This is an automated message from the Apache Git

[GitHub] [superset] dpgaspar opened a new pull request #15328: fix: downgrade selenium log level on timeout

2021-06-23 Thread GitBox
dpgaspar opened a new pull request #15328: URL: https://github.com/apache/superset/pull/15328 ### SUMMARY The majority of `TimeoutException` are triggered due to charts that do not render correctly or take a long time to load data (normally the first) Most of the execution stack

[GitHub] [superset] kgabryje closed pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
kgabryje closed pull request #15324: URL: https://github.com/apache/superset/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 #

[GitHub] [superset] codecov[bot] commented on pull request #15328: fix: downgrade selenium log level on timeout

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 #

[GitHub] [superset] serenajiang merged pull request #15315: fix(api): handle undefined column type_generic

2021-06-23 Thread GitBox
serenajiang merged pull request #15315: URL: https://github.com/apache/superset/pull/15315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] sowo commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
sowo commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r657338240 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as conn:

[GitHub] [superset] michael-s-molina commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
michael-s-molina commented on a change in pull request #15302: URL: https://github.com/apache/superset/pull/15302#discussion_r657296148 ## File path: superset-frontend/src/common/hooks/useComponentDidUpdate/useComponentDidUpdate.ts ## @@ -0,0 +1,34 @@ +/** + * Licensed to the

[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 #

[GitHub] [superset] pkdotson merged pull request #15309: refactor: migrate icon to icons in tablecollection

2021-06-23 Thread GitBox
pkdotson merged pull request #15309: URL: https://github.com/apache/superset/pull/15309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
kgabryje commented on a change in pull request #15302: URL: https://github.com/apache/superset/pull/15302#discussion_r657306915 ## File path: superset-frontend/src/common/hooks/useComponentDidUpdate/useComponentDidUpdate.ts ## @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache

[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 #

[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
kgabryje commented on a change in pull request #15302: URL: https://github.com/apache/superset/pull/15302#discussion_r657306740 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.test.tsx ## @@

[GitHub] [superset] srinify merged pull request #15245: docs: fix hyperlink

2021-06-23 Thread GitBox
srinify merged pull request #15245: URL: https://github.com/apache/superset/pull/15245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 #

[GitHub] [superset] codecov[bot] commented on pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 #

[GitHub] [superset] john-bodley merged pull request #15319: fix: Capitalize time granularity weekdays

2021-06-23 Thread GitBox
john-bodley merged pull request #15319: URL: https://github.com/apache/superset/pull/15319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] serenajiang merged pull request #15285: fix: Revert "build(webpack): use [contenthash] instead of [chunkhash]"

2021-06-23 Thread GitBox
serenajiang merged pull request #15285: URL: https://github.com/apache/superset/pull/15285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] john-bodley commented on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
john-bodley commented on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-867028511 @villebro would you mind re-reviewing this PR? I added all the additional time grains (not just week starting/ending) which have not previously been defined or the SQL

[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 #

[GitHub] [superset] john-bodley edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL

2021-06-23 Thread GitBox
john-bodley edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-867028511 @villebro would you mind re-reviewing this PR? I added all the additional time grains (not just week starting/ending) which have not previously been defined or

[GitHub] [superset] hughhhh opened a new pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
hug opened a new pull request #15334: URL: https://github.com/apache/superset/pull/15334 ### SUMMARY Raising the proper validation errors for BigQuery malformatted request. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ###

[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 #

[GitHub] [superset] hughhhh merged pull request #15334: fix: Big Query Error messaging

2021-06-23 Thread GitBox
hug merged pull request #15334: URL: https://github.com/apache/superset/pull/15334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] rusackas merged pull request #15306: refactor: Icon to icons for certifiedIcon

2021-06-23 Thread GitBox
rusackas merged pull request #15306: URL: https://github.com/apache/superset/pull/15306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] github-actions[bot] commented on pull request #15306: refactor: Icon to icons for certifiedIcon

2021-06-23 Thread GitBox
github-actions[bot] commented on pull request #15306: URL: https://github.com/apache/superset/pull/15306#issuecomment-867148199 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [superset] codecov[bot] edited a comment on pull request #15337: feat: Add validation Errors to bottom alert

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15337: URL: https://github.com/apache/superset/pull/15337#issuecomment-867148577 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 #

[GitHub] [superset] pkdotson opened a new pull request #15336: refactor: icon to icons for basicerror componenet

2021-06-23 Thread GitBox
pkdotson opened a new pull request #15336: URL: https://github.com/apache/superset/pull/15336 ### SUMMARY This pr refactors the basicerror icon to icons. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before

[GitHub] [superset] john-bodley commented on a change in pull request #15184: fix: datasource payload is incorrect

2021-06-23 Thread GitBox
john-bodley commented on a change in pull request #15184: URL: https://github.com/apache/superset/pull/15184#discussion_r657430908 ## File path: superset/connectors/connector_registry.py ## @@ -99,6 +100,41 @@ def get_datasource_by_id( # pylint: disable=too-many-arguments

  1   2   >