Re: the future of notmuch-vim?

2013-04-03 Thread Felipe Contreras
guyzmo wrote: On Tue, Apr 02, 2013 at 01:55:13PM -0600, Felipe Contreras wrote: Sorry for the late reply, I wasn't following the ml. same here David Bremner wrote: - There are now several alternatives for people whose only motivation to use the vim frontend was dislike of emacs

[PATCH] debian: package ruby bindings

2013-04-03 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 14 ++ debian/notmuch-ruby.install | 1 + debian/rules| 9 + 3 files changed, 24 insertions(+) create mode 100644 debian/notmuch-ruby.install diff --git a/debian

Re: the future of notmuch-vim?

2013-04-03 Thread Felipe Contreras
On Wed, Apr 3, 2013 at 3:48 PM, Patrick Totzke patricktot...@gmail.com wrote: Quoting Felipe Contreras (2013-04-03 10:09:39) ... What you prefer is irrelevant; it's relevant only for you, that's why it's called a *preference*, the rest of us prefer different things. Never mind preferences, I

[ANN] notmuch-vim-ruby v0.5

2013-04-03 Thread Felipe Contreras
away are much higher now. And for the people using Arch Linux: https://aur.archlinux.org/packages/vim-notmuch/ Grab it from the usual location: https://github.com/felipec/notmuch-vim-ruby Cheers. Felipe Contreras (9): Add option to save a message Update documentation Add simple

the future of notmuch-vim?

2013-04-02 Thread Felipe Contreras
be open to discuss the options here, but I think notmuch-vim-ruby is the only real option. Cheers. -- Felipe Contreras

[PATCH 0/5] Random patches for notmuch-vim-ruby

2013-04-02 Thread Felipe Contreras
rename g:notmuch_sendmail -> g:notmuch_rb_sendmail > /usr/sbin/sendmail as a default g:notmuch_rb_sendmail > Introduce g:notmuch_rb_folders_count_threads > Drop harmful reply buffer preparation -- Felipe Contreras

[PATCH 5/5] Drop harmful reply buffer preparation

2013-04-02 Thread Felipe Contreras
e lines upwards and remove them. That is of course if you reply *inline*. You might want to reply to the whole thing without modifications, in which case the original behavior is more useful. I'm not strongly opposed to this, but I don't see why those extra lines would hurt. Cheers. -- Felipe Contreras

[PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads

2013-04-02 Thread Felipe Contreras
q.search_messages.count : > q.search_threads.count I prefer: count = count_threads ? q.search_threads.count : q.search_messages.count But other than that looks good to me. Applied. -- Felipe Contreras

[PATCH 3/5] /usr/sbin/sendmail as a default g:notmuch_rb_sendmail

2013-04-02 Thread Felipe Contreras
Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > It's confusing that we don't have a default sendmail program. Let's use > /usr/sbin/sendmail as reasonable default. Applied. -- Felipe Contreras

[PATCH 1/5] open_reply: fallback to use addr.local if addr.name is nil

2013-04-02 Thread Felipe Contreras
ed too, let's just use "somebody". Thanks. Applied. -- Felipe Contreras

[PATCH 2/5] rename g:notmuch_sendmail -> g:notmuch_rb_sendmail

2013-04-02 Thread Felipe Contreras
ch-vim and notmuch-vim-ruby? Wouldn't it be nice to use the same variable for configuration? -- Felipe Contreras

Re: [PATCH 2/5] rename g:notmuch_sendmail - g:notmuch_rb_sendmail

2013-04-02 Thread Felipe Contreras
both notmuch-vim and notmuch-vim-ruby? Wouldn't it be nice to use the same variable for configuration? -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

RE: [PATCH 1/5] open_reply: fallback to use addr.local if addr.name is nil

2013-04-02 Thread Felipe Contreras
. Applied. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

RE: [PATCH 3/5] /usr/sbin/sendmail as a default g:notmuch_rb_sendmail

2013-04-02 Thread Felipe Contreras
Kirill A. Shutemov wrote: From: Kirill A. Shutemov kir...@shutemov.name It's confusing that we don't have a default sendmail program. Let's use /usr/sbin/sendmail as reasonable default. Applied. -- Felipe Contreras ___ notmuch mailing list

RE: [PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads

2013-04-02 Thread Felipe Contreras
prefer: count = count_threads ? q.search_threads.count : q.search_messages.count But other than that looks good to me. Applied. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

RE: [PATCH 5/5] Drop harmful reply buffer preparation

2013-04-02 Thread Felipe Contreras
case the original behavior is more useful. I'm not strongly opposed to this, but I don't see why those extra lines would hurt. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo

RE: [PATCH 0/5] Random patches for notmuch-vim-ruby

2013-04-02 Thread Felipe Contreras
- g:notmuch_rb_sendmail /usr/sbin/sendmail as a default g:notmuch_rb_sendmail Introduce g:notmuch_rb_folders_count_threads Drop harmful reply buffer preparation -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http

RE: the future of notmuch-vim?

2013-04-02 Thread Felipe Contreras
-vim-ruby. I did try the python version, and remember discussing options with the guy developing it, but nothing happened out of it, and I think the ruby version is superior. I'd be open to discuss the options here, but I think notmuch-vim-ruby is the only real option. Cheers. -- Felipe Contreras

gmail label support patch available for oflineimap

2012-11-29 Thread Felipe Contreras
d Maildir, and there are no better alternatives. -- Felipe Contreras

gmail label support patch available for oflineimap

2012-11-29 Thread Felipe Contreras
On Wed, Nov 28, 2012 at 1:53 PM, Michal Nazarewicz wrote: > On Wed, Nov 28 2012, Felipe Contreras wrote: >> Not everybody uses offlineimap. > > Go nag developers of whatever you are using to implement fetching labels > from Gmail. Or write another tool that does that. Why do

gmail label support patch available for oflineimap

2012-11-29 Thread Felipe Contreras
On Wed, Nov 28, 2012 at 12:29 PM, Jani Nikula wrote: > > On Nov 28, 2012 12:10 PM, "Felipe Contreras" > wrote: >> >> On Wed, Nov 28, 2012 at 8:32 AM, Rainer M Krug wrote: >> >> >> I just want to say that having notmuch communicate with Gmail is

gmail label support patch available for oflineimap

2012-11-28 Thread Felipe Contreras
cult to read the labels and to store them > in e.g. a sqlite > database for each message id. This could then be written back as well, and > only the [GMAIL] folder > would have to be synchronised, i.e. no duplication. Not everybody uses offlineimap. -- Felipe Contreras

Re: gmail label support patch available for oflineimap

2012-11-28 Thread Felipe Contreras
message id. This could then be written back as well, and only the [GMAIL] folder would have to be synchronised, i.e. no duplication. Not everybody uses offlineimap. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http

Re: gmail label support patch available for oflineimap

2012-11-28 Thread Felipe Contreras
On Wed, Nov 28, 2012 at 1:53 PM, Michal Nazarewicz min...@mina86.com wrote: On Wed, Nov 28 2012, Felipe Contreras wrote: Not everybody uses offlineimap. Go nag developers of whatever you are using to implement fetching labels from Gmail. Or write another tool that does that. Why do

Re: gmail label support patch available for oflineimap

2012-11-28 Thread Felipe Contreras
IMAP and Maildir, and there are no better alternatives. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[ANNOUNCE] notmuchfs - A virtual maildir file system for notmuch queries

2012-10-01 Thread Felipe Contreras
ing the query >> results. >> > > Well, since nobody else said it, let me be the first to say, that's a > pretty cool hack! I agree. Genius :) -- Felipe Contreras

Re: [ANNOUNCE] notmuchfs - A virtual maildir file system for notmuch queries

2012-10-01 Thread Felipe Contreras
be the first to say, that's a pretty cool hack! I agree. Genius :) -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[ANN] notmuch vim ruby v0.4

2012-06-04 Thread Felipe Contreras
On Mon, Jun 4, 2012 at 1:51 PM, Kirill A. Shutemov wrote: > On Mon, Jun 04, 2012 at 12:35:21PM +0200, Felipe Contreras wrote: >> Hi, >> >> Here's a new version of notmuch-vim-ruby, a new attempt to have a >> proper vim interface for notmuch. > > Hm. No

[ANN] notmuch vim ruby v0.4

2012-06-04 Thread Felipe Contreras
some on the encoding of outgoing messages that I haven't managed to nail down, but I don't want to hold this release because of that. There's plenty of good stuff already, and this plugin works perfectly fine for me as it is. Cheers. -- Felipe Contreras

Re: [ANN] notmuch vim ruby v0.4

2012-06-04 Thread Felipe Contreras
On Mon, Jun 4, 2012 at 1:51 PM, Kirill A. Shutemov kir...@shutemov.name wrote: On Mon, Jun 04, 2012 at 12:35:21PM +0200, Felipe Contreras wrote: Hi, Here's a new version of notmuch-vim-ruby, a new attempt to have a proper vim interface for notmuch. Hm. No links? Oops! I knew that message

Can't compile notmuch-delivery

2012-06-01 Thread Felipe Contreras
n notmuch_database_open2, mark the old one as deprecated (but still works), and only after some time obsolete it. Cheers. -- Felipe Contreras

Can't compile notmuch-delivery

2012-06-01 Thread Felipe Contreras
r of reverting these changes, and possibly put them in a separate branch, until they are ready (as in all notmuch code compiles). Cheers. -- Felipe Contreras

Re: Can't compile notmuch-delivery

2012-06-01 Thread Felipe Contreras
in a separate branch, until they are ready (as in all notmuch code compiles). Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: Can't compile notmuch-delivery

2012-06-01 Thread Felipe Contreras
as deprecated (but still works), and only after some time obsolete it. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-25 Thread Felipe Contreras
On Thu, May 24, 2012 at 10:56 AM, Felipe Contreras wrote: > On Thu, May 24, 2012 at 3:22 AM, David Bremner wrote: >> I do plan on a bug fix release, to fix an annoying emacs interface bug >> if nothing else. I'd rather see a fix/revert coordinated with Ali in his >>

Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-25 Thread Felipe Contreras
On Thu, May 24, 2012 at 10:56 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, May 24, 2012 at 3:22 AM, David Bremner da...@tethera.net wrote: I do plan on a bug fix release, to fix an annoying emacs interface bug if nothing else. I'd rather see a fix/revert coordinated with Ali

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
On Thu, May 24, 2012 at 3:22 AM, David Bremner wrote: > Felipe Contreras writes: > > >> I don't see how this patch could be fixed properly easily, and it was >> labeled as a hack, and I didn't like it in the first place anyway, so >> I'm going to revert it by tomorr

[ANN] New awesome vim plug-in using Ruby bindings

2012-05-24 Thread Felipe Contreras
: Add workarounds to use in-tree build not the installed one). Please use v0.12. Cheers. -- Felipe Contreras

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
t hear any good reason not to. I also suggest making a brown-paper-bag release 0.13.1 because 0.13 has completely unusable Ruby bindings; there's just no way to compile them and make them work. Cheers. -- Felipe Contreras

Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
On Thu, May 24, 2012 at 3:22 AM, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: I don't see how this patch could be fixed properly easily, and it was labeled as a hack, and I didn't like it in the first place anyway, so I'm going to revert

Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-23 Thread Felipe Contreras
if I don't hear any good reason not to. I also suggest making a brown-paper-bag release 0.13.1 because 0.13 has completely unusable Ruby bindings; there's just no way to compile them and make them work. Cheers. -- Felipe Contreras ___ notmuch mailing

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-05-23 Thread Felipe Contreras
one). Please use v0.12. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[ANN] New awesome vim plug-in using Ruby bindings

2012-05-15 Thread Felipe Contreras
linux/notmuch.so' shows? Looks like some C++ stuff is missing somehow. -- Felipe Contreras

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-05-15 Thread Felipe Contreras
somehow. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[ANN] New awesome vim plug-in using Ruby bindings

2012-05-14 Thread Felipe Contreras
On Sun, Apr 29, 2012 at 12:52 AM, Alex Ghitza wrote: > Felipe Contreras wrote: >> > vim -c ':NotMuchR' >> > >> > all I get is an error message: >> > >> > Error detected while processing command line: >> > E492: Not an editor command: :NotMu

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-05-14 Thread Felipe Contreras
On Sun, Apr 29, 2012 at 12:52 AM, Alex Ghitza aghi...@gmail.com wrote: Felipe Contreras wrote: vim -c ':NotMuchR' all I get is an error message: Error detected while processing command line: E492: Not an editor command: :NotMuchR I don't know if you did anything special to get

vim plugin development -- GIT branch?

2012-05-04 Thread Felipe Contreras
ve some pending patches myself, but I haven't made them public anywhere (still cooking). So there's nothing pending to push. I haven't heard any feedback from anybody else regarding the vim/ruby/python situation, so I don't know what's going to happen next. Cheers. -- Felipe Contreras

[ANN] New awesome vim plug-in using Ruby bindings

2012-05-04 Thread Felipe Contreras
On Wed, May 2, 2012 at 10:41 PM, Anton Khirnov wrote: > > On Mon, 23 Apr 2012 04:12:32 +0300, Felipe Contreras gmail.com> wrote: >> ?* Gradual searches; you don't have to wait for the whole search to finish, >> ? ?sort of like the 'less' command > > How did you

[RFC] vim plugin rewrite II

2012-05-04 Thread Felipe Contreras
I'm not getting any crashes here. On any exception in the > python code it prints the backtrace and continues normally. I don't > think I've ever seen it actually crash (not counting my ultimately > unsuccessfull attempts at threading). I wonder what could cause this. Interesting. I would need to check that, but I don't have time right now =/ Cheers. -- Felipe Contreras

Re: [RFC] vim plugin rewrite II

2012-05-04 Thread Felipe Contreras
normally. I don't think I've ever seen it actually crash (not counting my ultimately unsuccessfull attempts at threading). I wonder what could cause this. Interesting. I would need to check that, but I don't have time right now =/ Cheers. -- Felipe Contreras

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-05-04 Thread Felipe Contreras
On Wed, May 2, 2012 at 10:41 PM, Anton Khirnov an...@khirnov.net wrote: On Mon, 23 Apr 2012 04:12:32 +0300, Felipe Contreras felipe.contre...@gmail.com wrote:  * Gradual searches; you don't have to wait for the whole search to finish,    sort of like the 'less' command How did you do

Re: vim plugin development -- GIT branch?

2012-05-04 Thread Felipe Contreras
some pending patches myself, but I haven't made them public anywhere (still cooking). So there's nothing pending to push. I haven't heard any feedback from anybody else regarding the vim/ruby/python situation, so I don't know what's going to happen next. Cheers. -- Felipe Contreras

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-28 Thread Felipe Contreras
aybe you are doing 'source ~/.vim/plugin/notmuch.vim' directly in your .vimrc, if so, you can try to do the same with notmuch vim ruby. What I have is 'filetype plugin on'. Cheers. -- Felipe Contreras

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-26 Thread Felipe Contreras
2012/4/23 Felipe Contreras : > So, since I'm a big fan of Ruby, I decided to try my luck writing a > plug-in from scratch. It took me one weekend, but I'm pretty happy > with the result. This plug-in has already essentially all the > functionality of the current one, but it's much, *m

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-04-25 Thread Felipe Contreras
2012/4/23 Felipe Contreras felipe.contre...@gmail.com: So, since I'm a big fan of Ruby, I decided to try my luck writing a plug-in from scratch. It took me one weekend, but I'm pretty happy with the result. This plug-in has already essentially all the functionality of the current one, but it's

[PATCH] ruby: make sure the database is closed

2012-04-24 Thread Felipe Contreras
On Tue, Apr 24, 2012 at 4:15 AM, Austin Clements wrote: > Quoth Felipe Contreras on Apr 24 at ?3:45 am: >> On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel wrote: >> > 2012/4/24 Felipe Contreras : >> >> >> Personally I don't see why an object, like say a query

[PATCH] ruby: make sure the database is closed

2012-04-24 Thread Felipe Contreras
On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel wrote: > 2012/4/24 Felipe Contreras : >> Personally I don't see why an object, like say a query would remain >> working correctly after the database is gone, either by calling >> .close() directly, or just loosing the pointer t

[PATCH] ruby: make sure the database is closed

2012-04-24 Thread Felipe Contreras
On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel wrote: > 2012/4/23 Felipe Contreras : >> On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel wrote: >> >>> I'd rather not do this. >>> Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324 >> >

Re: [PATCH] ruby: make sure the database is closed

2012-04-24 Thread Felipe Contreras
On Tue, Apr 24, 2012 at 4:15 AM, Austin Clements amdra...@mit.edu wrote: Quoth Felipe Contreras on Apr 24 at  3:45 am: On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel a...@exherbo.org wrote: 2012/4/24 Felipe Contreras felipe.contre...@gmail.com: Personally I don't see why an object, like say

ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

2012-04-23 Thread Felipe Contreras
86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fPIC -o messages.o -c messages.c -- Felipe Contreras

[PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c |8 +++- 1 file

[PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c |8 +++- 1 file

[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

2012-04-23 Thread Felipe Contreras
-20,10 +20,16 @@ #include "defs.h" +static void +database_free (void *p) +{ +notmuch_database_destroy (p); +} + VALUE notmuch_rb_database_alloc (VALUE klass) { -return Data_Wrap_Struct (klass, NULL, NULL, NULL); +return Data_Wrap_Struct (klass, NULL, database_free, NULL); } /* -- Felipe Contreras

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-23 Thread Felipe Contreras
Hi, If you reply to all, remove Ryan Harper, as the address doesn't work. Or just reply here. Cheers. 2012/4/23 Felipe Contreras : > I've never been particularly happy with the code of the vim plug-in, > but it sort of did the job, after some fixes, and has been working > great so far

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-23 Thread Felipe Contreras
On Mon, Apr 23, 2012 at 6:41 AM, Adam Wolfe Gordon <awg+notmuch at xvx.ca> wrote: > Hi Felipe, > > This work sounds nice - it's good to have lots of interface choices. > One question below: > > On Sun, Apr 22, 2012 at 19:12, Felipe Contreras > wrote: >> doesn't

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-23 Thread Felipe Contreras
-- Felipe Contreras

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-04-23 Thread Felipe Contreras
On Mon, Apr 23, 2012 at 6:41 AM, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Hi Felipe, This work sounds nice - it's good to have lots of interface choices. One question below: On Sun, Apr 22, 2012 at 19:12, Felipe Contreras felipe.contre...@gmail.com wrote: doesn't have support

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-04-23 Thread Felipe Contreras
Hi, If you reply to all, remove Ryan Harper, as the address doesn't work. Or just reply here. Cheers. 2012/4/23 Felipe Contreras felipe.contre...@gmail.com: I've never been particularly happy with the code of the vim plug-in, but it sort of did the job, after some fixes, and has been working

Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

2012-04-23 Thread Felipe Contreras
notmuch_rb_database_alloc (VALUE klass) { -return Data_Wrap_Struct (klass, NULL, NULL, NULL); +return Data_Wrap_Struct (klass, NULL, database_free, NULL); } /* -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http

[PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- bindings/ruby/database.c

Re: ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

2012-04-23 Thread Felipe Contreras
=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fPIC -o messages.o -c messages.c -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- bindings/ruby/database.c

Re: [PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
db = Notmuch::Database.new($db_name, :mode = Notmuch::MODE_READ_WRITE) end That's perfectly fine in Ruby (although not ideal), since 'db' will get garbage-collected. But nobody will be able to use the database again until that process is killed. You think that's correct? -- Felipe Contreras

Re: [PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel a...@exherbo.org wrote: 2012/4/23 Felipe Contreras felipe.contre...@gmail.com: On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel a...@exherbo.org wrote: I'd rather not do this. Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324

Re: [PATCH] ruby: make sure the database is closed

2012-04-23 Thread Felipe Contreras
On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel a...@exherbo.org wrote: 2012/4/24 Felipe Contreras felipe.contre...@gmail.com: Personally I don't see why an object, like say a query would remain working correctly after the database is gone, either by calling .close() directly, or just loosing

[PATCH 2/7] NEWS: Document the notmuch_database_close split

2012-04-22 Thread Felipe Contreras
e lock associated with it without > + ?destroying the data structures obtained from it. > + I haven't following this change. Who can an application take advantage of this? I call _close(), now what do I do to use the database again? Cheers. -- Felipe Contreras

Re: [PATCH 2/7] NEWS: Document the notmuch_database_close split

2012-04-22 Thread Felipe Contreras
an application take advantage of this? I call _close(), now what do I do to use the database again? Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-22 Thread Felipe Contreras
-- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] vim: fix regex after "notmuch show" output change

2012-04-21 Thread Felipe Contreras
? ? ? ? ?let msg['filename'] = m[4] > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?let msg['excluded'] = m[4] > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?let msg['filename'] = m[5] > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? endif > > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? let in_message = 1 > -- Thanks. Pushed. -- Felipe Contreras

[PATCH] vim: simplify build

2012-04-21 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 7:03 PM, Tomi Ollila wrote: > So, $(CURDIR) has 3 votes :D All right. Pushed :) -- Felipe Contreras

Re: [PATCH] vim: simplify build

2012-04-20 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 7:03 PM, Tomi Ollila tomi.oll...@iki.fi wrote: So, $(CURDIR) has 3 votes :D All right. Pushed :) -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] vim: fix regex after notmuch show output change

2012-04-20 Thread Felipe Contreras
] +                                        let msg['filename'] = m[5]                                 endif                                 let in_message = 1 -- Thanks. Pushed. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http

[RFC] vim plugin rewrite II

2012-04-19 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 5:42 PM, Felipe Contreras wrote: > On Wed, Apr 18, 2012 at 5:21 PM, Felipe Contreras > wrote: >> On Sat, Jan 14, 2012 at 9:54 AM, ? wrote: >>> branch vim. Simply copy vim/plugin/{nm_vim.py,notmuch-vimpy.vim} to the >>> vim plugins dir and vim

[PATCH v2 1/3] Add 'compose' command

2012-04-19 Thread Felipe Contreras
On Thu, Apr 19, 2012 at 12:31 PM, Tomi Ollila wrote: > On Wed, Apr 18 2012, Jani Nikula wrote: > >> On Wed, 18 Apr 2012, Felipe Contreras wrote: >>> On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula wrote: >>>> On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras &

Re: [PATCH v2 1/3] Add 'compose' command

2012-04-19 Thread Felipe Contreras
On Thu, Apr 19, 2012 at 12:31 PM, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Apr 18 2012, Jani Nikula j...@nikula.org wrote: On Wed, 18 Apr 2012, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula j...@nikula.org wrote: On Wed, 18 Apr 2012 16:34

Re: [RFC] vim plugin rewrite II

2012-04-19 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 5:42 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 18, 2012 at 5:21 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Jan 14, 2012 at 9:54 AM,  an...@khirnov.net wrote: branch vim. Simply copy vim/plugin/{nm_vim.py,notmuch-vimpy.vim

[PATCH v2 2/3] reply: add message-id header

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 4:09 PM, Jani Nikula wrote: > On Wed, 18 Apr 2012 15:39:12 +0300, Felipe Contreras gmail.com> wrote: >> Signed-off-by: Felipe Contreras >> --- >> ?notmuch-reply.c | ? 11 +++ >> ?1 file changed, 11 insertions(+) >> >> diff

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila wrote: > On Wed, Apr 18 2012, David Bremner wrote: > >> Felipe Contreras writes: >>>> If this is not an issue, then LGTM. >>> >>> I don't know, I have always used $(PWD), unless anybody else prefers >>&

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 5:41 PM, Dmitry Kurochkin wrote: > Felipe Contreras writes: > >> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin >> wrote: >>> Hi Felipe. >>> >>> Felipe Contreras writes: >>> >>>> On Wed, Apr 18, 2012 a

[RFC] vim plugin rewrite II

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 5:21 PM, Felipe Contreras wrote: > On Sat, Jan 14, 2012 at 9:54 AM, ? wrote: >> branch vim. Simply copy vim/plugin/{nm_vim.py,notmuch-vimpy.vim} to the >> vim plugins dir and vim/syntax/{nm_vimpy*} to the vim syntax dir and run >> :NMVimpy() in

[RFC] vim plugin rewrite II

2012-04-18 Thread Felipe Contreras
e this a try, copying those files makes vim crash for me. I probably need to install notmuch's python bindings, but either way it shouldn't crash. Cheers. -- Felipe Contreras

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin wrote: > Hi Felipe. > > Felipe Contreras writes: > >> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: >> >>> Running "notmuch compose" more than once within a second would result in >&g

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 4:11 PM, Tomi Ollila wrote: > On Wed, Apr 18 2012, Felipe Contreras wrote: > >> There should be no functional changes, except that you don't need to >> make the directories before installing. >> >> Signed-off-by: Felipe Contreras >&g

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Felipe Contreras
g. In any case, people that have not needed this would not be affected; their UI would override the Message-ID. So do you have a better suggestion for a Message-ID? -- Felipe Contreras

[PATCH v2 3/3] reply: add user-agent field

2012-04-18 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- notmuch-reply.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index d796bb2..22838d5 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -464,7 +464,7 @@ create_reply_message(void *ctx

[PATCH v2 2/3] reply: add message-id header

2012-04-18 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- notmuch-reply.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/notmuch-reply.c b/notmuch-reply.c index 0949d9f..d796bb2 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -464,6 +464,8 @@ create_reply_message(void *ctx, { const

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- Makefile.local|1 + notmuch-client.h |3 ++ notmuch-compose.c | 111 + notmuch.c |5 +++ 4 files changed, 120 insertions(+) create mode 100644 notmuch-compose.c diff --git

[PATCH v2 0/3] composing patches

2012-04-18 Thread Felipe Contreras
be used while generating the 'notmuch search' output. Although we are adding extra fields in notmuch reply, higher layers can just override them easily. Felipe Contreras (3): Add 'compose' command reply: add message-id header reply: add user-agent field Makefile.local|1 + notmuch

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
There should be no functional changes, except that you don't need to make the directories before installing. Signed-off-by: Felipe Contreras --- vim/Makefile | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/vim/Makefile b/vim/Makefile index 89e18be

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
There should be no functional changes, except that you don't need to make the directories before installing. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/Makefile | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/vim/Makefile b/vim

<    1   2   3   4   5   6   7   >